Re: [PATCH v3 04/16] soc: mediatek: pm-domains: Add bus protection protocol

2020-10-30 Thread Enric Balletbo i Serra
Hi Weiyi Lu, Many thanks for your comments. On 27/10/20 12:07, Weiyi Lu wrote: > On Mon, 2020-10-26 at 18:55 +0100, Enric Balletbo i Serra wrote: >> From: Matthias Brugger >> >> Bus protection will need to update more then one register >> in infracfg. Add sup

Re: [PATCH v3 02/16] soc: mediatek: Add MediaTek SCPSYS power domains

2020-10-30 Thread Enric Balletbo i Serra
Hi Nicolas, Thank you for your comments. On 27/10/20 1:55, Nicolas Boichat wrote: > On Tue, Oct 27, 2020 at 1:55 AM Enric Balletbo i Serra > wrote: >> >> The System Control Processor System (SCPSYS) has several power management >> related tasks in the system. This d

Re: [PATCH v2 02/12] soc: mediatek: Add MediaTek SCPSYS power domains

2020-10-30 Thread Enric Balletbo i Serra
Hi Nicolas, On 28/10/20 2:13, Nicolas Boichat wrote: > On Wed, Oct 28, 2020 at 12:25 AM Enric Balletbo i Serra > wrote: >> >> Hi Nicolas, >> >> On 27/10/20 1:19, Nicolas Boichat wrote: >>> Hi Enric, >>> >>> On Mon, Oct 26, 2020 at 11:17 P

[PATCH] mfd: syscon: Add syscon_regmap_lookup_by_phandle_optional() function.

2020-10-27 Thread Enric Balletbo i Serra
the regmap phandle is optional. Suggested-by: Nicolas Boichat Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/syscon.c | 13 + include/linux/mfd/syscon.h | 11 +++ 2 files changed, 24 insertions(+) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index

Re: [PATCH v2 02/12] soc: mediatek: Add MediaTek SCPSYS power domains

2020-10-27 Thread Enric Balletbo i Serra
Hi Nicolas, On 27/10/20 1:19, Nicolas Boichat wrote: > Hi Enric, > > On Mon, Oct 26, 2020 at 11:17 PM Enric Balletbo i Serra > wrote: >> >> Hi Nicolas, >> >> Many thanks for looking at this. > > Thanks to you ,-) > > [snip] >

[PATCH v5] dt-bindings: power: rockchip: Convert to json-schema

2020-10-26 Thread Enric Balletbo i Serra
Convert the soc/rockchip/power_domain.txt binding document to json-schema and move to the power bindings directory. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Rob Herring --- Changes in v5: - Fix space warnings reported by bot. - Add the Rob's Reviewed-by tag. - Fix license. Changes

[PATCH v3 04/16] soc: mediatek: pm-domains: Add bus protection protocol

2020-10-26 Thread Enric Balletbo i Serra
From: Matthias Brugger Bus protection will need to update more then one register in infracfg. Add support for several operations. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: None drivers/soc/mediatek/mt8173-pm-domains.h | 4

[PATCH v3 12/16] arm64: dts: mediatek: Add smi_common node for MT8183

2020-10-26 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: None arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 9cfd961c45eb

[PATCH v3 05/16] soc: mediatek: pm_domains: Make bus protection generic

2020-10-26 Thread Enric Balletbo i Serra
From: Matthias Brugger Bus protection is not exclusively done by calling the infracfg misc driver. Make the calls for setting and clearing the bus protection generic so that we can use other blocks for it as well. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra

[PATCH v3 03/16] arm64: dts: mediatek: Add mt8173 power domain controller

2020-10-26 Thread Enric Balletbo i Serra
Add power domain controller node for SoC mt8173. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: - Add a scpsys syscon node as parent and a SPM (System Power Manager) as a child. arch/arm64/boot/dts/mediatek/mt8173.dtsi | 164 --- 1 file

[PATCH v3 07/16] soc: mediatek: pm-domains: Add extra sram control

2020-10-26 Thread Enric Balletbo i Serra
: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: - Nit, split readl(ctl_addr) | pd->data->sram_pdn_bits in two lines. - Use regmap API drivers/soc/mediatek/mtk-pm-domains.c | 25 +++-- drivers/soc/mediatek/mtk-pm-domains.h

[PATCH v3 13/16] arm64: dts: mediatek: Add mt8183 power domains controller

2020-10-26 Thread Enric Balletbo i Serra
From: Matthias Brugger Add power domains controller node for SoC mt8183 Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: None arch/arm64/boot/dts/mediatek/mt8183.dtsi | 162 +++ 1 file changed, 162 insertions

[PATCH v3 16/16] soc: mediatek: pm-domains: Add support for mt8192

2020-10-26 Thread Enric Balletbo i Serra
From: Weiyi Lu Add the needed board data to support mt8192 SoC. Signed-off-by: Weiyi Lu Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: None drivers/soc/mediatek/mt8192-pm-domains.h | 292 +++ drivers/soc/mediatek/mtk-pm-domains.c| 5

[PATCH v3 01/16] dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains controller

2020-10-26 Thread Enric Balletbo i Serra
The System Control Processor System (SCPSYS) has several power management related tasks in the system. Add the bindings to define the power domains for the SCPSYS power controller. Co-developed-by: Matthias Brugger Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra

[PATCH v3 02/16] soc: mediatek: Add MediaTek SCPSYS power domains

2020-10-26 Thread Enric Balletbo i Serra
-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Return only a boolean for scpsys_domain_is_on() - Use regmap_update_bits API when possible. - Add some logic to make sure scpsys->domains[id] == NULL or != NULL when needed. - Return the child n

[PATCH v3 10/16] dt-bindings: power: Add MT8183 power domains

2020-10-26 Thread Enric Balletbo i Serra
Add power domains dt-bindings for MT8183. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: None .../power/mediatek,power-controller.yaml | 2 ++ include/dt-bindings/power/mt8183-power.h | 26 +++ 2 files

[PATCH v3 06/16] soc: mediatek: pm-domains: Add SMI block as bus protection block

2020-10-26 Thread Enric Balletbo i Serra
From: Matthias Brugger Apart from the infracfg block, the SMI block is used to enable the bus protection for some power domains. Add support for this block. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Do not reuse bpd for 2 different things

[PATCH v3 14/16] dt-bindings: power: Add MT8192 power domains

2020-10-26 Thread Enric Balletbo i Serra
From: Weiyi Lu Add power domains dt-bindings for MT8192. Signed-off-by: Weiyi Lu Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: None .../power/mediatek,power-controller.yaml | 2 ++ include/dt-bindings/power/mt8192-power.h | 32

[PATCH v3 15/16] soc: mediatek: pm-domains: Add default power off flag

2020-10-26 Thread Enric Balletbo i Serra
-by: Weiyi Lu Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: None drivers/soc/mediatek/mtk-pm-domains.c | 23 +-- drivers/soc/mediatek/mtk-pm-domains.h | 1 + 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/soc/mediatek

[PATCH v3 11/16] soc: mediatek: pm-domains: Add support for mt8183

2020-10-26 Thread Enric Balletbo i Serra
From: Matthias Brugger Add the needed board data to support mt8183 SoC. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Do not remove mmsys from of_device_id. That's part of another patchset. - Move the soc specific data to separate include files

[PATCH v3 09/16] soc: mediatek: pm-domains: Allow bus protection to ignore clear ack

2020-10-26 Thread Enric Balletbo i Serra
From: Matthias Brugger In some cases the hardware does not create an acknowledgment of the bus protection clearing. Add a flag to the bus protection indicating that a clear event will be ignored. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None

[PATCH v3 08/16] soc: mediatek: pm-domains: Add subsystem clocks

2020-10-26 Thread Enric Balletbo i Serra
Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Prepare the basic clocks before we prepare the subsystem clocks. Changes in v2: - Use dev_err_probe if getting clocks fails, so an error is not printed if is deferred. drivers/soc/mediatek/mtk-pm-domains.c | 83

[PATCH v3 00/16] soc: mediatek: pm-domains: Add new driver for SCPSYS power domains controller

2020-10-26 Thread Enric Balletbo i Serra
regards, Enric Enric Balletbo i Serra (5): dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains controller soc: mediatek: Add MediaTek SCPSYS power domains arm64: dts: mediatek: Add mt8173 power domain controller dt-bindings: power: Add MT8183 power domains arm64

Re: [PATCH v2 06/12] soc: mediatek: pm-domains: Add SMI block as bus protection block

2020-10-26 Thread Enric Balletbo i Serra
Hi Nicolas, Thank you for your review. On 5/10/20 3:48, Nicolas Boichat wrote: > On Fri, Oct 2, 2020 at 4:56 PM Matthias Brugger > wrote: >> >> >> >> On 01/10/2020 18:01, Enric Balletbo i Serra wrote: >>> From: Matthias Brugger >>> >>

Re: [PATCH v2 08/12] soc: mediatek: pm-domains: Add subsystem clocks

2020-10-26 Thread Enric Balletbo i Serra
Hi Matthias, Thank you for your review. On 2/10/20 11:04, Matthias Brugger wrote: > > > On 01/10/2020 18:01, Enric Balletbo i Serra wrote: >> From: Matthias Brugger >> >> For the bus protection operations, some subsystem clocks need to be enabled >> before rel

Re: [PATCH v2 06/12] soc: mediatek: pm-domains: Add SMI block as bus protection block

2020-10-26 Thread Enric Balletbo i Serra
Hi Matthias, Thank you for your review. On 2/10/20 10:56, Matthias Brugger wrote: > > > On 01/10/2020 18:01, Enric Balletbo i Serra wrote: >> From: Matthias Brugger >> >> Apart from the infracfg block, the SMI block is used to enable the bus >> protection fo

Re: [PATCH 07/12] soc: mediatek: pm-domains: Add extra sram control

2020-10-26 Thread Enric Balletbo i Serra
Hi Matthias, On 10/9/20 20:27, Matthias Brugger wrote: > > > On 10/09/2020 19:28, Enric Balletbo i Serra wrote: >> From: Matthias Brugger >> >> For some power domains like vpu_core on MT8183 whose sram need to do clock >> and internal isolation whil

Re: [PATCH v2 02/12] soc: mediatek: Add MediaTek SCPSYS power domains

2020-10-26 Thread Enric Balletbo i Serra
Hi Nicolas, Many thanks for looking at this. On 5/10/20 3:39, Nicolas Boichat wrote: > On Fri, Oct 2, 2020 at 12:02 AM Enric Balletbo i Serra > wrote: >> >> The System Control Processor System (SCPSYS) has several power management >> related tasks in the system. This d

Re: [PATCH] arm64: dts: mediatek: Add smi_common node for MT8183

2020-10-15 Thread Enric Balletbo i Serra
Hi Matthias, On 2/10/20 11:17, Matthias Brugger wrote: > > > On 01/10/2020 18:28, Enric Balletbo i Serra wrote: >> The SMI (Smart Multimedia Interface) Common is a bridge between the m4u >> (Multimedia Memory Management Unit) and the Multimedia HW. This block is >>

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-15 Thread Enric Balletbo i Serra
Hi Matthias and Chun-Kuang, On 11/10/20 4:22, Chun-Kuang Hu wrote: > Hi, Matthias: > > Matthias Brugger 於 2020年10月8日 週四 下午6:22寫道: >> >> Hi Enric and CK, >> >> On 06/10/2020 21:33, Enric Balletbo i Serra wrote: >>> From: CK Hu >>> >>&g

[PATCH v4] dt-bindings: power: rockchip: Convert to json-schema

2020-10-15 Thread Enric Balletbo i Serra
Convert the soc/rockchip/power_domain.txt binding document to json-schema and move to the power bindings directory. Signed-off-by: Enric Balletbo i Serra --- Rob, I didn't add a number of clocks neither a number of pm_qos because will be a finger in the air number. If you still want I add it, I

Re: [PATCH v6 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

2020-10-11 Thread Enric Balletbo i Serra
Hi Duncan, On 11/10/20 18:35, Duncan Laurie wrote: > On Sun, Oct 11, 2020 at 4:59 AM Enric Balletbo i Serra > mailto:enric.balle...@collabora.com>> wrote: > > Hi Bhanu, > > Thank you for your patch. > > On 9/10/20 23:01, Bhanu Prakash Maiya wrote: &g

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Enric Balletbo i Serra
Hi Borislav, On 11/10/20 17:57, Borislav Petkov wrote: > On Sun, Oct 11, 2020 at 05:40:27PM +0200, Enric Balletbo i Serra wrote: >> How do you quantify those things are NOT common enough? Do you have a number? > > I don't want to change the defconfig - you do. So quantifying is

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Enric Balletbo i Serra
Hi Borislav, On 11/10/20 14:20, Borislav Petkov wrote: > On Sun, Oct 11, 2020 at 01:43:44PM +0200, Enric Balletbo i Serra wrote: >> We're also probably lacking a definition of what normal users mean, because I >> don't think normal users build their own kernel. > > You'd

Re: [PATCH v6 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

2020-10-11 Thread Enric Balletbo i Serra
umentation/devicetree/bindings/mfd/google,cros-ec.yaml > +++ b/Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > @@ -10,11 +10,12 @@ maintainers: >- Benson Leung >- Enric Balletbo i Serra >- Guenter Roeck > + - Bhanu Prakash Maiya > > descript

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Enric Balletbo i Serra
Hi Borislav and Randy, Thank you for your comments. On 8/10/20 20:31, Randy Dunlap wrote: > On 10/8/20 9:40 AM, Borislav Petkov wrote: >> On Thu, Oct 08, 2020 at 06:22:06PM +0200, Enric Balletbo i Serra wrote: >>> As part of KernelCI, we added a bunch of different x86 based Chr

Re: [PATCH v3] dt-bindings: power: rockchip: Convert to json-schema

2020-10-11 Thread Enric Balletbo i Serra
On 11/10/20 11:56, Enric Balletbo i Serra wrote: > Hi Rob, > > Many thanks for your comments, some questions below. > > On 7/10/20 17:11, Rob Herring wrote: >> On Mon, Sep 21, 2020 at 11:29:51AM +0200, Enric Balletbo i Serra wrote: >>> Convert the soc/roc

Re: [PATCH v3] dt-bindings: power: rockchip: Convert to json-schema

2020-10-11 Thread Enric Balletbo i Serra
Hi Rob, Many thanks for your comments, some questions below. On 7/10/20 17:11, Rob Herring wrote: > On Mon, Sep 21, 2020 at 11:29:51AM +0200, Enric Balletbo i Serra wrote: >> Convert the soc/rockchip/power_domain.txt binding document to json-schema >> and move to the power bin

Re: [PATCH v3] dt-bindings: power: rockchip: Convert to json-schema

2020-10-11 Thread Enric Balletbo i Serra
Hi Rob, On 8/10/20 21:47, Rob Herring wrote: > On Wed, Oct 7, 2020 at 3:57 PM Enric Balletbo Serra > wrote: >> >> Hi Rob, >> >> Missatge de Rob Herring del dia dc., 7 d’oct. 2020 a >> les 17:12: >>> >>> On Mon, Sep 21, 2020 at 11:29:

Re: [PATCH 00/12] soc: mediatek: pm-domains: Add new driver for SCPSYS power domains controller

2020-10-09 Thread Enric Balletbo i Serra
Hi, On 9/10/20 14:50, Matthias Brugger wrote: > > > On 06/10/2020 08:53, Weiyi Lu wrote: >> On Fri, 2020-09-25 at 16:04 +0200, Matthias Brugger wrote: >>> >>> On 25/09/2020 12:06, Weiyi Lu wrote: >>>> On Thu, 2020-09-10 at 19:28 +0200,

[PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-08 Thread Enric Balletbo i Serra
Gleixner Cc: Ingo Molnar Signed-off-by: Enric Balletbo i Serra --- arch/x86/configs/x86_64_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/x86/configs/x86_64_defconfig b/arch/x86/configs/x86_64_defconfig index 9936528e1939..c43f61a8059c 100644 --- a/arch/x86/configs

Re: [PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-08 Thread Enric Balletbo i Serra
Hi Chun-Kuang, On 8/10/20 2:01, Chun-Kuang Hu wrote: > Hi, Enric: > > Enric Balletbo i Serra 於 2020年10月7日 週三 > 上午3:33寫道: >> >> From: CK Hu >> >> Actually, setting the registers for routing, use multiple 'if-else' for >> different >> routes,

[PATCH 0/4] soc: mediatek: Prepare MMSYS for DDP routing using tables

2020-10-06 Thread Enric Balletbo i Serra
struct mtk_mmsys to store context data soc: mediatek: mmsys: Use an array for setting the routing registers Enric Balletbo i Serra (1): soc: mediatek: mmsys: Use devm_platform_ioremap_resource() Yongqiang Niu (1): soc / drm: mediatek: Move DDP component defines into mtk-mmsys.h drivers/gpu

[PATCH 2/4] soc: mediatek: mmsys: Use devm_platform_ioremap_resource()

2020-10-06 Thread Enric Balletbo i Serra
For the common platform_get_resource()+devm_platform_ioremap() combination, there is a helper, so use it and make the code a bit more compact. Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek/mtk-mmsys.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

[PATCH 1/4] soc / drm: mediatek: Move DDP component defines into mtk-mmsys.h

2020-10-06 Thread Enric Balletbo i Serra
From: Yongqiang Niu MMSYS is the driver which controls the routing of these DDP components, so the definition of the mtk_ddp_comp_id enum should be placed in mtk-mmsys.h Signed-off-by: Yongqiang Niu Reviewed-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- This patch

[PATCH 4/4] soc: mediatek: mmsys: Use an array for setting the routing registers

2020-10-06 Thread Enric Balletbo i Serra
Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek/mtk-mmsys.c | 393 +-- 1 file changed, 210 insertions(+), 183 deletions(-) diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c index da2de8f6969e..f00d6d08c9c5 100644

[PATCH 3/4] soc: mediatek: mmsys: Create struct mtk_mmsys to store context data

2020-10-06 Thread Enric Balletbo i Serra
From: CK Hu Apart from the driver data, in order to extend the driver to support more and more SoCs, we will need to store other configuration data. So, create a mtk_mmsys struct to encapsulate all that information. Signed-off-by: CK Hu Signed-off-by: Enric Balletbo i Serra --- drivers/soc

Re: [PATCH] ARM: dts: cros-ec-keyboard: Add alternate keymap for KEY_LEFTMETA

2020-10-06 Thread Enric Balletbo i Serra
Hi Stephen, On 25/9/20 18:26, Stephen Boyd wrote: > On newer keyboards this key is in a different place. Add both options to > the keymap so that both new and old keyboards work. > > Cc: Douglas Anderson > Signed-off-by: Stephen Boyd > --- Queued for 5.10. Thanks, Enric >

[PATCH] drm/mediatek: mtk_dpi: Fix unused variable 'mtk_dpi_encoder_funcs'

2020-10-05 Thread Enric Balletbo i Serra
oder_funcs mtk_dpi_encoder_funcs = { This struct is and the 'mtk_dpi_encoder_destroy()' are not needed anymore, so remove them. Fixes: f89c696e7f63 ("drm/mediatek: mtk_dpi: Convert to bridge driver") Reported-by: kernel test robot Signed-off-by: Enric Balletbo i Serra --- drivers/gpu/drm/me

[PATCH] arm64: dts: mediatek: Add smi_common node for MT8183

2020-10-01 Thread Enric Balletbo i Serra
. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index c2fd141afcf6..9082bc65e15e 100644 --- a/arch/arm64/boot/dts

[PATCH v2 10/12] dt-bindings: power: Add MT8183 power domains

2020-10-01 Thread Enric Balletbo i Serra
Add power domains dt-bindings for MT8183. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None .../power/mediatek,power-controller.yaml | 2 ++ include/dt-bindings/power/mt8183-power.h | 26 +++ 2 files changed, 28

[PATCH v2 07/12] soc: mediatek: pm-domains: Add extra sram control

2020-10-01 Thread Enric Balletbo i Serra
: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Nit, split readl(ctl_addr) | pd->data->sram_pdn_bits in two lines. - Use regmap API drivers/soc/mediatek/mtk-pm-domains.c | 30 +-- 1 file changed, 28 insertions(+), 2 deletions(-) diff

[PATCH v2 08/12] soc: mediatek: pm-domains: Add subsystem clocks

2020-10-01 Thread Enric Balletbo i Serra
Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Use dev_err_probe if getting clocks fails, so an error is not printed if is deferred. drivers/soc/mediatek/mtk-pm-domains.c | 89 ++- 1 file changed, 75 insertions(+), 14 deletions(-) diff --git a/drivers/soc

[PATCH v2 06/12] soc: mediatek: pm-domains: Add SMI block as bus protection block

2020-10-01 Thread Enric Balletbo i Serra
From: Matthias Brugger Apart from the infracfg block, the SMI block is used to enable the bus protection for some power domains. Add support for this block. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/soc/mediatek/mtk-pm-domains.c

[PATCH v2 05/12] soc: mediatek: pm_domains: Make bus protection generic

2020-10-01 Thread Enric Balletbo i Serra
From: Matthias Brugger Bus protection is not exclusively done by calling the infracfg misc driver. Make the calls for setting and clearing the bus protection generic so that we can use other blocks for it as well. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra

[PATCH v2 03/12] arm64: dts: mediatek: Add mt8173 power domain controller

2020-10-01 Thread Enric Balletbo i Serra
Add power domain controller node for SoC mt8173. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Add a scpsys syscon node as parent and a SPM (System Power Manager) as a child. arch/arm64/boot/dts/mediatek/mt8173.dtsi | 164 --- 1 file changed, 115 insertions

[PATCH v2 02/12] soc: mediatek: Add MediaTek SCPSYS power domains

2020-10-01 Thread Enric Balletbo i Serra
-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Get base address from parent syscon. We have now a scpsys syscon node and a child for the SPM (System Power Manager). - Use regmap API to acces de base address. drivers/soc/mediatek/Kconfig | 13 + drivers/soc

[PATCH v2 12/12] arm64: dts: mediatek: Add mt8183 power domains controller

2020-10-01 Thread Enric Balletbo i Serra
From: Matthias Brugger Add power domains controller node for SoC mt8183 Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None arch/arm64/boot/dts/mediatek/mt8183.dtsi | 162 +++ drivers/soc/mediatek/mtk-mmsys.c | 4 - 2

[PATCH v2 09/12] soc: mediatek: pm-domains: Allow bus protection to ignore clear ack

2020-10-01 Thread Enric Balletbo i Serra
From: Matthias Brugger In some cases the hardware does not create an acknowledgment of the bus protection clearing. Add a flag to the bus protection indicating that a clear event will be ignored. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None

[PATCH v2 11/12] soc: mediatek: pm-domains: Add support for mt8183

2020-10-01 Thread Enric Balletbo i Serra
From: Matthias Brugger Add the needed board data to support mt8183 SoC. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Do not use hardcoded values for triplets set, clear and status in infracfg and SMI. drivers/soc/mediatek/mtk-pm-domains.c

[PATCH v2 01/12] dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains controller

2020-10-01 Thread Enric Balletbo i Serra
The System Control Processor System (SCPSYS) has several power management related tasks in the system. Add the bindings to define the power domains for the SCPSYS power controller. Co-developed-by: Matthias Brugger Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra

[PATCH v2 00/12] soc: mediatek: pm-domains: Add new driver for SCPSYS power domains controller

2020-10-01 Thread Enric Balletbo i Serra
. Best regards, Enric Enric Balletbo i Serra (4): dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains controller soc: mediatek: Add MediaTek SCPSYS power domains arm64: dts: mediatek: Add mt8173 power domain controller dt-bindings: power: Add MT8183 power domains

[PATCH v2 04/12] soc: mediatek: pm-domains: Add bus protection protocol

2020-10-01 Thread Enric Balletbo i Serra
From: Matthias Brugger Bus protection will need to update more then one register in infracfg. Add support for several operations. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/soc/mediatek/mtk-pm-domains.c | 44

[PATCH v3] pinctrl: mediatek: Free eint data on failure

2020-10-01 Thread Enric Balletbo i Serra
ediatek: extend eint build to pinctrl-mtk-common-v2.c") Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Really release the resource when needed. For some reason the change was not reflected in patch v2. Changes in v2: - Free the resource when needed (Sean Wang) .../pinctrl/

Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-10-01 Thread Enric Balletbo i Serra
Hi, On 1/10/20 9:58, Linus Walleij wrote: > On Wed, Sep 30, 2020 at 6:33 PM Sean Wang wrote: >> On Wed, Sep 30, 2020 at 1:47 AM Linus Walleij >> wrote: >>> On Sun, Sep 27, 2020 at 7:57 PM Sean Wang wrote: >>> v2 seems the same with v1 or I was missing something. I just thought

Re: DT warnings in Cros EC

2020-09-30 Thread Enric Balletbo i Serra
Hi Rob, On 28/9/20 18:49, Rob Herring wrote: > There's a bunch of warnings in the Cros EC schemas. They stem from > child node names needing to be defined. I started fixing, but it's > kind of a mess as there's a mixture of no unit addresses and different > unit address spaces (regulators and

Re: [PATCH] chrome: Use kobj_to_dev() instead

2020-09-30 Thread Enric Balletbo i Serra
Hi Wang Qing, Many thanks for your patch. On 26/9/20 9:03, Wang Qing wrote: > Use kobj_to_dev() instead of container_of(). > > Signed-off-by: Wang Qing > --- Applied for 5.10 > drivers/platform/chrome/cros_ec_sysfs.c | 2 +- > drivers/platform/chrome/cros_ec_vbc.c | 4 ++-- > 2 files

Re: [PATCH] platform_data: ti: fix a typo

2020-09-29 Thread Enric Balletbo i Serra
Hi Wang Qing, Thank you for your patch. On 26/9/20 4:49, Wang Qing wrote: > Modify the typo: "compliment" -> "complement". > > Signed-off-by: Wang Qing > --- > include/linux/platform_data/cros_ec_commands.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH 11/12] soc: mediatek: pm-domains: Add support for mt8183

2020-09-25 Thread Enric Balletbo i Serra
Hi Hsin-Yi and Matthias, Hsin-Yi, many thanks to provide the register names. On 25/9/20 9:37, Hsin-Yi Wang wrote: > On Wed, Sep 16, 2020 at 8:19 PM Matthias Brugger > wrote: >> >> >> >> On 16/09/2020 11:46, Matthias Brugger wrote: >>> >>> >&

Re: [PATCH 01/12] dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains controller

2020-09-23 Thread Enric Balletbo i Serra
Hi Rob, Thank you for your answer. I have some doubts, see below. On 23/9/20 0:36, Rob Herring wrote: > On Mon, Sep 14, 2020 at 2:59 AM Matthias Brugger > wrote: >> >> >> >> On 12/09/2020 01:02, Rob Herring wrote: >>> On Thu, Sep 10, 2020 at 07:28:1

[PATCH v3] dt-bindings: power: rockchip: Convert to json-schema

2020-09-21 Thread Enric Balletbo i Serra
Convert the soc/rockchip/power_domain.txt binding document to json-schema and move to the power bindings directory. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Fixed tab errors found by bot Changes in v2: - Fixed a warning that says that 'syscon' should not be used alone. - Use

Re: [PATCH 2/2] platform/chrome: cros_ec_proto: Drop cros_ec_cmd_xfer()

2020-09-21 Thread Enric Balletbo i Serra
Hi Prashant, On 3/9/20 11:54, Prashant Malani wrote: > Since cros_ec_cmd_xfer_status() now returns Linux error codes and all > other files use that command, remove the now-unused function > cros_ec_cmd_xfer(). > > Signed-off-by: Prashant Malani Applied for 5.10 Thanks, Enric > --- >

Re: [PATCH 1/2] platform/chrome: cros_ec_proto: Update cros_ec_cmd_xfer() call-sites

2020-09-21 Thread Enric Balletbo i Serra
Hi Prashant and Gwendal, On 19/9/20 1:38, Gwendal Grignou wrote: > On Mon, Sep 14, 2020 at 4:29 PM Prashant Malani wrote: >> >> Thanks Enric, >> >> On Mon, Sep 7, 2020 at 3:48 AM Enric Balletbo i Serra >> wrote: >>> >>> Hi Prashant, >&g

[PATCH v2] dt-bindings: power: rockchip: Convert to json-schema

2020-09-18 Thread Enric Balletbo i Serra
Convert the soc/rockchip/power_domain.txt binding document to json-schema and move to the power bindings directory. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Fixed a warning that says that 'syscon' should not be used alone. - Use patternProperties to define a new level

Re: [PATCH] platform/chrome: cros_ec_debugfs: Support pd_info v2 format

2020-09-16 Thread Enric Balletbo i Serra
Hi Prashant, On 15/9/20 17:34, Prashant Malani wrote: > HI Enric, > > On Tue, Sep 15, 2020 at 5:48 AM Enric Balletbo i Serra > wrote: >> >> Hi Stephen, Prashant, >> >> On 9/9/20 6:04, Stephen Boyd wrote: >>> Let's try to read more information ou

Re: [PATCH v3 0/1] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-09-15 Thread Enric Balletbo i Serra
Hi Sam, On 27/8/20 10:59, Enric Balletbo i Serra wrote: > The first 4 patches of the series version 2: > - drm/bridge_connector: Set default status connected for eDP connectors > - drm/bridge: ps8640: Get the EDID from eDP control > - drm/bridge: ps8640: Return an error for inco

Re: [PATCH v5 1/2] platform/chrome: cros_ec_uart: Add cros-ec-uart transport layer

2020-09-15 Thread Enric Balletbo i Serra
INERS > index c8e8232c65da9..1603efb897a18 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -4133,6 +4133,12 @@ S: Maintained > F: Documentation/devicetree/bindings/sound/google,cros-ec-codec.yaml > F: sound/soc/codecs/cros_ec_codec.* > > +CHROMEOS EC UART DRIVER >

Re: [PATCH] platform/chrome: cros_ec_debugfs: Support pd_info v2 format

2020-09-15 Thread Enric Balletbo i Serra
Hi Stephen, Prashant, On 9/9/20 6:04, Stephen Boyd wrote: > Let's try to read more information out of more modern cros_ec devices by > using the v2 format first and then fall back to the v1 format. This > gives us more information about things such as DP mode of the typec pins > and the CC state,

Re: [PATCH] arm64: dts: mt8173-elm: Remove ddc property from panel

2020-09-15 Thread Enric Balletbo i Serra
Hi Matthias, On 26/8/20 11:02, Enric Balletbo i Serra wrote: > The elm and hana devices uses an Embedded DisplayPort (eDP) as interface > for its panel, so the DDC channel specified in the binding is useless. > > Signed-off-by: Enric Balletbo i Serra A gentle ping on this pa

Re: [PATCH v2] pinctrl: mediatek: Free eint data on failure

2020-09-15 Thread Enric Balletbo i Serra
Hi Linus, On 21/8/20 9:54, Enric Balletbo i Serra wrote: > The pinctrl driver can work without the EINT resource, but, if it is > expected to have this resource but the mtk_build_eint() function fails > after allocating their data (because can't get the resource or can't map > the ir

Re: [PATCH 01/12] dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains controller

2020-09-14 Thread Enric Balletbo i Serra
On 14/9/20 10:59, Matthias Brugger wrote: > > > On 12/09/2020 01:02, Rob Herring wrote: >> On Thu, Sep 10, 2020 at 07:28:15PM +0200, Enric Balletbo i Serra wrote: >>> The System Control Processor System (SCPSYS) has several power management >>> related task

Re: [PATCH v2] platform/chrome: Don't populate lightbar device if it isn't there

2020-09-10 Thread Enric Balletbo i Serra
Hi, On 10/9/20 16:52, Guenter Roeck wrote: > On Thu, Sep 10, 2020 at 7:32 AM Enric Balletbo i Serra > wrote: >> >> Hi, >> >> On 10/9/20 16:18, Guenter Roeck wrote: >>> On Wed, Sep 9, 2020 at 3:42 PM Stephen Boyd wrote: >>>> >>>>

[PATCH 07/12] soc: mediatek: pm-domains: Add extra sram control

2020-09-10 Thread Enric Balletbo i Serra
: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek/mtk-pm-domains.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c index 3aa430a60602..08

[PATCH 06/12] soc: mediatek: pm-domains: Add SMI block as bus protection block

2020-09-10 Thread Enric Balletbo i Serra
From: Matthias Brugger Apart from the infracfg block, the SMI block is used to enable the bus protection for some power domains. Add support for this block. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek/mtk-pm-domains.c | 64

[PATCH 08/12] soc: mediatek: pm-domains: Add subsystem clocks

2020-09-10 Thread Enric Balletbo i Serra
Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek/mtk-pm-domains.c | 82 +++ 1 file changed, 70 insertions(+), 12 deletions(-) diff --git a/drivers/soc/mediatek/mtk-pm-domains.c b/drivers/soc/mediatek/mtk-pm-domains.c index 0802eccc3a0b..52a93a87e313 100644

[PATCH 09/12] soc: mediatek: pm-domains: Allow bus protection to ignore clear ack

2020-09-10 Thread Enric Balletbo i Serra
From: Matthias Brugger In some cases the hardware does not create an acknowledgment of the bus protection clearing. Add a flag to the bus protection indicating that a clear event will be ignored. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek

[PATCH 10/12] dt-bindings: power: Add MT8183 power domains

2020-09-10 Thread Enric Balletbo i Serra
Add power domains dt-bindings for MT8183. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- .../power/mediatek,power-controller.yaml | 2 ++ include/dt-bindings/power/mt8183-power.h | 26 +++ 2 files changed, 28 insertions(+) create mode

[PATCH 12/12] arm64: dts: mediatek: Add mt8183 power domains controller

2020-09-10 Thread Enric Balletbo i Serra
From: Matthias Brugger Add power domains controller node for SoC mt8183 Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 160 +++ 1 file changed, 160 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH 01/12] dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains controller

2020-09-10 Thread Enric Balletbo i Serra
The System Control Processor System (SCPSYS) has several power management related tasks in the system. Add the bindings to define the power domains for the SCPSYS power controller. Co-developed-by: Matthias Brugger Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- Dear

[PATCH 11/12] soc: mediatek: pm-domains: Add support for mt8183

2020-09-10 Thread Enric Balletbo i Serra
From: Matthias Brugger Add the needed board data to support mt8183 SoC. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek/mtk-pm-domains.c | 162 ++ include/linux/soc/mediatek/infracfg.h | 28 + 2 files changed, 190

[PATCH 04/12] soc: mediatek: pm-domains: Add bus protection protocol

2020-09-10 Thread Enric Balletbo i Serra
From: Matthias Brugger Bus protection will need to update more then one register in infracfg. Add support for several operations. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek/mtk-pm-domains.c | 44 +++ 1 file changed

[PATCH 05/12] soc: mediatek: pm_domains: Make bus protection generic

2020-09-10 Thread Enric Balletbo i Serra
From: Matthias Brugger Bus protection is not exclusively done by calling the infracfg misc driver. Make the calls for setting and clearing the bus protection generic so that we can use other blocks for it as well. Signed-off-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra

[PATCH 02/12] soc: mediatek: Add MediaTek SCPSYS power domains

2020-09-10 Thread Enric Balletbo i Serra
-by: Matthias Brugger Signed-off-by: Enric Balletbo i Serra --- drivers/soc/mediatek/Kconfig | 13 + drivers/soc/mediatek/Makefile | 1 + drivers/soc/mediatek/mtk-pm-domains.c | 626 ++ 3 files changed, 640 insertions(+) create mode 100644 drivers/soc

[PATCH 03/12] arm64: dts: mediatek: Add mt8173 power domain controller

2020-09-10 Thread Enric Balletbo i Serra
Add power domain controller node for SoC mt8173. Signed-off-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 78 +--- 1 file changed, 69 insertions(+), 9 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts

[PATCH 00/12] soc: mediatek: pm-domains: Add new driver for SCPSYS power domains controller

2020-09-10 Thread Enric Balletbo i Serra
, only MT8173 and MT8183 is supported but should be fairly easy to add support for new SoCs. Best regards, Enric Enric Balletbo i Serra (4): dt-bindings: power: Add bindings for the Mediatek SCPSYS power domains controller soc: mediatek: Add MediaTek SCPSYS power domains arm64: dts

Re: [PATCH v2] platform/chrome: Don't populate lightbar device if it isn't there

2020-09-10 Thread Enric Balletbo i Serra
Hi, On 10/9/20 16:18, Guenter Roeck wrote: > On Wed, Sep 9, 2020 at 3:42 PM Stephen Boyd wrote: >> >> The cros ec lightbar driver has a check in probe to fail early if the ec >> device isn't the cros_ec one or if it can't read the lightbar version >> from the EC. Let's move this check to the

Re: [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype

2020-09-10 Thread Enric Balletbo i Serra
Hi Hsin-Yi, On 10/9/20 9:57, Hsin-Yi Wang wrote: > On Thu, Sep 10, 2020 at 3:20 PM Enric Balletbo i Serra > wrote: >> >> Hi Hsin-Yi, >> >> On 10/9/20 7:46, Hsin-Yi Wang wrote: >>> Set uart0 iotype to mmio32 to make earlycon work with stdout-pa

Re: [PATCH 1/2] arm64: dts: mt8173: elm: Set uart0 to mmio32 iotype

2020-09-10 Thread Enric Balletbo i Serra
Hi Hsin-Yi, On 10/9/20 7:46, Hsin-Yi Wang wrote: > Set uart0 iotype to mmio32 to make earlycon work with stdout-path. > > Signed-off-by: Hsin-Yi Wang > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

Re: [PATCH] platform/chrome: Kconfig: Remove the transitional MFD_CROS_EC config

2020-09-07 Thread Enric Balletbo i Serra
Hi Gwendal and Guenter, Thank you for the review and tested tags. On 3/9/20 16:17, Enric Balletbo i Serra wrote: > The MFD_CROS_EC config was a transitional Kconfig option to not break > current defconfigs in the kernel. Now, this is not required anymore > because all the defconfigs

Re: [PATCH 1/2] platform/chrome: cros_ec_proto: Update cros_ec_cmd_xfer() call-sites

2020-09-07 Thread Enric Balletbo i Serra
Hi Prashant, Thank you for your patch. On 3/9/20 11:54, Prashant Malani wrote: > Since all the other call-sites of cros_ec_cmd_xfer() have been converted > to use cros_ec_cmd_xfer_status() instead, update the remaining > call-sites to prepare for the merge of cros_ec_cmd_xfer() into >

<    1   2   3   4   5   6   7   8   9   10   >