Hi Gwendal,
On 30/8/20 8:59, Gwendal Grignou wrote:
> By default, the lightbar commands are set to the
> biggest lightbar command and response. That length is greater than 128
> bytes and may not work on all machines.
> But all EC are probed for lightbar by sending a get version request.
> Set tha
tor-allowed-modes element 0'
> since value 0 is invalid.
>
> Fixes: 689b937beddeb ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Signed-off-by: Dafna Hirschfeld
Double checked the regulator supported modes and I can confirm that this patch
gets rid of the err
p)
> {
> - list_add(&mdp->comp_list, &comp->node);
> + list_add(&comp->node, &mdp->comp_list);
> }
>
> void mtk_mdp_unregister_component(struct mtk_mdp_dev *mdp,
>
FWIW this also fixes my problems with suspend/resume on my Acer Chromebook R13,
so:
Tested-by: Enric Balletbo i Serra
The MFD_CROS_EC config was a transitional Kconfig option to not break
current defconfigs in the kernel. Now, this is not required anymore
because all the defconfigs have been removed this option and migrated to
enable the CrOS EC parts individually.
Signed-off-by: Enric Balletbo i Serra
Hi Gwendal,
On 15/8/20 5:39, Gwendal Grignou wrote:
> In ftrace, add more fields to the cros_ec command event:
> - Add size of commands to check if they are properly set.
> - Add offset (in case an EC is cascaded being another EC),
> to allow proper command output
>
> With:
> echo 1 > events/cros
Dear all,
On 22/8/20 17:08, Guenter Roeck wrote:
> The EC reports a variety of error codes. Most of those, with the exception
> of EC_RES_INVALID_VERSION, are converted to -EPROTO. As result, the actual
> error code gets lost. In cros_ec_cmd_xfer_status(), convert all EC errors
> to Linux error co
Hi Prashant and Heikki,
On 10/7/20 21:40, Prashant Malani wrote:
> From: Heikki Krogerus
>
> With USB4 mode the mux driver needs the Enter_USB Data
> Object (EUDO) that was used when the USB mode was entered.
> Though the object is not available in the driver, it is
> possible to construct it fr
Hi Azhar,
On 21/8/20 23:47, Azhar Shaikh wrote:
> Changes in v5:
>
> * Patch 1: "platform/chrome: cros_ec_typec: Send enum values to
> usb_role_switch_set_role()"
> - Rebased on top of https://lkml.org/lkml/2020/7/10/1063
>
> * Patch 2: "platform/chrome: cros_ec_typec: Avoid settin
to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:
> https://github.com/0day-ci/linux/commits/Enric-Balletbo-i-Serra/drm-bridge-ps8640-Make-sure-all-nee
Hi Bilal,
On 31/8/20 11:32, Bilal Wasim wrote:
>
> Hi Enric,
>
> On Thu, 27 Aug 2020 10:59:11 +0200
> Enric Balletbo i Serra wrote:
>
>> The get_edid() callback can be triggered anytime by an ioctl, i.e
>>
>> drm_mode_getconnector (ioctl)
>>
failed as explained in the third patch.
[1] https://lkml.org/lkml/2020/6/15/1208
Changes in v3:
- Make poweron/poweroff and pre_enable/post_disable reverse one to each other
(Sam Ravnborg)
Changes in v2:
- Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg)
Enric Balletbo i
o a power on cycle on this device.
Otherwise the device fails to retrieve the EDID.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v3:
- Make poweron/poweroff and pre_enable/post_disable reverse one to each other
(Sam Ravnborg)
Changes in v2:
- Use drm_bridge_chain_pre_enable/pos
Hi Sam,
Thanks for your comments.
On 26/8/20 20:46, Sam Ravnborg wrote:
> Hi Enric.
>
> On Wed, Aug 26, 2020 at 10:15:26AM +0200, Enric Balletbo i Serra wrote:
>> The get_edid() callback can be triggered anytime by an ioctl, i.e
>>
>> d
The elm and hana devices uses an Embedded DisplayPort (eDP) as interface
for its panel, so the DDC channel specified in the binding is useless.
Signed-off-by: Enric Balletbo i Serra
---
arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64
fails. (Boris)
Enric Balletbo i Serra (2):
drm/mediatek: mtk_dpi: Rename bridge to next_bridge
drm/mediatek: mtk_dpi: Convert to bridge driver
drivers/gpu/drm/mediatek/mtk_dpi.c | 77 +-
1 file changed, 45 insertions(+), 32 deletions(-)
--
2.28.0
Convert mtk_dpi to a bridge driver with built-in encoder support for
compatibility with existing component drivers.
Reviewed-by: Chun-Kuang Hu
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Maintain error message when attach to bridge fails. (Boris)
drivers/gpu/drm/mediatek
This is really a cosmetic change just to make a bit more readable the
code after convert the driver to drm_bridge. The bridge variable name
will be used by the encoder drm_bridge, and the chained bridge will be
named next_bridge.
Reviewed-by: Chun-Kuang Hu
Signed-off-by: Enric Balletbo i Serra
Hi Bilal,
On 24/8/20 21:01, Bilal Wasim wrote:
> Hi Chun-Kuan, Enric,
>
> Is there any plan to merge the following commits in this series to the
> mainline?
>
> drm/bridge: ps8640: Get the EDID from eDP control
> drm/bridge_connector: Set default status connected for eDP connectors
>
Just
Print an error message inside ps8640_bridge_vdo_control() function when
it fails so we can simplify a bit the callers, they will only need to
check the error code.
Reviewed-by: Sam Ravnborg
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
drivers/gpu/drm/bridge/parade-ps8640.c
/1208
Changes in v2:
- Included the patch `drm/bridge_connector: Set default status connected for
eDP connectors`
- Included the patch `drm/bridge: ps8640: Get the EDID from eDP control`
- Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg)
Enric Balletbo i Serra (5):
drm
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the
.get_edid callback and set the flag to indicate the core to use it.
Reviewed-by: Laurent Pinchart
Acked-by: Sam Ravnborg
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Included the patch `drm/bridge: ps8640: Get
o a power on cycle on this device.
Otherwise the device fails to retrieve the EDID.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Use drm_bridge_chain_pre_enable/post_disable() helpers (Sam Ravnborg)
drivers/gpu/drm/bridge/parade-ps8640.c | 64 +++---
1 fil
-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Included the patch `drm/bridge_connector: Set default status connected for
eDP connectors`
drivers/gpu/drm/drm_bridge_connector.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/drm_bridge_connector.c
b/drivers/gpu/drm
Bridge drivers that implement the new model only shall return an error
from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag
is not set. So make sure we return an error because only the new
drm_bridge model is supported.
Reviewed-by: Sam Ravnborg
Signed-off-by: Enric Balletbo
Dear drm_bridge maintainers,
It's been a while since I send these patches, and I'd like to find a proper
solution.
On 25/6/20 11:21, Enric Balletbo i Serra wrote:
> Hi Sam,
>
> On 24/6/20 9:07, Sam Ravnborg wrote:
>> Hi Enric.
>>
>> On Tue, Jun 23, 2020
Hi Marc,
On 20/8/20 16:53, Marc Zyngier wrote:
> On 2020-08-20 09:07, Saravana Kannan wrote:
>> On Thu, Aug 20, 2020 at 12:56 AM Marc Zyngier wrote:
>>>
>>> On 2020-08-19 19:51, Saravana Kannan wrote:
>>> > On Wed, Aug 19, 2020 at 9:52 AM Frank Wunderlich
>>> > wrote:
>>> >>
>>> >> hi,
>>> >>
>>
Hi Guenter et all,
On 6/8/20 17:33, Guenter Roeck wrote:
> The EC reports a variety of error codes. Most of those, with the exception
> of EC_RES_INVALID_VERSION, are converted to -EPROTO. As result, the actual
> error code gets lost. In cros_ec_cmd_xfer_status(), convert all EC errors
> to Linux
quot;pinctrl: mediatek: extend eint build to
pinctrl-mtk-common-v2.c")
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Free the resource when needed (Sean Wang)
.../pinctrl/mediatek/pinctrl-mtk-common-v2.c | 27 ++-
1 file changed, 20 insertions(+), 7 deletio
Hi Azhar,
I got a merge conflict because I applied [1] before these patches, fix the
conflict is trivial but, as I can't test, can you rebase your patches on top of
[1] and test and resend to make sure everything is working?
Thanks,
Enric
[1] https://lkml.org/lkml/2020/7/10/1063
On 21/8/20 1:
Hi Sean,
On 20/8/20 2:00, Sean Wang wrote:
> On Wed, Aug 19, 2020 at 9:19 AM Enric Balletbo i Serra
> wrote:
>>
>> The pinctrl driver can work without the EINT resource, but, if it is
>> expected to have this resource but the mtk_build_eint() function fails
>&g
quot;pinctrl: mediatek: extend eint build to
pinctrl-mtk-common-v2.c")
Signed-off-by: Enric Balletbo i Serra
---
.../pinctrl/mediatek/pinctrl-mtk-common-v2.c | 27 ++-
1 file changed, 20 insertions(+), 7 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-comm
c: Marc Zyngier
Cc: Hanks Chen
Fixes: f97dbf48ca43 ("irqchip/mtk-sysirq: Convert to a platform driver")
Signed-off-by: Enric Balletbo i Serra
---
drivers/irqchip/irq-mtk-sysirq.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq-mtk-sysirq.c
Hi Azhar,
Thank you for your patch.
On 11/8/20 21:37, Azhar Shaikh wrote:
> usb_role_switch_set_role() has the second argument as enum for usb_role.
> Currently depending upon the data role i.e. UFP(0) or DFP(1) is sent.
> This eventually translates to USB_ROLE_NONE in case of UFP and
> USB_ROLE_
Hi Gwendal,
On 28/7/20 11:13, Gwendal Grignou wrote:
> On some machine (nami), interrupt latency cause samples to appear
> to be from the future and are pegged to the current time.
> We would see samples with this pattern:
>
> [t, t + ~5ms, t + ~10ms, t + ~10ms + 100us, t + ~10ms + 200us],
>
Hi Brian,
On 24/7/20 21:08, Brian Norris wrote:
> ECs that don't implement EC_CMD_HOST_EVENT_GET_WAKE_MASK should still
> have some reasonable default mask -- otherwise, they'll treat a variety
> of EC signals as spurious wakeups. Battery and AC events can be
> especially common, for devices that
Hi Brian,
On 24/7/20 21:08, Brian Norris wrote:
> As with cros_ec_cmd_xfer_status(), etc., it's not enough to simply check
> for the return status of send_command() -- that only covers transport or
> other similarly-fatal errors. One must also check the ->result field, to
> see whether the command
Hi Guillaume et all,
On 17/8/20 12:02, Guillaume Tucker wrote:
> Hi,
>
> Please see the bisection report below about a driver probe
> regression with rockchip-pcie.
>
> Reports aren't automatically sent to the public while we're
> trialing new bisection features on kernelci.org but this one
> lo
> Reported-by: Nicolas Boichat
> Signed-off-by: Hsin-Yi Wang
Reviewed-by: Enric Balletbo i Serra
> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dt
ixes: 8d9f8d57e023 ("regulator: Add driver for cros-ec-regulator")
> Signed-off-by: Pi-Hsun Shih
Reviewed-by: Enric Balletbo i Serra
> ---
> drivers/regulator/cros-ec-regulator.c | 7 +--
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/regulator/c
the one
> in ChromeOS EC codebase.
>
> Fixes: dff08caf35ec ("platform/chrome: cros_ec: Add command for regulator
> control.")
> Signed-off-by: Pi-Hsun Shih
Acked-by: Enric Balletbo i Serra
This needs to go through Mark Brown's regulator tree as depends on
dff08caf
Hi Rob,
Thank you for your review.
On 21/7/20 5:25, Rob Herring wrote:
> On Wed, Jul 15, 2020 at 07:02:16PM +0200, Enric Balletbo i Serra wrote:
>> Convert the soc/rockchip/power_domain.txt binding document to json-schema
>> and move to the power bindings directory.
>>
&g
Hi Brian,
On 23/7/20 2:43, Brian Norris wrote:
> On Wed, Jul 22, 2020 at 2:13 PM Guenter Roeck wrote:
>> On Wed, Jul 22, 2020 at 1:50 PM Brian Norris
>> wrote:
>>> Other than perhaps taking a lesson not to propagate -ENOTSUPP, I don't
>>> think this series should block on that, as this is a bug
Hi Brian,
On 22/7/20 22:50, Brian Norris wrote:
> On Wed, Jul 22, 2020 at 3:19 AM Enric Balletbo i Serra
> wrote:
>>
>> Hi Brian,
>>
>> Thank you for your patch, I'll take a look soon but I'd like to ask if you
>> can
>> join the discussion w
>> possible to construct it from the information we have.
>>
>> Signed-off-by: Heikki Krogerus
>> Signed-off-by: Prashant Malani
For my own reference:
Acked-by: Enric Balletbo i Serra
>> ---
>>
>> This patch depends on latest usb-next from Greg K
Hi Prashant,
Thank you for your patch.
On 16/7/20 1:49, Prashant Malani wrote:
> When port update is called during probe(), any error with setting the
> Type C muxes results in an errno being returned to probe(), which promptly
> returns that itself. Ensure that we unregister any registered partn
Hi Brian,
Thank you for your patch, I'll take a look soon but I'd like to ask if you can
join the discussion with this patchset [1], specially this one [2]. We're trying
to match EC errors with standard linux kernel errors because we think can be
helpful.
[1] https://lore.kernel.org/patchwork/cov
Hi Guenter,
Thank you for work on this. Cc'ing Gwendal as he has a deep knowledge of the EC
and their errors.
On 20/7/20 22:22, Guenter Roeck wrote:
> The EC reports a variety of error codes. Most of those, with the exception
> of EC_RES_INVALID_VERSION, are converted to -EPROTO. As result, the a
Hi Rob,
On 16/7/20 21:13, Rob Herring wrote:
> On Wed, Jul 15, 2020 at 10:16:04PM -0700, Bhanu Prakash Maiya wrote:
>> From: Bhanu Prakash Maiya
>>
>> Add DT compatible string in
>> Documentation/devicetree/bindings/mfd/cros_ec.txt
>
> Need to update this.
>
> With that,
>
> Reviewed-by: Rob H
Hi Arnd,
On 17/7/20 8:59, Arnd Bergmann wrote:
> On Wed, Jul 15, 2020 at 11:31 PM Enric Balletbo Serra
> wrote:
>> Missatge de Enric Balletbo i Serra del
>> dia dj., 5 de març 2020 a les 12:11:
>>>
>>> We refactored the CrOS EC drivers moving part of the co
Hi,
On 16/7/20 19:23, Guenter Roeck wrote:
> On Thu, Jul 16, 2020 at 10:09 AM Yu-Hsuan Hsu wrote:
>>
>> It is not guaranteed that I2S RX is disabled when the kernel booting.
>> For example, if the kernel crashes while it is enabled, it will keep
>> enabled until the next time EC reboots. Reset I2
Hi Yu-Hsuan,
On 8/7/20 19:51, Yu-Hsuan Hsu wrote:
> Guenter Roeck 於 2020年7月9日 週四 上午1:26寫道：
>>
>> On Wed, Jul 8, 2020 at 9:17 AM Yu-Hsuan Hsu wrote:
>>>
>>> Guenter Roeck 於 2020年7月8日 週三 下午9:28寫道：
>>>>
>>>> On Wed, Jul 8, 2020 at 3:16
Convert the soc/rockchip/power_domain.txt binding document to json-schema
and move to the power bindings directory.
Signed-off-by: Enric Balletbo i Serra
---
.../power/rockchip,power-controller.yaml | 154 ++
.../bindings/soc/rockchip/power_domain.txt| 136
RS b/MAINTAINERS
> index 50659d76976b7..aa8e1d121c1d7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4036,6 +4036,7 @@ F: sound/soc/codecs/cros_ec_codec.*
> CHROMEOS EC SUBDRIVERS
> M: Benson Leung
> M: Enric Balletbo i Serra
> +M: Bhanu Prakash Maiya
c Peers
> , Benson Leung , Enric Balletbo i
> Serra , Guenter Roeck ,
> linux-kernel@vger.kernel.org, Lee Jones , Rob Herring
> , devicet...@vger.kernel.org
>
I think you need to fix your patman workflow. This should be removed from here.
&
Convert mtk_dpi to a bridge driver with built-in encoder support for
compatibility with existing component drivers.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Chun-Kuang Hu
---
Changes in v2:
- Maintain error message when attach to bridge fails. (Boris)
drivers/gpu/drm/mediatek
This is really a cosmetic change just to make a bit more readable the
code after convert the driver to drm_bridge. The bridge variable name
will be used by the encoder drm_bridge, and the chained bridge will be
named next_bridge.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Chun-Kuang Hu
. (Boris)
- Drop the third patch.
Enric Balletbo i Serra (2):
drm/mediatek: mtk_dpi: Rename bridge to next_bridge
drm/mediatek: mtk_dpi: Convert to bridge driver
drivers/gpu/drm/mediatek/mtk_dpi.c | 77 +-
1 file changed, 45 insertions(+), 32 deletions
Hi again,
On 8/7/20 17:12, Enric Balletbo i Serra wrote:
> Hi Boris,
>
> Thank you to spend some time to review the patches.
>
> On 1/7/20 13:41, Boris Brezillon wrote:
>> On Mon, 18 May 2020 19:39:09 +0200
>> Enric Balletbo i Serra wrote:
>>
>>> The m
Hi Rafael,
On 11/6/20 13:06, Enric Balletbo i Serra wrote:
> Hi,
>
> On 11/6/20 0:43, Dmitry Torokhov wrote:
>> On Wed, Jun 10, 2020 at 09:52:12PM +, mario.limoncie...@dell.com wrote:
>>>> -Original Message-
>>>> From: Dmitry Torokhov
>
_INVALID_VERSION, are converted to -EPROTO. As result, the
>> actual
>> error code gets lost. Convert all EC errors to Linux error codes to
>> report
>> a more meaningful error to the caller to aid debugging.
>>
>> Cc: Yu-Hsuan Hsu
>&g
The Rockchip DMC (Dynamic Memory Interface) needs to access to the PMU
general register files to know the DRAM type, so add a phandle to the
syscon that manages these registers.
Signed-off-by: Enric Balletbo i Serra
Reviewed-by: Chanwoo Choi
Acked-by: Rob Herring
Signed-off-by: Gaël PORTAY
Hi Eizan,
Thank you for your patch
On 8/7/20 6:53, Eizan Miyamoto wrote:
> Before creating an 'uptime' node in debugfs, this change adds a check to
> see if a EC_CMD_GET_UPTIME_INFO command can be successfully run.
>
> If the uptime node is created, userspace programs may periodically poll
> it
Hi Boris,
Thank you for review the patch.
On 1/7/20 13:51, Boris Brezillon wrote:
> On Mon, 18 May 2020 19:39:08 +0200
> Enric Balletbo i Serra wrote:
>
>> Convert mtk_dpi to a bridge driver with built-in encoder support for
>> compatibility with existing component drivers
Hi Boris,
Thank you to spend some time to review the patches.
On 1/7/20 13:41, Boris Brezillon wrote:
> On Mon, 18 May 2020 19:39:09 +0200
> Enric Balletbo i Serra wrote:
>
>> The mtk_dpi driver uses an empty implementation for its encoder. Replace
>> the code with the g
Hi Yu-Hsuan,
Thank you for your patch.
On 8/7/20 9:11, Yu-Hsuan Hsu wrote:
> It is not guaranteed that I2S RX is disabled when the kernel booting.
> For example, if the kernel crashes while it is enabled, it will keep
> enabled until the next time EC reboots. Reset I2S RX when probing to
> fix th
: eb9aecd90d1a ("thermal: mediatek: fix register index error")
Signed-off-by: Enric Balletbo i Serra
---
drivers/thermal/mtk_thermal.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c
index 6b7ef1993d7e..42
ck the patch.
Thoughts?
Thanks,
Enric
[1]
commit c5cd2b47b203f63682778c2a1783198e6b644294
Author: Enric Balletbo i Serra
Date: Thu Feb 20 16:58:52 2020 +0100
platform/chrome: cros_ec_proto: Report command not supported
In practice most drivers that use the EC protocol what really care i
Hi Yu-Hsuan,
On 3/7/20 11:40, Yu-Hsuan Hsu wrote:
> Enric Balletbo i Serra 於 2020年7月3日 週五 下午5:19寫道：
>>
>> Hi Yu-Hsuan,
>>
>> On 3/7/20 10:48, Yu-Hsuan Hsu wrote:
>>> Enric Balletbo i Serra 於 2020年7月3日 週五
>>> 下午4:38寫道：
>>>>
>>>
Hi Yu-Hsuan,
On 3/7/20 10:48, Yu-Hsuan Hsu wrote:
> Enric Balletbo i Serra 於 2020年7月3日 週五 下午4:38寫道：
>>
>> Hi Yu-Hsuan,
>>
>> Thank you for your patch
>>
>> On 3/7/20 9:19, Yu-Hsuan Hsu wrote:
>>> Log results of failed EC commands to
Hi Yu-Hsuan,
Thank you for your patch
On 3/7/20 9:19, Yu-Hsuan Hsu wrote:
> Log results of failed EC commands to identify a problem more easily.
>
> Replace cros_ec_cmd_xfer_status with cros_ec_cmd_xfer because the result
> has already been checked in this function. The wrapper is not needed.
>
Hi Gwendal,
Thank you for your patch.
On 30/6/20 9:52, Gwendal Grignou wrote:
> EC is using 32 bit timestamps (us), and before converting it to 64bit
> they were not casted, so it would overflow every 4s.
> Regular overflow every ~70 minutes was not taken into acoun either.
>
> Signed-off-by: Gw
Hi Gwendal,
Thank you for your review.
On 25/6/20 19:03, Enric Balletbo i Serra wrote:
> Kerneldoc expects all kernel structure member to be documented.
>
> Fixes the following W=1 level warnings:
>
> cros_ec_rpmsg.c:49: warning: Function parameter or member 'ept&
Hi Prashant,
Thank you for the patch. And thanks to Guenter and Heikki for reviewing it.
On 29/6/20 23:13, Prashant Malani wrote:
> Use a work queue to call the port update routines, instead of doing it
> directly in the PD notifier callback. This will prevent other drivers
> with PD notifier cal
Hi Gwendal,
Thank you for the review.
On 25/6/20 19:02, Enric Balletbo i Serra wrote:
> Kerneldoc expects all kernel function members to be documented.
>
> Fixes the following W=1 level warnings:
>
> cros_ec_spi.c:153: warning: Function parameter or member 'ec_dev&
Hi Qiushi,
Thank you for the patch.
On 23/5/20 5:16, wu000...@umn.edu wrote:
> From: Qiushi Wu
>
> In function cros_ec_ishtp_probe(), "up_write" is already called
> before function "cros_ec_dev_init". But "up_write" will be called
> again after the calling of the function "cros_ec_dev_init" fai
Hi Prashant,
Thank you for you ack
On 29/6/20 12:32, Enric Balletbo i Serra wrote:
> As reported by the kernel test robot the cros_ec_typec driver fails to
> build if the USB_ROLE_SWITCH is not selected, to fix that, add a
> dependency on that symbol. This fixes the following bu
Hi Chun-Kuang,
On 30/6/20 18:26, Chun-Kuang Hu wrote:
> Hi, Enric:
>
> Enric Balletbo i Serra 於 2020年6月30日 週二
> 下午10:34寫道：
>>
>> Hi Sam, Chun-Kuan,
>>
>> On 20/6/20 23:33, Sam Ravnborg wrote:
>>> Hi Enric
>>>
>>> On Mon,
Hi Sam, Chun-Kuan,
On 20/6/20 23:33, Sam Ravnborg wrote:
> Hi Enric
>
> On Mon, Jun 15, 2020 at 10:31:01PM +0200, Enric Balletbo i Serra wrote:
>> (This resend is to fix some trivial conflicts due the merge window)
>>
>> The PS8640 dsi-to-eDP bridge driver is
Hi Prashant,
Thank you for the patch.
On 27/6/20 6:58, Prashant Malani wrote:
> Define basic suspend resume functions for cros-ec-typec. On suspend, we
> simply ensure that any pending port update work is completed, and on
> resume, we re-poll the port state to account for any
> changes/disconnec
tch_put'
Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
Reported-by: kernel test robot
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/chrome/Kconfig b/drivers
Hi Chanwoo,
On 29/6/20 13:29, Chanwoo Choi wrote:
> Hi Enric and Mark,
>
> On 6/29/20 8:05 PM, Enric Balletbo i Serra wrote:
>> Hi Chanwoo and Marc,
>>
>> On 29/6/20 13:09, Chanwoo Choi wrote:
>>> Hi Enric,
>>>
>>> Could you check th
Hi Chanwoo and Marc,
On 29/6/20 13:09, Chanwoo Choi wrote:
> Hi Enric,
>
> Could you check this issue? Your patch[1] causes this issue.
> As Marc mentioned, although rk3399-dmc.c handled 'rockchip,pmu'
> as the mandatory property, your patch[1] didn't add the 'rockchip,pmu'
> property to the docu
Hi Eizan and Hans,
On 24/6/20 16:05, Hans Verkuil wrote:
> On 06/05/2020 10:40, Eizan Miyamoto wrote:
>>
>> This series depends on all changes in the series:
>> https://patchwork.kernel.org/patch/11530275/
>
> I plan on merging the v3 of this series.
>
>>
>> We are adding a dummy MDP component d
Hi Prashant,
On 24/6/20 10:09, Prashant Malani wrote:
> To support Thunderbolt compatibility mode, synchronize
> ec_response_usb_pd_control_v2 with the Chrome EC version, so that
> we get the Thunderbolt related control fields and macros.
>
> Signed-off-by: Prashant Malani
Applied both patches
Hi Bhanu,
Thank you for the patch.
On 25/6/20 23:34, Bhanu Prakash Maiya wrote:
> Add DT compatible string in
> Documentation/devicetree/bindings/mfd/cros_ec.txt
>
> Signed-off-by: Bhanu Prakash Maiya
> ---
>
> Documentation/devicetree/bindings/mfd/cros-ec.txt | 9 +++--
txt bindings are
Hi,
On 26/6/20 6:33, Greg Kroah-Hartman wrote:
> On Thu, Jun 25, 2020 at 10:06:03PM +0300, Andy Shevchenko wrote:
>> On Thu, Jun 25, 2020 at 9:25 PM Enric Balletbo i Serra
>> wrote:
>>>
>>> Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
>&
Remove the ambiguity with GPL-2.0 and use an explicit GPL-2.0-only
tag.
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/Makefile | 2 +-
drivers/platform/chrome/chromeos_pstore.c| 2 +-
drivers/platform/chrome/chromeos_tbmc.c | 2 +-
drivers
s_pending_host_event' not described in 'cros_ec_rpmsg'
cros_ec_rpmsg.c:49: warning: Function parameter or member 'probe_done' not
described in 'cros_ec_rpmsg'
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_rpmsg.c | 3 +++
1 file ch
27;buf' not described
in 'receive_n_bytes'
cros_ec_spi.c:153: warning: Function parameter or member 'n' not described in
'receive_n_bytes'
Signed-off-by: Enric Balletbo i Serra
---
drivers/platform/chrome/cros_ec_spi.c | 4
1 file changed, 4 insertions(+)
d
ion prototype:
> 'struct cros_feature_to_name '
> drivers/mfd/cros_ec_dev.c:44: warning: cannot understand function prototype:
> 'struct cros_feature_to_cells '
>
> Cc: Benson Leung
> Cc: Enric Balletbo i Serra
> Cc: Guenter Roeck
> Cc: Bill Richardson
> Signed-off
trieved from the Chrome OS EC.
>
> Signed-off-by: Prashant Malani
> Reviewed-by: Heikki Krogerus
> Acked-by: Enric Balletbo i Serra
Applied this patch for 5.9 to support ACPI devices, as discussed, the first
patch, the DT bindings, are still not ready.
Thanks,
Enric
> ---
&g
Hi Prashant,
On 20/6/20 4:00, Prashant Malani wrote:
> Since cros_typec_configure_mux() is only used in cros-ec-typec,
> it should be marked static.
>
> Fixes: 7e7def15fa4b ("platform/chrome: cros_ec_typec: Add USB mux control")
> Reported-by: kernel test robot
> Signed-off-by: Prashant Malani
Hi Prashant,
On 28/5/20 13:36, Prashant Malani wrote:
> This series adds mux control support for USB and DP alternate modes on
> devices using the cros-ec-typec driver with Type C switch handles
> provided by firmware bindings.
>
> The first patch imports some recent updates to the
> EC_CMD_USB_P
Hi Gwendal,
Thank you for your patch.
On 26/5/20 20:53, Gwendal Grignou wrote:
> When EC does not support uptime command (EC_CMD_GET_UPTIME_INFO),
> do not create the uptime sysfs entry point.
> User space application will not probe the file needlessly.
>
> The EC console log will not contain EC
05000/mmc1@0: node has a
unit name, but no reg or ranges property
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-evb.dts
b/arch/
take advantage of the
shared resources.
Signed-off-by: Ben Ho
[originally created by Ben Ho but adapted and ported to mainline]
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Move adding #phy-cells out of this patch. (Matthias Brugger)
arch/arm64/boot/dts/mediatek/Makefile
The MediaTek's peripheral configuration controller is present on the
MT8183 SoC. Add the node for that controller.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm64
Add the USB3.0 phyter and controller for the MediaTek's MT8183 SoC.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Move adding #phy-cells to this patch. (Matthias Brugger)
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 58
1 file changed, 58 inser
The krane-sku176 is the Lenovo IdeaPad Duet Chromebook. A 2-in-1
detachable device using the MediaTek MT8183 SoC.
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2: None
Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +
1 file changed, 5 insertions(+)
diff --git a
tates/cluster-sleep@1: node has a
unit name, but no reg or ranges property
Signed-off-by: Enric Balletbo i Serra
---
Changes in v2:
- Replace cluster-sleepX for cluster-sleep-x (Matthias Brugger)
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
201 - 300 of 1255 matches
Mail list logo
