Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-15 Thread Enric Balletbo i Serra
Hi, On 12/4/19 17:22, Srinivas Pandruvada wrote: > On Thu, 2019-04-11 at 15:54 +0200, Enric Balletbo i Serra wrote: >> Hi, >> >> On 11/4/19 13:10, Rushikesh S Kadam wrote: >>> Hi Enric, Srinivas >>> >>> On Thu, Apr 11, 2019 at 12:55:13PM

Re: [PATCH v3 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver

2019-04-15 Thread Enric Balletbo i Serra
Hi Nick, On 12/4/19 2:20, Nick Crews wrote: > Add control of the charging algorithm used on Wilco devices. > See Documentation/ABI/testing/sysfs-class-power-wilco for the > userspace interface and other info. > > v3 changes: > -Add this changelog > -Fix commit message tags > v2 changes: > -Updat

Re: [PATCH v3 1/2] power_supply: Add more charge types and CHARGE_CONTROL_* properties

2019-04-15 Thread Enric Balletbo i Serra
Hi Nick, On 12/4/19 2:20, Nick Crews wrote: > Add "Standard", "Adaptive", and "Custom" modes to the charge_type > property, to expand the existing "Trickle" and "Fast" modes. > In addition, add POWER_SUPPLY_PROP_CHARGE_CONTROL_START_THRESHOLD > and POWER_SUPPLY_PROP_CHARGE_CONTROL_END_THRESHOLD p

[PATCH] power: supply: core: fix typo in function to get current charge control limit

2019-04-15 Thread Enric Balletbo i Serra
There is a spelling mistake in ps_get_cur_charge_cntl_limit function so replace 'chrage' for 'charge'. Signed-off-by: Enric Balletbo i Serra --- drivers/power/supply/power_supply_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

Re: [PATCH v4 2/2] platform/chrome: wilco_ec: Add h1_gpio status to debugfs

2019-04-15 Thread Enric Balletbo i Serra
On 12/4/19 20:14, Nick Crews wrote: > As part of Chrome OS's FAFT (Fully Automated Firmware Testing) > tests, we need to ensure that the H1 chip is properly setting > some GPIO lines. The h1_gpio attribute exposes the state > of the lines: > - ENTRY_TO_FACT_MODE in BIT(0) > - SPI_CHROME_SEL in B

Re: [PATCH v4 1/2] platform/chrome: wilco_ec: Fix documentation for debugfs raw attribute

2019-04-15 Thread Enric Balletbo i Serra
Hi Nick, On 12/4/19 20:14, Nick Crews wrote: > In a previous refactor [repo chrome-platform, branch for-next, > commit 9cced499d6fdb60434ffa94f8f4b5087ad35802b > ("platform/chrome: wilco_ec: Standardize mailbox interface")], the > documentation for the raw debugfs attribute became incorrect, but I

Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-12 Thread Enric Balletbo i Serra
Hi, On 12/4/19 3:27, Brian Norris wrote: > On Wed, Apr 3, 2019 at 1:32 PM Douglas Anderson wrote: >> +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev, >> +struct cros_ec_command *ec_msg, >> +cros_ec_xfer_fn_t fn) >> +{

Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-11 Thread Enric Balletbo i Serra
Hi, On 11/4/19 13:10, Rushikesh S Kadam wrote: > Hi Enric, Srinivas > > On Thu, Apr 11, 2019 at 12:55:13PM +0200, Enric Balletbo i Serra wrote: >> Hi, >> >> On 10/4/19 17:31, Jett Rink wrote: >>> Reviewed-by: Jett Rink >>> Tested-by: Jett Rin

Re: [PATCH v3] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-11 Thread Enric Balletbo i Serra
Hi, On 10/4/19 17:31, Jett Rink wrote: > Reviewed-by: Jett Rink > Tested-by: Jett Rink > > > On Sun, Apr 7, 2019 at 6:10 AM Rushikesh S Kadam > wrote: >> >> This driver implements a slim layer to enable the ChromeOS >> EC kernel stack (cros_ec) to communicate with ChromeOS EC >> firmware runn

Re: [PATCH v2] mfd: cros_ec: check for NULL transfer function

2019-04-08 Thread Enric Balletbo i Serra
Hi Enrico, Many thanks to send this upstream. On 4/4/19 18:00, Jett ✈ Rink wrote: > Reviewed-by: Jett Rink > > On Wed, Apr 3, 2019 at 4:40 PM wrote: >> >> From: Enrico Granata >> >> As new transfer mechanisms are added to the EC codebase, they may >> not support v2 of the EC protocol. >> >> I

Re: [PATCH] mfd: cros_ec_dev: Add a poll handler to receive MKBP events

2019-04-08 Thread Enric Balletbo i Serra
Hi Lee, On 2/4/19 6:06, Lee Jones wrote: > On Fri, 08 Mar 2019, Enric Balletbo i Serra wrote: > >> From: Vincent Palatin >> >> Allow to poll on the cros_ec device to receive the MKBP events. >> >> The /dev/cros_[ec|fp|..] file operations now implements the

[PATCH] platform/chrome: cros_ec_debugfs: no need to check return value of debugfs_create functions

2019-04-08 Thread Enric Balletbo i Serra
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Greg Kroah-Hartman Signed-off-by: Enric Balletbo i Serra --- drivers/platform/chrome/cros_ec_debugfs.c | 35

Re: [PATCH v3] platform/chrome: mfd/cros_ec_debugfs: Add debugfs entry to retrieve EC uptime.

2019-04-08 Thread Enric Balletbo i Serra
On 8/4/19 13:29, Enric Balletbo i Serra wrote: > Hi Tim, > > Many thanks for sending this patch upstream, some comments below > > On 27/3/19 19:20, Tim Wawrzynczak wrote: >> The new debugfs entry 'uptime' is being made available to userspace so that >>

Re: [PATCH v3] platform/chrome: mfd/cros_ec_debugfs: Add debugfs entry to retrieve EC uptime.

2019-04-08 Thread Enric Balletbo i Serra
Hi Tim, Many thanks for sending this patch upstream, some comments below On 27/3/19 19:20, Tim Wawrzynczak wrote: > The new debugfs entry 'uptime' is being made available to userspace so that > a userspace daemon can synchronize EC logs with host time. > > Signed-off-by: Tim Wawrzynczak > --- >

Re: [PATCH v3 2/4] mfd: cros_ec: instantiate properly CrOS ISH MCU device

2019-04-08 Thread Enric Balletbo i Serra
On 8/4/19 12:28, Andy Shevchenko wrote: > On Mon, Apr 08, 2019 at 11:41:39AM +0200, Enric Balletbo i Serra wrote: >> From: Rushikesh S Kadam >> >> Integrated Sensor Hub (ISH) is also a MCU running EC >> having feature bit EC_FEATURE_ISH. Instantiate it as >&

[PATCH v3 0/4] mfd: cros_ec: Instantiate CrOS FP, TP and ISH devices

2019-04-08 Thread Enric Balletbo i Serra
a patch to introduce the required enums to build. - Add a patch to instantiate the CrOS ISH device to the series. Enric Balletbo i Serra (3): mfd: cros_ec: Update the EC feature codes mfd: cros_ec: instantiate properly CrOS FP MCU device mfd: cros_ec: instantiate properly CrOS Touchpad

[PATCH v3 4/4] mfd: cros_ec: instantiate properly CrOS Touchpad MCU device

2019-04-08 Thread Enric Balletbo i Serra
'. So regardless of the probing order between the actual cros_ec and cros_tp, the userspace and other kernel drivers should not confuse them. Signed-off-by: Wei-Ning Huang Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: None drivers/mfd/cros_ec_de

[PATCH v3 2/4] mfd: cros_ec: instantiate properly CrOS ISH MCU device

2019-04-08 Thread Enric Balletbo i Serra
ned-off-by: Enric Balletbo i Serra --- Changes in v3: - Fix Andy Shevchenko email. Changes in v2: - Add a patch to instantiate the CrOS ISH device to the series. drivers/mfd/cros_ec_dev.c | 13 + include/linux/mfd/cros_ec.h | 5 +++-- 2 files changed, 16 insertions(+), 2 deletion

[PATCH v3 1/4] mfd: cros_ec: Update the EC feature codes

2019-04-08 Thread Enric Balletbo i Serra
here, also fix a typo in one comment in the enum. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: - Add a patch to introduce the required enums to build. include/linux/mfd/cros_ec_commands.h | 34 +++- 1 file changed, 33 insertions(+), 1

[PATCH v3 3/4] mfd: cros_ec: instantiate properly CrOS FP MCU device

2019-04-08 Thread Enric Balletbo i Serra
'. So regardless of the probing order between the actual cros_ec and cros_fp, the userspace and other kernel drivers should not confuse them. Signed-off-by: Vincent Palatin Signed-off-by: Enric Balletbo i Serra --- Changes in v3: None Changes in v2: None drivers/mfd/cros_ec_de

[PATCH v2 3/4] mfd: cros_ec: instantiate properly CrOS FP MCU device

2019-04-05 Thread Enric Balletbo i Serra
'. So regardless of the probing order between the actual cros_ec and cros_fp, the userspace and other kernel drivers should not confuse them. Signed-off-by: Vincent Palatin Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/mfd/cros_ec_dev.c | 10 ++ include

[PATCH v2 2/4] mfd: cros_ec: instantiate properly CrOS ISH MCU device

2019-04-05 Thread Enric Balletbo i Serra
ned-off-by: Enric Balletbo i Serra --- Changes in v2: - Add a patch to instantiate the CrOS ISH device to the series. drivers/mfd/cros_ec_dev.c | 13 + include/linux/mfd/cros_ec.h | 5 +++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/cros_ec_dev.c b/d

[PATCH v2 1/4] mfd: cros_ec: Update the EC feature codes

2019-04-05 Thread Enric Balletbo i Serra
here, also fix a typo in one comment in the enum. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Add a patch to introduce the required enums to build. include/linux/mfd/cros_ec_commands.h | 34 +++- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git

[PATCH v2 4/4] mfd: cros_ec: instantiate properly CrOS Touchpad MCU device

2019-04-05 Thread Enric Balletbo i Serra
'. So regardless of the probing order between the actual cros_ec and cros_tp, the userspace and other kernel drivers should not confuse them. Signed-off-by: Wei-Ning Huang Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/mfd/cros_ec_dev.c | 10 ++ include

[PATCH v2 0/4] mfd: cros_ec: Instantiate CrOS FP, TP and ISH devices

2019-04-05 Thread Enric Balletbo i Serra
d. - Add a patch to instantiate the CrOS ISH device to the series. Enric Balletbo i Serra (3): mfd: cros_ec: Update the EC feature codes mfd: cros_ec: instantiate properly CrOS FP MCU device mfd: cros_ec: instantiate properly CrOS Touchpad MCU device Rushikesh S Kadam (1): mfd: cros_ec: i

Re: [PATCH] platform/chrome: wilco_ec: Standardize mailbox interface

2019-04-05 Thread Enric Balletbo i Serra
Hi Nick, On 5/4/19 0:54, Nick Crews wrote: > I sent this out previously in a series with a keyboard backlight driver > (https://lkml.org/lkml/2019/4/4/1370), but the backlight driver is > still in flux, and I wanted to get this committed ASAP. Thus I'm > sending this as a separate series, in hopes

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-05 Thread Enric Balletbo i Serra
Hi, On 5/4/19 0:42, Guenter Roeck wrote: > On Thu, Apr 4, 2019 at 3:05 PM Pavel Machek wrote: >> >> On Thu 2019-04-04 14:48:35, Dmitry Torokhov wrote: >>> On Thu, Apr 4, 2019 at 1:42 PM Pavel Machek wrote: Hi! >>> And what to do if internal keyboard is not platform but USB? Li

Re: [PATCH v3] platform/chrome: cros_ec_spi: Transfer messages at high priority

2019-04-04 Thread Enric Balletbo i Serra
Hi Doug, Thanks for sending this patch upstream. On 3/4/19 23:19, Matthias Kaehlcke wrote: > On Wed, Apr 03, 2019 at 02:08:40PM -0700, Doug Anderson wrote: >> Hi, >> >> On Wed, Apr 3, 2019 at 2:04 PM Matthias Kaehlcke wrote: +static int cros_ec_xfer_high_pri(struct cros_ec_device *ec_dev, >

Re: [PATCH v2] platform: chrome: Add ChromeOS EC ISHTP driver

2019-04-03 Thread Enric Balletbo i Serra
Hi Rushikesh, Thanks for sending this upstream, some comments below. On 3/4/19 10:52, Rushikesh S Kadam wrote: > Add ChromeOS EC ISHTP driver. > Could you explain a bit more about what ISHTP is? I suppose is a protocol to communicate with the Integrated Sensor Driver, but would be good have a b

Re: [PATCH v3 2/2] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-03 Thread Enric Balletbo i Serra
Hi Nick, On 3/4/19 4:05, Nick Crews wrote: > The EC is in charge of controlling the keyboard backlight on > the Wilco platform. We expose a standard LED class device at > /sys/class/leds/chromeos::kbd_backlight. This driver is modeled > after the standard Chrome OS keyboard backlight driver at > d

Re: [PATCH v3 1/2] platform/chrome: wilco_ec: Standardize mailbox interface

2019-04-03 Thread Enric Balletbo i Serra
Hi Nick, On 3/4/19 4:05, Nick Crews wrote: > The current API for the wilco EC mailbox interface is bad. > > It assumes that most messages sent to the EC follow a similar structure, > with a command byte in MBOX[0], followed by a junk byte, followed by > actual data. This doesn't happen in several

[PATCH v2 1/2] platform/chrome: Add CrOS USB PD logging driver

2019-04-03 Thread Enric Balletbo i Serra
APPEND_STRING and minor cleanups] Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Fix [2/2] to only include mfd changes. drivers/platform/chrome/Kconfig | 12 + drivers/platform/chrome/Makefile| 1 + drivers/platform/chrome/cros_usbpd_logger.c | 260

[PATCH v2 2/2] mfd: cros_ec: Instantiate the CrOS USB PD logger driver

2019-04-03 Thread Enric Balletbo i Serra
Add the cros-usbpd-logger driver for logging event data for the USB PD charger available in the Embedded Controller on ChromeOS systems. The logging feature is logically separate functionality from charge manager, hence is instantiated as a different driver. Signed-off-by: Enric Balletbo i Serra

Re: [PATCH 2/2] mfd: cros_ec: Instantiate the CrOS USB PD logger driver

2019-04-03 Thread Enric Balletbo i Serra
On 3/4/19 15:54, Enric Balletbo i Serra wrote: > Add the cros-usbpd-logger driver for logging event data for the USB PD > charger available in the Embedded Controller on ChromeOS systems. The > logging feature is logically separate functionality from charge manager, > hence is insta

[PATCH 1/2] platform/chrome: Add CrOS USB PD logging driver

2019-04-03 Thread Enric Balletbo i Serra
macro and minor cleanups] Signed-off-by: Enric Balletbo i Serra --- drivers/platform/chrome/Kconfig | 12 + drivers/platform/chrome/Makefile| 1 + drivers/platform/chrome/cros_usbpd_logger.c | 260 3 files changed, 273 insertions(+) create mode 100644

[PATCH 2/2] mfd: cros_ec: Instantiate the CrOS USB PD logger driver

2019-04-03 Thread Enric Balletbo i Serra
Add the cros-usbpd-logger driver for logging event data for the USB PD charger available in the Embedded Controller on ChromeOS systems. The logging feature is logically separate functionality from charge manager, hence is instantiated as a different driver. Signed-off-by: Enric Balletbo i Serra

[PATCH] platform/chrome: cros_ec_proto: Also return invalid command in cros_ec_cmd_xfer_status

2019-04-03 Thread Enric Balletbo i Serra
command is not supported by the EC. An use case for this is when you need to show/hide a sysfs attribute for a specific command and you don't have a EC feature flag that tells you that the command is supported or not. While here, also document properly the cros_ec_cmd_xfer_status function. Signed-of

[PATCH] platform/chrome: cros_ec_debugfs: Remove dev_warn when console log is not supported

2019-04-03 Thread Enric Balletbo i Serra
print an error. Signed-off-by: Enric Balletbo i Serra --- drivers/platform/chrome/cros_ec_debugfs.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_debugfs.c b/drivers/platform/chrome/cros_ec_debugfs.c index 71308766e891..f0de1991b688 10064

Re: [PATCH v3] mfd: cros: Update EC protocol to match current EC code

2019-03-29 Thread Enric Balletbo i Serra
Hi Gwendal, After fix my problems manually ... On 28/3/19 22:52, Gwendal Grignou wrote: > Chromebook Embedded Controller protocol is defined in the kernel at > cros_ec_commands.h. > The source of trust for the EC protocol is at > https://chromium.googlesource.com/chromiumos/platform/ec/+/master/i

Re: [PATCH v2] platform/chrome: mfd/cros_ec_sysfs: Add sysfs entry to retrieve EC uptime.

2019-03-27 Thread Enric Balletbo i Serra
Hi Tim, On 25/3/19 18:02, twawrzync...@chromium.org wrote: > From: Tim Wawrzynczak > > The new sysfs entry 'uptime' is being made available to userspace so that > a userspace daemon can synchronize EC logs with host time. > > Signed-off-by: Tim Wawrzynczak > --- > Enric, the use case for this

Re: [PATCH v2] mfd: cros: Update EC protocol to match current EC code

2019-03-27 Thread Enric Balletbo i Serra
Hi Gwendal, Unless my pwclient or patchwork is doing something weird I have some issues trying to apply this patch. Could you check that is correctly formatted? $ pwclient git-am 1055029 Applying patch #1055029 using u'git am' Description: [v2] mfd: cros: Update EC protocol to match current EC c

Re: [PATCH 1/3] platform/chrome: wilco_ec: Split core and mailbox into separate modules

2019-03-25 Thread Enric Balletbo i Serra
Hi Nick, Thanks for the patch, some comments below. On 21/3/19 23:13, Nick Crews wrote: > It was bad design to lump the mailbox interface to the Wilco EC into the > same module as the code module, which loads all the subdrivers: Typo: s/code/core/? > - This required the sub-drivers to depend on

Re: [PATCH] mfd: cros_ec: Only register a positive IRQ number

2019-03-22 Thread Enric Balletbo i Serra
GGER_LOW | IRQF_ONESHOT, > "chromeos-ec", ec_dev); > Acked-by: Enric Balletbo i Serra Thanks, Enric

Re: [PATCH V5] platform/chrome: mfd/cros_ec_dev: Add sysfile to force

2019-03-13 Thread Enric Balletbo i Serra
Hi RaviChandra, Many thanks for pushing this upstream. Some more comments below. On 9/3/19 2:42, RaviChandra Sadineni wrote: > On chromebooks, power_manager daemon normally shuts down(S5) the device > when the battery charge falls below 4% threshold. ChromeOS EC then > normally spends an hour in

[RESEND PATCH] PM / devfreq: Fix static checker warning in try_then_request_governor

2019-03-13 Thread Enric Balletbo i Serra
arpenter Signed-off-by: Enric Balletbo i Serra Reviewed-by: Chanwoo Choi --- Hi, This is a resend of [1] as seems that got lost at some point and I just noticed that was never merged. Thanks, Enric [1] https://lkml.org/lkml/2018/10/16/744 drivers/devfreq/devfreq.c | 4 ++-- 1 file changed

[PATCH] iio: cros_ec: Switch to SPDX identifier.

2019-03-13 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Also fix MODULE_LICENSE for cros_ec_accel_legacy to match the SPDX and boiler plate license. Signed-off-by: Enric Balletbo i Serra --- drivers/iio/accel/cros_ec_accel_legacy.c | 12

[PATCH] iio: cros_ec: Drop unnecessary include files

2019-03-13 Thread Enric Balletbo i Serra
Balletbo i Serra --- drivers/iio/accel/cros_ec_accel_legacy.c | 1 - drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 -- drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 1 - drivers/iio/light/cros_ec_light_prox.c| 2 -- drivers/iio

[PATCH v3] iio: cros_ec: Fix the maths for gyro scale calculation

2019-03-13 Thread Enric Balletbo i Serra
7a31d ("iio: cros_ec_sensors: add ChromeOS EC Contiguous Sensors driver") Signed-off-by: Gwendal Grignou Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - Fix 'warning: this decimal constant is unsigned only in ISO C90' spotted by kbuild test robot. Changes in v2:

[PATCH] iio: cros_ec: Add kernel-doc for cros_ec_sensors_read_lpc

2019-03-13 Thread Enric Balletbo i Serra
From: Gwendal Grignou Document cros_ec_sensors_read_lpc, adding an additional note to explain that this is the safe function for reading the EC data. Signed-off-by: Gwendal Grignou Signed-off-by: Enric Balletbo i Serra --- .../iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 11

Re: [PATCH] platform/chrome: Fix locking pattern in wilco_ec_mailbox()

2019-03-12 Thread Enric Balletbo i Serra
Hi Nick, On 11/3/19 16:58, Nick Crews wrote: > Before, ec->data_buffer could be written to from multiple > contexts at the same time. Since the ec is shared data, > it needs to be inside the mutex as well. > Probably you're missing a fixes tag here. > Signed-off-by: Nick Crews > --- > drivers

[PATCH] mfd: cros_ec_dev: Add a poll handler to receive MKBP events

2019-03-08 Thread Enric Balletbo i Serra
Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 163 +- drivers/mfd/cros_ec_dev.h | 1 + 2 files changed, 160 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 85f05cb648f8..0638a0d82d97 100644 --- a

[PATCH 1/2] mfd: cros_ec: instantiate properly CrOS FP MCU device

2019-03-07 Thread Enric Balletbo i Serra
name 'cros_fp'. So regardless of the probing order between the actual cros_ec and cros_fp, the userspace and other kernel drivers should not confuse them. Signed-off-by: Vincent Palatin Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 10 ++ include

[PATCH 0/2] mfd: cros_ec: instantiate CrOS FP and TP devices

2019-03-07 Thread Enric Balletbo i Serra
Hi, This patch adds support to instantiate two special CrOS EC devices, one is fingerprint and another one is a touchpad. This patchset depends on the following patches to apply cleanly and build. - mfd: cros: Update EC protocol to match current EC code - https://lore.kernel.org/patchwork/patch

[PATCH 2/2] mfd: cros_ec: instantiate properly CrOS Touchpad MCU device

2019-03-07 Thread Enric Balletbo i Serra
device name 'cros_tp'. So regardless of the probing order between the actual cros_ec and cros_tp, the userspace and other kernel drivers should not confuse them. Signed-off-by: Wei-Ning Huang Signed-off-by: Enric Balletbo i Serra --- drivers/mfd/cros_ec_dev.c | 10 ++ include

[PATCH v2] ARM: multi_v7_defconfig: Enable missing drivers for supported Chromebooks

2019-03-07 Thread Enric Balletbo i Serra
all Veyron boards. - ChromeOS EC userspace interface for all chromebooks boards. - ChromeOS EC light and proximity sensors for some chromebooks. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Rebased on top of mainline. arch/arm/configs/multi_v7_defconfig | 11 +++ 1 file

[PATCH v2] iio: cros_ec: Fix the maths for gyro scale calculation

2019-03-07 Thread Enric Balletbo i Serra
7a31d ("iio: cros_ec_sensors: add ChromeOS EC Contiguous Sensors driver") Signed-off-by: Gwendal Grignou Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Do the maths instead of play with dividers as pointed by Jonathan. drivers/iio/common/cros_ec_sensors/cros_ec_sensors.

Re: [PATCH V3] cros_ec: Expose sysfile to force battery cut-off on shutdown.

2019-03-07 Thread Enric Balletbo i Serra
Hi RaviChandra, Some few comments below ... On 5/3/19 1:53, RaviChandra Sadineni wrote: > On chromebooks, power_manager daemon normally shutsdown(S5) the device > when the battery charge falls below 4% threshold. Chromeos EC then > normally spends an hour in S5 before hibernating. If the battery

Re: [PATCH] iio: cros_ec: Fix gyro scale calculation

2019-03-06 Thread Enric Balletbo i Serra
Hi Jonathan, On 3/3/19 17:47, Jonathan Cameron wrote: > On Fri, 22 Feb 2019 11:24:24 +0100 > Enric Balletbo i Serra wrote: > >> Hi Jonathan, >> >> On 20/2/19 17:01, Jonathan Cameron wrote: >>> On Wed, 20 Feb 2019 16:03:00 +0100 >>> Enric Balle

Re: [PATCH] platform/chrome: fix wilco-ec dependencies

2019-03-05 Thread Enric Balletbo i Serra
Hi, On 4/3/19 21:06, Arnd Bergmann wrote: > When CROS_EC_LPC is set to =m, we get a link failure for a > builtin wilco-ec module: > > drivers/platform/chrome/wilco_ec/core.o: In function `wilco_ec_remove': > core.c:(.text+0x26): undefined reference to `cros_ec_lpc_mec_destroy' > drivers/platform/

Re: [PATCH v3] mfd: cros_ec: instantiate properly CrOS ISH MCU device

2019-03-01 Thread Enric Balletbo i Serra
1082..43bee4f 100644 > --- a/include/linux/mfd/cros_ec_commands.h > +++ b/include/linux/mfd/cros_ec_commands.h > @@ -856,6 +856,8 @@ enum ec_feature_code { > EC_FEATURE_RTC = 27, > /* EC supports CEC commands */ > EC_FEATURE_CEC = 35, > + /* The MCU is an Integrated Sensor Hub */ > + EC_FEATURE_ISH = 40, > }; > > #define EC_FEATURE_MASK_0(event_code) (1UL << (event_code % 32)) > Acked-by: Enric Balletbo i Serra

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-27 Thread Enric Balletbo i Serra
ance of people > more experienced in kernel design. If using cros_ish as a device name > instead of cros_ec is actually not a good idea, then we can accept > that and move forward and try to see what the fallout is from > userspace tools. > > -Jett > > > On Wed, Feb 27, 20

Re: [PATCH] cros_ec: instantiate properly Intel ISH MCU device

2019-02-27 Thread Enric Balletbo i Serra
Hi, On 26/2/19 18:21, Jett Rink wrote: > We are specifically wanting userspace applications to not worry/confuse > cros_ish > with a normal cros_ec. Adding an attribute instead of changing the path would > make it easy for userspace application to forget to check properly before > accessing the i

Re: [PATCH] ASoC: qcom: Kconfig: fix dependency for sdm845

2019-02-25 Thread Enric Balletbo i Serra
> Signed-off-by: Cheng-Yi Chiang Tested-by: Enric Balletbo i Serra Thanks, Enric > --- > sound/soc/qcom/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig > index 8f206cb4fcc0..75ceb04d8bf0 100644 &g

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-25 Thread Enric Balletbo i Serra
Hi Cheng-yi, Attached the config that Randy sent. Thanks, Enric On 25/2/19 11:22, Cheng-yi Chiang wrote: > On Mon, Feb 25, 2019 at 6:11 PM Enric Balletbo i Serra > wrote: >> >> Hi Randy, >> >> Thanks for the report >> >> On 22/2/19 17:50, Randy Du

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-25 Thread Enric Balletbo i Serra
Hi Randy, Thanks for the report On 22/2/19 17:50, Randy Dunlap wrote: > On 2/20/19 11:57 PM, Enric Balletbo i Serra wrote: >> Hi, >> >> On 21/2/19 0:09, Randy Dunlap wrote: >>> On 2/20/19 2:11 PM, Nick Crews wrote: >>>> In the initial version of the Wilc

Re: [PATCH v5 5/6] mfd: add EC host command support using rpmsg.

2019-02-22 Thread Enric Balletbo i Serra
Hi, Only some few comments, most of them nits that I'd be happy if you can apply as you should probably send another version because the documentation of the binding is missing. On 21/2/19 9:47, Pi-Hsun Shih wrote: > Add EC host command support through rpmsg. > > Signed-off-by: Pi-Hsun Shih > -

Re: [PATCH] iio: cros_ec: Fix gyro scale calculation

2019-02-22 Thread Enric Balletbo i Serra
Hi Jonathan, On 20/2/19 17:01, Jonathan Cameron wrote: > On Wed, 20 Feb 2019 16:03:00 +0100 > Enric Balletbo i Serra wrote: > >> From: Gwendal Grignou >> >> Calculation was copied from IIO_DEGREE_TO_RAD, but offset added to avoid >> rounding error is wro

Re: [PATCH] iio: cros_ec_accel_legacy: Refactor code in cros_ec_accel_legacy_probe

2019-02-21 Thread Enric Balletbo i Serra
t; This patch is part of the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva > > Acked-by: Kees Cook > Acked-by: Enric Balletbo i Serra Thanks, Enric > -Kees > >> --- >> drivers/iio/accel/cros_ec_

Re: [PATCH -next] platform/chrome: Fix Kconfig dependencies for wilco_ec

2019-02-20 Thread Enric Balletbo i Serra
Hi, On 21/2/19 0:09, Randy Dunlap wrote: > On 2/20/19 2:11 PM, Nick Crews wrote: >> In the initial version of the Wilco EC Driver, the >> dependency order was wrong. It before was possible to >> select CONFIG_WILCO_EC and CONFIG_CROS_EC_LPC without >> having CONFIG_CROS_EC_LPC_MEC. This was wrong,

Re: [PATCH -next] platform/chrome: Fix off-by-one error in wilco_ec/debugfs.c

2019-02-20 Thread Enric Balletbo i Serra
Hi, On 20/2/19 23:15, Nick Crews wrote: > Hi Enric, > > On Wed, Feb 20, 2019 at 3:06 PM Enric Balletbo i Serra > wrote: >> >> Hi Nick, >> >> Thanks for the patch. >> >> On 20/2/19 22:58, Nick Crews wrote: >>> Before, in debugfs.c it

Re: [PATCH -next] platform/chrome: Fix off-by-one error in wilco_ec/debugfs.c

2019-02-20 Thread Enric Balletbo i Serra
Hi Nick, Thanks for the patch. On 20/2/19 22:58, Nick Crews wrote: > Before, in debugfs.c it was possible to supply only the message type, > and not supply any other arguments when sending raw commands. However, > this is never used by the EC, and it led to an underflow error. Now, > just don't a

[PATCH] iio: cros_ec: Fix gyro scale calculation

2019-02-20 Thread Enric Balletbo i Serra
ned-off-by: Enric Balletbo i Serra --- drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c b/drivers/iio/common/cros_ec_sensors/cros_ec_sensors.c index 89cb0066a6e0..600942af9

Re: [PATCH -next] platform/chrome: Make function wilco_ec_transfer() static

2019-02-18 Thread Enric Balletbo i Serra
On 16/2/19 7:09, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/platform/chrome/wilco_ec/mailbox.c:126:5: warning: > symbol 'wilco_ec_transfer' was not declared. Should it be static? > > Fixes: 436dad4fda10 ("platform/chrome: Add new driver for Wilco EC") > Signed-off-by

[PATCH] ARM: dts: rockchip: add chosen node on veyron chromebooks

2019-02-15 Thread Enric Balletbo i Serra
In order to use earlycon, the stdout-path property needs to be set in the chosen node. Signed-off-by: Enric Balletbo i Serra --- arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm

Re: [PATCH v6 4/4] platform/chrome: rtc: Add RTC driver

2019-02-08 Thread Enric Balletbo i Serra
hwclock --show --rtc /dev/rtc1 > 2018-11-29 17:08:00.780793-08:00 > > Signed-off-by: Duncan Laurie > Signed-off-by: Nick Crews I think that you missed :) Acked-by: Enric Balletbo i Serra Acked-by: Alexandre Belloni > --- > > Changes in v6: > - In the core, actually u

[PATCH v2] mfd: cros_ec_dev: Return number of bytes read with CROS_EC_DEV_IOCRDMEM

2019-02-06 Thread Enric Balletbo i Serra
success. This is both inconsistent and problematic, since the amount of returned data can be dynamic. Have it return the number of data bytes for consistency. Signed-off-by: Guenter Roeck Signed-off-by: Enric Balletbo i Serra --- Hi, This patch was send long time ago and never landed to mainline [1

[PATCH] MAINTAINERS: chrome-platform: change the git tree to a chrome-platform group git tree

2019-02-01 Thread Enric Balletbo i Serra
Update the git tree URL for Chrome Platform drivers to point to a Chrome Platform Group managed URL. Signed-off-by: Enric Balletbo i Serra --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 51029a425dbe..a3c8b094228c 100644 --- a

[PATCH v3 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Also fix the module license mismatch and change the term 'Chrome OS' for 'ChromeOS' to be coherent with other drivers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck ---

[PATCH v3 05/12] platform/chrome: cros_ec_vbc: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes in v3: None Changes in v2: None drivers/platform/chrome/cros_ec_vbc.c | 24 +--- 1 file changed, 5 insertions

[PATCH v3 02/12] platform/chrome: cros_ec_debugfs: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes in v3: None Changes in v2: None drivers/platform/chrome/cros_ec_debugfs.c | 22 -- 1 file changed, 4 insertions

[PATCH v3 08/12] platform/chrome: cros_ec_proto: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes in v3: None Changes in v2: None drivers/platform/chrome/cros_ec_proto.c | 19 --- 1 file changed, 4 insertions(+), 15

[PATCH v3 07/12] platform/chrome: cros_ec_lpc: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Also remove the license boiler-plate and redundant driver description. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes in v3: None Changes in v2: None drivers/platform/chrome

[PATCH v3 11/12] platform/chrome: cros_ec_lightbar: remove pr_fmt() define

2019-01-29 Thread Enric Balletbo i Serra
This driver no longer has any pr_{level} messages. Remove the pr_fmt(). Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes in v3: None Changes in v2: None drivers/platform/chrome/cros_ec_lightbar.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers

[PATCH v3 03/12] platform/chrome: cros_ec_lightbar: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes in v3: None Changes in v2: None drivers/platform/chrome/cros_ec_lightbar.c | 22 -- 1 file changed, 4 insertions

[PATCH v3 06/12] platform/chrome: cros_ec_i2c: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Also fix the module license mismatch and change the description for a more descriptive phrase. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - cros_ec_i2c: Fix SPDX license tag. Changes in v2: None

[PATCH v3 00/12] platform/chrome: switch to SPDX license and some minor cleanup

2019-01-29 Thread Enric Balletbo i Serra
SPDX license tag. Changes in v2: - Removed the patches that removed the unnused includes (were wrong). - Add patches for all files in platform/chrome that didn't switch yet. Enric Balletbo i Serra (12): platform/chrome: cromeos_pstore: switch to SPDX identifier platform/chrome: cros_

[PATCH v3 09/12] platform/chrome: cros_ec_spi: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Also change the description for one more appropriate. Signed-off-by: Enric Balletbo i Serra --- Changes in v3: - cros_ec_spi: Fix SPDX license tag. Changes in v2: None drivers/platform/chrome/cros_ec_spi.c | 20

[PATCH v3 10/12] platform/chrome: cros_kbd_led_backlight: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Also change the term 'Chrome OS' for 'ChromeOS' to be coherent with other drivers. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes in v3: None Changes in v2: None

[PATCH v3 04/12] platform/chrome: cros_ec_sysfs: switch to SPDX identifier

2019-01-29 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Also change the description for one more appropriate. Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes in v3: None Changes in v2: None drivers/platform/chrome/cros_ec_sysfs.c | 24

[PATCH v3 12/12] platform/chrome: cros_ec_sysfs: remove pr_fmt() define

2019-01-29 Thread Enric Balletbo i Serra
This driver no longer has any pr_{level} messages. Remove the pr_fmt(). Signed-off-by: Enric Balletbo i Serra Reviewed-by: Guenter Roeck --- Changes in v3: None Changes in v2: None drivers/platform/chrome/cros_ec_sysfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform

[PATCH 2/3] arm64: dts: rockchip: fix rk3399-gru-kevin graph_port warning

2019-01-26 Thread Enric Balletbo i Serra
ingi (graph_port): /edp-panel/ports: graph port node name should be 'port' Signed-off-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-kevin.dts b

[PATCH 3/3] arm64: dts: rockchip: fix rk3399-sapphire-excavator graph_port warning

2019-01-26 Thread Enric Balletbo i Serra
5: Warning (graph_port): /edp-panel/ports: graph port node name should be 'port' Signed-off-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/rockchip/rk3399-sapphire-excavator.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3

[PATCH 1/3] arm64: dts: rockchip: fix rk3300-gru-bob graph_port warning

2019-01-26 Thread Enric Balletbo i Serra
(graph_port): /edp-panel/ports: graph port node name should be 'port' Signed-off-by: Enric Balletbo i Serra --- arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts b/arch/ar

[PATCH v2 02/12] platform/chrome: cros_ec_debugfs: switch to SPDX identifier

2019-01-26 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/platform/chrome/cros_ec_debugfs.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers/platform

[PATCH v2 01/12] platform/chrome: cromeos_pstore: switch to SPDX identifier

2019-01-26 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Also fix the module license mismatch and change the term 'Chrome OS' for 'ChromeOS' to be coherent with other drivers. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Removed the patc

[PATCH v2 05/12] platform/chrome: cros_ec_vbc: switch to SPDX identifier

2019-01-26 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/platform/chrome/cros_ec_vbc.c | 24 +--- 1 file changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/platform

[PATCH v2 00/12] platform/chrome: switch to SPDX license and some minor cleanup

2019-01-26 Thread Enric Balletbo i Serra
s for all files in platform/chrome that didn't switch yet. Enric Balletbo i Serra (12): platform/chrome: cromeos_pstore: switch to SPDX identifier platform/chrome: cros_ec_debugfs: switch to SPDX identifier platform/chrome: cros_ec_lightbar: switch to SPDX identifier platform/chrome: cro

[PATCH v2 03/12] platform/chrome: cros_ec_lightbar: switch to SPDX identifier

2019-01-26 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/platform/chrome/cros_ec_lightbar.c | 22 -- 1 file changed, 4 insertions(+), 18 deletions(-) diff --git a/drivers

[PATCH v2 11/12] platform/chrome: cros_ec_lightbar: remove pr_fmt() define

2019-01-26 Thread Enric Balletbo i Serra
This driver no longer has any pr_{level} messages. Remove the pr_fmt(). Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/platform/chrome/cros_ec_lightbar.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform

[PATCH v2 10/12] platform/chrome: cros_kbd_led_backlight: switch to SPDX identifier

2019-01-26 Thread Enric Balletbo i Serra
Adopt the SPDX license identifier headers to ease license compliance management. Also change the term 'Chrome OS' for 'ChromeOS' to be coherent with other drivers. Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None .../platform/chrome/cros_kbd_l

<    2   3   4   5   6   7   8   9   10   11   >