16-08-19
19:36:22 -0700)
This pull request brings in interlaced vblank timing and a 3D
rendering memory/CPU overhead reduction.
Eric Anholt (1):
drm/vc4: Don
The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc:
Linux 4.8-rc1 (2016-08-07 18:18:00 -0700)
are available in the git repository at:
https://github.com/anholt/linux bcm2835-dt-next-2016-08-29
for you to fetch changes up to c8336249c1eeca288919e3286f7dd03ae1d8ceae:
This came from the initial bringup code, which always idled the GPU
and always reset the overflow. That massively increases the size of
the working set when you're doing lots of small draws, though, as is
common on X desktops or piglit.
Signed-off-by: Eric Anholt
---
drivers/gpu/dr
ned-off-by: Ian Campbell
> Acked-by: Mark Rutland
> Tested-by: Stefan Wahren
I'd lost track of these patches, sorry. Both are:
Acked-by: Eric Anholt
They're going through the -soc tree, right?
signature.asc
Description: PGP signature
Rob Clark writes:
> On Tue, Jul 26, 2016 at 7:11 PM, Eric Anholt wrote:
>> Rob Clark writes:
>>
>>> On Tue, Jul 26, 2016 at 4:47 PM, Eric Anholt wrote:
>>>> Overflow memory handling is tricky: While it's still referenced by the
>>>> BPO reg
Rob Clark writes:
> On Tue, Jul 26, 2016 at 4:47 PM, Eric Anholt wrote:
>> Overflow memory handling is tricky: While it's still referenced by the
>> BPO registers, we want to keep it from being freed. When we are
>> putting a new set of overflow memory in the regis
The BO cache will complain if BOs are still allocated when we try to
destroy it (since freeing those BOs would try to hit the cache). You
could hit this if you were to unload the module after a GPU hang.
Signed-off-by: Eric Anholt
Fixes: 214613656b51 ("drm/vc4: Add an interface for capt
Here are a bunch of miscellaneous fixes for 3D I've come up with while
doing a bunch of piglit runs. One has a new IGT test sent out, and
I've got a test almost ready for large CLs.
Eric Anholt (6):
drm/vc4: Use drm_free_large() on handles to match its allocation.
drm/vc4: Use drm
If you managed to exceed the limit to switch to vmalloc, we'd use the
wrong free.
Signed-off-by: Eric Anholt
Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.")
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/vc4/vc4_gem.c | 2 +-
1 file changed, 1 insertion
If the device was already up, a 1 is returned instead of 0. We were
erroring out, leading the 3D driver to sometimes fail at screen
initialization (generally with ENOENT returned to it).
Signed-off-by: Eric Anholt
Fixes: af713795c59f ("drm/vc4: Add a getparam ioctl for getting the V3D
ide
We'd end up NULL pointer dereferencing because we didn't take the
error path out in the parent. Fixes igt vc4_lookup_fail test.
Signed-off-by: Eric Anholt
Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.")
Cc: sta...@vger.kernel.org
---
drivers/gpu/drm/vc4
x27;s currently running in the binner", but since
the bin/render submission split, we may end up with the binner
completing and having no new job while the renderer is still
processing. So, if we don't find a bin job at all, look at the
highest-seqno (last) render job to attach our overflow
If you exceeded the size that kmalloc would return, you'd get a dmesg
warning and an error from the job submit. We can handle much larger
allocations with vmalloc, and drm_malloc_ab makes that decision.
Fixes failure in piglit's scissor-many.
Signed-off-by: Eric Anholt
---
drivers/g
arch/arm/configs/bcm2835_defconfig:CONFIG_CC_STACKPROTECTOR_REGULAR=y
>$
I don't see why rpi1 shoud be special, so for bcm2835:
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
s in vc4 shader validation for branching,
allowing GLSL shaders with non-unrolled loops.
--------
Eric Anholt (7):
drm/vc4: Add a getparam ioctl for getting the V3D identity regs.
drm/vc4: Move validation's current/max ip into t
Eric Anholt writes:
> This isn't used yet, it's just a first step toward loop validation.
> During the main parsing of instructions, we need to know when we hit a
> new basic block so that we can reset validated state.
>
> Signed-off-by: Eric Anholt
>
Rasmus Villemoes writes:
> bcm2835_wdt_set_timeout does exactly what the watchdog framework does
> in the absence of a ->set_timeout callback (see watchdog_set_timeout
> in watchdog_dev.c), so remove it.
These first two patches are:
Acked-by: Eric Anholt
signature.asc
Desc
Clark in review)
Signed-off-by: Eric Anholt
Acked-by: Daniel Vetter (v2)
Reviewed-by: Rob Clark (v3, over irc)
---
drivers/gpu/drm/vc4/vc4_drv.c | 42 ++
include/uapi/drm/vc4_drm.h| 12
2 files changed, 54 insertions(+)
diff --git a/dr
drm/vc4: clean up error exit path on failed dpi_connector allocation
drm/vc4: remove redundant ret status check
Eric Anholt (2):
Merge tag 'drm-vc4-fixes-2016-06-06' into drm-vc4-next
drm/vc4: Bind the HVS before we bind the individual CRTCs.
Mario Kleiner
Thierry Reding writes:
> On Wed, Jun 01, 2016 at 12:18:01PM -0700, Eric Anholt wrote:
>> It appears to have no callers.
>>
>> Signed-off-by: Eric Anholt
>> ---
>> drivers/gpu/drm/panel/panel-simple.c | 18 --
>> include/drm/drm_pan
As I extend the driver to support different V3D revisions, userspace
needs to know what version it's targeting. This is most easily
detected using the V3D identity registers.
v2: Make sure V3D is runtime PM on when reading the registers.
Signed-off-by: Eric Anholt
---
drivers/gpu/dr
Colin King writes:
> From: Colin Ian King
>
> At the current point where ret is being checked for non-zero it has
> not changed since it was initialized to zero, hence the check and the
> label unref are redundant and can be removed.
Reviewed-by: Eric Anholt
I'll put
Mario Kleiner writes:
> Hi Eric,
>
> thanks for all the infos and help! Both your patches look good and i
> have successfully tested them on top of with my vblank timestamping patch.
>
> So for both:
>
> Reviewed-and-tested-by: Mario Kleiner
>
> Will you squash 2/2 into my patch or should i res
We need to be able to look at the CRTC's registers in the HVS as part
of initialization, while the HVS doesn't need to look at the PV
registers.
Signed-off-by: Eric Anholt
---
This commit would be slipped in before Mario's commit.
drivers/gpu/drm/vc4/vc4_drv.c | 2 +-
1
Read out the DISPBASE registers to decide on the FIFO size.
Signed-off-by: Eric Anholt
---
Mario: How about this for a squash into your commit? Here are the
values I dumped for cob_size:
[2.148314] [drm] Scaler 0 size 5232
[2.162239] [drm] Scaler 2 size 2048
[2.172957] [drm
Peter Chen writes:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Eric Anholt
> Signed-off-by: Peter Chen
Applied this to drm-vc4-next. Thanks!
signature.asc
Description: PGP signature
t; There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can
> replace the 'select' with a dependency.
>
> Signed-off-by: Arnd Bergmann
Acked-by: Eric Anholt
I'm guessing you'll take this patch directly.
signature.asc
Description: PGP signature
Peter Chen writes:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: Eric Anholt
> Signed-off-by: Peter Chen
> ---
> drivers/gpu/drm/vc4/vc4_hdmi.c | 13 +++--
> 1 file changed, 7 in
As I extend the driver to support different V3D revisions, userspace
needs to know what version it's targeting. This is most easily
detected using the V3D identity registers.
Signed-off-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_drv.c | 25 +
include/uapi/drm/vc4_
nd at
draw call time fix up the uniform stream to have the address of the
start of the shader's uniforms at that location.
Signed-off-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_drv.h | 3 +
drivers/gpu/drm/vc4/vc4_qpu_defines.h | 3 +
drivers/gpu/drm/vc4/vc4_validate.
Userspace needs to know if it can create shaders that do branching.
Otherwise, for backwards compatibility with old kernels it needs to
lower if statements to conditional assignments.
Signed-off-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_drv.c | 3 +++
include/uapi/drm/vc4_drm.h| 1 +
2
ps and I'll try to get an
identity getparam patch sent out tomorrow.
Eric Anholt (7):
drm/vc4: Add a getparam ioctl for getting the V3D identity regs.
drm/vc4: Move validation's current/max ip into the validation struct.
drm/vc4: Add a bitmap of branch targets during shader validatio
We don't use it in shader validation currently, so it had no effect,
but best to fix it anyway in case we do some day.
Signed-off-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_qpu_defines.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_qpu_defi
Reduces the argument count for some of the functions, and will be used
more with the upcoming looping support.
Signed-off-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_validate_shaders.c | 54 +-
1 file changed, 30 insertions(+), 24 deletions(-)
diff --git a/drivers
Signed-off-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_validate_shaders.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vc4/vc4_validate_shaders.c
b/drivers/gpu/drm/vc4/vc4_validate_shaders.c
index 302ce68e24cd..d126145c60ca 100644
--- a/drivers/gpu/drm/vc4
This isn't used yet, it's just a first step toward loop validation.
During the main parsing of instructions, we need to know when we hit a
new basic block so that we can reset validated state.
Signed-off-by: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_qpu_defines.h | 12 +++
drive
Wolfram Sang writes:
>> +/*
>> + * SMBUS says "Devices participating in a transfer will
>> + * timeout when any clock low exceeds the value of
>> + * T_TIMEOUT,MIN of 25 ms."
>> + */
>
> SMBus has that timeout, but I2C doesn't. How about disabling the timeout
> simply? Or usin
dress.
Eric Anholt (3):
dt-bindings: Add root properties for Raspberry Pi 3
ARM: bcm2835: Add devicetree for the Raspberry Pi 3.
Merge tag 'bcm2835-dt-ethernet' into HEAD
Gerd Hoffmann (1):
ARM: bcm2837: dt: Add the ethernet to t
It looks like we didn't get an updated defconfig patch while I was
gone, so I'm sending my pull requests for Pi3 and ethernet in the DT
now (the same stuff that's been in -next the whole time). I think
it's still worth it to have Pi3 present in 4.8, even if we don't have
the defconfig in place yet
-0700)
This pull request brings in the build support for the Raspberry Pi
arm64 port.
Alexander Graf (1):
arm64: Allow for different DMA and CPU bus offsets
Eric
Linux 4.7-rc1 (2016-05-29 09:29:24 -0700)
are available in the git repository at:
https://github.com/anholt/linux tags/bcm2835-dt-next-2016-07-03
for you to fetch changes up to 6a93792774fc72861b7e8efaa3545a88272b4413:
ARM: bcm2835: dt: Add the ethernet to the device trees (2016-05-31 10:
success in the init
> function.
>
> Signed-off-by: Daniel Lezcano
For the bcm2835 changes here and in 63/63:
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
Catalin Marinas writes:
> On Tue, Jun 14, 2016 at 11:48:54PM -0700, Eric Anholt wrote:
>> Catalin Marinas writes:
>>
>> > On Thu, Jun 09, 2016 at 05:21:35PM -0700, Eric Anholt wrote:
>> >> Catalin Marinas writes:
>> >> > On Sat,
Catalin Marinas writes:
> On Thu, Jun 09, 2016 at 05:21:35PM -0700, Eric Anholt wrote:
>> Catalin Marinas writes:
>> > On Sat, Jun 04, 2016 at 12:55:15PM -0700, Eric Anholt wrote:
>> >> Catalin Marinas writes:
>> >> > On Fri, Jun 03,
Linus Walleij writes:
> On Fri, Jun 3, 2016 at 8:18 AM, Gerd Hoffmann wrote:
>
>> There is no ARCH_BCM on arm64, and we need pinctrl-bcm2835 for the rpi3.
>>
>> Signed-off-by: Gerd Hoffmann
>
> I see I got an identical patch from Florian Fainelli and applied it.
> Sorry for my clashes, confusio
* latency of fetching the CBs.
*/
if (period_remaining < max_len * 2) {
control_block->length =
DIV_ROUND_UP(period_remaining, 8) * 4;
}
/* update number of bytes in this period so far */
*total_len += control_block-&g
for a long time, and this fix
is pretty dependent on the recent refactors.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
Catalin Marinas writes:
> On Sat, Jun 04, 2016 at 12:55:15PM -0700, Eric Anholt wrote:
>> Catalin Marinas writes:
>> > On Fri, Jun 03, 2016 at 08:18:23AM +0200, Gerd Hoffmann wrote:
>> >> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platform
;s ACK?
It looks like this is the only instance of filtering the directory on
CONFIG_ARCH_BCM, so regardless of the patch 4 resolution,
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
Linus Walleij writes:
> On Wed, Jun 1, 2016 at 11:43 PM, Gerd Hoffmann wrote:
>
>> +#define FXL6408_OUTPUT 0x05
>> +/* Bits here make the output High-Z, instead of the OUTPUT value. */
>> +#define FXL6408_OUTPUT_HIGH_Z 0x07
> (...)
>> + /* Disable High-Z of outputs
Arnd Bergmann writes:
> On Friday, June 3, 2016 8:18:24 AM CEST Gerd Hoffmann wrote:
>> From: Eric Anholt
>>
>> Made with make defconfig; make menuconfig (only saying Y to new
>> entries); make savedefconfig.
>
> Please try not to mix 'make savedefconfi
Stephen Rothwell writes:
> Hi Eric,
>
> On Mon, 06 Jun 2016 15:08:26 -0700 Eric Anholt wrote:
>>
>> I was going to bother you to add a bunch more trees to pull into -next
>> now that I'll be merging arm64 changes for the Raspberry Pi 3, but
>> instead
Vinod Koul writes:
> On Mon, Jun 06, 2016 at 11:10:38PM -0700, Eric Anholt wrote:
>> >> >> - if (ret == DMA_COMPLETE || !txstate)
>> >> >> + if (ret == DMA_COMPLETE)
>> >> >
>> >> > Why do you change this? txstate c
#x27; was not
> declared. Should it be static?
Reviewed-by: Eric Anholt
PM folks: I'd be happy to see this go through your trees, but either way
is fine with me.
signature.asc
Description: PGP signature
Vinod Koul writes:
> On Mon, Jun 06, 2016 at 10:33:18AM -0700, Eric Anholt wrote:
>> Vinod Koul writes:
>>
>> > On Fri, Jun 03, 2016 at 07:29:11PM -0700, Eric Anholt wrote:
>> >> The tx_status hook is supposed to be safe to call from interrupt
>&g
Gerd Hoffmann writes:
> From: Eric Anholt
>
> This commit needs to be split up and cleaned up. Also we should add
> interrupt support before pushing upstream.
>
> Signed-off-by: Eric Anholt
OK, I've confirmed with the firmware maintainers: We really can't drive
th
I was going to bother you to add a bunch more trees to pull into -next
now that I'll be merging arm64 changes for the Raspberry Pi 3, but
instead I've decided to start using the maint-scripts to make generating
a single for-next branch trivial.
So, could you replace all of my -next branches you're
Colin King writes:
> From: Colin Ian King
>
> There is redundant code in the clean up exit path when dpi_connector
> fails to be allocated. The current code checks if connector is NULL
> before destroying it, in fact, connector is NULL at this point so
> the check is redundant and can be remove
Linux 4.7-rc1 (2016-05-29 09:29:24 -0700)
are available in the git repository at:
g...@github.com:anholt/linux.git tags/drm-vc4-fixes-2016-06-06
for you to fetch changes up to 56d1fe0979dc9b73c1c12ee07722ac380d42a0c4:
drm/vc4: Make pageflip completion handling more robust. (2016-06-06 13:
Vinod Koul writes:
> On Fri, Jun 03, 2016 at 07:29:11PM -0700, Eric Anholt wrote:
>> The tx_status hook is supposed to be safe to call from interrupt
>> context, but it wouldn't ever return completion for the last transfer,
>> meaning you couldn't poll for DMA co
Vinod Koul writes:
> On Fri, Jun 03, 2016 at 07:23:33PM -0700, Eric Anholt wrote:
>> The min() macro was complaining about mismatched types. The max len
>> is at most SZ_1G, so we can just put it in an unsigned int.
>>
>> Signed-off-by: Eric Anholt
>> ---
>
Catalin Marinas writes:
> On Fri, Jun 03, 2016 at 08:18:23AM +0200, Gerd Hoffmann wrote:
>> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>> index 7ef1d05..ea88402 100644
>> --- a/arch/arm64/Kconfig.platforms
>> +++ b/arch/arm64/Kconfig.platforms
>> @@ -13,6 +13,19 @@ c
ne to write its registers due to a bug in the AXI bridge.
Signed-off-by: Eric Anholt
---
drivers/dma/bcm2835-dma.c | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/bcm2835-dma.c b/drivers/dma/bcm2835-dma.c
index 6149b27c33ad..320461c578
The min() macro was complaining about mismatched types. The max len
is at most SZ_1G, so we can just put it in an unsigned int.
Signed-off-by: Eric Anholt
---
Vinod, if you ack it, this one would be nice to be able to merge
through the -soc tree, so that when we enable of arm64 builds of this
Stefan Wahren writes:
> Hi Eric,
>
>> Eric Anholt hat am 2. Juni 2016 um 20:18 geschrieben:
>>
>>
>> Stefan Wahren writes:
>>
>> > Hi Gerd,
>> >
>> > Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann:
>> >> From: Eric Anh
Arnd Bergmann writes:
> On Wednesday, June 1, 2016 11:43:19 PM CEST Gerd Hoffmann wrote:
>> From: Eric Anholt
>>
>> ---
>>
>
> No signoff or description?
This commit should not have been sent out as is. Gerd took a bunch of
messy commits from my trees that
Stephen Boyd writes:
> Now that we have clk_hw based provider APIs to register clks, we
> can get rid of struct clk pointers while registering clks in
> these drivers, allowing us to move closer to a clear split of
> consumer and provider clk APIs.
This looks good, but it'll conflict with the fi
Stefan Wahren writes:
> Hi Gerd,
>
> Am 01.06.2016 um 23:43 schrieb Gerd Hoffmann:
>> From: Eric Anholt
>>
>> With this we can get wifi (brcmfmac) to probe. Without it we're stuck
>> with timeouts from sdio.c when it tries to set the bus width to 4.
>
Arnd Bergmann writes:
> On Wednesday, June 1, 2016 11:43:30 PM CEST Gerd Hoffmann wrote:
>> +/* Parse OF address directly to get the physical address for
>> + * DMA to our registers.
>> + */
>> +host->phys_addr = be32_to_cpup(of_get_address(pdev->dev.of_node, 0,
>> +
Jason Cooper writes:
> Hey Gerd,
>
> On Wed, Jun 01, 2016 at 11:43:12PM +0200, Gerd Hoffmann wrote:
>> From: Eric Anholt
>>
>> This is equivalent and works for arm64 as well.
>>
>> Signed-off-by: Eric Anholt
>> ---
>
> I don't min
Stefan Wahren writes:
> Hi Eric,
>
> Am 02.06.2016 um 00:07 schrieb Eric Anholt:
>> The register at poweron contains 0x40, which at our typical 100khz bus
>> rate means .64ms instead of the desired 25ms.
>>
>> Fixes many clock stretching timeouts when talking
-by: Herve Jourdain
Signed-off-by: Eric Anholt
Fixes: 0cd3e2747662 ("drm/vc4: Add missing render node support")
---
drivers/gpu/drm/vc4/vc4_drv.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.
Arnd Bergmann writes:
> On Wednesday, June 1, 2016 11:43:18 PM CEST Gerd Hoffmann wrote:
>> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
>> new file mode 100644
>> index 000..36178a6
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.
ff-by: Eric Anholt
---
drivers/i2c/busses/i2c-bcm2835.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 818b051d25e6..1348f224013d 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busse
It appears to have no callers.
Signed-off-by: Eric Anholt
---
drivers/gpu/drm/panel/panel-simple.c | 18 --
include/drm/drm_panel.h | 4
2 files changed, 22 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c
b/drivers/gpu/drm/panel/panel-simple.c
ication to Linux.
On my system, this moves the Linux-enabled HDMI state machine and DSI1
escape clock over to plld_per from pllc_per. EMMC still ends up on
pllc_per, because the firmware had set it up to use that.
Signed-off-by: Eric Anholt
Fixes: 41691b8862e2 ("clk: bcm2835: Add support for
choose SDRAM's parent for some other
clock, then disable that clock.
Signed-off-by: Eric Anholt
---
drivers/clk/bcm/clk-bcm2835.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 400615b
fixes are all suitable for 4.7.
Eric Anholt (4):
clk: bcm2835: Mark the VPU clock as critical
clk: bcm2835: Mark GPIO clocks enabled at boot as critical
clk: bcm2835: Mark the CM SDRAM clock's parent as critical
clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent
driv
x27;s refcount going to 0.
Signed-off-by: Eric Anholt
---
v3: Only mark critical if it's on at boot.
drivers/clk/bcm/clk-bcm2835.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index d9db03cb3fd8..40
The VPU clock is also the clock for our AXI bus, so we really can't
disable it. This might have happened during boot if, for example,
uart1 (aux_uart clock) probed and was then disabled before the other
consumers of the VPU clock had probed.
Signed-off-by: Eric Anholt
---
v2: Rewrite to
This is equivalent and works for arm64 as well.
Signed-off-by: Eric Anholt
Acked-by: Stephen Warren
---
Patch 1 of the arm64 series was left out of the 4.7 pull request.
Would it be possible to merge this through the SOC tree? Otherwise I
would need a stable branch to merge from you, so that
Yendapally Reddy Dhananjaya Reddy
writes:
> Document the bindings used by Northstar Plus(NSP) SoC random number
> generator.
>
> Signed-off-by: Yendapally Reddy Dhananjaya Reddy
>
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
eanup: here and in the return statement, drop the extra
parenthesis.
Functionality-wise, this patch looks great to me, and should make the
driver more efficient. With at least the binary operators change done,
it will be:
Reviewed-by: Eric Anholt
Thanks!
signature.asc
Description: PGP signature
, even though the firmware has presumably been setting it for us
already.
However, this patch is still correct and I'm fine with it, so it's:
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
Here are a few late bugfixes for vc4. I figure it's best to bring
them in through -next since 4.6 is about done. I've based them late
in your -next branch to avoid needing conflict resolution.
The following changes since commit bafb86f5bc3173479002555dea7f31d943b12332:
Merge tag 'v4.6-rc7' in
Martin Sperl writes:
> On 10.05.2016, at 21:58, Martin Sperl wrote:
>>
>>
>>
>>> On 10.05.2016, at 19:37, Eric Anholt wrote:
>>>
>>> Martin Sperl writes:
>>>
>>>>> On 10.05.2016 03:01, Eric Anholt wrote:
&g
Martin Sperl writes:
>> On 10.05.2016, at 19:37, Eric Anholt wrote:
>>
>> Martin Sperl writes:
>>> and also hsm (probably hardware security module):
>>> root@raspcm:~# cat /sys/kernel/debug/clk/hsm/regdump
>>> ctl = 0x02d6
>>> div = 0
ker...@martin.sperl.org writes:
> From: Martin Sperl
>
> As the sdram clock is a critical clock to the system
> the minimal bcm2835-sdram driver claims (and enables)
> this clock and also exposes the corresponding sdram
> registers via debugfs.
I don't think this is a good solution to the proble
Stephen Boyd writes:
> On 05/09, Eric Anholt wrote:
>> If the firmware had set up a clock to source from PLLC, go along with
>> it. But if we're looking for a new parent, we don't want to switch it
>> to PLLC because the firmware will force PLLC (and thus the
Martin Sperl writes:
> On 10.05.2016 03:01, Eric Anholt wrote:
>> With the new patch 2 inserted between my previous pair, I think this
>> should cover Martin's bugs with clock disabling.
>>
>> I tested patch 2 to be important on the downstream kernel: with the
>
Robert Foss writes:
> On 2016-05-03 03:22 PM, Eric Anholt wrote:
>> robert.f...@collabora.com writes:
>>
>>> From: Robert Foss
>>>
>>> As per the documentation in drm_crtc.h, atomic_commit should return
>>> -EBUSY if an asycnhronous update is r
ication to Linux.
On my system, this moves the Linux-enabled HDMI state machine and DSI1
escape clock over to plld_per from pllc_per. EMMC still ends up on
pllc_per, because the firmware had set it up to use that.
Signed-off-by: Eric Anholt
Fixes: 41691b8862e2 ("clk: bcm2835: Add support for
D_PER got disabled due to
EPROBE_DEFER.
Eric Anholt (3):
clk: bcm2835: Mark the VPU clock as critical
clk: bcm2835: Mark GPIO clocks enabled at boot as critical.
clk: bcm2835: Skip PLLC clocks when deciding on a new clock parent
drivers/clk/bcm/clk-bcm2835.c | 32 ++
The VPU clock is also the clock for our AXI bus, so we really can't
disable it. This might have happened during boot if, for example,
uart1 (aux_uart clock) probed and was then disabled before the other
consumers of the VPU clock had probed.
Signed-off-by: Eric Anholt
---
v2: Rewrite to
x27;s refcount going to 0.
Signed-off-by: Eric Anholt
---
drivers/clk/bcm/clk-bcm2835.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index d9db03cb3fd8..1091012ecec6 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
robert.f...@collabora.com writes:
> From: Robert Foss
>
> As per the documentation in drm_crtc.h, atomic_commit should return
> -EBUSY if an asycnhronous update is requested and there is an earlier
> update pending.
>
> Note: docs cited here are drm_crtc.h, and the whole quote is:
>
> * - -E
Robert Foss writes:
> On 05/02/2016 08:57 PM, Eric Anholt wrote:
>> robert.f...@collabora.com writes:
>>
>>> From: Robert Foss
>>>
>>> As per the docs, atomic_commit should return -EBUSY "if an asycnhronous
>>> update is requested and the
-0700)
This pull request brings in DPI panel support, gamma ramp support, and
render nodes for vc4.
Eric Anholt (5):
drm: Add an encoder and connector type enum for DPI.
drm/vc4: Add DPI driver
drm/vc4: Fix NULL deref in
Martin Sperl writes:
>> On 02.05.2016, at 17:29, Eric Anholt wrote:
>>
>> Martin Sperl writes:
>>
>>>> On 26.04.2016, at 21:39, Eric Anholt wrote:
>>>>
>>>> If the firmware had set up a clock to source from PLLC, go along with
&g
robert.f...@collabora.com writes:
> From: Robert Foss
>
> As per the docs, atomic_commit should return -EBUSY "if an asycnhronous
> update is requested and there is an earlier update pending".
Note: docs cited here are drm_crtc.h, and the whole quote is:
* - -EBUSY, if an asynchronous
801 - 900 of 1368 matches
Mail list logo