Re: [PATCH] w1: ds2482: Add i2c module alias name

2015-05-29 Thread Evgeniy Polyakov
Hi everyone 27.05.2015, 01:38, "Ludek Hlavacek" : > Add i2c alias to enable autoloading of the module for device specified > in device-tree. > > Signed-off-by: Ludek Hlavacek This looks good to me, Greg, please pull to your tree. Thank you. Acked-by: Evgeniy Polyakov

Re: [PATCH] w1: ds2482: Add i2c module alias name

2015-05-29 Thread Evgeniy Polyakov
Hi everyone 27.05.2015, 01:38, Ludek Hlavacek lude...@seznam.cz: Add i2c alias to enable autoloading of the module for device specified in device-tree. Signed-off-by: Ludek Hlavacek lude...@seznam.cz This looks good to me, Greg, please pull to your tree. Thank you. Acked-by: Evgeniy

Re: [PATCH] w1: Fix typo in MODULE_DESCRIPTION in matrox_w1.c

2015-05-21 Thread Evgeniy Polyakov
Hi 21.05.2015, 16:41, "Masanari Iida" : > This patch fix spelling typo in matrox_w1.c > > Signed-off-by: Masanari Iida Looks good to me, please pull it into the tree Acked-by: Evgeniy Polyakov > --- >  drivers/w1/masters/matrox_w1.c | 2 +- >  1 file changed

Re: [PATCH] w1: Fix typo in MODULE_DESCRIPTION in matrox_w1.c

2015-05-21 Thread Evgeniy Polyakov
Hi 21.05.2015, 16:41, Masanari Iida standby2...@gmail.com: This patch fix spelling typo in matrox_w1.c Signed-off-by: Masanari Iida standby2...@gmail.com Looks good to me, please pull it into the tree Acked-by: Evgeniy Polyakov z...@ioremap.net ---  drivers/w1/masters/matrox_w1.c | 2

Re: [PATCH v3] w1: introduce an ability to specify microseconds bus scanning intervals

2015-05-13 Thread Evgeniy Polyakov
by: Dmitry Khromov Greg, please pull it upstream Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH RESEND] w1: masters: omap_hdq: Add support for 1-wire mode

2015-05-13 Thread Evgeniy Polyakov
sent for v4.1 but was never picked up. >>  Here is the link to the previous patch >>  http://www.spinics.net/lists/linux-omap/msg116228.html > > Hi Andrew, Evgeniy Polyakov, > > Gentle ping > This patch has been waiting since 4.1 merge window. I believe it should go via omap t

Re: [PATCH] w1_therm reference count family data

2015-05-13 Thread Evgeniy Polyakov
e when it is no longer detected. > If that happens the sl->family_data will be freed and set to NULL > causing w1_slave_show to crash when it wakes up. > > Signed-off-by: David Fries > Reported-By: Thorsten Bschorr > Tested-by: Thorsten Bschorr > Acked-by: Evgeniy Polyakov

Re: [PATCH] w1_therm reference count family data

2015-05-13 Thread Evgeniy Polyakov
it is no longer detected. If that happens the sl-family_data will be freed and set to NULL causing w1_slave_show to crash when it wakes up. Signed-off-by: David Fries da...@fries.net Reported-By: Thorsten Bschorr thors...@bschorr.de Tested-by: Thorsten Bschorr thors...@bschorr.de Acked-by: Evgeniy

Re: [PATCH RESEND] w1: masters: omap_hdq: Add support for 1-wire mode

2015-05-13 Thread Evgeniy Polyakov
://www.spinics.net/lists/linux-omap/msg116228.html Hi Andrew, Evgeniy Polyakov, Gentle ping This patch has been waiting since 4.1 merge window. I believe it should go via omap tree. It looks good to me, Greg, please pull it upstream, if it continues to be quiet -- To unsubscribe from this list: send

Re: [PATCH v3] w1: introduce an ability to specify microseconds bus scanning intervals

2015-05-13 Thread Evgeniy Polyakov
...@icelogic.net Greg, please pull it upstream Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH]Add support for DS28EA00 sequence to w1-therm

2015-05-02 Thread Evgeniy Polyakov
Hi 28.04.2015, 14:44, "Matt Campbell" : > This patch provides support for the DS28EA00 digital thermometer. Patch looks good, Greg, please pull this patch into you tree -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] signals: Generate warning when flush_signals() is called from non-kthread context

2015-05-02 Thread Evgeniy Polyakov
Hi Ingo 01.05.2015, 22:38, "Ingo Molnar" : > * Linus Torvalds wrote: >>  On Fri, May 1, 2015 at 10:40 AM, Alex Williamson >>   wrote: >>>  - Flush signals on interrupted wait to retain polling interval (Alex >>> Williamson) >>  This cannot *possibly* be right. If I read this patch right, you're

Re: [PATCH] signals: Generate warning when flush_signals() is called from non-kthread context

2015-05-02 Thread Evgeniy Polyakov
Hi Ingo 01.05.2015, 22:38, Ingo Molnar mi...@kernel.org: * Linus Torvalds torva...@linux-foundation.org wrote:  On Fri, May 1, 2015 at 10:40 AM, Alex Williamson  alex.william...@redhat.com wrote:  - Flush signals on interrupted wait to retain polling interval (Alex Williamson)  This cannot

Re: [PATCH]Add support for DS28EA00 sequence to w1-therm

2015-05-02 Thread Evgeniy Polyakov
Hi 28.04.2015, 14:44, Matt Campbell mattrcampb...@gmail.com: This patch provides support for the DS28EA00 digital thermometer. Patch looks good, Greg, please pull this patch into you tree -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000

2015-04-30 Thread Evgeniy Polyakov
HI Marek 28.04.2015, 23:25, "Marek Belisko" : > bq2700 slave driver depends on bq27x00-battery driver thus adding this > dependency to config. When bq2700 is build as module bq27x00-battery > will be loaded automatically. > > Signed-off-by: Marek Belisko Patch looks good to me, but you should

Re: [PATCH] w1: slaves: Add dependency for W1_SLAVE_BQ27000

2015-04-30 Thread Evgeniy Polyakov
HI Marek 28.04.2015, 23:25, Marek Belisko ma...@goldelico.com: bq2700 slave driver depends on bq27x00-battery driver thus adding this dependency to config. When bq2700 is build as module bq27x00-battery will be loaded automatically. Signed-off-by: Marek Belisko ma...@goldelico.com Patch

Re: [PATCH]Add support for DS28AE00 sequence to w1-therm

2015-04-27 Thread Evgeniy Polyakov
Hi everyone 27.04.2015, 16:32, "Matt Campbell" : > This patch provides support for the DS28AE00 digital thermometer. Greg, please pull it into you tree, everything looks good to me -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH]Add support for DS28AE00 sequence to w1-therm

2015-04-27 Thread Evgeniy Polyakov
Hi everyone 27.04.2015, 16:32, Matt Campbell mattrcampb...@gmail.com: This patch provides support for the DS28AE00 digital thermometer. Greg, please pull it into you tree, everything looks good to me -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH v2] w1: introduce an ability to specify microseconds bus scanning intervals

2015-04-22 Thread Evgeniy Polyakov
Hi Looks good to me. Greg, please pull it into your tree. Acked-by: Evgeniy Polyakov 23.04.2015, 00:56, "Dmitry Khromov" : > Signed-off-by: Dmitry Khromov > --- >  drivers/w1/w1.c | 17 - >  1 file changed, 16 insertions(+), 1 deletion(-) > > di

Re: [PATCH v2] w1: introduce an ability to specify microseconds bus scanning intervals

2015-04-22 Thread Evgeniy Polyakov
Hi Looks good to me. Greg, please pull it into your tree. Acked-by: Evgeniy Polyakov z...@ioremap.net 23.04.2015, 00:56, Dmitry Khromov d...@icelogic.net: Signed-off-by: Dmitry Khromov d...@icelogic.net ---  drivers/w1/w1.c | 17 -  1 file changed, 16 insertions(+), 1

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-04-17 Thread Evgeniy Polyakov
Hi 16.04.2015, 15:00, "Thorsten Bschorr" : >> Let's push this patch upstream as a temporal fix until we are ready with the >> new solution. >> Thorsten, does it fix your crash? > > I'm running David's refcounting-patch for about 3 weeks now on my 3.18.y > kernel, and did not observe any

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-04-17 Thread Evgeniy Polyakov
Hi 16.04.2015, 15:00, Thorsten Bschorr thors...@bschorr.de: Let's push this patch upstream as a temporal fix until we are ready with the new solution. Thorsten, does it fix your crash? I'm running David's refcounting-patch for about 3 weeks now on my 3.18.y kernel, and did not observe any

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-04-16 Thread Evgeniy Polyakov
Hi David 16.04.2015, 06:52, "David Fries" : > It has not been solved.  Evgeniy would like to make use of the sysfs > device management instead of the current reference counting, however I > haven't heard any volunteers to do that work.  I posted a quick fix > patch, it was very easy to crash

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-04-16 Thread Evgeniy Polyakov
Hi David 16.04.2015, 06:52, David Fries da...@fries.net: It has not been solved.  Evgeniy would like to make use of the sysfs device management instead of the current reference counting, however I haven't heard any volunteers to do that work.  I posted a quick fix patch, it was very easy to

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-18 Thread Evgeniy Polyakov
Hi 18.03.2015, 07:20, "David Fries" : >  static void w1_therm_remove_slave(struct w1_slave *sl) >  { > + int refcnt = atomic_sub_return(1, THERM_REFCNT(sl->family_data)); > + while(refcnt) { > + msleep(1000); > + refcnt = atomic_read(THERM_REFCNT(sl->family_data)); > + } >  

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-18 Thread Evgeniy Polyakov
Hi 18.03.2015, 07:20, David Fries da...@fries.net:  static void w1_therm_remove_slave(struct w1_slave *sl)  { + int refcnt = atomic_sub_return(1, THERM_REFCNT(sl-family_data)); + while(refcnt) { + msleep(1000); + refcnt = atomic_read(THERM_REFCNT(sl-family_data)); + }  

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-14 Thread Evgeniy Polyakov
Hi David 12.03.2015, 03:54, "David Fries" : > Would that be removing all four refcnt, w1_slave, w1_master, > w1_family, w1_cb_block, or just some of them?  It sounds good to me, > if that had bugs there would be much more than just the w1 system > relying on it.  I don't know enough about that

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-14 Thread Evgeniy Polyakov
Hi David 12.03.2015, 03:54, David Fries da...@fries.net: Would that be removing all four refcnt, w1_slave, w1_master, w1_family, w1_cb_block, or just some of them?  It sounds good to me, if that had bugs there would be much more than just the w1 system relying on it.  I don't know enough

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-10 Thread Evgeniy Polyakov
Hi 10.03.2015, 02:09, "David Fries" : > diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c > index 1f11a20..39a9e6a 100644 > --- a/drivers/w1/slaves/w1_therm.c > +++ b/drivers/w1/slaves/w1_therm.c > @@ -59,9 +59,20 @@ MODULE_ALIAS("w1-family-"

Re: [PATCH] Avoid null-pointer access in w1/slaves/w1_therm

2015-03-10 Thread Evgeniy Polyakov
Hi 10.03.2015, 02:09, David Fries da...@fries.net: diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c index 1f11a20..39a9e6a 100644 --- a/drivers/w1/slaves/w1_therm.c +++ b/drivers/w1/slaves/w1_therm.c @@ -59,9 +59,20 @@ MODULE_ALIAS(w1-family-

Re: [PATCH netfilter-next] xt_osf: Use continue to reduce indentation

2014-12-17 Thread Evgeniy Polyakov
d. Thank you. Which tree should this patch go through? Please pull it in. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: [PATCH netfilter-next] xt_osf: Use continue to reduce indentation

2014-12-17 Thread Evgeniy Polyakov
should this patch go through? Please pull it in. Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [patch V2 35/64] connector: Use ktime_get_ns()

2014-07-16 Thread Evgeniy Polyakov
Hi 17.07.2014, 01:04, "Thomas Gleixner" : > Replace the ever recurring: > ts = ktime_get_ts(); > ns = timespec_to_ns(); > with > ns = ktime_get_ns(); > > Signed-off-by: Thomas Gleixner > Cc: Evgeniy Polyakov Looks good to me, thank you

Re: [patch V2 35/64] connector: Use ktime_get_ns()

2014-07-16 Thread Evgeniy Polyakov
Hi 17.07.2014, 01:04, Thomas Gleixner t...@linutronix.de: Replace the ever recurring: ts = ktime_get_ts(); ns = timespec_to_ns(ts); with ns = ktime_get_ns(); Signed-off-by: Thomas Gleixner t...@linutronix.de Cc: Evgeniy Polyakov z...@ioremap.net Looks good to me

Re: [PATCH 0/3] "printk" related fixes for the 1-wire (w1) subsystem

2014-06-19 Thread Evgeniy Polyakov
"pr_*" > function but also minor issues such as indentation and whitespace problems > in the immediate vicinity were addressed. Looks good to me Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: revised driver: w1_ds2406

2014-06-19 Thread Evgeniy Polyakov
d. > > Signed-off-by: Scott Alfter Greg, this patch looks good, please pull it into your tree. If you already applied previous ds2406, let us know. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majo

Re: revised driver: w1_ds2406

2014-06-19 Thread Evgeniy Polyakov
sc...@alfter.us Greg, this patch looks good, please pull it into your tree. If you already applied previous ds2406, let us know. Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 0/3] printk related fixes for the 1-wire (w1) subsystem

2014-06-19 Thread Evgeniy Polyakov
issues such as indentation and whitespace problems in the immediate vicinity were addressed. Looks good to me Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: new driver: w1_ds2406

2014-06-06 Thread Evgeniy Polyakov
Hi everyone Greg, please pull this patch into the tree 06.06.2014, 21:47, "Scott Alfter" : > On Thu, June 5, 2014 10:44, Evgeniy Polyakov wrote: >>  04.06.2014, 08:25, "Scott Alfter" : >>>  I have a project for which I needed support for the DS2406

Re: new driver: w1_ds2406

2014-06-06 Thread Evgeniy Polyakov
Hi everyone Greg, please pull this patch into the tree 06.06.2014, 21:47, Scott Alfter sc...@alfter.us: On Thu, June 5, 2014 10:44, Evgeniy Polyakov wrote:  04.06.2014, 08:25, Scott Alfter sc...@alfter.us:  I have a project for which I needed support for the DS2406 addressable  switch, so I

Re: [PATCH] drivers/w1/w1_int.c: Fix style errors.

2014-05-31 Thread Evgeniy Polyakov
st appropriate. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] drivers/w1/w1_int.c: Fix style errors.

2014-05-31 Thread Evgeniy Polyakov
or suggest appropriate. Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [RFC] w1: fixes and bundling replies

2014-04-08 Thread Evgeniy Polyakov
Hi David 07.04.2014, 18:13, "David Fries" : > Evgeniy, > Could you review this set of patches in this thread?  Thanks. I've checked it and it looks good, please resend it to lkml and Greg Kroah-Hartman, he will pull it into the tree. Feel free to add my Acked-by. -- To unsubscribe from this

Re: [RFC] w1: fixes and bundling replies

2014-04-08 Thread Evgeniy Polyakov
Hi David 07.04.2014, 18:13, David Fries da...@fries.net: Evgeniy, Could you review this set of patches in this thread?  Thanks. I've checked it and it looks good, please resend it to lkml and Greg Kroah-Hartman, he will pull it into the tree. Feel free to add my Acked-by. -- To unsubscribe

Re: [PATCH 1/4] w1: Remove excess dependencies on W1 for masters and slaves

2014-03-04 Thread Evgeniy Polyakov
Hi everyone 22.02.2014, 11:30, "Alexander Shiyan" : > Configuration for masters and slaves is included only if W1 symbol > enabled, so no reason to check it once more. > > Signed-off-by: Alexander Shiyan > --- >  drivers/w1/masters/Kconfig | 3 +-- >  drivers/w1/slaves/Kconfig  | 5 - >  2

Re: [PATCH 1/4] w1: Remove excess dependencies on W1 for masters and slaves

2014-03-04 Thread Evgeniy Polyakov
Hi everyone 22.02.2014, 11:30, Alexander Shiyan shc_w...@mail.ru: Configuration for masters and slaves is included only if W1 symbol enabled, so no reason to check it once more. Signed-off-by: Alexander Shiyan shc_w...@mail.ru ---  drivers/w1/masters/Kconfig | 3 +--  

Re: [PATCH] w1: bundle reply if the request was bundled

2014-02-20 Thread Evgeniy Polyakov
Hi 19.02.2014, 11:19, "David Fries" : > A program can bundle multiple messages and commands together when > making one wire requests, which is going to be much more efficient > than sending lots of little packets one write at a time.  With this > change the kernel will then bundle responses to

Re: [PATCH] w1: bundle reply if the request was bundled

2014-02-20 Thread Evgeniy Polyakov
Hi 19.02.2014, 11:19, David Fries da...@fries.net: A program can bundle multiple messages and commands together when making one wire requests, which is going to be much more efficient than sending lots of little packets one write at a time.  With this change the kernel will then bundle

Re: [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better

2014-02-18 Thread Evgeniy Polyakov
troller). In this case you still want to retry probing later instead > of ignoring the problem. > > Does that make it clearer? Well, yes, thank you :) Greg, please pull this patch into your tree. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better

2014-02-18 Thread Evgeniy Polyakov
). In this case you still want to retry probing later instead of ignoring the problem. Does that make it clearer? Well, yes, thank you :) Greg, please pull this patch into your tree. Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [patch v2] w1: small type cleanup in sysfs

2014-02-14 Thread Evgeniy Polyakov
his is more of a problem for static checkers than a real life issue, > but it's simple enough to fix. > > Acked-by: David Fries > Signed-off-by: Dan Carpenter Looks good to me, thank you Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [patch v2] w1: small type cleanup in sysfs

2014-02-14 Thread Evgeniy Polyakov
life issue, but it's simple enough to fix. Acked-by: David Fries da...@fries.net Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Looks good to me, thank you Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 16/16] hold bus_mutex in netlink and search

2014-01-15 Thread Evgeniy Polyakov
rch.  This was causing the ds2490 hardware to stop > responding when both netlink and /sys slaves were executing bus > commands at the same time. > > Signed-off-by: David Fries Looks good to me, thank you. Greg, please pull the whole set if you hadn't yet Acked-by: Evgeniy Polyakov -- T

Re: [PATCH 16/16] hold bus_mutex in netlink and search

2014-01-15 Thread Evgeniy Polyakov
.  This was causing the ds2490 hardware to stop responding when both netlink and /sys slaves were executing bus commands at the same time. Signed-off-by: David Fries da...@fries.net Looks good to me, thank you. Greg, please pull the whole set if you hadn't yet Acked-by: Evgeniy Polyakov z...@ioremap.net

Re: [PATCH 00/14] w1: async netlink, search, fixes, and improvements

2013-12-29 Thread Evgeniy Polyakov
Hi 29.12.2013, 10:46, "David Fries" : > This patch series aims to extend and improve the netlink interface to > the one wire system.  Netlink is exposed as a socket interface which I've reviewed all your patches and everything looks good. Thank you David Acked-by:

Re: [PATCH 00/14] w1: async netlink, search, fixes, and improvements

2013-12-29 Thread Evgeniy Polyakov
Hi 29.12.2013, 10:46, David Fries da...@fries.net: This patch series aims to extend and improve the netlink interface to the one wire system.  Netlink is exposed as a socket interface which I've reviewed all your patches and everything looks good. Thank you David Acked-by: Evgeniy Polyakov z

Re: [PATCH 4/4] w1: call put_device if device_register fails

2013-12-23 Thread Evgeniy Polyakov
Hi 19.12.2013, 03:47, "Greg KH" : > I don't seem to have this patch anywhere, can someone please resend it > to me? Andrew Morton picked it up http://www.spinics.net/lists/mm-commits/msg101101.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH 4/4] w1: call put_device if device_register fails

2013-12-23 Thread Evgeniy Polyakov
Hi 19.12.2013, 03:47, Greg KH gre...@linuxfoundation.org: I don't seem to have this patch anywhere, can someone please resend it to me? Andrew Morton picked it up http://www.spinics.net/lists/mm-commits/msg101101.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH 4/4] w1: call put_device if device_register fails

2013-12-14 Thread Evgeniy Polyakov
e right after it fails. Looks good to me, thank you Greg, please pull it into your treee > Signed-off-by: Levente Kurusa Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kern

Re: [PATCH 4/4] w1: call put_device if device_register fails

2013-12-14 Thread Evgeniy Polyakov
it fails. Looks good to me, thank you Greg, please pull it into your treee Signed-off-by: Levente Kurusa le...@linux.com Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field "clkdiv" from private structure

2013-11-30 Thread Evgeniy Polyakov
Hi 29.11.2013, 15:40, "Alexander Shiyan" : > Private field "clkdiv" is not used outside "probe", so there are > no reason to keep it in driver. The whole serie looks good, thank you Greg, please pull it into your tree > Signed-off-by: Alexan

Re: [PATCH 1/3] w1: mxc_w1: Remove unused field clkdiv from private structure

2013-11-30 Thread Evgeniy Polyakov
Hi 29.11.2013, 15:40, Alexander Shiyan shc_w...@mail.ru: Private field clkdiv is not used outside probe, so there are no reason to keep it in driver. The whole serie looks good, thank you Greg, please pull it into your tree Signed-off-by: Alexander Shiyan shc_w...@mail.ru Acked-by: Evgeniy

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-13 Thread Evgeniy Polyakov
Hi 13.11.2013, 08:07, "David Fries" : >>>>   Strong pullup is emulated by driving pin logic high after write >>>>   command when >>>>   using tri-state push-pull GPIO. > > Acked-by: David Fries > > Looks good to me. Ok, thank you

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-13 Thread Evgeniy Polyakov
Hi 13.11.2013, 08:07, David Fries da...@fries.net:   Strong pullup is emulated by driving pin logic high after write   command when   using tri-state push-pull GPIO. Acked-by: David Fries da...@fries.net Looks good to me. Ok, thank you Acked-by: Evgeniy Polyakov z...@ioremap.net Evgeny

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-11 Thread Evgeniy Polyakov
Hi 12.11.2013, 03:32, "Evgeny Boger" : >> Why did you drop this check? It has nothing with w1-gpio driver > This check prevents master from implementing "set_pullup"  provided it does > support only "write_bit" method. > The comment above states that >>  w1_io.c would need to support calling

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-11 Thread Evgeniy Polyakov
Hi 11.11.2013, 18:37, "Evgeny Boger" : >  Strong pullup is emulated by driving pin logic high after write command when >  using tri-state push-pull GPIO. > > Signed-off-by: Evgeny Boger > --- >  drivers/w1/masters/w1-gpio.c | 22 ++ >  drivers/w1/w1_int.c  | 12

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-11 Thread Evgeniy Polyakov
Hi 11.11.2013, 18:37, Evgeny Boger eugenybo...@gmail.com:  Strong pullup is emulated by driving pin logic high after write command when  using tri-state push-pull GPIO. Signed-off-by: Evgeny Boger bo...@contactless.ru ---  drivers/w1/masters/w1-gpio.c | 22 ++  

Re: [PATCH 1/1] Add strong pullup emulation to w1-gpio master driver.

2013-11-11 Thread Evgeniy Polyakov
Hi 12.11.2013, 03:32, Evgeny Boger eugenybo...@gmail.com: Why did you drop this check? It has nothing with w1-gpio driver This check prevents master from implementing set_pullup  provided it does support only write_bit method. The comment above states that  w1_io.c would need to support

Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts

2013-11-01 Thread Evgeniy Polyakov
Hi everyone 31.10.2013, 13:12, "Michal Nazarewicz" : >>>   int ttl; >>  ... w1_slave.ttl? For noisy lines this was a 'timeout' after which system considered attached device as failed, the noisier line is the longer is timeout I experimented with meters-long w1 wires and it required

Re: [PATCH] drivers: w1: make w1_slave::flags long to avoid casts

2013-11-01 Thread Evgeniy Polyakov
Hi everyone 31.10.2013, 13:12, Michal Nazarewicz min...@mina86.com:   int ttl;  ... w1_slave.ttl? For noisy lines this was a 'timeout' after which system considered attached device as failed, the noisier line is the longer is timeout I experimented with meters-long w1 wires and it

Re: [PATCH] w1: ds1wm: remove deprecated IRQF_DISABLED

2013-10-16 Thread Evgeniy Polyakov
hem into your tree Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] w1: ds1wm: remove deprecated IRQF_DISABLED

2013-10-16 Thread Evgeniy Polyakov
look good, thank you Greg, please pull them into your tree Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] w1 fixes for broken subsystem

2013-10-06 Thread Evgeniy Polyakov
devices, I would introduce them everywhere... But anyway, your patches fix those problems, thanks a lot. Greg, please queue them into appropriate trees. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to m

Re: [PATCH 0/2] w1 fixes for broken subsystem

2013-10-06 Thread Evgeniy Polyakov
... But anyway, your patches fix those problems, thanks a lot. Greg, please queue them into appropriate trees. Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/2] w1: w1-gpio: use dev_get_platdata()

2013-08-31 Thread Evgeniy Polyakov
Signed-off-by: Jingoo Han Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] w1: w1-gpio: use dev_get_platdata()

2013-08-31 Thread Evgeniy Polyakov
-by: Jingoo Han jg1@samsung.com Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 2/2] w1: use default attribute groups for w1 slave devices

2013-08-21 Thread Evgeniy Polyakov
hi Greg 22.08.2013, 00:24, "Greg Kroah-Hartman" : > As we have 2 sysfs files for the w1 slave devices, let the driver core > create / destroy them automatically by setting the default attribute > group for them, saving code and housekeeping logic. > > Cc: Evgeniy Polyak

Re: [PATCH 2/2] w1: use default attribute groups for w1 slave devices

2013-08-21 Thread Evgeniy Polyakov
hi Greg 22.08.2013, 00:24, Greg Kroah-Hartman gre...@linuxfoundation.org: As we have 2 sysfs files for the w1 slave devices, let the driver core create / destroy them automatically by setting the default attribute group for them, saving code and housekeeping logic. Cc: Evgeniy Polyakov z

Re: [PATCH] w1: replace strict_strtol() with kstrtol()

2013-07-22 Thread Evgeniy Polyakov
appropriate. Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] w1: replace strict_strtol() with kstrtol()

2013-07-22 Thread Evgeniy Polyakov
appropriate. Acked-by: Evgeniy Polyakov z...@ioremap.net -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] w1-gpio: Let device core handle pinctrl

2013-06-05 Thread Evgeniy Polyakov
t; - if (IS_ERR(pinctrl)) > - dev_warn(>dev, "unable to select pin group\n"); > - > if (of_have_populated_dt()) { > err = w1_gpio_probe_dt(pdev); > if (err < 0) { > -- > 1.8.1.2 > -- Evgeniy Polyakov --

Re: [PATCH] w1-gpio: Let device core handle pinctrl

2013-06-05 Thread Evgeniy Polyakov
); - if (IS_ERR(pinctrl)) - dev_warn(pdev-dev, unable to select pin group\n); - if (of_have_populated_dt()) { err = w1_gpio_probe_dt(pdev); if (err 0) { -- 1.8.1.2 -- Evgeniy Polyakov -- To unsubscribe from this list: send the line

Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-10 Thread Evgeniy Polyakov
rm is only used to cast structure to uint64_t, nothing fancy. In-memory structure should be ok because of above definition on every endian. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ke

Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-10 Thread Evgeniy Polyakov
definition on every endian. -- Evgeniy Polyakov -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] w1: ds2482: add device tree probe support

2013-03-29 Thread Evgeniy Polyakov
Hi On Mon, Mar 25, 2013 at 05:21:34PM +0100, Hector Palacios (hector.palac...@digi.com) wrote: > It adds device tree probe support for ds2482 driver. > > Signed-off-by: Hector Palacios Looks good, thank you Acked-by: Evgeniy Polyakov Greg, please pull it into your tree,

Re: [PATCH] 1-wire: in-kernel notification on device events

2013-03-29 Thread Evgeniy Polyakov
informed > of subsequent device insertions and removals. > > The framework is copied from USB subsystem. > > Signed-off-by: Sergey Yanovich Thanks Sergey, patch looks good to me Acked-by: Evgeniy Polyakov Greg, please pull it into your tree. Thank you -- Evgeniy Polyako

Re: [PATCH] 1-wire: in-kernel notification on device events

2013-03-29 Thread Evgeniy Polyakov
of subsequent device insertions and removals. The framework is copied from USB subsystem. Signed-off-by: Sergey Yanovich ynv...@gmail.com Thanks Sergey, patch looks good to me Acked-by: Evgeniy Polyakov z...@ioremap.net Greg, please pull it into your tree. Thank you -- Evgeniy Polyakov

Re: [PATCH] w1: ds2482: add device tree probe support

2013-03-29 Thread Evgeniy Polyakov
Hi On Mon, Mar 25, 2013 at 05:21:34PM +0100, Hector Palacios (hector.palac...@digi.com) wrote: It adds device tree probe support for ds2482 driver. Signed-off-by: Hector Palacios hector.palac...@digi.com Looks good, thank you Acked-by: Evgeniy Polyakov z...@ioremap.net Greg, please pull

Re: [PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

2013-03-14 Thread Evgeniy Polyakov
On Tue, Mar 12, 2013 at 02:28:11PM -0400, Jean-François Dagenais (jeff.dagen...@gmail.com) wrote: > Thoughts? > /jfd Well, sounds reasonable. Please submit patches to Greg Kroah-Hartman , he will push them upstream. Acked-by: Evgeniy Polyakov -- Evgeniy Polyakov -- To unsub

Re: [PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

2013-03-14 Thread Evgeniy Polyakov
On Tue, Mar 12, 2013 at 02:28:11PM -0400, Jean-François Dagenais (jeff.dagen...@gmail.com) wrote: Thoughts? /jfd Well, sounds reasonable. Please submit patches to Greg Kroah-Hartman g...@kroah.com, he will push them upstream. Acked-by: Evgeniy Polyakov z...@ioremap.net -- Evgeniy

Re: [PATCH 1/2] w1: mxc_w1: Convert to devm_ioremap_resource()

2013-03-11 Thread Evgeniy Polyakov
m Both patches look good to me, thank you Greg, please pull it into you tree Acked-by: Evgeniy Polyakov -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at h

Re: [PATCH 1/2] w1-gpio: remove erroneous __exit and __exit_p()

2013-03-11 Thread Evgeniy Polyakov
ction markers for probe and remove > (to __devinit/exit, which have since been removed). A later commit fixed > the section mismatch for probe, but left remove marked with __exit. > > Signed-off-by: Johan Hovold Both patches look good to me, thank you Greg, please pull it into yo

Re: [PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

2013-03-11 Thread Evgeniy Polyakov
ameter? -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] w1: ds2408: make value read-back check a Kconfig option

2013-03-11 Thread Evgeniy Polyakov
? -- Evgeniy Polyakov -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/2] w1-gpio: remove erroneous __exit and __exit_p()

2013-03-11 Thread Evgeniy Polyakov
(to __devinit/exit, which have since been removed). A later commit fixed the section mismatch for probe, but left remove marked with __exit. Signed-off-by: Johan Hovold jhov...@gmail.com Both patches look good to me, thank you Greg, please pull it into your tree Acked-by: Evgeniy Polyakov z

Re: [PATCH 1/2] w1: mxc_w1: Convert to devm_ioremap_resource()

2013-03-11 Thread Evgeniy Polyakov
fabio.este...@freescale.com Both patches look good to me, thank you Greg, please pull it into you tree Acked-by: Evgeniy Polyakov z...@ioremap.net -- Evgeniy Polyakov -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 1/1] w1: fix oops when w1_search is called from netlink connector

2013-03-03 Thread Evgeniy Polyakov
Hi Marcin, thanks a lot for the fix, I have to sorry I'm not on this bug yet :( Sven confirmed patch fixes it, Greg please pull it into your tree. I believe this is stable material. Thanks everyone. Acked-by: Evgeniy Polyakov On Sat, Mar 02, 2013 at 02:50:15PM +0100, Marcin Jurkowski (marci

Re: [PATCH 1/1] w1: fix oops when w1_search is called from netlink connector

2013-03-03 Thread Evgeniy Polyakov
Hi Marcin, thanks a lot for the fix, I have to sorry I'm not on this bug yet :( Sven confirmed patch fixes it, Greg please pull it into your tree. I believe this is stable material. Thanks everyone. Acked-by: Evgeniy Polyakov z...@ioremap.net On Sat, Mar 02, 2013 at 02:50:15PM +0100, Marcin

Re: [PATCH] proc connector: reject unprivileged listener bumps

2013-02-26 Thread Evgeniy Polyakov
the same privileges as > required for a multicast bind. Sounds resonable. Not sure whether this is a candidate for stable release, but otherwise Acked-by: Evgeniy Polyakov -- Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] proc connector: reject unprivileged listener bumps

2013-02-26 Thread Evgeniy Polyakov
privileges as required for a multicast bind. Sounds resonable. Not sure whether this is a candidate for stable release, but otherwise Acked-by: Evgeniy Polyakov z...@ioremap.net -- Evgeniy Polyakov -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

<    1   2   3   4   5   6   7   8   9   10   >