Hi Andrejs, Marc,
On Wed, 24 Jul 2019 at 06:48, Marc Kleine-Budde wrote:
>
> On 2/8/19 2:17 PM, Andrejs Cainikovs wrote:
> > D_CAN supports up to 128 message objects, comparing to 32 on C_CAN.
> > However, some CPUs with D_CAN controller have their own limits:
> > TI AM335x Sitara CPU, for
Hi everyone,
This series was recently brought to my attention, in connection to a
long-standing
packet drop issue that we had on a Sitara-based product.
I haven't tested this personally, but I've been notified that this was
backported
to the v4.19 kernel, and the packet drop was fixed.
It seems
Salut Paul,
Just a minor comment about the v4l2 async API.
On Thu, 31 Dec 2020 at 11:30, Paul Kocialkowski
wrote:
>
> The A31 MIPI CSI-2 controller is a dedicated MIPI CSI-2 bridge
> found on Allwinner SoCs such as the A31 and V3/V3s.
>
> It is a standalone block, connected to the CSI
Hi Ricardo,
Thanks a lot for doing this media-wide cleanup.
Aside from a silly typo here in the commit title, s/sum4i-csi/sun4i-csi,
all the patches seem fine.
Thanks,
Ezequiel
On Mon, 11 Jan 2021 at 11:56, Ricardo Ribalda wrote:
>
> Core code already clears reserved fields of struct
>
On Mon, 2021-01-11 at 13:22 +0100, Ricardo Ribalda wrote:
> Hi Ezequiel
>
> On Mon, Jan 11, 2021 at 12:55 PM Ricardo Ribalda wrote:
> >
> > Hi Ezequiel
> >
> > On Mon, Jan 11, 2021 at 12:48 PM Ezequiel Garcia
> > wrote:
> > >
> > > H
Hi Ricardo,
On Mon, 2021-01-11 at 12:35 +0100, Ricardo Ribalda wrote:
> Clear the reserved fields.
>
> Fixes:
> fail: v4l2-test-formats.cpp(482): pix_mp.plane_fmt[0].reserved not zeroed
> test VIDIOC_TRY_FMT: FAIL
> fail: v4l2-test-formats.cpp(482): pix_mp.plane_fmt[0].reserved not zeroed
>
On Fri, 2021-01-08 at 17:22 +0800, Zheng Yongjun wrote:
> Replace a comma between expression statements by a semicolon.
>
> Signed-off-by: Zheng Yongjun
> ---
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Sat, 2021-01-09 at 17:43 +0530, Sri Laasya Nutheti wrote:
> Line 146 had a comma in place of a semicolon. Fix it.
>
> Signed-off-by: Sri Laasya Nutheti
> ---
> v3: Corrected email recipients
> drivers/staging/media/rkvdec/rkvdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
On Fri, 2021-01-08 at 10:05 +0100, Paul Kocialkowski wrote:
> Hi Ezequiel,
>
> On Thu 07 Jan 21, 16:08, Ezequiel Garcia wrote:
> > Happy to see this patch. It was on my TODO list,
> > but I hadn't had time to bringup my rk3326 device.
>
> Same here, I just had
Hi Paul,
Happy to see this patch. It was on my TODO list,
but I hadn't had time to bringup my rk3326 device.
A few comments.
On Thu, 2021-01-07 at 14:41 +0100, Paul Kocialkowski wrote:
> The PX30 SoC includes both the VDPU2 and VEPU2 blocks which are similar
> to the RK3399 (Hantro G1/H1 with
On Thu, 2021-01-07 at 12:41 +0100, Boris Brezillon wrote:
> On Thu, 7 Jan 2021 10:13:43 +0100
> Hans Verkuil wrote:
>
> > On 08/12/2020 16:55, Adrian Ratiu wrote:
> > > Some configurations built by the ktest bot produce the following
> > > warn, so mark the struct as __maybe_unused to avoid
Let's see if this works:
#syz test: https://gitlab.collabora.com/linux/0day.git
a1714d224e516b579d09cc1b4c3d85042e42f14c
On Wed, 23 Dec 2020 at 12:27, syzbot
wrote:
>
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:3644e2d2 mm/filemap: fix infinite loop in
On Mon, 2020-12-28 at 15:16 +0200, Laurent Pinchart wrote:
> Hi Ezequiel,
>
> Thank you for the patch.
>
> On Mon, Dec 28, 2020 at 09:17:25AM -0300, Ezequiel Garcia wrote:
> > fwnode_handle_put() should be called after the fwnode
> > is last accessed. Fix it.
> >
fwnode_handle_put() should be called after the fwnode
is last accessed. Fix it.
Fixes: b98158d837ef ("media: v4l2-async: Accept endpoints and devices for
fwnode matching")
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-async.c | 6 --
1 file changed, 4 insert
On Wed, 2020-12-02 at 16:11 +0100, Hans Verkuil wrote:
> Hi Ezequiel,
>
> Some small comments:
>
> On 30/11/2020 19:52, Ezequiel Garcia wrote:
> > Typically, bitstreams are composed of one sequence header NAL unit,
> > followed by a number of picture header and pictu
On Sun, 2020-11-29 at 22:59 +, Jonas Karlman wrote:
> Hi Ezequiel,
>
> On 2020-11-05 21:51, Ezequiel Garcia wrote:
> > Typically, bitstreams are composed of one sequence header NAL unit,
> > followed by a number of picture header and picture coding extension
> >
flexibility. Having these controls split
allows applications to set a sequence control at the beginning
of a sequence, and then set a picture control for each frame.
While here add padding fields where needed, and document
the uAPI header thoroughly.
Signed-off-by: Ezequiel Garcia
Tested-by: Jonas Karlman
n matrices
(by not setting the MPEG2_QUANTIZATION control in decode request).
A follow-up change will refactor this uAPI so we don't need
to add padding fields just yet.
Signed-off-by: Ezequiel Garcia
Tested-by: Jonas Karlman
---
.../media/v4l/ext-ctrls-codec.rst | 108 +++--
is the slice size.
To reduce the API surface and avoid confusion drop these
fields from control.
Signed-off-by: Ezequiel Garcia
Tested-by: Jonas Karlman
---
Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 6 --
drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c| 4
:
* No API changes, just minor boilerplate fixes for the new
controls to be properly exposed, initialized and validated.
v2:
* Fixed bad use of boolean negation in a flag, which
was fortunately reported by 0day bot.
Ezequiel Garcia (3):
media: uapi: mpeg2: Cleanup flags
media: uapi: mpeg2
On Sun, 2020-11-29 at 05:29 +0200, Jarkko Sakkinen wrote:
> On Thu, Nov 26, 2020 at 03:19:24AM -0300, Ezequiel Garcia wrote:
> > On Thu, 2020-11-26 at 05:30 +0200, Jarkko Sakkinen wrote:
> > > On Tue, 2020-11-24 at 10:14 -0300, Ezequiel Garcia wrote:
> > > > Hi J
On Fri, 2020-11-27 at 00:40 +0100, Jernej Škrabec wrote:
> Hi!
>
> Dne petek, 27. november 2020 ob 00:21:11 CET je Ezequiel Garcia napisal(a):
> > Hi Jernej, Emmanuel,
> >
> > Thanks for the patch.
> >
> > On Tue, 2020-11-10 at 23:35 +0100, Jernej Skrabec
rigger.
>
> Signed-off-by: Jernej Skrabec
> [addressed issues from reviewer]
> Signed-off-by: Emmanuel Gil Peyrot
> ---
> Changes in v3:
> - addressed comments from Ezequiel Garcia - new comments,
> using new macros from VP8 UAPI, new function for waiting
> on bit t
For now, only print the type of the control. In the future,
we might want to be able to print the values of all
the stateless codec controls currently set in the control handler,
which should be useful for debugging reasons.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2
The H264 stateless controls is ready to be part
of the stable uAPI.
Re-number the control IDs, move them to the newly
created stateless control class, and updates all
the drivers accordingly.
Signed-off-by: Ezequiel Garcia
Tested-by: Jernej Skrabec
---
drivers/media/v4l2-core/v4l2-ctrls.c
Now that we've destaged the H264 stateless codec controls,
and with all the pieces in place, update the documentation
and move it to its own section.
Signed-off-by: Ezequiel Garcia
---
.../userspace-api/media/v4l/common.rst| 1 +
.../media/v4l/ext-ctrls-codec-stateless.rst | 674
Add a new control class to hold the stateless codecs controls
that are ready to be moved out of staging.
Signed-off-by: Ezequiel Garcia
Tested-by: Jernej Skrabec
---
.../userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 4
drivers/media/v4l2-core/v4l2-ctrls.c
When V4L2_CTRL_TYPE_H264_PRED_WEIGHTS was added, adding a replace
symbol directive in videodev2.h.rst.exceptions was missed.
Now that the control type is destaged, it's important to fix this.
Signed-off-by: Ezequiel Garcia
---
Documentation/userspace-api/media/videodev2.h.rst.exceptions | 1
Since we are ready to stabilize the H264 stateless API,
start by first moving the parsed H264 pixel format.
Signed-off-by: Ezequiel Garcia
Tested-by: Jernej Skrabec
---
include/media/h264-ctrls.h | 3 ---
include/uapi/linux/videodev2.h | 1 +
2 files changed, 1 insertion(+), 3 deletions
Move the H264 stateless control types out of staging,
and re-number them to avoid any confusion.
Signed-off-by: Ezequiel Garcia
Tested-by: Jernej Skrabec
---
include/media/h264-ctrls.h | 8
include/uapi/linux/videodev2.h | 7 +++
2 files changed, 7 insertions(+), 8 deletions
Check that all the fields that correspond or are related
to a H264 specification syntax element have legal values.
Signed-off-by: Ezequiel Garcia
Tested-by: Jernej Skrabec
---
drivers/media/v4l2-core/v4l2-ctrls.c | 134 +++
include/media/h264-ctrls.h | 9
Avoid including h264-ctrls.h, vp8-ctrls.h, etc,
and instead just include v4l2-ctrls.h which does the right
thing.
This is in preparation for moving the stateless controls
out of staging, which will mean removing some of these headers.
Signed-off-by: Ezequiel Garcia
Tested-by: Jernej Skrabec
For historical reasons, stateful codec controls are named
as {}_MPEG_{}. While we can't at this point sanely
change all control IDs (such as V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER),
we can least change the more meaningful macros such as classes
macros.
Signed-off-by: Ezequiel Garcia
Tested
Add a debug message for control validation (validate_new)
failures. This is useful to debug issues with ioctls such
as VIDIOC_TRY_EXT_CTRLS and VIDIOC_S_EXT_CTRLS.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion
From: Hans Verkuil
V4L2_CTRL_CLASS_DETECT was never documented here, add it.
Signed-off-by: Hans Verkuil
---
Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst
Cedrus supports H.264 profiles from Baseline to High,
except for the Extended profile
Expose the V4L2_CID_MPEG_VIDEO_H264_PROFILE so that
userspace can query the driver for the supported
profiles and levels.
Signed-off-by: Ezequiel Garcia
Reviewed-by: Jernej Skrabec
Tested-by: Jernej Skrabec
for the list of supported profiles and level.
For now, we don't expose 4:2:2 since the driver doesn't
implement the required support.
Signed-off-by: Jonas Karlman
[Ezequiel: Don't expose 4:2:2 profile for now]
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/rkvdec/rkvdec.c | 13
.
Ezequiel Garcia (12):
media: controls: Add validate failure debug message
media: cedrus: h264: Support profile controls
media: Rename stateful codec control macros
media: Clean stateless control includes
media: controls: Validate H264 stateless controls
media: controls: Add the stateless
On Thu, 2020-11-26 at 05:30 +0200, Jarkko Sakkinen wrote:
> On Tue, 2020-11-24 at 10:14 -0300, Ezequiel Garcia wrote:
> > Hi Jarkko,
> >
> > Thanks for your review.
> >
> > On Tue, 2020-11-24 at 00:06 +0200, Jarkko Sakkinen wrote:
> > > On Fri, Nov
Hi Jarkko,
Thanks for your review.
On Tue, 2020-11-24 at 00:06 +0200, Jarkko Sakkinen wrote:
> On Fri, Nov 20, 2020 at 07:23:45PM +0200, Adrian Ratiu wrote:
> > From: "dlau...@chromium.org"
> >
> > Add TPM 2.0 compatible I2C interface for chips with cr50 firmware.
> >
> > The firmware running
The H264 stateless controls is ready to be part
of the stable uAPI.
Re-number the control IDs, move them to the newly
created stateless control class, and updates all
the drivers accordingly.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 36 +-
drivers
Now that we've destaged the H264 stateless codec controls,
and with all the pieces in place, update the documentation
and move it to its own section.
Signed-off-by: Ezequiel Garcia
---
.../userspace-api/media/v4l/common.rst| 1 +
.../media/v4l/ext-ctrls-codec-stateless.rst | 674
For now, only print the type of the control. In the future,
we might want to be able to print the values of all
the stateless codec controls currently set in the control handler,
which should be useful for debugging reasons.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2
Move the H264 stateless control types out of staging,
and re-number them to avoid any confusion.
Signed-off-by: Ezequiel Garcia
---
include/media/h264-ctrls.h | 8
include/uapi/linux/videodev2.h | 7 +++
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/include
Add a new control class to hold the stateless codecs controls
that are ready to be moved out of staging.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 5 +
include/uapi/linux/v4l2-controls.h | 7 +++
2 files changed, 12 insertions(+)
diff --git a/drivers
Since we are ready to stabilize the H264 stateless API,
start by first moving the parsed H264 pixel format.
Signed-off-by: Ezequiel Garcia
---
include/media/h264-ctrls.h | 3 ---
include/uapi/linux/videodev2.h | 1 +
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/include
Add some macros to document the profile_idc magic numbers.
This will be used to validate the controls, but could
also be used by drivers.
Signed-off-by: Ezequiel Garcia
---
include/media/h264-ctrls.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/media/h264-ctrls.h b/include
Check that all the fields that correspond or are related
to a H264 specification syntax element have legal values.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 128 +++
include/media/h264-ctrls.h | 9 ++
2 files changed, 137
Avoid including h264-ctrls.h, vp8-ctrls.h, etc,
and instead just include v4l2-ctrls.h which does the right
thing.
This is in preparation for moving the stateless controls
out of staging, which will mean removing some of these headers.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media
Cedrus supports H.264 profiles from Baseline to High,
except for the Extended profile
Expose the V4L2_CID_MPEG_VIDEO_H264_PROFILE so that
userspace can query the driver for the supported
profiles and levels.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/sunxi/cedrus/cedrus.c | 19
For historical reasons, stateful codec controls are named
as {}_MPEG_{}. While we can't at this point sanely
change all control IDs (such as V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER),
we can least change the more meaningful macros such as classes
macros.
Signed-off-by: Ezequiel Garcia
for the list of supported profiles and level.
For now, we don't expose 4:2:2 since the driver doesn't
implement the required support.
Signed-off-by: Jonas Karlman
[Ezequiel: Don't expose 4:2:2 profile for now]
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/rkvdec/rkvdec.c | 13
Add a debug message for control validation (validate_new)
failures. This is useful to debug issues with ioctls such
as VIDIOC_TRY_EXT_CTRLS and VIDIOC_S_EXT_CTRLS.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion
the compatibility macros for MPEG to the end of the header.
Ezequiel Garcia (12):
media: ctrls: Add validate failure debug message
media: cedrus: h264: Support profile controls
media: Rename stateful codec control macros
media: Clean stateless control includes
media: uapi: h264: Add profile_idc
Hi Maxime,
On Mon, 23 Nov 2020 at 04:21, Maxime Chevallier
wrote:
>
> Hi Ezequiel, and thanks a lot for the review !
>
> On Fri, 2 Oct 2020 14:35:28 -0300
> Ezequiel Garcia wrote:
>
> > Hi Maxime,
> >
> >Thanks to Dafna, I found the patch ^_^
> >
On Sat, 21 Nov 2020 at 23:01, Dmitry Osipenko wrote:
>
> 22.11.2020 04:02, Ezequiel Garcia пишет:
> > Hi Dmitry,
> >
> ...
> >> +++ b/drivers/staging/media/tegra-vde/TODO
> >> @@ -0,0 +1,4 @@
> >> +TODO:
> >> + - Implem
Hi Dmitry,
On Mon, 11 Dec 2017 at 21:27, Dmitry Osipenko wrote:
>
> NVIDIA Tegra20/30/114/124/132 SoC's have video decoder engine that
> supports standard set of video formats like H.264 / MPEG-4 / WMV / VC1.
>
> Signed-off-by: Dmitry Osipenko
> ---
> MAINTAINERS
On Fri, 2020-11-20 at 10:30 +0100, Hans Verkuil wrote:
> On 18/11/2020 19:46, Ezequiel Garcia wrote:
> > Check that all the fields that correspond or are related
> > to a H264 specification syntax element have legal values.
> >
> > Signed-off-by: Ezequiel Garcia
>
On Wed, 2020-11-18 at 15:46 -0300, Ezequiel Garcia wrote:
> The H264 stateless controls is ready to be part
> of the stable uAPI.
>
> Re-number the control IDs, move them to the newly
> created stateless control class, and updates all
> the drivers accordingly.
>
> Signed
Hello,
On Wed, 2020-11-18 at 15:46 -0300, Ezequiel Garcia wrote:
> Check that all the fields that correspond or are related
> to a H264 specification syntax element have legal values.
>
> Signed-off-by: Ezequiel Garcia
> ---
> drivers/media/v4l2-core
Now that we've destaged the H264 stateless codec controls,
and with all the pieces in place, update the documentation
and move it to its own section.
Signed-off-by: Ezequiel Garcia
---
.../userspace-api/media/v4l/common.rst| 1 +
.../media/v4l/ext-ctrls-codec-stateless.rst | 674
The H264 stateless controls is ready to be part
of the stable uAPI.
Re-number the control IDs, move them to the newly
created stateless control class, and updates all
the drivers accordingly.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 36 +-
drivers
For now, only print the type of the control. In the future,
we might want to be able to print the values of all
the stateless codec controls currently set in the control handler,
which should be useful for debugging reasons.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2
Move the H264 stateless control types out of staging,
and re-number them to avoid any confusion.
Signed-off-by: Ezequiel Garcia
---
include/media/h264-ctrls.h | 8
include/uapi/linux/videodev2.h | 7 +++
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/include
Add some macros to document the profile_idc magic numbers.
This will be used to validate the controls, but could
also be used by drivers.
Signed-off-by: Ezequiel Garcia
---
include/media/h264-ctrls.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/media/h264-ctrls.h b/include
Check that all the fields that correspond or are related
to a H264 specification syntax element have legal values.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 83
1 file changed, 83 insertions(+)
diff --git a/drivers/media/v4l2-core
Add a new control class to hold the stateless codecs controls
that are ready to be moved out of staging.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 5 +
include/uapi/linux/v4l2-controls.h | 7 +++
2 files changed, 12 insertions(+)
diff --git a/drivers
Since we are ready to stabilize the H264 stateless API,
start by first moving the parsed H264 pixel format.
Signed-off-by: Ezequiel Garcia
---
include/media/h264-ctrls.h | 3 ---
include/uapi/linux/videodev2.h | 1 +
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/include
Avoid including h264-ctrls.h, vp8-ctrls.h, etc,
and instead just include v4l2-ctrls.h which does the right
thing.
This is in preparation for moving the stateless controls
out of staging, which will mean removing some of these headers.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media
For historical reasons, stateful codec controls are named
as {}_MPEG_{}. While we can't at this point sanely
change all control IDs (such as V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER),
we can least change the more meaningful macros such as classes
macros.
Signed-off-by: Ezequiel Garcia
ges to drivers/media/v4l2-core/v4l2-ctrls.c.
* Renamed V4L2_CID_CODEC_CX2341X_ and V4L2_CID_MPEG_MFC51_
* Moved the compatibility macros for MPEG to the end of the header.
Ezequiel Garcia (12):
media: ctrls: Add validate failure debug message
media: cedrus: h264: Support profile contr
for the list of supported profiles and level.
For now, we don't expose 4:2:2 since the driver doesn't
implement the required support.
Signed-off-by: Jonas Karlman
[Ezequiel: Don't expose 4:2:2 profile for now]
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/rkvdec/rkvdec.c | 13
Cedrus supports H.264 profiles from Baseline to High,
except for the Extended profile
Expose the V4L2_CID_MPEG_VIDEO_H264_PROFILE so that
userspace can query the driver for the supported
profiles and levels.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/sunxi/cedrus/cedrus.c | 19
Add a debug message for control validation (validate_new)
failures. This is useful to debug issues with ioctls such
as VIDIOC_TRY_EXT_CTRLS and VIDIOC_S_EXT_CTRLS.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion
On Tue, 2020-11-17 at 20:55 +0100, Jernej Škrabec wrote:
> Dne torek, 17. november 2020 ob 20:40:09 CET je Ezequiel Garcia napisal(a):
> > On Tue, 2020-11-17 at 20:24 +0100, Jernej Škrabec wrote:
> > > Hi Ezequiel,
> > >
> > > sorry for late review.
> >
On Tue, 2020-11-17 at 20:24 +0100, Jernej Škrabec wrote:
> Hi Ezequiel,
>
> sorry for late review.
>
> First of all, this patch doesn't break anything. However, see comment below.
>
> Dne petek, 13. november 2020 ob 22:51:14 CET je Ezequiel Garcia napisal(a):
> > Ced
On Sat, 2020-11-14 at 13:53 +0100, Hans Verkuil wrote:
> On 13/11/2020 22:51, Ezequiel Garcia wrote:
> > For historical reasons, stateful codec controls are named
> > as {}_MPEG_{}. While we can't at this point sanely
> > change all control IDs (such as V4L2_CID_MPEG_V
On Sat, 2020-11-14 at 13:57 +0100, Hans Verkuil wrote:
> On 13/11/2020 22:51, Ezequiel Garcia wrote:
> > Now that we've destaged the H264 stateless codec controls,
> > and with all the pieces in place, update the documentation
> > and move it to its own section.
> >
Hi Hans,
Thanks for the quick review.
On Sat, 2020-11-14 at 13:58 +0100, Hans Verkuil wrote:
> On 13/11/2020 22:51, Ezequiel Garcia wrote:
> > Now that H.264 stateless controls are solid, we can get it
> > out of staging.
> >
> > Following some guidelines fro
Avoid including h264-ctrls.h, vp8-ctrls.h, etc,
and instead just include v4l2-ctrls.h which does the right
thing.
This is in preparation for moving the stateless controls
out of staging, which will mean removing some of these headers.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media
The H264 stateless controls is ready to be part
of the stable uAPI.
Re-number the control IDs, move them to the newly
created stateless control class, and updates all
the drivers accordingly.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 36 +-
drivers
Now that we've destaged the H264 stateless codec controls,
and with all the pieces in place, update the documentation
and move it to its own section.
Signed-off-by: Ezequiel Garcia
---
.../userspace-api/media/v4l/common.rst| 1 +
.../media/v4l/ext-ctrls-codec-stateless.rst | 674
Add a new control class to hold the stateless codecs controls
that are ready to be moved out of staging.
Signed-off-by: Ezequiel Garcia
---
drivers/media/v4l2-core/v4l2-ctrls.c | 5 +
include/uapi/linux/v4l2-controls.h | 7 +++
2 files changed, 12 insertions(+)
diff --git a/drivers
For historical reasons, stateful codec controls are named
as {}_MPEG_{}. While we can't at this point sanely
change all control IDs (such as V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER),
we can least change the more meaningful macros such as classes
macros.
Signed-off-by: Ezequiel Garcia
Move the H264 stateless control types out of staging,
and re-number them to avoid any confusion.
Signed-off-by: Ezequiel Garcia
---
include/media/h264-ctrls.h | 8
include/uapi/linux/videodev2.h | 7 +++
2 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/include
Cedrus supports H.264 profiles from Baseline to High,
up to Level 5.1, except for the Extended profile
Expose the V4L2_CID_MPEG_VIDEO_H264_PROFILE and
V4L2_CID_MPEG_VIDEO_H264_LEVEL so that userspace can
query the driver for the supported profiles and levels.
Signed-off-by: Ezequiel Garcia
in several patches so it's easier to review.
* Added missing changes to drivers/media/v4l2-core/v4l2-ctrls.c.
* Renamed V4L2_CID_CODEC_CX2341X_ and V4L2_CID_MPEG_MFC51_
* Moved the compatibility macros for MPEG to the end of the header.
Ezequiel Garcia (8):
media: cedrus: h264: Support profile
Since we are ready to stabilize the H264 stateless API,
start by first moving the parsed H264 pixel format.
Signed-off-by: Ezequiel Garcia
---
include/media/h264-ctrls.h | 3 ---
include/uapi/linux/videodev2.h | 1 +
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/include
for the list of supported profiles and level.
For now, we don't expose 4:2:2 since the driver doesn't
implement the required support.
Signed-off-by: Jonas Karlman
[Ezequiel: Don't expose 4:2:2 profile for now]
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/rkvdec/rkvdec.c | 13
, or otherwise get feedback.
I'll be porting GStreamer v4l2codecs to the new interface
and running some tests soon.
As far as I'm aware, Ffmpeg/libavcodec support is ready and
waiting for stable uAPIs, so we can expect that to be added
shortly after we land this.
Thanks,
Ezequiel
Ezequiel Garcia (4
For historical reasons, stateful codec controls are named
as {}_MPEG_{}. While we can't at this point sanely
change all control IDs (such as V4L2_CID_MPEG_VIDEO_VP8_FRAME_HEADER),
we can least change the more meaningful macros such as classes
macros.
Signed-off-by: Ezequiel Garcia
Avoid including h264-ctrls.h, vp8-ctrls.h, etc,
and instead just include v4l2-ctrls.h which does the right
thing.
This is in preparation for moving the stateless controls
out of staging, which will mean removing some of these headers.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media
Cedrus supports H.264 profiles from Baseline to High,
except for the Extended profile.
Expose the V4L2_CID_MPEG_VIDEO_H264_PROFILE so that userspace
can query the driver for the list of supported profiles.
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/sunxi/cedrus/cedrus.c | 12
for the list of supported profiles and level.
For now, we don't expose 4:2:2 since the driver doesn't
implement the required support.
Signed-off-by: Jonas Karlman
[Ezequiel: Don't expose 4:2:2 profile for now]
Signed-off-by: Ezequiel Garcia
---
drivers/staging/media/rkvdec/rkvdec.c | 13
The H264 stateless control class is ready to be part
of the stable uAPI.
The control IDs and types are re-numbered and moved
to a newly created stateless control class, and
a new documentation section is created.
Signed-off-by: Ezequiel Garcia
---
.../userspace-api/media/v4l/common.rst
Hi Mirela,
On Thu, 2020-11-12 at 05:05 +0200, Mirela Rabulea (OSS) wrote:
> From: Mirela Rabulea
>
> Add jpeg decoder/encoder nodes, for now on imx8qxp only.
> The same should work on imx8qm, but it was not tested.
>
Does imx8qm need changes in the dt bindings?
Unless you are aware of
Hi Emmanuel,
Thanks for the patch.
On Mon, 9 Nov 2020 at 15:37, Emmanuel Gil Peyrot wrote:
>
> These values will be used by various drivers implementing the VP8
> stateless API.
>
> This had been suggested by Ezequiel Garcia for the Cedrus VP8 driver.
>
> The only driver
On Wed, 2020-11-11 at 00:28 +0200, Adrian Ratiu wrote:
> Hi Ezequiel,
>
> On Tue, 10 Nov 2020, Ezequiel Garcia
> wrote:
> > On Mon, 2 Nov 2020 at 16:04, Adrian Ratiu
> > wrote:
> > > Dear all,
> > >
> > > This is v5 of the se
pointed out by Nicolas internally.
> * s/VP9_PROFILE_MAX/V4L2_VP9_PROFILE_MAX/
> * Fix wrong kfree(ctx).
> * constify a couple structs on rkvdec-vp9.c
>
>
> Boris Brezillon (2):
> media: uapi: Add VP9 stateless decoder controls
> media: rkvdec: Add the VP9 backend
>
>
n matrices
(by not setting the MPEG2_QUANTIZATION control in decode request).
A follow-up change will refactor this uAPI so we don't need
to add padding fields just yet.
Signed-off-by: Ezequiel Garcia
---
.../media/v4l/ext-ctrls-codec.rst | 108 +++---
drivers/media/v4l2-core/v4
101 - 200 of 1882 matches
Mail list logo
