Re: [PATCH 1/1 net-next] Bluetooth: fix shadow warning in hci_disconnect()

On 23 October 2014 at 18:29 Marcel Holtmann mar...@holtmann.org wrote: Hi Fabian, use cpr for hci_cp_read_clock_offset instead of cp (already defined above). Signed-off-by: Fabian Frederick f...@skynet.be --- net/bluetooth/hci_conn.c | 6 +++--- 1 file changed, 3 insertions

[PATCH 1/1 linux-next] scsi: remove unused label in sg_scsi_ioctl()

label 'out' is unused since commit 374f8fdea4aa (scsi: Fix error handling in SCSI_IOCTL_SEND_COMMAND) Signed-off-by: Fabian Frederick f...@skynet.be --- block/scsi_ioctl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index cc7927a..d1ae462 100644

[RFC 00/13] drivers: replace long unsigned int by unsigned long

Trivial patchset to use standard unsigned long in drivers/ instead of long unsigned int I'm just sending the summary; if you think it's worth being applied, I'll send this patchset and smaller ones for other trees. Regards, Fabian Fabian Frederick (13): qla4xxx: replace long unsigned int

[PATCH 1/1 net-next] net: llc: include linux/errno.h instead of asm/errno.h

Signed-off-by: Fabian Frederick --- net/llc/llc_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/llc/llc_if.c b/net/llc/llc_if.c index 25c31c0..6daf391 100644 --- a/net/llc/llc_if.c +++ b/net/llc/llc_if.c @@ -15,7 +15,7 @@ #include #include #include -#include

[PATCH 1/1 net-next] lapb: move EXPORT_SYMBOL after functions.

See Documentation/CodingStyle Chapter 6 Signed-off-by: Fabian Frederick --- net/lapb/lapb_iface.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c index 3cdaa04..fc60d9d 100644 --- a/net/lapb/lapb_iface.c +++ b

[PATCH 1/1 net-next] lapb: move EXPORT_SYMBOL after functions.

See Documentation/CodingStyle Chapter 6 Signed-off-by: Fabian Frederick f...@skynet.be --- net/lapb/lapb_iface.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c index 3cdaa04..fc60d9d 100644 --- a/net/lapb

[PATCH 1/1 net-next] net: llc: include linux/errno.h instead of asm/errno.h

Signed-off-by: Fabian Frederick f...@skynet.be --- net/llc/llc_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/llc/llc_if.c b/net/llc/llc_if.c index 25c31c0..6daf391 100644 --- a/net/llc/llc_if.c +++ b/net/llc/llc_if.c @@ -15,7 +15,7 @@ #include linux/module.h

Re: [PATCH 1/1 net-next] mac80211: remove unnecessary null test before debugfs_remove

> On 21 October 2014 at 21:06 Johannes Berg wrote: > > > On Tue, 2014-10-21 at 18:20 +0200, Fabian Frederick wrote: > > Fix checkpatch warnings: > > > >     WARNING: debugfs_remove(NULL) is safe this check is probably not > >required > > I'll ap

[PATCH 1/1 linux-next] ceph: remove unused ceph_get_direct_page_vector

This function is not used since commit 64c3131161c1 ("ceph_sync_direct_write: stop poking into iov_iter guts") Signed-off-by: Fabian Frederick --- include/linux/ceph/libceph.h | 3 --- net/ceph/pagevec.c | 35 --- 2 files changed, 38 deletion

[PATCH 1/1 linux-next] fs/affs/file.c: adding support to O_DIRECT

Based on ext2_direct_IO Cc: Al Viro Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/file.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/fs/affs/file.c b/fs/affs/file.c index 8e51085..05005bd 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -12,6

[PATCH 1/1 net-next] mac80211: remove unnecessary null test before debugfs_remove

Fix checkpatch warnings: WARNING: debugfs_remove(NULL) is safe this check is probably not required Signed-off-by: Fabian Frederick --- net/mac80211/debugfs_key.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/net/mac80211/debugfs_key.c b/net/mac80211

[PATCH 1/1 net-next] mac80211: remove unnecessary null test before debugfs_remove

Fix checkpatch warnings: WARNING: debugfs_remove(NULL) is safe this check is probably not required Signed-off-by: Fabian Frederick f...@skynet.be --- net/mac80211/debugfs_key.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/net/mac80211/debugfs_key.c b/net

[PATCH 1/1 linux-next] fs/affs/file.c: adding support to O_DIRECT

Based on ext2_direct_IO Cc: Al Viro v...@zeniv.linux.org.uk Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/file.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/fs/affs/file.c b/fs/affs/file.c index 8e51085..05005bd

[PATCH 1/1 linux-next] ceph: remove unused ceph_get_direct_page_vector

This function is not used since commit 64c3131161c1 (ceph_sync_direct_write: stop poking into iov_iter guts) Signed-off-by: Fabian Frederick f...@skynet.be --- include/linux/ceph/libceph.h | 3 --- net/ceph/pagevec.c | 35 --- 2 files changed, 38

Re: [PATCH 1/1 net-next] mac80211: remove unnecessary null test before debugfs_remove

On 21 October 2014 at 21:06 Johannes Berg johan...@sipsolutions.net wrote: On Tue, 2014-10-21 at 18:20 +0200, Fabian Frederick wrote: Fix checkpatch warnings:      WARNING: debugfs_remove(NULL) is safe this check is probably not required I'll apply this; however, I think

[tip:x86/cleanups] x86, msr: Use seek definitions instead of hard-coded values

Commit-ID: 03452d27c6cd9cebb59a6bb0fb6bd8557916c263 Gitweb: http://git.kernel.org/tip/03452d27c6cd9cebb59a6bb0fb6bd8557916c263 Author: Fabian Frederick AuthorDate: Fri, 17 Oct 2014 22:01:59 +0200 Committer: H. Peter Anvin CommitDate: Fri, 17 Oct 2014 13:40:55 -0700 x86, msr: Use seek

[tip:x86/cleanups] x86, msr: Convert printk to pr_foo()

Commit-ID: 951a18c6fee5d2f6f5d7b5118776bf787bf9c351 Gitweb: http://git.kernel.org/tip/951a18c6fee5d2f6f5d7b5118776bf787bf9c351 Author: Fabian Frederick AuthorDate: Fri, 17 Oct 2014 22:01:50 +0200 Committer: H. Peter Anvin CommitDate: Fri, 17 Oct 2014 13:40:54 -0700 x86, msr: Convert

[tip:x86/cleanups] x86, msr: Use PTR_ERR_OR_ZERO

Commit-ID: cba0fdbcff8b54c206c8e18898a55456959ed51a Gitweb: http://git.kernel.org/tip/cba0fdbcff8b54c206c8e18898a55456959ed51a Author: Fabian Frederick AuthorDate: Fri, 17 Oct 2014 22:01:38 +0200 Committer: H. Peter Anvin CommitDate: Fri, 17 Oct 2014 13:40:53 -0700 x86, msr: Use

[tip:x86/cleanups] x86/simplefb: Use PTR_ERR_OR_ZERO

Commit-ID: 76ef0db72f8b74bb92e24775d9d7f5ab26352bec Gitweb: http://git.kernel.org/tip/76ef0db72f8b74bb92e24775d9d7f5ab26352bec Author: Fabian Frederick AuthorDate: Fri, 17 Oct 2014 22:01:05 +0200 Committer: H. Peter Anvin CommitDate: Fri, 17 Oct 2014 13:40:52 -0700 x86/simplefb: Use

[tip:x86/cleanups] x86/sysfb: Use PTR_ERR_OR_ZERO

Commit-ID: e8d95ce9705c6683f57dc146b8c726c4d2242a52 Gitweb: http://git.kernel.org/tip/e8d95ce9705c6683f57dc146b8c726c4d2242a52 Author: Fabian Frederick AuthorDate: Fri, 17 Oct 2014 22:00:53 +0200 Committer: H. Peter Anvin CommitDate: Fri, 17 Oct 2014 13:40:52 -0700 x86/sysfb: Use

[tip:x86/cleanups] x86, cpuid: Use PTR_ERR_OR_ZERO

Commit-ID: cbda45a2d4798912637b5b792c1c7a97c8d8b080 Gitweb: http://git.kernel.org/tip/cbda45a2d4798912637b5b792c1c7a97c8d8b080 Author: Fabian Frederick AuthorDate: Fri, 17 Oct 2014 22:01:17 +0200 Committer: H. Peter Anvin CommitDate: Fri, 17 Oct 2014 13:40:51 -0700 x86, cpuid: Use

[PATCH 4/4 linux-next] x86, msr: use seek definitions instead of hard-coded values

Replace 0/1 by SEEK_SET/SEEK_CUR. Signed-off-by: Fabian Frederick --- arch/x86/kernel/msr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c index 1c66cd0..1ed1190 100644 --- a/arch/x86/kernel/msr.c +++ b/arch/x86/kernel/msr.c

[PATCH 3/4 linux-next] x86, msr: convert printk to pr_foo()

Also define pr_fmt. Signed-off-by: Fabian Frederick --- arch/x86/kernel/msr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c index 5b14dac..1c66cd0 100644 --- a/arch/x86/kernel/msr.c +++ b/arch/x86/kernel/msr.c @@ -22,6

[PATCH 1/1 linux-next] x86, cpuid: use PTR_ERR_OR_ZERO

replace IS_ERR/PTR_ERR Signed-off-by: Fabian Frederick --- arch/x86/kernel/cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpuid.c b/arch/x86/kernel/cpuid.c index 3225ae6c..83741a7 100644 --- a/arch/x86/kernel/cpuid.c +++ b/arch/x86/kernel/cpuid.c

[PATCH 1/4 linux-next] x86, msr: define msr chunksize

define MSR_CHUNK_SIZE instead of hard-coded value (8). Signed-off-by: Fabian Frederick --- arch/x86/include/asm/msr.h | 2 ++ arch/x86/kernel/msr.c | 18 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm

[PATCH 2/4 linux-next] x86, msr: use PTR_ERR_OR_ZERO

replace IS_ERR/PTR_ERR Signed-off-by: Fabian Frederick --- arch/x86/kernel/msr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c index f1f3ed0..5b14dac 100644 --- a/arch/x86/kernel/msr.c +++ b/arch/x86/kernel/msr.c @@ -206,7

[PATCH 1/1 linux-next] x86: sysfb: use PTR_ERR_OR_ZERO

replace IS_ERR/PTR_ERR Signed-off-by: Fabian Frederick --- arch/x86/kernel/sysfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/sysfb.c b/arch/x86/kernel/sysfb.c index 193ec2c..160386e 100644 --- a/arch/x86/kernel/sysfb.c +++ b/arch/x86/kernel/sysfb.c

[PATCH 1/1 linux-next] x86/simplefb: use PTR_ERR_OR_ZERO

replace IS_ERR/PTR_ERR Signed-off-by: Fabian Frederick --- arch/x86/kernel/sysfb_simplefb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c index 86179d4..764a29f 100644 --- a/arch/x86/kernel

[PATCH 1/1 net-next] netrom: use linux/uaccess.h

replace asm/uaccess.h by linux/uaccess.h Signed-off-by: Fabian Frederick --- net/netrom/af_netrom.c | 2 +- net/netrom/nr_dev.c| 2 +- net/netrom/nr_in.c | 2 +- net/netrom/nr_out.c| 2 +- net/netrom/nr_route.c | 2 +- net/netrom/nr_subr.c | 2 +- net/netrom/nr_timer.c | 2 +- 7

[PATCH 1/1 net-next] netrom: use linux/uaccess.h

replace asm/uaccess.h by linux/uaccess.h Signed-off-by: Fabian Frederick f...@skynet.be --- net/netrom/af_netrom.c | 2 +- net/netrom/nr_dev.c| 2 +- net/netrom/nr_in.c | 2 +- net/netrom/nr_out.c| 2 +- net/netrom/nr_route.c | 2 +- net/netrom/nr_subr.c | 2 +- net/netrom

[PATCH 1/1 linux-next] x86: sysfb: use PTR_ERR_OR_ZERO

replace IS_ERR/PTR_ERR Signed-off-by: Fabian Frederick f...@skynet.be --- arch/x86/kernel/sysfb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/sysfb.c b/arch/x86/kernel/sysfb.c index 193ec2c..160386e 100644 --- a/arch/x86/kernel/sysfb.c +++ b/arch/x86

[PATCH 1/1 linux-next] x86/simplefb: use PTR_ERR_OR_ZERO

replace IS_ERR/PTR_ERR Signed-off-by: Fabian Frederick f...@skynet.be --- arch/x86/kernel/sysfb_simplefb.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/x86/kernel/sysfb_simplefb.c b/arch/x86/kernel/sysfb_simplefb.c index 86179d4..764a29f 100644 --- a/arch/x86

[PATCH 1/4 linux-next] x86, msr: define msr chunksize

define MSR_CHUNK_SIZE instead of hard-coded value (8). Signed-off-by: Fabian Frederick f...@skynet.be --- arch/x86/include/asm/msr.h | 2 ++ arch/x86/kernel/msr.c | 18 +- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/arch/x86/include/asm/msr.h b/arch/x86

[PATCH 2/4 linux-next] x86, msr: use PTR_ERR_OR_ZERO

replace IS_ERR/PTR_ERR Signed-off-by: Fabian Frederick f...@skynet.be --- arch/x86/kernel/msr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c index f1f3ed0..5b14dac 100644 --- a/arch/x86/kernel/msr.c +++ b/arch/x86/kernel/msr.c

[PATCH 1/1 linux-next] x86, cpuid: use PTR_ERR_OR_ZERO

replace IS_ERR/PTR_ERR Signed-off-by: Fabian Frederick f...@skynet.be --- arch/x86/kernel/cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/cpuid.c b/arch/x86/kernel/cpuid.c index 3225ae6c..83741a7 100644 --- a/arch/x86/kernel/cpuid.c +++ b/arch/x86

[PATCH 3/4 linux-next] x86, msr: convert printk to pr_foo()

Also define pr_fmt. Signed-off-by: Fabian Frederick f...@skynet.be --- arch/x86/kernel/msr.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c index 5b14dac..1c66cd0 100644 --- a/arch/x86/kernel/msr.c +++ b/arch/x86/kernel

[PATCH 4/4 linux-next] x86, msr: use seek definitions instead of hard-coded values

Replace 0/1 by SEEK_SET/SEEK_CUR. Signed-off-by: Fabian Frederick f...@skynet.be --- arch/x86/kernel/msr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c index 1c66cd0..1ed1190 100644 --- a/arch/x86/kernel/msr.c +++ b/arch

[tip:x86/cleanups] x86, cpuid: Use PTR_ERR_OR_ZERO

Commit-ID: cbda45a2d4798912637b5b792c1c7a97c8d8b080 Gitweb: http://git.kernel.org/tip/cbda45a2d4798912637b5b792c1c7a97c8d8b080 Author: Fabian Frederick f...@skynet.be AuthorDate: Fri, 17 Oct 2014 22:01:17 +0200 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 17 Oct 2014

[tip:x86/cleanups] x86/sysfb: Use PTR_ERR_OR_ZERO

Commit-ID: e8d95ce9705c6683f57dc146b8c726c4d2242a52 Gitweb: http://git.kernel.org/tip/e8d95ce9705c6683f57dc146b8c726c4d2242a52 Author: Fabian Frederick f...@skynet.be AuthorDate: Fri, 17 Oct 2014 22:00:53 +0200 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 17 Oct 2014

[tip:x86/cleanups] x86/simplefb: Use PTR_ERR_OR_ZERO

Commit-ID: 76ef0db72f8b74bb92e24775d9d7f5ab26352bec Gitweb: http://git.kernel.org/tip/76ef0db72f8b74bb92e24775d9d7f5ab26352bec Author: Fabian Frederick f...@skynet.be AuthorDate: Fri, 17 Oct 2014 22:01:05 +0200 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 17 Oct 2014

[tip:x86/cleanups] x86, msr: Use PTR_ERR_OR_ZERO

Commit-ID: cba0fdbcff8b54c206c8e18898a55456959ed51a Gitweb: http://git.kernel.org/tip/cba0fdbcff8b54c206c8e18898a55456959ed51a Author: Fabian Frederick f...@skynet.be AuthorDate: Fri, 17 Oct 2014 22:01:38 +0200 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 17 Oct 2014

[tip:x86/cleanups] x86, msr: Convert printk to pr_foo()

Commit-ID: 951a18c6fee5d2f6f5d7b5118776bf787bf9c351 Gitweb: http://git.kernel.org/tip/951a18c6fee5d2f6f5d7b5118776bf787bf9c351 Author: Fabian Frederick f...@skynet.be AuthorDate: Fri, 17 Oct 2014 22:01:50 +0200 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 17 Oct 2014

[tip:x86/cleanups] x86, msr: Use seek definitions instead of hard-coded values

Commit-ID: 03452d27c6cd9cebb59a6bb0fb6bd8557916c263 Gitweb: http://git.kernel.org/tip/03452d27c6cd9cebb59a6bb0fb6bd8557916c263 Author: Fabian Frederick f...@skynet.be AuthorDate: Fri, 17 Oct 2014 22:01:59 +0200 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 17 Oct 2014

Re: [PATCH 1/1 linux-next] zd1201: replace kmalloc/memset by kzalloc

> On 14 October 2014 at 20:08 Bjørn Mork wrote: > > > Joe Perches writes: > > > And does this really need to be alloc'd? > > Yes, it does. It is used as a transfer_buffer in usb_fill_bulk_urb() and > must be "suitable for DMA".  From include/linux/usb.h: > > /** >  * struct urb - USB Request

Re: [PATCH 1/1 linux-next] fs/jffs2/nodelist.h: remove unnecessary __constant_ prefix

> On 14 October 2014 at 18:52 Joe Perches wrote: > > > On Tue, 2014-10-14 at 18:44 +0200, Fabian Frederick wrote: > > See commit fbdb8138cf0c > > ("checkpatch: warn on uses of __constant_ functions") > > Perhaps it'd be better to use the same > __built

Re: [PATCH 1/1 linux-next] fs/jffs2/nodelist.h: remove unnecessary __constant_ prefix

On 14 October 2014 at 18:52 Joe Perches j...@perches.com wrote: On Tue, 2014-10-14 at 18:44 +0200, Fabian Frederick wrote: See commit fbdb8138cf0c (checkpatch: warn on uses of __constant_ functions) Perhaps it'd be better to use the same __builtin_constant_p test as swab.h and use

Re: [PATCH 1/1 linux-next] zd1201: replace kmalloc/memset by kzalloc

On 14 October 2014 at 20:08 Bjørn Mork bj...@mork.no wrote: Joe Perches j...@perches.com writes: And does this really need to be alloc'd? Yes, it does. It is used as a transfer_buffer in usb_fill_bulk_urb() and must be suitable for DMA.  From include/linux/usb.h: /**   * struct urb -

[PATCH 1/1 net-next] openvswitch: kerneldoc warning fix

s/sock/gs Signed-off-by: Fabian Frederick --- net/openvswitch/vport-geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/vport-geneve.c b/net/openvswitch/vport-geneve.c index 910b3ef..106a9d8 100644 --- a/net/openvswitch/vport-geneve.c +++ b/net

[PATCH 1/1 net-next] NFC: netlink: use sizeof(*iter) instead of class_dev_iter

Also fixes kzalloc on struct se_io_ctx See Documentation/CodingStyle Chapter 14 Signed-off-by: Fabian Frederick --- net/nfc/netlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c index 43cb1c1..b4ba68e 100644 --- a/net/nfc

[PATCH 1/1 net-next] NFC: llcp: use sizeof(*sdres) instead of nfc_llcp_sdp_tlv

See Documentation/CodingStyle Chapter 14 Signed-off-by: Fabian Frederick --- net/nfc/llcp_commands.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/nfc/llcp_commands.c b/net/nfc/llcp_commands.c index a3ad69a..a450075 100644 --- a/net/nfc/llcp_commands.c +++ b/net

[PATCH 1/1 net-next] openvswitch: use vport instead of p

All functions used struct vport *vport except ovs_vport_find_upcall_portid. This fixes 1 kerneldoc warning Signed-off-by: Fabian Frederick --- net/openvswitch/vport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c index

[PATCH 1/1 net-next] NFC: digital: use sizeof(*target) instead of nfc_target

See Documentation/CodingStyle Chapter 14 Signed-off-by: Fabian Frederick --- net/nfc/digital_technology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/nfc/digital_technology.c b/net/nfc/digital_technology.c index fb58ed2d..5e94b6f 100644 --- a/net/nfc

[PATCH 1/1 net-next] NFC: llcp: remove bool comparison on device

Fixes coccinelle warning: net/nfc/llcp_core.c:132:5-11: WARNING: Comparison to bool Signed-off-by: Fabian Frederick --- net/nfc/llcp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/llcp_core.c b/net/nfc/llcp_core.c index 51e7887..978399d 100644 --- a/net/nfc

[PATCH 1/1 net-next] NFC: digital: remove redundant memory message

Let MM subsystem display out of memory messages. Signed-off-by: Fabian Frederick --- net/nfc/digital_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/nfc/digital_core.c b/net/nfc/digital_core.c index 009bcf3..41ba70c 100644 --- a/net/nfc/digital_core.c +++ b/net

[PATCH 1/1 net-next] HCI: remove comparisons on shdlc boolean members.

/llc_shdlc.c:333:6-16: WARNING: Comparison to bool net/nfc/hci/llc_shdlc.c:431:31-43: WARNING: Comparison to bool Signed-off-by: Fabian Frederick --- net/nfc/hci/llc_shdlc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci/llc_shdlc.c

[PATCH 1/1 net-next] HCI: remove comparisons on shdlc boolean members.

/llc_shdlc.c:333:6-16: WARNING: Comparison to bool net/nfc/hci/llc_shdlc.c:431:31-43: WARNING: Comparison to bool Signed-off-by: Fabian Frederick f...@skynet.be --- net/nfc/hci/llc_shdlc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/nfc/hci/llc_shdlc.c b/net/nfc/hci

[PATCH 1/1 net-next] NFC: digital: remove redundant memory message

Let MM subsystem display out of memory messages. Signed-off-by: Fabian Frederick f...@skynet.be --- net/nfc/digital_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/nfc/digital_core.c b/net/nfc/digital_core.c index 009bcf3..41ba70c 100644 --- a/net/nfc

[PATCH 1/1 net-next] NFC: llcp: remove bool comparison on device

Fixes coccinelle warning: net/nfc/llcp_core.c:132:5-11: WARNING: Comparison to bool Signed-off-by: Fabian Frederick f...@skynet.be --- net/nfc/llcp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/nfc/llcp_core.c b/net/nfc/llcp_core.c index 51e7887..978399d 100644

[PATCH 1/1 net-next] NFC: digital: use sizeof(*target) instead of nfc_target

See Documentation/CodingStyle Chapter 14 Signed-off-by: Fabian Frederick f...@skynet.be --- net/nfc/digital_technology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/nfc/digital_technology.c b/net/nfc/digital_technology.c index fb58ed2d..5e94b6f 100644 --- a/net

[PATCH 1/1 net-next] NFC: llcp: use sizeof(*sdres) instead of nfc_llcp_sdp_tlv

See Documentation/CodingStyle Chapter 14 Signed-off-by: Fabian Frederick f...@skynet.be --- net/nfc/llcp_commands.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/nfc/llcp_commands.c b/net/nfc/llcp_commands.c index a3ad69a..a450075 100644 --- a/net/nfc

[PATCH 1/1 net-next] openvswitch: use vport instead of p

All functions used struct vport *vport except ovs_vport_find_upcall_portid. This fixes 1 kerneldoc warning Signed-off-by: Fabian Frederick f...@skynet.be --- net/openvswitch/vport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/openvswitch/vport.c b/net/openvswitch

[PATCH 1/1 net-next] NFC: netlink: use sizeof(*iter) instead of class_dev_iter

Also fixes kzalloc on struct se_io_ctx See Documentation/CodingStyle Chapter 14 Signed-off-by: Fabian Frederick f...@skynet.be --- net/nfc/netlink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c index 43cb1c1..b4ba68e 100644

[PATCH 1/1 net-next] openvswitch: kerneldoc warning fix

s/sock/gs Signed-off-by: Fabian Frederick f...@skynet.be --- net/openvswitch/vport-geneve.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/vport-geneve.c b/net/openvswitch/vport-geneve.c index 910b3ef..106a9d8 100644 --- a/net/openvswitch/vport-geneve.c +++ b

Re: [RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment

> On 14 October 2014 at 21:15 Zach Brown wrote: > > > On Tue, Oct 14, 2014 at 07:46:14PM +0200, Fabian Frederick wrote: > > use function defined in include/linux/highmem.h > > Note that this reverts 2 last function call order > > And adds a BUG_ON(PAGE_CACHE_SIZE &

[RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment

use function defined in include/linux/highmem.h Note that this reverts 2 last function call order Signed-off-by: Fabian Frederick --- fs/btrfs/scrub.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index efa0831..fa063cd 100644

[PATCH V2 2/2 net-next] caif_usb: use target structure member in memset

parent cfusbl was used instead of first structure member 'layer' Suggested-by: Joe Perches Signed-off-by: Fabian Frederick --- net/caif/caif_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c index 0e487b0..5cd44f0 100644

[PATCH V2 1/2 net-next] caif_usb: remove redundant memory message

Let MM subsystem display out of memory messages. Signed-off-by: Fabian Frederick --- V2: add second patch with memset fix net/caif/caif_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c index ba02db0..0e487b0 100644

[PATCH 1/1 linux-next] fs/jffs2/nodelist.h: remove unnecessary __constant_ prefix

See commit fbdb8138cf0c ("checkpatch: warn on uses of __constant_ functions") Cc: Joe Perches Cc: Andrew Morton Cc: David Woodhouse Cc: linux-...@lists.infradead.org Signed-off-by: Fabian Frederick --- fs/jffs2/nodelist.h | 8 1 file changed, 4 insertions(+), 4 deletion

[PATCH 1/1 linux-next] zd1201: replace kmalloc/memset by kzalloc

Signed-off-by: Fabian Frederick --- drivers/net/wireless/zd1201.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/zd1201.c b/drivers/net/wireless/zd1201.c index 6f5c793..4630b26 100644 --- a/drivers/net/wireless/zd1201.c +++ b/drivers/net/wireless

[PATCH V2 linux-next] fs/affs/amigaffs.c: use va_format instead of buffer/vnsprintf

-Remove ErrorBuffer and use %pV -Add __printf to enable argument mistmatch warnings Original-patch-by: Joe Perches Cc: Joe Perches Cc: Andrew Morton Signed-off-by: Fabian Frederick --- V2: add __printf (suggested by Joe Perches) fs/affs/affs.h | 2 ++ fs/affs/amigaffs.c | 28

[PATCH 1/1 linux-next] fs/affs/file.c: forward declaration clean-up

-Move file_operations to avoid forward declarations. -Remove unused declarations. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/file.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/fs/affs/file.c b/fs/affs/file.c

[PATCH 1/1 linux-next] fs/affs/file.c: forward declaration clean-up

-Move file_operations to avoid forward declarations. -Remove unused declarations. Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/file.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) diff

[PATCH V2 linux-next] fs/affs/amigaffs.c: use va_format instead of buffer/vnsprintf

-Remove ErrorBuffer and use %pV -Add __printf to enable argument mistmatch warnings Original-patch-by: Joe Perches j...@perches.com Cc: Joe Perches j...@perches.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- V2: add __printf (suggested by Joe

[PATCH 1/1 linux-next] zd1201: replace kmalloc/memset by kzalloc

Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/net/wireless/zd1201.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/zd1201.c b/drivers/net/wireless/zd1201.c index 6f5c793..4630b26 100644 --- a/drivers/net/wireless/zd1201.c +++ b/drivers/net

[PATCH 1/1 linux-next] fs/jffs2/nodelist.h: remove unnecessary __constant_ prefix

See commit fbdb8138cf0c (checkpatch: warn on uses of __constant_foo functions) Cc: Joe Perches j...@perches.com Cc: Andrew Morton a...@linux-foundation.org Cc: David Woodhouse dw...@infradead.org Cc: linux-...@lists.infradead.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/jffs2

[PATCH V2 1/2 net-next] caif_usb: remove redundant memory message

Let MM subsystem display out of memory messages. Signed-off-by: Fabian Frederick f...@skynet.be --- V2: add second patch with memset fix net/caif/caif_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c index ba02db0..0e487b0

[PATCH V2 2/2 net-next] caif_usb: use target structure member in memset

parent cfusbl was used instead of first structure member 'layer' Suggested-by: Joe Perches j...@perches.com Signed-off-by: Fabian Frederick f...@skynet.be --- net/caif/caif_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c index

[RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment

use function defined in include/linux/highmem.h Note that this reverts 2 last function call order Signed-off-by: Fabian Frederick f...@skynet.be --- fs/btrfs/scrub.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index efa0831

Re: [RFC 1/1 linux-next] btrfs: don't opencode zero_user_segment

On 14 October 2014 at 21:15 Zach Brown z...@zabbo.net wrote: On Tue, Oct 14, 2014 at 07:46:14PM +0200, Fabian Frederick wrote: use function defined in include/linux/highmem.h Note that this reverts 2 last function call order And adds a BUG_ON(PAGE_CACHE_SIZE PAGE_SIZE).  We can take

[PATCH 1/1 linux-next] fs/affs/amigaffs.c: use va_format instead of buffer/vnsprintf

Remove ErrorBuffer and use %pV Cc: Joe Perches Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/amigaffs.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c index abc8539..9643bdd 100644

[PATCH 1/1 net-next] caif_usb: remove redundant memory message

Let MM subsystem display out of memory messages. Signed-off-by: Fabian Frederick --- net/caif/caif_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c index ba02db0..0e487b0 100644 --- a/net/caif/caif_usb.c +++ b/net/caif

[PATCH 1/1 net-next] caif: replace kmalloc/memset 0 by kzalloc

Also add blank line after declaration Signed-off-by: Fabian Frederick --- net/caif/cfmuxl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/caif/cfmuxl.c b/net/caif/cfmuxl.c index 8c5d638..510aa5a 100644 --- a/net/caif/cfmuxl.c +++ b/net/caif/cfmuxl.c @@ -47,10

[PATCH 1/1 linux-next] scripts/checkpatch.pl: fix k[mz]alloc with multiplies check

checkpatch doesn't seem to detect any case since Commit e367455a9f25 ("checkpatch: emit fewer kmalloc_array/kcalloc conversion warnings") Cc: Joe Perches Cc: Andrew Morton Signed-off-by: Fabian Frederick --- scripts/checkpatch.pl | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 1/1 linux-next] scripts/checkpatch.pl: fix k[mz]alloc with multiplies check

checkpatch doesn't seem to detect any case since Commit e367455a9f25 (checkpatch: emit fewer kmalloc_array/kcalloc conversion warnings) Cc: Joe Perches j...@perches.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- scripts/checkpatch.pl | 4

[PATCH 1/1 net-next] caif: replace kmalloc/memset 0 by kzalloc

Also add blank line after declaration Signed-off-by: Fabian Frederick f...@skynet.be --- net/caif/cfmuxl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/caif/cfmuxl.c b/net/caif/cfmuxl.c index 8c5d638..510aa5a 100644 --- a/net/caif/cfmuxl.c +++ b/net/caif/cfmuxl.c

[PATCH 1/1 net-next] caif_usb: remove redundant memory message

Let MM subsystem display out of memory messages. Signed-off-by: Fabian Frederick f...@skynet.be --- net/caif/caif_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c index ba02db0..0e487b0 100644 --- a/net/caif/caif_usb.c +++ b

[PATCH 1/1 linux-next] fs/affs/amigaffs.c: use va_format instead of buffer/vnsprintf

Remove ErrorBuffer and use %pV Cc: Joe Perches j...@perches.com Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/amigaffs.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/fs/affs/amigaffs.c

Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

> On 10 October 2014 at 10:24 Ilya Dryomov wrote: > > > On Fri, Oct 10, 2014 at 4:41 AM, Dan Mick wrote: > > > > > > On 10/09/2014 02:16 PM, Fabian Frederick wrote: > >> Fix some coccinelle warnings: > >> fs/ceph/caps.c:2400:6-10: WARNING: Assign

[PATCH 1/1 linux-next] scripts/coccinelle/misc/boolinit.cocci: fix assignment warnings

Replace "Assignment of bool to 0/1" by "Assignment of 0/1 to bool" Suggested-by: Dan Mick Signed-off-by: Fabian Frederick --- scripts/coccinelle/misc/boolinit.cocci | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/coccinelle/misc/booli

[PATCH 1/1 linux-next] scripts/coccinelle/misc/boolinit.cocci: fix assignment warnings

Replace Assignment of bool to 0/1 by Assignment of 0/1 to bool Suggested-by: Dan Mick dan.m...@inktank.com Signed-off-by: Fabian Frederick f...@skynet.be --- scripts/coccinelle/misc/boolinit.cocci | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/coccinelle/misc

Re: [PATCH 1/1 linux-next] ceph: fix bool assignments

On 10 October 2014 at 10:24 Ilya Dryomov ilya.dryo...@inktank.com wrote: On Fri, Oct 10, 2014 at 4:41 AM, Dan Mick dan.m...@inktank.com wrote: On 10/09/2014 02:16 PM, Fabian Frederick wrote: Fix some coccinelle warnings: fs/ceph/caps.c:2400:6-10: WARNING: Assignment of bool to 0/1

[PATCH 1/1 linux-next] ceph: fix bool assignments

:3-7: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2549:3-12: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2575:2-6: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2589:3-7: WARNING: Assignment of bool to 0/1 Signed-off-by: Fabian Frederick --- fs/ceph/caps.c | 26

[PATCH 1/1 linux-next] GFS2: directly return gfs2_dir_check()

No need to store gfs2_dir_check result and test it before returning. Signed-off-by: Fabian Frederick --- fs/gfs2/inode.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index c4ed823..b41b5c7 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2

[PATCH 1/1 net-next] mac80211: directly return ieee80211_vif_use_reserved_context()

No need to store ieee80211_vif_use_reserved_context result and test it before returning. Signed-off-by: Fabian Frederick --- net/mac80211/cfg.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index fb6a150..c76b457 100644

[PATCH 1/1 net-next] mac80211: directly return ieee80211_vif_use_reserved_context()

No need to store ieee80211_vif_use_reserved_context result and test it before returning. Signed-off-by: Fabian Frederick f...@skynet.be --- net/mac80211/cfg.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c index fb6a150..c76b457

[PATCH 1/1 linux-next] GFS2: directly return gfs2_dir_check()

No need to store gfs2_dir_check result and test it before returning. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/gfs2/inode.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index c4ed823..b41b5c7 100644 --- a/fs/gfs2/inode.c

[PATCH 1/1 linux-next] ceph: fix bool assignments

:3-7: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2549:3-12: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2575:2-6: WARNING: Assignment of bool to 0/1 fs/ceph/caps.c:2589:3-7: WARNING: Assignment of bool to 0/1 Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ceph/caps.c | 26

[PATCH 1/1 linux-next] ceph: return error code directly.

Testing err before returning value is not needed. Signed-off-by: Fabian Frederick --- fs/ceph/ioctl.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ceph/ioctl.c b/fs/ceph/ioctl.c index a822a6e..b2d777a 100644 --- a/fs/ceph/ioctl.c +++ b/fs/ceph/ioctl.c @@ -54,10

[RFC 1/1 linux-next] fs/affs: only call remove_header on empty directory

Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 1 + fs/affs/amigaffs.c | 18 +- fs/affs/namei.c| 11 +-- 3 files changed, 11 insertions(+), 19 deletions(-) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index 9bca881..3a7f287 100644 --- a/fs/affs/affs.h +++ b

[PATCH 1/1 net-next] netlabel: directly return netlbl_unlabel_genl_init()

No need to store netlbl_unlabel_genl_init result and test it before returning. Signed-off-by: Fabian Frederick --- net/netlabel/netlabel_user.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/netlabel/netlabel_user.c b/net/netlabel/netlabel_user.c index 1e779bb

<    10   11   12   13   14   15   16   17   18   19   >