[RFC 1/1] fs/omfs/file.c: use mpage_readpage() instead of block_read_full_page()

-by: Fabian Frederick --- fs/omfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/omfs/file.c b/fs/omfs/file.c index d9e26cf..672d3c2 100644 --- a/fs/omfs/file.c +++ b/fs/omfs/file.c @@ -286,7 +286,7 @@ out: static int omfs_readpage(struct file *file, struct page

[RFC 1/1] fs/omfs/file.c: use mpage_readpage() instead of block_read_full_page()

-by: Fabian Frederick f...@skynet.be --- fs/omfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/omfs/file.c b/fs/omfs/file.c index d9e26cf..672d3c2 100644 --- a/fs/omfs/file.c +++ b/fs/omfs/file.c @@ -286,7 +286,7 @@ out: static int omfs_readpage(struct file *file

Re: [PATCH 6/6 linux-next] ubifs: remove else after return

On 19 May 2015 at 19:57 Richard Weinberger rich...@nod.at wrote: Am 19.05.2015 um 19:42 schrieb Fabian Frederick:          All was compiled but untested. Can you please test your changes too? Trivial looking changes introduce sometimes issues and having them tested would be wonderful

[PATCH 1/1 linux-next] btrfs: remove -ENOENT from test values in btrfs_get_acl()

system.posix_acl_access: size: 44 acl: not NULL system.posix_acl_default: size: ENODATA acl: NULL Signed-off-by: Fabian Frederick --- fs/btrfs/acl.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c index 9a0124a

[PATCH 1/1 linux-next] btrfs: remove -ENOENT from test values in btrfs_get_acl()

system.posix_acl_access: size: 44 acl: not NULL system.posix_acl_default: size: ENODATA acl: NULL Signed-off-by: Fabian Frederick f...@skynet.be --- fs/btrfs/acl.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/acl.c b/fs/btrfs

[PATCH 1/1] scripts/coccinelle/misc: add swap.cocci

Operations like int a, b, tmp; tmp = a; a = b; b = tmp; can be replaced by int a, b; swap(a, b); This uses kernel.h macro definition and simplifies the code. Thanks to Julia Lawall for suggestions about expressions and sgen Signed-off-by: Fabian Frederick --- scripts/coccinelle/misc

Re: [PATCH 6/6 linux-next] ubifs: remove else after return

> On 19 May 2015 at 00:17 Richard Weinberger > wrote: > > > On Fri, May 15, 2015 at 11:44 PM, Fabian Frederick wrote: > > simplify code in add_to_lpt_heap() > > > > Signed-off-by: Fabian Frederick > > --- > >  fs/ubifs/lprops.c | 11 +-

[PATCH 1/1] scripts/coccinelle/misc: add swap.cocci

Operations like int a, b, tmp; tmp = a; a = b; b = tmp; can be replaced by int a, b; swap(a, b); This uses kernel.h macro definition and simplifies the code. Thanks to Julia Lawall for suggestions about expressions and sgen Signed-off-by: Fabian Frederick f...@skynet.be --- scripts

Re: [PATCH 6/6 linux-next] ubifs: remove else after return

On 19 May 2015 at 00:17 Richard Weinberger richard.weinber...@gmail.com wrote: On Fri, May 15, 2015 at 11:44 PM, Fabian Frederick f...@skynet.be wrote: simplify code in add_to_lpt_heap() Signed-off-by: Fabian Frederick f...@skynet.be ---   fs/ubifs/lprops.c | 11 +--   1

[PATCH V2 linux-next] gfs2: fix shadow warning in gfs2_rbm_find()

bi was already declared and initialized globally in gfs2_rbm_find() Suggested-by: Bob Peterson Signed-off-by: Fabian Frederick --- V2: use global bi instead of new call to rbm_bi() on local variable. fs/gfs2/rgrp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/gfs2

Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

> On 18 May 2015 at 20:20 Vaibhav Hiremath wrote: > > > > > On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote: > > Use kernel.h macro definition. > > > > Signed-off-by: Fabian Frederick > > --- > >   drivers/media/platform/omap/oma

Re: [PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()

> On 18 May 2015 at 19:19 Al Viro wrote: > > > On Mon, May 18, 2015 at 07:13:48PM +0200, Fabian Frederick wrote: > >      * If the block order is wrong, swap the arguments. > >      */ > > -   if ((swap = xfs_dir2_leafn_order(dp, blk1->bp, blk2->bp)))

[PATCH 1/1 linux-next] cdc-acm: use swap() in acm_probe()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- drivers/usb/class/cdc-acm.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 5c8f581..8d045be 100644 --- a/drivers/usb/class/cdc-acm.c

[PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- drivers/media/platform/omap/omap_vout.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index 17b189a..f09c5f1

[PATCH 1/1 linux-next] mmc: mmc-test: use swap() in mmc_test_nonblock_transfer()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- drivers/mmc/card/mmc_test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c index 5e90b3f..b78cf5d 100644 --- a/drivers/mmc/card/mmc_test.c +++ b

[PATCH 1/1 linux-next] video/console: use swap() in newport_bmove()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- drivers/video/console/newport_con.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c index a6ab929..bb4e962 100644 --- a/drivers

[PATCH 1/1 linux-next] video: fbdev: use swap() in ami_set_sprite()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- drivers/video/fbdev/amifb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c index 35f7900..a171bd9 100644 --- a/drivers/video/fbdev/amifb.c +++ b

[PATCH 3/4 linux-next] xfs: use swap() in xfs_attr3_leaf_rebalance()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- fs/xfs/libxfs/xfs_attr_leaf.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c index 04e79d5..a346455 100644 --- a/fs/xfs/libxfs

[PATCH 1/2 linux-next] btrfs: use swap() in __merge_refs

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- fs/btrfs/backref.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 9de772e..01abe4c 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c @@ -530,7

[PATCH 4/4 linux-next] xfs: use swap() in xfs_da3_node_rebalance()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- fs/xfs/libxfs/xfs_da_btree.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/xfs/libxfs/xfs_da_btree.c b/fs/xfs/libxfs/xfs_da_btree.c index 2385f8c..f0101a8 100644 --- a/fs/xfs/libxfs/xfs_da_btree.c

[PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()

Use kernel.h macro definition. Also remove assignment in if condition (checkpatch error) Signed-off-by: Fabian Frederick --- fs/xfs/libxfs/xfs_dir2_node.c | 8 ++-- Signed-off-by: Fabian Frederick --- fs/xfs/libxfs/xfs_dir2_node.c | 9 +++-- 1 file changed, 3 insertions(+), 6

[PATCH 1/1 linux-next] staging: xgifb: use swap() in XGI_WriteDAC()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- drivers/staging/xgifb/vb_setmode.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index a47395e..3b0b4d3 100644

[PATCH 2/2 linux-next] btrfs: use swap() in merge_ref()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- fs/btrfs/delayed-ref.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed-ref.c index 8f8ed7d..97c5a19 100644 --- a/fs/btrfs/delayed-ref.c +++ b/fs/btrfs/delayed

[PATCH 2/4 linux-next] xfs: use swap() in xfs_lock_two_inodes()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- fs/xfs/xfs_inode.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index d6ebc85..d4f3a09 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c @@ -500,7

[PATCH 1/1 linux-next] video: fbdev: matrox: use swap() in matroxfb_decode_var()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick --- drivers/video/fbdev/matrox/matroxfb_base.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c index 62539ca..2ba4e54

[PATCH 1/1 linux-next] video: fbdev: matrox: use swap() in matroxfb_decode_var()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/video/fbdev/matrox/matroxfb_base.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c index

[PATCH 1/1 linux-next] video/console: use swap() in newport_bmove()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/video/console/newport_con.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/console/newport_con.c b/drivers/video/console/newport_con.c index a6ab929..bb4e962 100644

[PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/media/platform/omap/omap_vout.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index

[PATCH 1/1 linux-next] cdc-acm: use swap() in acm_probe()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/usb/class/cdc-acm.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index 5c8f581..8d045be 100644 --- a/drivers/usb

[PATCH 2/4 linux-next] xfs: use swap() in xfs_lock_two_inodes()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/xfs/xfs_inode.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c index d6ebc85..d4f3a09 100644 --- a/fs/xfs/xfs_inode.c +++ b/fs/xfs/xfs_inode.c

[PATCH 2/2 linux-next] btrfs: use swap() in merge_ref()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/btrfs/delayed-ref.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed-ref.c index 8f8ed7d..97c5a19 100644 --- a/fs/btrfs/delayed-ref.c +++ b/fs

[PATCH 4/4 linux-next] xfs: use swap() in xfs_da3_node_rebalance()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/xfs/libxfs/xfs_da_btree.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/xfs/libxfs/xfs_da_btree.c b/fs/xfs/libxfs/xfs_da_btree.c index 2385f8c..f0101a8 100644 --- a/fs/xfs/libxfs

[PATCH 1/2 linux-next] btrfs: use swap() in __merge_refs

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/btrfs/backref.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 9de772e..01abe4c 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c

[PATCH 3/4 linux-next] xfs: use swap() in xfs_attr3_leaf_rebalance()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/xfs/libxfs/xfs_attr_leaf.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/fs/xfs/libxfs/xfs_attr_leaf.c b/fs/xfs/libxfs/xfs_attr_leaf.c index 04e79d5..a346455 100644 --- a/fs/xfs

[PATCH 1/1 linux-next] video: fbdev: use swap() in ami_set_sprite()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/video/fbdev/amifb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/amifb.c b/drivers/video/fbdev/amifb.c index 35f7900..a171bd9 100644 --- a/drivers/video/fbdev

[PATCH 1/1 linux-next] staging: xgifb: use swap() in XGI_WriteDAC()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/staging/xgifb/vb_setmode.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c index a47395e

[PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()

Use kernel.h macro definition. Also remove assignment in if condition (checkpatch error) Signed-off-by: Fabian Frederick f...@skynet.be --- fs/xfs/libxfs/xfs_dir2_node.c | 8 ++-- Signed-off-by: Fabian Frederick f...@skynet.be --- fs/xfs/libxfs/xfs_dir2_node.c | 9 +++-- 1 file changed

[PATCH 1/1 linux-next] mmc: mmc-test: use swap() in mmc_test_nonblock_transfer()

Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/mmc/card/mmc_test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/card/mmc_test.c b/drivers/mmc/card/mmc_test.c index 5e90b3f..b78cf5d 100644 --- a/drivers/mmc/card

Re: [PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()

On 18 May 2015 at 19:19 Al Viro v...@zeniv.linux.org.uk wrote: On Mon, May 18, 2015 at 07:13:48PM +0200, Fabian Frederick wrote:       * If the block order is wrong, swap the arguments.       */ -   if ((swap = xfs_dir2_leafn_order(dp, blk1-bp, blk2-bp

[PATCH V2 linux-next] gfs2: fix shadow warning in gfs2_rbm_find()

bi was already declared and initialized globally in gfs2_rbm_find() Suggested-by: Bob Peterson rpete...@redhat.com Signed-off-by: Fabian Frederick f...@skynet.be --- V2: use global bi instead of new call to rbm_bi() on local variable. fs/gfs2/rgrp.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: [PATCH 1/1 linux-next] omap_vout: use swap() in omapvid_init()

On 18 May 2015 at 20:20 Vaibhav Hiremath vaibhav.hirem...@linaro.org wrote: On Monday 18 May 2015 11:24 PM, Fabian Frederick wrote: Use kernel.h macro definition. Signed-off-by: Fabian Frederick f...@skynet.be ---    drivers/media/platform/omap/omap_vout.c | 10 +++---    1

[PATCH V2 2/2 linux-next RESEND] affs: add tmpfile support

Based on the following patch: commit 60545d0d4610 ("[O_TMPFILE] it's still short a few helpers, but infrastructure should be OK now...") Tested with xfstests generic/004 Cc: Andrew Morton Cc: Alexander Viro Cc: Jan Kara Reviewed-by: Jan Kara Signed-off-by: Fabian Frederick -

[PATCH V2 1/2 linux-next RESEND] affs: mark new inode before hashtable insertion

-by: Jan Kara Reviewed-by: Jan Kara Signed-off-by: Fabian Frederick --- V2: -remove insert_inode_hash() to avoid double insert -update patch subject fs/affs/inode.c | 4 ++-- fs/affs/namei.c | 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/affs/inode.c b/fs/affs

[PATCH 6/6 linux-next] ubifs: remove else after return

simplify code in add_to_lpt_heap() Signed-off-by: Fabian Frederick --- fs/ubifs/lprops.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c index a0011aa..e1454cf 100644 --- a/fs/ubifs/lprops.c +++ b/fs/ubifs/lprops.c @@ -208,13

[PATCH 3/6 linux-next] ubifs: simplify return in layout_cnodes()

Directly return dbg_chk_lpt_sz() instead of storing value in err and testing it. Signed-off-by: Fabian Frederick --- fs/ubifs/lpt_commit.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c index ce89bdc..79a8e96 100644 --- a/fs

[PATCH 5/6 linux-next] ubifs: remove unnecessary else after break

else is not needed after break in dbg_check_old_index() This also solves the {} parity. Signed-off-by: Fabian Frederick --- fs/ubifs/commit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ubifs/commit.c b/fs/ubifs/commit.c index 63f5661..dd9ba81 100644 --- a/fs

[PATCH 4/6 linux-next] ubifs: simplify return in sort_nodes()

Directly return dbg_check_nondata_nodes_order() instead of storing value in err and testing it. Signed-off-by: Fabian Frederick --- fs/ubifs/gc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c index 9718da8..bf0a3eb 100644 --- a/fs/ubifs

[PATCH 1/6 linux-next] ubifs: remove unnecessary semi-colon

semi-colon after case is unneeded. Signed-off-by: Fabian Frederick --- fs/ubifs/sb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c index f4fbc7b..50be857 100644 --- a/fs/ubifs/sb.c +++ b/fs/ubifs/sb.c @@ -586,7 +586,7 @@ int

[PATCH 2/6 linux-next] ubifs: simplify return in shrink_liability()

Directly return ubifs_return_leb() instead of storing value in err and testing it. Signed-off-by: Fabian Frederick --- fs/ubifs/budget.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/ubifs/budget.c b/fs/ubifs/budget.c index 11a11b3..c07b770 100644 --- a/fs/ubifs

[PATCH 1/1 linux-next] udf: remove double err declaration in udf_file_write_iter()

Use first err declaration for generic_write_sync() return value. Signed-off-by: Fabian Frederick --- fs/udf/file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/udf/file.c b/fs/udf/file.c index 7a95b8f..bddf3d0 100644 --- a/fs/udf/file.c +++ b/fs/udf/file.c @@ -152,8 +152,6 @@ out

[PATCH 1/1 linux-next] gfs2: fix shadow warning in gfs2_rbm_find()

bi was already declared globally in gfs2_rbm_find() Use bi_full for this variable in "Mark bitmap as full and fall through" context. Also add blank line after declaration. Signed-off-by: Fabian Frederick --- fs/gfs2/rgrp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH 1/1 linux-next] fs/affs/symlink.c: remove unneeded err variable

err is only assigned to -EIO Return that value at the end of fail context. Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/symlink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/affs/symlink.c b/fs/affs/symlink.c index f39b71c..ea5b69a 100644 --- a/fs

[PATCH 1/1 linux-next] ext4: fix incorrect type argument

got void * Signed-off-by: Fabian Frederick --- fs/ext4/ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 2cb9e17..3c5e530 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -675,8 +675,8 @@ encryption_

[PATCH 6/6 linux-next] ubifs: remove else after return

simplify code in add_to_lpt_heap() Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ubifs/lprops.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/fs/ubifs/lprops.c b/fs/ubifs/lprops.c index a0011aa..e1454cf 100644 --- a/fs/ubifs/lprops.c +++ b/fs/ubifs

[PATCH 3/6 linux-next] ubifs: simplify return in layout_cnodes()

Directly return dbg_chk_lpt_sz() instead of storing value in err and testing it. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ubifs/lpt_commit.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ubifs/lpt_commit.c b/fs/ubifs/lpt_commit.c index ce89bdc..79a8e96

[PATCH 1/6 linux-next] ubifs: remove unnecessary semi-colon

semi-colon after case is unneeded. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ubifs/sb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ubifs/sb.c b/fs/ubifs/sb.c index f4fbc7b..50be857 100644 --- a/fs/ubifs/sb.c +++ b/fs/ubifs/sb.c @@ -586,7 +586,7 @@ int

[PATCH 2/6 linux-next] ubifs: simplify return in shrink_liability()

Directly return ubifs_return_leb() instead of storing value in err and testing it. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ubifs/budget.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/ubifs/budget.c b/fs/ubifs/budget.c index 11a11b3..c07b770 100644

[PATCH 5/6 linux-next] ubifs: remove unnecessary else after break

else is not needed after break in dbg_check_old_index() This also solves the {} parity. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ubifs/commit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/ubifs/commit.c b/fs/ubifs/commit.c index 63f5661..dd9ba81

[PATCH 4/6 linux-next] ubifs: simplify return in sort_nodes()

Directly return dbg_check_nondata_nodes_order() instead of storing value in err and testing it. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ubifs/gc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/ubifs/gc.c b/fs/ubifs/gc.c index 9718da8..bf0a3eb 100644

[PATCH V2 1/2 linux-next RESEND] affs: mark new inode before hashtable insertion

...@zeniv.linux.org.uk Cc: Jan Kara j...@suse.cz Suggested-by: Jan Kara j...@suse.cz Reviewed-by: Jan Kara j...@suse.cz Signed-off-by: Fabian Frederick f...@skynet.be --- V2: -remove insert_inode_hash() to avoid double insert -update patch subject fs/affs/inode.c | 4 ++-- fs/affs/namei.c | 6

[PATCH V2 2/2 linux-next RESEND] affs: add tmpfile support

-by: Jan Kara j...@suse.cz Signed-off-by: Fabian Frederick f...@skynet.be --- V2: add Reviewed-by fs/affs/affs.h | 1 + fs/affs/dir.c | 1 + fs/affs/namei.c | 23 +++ 3 files changed, 25 insertions(+) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index cffe837..c3f60a5 100644

[PATCH 1/1 linux-next] ext4: fix incorrect type argument

void *noident Signed-off-by: Fabian Frederick f...@skynet.be --- fs/ext4/ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 2cb9e17..3c5e530 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -675,8 +675,8

[PATCH 1/1 linux-next] fs/affs/symlink.c: remove unneeded err variable

err is only assigned to -EIO Return that value at the end of fail context. Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/symlink.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/affs/symlink.c b/fs/affs/symlink.c

[PATCH 1/1 linux-next] gfs2: fix shadow warning in gfs2_rbm_find()

bi was already declared globally in gfs2_rbm_find() Use bi_full for this variable in Mark bitmap as full and fall through context. Also add blank line after declaration. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/gfs2/rgrp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions

[PATCH 1/1 linux-next] udf: remove double err declaration in udf_file_write_iter()

Use first err declaration for generic_write_sync() return value. Signed-off-by: Fabian Frederick f...@skynet.be --- fs/udf/file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/udf/file.c b/fs/udf/file.c index 7a95b8f..bddf3d0 100644 --- a/fs/udf/file.c +++ b/fs/udf/file.c @@ -152,8

Re: [PATCH 1/1 linux-next] configfs: unexport/make static config_item_init()

> On 14 May 2015 at 12:41 Daniel Baluta wrote: > > > On Wed, Apr 29, 2015 at 8:01 PM, Fabian Frederick wrote: > > config_item_init() is only used in item.c > > > > Signed-off-by: Fabian Frederick > > Nack! Have a look at drivers/usb/ga

Re: [PATCH 1/1 linux-next] configfs: unexport/make static config_item_init()

On 14 May 2015 at 12:41 Daniel Baluta daniel.bal...@gmail.com wrote: On Wed, Apr 29, 2015 at 8:01 PM, Fabian Frederick f...@skynet.be wrote: config_item_init() is only used in item.c Signed-off-by: Fabian Frederick f...@skynet.be Nack! Have a look at drivers/usb/gadget/configfs.c

Re: [PATCH 2/2 linux-next] drm/msm: use IS_ERR() to check regulator_get() return

Please ignore this patch, I just noticed conditional regulator_get() definition (#if defined(CONFIG_REGULATOR)) Regards, Fabian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH V2 1/2 linux-next] affs: mark new inode before hashtable insertion

-by: Jan Kara Signed-off-by: Fabian Frederick --- V2: -remove insert_inode_hash() to avoid double insert -update patch subject fs/affs/inode.c | 4 ++-- fs/affs/namei.c | 6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 1734950

[PATCH V2 2/2 linux-next] affs: add tmpfile support

Based on the following patch: commit 60545d0d4610 ("[O_TMPFILE] it's still short a few helpers, but infrastructure should be OK now...") Tested with xfstests generic/004 Cc: Andrew Morton Cc: Alexander Viro Cc: Jan Kara Reviewed-by: Jan Kara Signed-off-by: Fabian Frederick -

Re: [PATCH 2/2 linux-next] drm/msm: use IS_ERR() to check regulator_get() return

Please ignore this patch, I just noticed conditional regulator_get() definition (#if defined(CONFIG_REGULATOR)) Regards, Fabian -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH V2 2/2 linux-next] affs: add tmpfile support

-by: Jan Kara j...@suse.cz Signed-off-by: Fabian Frederick f...@skynet.be --- V2: add Reviewed-by fs/affs/affs.h | 1 + fs/affs/dir.c | 1 + fs/affs/namei.c | 23 +++ 3 files changed, 25 insertions(+) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index cffe837..c3f60a5 100644

[PATCH V2 1/2 linux-next] affs: mark new inode before hashtable insertion

...@zeniv.linux.org.uk Cc: Jan Kara j...@suse.cz Suggested-by: Jan Kara j...@suse.cz Signed-off-by: Fabian Frederick f...@skynet.be --- V2: -remove insert_inode_hash() to avoid double insert -update patch subject fs/affs/inode.c | 4 ++-- fs/affs/namei.c | 6 ++ 2 files changed, 8 insertions

[PATCH 1/2 linux-next] fs/affs/inode.c: mark new inode before hashtable insertion

-by: Jan Kara Signed-off-by: Fabian Frederick --- fs/affs/inode.c | 2 ++ fs/affs/namei.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 1734950..859a9cb 100644 --- a/fs/affs/inode.c +++ b/fs/affs/inode.c @@ -323,6 +323,8 @@ affs_new_inode(struct

[PATCH 2/2 linux-next] AFFS: add tmpfile support

Based on the following patch: commit 60545d0d4610 ("[O_TMPFILE] it's still short a few helpers, but infrastructure should be OK now...") Tested with xfstests generic/004 Cc: Andrew Morton Cc: Alexander Viro Cc: Jan Kara Signed-off-by: Fabian Frederick --- fs/affs/affs.h | 1

Re: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions

> On 04 May 2015 at 23:30 "Rafael J. Wysocki" wrote: > > > On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote: > > EXPORT macro must be placed directly after functions. > > See Documentation/CodingStyle Chapter 6 > > Well, why is this change

[PATCH V3 linux-next] gfs2: convert simple_str to kstr

-Remove obsolete simple_str functions. -Return error code when kstr failed. -This patch also calls functions corresponding to destination type. Thanks to Alexey Dobriyan for suggesting improvements in block_store() and wdack_store() Signed-off-by: Fabian Frederick --- V3: -Compare kstr return

Re: [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static

> On 05 May 2015 at 18:03 Joerg Roedel wrote: > > > On Wed, Apr 29, 2015 at 09:05:17PM +0200, Fabian Frederick wrote: > > msm_iommu_lock is only used in msm_iommu.c > > > > Signed-off-by: Fabian Frederick > > --- > >  drivers/iommu/msm_iommu.c | 2

Re: [PATCH V2 linux-next] gfs2: convert simple_str to kstr

destination type. > > > > Thanks to Alexey Dobriyan for suggesting improvements in > > block_store() and wdack_store() > > > > Signed-off-by: Fabian Frederick > > --- > >  fs/gfs2/sys.c | 69 > >  ++- &

[PATCH 2/2 linux-next] AFFS: add tmpfile support

-by: Fabian Frederick f...@skynet.be --- fs/affs/affs.h | 1 + fs/affs/dir.c | 1 + fs/affs/namei.c | 23 +++ 3 files changed, 25 insertions(+) diff --git a/fs/affs/affs.h b/fs/affs/affs.h index cffe837..c3f60a5 100644 --- a/fs/affs/affs.h +++ b/fs/affs/affs.h @@ -180,6 +180,7

[PATCH 1/2 linux-next] fs/affs/inode.c: mark new inode before hashtable insertion

...@zeniv.linux.org.uk Cc: Jan Kara j...@suse.cz Suggested-by: Jan Kara j...@suse.cz Signed-off-by: Fabian Frederick f...@skynet.be --- fs/affs/inode.c | 2 ++ fs/affs/namei.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 1734950..859a9cb 100644

Re: [PATCH V2 linux-next] gfs2: convert simple_str to kstr

Dobriyan for suggesting improvements in block_store() and wdack_store() Signed-off-by: Fabian Frederick f...@skynet.be ---   fs/gfs2/sys.c | 69   ++-   1 file changed, 49 insertions(+), 20 deletions(-) diff --git a/fs/gfs2/sys.c b/fs

[PATCH V3 linux-next] gfs2: convert simple_str to kstr

-Remove obsolete simple_str functions. -Return error code when kstr failed. -This patch also calls functions corresponding to destination type. Thanks to Alexey Dobriyan for suggesting improvements in block_store() and wdack_store() Signed-off-by: Fabian Frederick f...@skynet.be --- V3: -Compare

Re: [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static

On 05 May 2015 at 18:03 Joerg Roedel j...@8bytes.org wrote: On Wed, Apr 29, 2015 at 09:05:17PM +0200, Fabian Frederick wrote: msm_iommu_lock is only used in msm_iommu.c Signed-off-by: Fabian Frederick f...@skynet.be ---   drivers/iommu/msm_iommu.c | 2 +-   1 file changed, 1

Re: [PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions

On 04 May 2015 at 23:30 Rafael J. Wysocki r...@rjwysocki.net wrote: On Saturday, May 02, 2015 06:01:21 PM Fabian Frederick wrote: EXPORT macro must be placed directly after functions. See Documentation/CodingStyle Chapter 6 Well, why is this change an improvement? Yes, it makes

[PATCH 1/1 linux-next] block: loop: use IS_ERR() to check blk_mq_init_queue() return

blk_mq_init_queue() never returns NULL. There's no need for IS_ERR_OR_NULL() Signed-off-by: Fabian Frederick --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index ae3fcb4..3fb23e9 100644 --- a/drivers/block

[PATCH 2/2 linux-next] drm/msm: use IS_ERR() to check regulator_get() return

regulator_get() never returns NULL. There's no need for IS_ERR_OR_NULL() Signed-off-by: Fabian Frederick --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c index

[PATCH 1/2 linux-next] drm/msm: use IS_ERR() to check msm_ioremap() return

msm_ioremap() never returns NULL. There's no need for IS_ERR_OR_NULL() Signed-off-by: Fabian Frederick --- drivers/gpu/drm/msm/dsi/dsi_phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_phy.c b/drivers/gpu/drm/msm/dsi/dsi_phy.c index

[PATCH 1/2 linux-next] drm/msm: use IS_ERR() to check msm_ioremap() return

msm_ioremap() never returns NULL. There's no need for IS_ERR_OR_NULL() Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/gpu/drm/msm/dsi/dsi_phy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_phy.c b/drivers/gpu/drm/msm/dsi

[PATCH 2/2 linux-next] drm/msm: use IS_ERR() to check regulator_get() return

regulator_get() never returns NULL. There's no need for IS_ERR_OR_NULL() Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi

[PATCH 1/1 linux-next] block: loop: use IS_ERR() to check blk_mq_init_queue() return

blk_mq_init_queue() never returns NULL. There's no need for IS_ERR_OR_NULL() Signed-off-by: Fabian Frederick f...@skynet.be --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index ae3fcb4..3fb23e9 100644

Re: [PATCH 1/1 linux-next] affs: add default case in switch

> On 03 May 2015 at 20:23 Richard Weinberger wrote: > > > Am 03.05.2015 um 20:15 schrieb Fabian Frederick: > >> If the code can be reached you need to take a proper action of not the > >> warning is bogus. > > > > As far as I understand, switch

Re: [PATCH 1/1 linux-next] affs: add default case in switch

> On 03 May 2015 at 16:51 Richard Weinberger > wrote: > > > On Sat, May 2, 2015 at 8:56 PM, Fabian Frederick wrote: > > Fix gcc -Wswitch-default warnings > > > > Cc: Andrew Morton > > Signed-off-by: Fabian Frederick > > --- > >  fs/affs

Re: [PATCH 1/1 linux-next] affs: add default case in switch

On 03 May 2015 at 20:23 Richard Weinberger rich...@nod.at wrote: Am 03.05.2015 um 20:15 schrieb Fabian Frederick: If the code can be reached you need to take a proper action of not the warning is bogus. As far as I understand, switch in affs_lookup() only updates inode number when

Re: [PATCH 1/1 linux-next] affs: add default case in switch

On 03 May 2015 at 16:51 Richard Weinberger richard.weinber...@gmail.com wrote: On Sat, May 2, 2015 at 8:56 PM, Fabian Frederick f...@skynet.be wrote: Fix gcc -Wswitch-default warnings Cc: Andrew Morton a...@linux-foundation.org Signed-off-by: Fabian Frederick f...@skynet.be

[PATCH 1/1 linux-next] [media] siano: define SRVM_MAX_PID_FILTERS only once

SRVM_MAX_PID_FILTERS was defined in 2 sms_tx_stats structures Signed-off-by: Fabian Frederick --- drivers/media/common/siano/smscoreapi.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/common/siano/smscoreapi.h b/drivers/media/common/siano/smscoreapi.h

[PATCH 1/1 linux-next] affs: add default case in switch

Fix gcc -Wswitch-default warnings Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/affs/inode.c | 2 ++ fs/affs/namei.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/fs/affs/inode.c b/fs/affs/inode.c index 1734950..623398e 100644 --- a/fs/affs/inode.c +++ b/fs/affs/inode.c

[PATCH 1/1 linux-next] gfs2: kerneldoc warning fixes

): No description found for parameter 'copied' Signed-off-by: Fabian Frederick --- fs/gfs2/aops.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c index 5551fea..1caee05 100644 --- a/fs/gfs2/aops.c +++ b/fs/gfs2/aops.c @@ -171,6

[PATCH 1/1 linux-next] PNP: move EXPORT_SYMBOL after functions

EXPORT macro must be placed directly after functions. See Documentation/CodingStyle Chapter 6 Signed-off-by: Fabian Frederick --- drivers/pnp/driver.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c index 153a493..b690e6b

[PATCH 1/2 linux-next] PNPACPI: use u8 instead of int in acpi_resource_extended_irq context

acpi_resource_extented_irq variables are all u8. Use that type for triggering, polarity and shareable. This fixes gcc warnings of type "conversion to u8 from int may alter its value" Signed-off-by: Fabian Frederick --- drivers/pnp/pnpacpi/rsparser.c | 8 1 file changed, 4

<    2   3   4   5   6   7   8   9   10   11   >