use unsigned int for port, irq, dma and mem used for pnp_get_resource()
This fixes gcc warnings of type "conversion to unsigned int
from int may change the sign of the result"
Signed-off-by: Fabian Frederick
---
drivers/pnp/pnpacpi/rsparser.c | 2 +-
1 file changed, 1 insertion(+),
EXPORT macro must be placed directly after functions.
See Documentation/CodingStyle Chapter 6
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/pnp/driver.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c
index
acpi_resource_extented_irq variables are all u8.
Use that type for triggering, polarity and shareable.
This fixes gcc warnings of type
conversion to u8 from int may alter its value
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/pnp/pnpacpi/rsparser.c | 8
1 file changed, 4
use unsigned int for port, irq, dma and mem used for pnp_get_resource()
This fixes gcc warnings of type conversion to unsigned int
from int may change the sign of the result
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/pnp/pnpacpi/rsparser.c | 2 +-
1 file changed, 1 insertion
): No description found for parameter 'copied'
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/gfs2/aops.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 5551fea..1caee05 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
Fix gcc -Wswitch-default warnings
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/affs/inode.c | 2 ++
fs/affs/namei.c | 3 +++
2 files changed, 5 insertions(+)
diff --git a/fs/affs/inode.c b/fs/affs/inode.c
index 1734950..623398e 100644
SRVM_MAX_PID_FILTERS was defined in 2 sms_tx_stats structures
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/media/common/siano/smscoreapi.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/common/siano/smscoreapi.h
b/drivers/media/common/siano
pxa255_run_freqs and pxa255_turbo_freqs are only read.
This patch updates arrays declaration, find_freq_tables()
and its callsites.
Suggested-by: Joe Perches
Signed-off-by: Fabian Frederick
---
Compiled but untested.
drivers/cpufreq/pxa2xx-cpufreq.c | 12 ++--
1 file changed, 6
typedef is not really useful here. Replace it by structure
to improve readability. typedef should only be used in some cases.
(See Documentation/CodingStyle Chapter 5 for details).
Signed-off-by: Fabian Frederick
---
Compiled but untested.
V3: -constify arrays(patch 2) (suggested by Joe Perches
typedef is not really useful here. Replace it by structure
to improve readability. typedef should only be used in some cases.
(See Documentation/CodingStyle Chapter 5 for details).
Signed-off-by: Fabian Frederick f...@skynet.be
---
Compiled but untested.
V3: -constify arrays(patch 2) (suggested
pxa255_run_freqs and pxa255_turbo_freqs are only read.
This patch updates arrays declaration, find_freq_tables()
and its callsites.
Suggested-by: Joe Perches j...@perches.com
Signed-off-by: Fabian Frederick f...@skynet.be
---
Compiled but untested.
drivers/cpufreq/pxa2xx-cpufreq.c | 12
> On 30 April 2015 at 09:55 Boaz Harrosh wrote:
>
>
> On 04/29/2015 08:58 PM, Fabian Frederick wrote:
> > replace obsolete function.
> >
> > Signed-off-by: Fabian Frederick
>
> Thanks.
> ACK-by: Boaz Harrosh
>
> Are you pushing all these through s
> On 30 April 2015 at 06:46 Joe Perches wrote:
>
>
> On Wed, 2015-04-29 at 21:32 +0200, Fabian Frederick wrote:
> > typedef is not really useful here. Replace it by structure
> > to improve readability.typedef should only be used in some cases.
> > (See Docum
-Remove obsolete simple_str functions.
-Return error code when kstr failed.
-This patch also calls functions corresponding to destination type.
Thanks to Alexey Dobriyan for suggesting improvements in
block_store() and wdack_store()
Signed-off-by: Fabian Frederick
---
fs/gfs2/sys.c | 69
On 30 April 2015 at 06:46 Joe Perches j...@perches.com wrote:
On Wed, 2015-04-29 at 21:32 +0200, Fabian Frederick wrote:
typedef is not really useful here. Replace it by structure
to improve readability.typedef should only be used in some cases.
(See Documentation/CodingStyle Chapter 5
-Remove obsolete simple_str functions.
-Return error code when kstr failed.
-This patch also calls functions corresponding to destination type.
Thanks to Alexey Dobriyan for suggesting improvements in
block_store() and wdack_store()
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/gfs2
On 30 April 2015 at 09:55 Boaz Harrosh o...@electrozaur.com wrote:
On 04/29/2015 08:58 PM, Fabian Frederick wrote:
replace obsolete function.
Signed-off-by: Fabian Frederick f...@skynet.be
Thanks.
ACK-by: Boaz Harrosh o...@electrozaur.com
Are you pushing all these through some
typedef is not really useful here. Replace it by structure
to improve readability.typedef should only be used in some cases.
(See Documentation/CodingStyle Chapter 5 for details).
Signed-off-by: Fabian Frederick
---
V2: verbose changelog.
drivers/cpufreq/pxa2xx-cpufreq.c | 20
msm_iommu_lock is only used in msm_iommu.c
Signed-off-by: Fabian Frederick
---
drivers/iommu/msm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
index 15a2063..f2a6321 100644
--- a/drivers/iommu/msm_iommu.c
+++ b
such problems.
By default I used destination type as a reference. Maybe it's wrong and we
really want to read long, unsigned long from source ?
Signed-off-by: Fabian Frederick
---
fs/gfs2/sys.c | 56
1 file changed, 44 insertions(+), 12 deletions
bnx2fc_global_lock is only used in bnx2fc_fcoe.c
Signed-off-by: Fabian Frederick
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 98d06d1..66fb527 100644
replace obsolete function.
Signed-off-by: Fabian Frederick
---
This is untested.
fs/exofs/super.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/exofs/super.c b/fs/exofs/super.c
index b795c56..b667f73 100644
--- a/fs/exofs/super.c
+++ b/fs/exofs/super.c
@@ -108,9
config_item_init() is only used in item.c
Signed-off-by: Fabian Frederick
---
fs/configfs/item.c | 3 +--
include/linux/configfs.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/configfs/item.c b/fs/configfs/item.c
index e65f9ff..4d6a30e 100644
--- a/fs/configfs
config_item_init() is only used in item.c
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/configfs/item.c | 3 +--
include/linux/configfs.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/configfs/item.c b/fs/configfs/item.c
index e65f9ff..4d6a30e 100644
typedef is not really useful here. Replace it by structure
to improve readability.typedef should only be used in some cases.
(See Documentation/CodingStyle Chapter 5 for details).
Signed-off-by: Fabian Frederick f...@skynet.be
---
V2: verbose changelog.
drivers/cpufreq/pxa2xx-cpufreq.c | 20
such problems.
By default I used destination type as a reference. Maybe it's wrong and we
really want to read long, unsigned long from source ?
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/gfs2/sys.c | 56
1 file changed, 44 insertions
msm_iommu_lock is only used in msm_iommu.c
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/iommu/msm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
index 15a2063..f2a6321 100644
--- a/drivers/iommu
bnx2fc_global_lock is only used in bnx2fc_fcoe.c
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
index 98d06d1..66fb527
replace obsolete function.
Signed-off-by: Fabian Frederick f...@skynet.be
---
This is untested.
fs/exofs/super.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/exofs/super.c b/fs/exofs/super.c
index b795c56..b667f73 100644
--- a/fs/exofs/super.c
+++ b/fs/exofs
> On 28 April 2015 at 19:39 Al Viro wrote:
>
>
> On Tue, Apr 28, 2015 at 06:42:10PM +0200, Fabian Frederick wrote:
> >
> >
> > > On 28 April 2015 at 18:05 Al Viro wrote:
> > >
> > >
> > > On Tue, Apr 28, 2015 at 07:35:10AM +0200, Fa
> On 28 April 2015 at 18:05 Al Viro wrote:
>
>
> On Tue, Apr 28, 2015 at 07:35:10AM +0200, Fabian Frederick wrote:
>
> > > Al, very unhappy about the prospect of looking through ~2000 calls of
> > > strlcpy()
> > > we have in the tree...
> >
>
On 28 April 2015 at 18:05 Al Viro v...@zeniv.linux.org.uk wrote:
On Tue, Apr 28, 2015 at 07:35:10AM +0200, Fabian Frederick wrote:
Al, very unhappy about the prospect of looking through ~2000 calls of
strlcpy()
we have in the tree...
Sorry Al, I thought it was more secure
On 28 April 2015 at 19:39 Al Viro v...@zeniv.linux.org.uk wrote:
On Tue, Apr 28, 2015 at 06:42:10PM +0200, Fabian Frederick wrote:
On 28 April 2015 at 18:05 Al Viro v...@zeniv.linux.org.uk wrote:
On Tue, Apr 28, 2015 at 07:35:10AM +0200, Fabian Frederick wrote:
Al
> On 28 April 2015 at 05:48 Al Viro wrote:
>
>
> commit 39d7a29f867bd5a4a551fad6bb3812ceddb0bce1
> Author: Fabian Frederick
> Date: Fri Jun 6 14:36:15 2014 -0700
>
> fs/befs/linuxvfs.c: replace strncpy by strlcpy
>
> strncpy + end of string
> On 27 April 2015 at 20:37 Jan Harkes wrote:
>
>
> On Mon, Apr 27, 2015 at 07:23:06PM +0200, Fabian Frederick wrote:
> > Move UPARG code to alloc_upcall() and test errors/return in callsites.
> > This patch removes flow control in macros which must be avoided
Move UPARG code to alloc_upcall() and test errors/return in callsites.
This patch removes flow control in macros which must be avoided.
(See Documentation/CodingStyle)
Signed-off-by: Fabian Frederick
---
This is untested.
fs/coda/upcall.c | 107
Inspired by scripts/coccinelle/api/err_cast.cocci
Signed-off-by: Fabian Frederick
---
include/linux/pinctrl/consumer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/pinctrl/consumer.h b/include/linux/pinctrl/consumer.h
index 18eccef..d7e5d60 100644
On 27 April 2015 at 20:37 Jan Harkes jahar...@cs.cmu.edu wrote:
On Mon, Apr 27, 2015 at 07:23:06PM +0200, Fabian Frederick wrote:
Move UPARG code to alloc_upcall() and test errors/return in callsites.
This patch removes flow control in macros which must be avoided.
(See Documentation
Inspired by scripts/coccinelle/api/err_cast.cocci
Signed-off-by: Fabian Frederick f...@skynet.be
---
include/linux/pinctrl/consumer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/pinctrl/consumer.h b/include/linux/pinctrl/consumer.h
index 18eccef..d7e5d60
Move UPARG code to alloc_upcall() and test errors/return in callsites.
This patch removes flow control in macros which must be avoided.
(See Documentation/CodingStyle)
Signed-off-by: Fabian Frederick f...@skynet.be
---
This is untested.
fs/coda/upcall.c | 107
On 28 April 2015 at 05:48 Al Viro v...@zeniv.linux.org.uk wrote:
commit 39d7a29f867bd5a4a551fad6bb3812ceddb0bce1
Author: Fabian Frederick f...@skynet.be
Date: Fri Jun 6 14:36:15 2014 -0700
fs/befs/linuxvfs.c: replace strncpy by strlcpy
strncpy + end of string assignment
bh, od_sup and this_node are unconditionally initialized in
befs_bt_read_super() and befs_btree_find()
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/befs/btree.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/befs/btree.c b/fs/befs/btree.c
index 0826e91
bh is initialized unconditionally in affs_add_entry()
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/affs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/affs/inode.c b/fs/affs/inode.c
index a022f4a..1734950 100644
--- a/fs/affs/inode.c
+++ b/fs/affs
bh is initialized unconditionally in affs_remove_link()
Cc: Andrew Morton
Signed-off-by: Fabian Frederick
---
fs/affs/amigaffs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c
index 1df7478..4ff6edb 100644
--- a/fs/affs/amigaffs.c
Inspired by scripts/coccinelle/api/err_cast.cocci
Signed-off-by: Fabian Frederick
---
drivers/gpu/drm/i915/intel_drv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 897f17d..d52f267 100644
See Documentation/CodingStyle.
Signed-off-by: Fabian Frederick
---
drivers/cpufreq/pxa2xx-cpufreq.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
index e24269a..fcf6e34 100644
insert_inline_extent() checked for compressed_pages to be NULL then
it accessed it under compress_type != BTRFS_COMPRESS_NONE.
This patch adds a BUG() when compress_size != 0, compress_type !=
BTRFS_COMPRESS_NONE and compressed_pages == 0.
Signed-off-by: Fabian Frederick
---
fs/btrfs/inode.c
Inspired by scripts/coccinelle/api/err_cast.cocci
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/gpu/drm/i915/intel_drv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 897f17d..d52f267
bh is initialized unconditionally in affs_add_entry()
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/affs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/affs/inode.c b/fs/affs/inode.c
index a022f4a..1734950 100644
insert_inline_extent() checked for compressed_pages to be NULL then
it accessed it under compress_type != BTRFS_COMPRESS_NONE.
This patch adds a BUG() when compress_size != 0, compress_type !=
BTRFS_COMPRESS_NONE and compressed_pages == 0.
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs
bh is initialized unconditionally in affs_remove_link()
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/affs/amigaffs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/affs/amigaffs.c b/fs/affs/amigaffs.c
index 1df7478
See Documentation/CodingStyle.
Signed-off-by: Fabian Frederick f...@skynet.be
---
drivers/cpufreq/pxa2xx-cpufreq.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
index e24269a..fcf6e34
bh, od_sup and this_node are unconditionally initialized in
befs_bt_read_super() and befs_btree_find()
Cc: Andrew Morton a...@linux-foundation.org
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/befs/btree.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/befs
if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition. The reason being BUG_ON won't execute the condition when
CONFIG_BUG
is not defined.
Inspired-by: J. Bruce Fields
Suggested-by: Julia Lawall
Acked-by: Julia Lawall
Signed-off-by: Fabian Frederick
---
V2: s
slob_alloc_node() is only used in slob.c
This patch removes EXPORT_SYMBOL and statify function
Signed-off-by: Fabian Frederick
---
mm/slob.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/slob.c b/mm/slob.c
index 6d55710..495df8e 100644
--- a/mm/slob.c
+++ b/mm/slob.c
if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition. The reason being BUG_ON won't execute condition when CONFIG_BUG
is not defined.
Inspired-by: J. Bruce Fields
Suggested-by: Julia Lawall
Signed-off-by: Fabian Frederick
---
scripts/coccinelle/misc/bugon.cocci
slob_alloc_node() is only used in slob.c
This patch removes EXPORT_SYMBOL and statify function
Signed-off-by: Fabian Frederick f...@skynet.be
---
mm/slob.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/slob.c b/mm/slob.c
index 6d55710..495df8e 100644
--- a/mm/slob.c
julia.law...@lip6.fr
Signed-off-by: Fabian Frederick f...@skynet.be
---
V2: s/condition/the condition/
scripts/coccinelle/misc/bugon.cocci | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccinelle/misc/bugon.cocci
b/scripts/coccinelle/misc/bugon.cocci
index 3b7eec2..27c97f1
if()/BUG conversion to BUG_ON must be avoided when there's side effect
in condition. The reason being BUG_ON won't execute condition when CONFIG_BUG
is not defined.
Inspired-by: J. Bruce Fields bfie...@fieldses.org
Suggested-by: Julia Lawall julia.law...@lip6.fr
Signed-off-by: Fabian Frederick f
Only callsite udf_get_filename() now returns
error code as well.
Suggested-by: Jan Kara
Signed-off-by: Fabian Frederick
---
fs/udf/unicode.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c
index 9008a36..488a838 100644
--- a/fs
udf_CS0toUTF8() now returns -EINVAL on error.
udf_load_pvoldesc() and udf_get_filename() do the same.
Suggested-by: Jan Kara
Signed-off-by: Fabian Frederick
---
fs/udf/super.c | 23 ++-
fs/udf/unicode.c | 9 +
2 files changed, 19 insertions(+), 13 deletions
() and udf_readdir() call udf_get_filename with UDF_NAME_LEN
udf_pc_to_char() with PAGE_SIZE
Suggested-by: Jan Kara
Signed-off-by: Fabian Frederick
---
V2: Return -EIO if slen = 0 in udf_get_filename()
(suggested by Jan Kara)
fs/udf/unicode.c | 14 +-
1 file changed, 5 insertions(+), 9
.
Fabian Frederick (9):
udf: udf_get_filename(): return -ENOMEM when allocation fails
udf: remove unneccessary test in udf_build_ustr_exact()
udf: unicode: update function name in comments
udf: improve error management in udf_CS0toUTF8()
udf: improve error management in udf_CS0toNLS
udf_get_filename() and its callsites considered 0 as an error
without propagating an error value.
udf_translate_to_linux() now returns -EINVAL when newIndex is 0.
other functions are updated accordingly.
Signed-off-by: Fabian Frederick
---
fs/udf/dir.c | 2 +-
fs/udf/namei.c | 2 +-
fs
udf_pc_to_char() now returns error accordingly.
udf_readdir() and udf_find_entry() process is done on
positive result.
Signed-off-by: Fabian Frederick
---
fs/udf/dir.c | 2 +-
fs/udf/namei.c | 3 ++-
fs/udf/symlink.c | 3 +++
fs/udf/unicode.c | 12 +++-
4 files changed, 13
-Return udf_get_filename() error from udf_readdir()
-Return -ENOMEM from udf_find_entry() when unable to allocate
fname and udf_get_filename() error
-udf_find_entry() callsites are also updated:
udf_lookup(), udf_rmdir(), udf_unlink() and udf_rename()
Suggested-by: Jan Kara
Signed-off-by: Fabian
Signed-off-by: Fabian Frederick
---
fs/udf/unicode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c
index e2c079a..41c3bef 100644
--- a/fs/udf/unicode.c
+++ b/fs/udf/unicode.c
@@ -77,7 +77,7 @@ static void udf_build_ustr_exact(struct
UDF volume is only mounted with UDF_FLAG_UTF8
or UDF_FLAG_NLS_MAP (see fill udf_fill_super().
BUG() if we have something different in udf_get_filename()
Suggested-by: Jan Kara
Signed-off-by: Fabian Frederick
---
fs/udf/unicode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Function return changed lately.
Suggested-by: Jan Kara
Signed-off-by: Fabian Frederick
---
fs/udf/namei.c | 12
1 file changed, 12 insertions(+)
diff --git a/fs/udf/namei.c b/fs/udf/namei.c
index 891c067..1f8e4d0 100644
--- a/fs/udf/namei.c
+++ b/fs/udf/namei.c
@@ -138,6 +138,18
UDF volume is only mounted with UDF_FLAG_UTF8
or UDF_FLAG_NLS_MAP (see fill udf_fill_super().
BUG() if we have something different in udf_get_filename()
Suggested-by: Jan Kara j...@suse.cz
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/udf/unicode.c | 2 +-
1 file changed, 1 insertion
Function return changed lately.
Suggested-by: Jan Kara j...@suse.cz
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/udf/namei.c | 12
1 file changed, 12 insertions(+)
diff --git a/fs/udf/namei.c b/fs/udf/namei.c
index 891c067..1f8e4d0 100644
--- a/fs/udf/namei.c
+++ b/fs/udf
-off-by: Fabian Frederick f...@skynet.be
---
V2:
-Don't set error in udf_readdir()
-Improve code flow
-Merge if(nfi) if (!inode) in udf_rename()
fs/udf/namei.c | 70 ++
1 file changed, 51 insertions(+), 19 deletions
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/udf/unicode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c
index e2c079a..41c3bef 100644
--- a/fs/udf/unicode.c
+++ b/fs/udf/unicode.c
@@ -77,7 +77,7 @@ static void
.
Fabian Frederick (9):
udf: udf_get_filename(): return -ENOMEM when allocation fails
udf: remove unneccessary test in udf_build_ustr_exact()
udf: unicode: update function name in comments
udf: improve error management in udf_CS0toUTF8()
udf: improve error management in udf_CS0toNLS
udf_get_filename() and its callsites considered 0 as an error
without propagating an error value.
udf_translate_to_linux() now returns -EINVAL when newIndex is 0.
other functions are updated accordingly.
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/udf/dir.c | 2 +-
fs/udf/namei.c
() and udf_readdir() call udf_get_filename with UDF_NAME_LEN
udf_pc_to_char() with PAGE_SIZE
Suggested-by: Jan Kara j...@suse.cz
Signed-off-by: Fabian Frederick f...@skynet.be
---
V2: Return -EIO if slen = 0 in udf_get_filename()
(suggested by Jan Kara)
fs/udf/unicode.c | 14 +-
1 file
udf_pc_to_char() now returns error accordingly.
udf_readdir() and udf_find_entry() process is done on
positive result.
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/udf/dir.c | 2 +-
fs/udf/namei.c | 3 ++-
fs/udf/symlink.c | 3 +++
fs/udf/unicode.c | 12 +++-
4 files
udf_CS0toUTF8() now returns -EINVAL on error.
udf_load_pvoldesc() and udf_get_filename() do the same.
Suggested-by: Jan Kara j...@suse.cz
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/udf/super.c | 23 ++-
fs/udf/unicode.c | 9 +
2 files changed, 19
Only callsite udf_get_filename() now returns
error code as well.
Suggested-by: Jan Kara j...@suse.cz
Signed-off-by: Fabian Frederick f...@skynet.be
---
fs/udf/unicode.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/fs/udf/unicode.c b/fs/udf/unicode.c
index 9008a36
> On 31 March 2015 at 17:17 David Miller wrote:
>
>
> From: YOSHIFUJI Hideaki
> Date: Tue, 31 Mar 2015 12:50:27 +0900
>
> > Hi,
> >
> > Fabian Frederick wrote:
> >> Signed-off-by: Fabian Frederick
> >> ---
> >> net/ip
cow_file_range_inline() was called with 0 instead of actual definition.
btrfs_finish_ordered_io() initialized compress_type with 0 as well.
(Thanks to David Sterba for suggesting this update).
Signed-off-by: Fabian Frederick
---
V2: also replace 0 in btrfs_finish_ordered_io()
fs/btrfs
On 31 March 2015 at 17:17 David Miller da...@davemloft.net wrote:
From: YOSHIFUJI Hideaki hideaki.yoshif...@miraclelinux.com
Date: Tue, 31 Mar 2015 12:50:27 +0900
Hi,
Fabian Frederick wrote:
Signed-off-by: Fabian Frederick f...@skynet.be
---
net/ipv6/addrconf.c
cow_file_range_inline() was called with 0 instead of actual definition.
btrfs_finish_ordered_io() initialized compress_type with 0 as well.
(Thanks to David Sterba for suggesting this update).
Signed-off-by: Fabian Frederick f...@skynet.be
---
V2: also replace 0 in btrfs_finish_ordered_io
> On 31 March 2015 at 21:11 Julia Lawall wrote:
>
>
>
>
> On Tue, 31 Mar 2015, Fabian Frederick wrote:
>
> >
> >
> > > On 30 March 2015 at 23:25 "J. Bruce Fields" wrote:
> > >
> > >
> > > Huh
Currently checkpatch warns when asm/file.h is included and linux/file.h
exists. That conversion can be made when linux/file.h includes asm/file.h
which is not always the case.(See signal.h)
Signed-off-by: Fabian Frederick
---
V3:
Only grep when $root/$checkfile exists (suggested by Joe
> On 27 March 2015 at 08:48 Stephen Rothwell wrote:
>
>
> Hi all,
>
> After merging the char-misc tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
>
> In file included from include/linux/module.h:17:0,
> from drivers/uio/uio_pdrv_genirq.c:21:
>
> On 30 March 2015 at 22:49 Joe Perches wrote:
>
>
> On Mon, 2015-03-30 at 22:36 +0200, Fabian Frederick wrote:
> > Currently checkpatch warns when asm/file.h is included and linux/file.h
> > exists. That conversion can be made when linux/file.h includes asm/file.h
Currently checkpatch warns when asm/file.h is included and linux/file.h
exists. That conversion can be made when linux/file.h includes asm/file.h
which is not always the case.(See signal.h)
Signed-off-by: Fabian Frederick
---
V2:
Apply suggestions by Joe Perches:
-Remove
> On 27 March 2015 at 08:19 Stephen Boyd wrote:
>
>
> On 03/22, Fabian Frederick wrote:
> >
> >
> > > On 18 March 2015 at 15:15 Michael Turquette wrote:
> > >
> > >
> > > Quoting Fabian Frederick (2015-03-16 12:59:06
BUG_ONs"
Thanks for the link, I wasn't aware of that problem. Maybe we should add some
documentation and fix coccinelle detection then ?
Regards,
Fabian
>
> --b.
>
> On Mon, Mar 30, 2015 at 11:13:15PM +0200, Fabian Frederick wrote:
> > Signed-off-by: Fabian Frederick
>
of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)
__initdata updated to __initconst for
static const struct of_device_id ti_clkdm_match_table[]
Signed-off-by: Fabian Frederick
---
V2:
add __initdata -> __initconst in changelog
drivers/clk/
wasn't aware of that problem. Maybe we should add some
documentation and fix coccinelle detection then ?
Regards,
Fabian
--b.
On Mon, Mar 30, 2015 at 11:13:15PM +0200, Fabian Frederick wrote:
Signed-off-by: Fabian Frederick f...@skynet.be
---
net/sunrpc/auth_gss/svcauth_gss.c | 9
of_device_id is always used as const.
(See driver.of_match_table and open firmware functions)
__initdata updated to __initconst for
static const struct of_device_id ti_clkdm_match_table[]
Signed-off-by: Fabian Frederick f...@skynet.be
---
V2:
add __initdata - __initconst in changelog
drivers
Currently checkpatch warns when asm/file.h is included and linux/file.h
exists. That conversion can be made when linux/file.h includes asm/file.h
which is not always the case.(See signal.h)
Signed-off-by: Fabian Frederick f...@skynet.be
---
V3:
Only grep when $root/$checkfile exists
On 27 March 2015 at 08:19 Stephen Boyd sb...@codeaurora.org wrote:
On 03/22, Fabian Frederick wrote:
On 18 March 2015 at 15:15 Michael Turquette mturque...@linaro.org wrote:
Quoting Fabian Frederick (2015-03-16 12:59:06)
of_device_id is always used as const.
(See
On 30 March 2015 at 22:49 Joe Perches j...@perches.com wrote:
On Mon, 2015-03-30 at 22:36 +0200, Fabian Frederick wrote:
Currently checkpatch warns when asm/file.h is included and linux/file.h
exists. That conversion can be made when linux/file.h includes asm/file.h
which is not always
On 27 March 2015 at 08:48 Stephen Rothwell s...@canb.auug.org.au wrote:
Hi all,
After merging the char-misc tree, today's linux-next build (powerpc
allyesconfig) produced this warning:
In file included from include/linux/module.h:17:0,
from
Currently checkpatch warns when asm/file.h is included and linux/file.h
exists. That conversion can be made when linux/file.h includes asm/file.h
which is not always the case.(See signal.h)
Signed-off-by: Fabian Frederick f...@skynet.be
---
V2:
Apply suggestions by Joe Perches
On 31 March 2015 at 21:11 Julia Lawall julia.law...@lip6.fr wrote:
On Tue, 31 Mar 2015, Fabian Frederick wrote:
On 30 March 2015 at 23:25 J. Bruce Fields bfie...@fieldses.org wrote:
Huh, I thought this wasn't recommended:
http://lkml.kernel.org/r
Signed-off-by: Fabian Frederick
---
net/ipv4/devinet.c | 3 +--
net/ipv4/esp4.c | 3 +--
net/ipv4/icmp.c | 3 +--
net/ipv4/ip_output.c | 4 ++--
net/ipv4/ping.c | 3 +--
net/ipv4/tcp_input.c | 8
net/ipv4/tcp_minisocks.c | 4 ++--
net/ipv4
701 - 800 of 3217 matches
Mail list logo
