Re: [PATCH v2 3/3] mailbox: stm32-ipcc: cast void pointers to unsigned long

2020-11-02 Thread Fabien DESSENNE
gned long variables, which are the same > size as pointers on all platforms. > > Reported-by: kernel test robot > Signed-off-by: Martin Kaiser Reviewed-by: Fabien Dessenne > --- > changes in v2 > - added this patch to fix COMPILE_TEST warnings > > drivers/mailbox/stm

Re: [PATCH 2/2] mailbox: stm32-ipcc: remove duplicate error message

2020-10-26 Thread Fabien DESSENNE
Hi Martin Thank you for the patch On 24/10/2020 3:31 pm, Martin Kaiser wrote: > platform_get_irq_byname already prints an error message if the requested irq > was not found. Don't print another message in the driver. > > Signed-off-by: Martin Kaiser Reviewed-by: Fab

Re: [PATCH] media: bdisp: Fix runtime PM imbalance on error

2020-05-25 Thread Fabien DESSENNE
Hi, Looks good to me. Reviewed-by: Fabien Dessenne BR Fabien On 21/05/2020 12:00 pm, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep th

[PATCH 2/2] mailbox: stm32-ipcc: Update wakeup management

2019-10-16 Thread Fabien Dessenne
The wakeup specific IRQ management is no more needed to wake up the stm32 plaform. A relationship has been established between the EXTI and the RX IRQ, just need to declare the EXTI interrupt instead of the IPCC RX IRQ. Signed-off-by: Alexandre Torgue Signed-off-by: Fabien Dessenne --- drivers

[PATCH 0/2] mailbox: stm32-ipcc: rework wakeup

2019-10-16 Thread Fabien Dessenne
Remove the dedicated wakeup IRQ as wakeup can be handled by the RX IRQ. Fabien Dessenne (2): dt-bindings: mailbox: stm32-ipcc: Updates for wakeup management mailbox: stm32-ipcc: Update wakeup management .../devicetree/bindings/mailbox/stm32-ipcc.txt | 4 +-- drivers/mailbox/stm32

[PATCH 1/2] dt-bindings: mailbox: stm32-ipcc: Updates for wakeup management

2019-10-16 Thread Fabien Dessenne
The wakeup specific IRQ management is no more needed to wake up the stm32 plaform. Signed-off-by: Alexandre Torgue Signed-off-by: Fabien Dessenne --- Documentation/devicetree/bindings/mailbox/stm32-ipcc.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation

RE: [PATCH 0/2] remoteproc: stm32: allow wdg irq to be a wakeup source

2019-10-10 Thread Fabien DESSENNE
Hi I Got Rob's Reviewed-by for the bindings. Any further comments for the driver part? Fabien > -Original Message- > From: Fabien DESSENNE > Sent: lundi 26 août 2019 17:39 > To: Rob Herring ; Mark Rutland ; > Maxime Coquelin ; Alexandre TORGUE > ; Ohad Ben-Cohen ;

[PATCH v2] remoteproc: stm32: fix probe error case

2019-10-07 Thread Fabien Dessenne
If the rproc driver is probed before the mailbox driver and if the rproc Device Tree node has some mailbox properties, the rproc driver probe shall be deferred instead of being probed without mailbox support. Signed-off-by: Fabien Dessenne --- Changes since v1: test IS_ERR() before checking

[PATCH] remoteproc: stm32: fix probe error case

2019-10-04 Thread Fabien Dessenne
If the rproc driver is probed before the mailbox driver and if the rproc Device Tree node has some mailbox properties, the rproc driver probe shall be deferred instead of being probed without mailbox support. Signed-off-by: Fabien Dessenne --- drivers/remoteproc/stm32_rproc.c | 12

[PATCH] irqchip/stm32-exti: Use the hwspin_lock_timeout_in_atomic() API

2019-09-20 Thread Fabien Dessenne
Now that the hwspin_lock_timeout_in_atomic() API is available use it. Signed-off-by: Fabien Dessenne --- drivers/irqchip/irq-stm32-exti.c | 65 +--- 1 file changed, 20 insertions(+), 45 deletions(-) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers

[PATCH 0/2] remoteproc: stm32: allow wdg irq to be a wakeup source

2019-08-26 Thread Fabien Dessenne
The watchdog IRQ which notifies the remote processor crash is used by the remoteproc framework to perform a recovery procedure. Since this IRQ may be fired when the Linux system is suspended, this IRQ may be configured to wake up the system. Fabien Dessenne (2): dt-bindings: remoteproc: stm32

[PATCH 1/2] dt-bindings: remoteproc: stm32: add wakeup-source

2019-08-26 Thread Fabien Dessenne
Add the "wakeup-source" property: if the optional wdg interrupt is defined, then this property may be defined too. Signed-off-by: Fabien Dessenne --- Documentation/devicetree/bindings/remoteproc/stm32-rproc.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/

[PATCH 2/2] remoteproc: stm32: wakeup the system by wdg irq

2019-08-26 Thread Fabien Dessenne
If the device node defines the 'wakeup-source' property, use the WDG exti IRQ as a wakeup source of the system. Signed-off-by: Fabien Dessenne --- drivers/remoteproc/stm32_rproc.c | 47 1 file changed, 47 insertions(+) diff --git a/drivers/remoteproc

[PATCH] remoteproc: stm32: manage the get_irq probe defer case

2019-08-26 Thread Fabien Dessenne
Manage the -EPROBE_DEFER error case for "wdg" IRQ. Signed-off-by: Fabien Dessenne --- drivers/remoteproc/stm32_rproc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index 1c95913..2cf4b29 100644 ---

[PATCH] remoteproc: stm32: clear MCU PDDS at firmware start

2019-08-26 Thread Fabien Dessenne
. Signed-off-by: Fabien Dessenne --- drivers/remoteproc/stm32_rproc.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c index e2da719..1c95913 100644 --- a/drivers/remoteproc/stm32_rproc.c +++ b/drivers/remoteproc

Re: [PATCH] rpmsg: add a description field

2019-08-12 Thread Fabien DESSENNE
Hi Suman, See my remarks below BR Fabien On 09/08/2019 11:40 PM, Suman Anna wrote: > From: Ohad Ben-Cohen > > Add a new description field to the rpmsg bus infrastructure > that can be passed onto the rpmsg client drivers for additional > information. The current rpmsg bus client drivers need

Re: [PATCH] media: stm32-dcmi: fix irq = 0 case

2019-06-03 Thread Fabien DESSENNE
Hi Hans "platform_get_irq() = 0" shall be considered as an error. See these discussions: https://patchwork.kernel.org/patch/10006651/ https://yarchive.net/comp/linux/zero.html BR Fabien On 03/06/2019 1:45 PM, Hans Verkuil wrote: > On 5/31/19 11:18 AM, Fabien Dessenne wrote: >

[PATCH] media: stm32-dcmi: fix irq = 0 case

2019-05-31 Thread Fabien Dessenne
Manage the irq = 0 case, where we shall return an error. Fixes: b5b5a27bee58 ("media: stm32-dcmi: return appropriate error codes during probe") Signed-off-by: Fabien Dessenne --- drivers/media/platform/stm32/stm32-dcmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 4.19 070/276] media: stm32-dcmi: return appropriate error codes during probe

2019-05-31 Thread Fabien DESSENNE
Hi Pavel On 31/05/2019 10:19 AM, Pavel Machek wrote: > Hi! > >> [ Upstream commit b5b5a27bee5884860798ffd0f08e611a3942064b ] >> >> During probe, return the provided errors value instead of -ENODEV. >> This allows the driver to be deferred probed if needed. > This is not correct AFAICT. The

Re: [PATCH] mailbox: stm32_ipcc: add spinlock to fix channels concurrent access

2019-05-23 Thread Fabien DESSENNE
s results in register > corruptions. > > Signed-off-by: Arnaud Pouliquen Reviewed-by: Fabien Dessenne > --- > drivers/mailbox/stm32-ipcc.c | 37 +++-- > 1 file changed, 27 insertions(+), 10 deletions(-) > > diff --git a/drivers/mailbox/stm

[PATCH v4 4/8] ARM: dts: stm32: add m4 remoteproc support on STM32MP157c

2019-05-14 Thread Fabien Dessenne
Declare the M4 remote processor in a sub-node of the mlahb simple bus. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index

[PATCH v4 1/8] dt-bindings: stm32: add bindings for ML-AHB interconnect

2019-05-14 Thread Fabien Dessenne
Document the ML-AHB interconnect for stm32 SoCs. Signed-off-by: Fabien Dessenne --- .../devicetree/bindings/arm/stm32/mlahb.txt| 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/stm32/mlahb.txt diff --git

[PATCH v4 6/8] ARM: dts: stm32: enable m4 coprocessor support on STM32MP157c-ed1

2019-05-14 Thread Fabien Dessenne
Enable m4 coprocessor for STM32MP157c-ed1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot/dts/stm32mp157c-ed1.dts index acfc5cd..e5a6f40 100644

[PATCH v4 0/8] stm32 m4 remoteproc on STM32MP157c

2019-05-14 Thread Fabien Dessenne
es'. - Updated the 'compatible' property. - Remove the 'recovery', 'reset-names' and 'interrupt-names' properties. - Clarified why / when mailboxes are optional. Fabien Dessenne (8): dt-bindings: stm32: add bindings for ML-AHB interconnect dt-bindings: remoteproc: add bindings for stm32 remote p

[PATCH v4 7/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157a-dk1

2019-05-14 Thread Fabien Dessenne
Declare reserved memories shared by the processors for STM32MP157a-dk1 Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157a-dk1.dts | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts

[PATCH v4 5/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157c-ed1

2019-05-14 Thread Fabien Dessenne
Declare reserved memories shared by the processors for STM32MP157c-ed1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot

[PATCH v4 8/8] ARM: dts: stm32: enable m4 coprocessor support on STM32MP157a-dk1

2019-05-14 Thread Fabien Dessenne
Enable m4 coprocessor for STM32MP157a-dk1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157a-dk1.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts index 26ce8de..da64ee2 100644

[PATCH v4 3/8] remoteproc: stm32: add an ST stm32_rproc driver

2019-05-14 Thread Fabien Dessenne
This patch introduces a new remoteproc driver to control Cortex-M4 co-processor of the STM32 family. It provides with the following features: - start and stop - dedicated co-processor memory regions registration - coredump and recovery Signed-off-by: Fabien Dessenne Signed-off-by: Ludovic Barre

[PATCH v4 2/8] dt-bindings: remoteproc: add bindings for stm32 remote processor driver

2019-05-14 Thread Fabien Dessenne
Add the device tree bindings document for the stm32 remoteproc devices. Signed-off-by: Fabien Dessenne --- .../devicetree/bindings/remoteproc/stm32-rproc.txt | 63 ++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/stm32

Re: [PATCH v2 0/6] hwspinlock: allow sharing of hwspinlocks

2019-05-13 Thread Fabien DESSENNE
Hi I Got Rob's Reviewed-by. Any further comments? Fabien On 25/04/2019 11:17 AM, Fabien Dessenne wrote: > The current implementation does not allow two different devices to use > a common hwspinlock. This patch set proposes to have, as an option, some > hwspinlocks shared betwee

Re: [PATCH v2] hwspinlock: ignore disabled device

2019-05-13 Thread Fabien DESSENNE
Hi Gentle reminder Fabien On 08/03/2019 5:53 PM, Fabien Dessenne wrote: > Do not wait for hwspinlock device registration if it is not available > for use. > > Signed-off-by: Fabien Dessenne > --- > V2: use 'goto out' instead of 'return' > > drivers/hwspinlo

Re: [PATCH] hwspinlock: stm32: implement the relax() ops

2019-05-13 Thread Fabien DESSENNE
Hi Any further comments? Fabien On 08/03/2019 1:42 PM, Benjamin Gaignard wrote: > Le jeu. 7 mars 2019 à 16:42, Fabien Dessenne a écrit > : >> Implement this optional ops, called by hwspinlock core while spinning on >> a lock, between two successive invocations of trylock()

Re: [PATCH] HID: rmi: fix devm_add_action_or_reset() parameter

2019-05-03 Thread Fabien DESSENNE
On 03/05/2019 2:19 PM, Jiri Kosina wrote: > On Fri, 12 Apr 2019, Fabien Dessenne wrote: > >> The second parameter of devm_add_action_or_reset() shall be a function, >> not a function address. >> >> Signed-off-by: Fabien Dessenne >> --- >> drivers/h

[PATCH v3 1/8] dt-bindings: stm32: add bindings for ML-AHB interconnect

2019-05-02 Thread Fabien Dessenne
Document the ML-AHB interconnect for stm32 SoCs. Signed-off-by: Fabien Dessenne --- .../devicetree/bindings/arm/stm32/mlahb.txt| 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/stm32/mlahb.txt diff --git

[PATCH v3 7/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157a-dk1

2019-05-02 Thread Fabien Dessenne
Declare reserved memories shared by the processors for STM32MP157a-dk1 Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157a-dk1.dts | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts

[PATCH v3 2/8] dt-bindings: remoteproc: add bindings for stm32 remote processor driver

2019-05-02 Thread Fabien Dessenne
Add the device tree bindings document for the stm32 remoteproc devices. Signed-off-by: Fabien Dessenne --- .../devicetree/bindings/remoteproc/stm32-rproc.txt | 63 ++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/stm32

[PATCH v3 6/8] ARM: dts: stm32: enable m4 coprocessor support on STM32MP157c-ed1

2019-05-02 Thread Fabien Dessenne
Enable m4 coprocessor for STM32MP157c-ed1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot/dts/stm32mp157c-ed1.dts index acfc5cd..e5a6f40 100644

[PATCH v3 5/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157c-ed1

2019-05-02 Thread Fabien Dessenne
Declare reserved memories shared by the processors for STM32MP157c-ed1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot

[PATCH v3 8/8] ARM: dts: stm32: enable m4 coprocessor support on STM32MP157a-dk1

2019-05-02 Thread Fabien Dessenne
Enable m4 coprocessor for STM32MP157a-dk1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157a-dk1.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts index 26ce8de..da64ee2 100644

[PATCH v3 3/8] remoteproc: stm32: add an ST stm32_rproc driver

2019-05-02 Thread Fabien Dessenne
This patch introduces a new remoteproc driver to control Cortex-M4 co-processor of the STM32 family. It provides with the following features: - start and stop - dedicated co-processor memory regions registration - coredump and recovery Signed-off-by: Fabien Dessenne Signed-off-by: Ludovic Barre

[PATCH v3 4/8] ARM: dts: stm32: add m4 remoteproc support on STM32MP157c

2019-05-02 Thread Fabien Dessenne
Declare the M4 remote processor in a sub-node of the mlahb simple bus. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index

[PATCH v3 0/8] stm32 m4 remoteproc on STM32MP157c

2019-05-02 Thread Fabien Dessenne
"auto_boot" in "st,auto-boot" Changes since v1: - Gave details about the memory mapping (in bindings). - Used 'dma-ranges' instead of 'ranges'. - Updated the 'compatible' property. - Remove the 'recovery', 'reset-names' and 'interrupt-names' properties. - Clarified why / when m

Re: [PATCH v2 2/8] dt-bindings: remoteproc: add bindings for stm32 remote processor driver

2019-04-30 Thread Fabien DESSENNE
Hi Rob, On 30/04/2019 2:40 AM, Rob Herring wrote: > On Tue, Apr 16, 2019 at 04:58:13PM +0200, Fabien Dessenne wrote: >> Add the device tree bindings document for the stm32 remoteproc devices. >> >> Signed-off-by: Fabien Dessenne >> --- >> .../devicetree/bi

[PATCH v2 1/6] dt-bindings: hwlock: add support of shared locks

2019-04-25 Thread Fabien Dessenne
Use #hwlock-cells value to define whether the locks can be shared by several users. Signed-off-by: Fabien Dessenne Reviewed-by: Rob Herring --- .../devicetree/bindings/hwlock/hwlock.txt | 27 -- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git

[PATCH] mailbox: stm32-ipcc: check invalid irq

2019-04-24 Thread Fabien Dessenne
-off-by: Fabien Dessenne --- drivers/mailbox/stm32-ipcc.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/mailbox/stm32-ipcc.c b/drivers/mailbox/stm32-ipcc.c index 210fe50..f91dfb1 100644 --- a/drivers/mailbox/stm32-ipcc.c +++ b/drivers/mailbox/stm32-ipcc.c

[PATCH] ASoC: stm32: i2s: return the get_irq error

2019-04-24 Thread Fabien Dessenne
During probe, return the "get_irq" error value instead of -ENOENT. This allows the driver to be deferred probed if needed. Signed-off-by: Fabien Dessenne --- sound/soc/stm/stm32_i2s.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/stm/stm32_i2s.c b

[PATCH] spi: stm32-qspi: manage the get_irq error case

2019-04-24 Thread Fabien Dessenne
During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne --- drivers/spi/spi-stm32-qspi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c index 11a89aa..42f8e3c 100644 --- a/drivers/spi/spi-st

[PATCH] mtd: rawnand: stm32_fmc2: manage the get_irq error case

2019-04-24 Thread Fabien Dessenne
During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne --- drivers/mtd/nand/raw/stm32_fmc2_nand.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/mtd/nand/raw/stm32_fmc2_nand.c b/drivers/mtd/nand/raw/stm32_fmc2_nand.c index 999ca6a..4aab

[PATCH 2/2] iio: adc: stm32-dfsdm: missing error case during probe

2019-04-24 Thread Fabien Dessenne
During probe, check the devm_ioremap_resource() error value. Also return the devm_clk_get() error value instead of -EINVAL. Signed-off-by: Fabien Dessenne --- drivers/iio/adc/stm32-dfsdm-core.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/stm32

[PATCH 0/2] iio: adc: stm32-dfsdm: manage error cases in probe

2019-04-24 Thread Fabien Dessenne
This patchset adds some check of the returned error code in probe. Fabien Dessenne (2): iio: adc: stm32-dfsdm: manage the get_irq error case iio: adc: stm32-dfsdm: missing error case during probe drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++ drivers/iio/adc/stm32-dfsdm-core.c | 8

[PATCH 1/2] iio: adc: stm32-dfsdm: manage the get_irq error case

2019-04-24 Thread Fabien Dessenne
During probe, check the "get_irq" error value. Signed-off-by: Fabien Dessenne --- drivers/iio/adc/stm32-dfsdm-adc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c index 19adc2b..588907c 100644 --- a/d

[PATCH] spi: stm32: return the get_irq error

2019-04-24 Thread Fabien Dessenne
During probe, return the "get_irq" error value instead of -ENOENT. This allows the driver to be defer probed if needed. Signed-off-by: Fabien Dessenne --- drivers/spi/spi-stm32.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-stm32.c b/drive

[PATCH] rtc: stm32: manage the get_irq probe defer case

2019-04-24 Thread Fabien Dessenne
Manage the -EPROBE_DEFER error case for the wake IRQ. Signed-off-by: Fabien Dessenne --- drivers/rtc/rtc-stm32.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index c5908cf..8e6c9b3 100644 --- a/drivers/rtc/rtc

[PATCH] dmaengine: stm32-dma: dmaengine: stm32-dma: use platform_get_irq()

2019-04-24 Thread Fabien Dessenne
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for requesting IRQ's resources, as they can be not ready yet. Using platform_get_irq() instead is preferred for getting IRQ even if it was not retrieved earlier. Signed-off-by: Fabien Dessenne --- drivers/dma/stm32-dma.c | 11

[PATCH] pinctrl: stm32: check irq controller availability at probe

2019-04-24 Thread Fabien Dessenne
It is not guaranteed that the IRQ controller driver is probed before the pin controller driver gets probed. Considering this, check for the irq domain availability during probe and return EPROBE_DEFER if needed. Signed-off-by: Fabien Dessenne --- drivers/pinctrl/stm32/pinctrl-stm32.c | 37

[PATCH] irqchip: stm32: use a platform driver for stm32mp1-exti device

2019-04-17 Thread Fabien Dessenne
. This applies only for the device which is "st,stm32mp1-exti" compatible, the management of the other devices (st,stm32h7-exti / st,stm32-exti) is kept unchanged (use IRQCHIP_DECLARE) Signed-off-by: Fabien Dessenne --- drivers/irqchip/irq-stm32-ex

[PATCH v2 4/8] ARM: dts: stm32: add m4 remoteproc support on STM32MP157c

2019-04-16 Thread Fabien Dessenne
Declare the M4 remote processor in a sub-node of the mlahb simple bus. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index

[PATCH v2 2/8] dt-bindings: remoteproc: add bindings for stm32 remote processor driver

2019-04-16 Thread Fabien Dessenne
Add the device tree bindings document for the stm32 remoteproc devices. Signed-off-by: Fabien Dessenne --- .../devicetree/bindings/remoteproc/stm32-rproc.txt | 64 ++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/remoteproc/stm32

[PATCH v2 0/8] stm32 m4 remoteproc on STM32MP157c

2019-04-16 Thread Fabien Dessenne
of 'ranges'. - Updated the 'compatible' property. - Remove the 'recovery', 'reset-names' and 'interrupt-names' properties. - Clarified why / when mailboxes are optional. Fabien Dessenne (8): dt-bindings: stm32: add bindings for ML-AHB interconnect dt-bindings: remoteproc: add bindings for stm32

[PATCH v2 3/8] remoteproc: stm32: add an ST stm32_rproc driver

2019-04-16 Thread Fabien Dessenne
This patch introduces a new remoteproc driver to control Cortex-M4 co-processor of the STM32 family. It provides with the following features: - start and stop - dedicated co-processor memory regions registration - coredump and recovery Signed-off-by: Fabien Dessenne Signed-off-by: Ludovic Barre

[PATCH v2 1/8] dt-bindings: stm32: add bindings for ML-AHB interconnect

2019-04-16 Thread Fabien Dessenne
Document the ML-AHB interconnect for stm32 SoCs. Signed-off-by: Fabien Dessenne --- .../devicetree/bindings/arm/stm32/mlahb.txt| 37 ++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/stm32/mlahb.txt diff --git

[PATCH v2 8/8] ARM: dts: stm32: enable m4 coprocessor support on STM32MP157a-dk1

2019-04-16 Thread Fabien Dessenne
Enable m4 coprocessor for STM32MP157a-dk1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157a-dk1.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts index 26ce8de..da64ee2 100644

[PATCH v2 5/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157c-ed1

2019-04-16 Thread Fabien Dessenne
Declare reserved memories shared by the processors for STM32MP157c-ed1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot

[PATCH v2 7/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157a-dk1

2019-04-16 Thread Fabien Dessenne
Declare reserved memories shared by the processors for STM32MP157a-dk1 Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157a-dk1.dts | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts

[PATCH v2 6/8] ARM: dts: stm32: enable m4 coprocessor support on STM32MP157c-ed1

2019-04-16 Thread Fabien Dessenne
Enable m4 coprocessor for STM32MP157c-ed1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot/dts/stm32mp157c-ed1.dts index acfc5cd..e5a6f40 100644

[PATCH] HID: rmi: fix devm_add_action_or_reset() parameter

2019-04-12 Thread Fabien Dessenne
The second parameter of devm_add_action_or_reset() shall be a function, not a function address. Signed-off-by: Fabien Dessenne --- drivers/hid/hid-rmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c index 9e33165..8748d4d

Re: [PATCH 2/2] tty: add rpmsg driver

2019-04-05 Thread Fabien DESSENNE
Hi Johan, On 03/04/2019 10:44 AM, Johan Hovold wrote: > On Thu, Mar 21, 2019 at 04:47:19PM +0100, Fabien Dessenne wrote: >> This driver exposes a standard tty interface on top of the rpmsg >> framework through the "rpmsg-tty-channel" rpmsg service. >> >>

Re: [PATCH 1/8] dt-bindings: stm32: add bindings for ML-AHB interconnect

2019-03-29 Thread Fabien DESSENNE
, please let me know if you think about something better. See also below my answer to your specific remarks BR On 28/03/2019 12:07 AM, Rob Herring wrote: > On Tue, Mar 05, 2019 at 03:24:02PM +0100, Fabien Dessenne wrote: >> Document the ML-AHB interconnect for stm32 SoCs. >>

Re: [PATCH] tty: fix NULL pointer issue when tty_port ops is not set

2019-03-22 Thread Fabien DESSENNE
Mar 21, 2019 at 04:43:26PM +0100, Fabien Dessenne wrote: >> Unlike 'client_ops' which is initialized to 'default_client_ops', the >> port operations 'ops' may be left to NULL. >> Check the 'ops' value before checking the 'ops->x' value. >> >> Signed-off-by: Fabi

[PATCH 1/2] rpmsg: core: add possibility to get message payload length

2019-03-21 Thread Fabien Dessenne
Return the rpmsg buffer payload size for sending message, so rpmsg users can split a long message in several sub rpmsg buffers. Signed-off-by: Arnaud Pouliquen Signed-off-by: Fabien Dessenne --- drivers/rpmsg/rpmsg_core.c | 20 drivers/rpmsg/rpmsg_internal.h | 2

[PATCH 0/2] TTY: add rpmsg tty driver

2019-03-21 Thread Fabien Dessenne
driver itself. Fabien Dessenne (2): rpmsg: core: add possibility to get message payload length tty: add rpmsg driver drivers/rpmsg/rpmsg_core.c | 20 +++ drivers/rpmsg/rpmsg_internal.h | 2 + drivers/rpmsg/virtio_rpmsg_bus.c | 11 ++ drivers/tty/Kconfig | 9 ++ drivers

[PATCH 2/2] tty: add rpmsg driver

2019-03-21 Thread Fabien Dessenne
This driver exposes a standard tty interface on top of the rpmsg framework through the "rpmsg-tty-channel" rpmsg service. This driver supports multi-instances, offering a /dev/ttyRPMSGx entry per rpmsg endpoint. Signed-off-by: Arnaud Pouliquen Signed-off-by: Fabien Dessenne --- d

[PATCH] tty: fix NULL pointer issue when tty_port ops is not set

2019-03-21 Thread Fabien Dessenne
Unlike 'client_ops' which is initialized to 'default_client_ops', the port operations 'ops' may be left to NULL. Check the 'ops' value before checking the 'ops->x' value. Signed-off-by: Fabien Dessenne --- drivers/tty/tty_port.c | 10 +- 1 file changed, 5 insertions(+), 5 deleti

[PATCH 0/6] hwspinlock: allow sharing of hwspinlocks

2019-03-13 Thread Fabien Dessenne
ramework supports only one value : 1 (see implementation of of_hwspin_lock_simple_xlate()) Hence, it shall not be a problem to restrict this value to 1 or 2 since it won't break any driver. Fabien Dessenne (6): dt-bindings: hwlock: add support of shared locks hwspinlock: allow sharing of hwspinlocks dt-bindings: hw

[PATCH 2/6] hwspinlock: allow sharing of hwspinlocks

2019-03-13 Thread Fabien Dessenne
an hwlock is requested for an exclusive or a shared usage. If a device registers with #hwlock-cells = 1, then all the hwlocks are for an exclusive usage. Signed-off-by: Fabien Dessenne --- Documentation/hwspinlock.txt | 10 ++-- drivers/hwspinlock/hwspinlock_core.c | 82

[PATCH v2] hwspinlock: ignore disabled device

2019-03-08 Thread Fabien Dessenne
Do not wait for hwspinlock device registration if it is not available for use. Signed-off-by: Fabien Dessenne --- V2: use 'goto out' instead of 'return' drivers/hwspinlock/hwspinlock_core.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers

Re: [PATCH] irqchip: stm32: add a second level init to request hwspinlock

2019-03-08 Thread Fabien DESSENNE
Hi Marc, Thanks for your detailed answer. I will study how to move this driver to a device one. BR Fabien On 08/03/2019 4:30 PM, Marc Zyngier wrote: > On Fri, 08 Mar 2019 14:03:55 +, > Fabien DESSENNE wrote: > > Fabien, > >> Hi Marc, >> >> Thank

Re: [PATCH] irqchip: stm32: add a second level init to request hwspinlock

2019-03-08 Thread Fabien DESSENNE
ons justify its implementation. Waiting for your feedback BR Fabien On 07/03/2019 5:44 PM, Marc Zyngier wrote: > On 07/03/2019 16:23, Fabien Dessenne wrote: >> Requesting hwspinlock, at the first time it is used, is not correct: >> indeed, at that moment we are under raw_spin_lock

[PATCH v3 0/2] irqchip: stm32: fixes for config registers at init

2019-03-07 Thread Fabien Dessenne
Here's a couple of fixes for the stm32 irqchip. The configuration set by the remote processor is overwritten by the irqchip driver when it is intialized, which is wrong. v3: add the "Fixes" tag v2: add the missing "don't clear rising/falling" patch Fabien Dessenne (2): i

[PATCH v3 2/2] irqchip: stm32: don't set rising configuration registers at init

2019-03-07 Thread Fabien Dessenne
The rising configuration status register (rtsr) is not banked. As it is shared with the co-processor, it should not be written at probe time, else the co-processor configuration will be lost. Fixes: f9fc1745501e ("irqchip/stm32: Add host and driver data structures") Signed-off-by: Fabie

[PATCH v3 1/2] irqchip: stm32: don't clear rising/falling config registers at init

2019-03-07 Thread Fabien Dessenne
f-by: Loic Pallardy Signed-off-by: Fabien Dessenne --- drivers/irqchip/irq-stm32-exti.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c index 6edfd4b..dab37fb 100644 --- a/drivers/irqchip/irq-stm32-exti.c +++ b/drivers/i

RE: [PATCH] irqchip: stm32: don't set rising configuration registers at init

2019-03-07 Thread Fabien DESSENNE
> -Original Message- > From: Marc Zyngier > Sent: jeudi 7 mars 2019 18:46 > To: Fabien DESSENNE ; Thomas Gleixner > ; Jason Cooper ; Maxime Coquelin > ; Alexandre TORGUE > ; linux-kernel@vger.kernel.org; linux-stm32@st-md- > mailman.stormreply.com; linux-arm-ke

[PATCH v2 1/2] irqchip: stm32: don't clear rising/falling config registers at init

2019-03-07 Thread Fabien Dessenne
falling and rising configuration and status registers are not banked. As they are shared with M4 co-processor, they should not be cleared at probe time, else M4 co-processor configuration will be lost. Signed-off-by: Loic Pallardy Signed-off-by: Fabien Dessenne --- drivers/irqchip/irq-stm32

[PATCH v2 0/2] irqchip: stm32: fixes for config registers at init

2019-03-07 Thread Fabien Dessenne
Here's a couple of fixes for the stm32 irqchip. The configuration set by the remote processor is overwritten by the irqchip driver when it is intialized, which is wrong. v2: add the missing "don't clear rising/falling" patch Fabien Dessenne (2): irqchip: stm32: don't clear risi

[PATCH v2 2/2] irqchip: stm32: don't set rising configuration registers at init

2019-03-07 Thread Fabien Dessenne
The rising configuration status register (rtsr) is not banked. As it is shared with the co-processor, it should not be written at probe time, else the co-processor configuration will be lost. Signed-off-by: Fabien Dessenne --- drivers/irqchip/irq-stm32-exti.c | 5 - 1 file changed, 5

RE: [PATCH] irqchip: stm32: don't set rising configuration registers at init

2019-03-07 Thread Fabien DESSENNE
Hi > -Original Message- > From: Marc Zyngier > Sent: jeudi 7 mars 2019 17:40 > To: Fabien DESSENNE ; Thomas Gleixner > ; Jason Cooper ; Maxime Coquelin > ; Alexandre TORGUE > ; linux-kernel@vger.kernel.org; linux-stm32@st-md- > mailman.storm

[PATCH] irqchip: stm32: add a second level init to request hwspinlock

2019-03-07 Thread Fabien Dessenne
ti_of_init()) is also not possible (the hwspinlock framework is not ready at that stage of the kernel init). As a consequence, add a second level init (probed with arch_initcall) where we can safely request hwspinlock. Signed-off-by: Fabien Dessenne --- drivers/irqchip/irq-stm32-ex

[PATCH] irqchip: stm32: don't set rising configuration registers at init

2019-03-07 Thread Fabien Dessenne
The rising configuration status register (rtsr) is not banked. As it is shared with the co-processor, it should not be written at probe time, else the co-processor configuration will be lost. Signed-off-by: Fabien Dessenne --- drivers/irqchip/irq-stm32-exti.c | 5 - 1 file changed, 5

[PATCH 2/2] hwspinlock: add the 'in_atomic' API

2019-03-07 Thread Fabien Dessenne
() calls. Signed-off-by: Fabien Dessenne --- Documentation/hwspinlock.txt | 39 +++ drivers/hwspinlock/hwspinlock_core.c | 43 + include/linux/hwspinlock.h | 61 ++-- 3 files changed, 127 insertions(+), 16

[PATCH 0/2] hwspinlock: add the 'in_atomic' API

2019-03-07 Thread Fabien Dessenne
. Fabien Dessenne (2): hwspinlock: document the hwspinlock 'raw' API hwspinlock: add the 'in_atomic' API Documentation/hwspinlock.txt | 81 drivers/hwspinlock/hwspinlock_core.c | 43 +-- include/linux/hwspinlock.h | 61

[PATCH 1/2] hwspinlock: document the hwspinlock 'raw' API

2019-03-07 Thread Fabien Dessenne
Document the hwspin_lock_timeout_raw(), hwspin_trylock_raw() and hwspin_unlock_raw() API. Signed-off-by: Fabien Dessenne --- Documentation/hwspinlock.txt | 42 ++ 1 file changed, 42 insertions(+) diff --git a/Documentation/hwspinlock.txt b/Documentation

[PATCH] hwspinlock: ignore disabled device

2019-03-07 Thread Fabien Dessenne
Do not wait for hwspinlock device registration if it is not available for use. Signed-off-by: Fabien Dessenne --- drivers/hwspinlock/hwspinlock_core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/hwspinlock/hwspinlock_core.c b/drivers/hwspinlock/hwspinlock_core.c index

[PATCH] hwspinlock: stm32: implement the relax() ops

2019-03-07 Thread Fabien Dessenne
Implement this optional ops, called by hwspinlock core while spinning on a lock, between two successive invocations of trylock(). Signed-off-by: Fabien Dessenne --- drivers/hwspinlock/stm32_hwspinlock.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/hwspinlock

[PATCH 0/8] stm32 m4 remoteproc on STM32MP157c

2019-03-05 Thread Fabien Dessenne
STMicrolectronics STM32MP157 MPU are based on a Dual Arm Cortex-A7 core and a Cortex-M4. This patchset adds the support of the stm32_rproc driver allowing to control the M4 remote processor. Fabien Dessenne (8): dt-bindings: stm32: add bindings for ML-AHB interconnect dt-bindings: remoteproc

[PATCH 1/8] dt-bindings: stm32: add bindings for ML-AHB interconnect

2019-03-05 Thread Fabien Dessenne
Document the ML-AHB interconnect for stm32 SoCs. Signed-off-by: Fabien Dessenne --- .../devicetree/bindings/arm/stm32/mlahb.txt| 30 ++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/stm32/mlahb.txt diff --git

[PATCH 6/8] ARM: dts: stm32: enable m4 coprocessor support on STM32MP157c-ed1

2019-03-05 Thread Fabien Dessenne
Enable m4 coprocessor for STM32MP157c-ed1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot/dts/stm32mp157c-ed1.dts index acfc5cd..c0b4cca

[PATCH 4/8] ARM: dts: stm32: add m4 remoteproc support on STM32MP157c

2019-03-05 Thread Fabien Dessenne
Declare the M4 remote processor in a sub-node of the ahb simple bus. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index

[PATCH 5/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157c-ed1

2019-03-05 Thread Fabien Dessenne
Declare reserved memories shared by the processors for STM32MP157c-ed1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot

[PATCH 8/8] ARM: dts: stm32: enable m4 coprocessor support on STM32MP157a-dk1

2019-03-05 Thread Fabien Dessenne
Enable m4 coprocessor for STM32MP157a-dk1 board. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157a-dk1.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts/stm32mp157a-dk1.dts index 26ce8de..818a979

[PATCH 7/8] ARM: dts: stm32: declare copro reserved memories on STM32MP157a-dk1

2019-03-05 Thread Fabien Dessenne
Declare reserved memories shared by the processors for STM32MP157a-dk1 Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32mp157a-dk1.dts | 42 +++ 1 file changed, 42 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157a-dk1.dts b/arch/arm/boot/dts

  1   2   3   >