Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Baolin Wang writes: [...] and you have triggered this with mailine? How? We don't write to GEVNT* registers from PM code and we only allow runtime_suspend with cable dettached. >>> >>> Sorry for late reply since I am busy on other things. I just agreed >>> with the possible

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Baolin Wang writes: >>> On 27 December 2016 at 18:52, Janusz Dziedzic >>> wrote: 2016-12-26 9:01 GMT+01:00 Baolin Wang : > On some platfroms(like x86 platform), when one core is running the

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Baolin Wang writes: >>> On 27 December 2016 at 18:52, Janusz Dziedzic >>> wrote: 2016-12-26 9:01 GMT+01:00 Baolin Wang : > On some platfroms(like x86 platform), when one core is running the > USB gadget > irq thread handler by

RE: [RFC PATCH] usb: dwc3: add support for OTG driver compilation

Hi, Manish Narani <manish.nar...@xilinx.com> writes: > Hi Felipe, > > >> From: Felipe Balbi [mailto:ba...@kernel.org] >> Sent: Wednesday, January 04, 2017 7:01 PM >> Hi, >> >> Manish Narani <manish.nar...@xilinx.com> writes: >> > This p

RE: [RFC PATCH] usb: dwc3: add support for OTG driver compilation

Hi, Manish Narani writes: > Hi Felipe, > > >> From: Felipe Balbi [mailto:ba...@kernel.org] >> Sent: Wednesday, January 04, 2017 7:01 PM >> Hi, >> >> Manish Narani writes: >> > This patch adds support for OTG driver compilation and object fi

Re: [RFC PATCH] usb: dwc3: gadget: add support for OTG in gadget framework

Hi, Manish Narani writes: > This patch adds support for OTG in DWC3 gadget framework. This > also adds support for HNP polling by host while in OTG mode. > > Modifications in couple of functions to make it in sync with > OTG driver while keeping its original

Re: [RFC PATCH] usb: dwc3: gadget: add support for OTG in gadget framework

Hi, Manish Narani writes: > This patch adds support for OTG in DWC3 gadget framework. This > also adds support for HNP polling by host while in OTG mode. > > Modifications in couple of functions to make it in sync with > OTG driver while keeping its original functionality intact. > >

Re: [RFC PATCH] arch: arm64: dts: add USB OTG interrupts support in ZynqMP device tree

Hi, Manish Narani writes: > This patch adds OTG interrupt support in device tree. It will add > an extra interrupt line number dedicated to OTG events. This will > enable OTG interrupts to serve in DWC3 OTG driver. > > Signed-off-by: Manish Narani

Re: [RFC PATCH] arch: arm64: dts: add USB OTG interrupts support in ZynqMP device tree

Hi, Manish Narani writes: > This patch adds OTG interrupt support in device tree. It will add > an extra interrupt line number dedicated to OTG events. This will > enable OTG interrupts to serve in DWC3 OTG driver. > > Signed-off-by: Manish Narani > --- >

Re: [RFC PATCH] usb: dwc3: add support for OTG driver compilation

Hi, Manish Narani writes: > This patch adds support for OTG driver compilation and object > file creation > > Signed-off-by: Manish Narani > --- > drivers/usb/dwc3/Makefile | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [RFC PATCH] usb: dwc3: add support for OTG driver compilation

Hi, Manish Narani writes: > This patch adds support for OTG driver compilation and object > file creation > > Signed-off-by: Manish Narani > --- > drivers/usb/dwc3/Makefile | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile >

Re: [RFC PATCH] usb: dwc3: host: add support for OTG in DWC3 host driver

Hi, Manish Narani writes: > This patch adds support for OTG host mode initialization in DWC3 > host driver. Before the host initialization sequence begins. The > driver has to make sure the no OTG peripheral mode is enabled. > > Signed-off-by: Manish Narani

Re: [RFC PATCH] usb: dwc3: host: add support for OTG in DWC3 host driver

Hi, Manish Narani writes: > This patch adds support for OTG host mode initialization in DWC3 > host driver. Before the host initialization sequence begins. The > driver has to make sure the no OTG peripheral mode is enabled. > > Signed-off-by: Manish Narani > --- > drivers/usb/dwc3/host.c |

Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

Hi, Greg Kroah-Hartman writes: > On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote: >> Hi, >> >> On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote: >> > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote: >> > > Defer probe if

Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing

Hi, Greg Kroah-Hartman writes: > On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote: >> Hi, >> >> On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote: >> > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote: >> > > Defer probe if PHY is missing. E.g. on

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

Hi, Roger Quadros writes: > Mathias & Felipe, > > On 17/11/16 17:01, Roger Quadros wrote: >> Hi, >> >> Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. >> >> If the attached high-speed device is misbehaving, the USB stack typically >> disables the port

Re: [PATCH 0/3] usb: xhci: Add broken port disable quirk

Hi, Roger Quadros writes: > Mathias & Felipe, > > On 17/11/16 17:01, Roger Quadros wrote: >> Hi, >> >> Some XHCI controllers e.g. dwc3 based have a broken Port disable [1]. >> >> If the attached high-speed device is misbehaving, the USB stack typically >> disables the port using the PED bit

Re: [PATCH] Revert "usb: gadget: f_hid: use alloc_ep_req()"

Hi, David Lechner writes: > This reverts commit ba1582f22231821c57534e87b077d84adbc15dbd. > > I am getting a null pointer dereference when setting up an hid gadget using > configfs. Reverting this commit fixes the crash. > > dmesg: > > [ 382.406622] Unable to handle

Re: [PATCH] Revert "usb: gadget: f_hid: use alloc_ep_req()"

Hi, David Lechner writes: > This reverts commit ba1582f22231821c57534e87b077d84adbc15dbd. > > I am getting a null pointer dereference when setting up an hid gadget using > configfs. Reverting this commit fixes the crash. > > dmesg: > > [ 382.406622] Unable to handle kernel NULL pointer

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Baolin Wang <baolin.w...@linaro.org> writes: > On 28 December 2016 at 20:30, Janusz Dziedzic <janusz.dzied...@gmail.com> > wrote: >> 2016-12-27 13:16 GMT+01:00 Baolin Wang <baolin.w...@linaro.org>: >>> Hi, >>> >>> On 27 Dece

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Baolin Wang writes: > On 28 December 2016 at 20:30, Janusz Dziedzic > wrote: >> 2016-12-27 13:16 GMT+01:00 Baolin Wang : >>> Hi, >>> >>> On 27 December 2016 at 19:11, Felipe Balbi wrote: >>>> >>>> Hi, >>>> &

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Janusz Dziedzic writes: On some platfroms(like x86 platform), when one core is running the USB gadget irq thread handler by dwc3_thread_interrupt(), meanwhile another core also can respond other interrupts from dwc3 controller and modify

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Janusz Dziedzic writes: On some platfroms(like x86 platform), when one core is running the USB gadget irq thread handler by dwc3_thread_interrupt(), meanwhile another core also can respond other interrupts from dwc3 controller and modify the event buffer by

Re: net/gadget: slab-out-of-bounds write in dev_config

p_activity (handle ep0) USB: gadgetfs: fix unbounded memory allocation bug USB: gadgetfs: fix use-after-free bug USB: gadgetfs: fix checks of wTotalLength in config descriptors USB: gadgetfs: remove unnecessary assignment Baolin Wang (1): usb: gadget: f_fs: Fix possibe de

Re: net/gadget: slab-out-of-bounds write in dev_config

adgetfs: fix unbounded memory allocation bug USB: gadgetfs: fix use-after-free bug USB: gadgetfs: fix checks of wTotalLength in config descriptors USB: gadgetfs: remove unnecessary assignment Baolin Wang (1): usb: gadget: f_fs: Fix possibe deadlock Felipe Balbi (4): us

Re: usb/gadget: warning in dummy_free_request

Hi, Andrey Konovalov writes: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > WARNING: CPU: 0 PID: 5257 at drivers/usb/gadget/udc/dummy_hcd.c:672 >

Re: usb/gadget: warning in dummy_free_request

Hi, Andrey Konovalov writes: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > WARNING: CPU: 0 PID: 5257 at drivers/usb/gadget/udc/dummy_hcd.c:672 > dummy_free_request+0x153/0x170 > Kernel panic

Re: [PATCH] usb: mtu3: fix U3 port link issue

Hi, Chunfeng Yun writes: > the issue is introduced when @is_u3_ip is used in mtu3_device_enabe() > before initialized in mtu3_mem_alloc(), so get global IP information > at first before used by following functins. > > Signed-off-by: Chunfeng Yun

Re: [PATCH] usb: mtu3: fix U3 port link issue

Hi, Chunfeng Yun writes: > the issue is introduced when @is_u3_ip is used in mtu3_device_enabe() > before initialized in mtu3_mem_alloc(), so get global IP information > at first before used by following functins. > > Signed-off-by: Chunfeng Yun patch doesn't apply to my testing/fixes. Please

Re: net/gadget: slab-out-of-bounds write in dev_config

Hi, Alan Stern writes: > On Tue, 6 Dec 2016, Andrey Konovalov wrote: > >> Hi! >> >> I've got the following error report while running the syzkaller fuzzer. >> >> ep0_write() doesn't check the length, so a user can cause an >> out-of-bounds with both size and data

Re: net/gadget: slab-out-of-bounds write in dev_config

Hi, Alan Stern writes: > On Tue, 6 Dec 2016, Andrey Konovalov wrote: > >> Hi! >> >> I've got the following error report while running the syzkaller fuzzer. >> >> ep0_write() doesn't check the length, so a user can cause an >> out-of-bounds with both size and data controlled. >> There's a

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Baolin Wang writes: > Hi, > > On 27 December 2016 at 18:52, Janusz Dziedzic > wrote: >> 2016-12-26 9:01 GMT+01:00 Baolin Wang : >>> On some platfroms(like x86 platform), when one core is running the USB >>> gadget

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Baolin Wang writes: > Hi, > > On 27 December 2016 at 18:52, Janusz Dziedzic > wrote: >> 2016-12-26 9:01 GMT+01:00 Baolin Wang : >>> On some platfroms(like x86 platform), when one core is running the USB >>> gadget >>> irq thread handler by dwc3_thread_interrupt(), meanwhile another core

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Janusz Dziedzic writes: > 2016-12-26 9:01 GMT+01:00 Baolin Wang : >> On some platfroms(like x86 platform), when one core is running the USB gadget >> irq thread handler by dwc3_thread_interrupt(), meanwhile another core also >> can >>

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Janusz Dziedzic writes: > 2016-12-26 9:01 GMT+01:00 Baolin Wang : >> On some platfroms(like x86 platform), when one core is running the USB gadget >> irq thread handler by dwc3_thread_interrupt(), meanwhile another core also >> can >> respond other interrupts from dwc3 controller and

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Lu Baolu writes: > On 12/26/2016 04:01 PM, Baolin Wang wrote: >> On some platfroms(like x86 platform), when one core is running the USB gadget >> irq thread handler by dwc3_thread_interrupt(), meanwhile another core also >> can >> respond other interrupts from dwc3

Re: [PATCH] usb: dwc3: gadget: Avoid race between dwc3 interrupt handler and irq thread handler

Hi, Lu Baolu writes: > On 12/26/2016 04:01 PM, Baolin Wang wrote: >> On some platfroms(like x86 platform), when one core is running the USB gadget >> irq thread handler by dwc3_thread_interrupt(), meanwhile another core also >> can >> respond other interrupts from dwc3 controller and modify the

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, John Youn <john.y...@synopsys.com> writes: > On 12/7/2016 7:06 PM, John Youn wrote: >> On 12/7/2016 4:44 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros <rog...@ti.com> writes: >>>>>> Roger Quadros <rog

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, John Youn writes: > On 12/7/2016 7:06 PM, John Youn wrote: >> On 12/7/2016 4:44 AM, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: >>>>>> Roger Quadros writes: >>>>>>> DCFG.DEVSPD =

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> >> Jerry Huang writes: >> >> >> there's no need for that. This patch is in good format. I do have >> >> >> a question, >> >> >> however: how do you know this will work for all users? Burst size >> >> >> is a function of how

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> >> Jerry Huang writes: >> >> >> there's no need for that. This patch is in good format. I do have >> >> >> a question, >> >> >> however: how do you know this will work for all users? Burst size >> >> >> is a function of how wide the interconnect where dwc3 is

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang <jerry.hu...@nxp.com> writes: > Hi, Balbi, >> -Original Message- >> From: Felipe Balbi [mailto:ba...@kernel.org] >> Sent: Friday, December 16, 2016 7:44 PM >> To: Jerry Huang <jerry.hu...@nxp.com>; gre...@linuxfoundation.org >>

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: > Hi, Balbi, >> -Original Message- >> From: Felipe Balbi [mailto:ba...@kernel.org] >> Sent: Friday, December 16, 2016 7:44 PM >> To: Jerry Huang ; gre...@linuxfoundation.org >> Cc: linux-...@vger.kernel.org; linux-kern

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> there's no need for that. This patch is in good format. I do have a question, >> however: how do you know this will work for all users? Burst size is a >> function >> of how wide the interconnect where dwc3 is attached to, is. > So I need to

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> there's no need for that. This patch is in good format. I do have a question, >> however: how do you know this will work for all users? Burst size is a >> function >> of how wide the interconnect where dwc3 is attached to, is. > So I need to generate one new property

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> -Original Message- >> From: Changming Huang [mailto:jerry.hu...@nxp.com] >> Sent: Tuesday, December 13, 2016 5:06 PM >> To: ba...@kernel.org; gre...@linuxfoundation.org >> Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Jerry

RE: [PATCH] USB3/DWC3: Enable undefined length INCR burst type

Hi, Jerry Huang writes: >> -Original Message- >> From: Changming Huang [mailto:jerry.hu...@nxp.com] >> Sent: Tuesday, December 13, 2016 5:06 PM >> To: ba...@kernel.org; gre...@linuxfoundation.org >> Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Jerry Huang >> ; Rajesh

Re: Should xhci_irq() call usb_hc_died()?

Hi, Bjorn Helgaas writes: > Hi Mathias, > > ehci_irq(), ohci_irq(), fotg210_irq(), and oxu210_hcd_irq() contain code > equivalent to this: > > status = ehci_readl(...); > if (status == ~(u32) 0) { > ... > usb_hc_died(hcd); > ... > return IRQ_HANDLED; >

Re: Should xhci_irq() call usb_hc_died()?

Hi, Bjorn Helgaas writes: > Hi Mathias, > > ehci_irq(), ohci_irq(), fotg210_irq(), and oxu210_hcd_irq() contain code > equivalent to this: > > status = ehci_readl(...); > if (status == ~(u32) 0) { > ... > usb_hc_died(hcd); > ... > return IRQ_HANDLED; > } > > xhci_irq() has

Re: usb:xhci: support disable usb2 LPM Remote Wakeup

Hi, "Thang Q. Nguyen" writes: > On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring wrote: >> On Sun, Dec 04, 2016 at 07:42:01PM +0700, Thang Q. Nguyen wrote: >>> From: Thang Nguyen >>> >>> As per USB 2.0 link power management addendum ECN, table

Re: usb:xhci: support disable usb2 LPM Remote Wakeup

Hi, "Thang Q. Nguyen" writes: > On Sat, Dec 10, 2016 at 4:36 AM, Rob Herring wrote: >> On Sun, Dec 04, 2016 at 07:42:01PM +0700, Thang Q. Nguyen wrote: >>> From: Thang Nguyen >>> >>> As per USB 2.0 link power management addendum ECN, table 1-2, page 4, >>> device or host initiated via resume

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, Baolin Wang writes: >> Baolin Wang writes: > On 28 November 2016 at 14:43, Baolin Wang wrote: >> For some mobile devices with strict power management, we also want to >> suspend >> the host when the

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, Baolin Wang writes: >> Baolin Wang writes: > On 28 November 2016 at 14:43, Baolin Wang wrote: >> For some mobile devices with strict power management, we also want to >> suspend >> the host when the slave is detached for power saving. Thus we add the >> host >>

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, Baolin Wang writes: >>> On 28 November 2016 at 14:43, Baolin Wang wrote: For some mobile devices with strict power management, we also want to suspend the host when the slave is detached for power saving. Thus we add the host

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, Baolin Wang writes: >>> On 28 November 2016 at 14:43, Baolin Wang wrote: For some mobile devices with strict power management, we also want to suspend the host when the slave is detached for power saving. Thus we add the host suspend/resume functions to support this

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, Baolin Wang writes: > Hi Felipe, > > On 28 November 2016 at 14:43, Baolin Wang wrote: >> For some mobile devices with strict power management, we also want to suspend >> the host when the slave is detached for power saving. Thus we add the

Re: [PATCH v4 2/2] usb: dwc3: core: Support the dwc3 host suspend/resume

Hi, Baolin Wang writes: > Hi Felipe, > > On 28 November 2016 at 14:43, Baolin Wang wrote: >> For some mobile devices with strict power management, we also want to suspend >> the host when the slave is detached for power saving. Thus we add the host >> suspend/resume functions to support this

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, Roger Quadros writes: >>> Roger Quadros writes: DCFG.DEVSPD == 0x3 is not valid and we need to set DCFG.DEVSPD to 0x1 for full speed mode. >>> >>> seems like it has been made invalid somewhere between 1.73a and >>> 2.60a. Can you figure it out from

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, Roger Quadros writes: >>> Roger Quadros writes: DCFG.DEVSPD == 0x3 is not valid and we need to set DCFG.DEVSPD to 0x1 for full speed mode. >>> >>> seems like it has been made invalid somewhere between 1.73a and >>> 2.60a. Can you figure it out from Documentation why and when it

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

Hi, Chanwoo Choi <cw00.c...@samsung.com> writes: > Hi Felipe, > > On 2016년 11월 30일 19:36, Felipe Balbi wrote: >> >> Hi, >> >> Chanwoo Choi <cw00.c...@samsung.com> writes: >>> This patch uses the resource-managed extcon API for >>

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

Hi, Chanwoo Choi writes: > Hi Felipe, > > On 2016년 11월 30일 19:36, Felipe Balbi wrote: >> >> Hi, >> >> Chanwoo Choi writes: >>> This patch uses the resource-managed extcon API for >>> extcon_register_notifier() >

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

Hi, John Youn <john.y...@synopsys.com> writes: > On 11/30/2016 4:47 AM, Felipe Balbi wrote: >> >> Hi, >> >> Raviteja Garimella <raviteja.garime...@broadcom.com> writes: >>> Hi Balbi, >>> >>> On Wed, Nov 30, 20

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

Hi, John Youn writes: > On 11/30/2016 4:47 AM, Felipe Balbi wrote: >> >> Hi, >> >> Raviteja Garimella writes: >>> Hi Balbi, >>> >>> On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: >>>> >>>> Hi, >>>&g

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

Hi, Raviteja Garimella <raviteja.garime...@broadcom.com> writes: > Hi Balbi, > > On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi <ba...@kernel.org> wrote: >> >> Hi, >> >> Raviteja Garimella <raviteja.garime...@broadcom.com> writes: >>

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

Hi, Raviteja Garimella writes: > Hi Balbi, > > On Wed, Nov 30, 2016 at 4:10 PM, Felipe Balbi wrote: >> >> Hi, >> >> Raviteja Garimella writes: >>> This is driver for Synopsys Designware Cores USB Device >>> Controller (UDC) Subsystem w

Re: [PATCH 12/12] usb: renesas_usbhs: Replace the deprecated extcon API

Hi, Chanwoo Choi <cw00.c...@samsung.com> writes: > This patch replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba.

Re: [PATCH 12/12] usb: renesas_usbhs: Replace the deprecated extcon API

Hi, Chanwoo Choi writes: > This patch replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 09/12] usb: phy: omap-otg: Replace the extcon API

i <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 11/12] usb: phy: tahvo: Replace the deprecated extcon API

Hi, Chanwoo Choi <cw00.c...@samsung.com> writes: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_set_state_sync() > > Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba.

Re: [PATCH 09/12] usb: phy: omap-otg: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe

Re: [PATCH 11/12] usb: phy: tahvo: Replace the deprecated extcon API

Hi, Chanwoo Choi writes: > This patch replaces the deprecated extcon API as following: > - extcon_set_cable_state_() -> extcon_set_state_sync() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe Balbi -- balbi signature.asc Description: PGP signature

Re: [PATCH 10/12] usb: phy: qcom-8x16-usb: Replace the extcon API

i <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 10/12] usb: phy: qcom-8x16-usb: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe

Re: [PATCH 08/12] usb: phy: msm: Replace the extcon API

i <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 08/12] usb: phy: msm: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

Hi, Raviteja Garimella writes: > This is driver for Synopsys Designware Cores USB Device > Controller (UDC) Subsystem with the AMBA Advanced High-Performance > Bus (AHB). This driver works with Synopsys UDC20 products. > > Signed-off-by: Raviteja Garimella

Re: [PATCH 2/2] Synopsys USB 2.0 Device Controller (UDC) Driver

Hi, Raviteja Garimella writes: > This is driver for Synopsys Designware Cores USB Device > Controller (UDC) Subsystem with the AMBA Advanced High-Performance > Bus (AHB). This driver works with Synopsys UDC20 products. > > Signed-off-by: Raviteja Garimella use drivers/usb/dwc2 instead of

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

i <cw00.c...@samsung.com> Acked-by: Felipe Balbi <felipe.ba...@linux.intel.com> -- balbi signature.asc Description: PGP signature

Re: [PATCH 06/12] usb: dwc3: omap: Replace the extcon API

Hi, Chanwoo Choi writes: > This patch uses the resource-managed extcon API for extcon_register_notifier() > and replaces the deprecated extcon API as following: > - extcon_get_cable_state_() -> extcon_get_state() > > Signed-off-by: Chanwoo Choi Acked-by: Felipe

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, Roger Quadros writes: > DCFG.DEVSPD == 0x3 is not valid and we need to set > DCFG.DEVSPD to 0x1 for full speed mode. seems like it has been made invalid somewhere between 1.73a and 2.60a. Can you figure it out from Documentation why and when it was made invalid? We might

Re: [PATCH 1/2] usb: dwc3: gadget: Fix full speed mode

Hi, Roger Quadros writes: > DCFG.DEVSPD == 0x3 is not valid and we need to set > DCFG.DEVSPD to 0x1 for full speed mode. seems like it has been made invalid somewhere between 1.73a and 2.60a. Can you figure it out from Documentation why and when it was made invalid? We might need revision

Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

Hi, Stefan Wahren <stefan.wah...@i2se.com> writes: > Hi Felipe, > > Am 22.11.2016 um 13:23 schrieb Felipe Balbi: >> Hi, >> >> Stefan Wahren <stefan.wah...@i2se.com> writes: >>> Since there is no parameter @value replace it with @legacy. >

Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

Hi, Stefan Wahren writes: > Hi Felipe, > > Am 22.11.2016 um 13:23 schrieb Felipe Balbi: >> Hi, >> >> Stefan Wahren writes: >>> Since there is no parameter @value replace it with @legacy. >>> >>> Fixes: 05ee799f202 ("usb: dwc2: Move g

Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

Hi, Stefan Wahren writes: > Since there is no parameter @value replace it with @legacy. > > Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params") > Signed-off-by: Stefan Wahren > --- > drivers/usb/dwc2/params.c |2 +- > 1

Re: [PATCH 5/5] usb: dwc2: fix kernel-doc for dwc2_set_param

Hi, Stefan Wahren writes: > Since there is no parameter @value replace it with @legacy. > > Fixes: 05ee799f202 ("usb: dwc2: Move gadget settings into core_params") > Signed-off-by: Stefan Wahren > --- > drivers/usb/dwc2/params.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 0/5] usb: dwc2: fix parameter handling

Hi, John Youn writes: > On 11/20/2016 1:26 PM, Stefan Wahren wrote: >> This patch series fixes several parameter handling issues >> found on bcm2835 in gadget mode. It's based on Felipe's USB next. >> >> Stefan Wahren (5): >> usb: dwc2: Do not set host parameter in

Re: [PATCH 0/5] usb: dwc2: fix parameter handling

Hi, John Youn writes: > On 11/20/2016 1:26 PM, Stefan Wahren wrote: >> This patch series fixes several parameter handling issues >> found on bcm2835 in gadget mode. It's based on Felipe's USB next. >> >> Stefan Wahren (5): >> usb: dwc2: Do not set host parameter in peripheral mode >> usb:

Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

Hi, Roger Quadros writes: > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index f945380..6553903 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -1656,6 +1656,9 @@ struct xhci_hcd { > #define XHCI_SSIC_PORT_UNUSED(1 << 22) >

Re: [PATCH v2 1/3] usb: xhci: add quirk flag for broken PED bits

Hi, Roger Quadros writes: > diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h > index f945380..6553903 100644 > --- a/drivers/usb/host/xhci.h > +++ b/drivers/usb/host/xhci.h > @@ -1656,6 +1656,9 @@ struct xhci_hcd { > #define XHCI_SSIC_PORT_UNUSED(1 << 22) > #define

Re: [PATCH] usb: dwc3: avoid empty-body warning

empty body in an 'if' statement [-Werror=empty-body] Instead of adding empty braces which would introduce checkpatch.pl warnings, we're just removing the code which doesn't do anything and making sure we return 0 so USBCV tool is happy. NYET-Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-o

Re: [PATCH] usb: dwc3: avoid empty-body warning

dding empty braces which would introduce checkpatch.pl warnings, we're just removing the code which doesn't do anything and making sure we return 0 so USBCV tool is happy. NYET-Signed-off-by: Arnd Bergmann Signed-off-by: Felipe Balbi --- drivers/usb/dwc3/ep0.c | 13 +++-- 1 file changed,

Re: [PATCH] dwc3: make PM functions as __maybe_unused

Hi, Arnd Bergmann writes: > A change to the suspend/resume handling in dwc3-pci introduced a > harmless warning: > > drivers/usb/dwc3/dwc3-pci.c:169:12: error: ‘dwc3_pci_dsm’ defined but not > used [-Werror=unused-function] > > Replacing the #ifdef around the PM functions with

Re: [PATCH] dwc3: make PM functions as __maybe_unused

Hi, Arnd Bergmann writes: > A change to the suspend/resume handling in dwc3-pci introduced a > harmless warning: > > drivers/usb/dwc3/dwc3-pci.c:169:12: error: ‘dwc3_pci_dsm’ defined but not > used [-Werror=unused-function] > > Replacing the #ifdef around the PM functions with __maybe_unused >

Re: [PATCH v4 5/6] usb: dwc3: use bus->sysdev for DMA configuration

ma. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Signed-off-by: Sriram Dash <sriram.d...@nxp.com> > Signed-off-by: Felipe Balbi <ba...@kernel.org> I can't see when I gave you my S-o-B. Don't add stuff like that on your own, that's quite bad ;-) > Tested-by: Baol

Re: [PATCH v4 5/6] usb: dwc3: use bus->sysdev for DMA configuration

gned-off-by: Sriram Dash > Signed-off-by: Felipe Balbi I can't see when I gave you my S-o-B. Don't add stuff like that on your own, that's quite bad ;-) > Tested-by: Baolin Wang unfortunately this doesn't apply to my testing/next. Can you rebase only this one to testing/next? I think there a

Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

r Mark Rutland >>> about this case. >>> >>> Regards, >>> Christian >>> >>> [0] <https://patchwork.kernel.org/patch/8976221/> >>> [1] >>> <http://lxr.free-electrons.com/source/arch/powerpc/boot/dts/canyonlands.dts#L181> >>

Re: [PATCH 1/2] usb: dwc2: add amcc,dwc-otg support

this case. >>> >>> Regards, >>> Christian >>> >>> [0] <https://patchwork.kernel.org/patch/8976221/> >>> [1] >>> <http://lxr.free-electrons.com/source/arch/powerpc/boot/dts/canyonlands.dts#L181> >>> [2] <http://www.

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

Hi, Baolin Wang writes: > When dwc3 controller acts as host role with attaching slow speed device > (like mouse or keypad). Then if we plugged out the slow speed device, > it will timeout to run the deconfiguration endpoint command to drop the > endpoint's resources.

Re: [PATCH] usb: dwc3: core: Disable USB2.0 phy suspend when dwc3 acts as host role

Hi, Baolin Wang writes: > When dwc3 controller acts as host role with attaching slow speed device > (like mouse or keypad). Then if we plugged out the slow speed device, > it will timeout to run the deconfiguration endpoint command to drop the > endpoint's resources. Some xHCI command timeout

RE: [PATCH v3 5/6] usb: dwc3: use bus->sysdev for DMA configuration

Hi, Sriram Dash <sriram.d...@nxp.com> writes: >>From: Felipe Balbi [mailto:felipe.ba...@linux.intel.com] >> >> >>Hi, > > Hello Felipe, > >> >>Sriram Dash <sriram.d...@nxp.com> writes: >>> From: Arnd Bergmann <a...@arndb.d

<    5   6   7   8   9   10   11   12   13   14   >