On Fri, Sep 12, 2014 at 11:51:22AM +0200, Sebastian Andrzej Siewior wrote:
On 09/12/2014 11:40 AM, Frans Klaver wrote:
I'm not sure. I just reproduced this on a boneblack, using your uart_v9
branch.
This problem only pops-up if you use DMA. With disabled DMA you don't
see this, right
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index 90be993..982778f 100644
--- a/drivers/platform/x86/eeepc
The result of set_acpi is left unchecked, but it may return errors. If
one occurs, send the error to the caller.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86
In show_available_cpufv, show_cpufv, and store_cpufv, errors from
get_cpufv are mapped to -ENODEV. To paint a clear picture to callers,
propagate the errors instead.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 16 ++--
1 file changed
-by: Frans Klaver franskla...@gmail.com
---
Changing ENODEV to ENXIO in acpi_setter_handle() probably requires some extra
work to get it working properly. I'd propose to dive into that after we finish
this series, or we drop this patch from the series and move the whole return
value issue
values below
zero.
Check the result of get_acpi() right away. While at it, propagate the
error if we got one.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86
Pull out EEEPC_SENSOR_STORE_FUNC and EEEPC_SENSOR_SHOW_FUNC. These
macros define functions that call store_sys_hwmon() and show_sys_hwmon()
respectively. This helps prevent duplication later on.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 12
attribute, and declare the disp attribute with it. Sysfs makes sure
userspace can only write to disp at all times. This also means we can
back to propagating any errors from get_acpi().
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 8 ++--
1 file changed
the
attribute, the system will at least keep its sanity.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index
Pull out macros EEEPC_ACPI_STORE_FUNC and EEEPC_ACPI_SHOW_FUNC. These
macros define functions that call store_sys_acpi() and show_sys_acpi()
respectively. This helps prevent duplication later on.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 12
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index 702fcbb..9d8dff9 100644
--- a/drivers/platform/x86/eeepc
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 35 +--
1 file changed, 5 insertions(+), 30 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index f35d008..8225b1e
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index 9d8dff9..f35d008 100644
--- a/drivers
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index 982778f..702fcbb 100644
--- a/drivers/platform/x86/eeepc
] https://lkml.org/lkml/2014/9/10/742
For those interested, a proper branch is available at:
https://github.com/fransklaver/linux wip/eeepc_cleanup_v1
Frans Klaver (13):
eeepc-laptop: coding style: fix indentation
eeepc-laptop: coding style: add curly braces around else compound
eeepc
On 11 September 2014 18:04:32 CEST, Sebastian Andrzej Siewior
wrote:
>On 09/11/2014 05:11 PM, Frans Klaver wrote:
>
>> I can still reproduce it on am335x. I can get out of it as soon as
>> something else gets written to the console though.
>>
>> #
On Thu, Sep 11, 2014 at 02:50:50PM +0200, Sebastian Andrzej Siewior wrote:
> On 09/11/2014 02:32 PM, Peter Hurley wrote:
> > On 09/11/2014 07:42 AM, Sebastian Andrzej Siewior wrote:
> >> I also need a watchdog timer for TX since it seems that on omap3 the
> >> DMA engine suddenly forgets to
On Thu, Sep 11, 2014 at 02:50:50PM +0200, Sebastian Andrzej Siewior wrote:
On 09/11/2014 02:32 PM, Peter Hurley wrote:
On 09/11/2014 07:42 AM, Sebastian Andrzej Siewior wrote:
I also need a watchdog timer for TX since it seems that on omap3 the
DMA engine suddenly forgets to continue with
On 11 September 2014 18:04:32 CEST, Sebastian Andrzej Siewior
bige...@linutronix.de wrote:
On 09/11/2014 05:11 PM, Frans Klaver wrote:
I can still reproduce it on am335x. I can get out of it as soon as
something else gets written to the console though.
# echo 3something /dev/kmsg
On Wed, Sep 10, 2014 at 5:33 AM, Darren Hart wrote:
> On Tue, Sep 09, 2014 at 10:50:08AM +0200, Paul Bolle wrote:
>> Hi Darren,
>>
>> On Sat, 2014-09-06 at 23:17 +0200, Rafael J. Wysocki wrote:
>> > On Friday, September 05, 2014 07:17:57 PM Darren Hart wrote:
>> > > On Thu, Sep 04, 2014 at
On Tue, Sep 09, 2014 at 09:41:20PM +0200, Sebastian Andrzej Siewior wrote:
> On 09/08/2014 08:33 PM, Frans Klaver wrote:
> > Thanks. I'll give it a spin on Wednesday.
>
> Could you please pull the upcoming v9 first?
>
> git://git.breakpoint.cc/bigeasy/linux.git uart_v9_
On Tue, Sep 09, 2014 at 09:41:20PM +0200, Sebastian Andrzej Siewior wrote:
On 09/08/2014 08:33 PM, Frans Klaver wrote:
Thanks. I'll give it a spin on Wednesday.
Could you please pull the upcoming v9 first?
git://git.breakpoint.cc/bigeasy/linux.git uart_v9_pre1
This solves a few of my
On Wed, Sep 10, 2014 at 5:33 AM, Darren Hart dvh...@infradead.org wrote:
On Tue, Sep 09, 2014 at 10:50:08AM +0200, Paul Bolle wrote:
Hi Darren,
On Sat, 2014-09-06 at 23:17 +0200, Rafael J. Wysocki wrote:
On Friday, September 05, 2014 07:17:57 PM Darren Hart wrote:
On Thu, Sep 04, 2014 at
. While at it, propagate any errors
produced in store_sys_acpi() and show_sys_acpi(), instead of overriding
them with -EIO.
Signed-off-by: Frans Klaver
---
This patch applies on top of Paul's "eeepc-laptop: simplify parse_arg()".
Tested both patches separately, as well as combined. As fa
On Mon, Sep 08, 2014 at 05:15:01PM +0200, Sebastian Andrzej Siewior wrote:
> * Frans Klaver | 2014-09-08 16:46:18 [+0200]:
>
> >- I seem seem to get stuck in a "serial8250: too much work for irq%d"
> > loop somewhat reliably. We have a rather demanding application w
On Mon, Sep 08, 2014 at 06:33:13PM +0200, Sebastian Andrzej Siewior wrote:
> * Sebastian Andrzej Siewior | 2014-09-08 17:15:01 [+0200]:
>
> >* Frans Klaver | 2014-09-08 16:46:18 [+0200]:
> >
> >>- ncurses based applications (vi, less) don't play nice for me on the
>
Hi,
On Fri, Sep 05, 2014 at 09:02:35PM +0200, Sebastian Andrzej Siewior wrote:
> This is my complete queue fo the omap serial driver based on the 8250 core
> code. I played with it on beagle bone, am335x-evm and dra7xx including DMA.
> The runtime-pm pieces look now bug-compatible with the
Hi,
On Fri, Sep 05, 2014 at 09:02:35PM +0200, Sebastian Andrzej Siewior wrote:
This is my complete queue fo the omap serial driver based on the 8250 core
code. I played with it on beagle bone, am335x-evm and dra7xx including DMA.
The runtime-pm pieces look now bug-compatible with the
On Mon, Sep 08, 2014 at 06:33:13PM +0200, Sebastian Andrzej Siewior wrote:
* Sebastian Andrzej Siewior | 2014-09-08 17:15:01 [+0200]:
* Frans Klaver | 2014-09-08 16:46:18 [+0200]:
- ncurses based applications (vi, less) don't play nice for me on the
console with this series. less doesn't
On Mon, Sep 08, 2014 at 05:15:01PM +0200, Sebastian Andrzej Siewior wrote:
* Frans Klaver | 2014-09-08 16:46:18 [+0200]:
- I seem seem to get stuck in a serial8250: too much work for irq%d
loop somewhat reliably. We have a rather demanding application with
typically somewhere between 600
. While at it, propagate any errors
produced in store_sys_acpi() and show_sys_acpi(), instead of overriding
them with -EIO.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
This patch applies on top of Paul's eeepc-laptop: simplify parse_arg().
Tested both patches separately, as well as combined
On Thu, Sep 4, 2014 at 4:10 PM, Greg Kroah-Hartman
wrote:
> On Thu, Sep 04, 2014 at 08:46:40AM +0200, Frans Klaver wrote:
>> On Thu, Sep 4, 2014 at 3:14 AM, Greg Kroah-Hartman
>> wrote:
>> > On Wed, Sep 03, 2014 at 05:49:47PM -0700, Darren Hart wrote:
>> >>
On Thu, Sep 04, 2014 at 11:22:26AM +0200, Johan Hovold wrote:
> On Thu, Sep 04, 2014 at 11:05:47AM +0200, Frans Klaver wrote:
> >
> > The new version is applied, built and tested with some actual hardware
> > on 3.17-rc3.
>
> Good. Both patches applied now.
Thanks aga
On Thu, Sep 04, 2014 at 10:15:22AM +0200, Johan Hovold wrote:
> On Thu, Sep 04, 2014 at 09:12:05AM +0200, Frans Klaver wrote:
>
> > > static int xsens_mt_probe(struct usb_serial *serial,
> > > const
On Thu, Sep 4, 2014 at 9:08 AM, Paul Bolle wrote:
> On Thu, 2014-09-04 at 00:53 +0200, Frans Klaver wrote:
>> In store_sys_acpi, if count equals zero, or parse_arg()s sscanf call
>> fails, 'value' remains possibly uninitialized. In that case 'value'
>> shouldn
.
Signed-off-by: Frans Klaver
---
drivers/usb/serial/xsens_mt.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index d500ccd..3837d51 100644
--- a/drivers/usb/serial/xsens_mt.c
+++ b/drivers
Johan,
I noticed I submitted an error here. Will resend later today.
On Mon, Sep 1, 2014 at 11:39 AM, Frans Klaver wrote:
> Probe is testing if the current interface provides two bulk endpoints.
> While this achieves the goal of only binding to the correct interface,
> we already kn
On Thu, Sep 4, 2014 at 3:14 AM, Greg Kroah-Hartman
wrote:
> On Wed, Sep 03, 2014 at 05:49:47PM -0700, Darren Hart wrote:
>> On Thu, Sep 04, 2014 at 12:53:25AM +0200, Frans Klaver wrote:
>> > In store_sys_acpi, if count equals zero, or parse_arg()s sscanf call
>> > fail
On Thu, Sep 4, 2014 at 3:14 AM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Wed, Sep 03, 2014 at 05:49:47PM -0700, Darren Hart wrote:
On Thu, Sep 04, 2014 at 12:53:25AM +0200, Frans Klaver wrote:
In store_sys_acpi, if count equals zero, or parse_arg()s sscanf call
fails, 'value
Johan,
I noticed I submitted an error here. Will resend later today.
On Mon, Sep 1, 2014 at 11:39 AM, Frans Klaver frans.kla...@xsens.com wrote:
Probe is testing if the current interface provides two bulk endpoints.
While this achieves the goal of only binding to the correct interface,
we
.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/usb/serial/xsens_mt.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index d500ccd..3837d51 100644
--- a/drivers/usb/serial
On Thu, Sep 4, 2014 at 9:08 AM, Paul Bolle pebo...@tiscali.nl wrote:
On Thu, 2014-09-04 at 00:53 +0200, Frans Klaver wrote:
In store_sys_acpi, if count equals zero, or parse_arg()s sscanf call
fails, 'value' remains possibly uninitialized. In that case 'value'
shouldn't be used to produce
On Thu, Sep 04, 2014 at 10:15:22AM +0200, Johan Hovold wrote:
On Thu, Sep 04, 2014 at 09:12:05AM +0200, Frans Klaver wrote:
static int xsens_mt_probe(struct usb_serial *serial,
const struct usb_device_id *id
On Thu, Sep 04, 2014 at 11:22:26AM +0200, Johan Hovold wrote:
On Thu, Sep 04, 2014 at 11:05:47AM +0200, Frans Klaver wrote:
The new version is applied, built and tested with some actual hardware
on 3.17-rc3.
Good. Both patches applied now.
Thanks again,
Frans
--
To unsubscribe from
On Thu, Sep 4, 2014 at 4:10 PM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Thu, Sep 04, 2014 at 08:46:40AM +0200, Frans Klaver wrote:
On Thu, Sep 4, 2014 at 3:14 AM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Wed, Sep 03, 2014 at 05:49:47PM -0700, Darren Hart wrote
Match the style of the other one-line comments.
Signed-off-by: Frans Klaver
---
include/linux/mod_devicetable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 745def8..c471047 100644
--- a/include/linux
Signed-off-by: Frans Klaver
---
include/linux/mod_devicetable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 44eeef0..745def8 100644
--- a/include/linux/mod_devicetable.h
+++ b/include/linux
.
Signed-off-by: Frans Klaver
---
drivers/platform/x86/eeepc-laptop.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index bd533c2..41f12ba 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b
.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
drivers/platform/x86/eeepc-laptop.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/x86/eeepc-laptop.c
b/drivers/platform/x86/eeepc-laptop.c
index bd533c2..41f12ba 100644
--- a/drivers/platform/x86/eeepc
Match the style of the other one-line comments.
Signed-off-by: Frans Klaver franskla...@gmail.com
---
include/linux/mod_devicetable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 745def8..c471047
Signed-off-by: Frans Klaver franskla...@gmail.com
---
include/linux/mod_devicetable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/mod_devicetable.h b/include/linux/mod_devicetable.h
index 44eeef0..745def8 100644
--- a/include/linux/mod_devicetable.h
+++ b
Neither of these patches should be on stable. The resend has a slightly
better tuned audience.
Sorry for the noise,
Frans
On Mon, Sep 01, 2014 at 10:32:12AM +0200, Frans Klaver wrote:
> Signed-off-by: Frans Klaver
> ---
> drivers/usb/serial/xsens_mt.c | 2 ++
> 1 file changed,
.
Signed-off-by: Frans Klaver
---
drivers/usb/serial/xsens_mt.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index d500ccd..ea67ed9 100644
--- a/drivers/usb/serial/xsens_mt.c
+++ b/drivers
Signed-off-by: Frans Klaver
---
drivers/usb/serial/xsens_mt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index 4841fb5..d500ccd 100644
--- a/drivers/usb/serial/xsens_mt.c
+++ b/drivers/usb/serial/xsens_mt.c
@@ -82,4 +82,6
Signed-off-by: Frans Klaver
---
drivers/usb/serial/xsens_mt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index 4841fb5..d500ccd 100644
--- a/drivers/usb/serial/xsens_mt.c
+++ b/drivers/usb/serial/xsens_mt.c
@@ -82,4 +82,6
.
Signed-off-by: Frans Klaver
---
drivers/usb/serial/xsens_mt.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index d500ccd..ea67ed9 100644
--- a/drivers/usb/serial/xsens_mt.c
+++ b/drivers
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/usb/serial/xsens_mt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index 4841fb5..d500ccd 100644
--- a/drivers/usb/serial/xsens_mt.c
+++ b/drivers/usb/serial
.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/usb/serial/xsens_mt.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index d500ccd..ea67ed9 100644
--- a/drivers/usb/serial
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/usb/serial/xsens_mt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index 4841fb5..d500ccd 100644
--- a/drivers/usb/serial/xsens_mt.c
+++ b/drivers/usb/serial
.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/usb/serial/xsens_mt.c | 23 ---
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/usb/serial/xsens_mt.c b/drivers/usb/serial/xsens_mt.c
index d500ccd..ea67ed9 100644
--- a/drivers/usb/serial
Neither of these patches should be on stable. The resend has a slightly
better tuned audience.
Sorry for the noise,
Frans
On Mon, Sep 01, 2014 at 10:32:12AM +0200, Frans Klaver wrote:
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/usb/serial/xsens_mt.c | 2 ++
1 file changed
doesn't have to buffer as much either.
Signed-off-by: Frans Klaver
---
drivers/tty/serial/omap-serial.c | 30 +++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 14a0167..1671443a 100644
doesn't have to buffer as much either.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/tty/serial/omap-serial.c | 30 +++---
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index
On August 21, 2014 11:48:40 PM CEST, Felipe Balbi wrote:
>Hi,
>
>On Thu, Aug 21, 2014 at 11:41:17PM +0200, Frans Klaver wrote:
>> On Wed, Aug 20, 2014 at 11:06:05AM -0500, Felipe Balbi wrote:
>> > On Wed, Aug 20, 2014 at 08:40:28AM +0200, Frans Klaver wrote:
>> >
On Wed, Aug 20, 2014 at 11:06:05AM -0500, Felipe Balbi wrote:
> On Wed, Aug 20, 2014 at 08:40:28AM +0200, Frans Klaver wrote:
> > On Tue, Aug 19, 2014 at 01:57:02PM -0500, Felipe Balbi wrote:
> > > On Tue, Aug 19, 2014 at 02:14:47PM +0200, Frans Klaver wrote:
> > > &
On Wed, Aug 20, 2014 at 11:06:05AM -0500, Felipe Balbi wrote:
On Wed, Aug 20, 2014 at 08:40:28AM +0200, Frans Klaver wrote:
On Tue, Aug 19, 2014 at 01:57:02PM -0500, Felipe Balbi wrote:
On Tue, Aug 19, 2014 at 02:14:47PM +0200, Frans Klaver wrote:
At 3.6Mbaud, with slightly over 2Mbit/s
On August 21, 2014 11:48:40 PM CEST, Felipe Balbi ba...@ti.com wrote:
Hi,
On Thu, Aug 21, 2014 at 11:41:17PM +0200, Frans Klaver wrote:
On Wed, Aug 20, 2014 at 11:06:05AM -0500, Felipe Balbi wrote:
On Wed, Aug 20, 2014 at 08:40:28AM +0200, Frans Klaver wrote:
On Tue, Aug 19, 2014 at 01:57
On Wed, Aug 20, 2014 at 11:23:21AM +0200, Frans Klaver wrote:
> Hi,
>
> On Fri, Aug 15, 2014 at 07:42:31PM +0200, Sebastian Andrzej Siewior wrote:
> > --- a/drivers/tty/serial/8250/8250_core.c
> > +++ b/drivers/tty/serial/8250/8250_core.c
> > @@ -1899,12 +1984,22 @@
Hi,
On Fri, Aug 15, 2014 at 07:42:31PM +0200, Sebastian Andrzej Siewior wrote:
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -1899,12 +1984,22 @@ static void wait_for_xmitr(struct uart_8250_port *up,
> int bits)
>
> static int
On Tue, Aug 19, 2014 at 01:57:02PM -0500, Felipe Balbi wrote:
> On Tue, Aug 19, 2014 at 02:14:47PM +0200, Frans Klaver wrote:
> > At 3.6Mbaud, with slightly over 2Mbit/s data coming in, we see 1600 uart
> > rx buffer overflows within 30 seconds. Threading the interrupt handli
On Tue, Aug 19, 2014 at 01:57:02PM -0500, Felipe Balbi wrote:
On Tue, Aug 19, 2014 at 02:14:47PM +0200, Frans Klaver wrote:
At 3.6Mbaud, with slightly over 2Mbit/s data coming in, we see 1600 uart
rx buffer overflows within 30 seconds. Threading the interrupt handling
reduces
Hi,
On Fri, Aug 15, 2014 at 07:42:31PM +0200, Sebastian Andrzej Siewior wrote:
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -1899,12 +1984,22 @@ static void wait_for_xmitr(struct uart_8250_port *up,
int bits)
static int
On Wed, Aug 20, 2014 at 11:23:21AM +0200, Frans Klaver wrote:
Hi,
On Fri, Aug 15, 2014 at 07:42:31PM +0200, Sebastian Andrzej Siewior wrote:
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -1899,12 +1984,22 @@ static void wait_for_xmitr(struct
If the chosen baud rate is large enough (e.g. 3.5 megabaud), the
calculated n values in calculate_baud_abs_diff may become 0. This causes
a division by zero when calculating the difference between calculated
and desired baud rates. To prevent this, cap n on 1.
Signed-off-by: Frans Klaver
This makes hardware flow control availability configurable from the
device tree.
Signed-off-by: Frans Klaver
---
Documentation/devicetree/bindings/serial/omap_serial.txt | 1 +
drivers/tty/serial/omap-serial.c | 4
2 files changed, 5 insertions(+)
diff --git
as-hw-flow-control property in of_get_uart_port_info
Frans Klaver (4):
tty: omap-serial: pull out calculation from baud_is_mode16
tty: omap-serial: prevent division by zero
tty: omap-serial: use threaded interrupt handler
tty: omap-serial: support setting of hardware flow cont
doesn't have to buffer as much either.
Signed-off-by: Frans Klaver
---
drivers/tty/serial/omap-serial.c | 31 ---
1 file changed, 24 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 14a0167..57664b9 100644
To determine the correct divisor, we need to know the difference between
the desired baud rate and the actual baud rate. The calculation for this
difference is implemented twice within omap_serial_baud_is_mode16().
Pull out the calculation for easier maintenance.
Signed-off-by: Frans Klaver
To determine the correct divisor, we need to know the difference between
the desired baud rate and the actual baud rate. The calculation for this
difference is implemented twice within omap_serial_baud_is_mode16().
Pull out the calculation for easier maintenance.
Signed-off-by: Frans Klaver
-control property in of_get_uart_port_info
Frans Klaver (4):
tty: omap-serial: pull out calculation from baud_is_mode16
tty: omap-serial: prevent division by zero
tty: omap-serial: use threaded interrupt handler
tty: omap-serial: support setting of hardware flow control in dts
.../devicetree
doesn't have to buffer as much either.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/tty/serial/omap-serial.c | 31 ---
1 file changed, 24 insertions(+), 7 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index
This makes hardware flow control availability configurable from the
device tree.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
Documentation/devicetree/bindings/serial/omap_serial.txt | 1 +
drivers/tty/serial/omap-serial.c | 4
2 files changed, 5 insertions
If the chosen baud rate is large enough (e.g. 3.5 megabaud), the
calculated n values in calculate_baud_abs_diff may become 0. This causes
a division by zero when calculating the difference between calculated
and desired baud rates. To prevent this, cap n on 1.
Signed-off-by: Frans Klaver
On Mon, Aug 18, 2014 at 08:45:08AM -0500, Felipe Balbi wrote:
> Hi,
>
> On Tue, Jul 29, 2014 at 04:52:54PM +0200, Frans Klaver wrote:
> > Hi,
> >
> > Here's a couple of patches that should improve the behavior of the omap
> > serial
> > driver at hig
On Mon, Aug 18, 2014 at 08:45:08AM -0500, Felipe Balbi wrote:
Hi,
On Tue, Jul 29, 2014 at 04:52:54PM +0200, Frans Klaver wrote:
Hi,
Here's a couple of patches that should improve the behavior of the omap
serial
driver at high data rates and baud rates.
I was actually surprised
On Tue, Jul 29, 2014 at 05:02:29PM +0200, Frans Klaver wrote:
> Here's a couple of patches that should improve the behavior of the omap serial
> driver at high data rates and baud rates.
Anyone?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the b
On Tue, Jul 29, 2014 at 05:02:29PM +0200, Frans Klaver wrote:
Here's a couple of patches that should improve the behavior of the omap serial
driver at high data rates and baud rates.
Anyone?
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
Hi,
Here's a couple of patches that should improve the behavior of the omap serial
driver at high data rates and baud rates.
I was actually surprised to see that proper dma support isn't there yet, but
there you go. Anyone got news on that, by the way?
Thanks for reviewing this,
Frans
Frans
doesn't have to buffer as much either.
Signed-off-by: Frans Klaver
---
drivers/tty/serial/omap-serial.c | 37 ++---
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index e454b7c..ff2d931
This makes hardware flow control availability configurable from the
device tree.
Signed-off-by: Frans Klaver
---
Documentation/devicetree/bindings/serial/omap_serial.txt | 1 +
drivers/tty/serial/omap-serial.c | 3 +++
2 files changed, 4 insertions(+)
diff --git
on that, by the way?
Thanks for reviewing this,
Frans
Frans Klaver (3):
tty: omap-serial: prevent division by zero
tty: omap-serial: use threaded interrupt handler
tty: omap-serial: support setting of hardware flow control in dts
.../devicetree/bindings/serial/omap_serial.txt | 1 +
drivers/tty
-by: Frans Klaver
---
drivers/tty/serial/omap-serial.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index d017cec..e454b7c 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial
Sorry, missed some CC's in git send-email.
On Tue, Jul 29, 2014 at 04:52:55PM +0200, Frans Klaver wrote:
> If the chosen baud rate is large enough (e.g. 3.5 megabaud), the
> calculated n13 and n16 values in serial_omap_baud_is_mode16 may become
> 0. This causes a division by zero when ca
Sorry, missed some CC's in git send-email.
On Tue, Jul 29, 2014 at 04:52:55PM +0200, Frans Klaver wrote:
If the chosen baud rate is large enough (e.g. 3.5 megabaud), the
calculated n13 and n16 values in serial_omap_baud_is_mode16 may become
0. This causes a division by zero when calculating
-by: Frans Klaver frans.kla...@xsens.com
---
drivers/tty/serial/omap-serial.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index d017cec..e454b7c 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b
This makes hardware flow control availability configurable from the
device tree.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
Documentation/devicetree/bindings/serial/omap_serial.txt | 1 +
drivers/tty/serial/omap-serial.c | 3 +++
2 files changed, 4 insertions
on that, by the way?
Thanks for reviewing this,
Frans
Frans Klaver (3):
tty: omap-serial: prevent division by zero
tty: omap-serial: use threaded interrupt handler
tty: omap-serial: support setting of hardware flow control in dts
.../devicetree/bindings/serial/omap_serial.txt | 1 +
drivers/tty
doesn't have to buffer as much either.
Signed-off-by: Frans Klaver frans.kla...@xsens.com
---
drivers/tty/serial/omap-serial.c | 37 ++---
1 file changed, 26 insertions(+), 11 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
Hi,
Here's a couple of patches that should improve the behavior of the omap serial
driver at high data rates and baud rates.
I was actually surprised to see that proper dma support isn't there yet, but
there you go. Anyone got news on that, by the way?
Thanks for reviewing this,
Frans
Frans
901 - 999 of 999 matches
Mail list logo
