[PATCH v3] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Gaurav Dhingra
Wrap comment to fix warning "prefer a maximum 75 chars per line" Signed-off-by: Gaurav Dhingra --- Changes in v2: - use correct format for multiline comment Changes in v3: - include commit log --- drivers/staging/greybus/audio_codec.h | 5 - 1 file changed, 4 insert

Re: [PATCH v2] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Gaurav Dhingra
Hi, On Friday 06 April 2018 03:52 PM, Viresh Kumar wrote: On Fri, Apr 6, 2018 at 3:39 PM, Gaurav Dhingra wrote: Why did you remove the commit log? You had the right one in v1. I didn't realize that it would be necessary to add it to this patch set. I thought you guys will do squashi

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Gaurav Dhingra
On Friday 06 April 2018 03:56 PM, Viresh Kumar wrote: On 06-04-18, 15:55, Viresh Kumar wrote: On 06-04-18, 15:47, Gaurav Dhingra wrote: I sent in an updated patchset. Though I forgot to add viresh.ku...@linaro.org to "To" in mail. That's fine, but you still haven'

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Gaurav Dhingra
Hi, Thanks for reviewing the patch. On Friday 06 April 2018 10:52 AM, Viresh Kumar wrote: On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer wrote: On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote: Wrap comment to fix warning "prefer a maximum 75 chars per line" Sig

[PATCH v2] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Gaurav Dhingra
Signed-off-by: Gaurav Dhingra --- Changes in v2: - use correct format for multiline comment --- drivers/staging/greybus/audio_codec.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h index

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-05 Thread Gaurav Dhingra
Hi, Can anyone please review this patchset? Since this is my first patch set, so I felt it was okay to make change even in the comment, though the patch set fixes the warning. Please let me know in anycase your view on the patchset. On Wednesday 04 April 2018 12:02 AM, Gaurav Dhingra wrote

[PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-03 Thread Gaurav Dhingra
Wrap comment to fix warning "prefer a maximum 75 chars per line" Signed-off-by: Gaurav Dhingra --- drivers/staging/greybus/audio_codec.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_cod