[PATCH v4] NFC: trf7970a: Correct register settings for 27MHz clock

In prior commits the selected clock frequency does not propagate correctly to what is written to the TRF7970A_MODULATOR_SYS_CLK_CTRL register. Signed-off-by: Geoff Lansberry <ge...@kuvee.com> --- drivers/nfc/trf7970a.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drive

[PATCH v4] NFC: trf7970a: Correct register settings for 27MHz clock

In prior commits the selected clock frequency does not propagate correctly to what is written to the TRF7970A_MODULATOR_SYS_CLK_CTRL register. Signed-off-by: Geoff Lansberry --- drivers/nfc/trf7970a.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nfc/trf7970a.c b/drivers

[PATCH v3] NFC: trf7970a: Correct register settings for 27MHz clock

In prior commits the selected clock frequency does not propagate correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL register. Signed-off-by: Geoff Lansberry <ge...@kuvee.com> --- drivers/nfc/trf7970a.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drive

[PATCH v3] NFC: trf7970a: Correct register settings for 27MHz clock

In prior commits the selected clock frequency does not propagate correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL register. Signed-off-by: Geoff Lansberry --- drivers/nfc/trf7970a.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nfc/trf7970a.c b/drivers

[PATCH v2] NFC: trf7970a: Correct register settings for 27MHz clock

In prior commits the selected clock frequency does not propagate correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL register. Signed-off-by: Geoff Lansberry <ge...@kuvee.com> --- drivers/nfc/trf7970a.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drive

[PATCH v2] NFC: trf7970a: Correct register settings for 27MHz clock

In prior commits the selected clock frequency does not propagate correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL register. Signed-off-by: Geoff Lansberry --- drivers/nfc/trf7970a.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/nfc/trf7970a.c b/drivers

[PATCH] NFC: trf7970a: Correct register settings for 27MHz clock

In prior commits the selected clock frequency does not propagate correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL register. Also fixes a bug that causes the device tree property check to always pass. Signed-off-by: Geoff Lansberry <ge...@kuvee.com> --- drivers/nfc/trf7

[PATCH] NFC: trf7970a: Correct register settings for 27MHz clock

In prior commits the selected clock frequency does not propagate correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL register. Also fixes a bug that causes the device tree property check to always pass. Signed-off-by: Geoff Lansberry --- drivers/nfc/trf7970a.c | 9 - 1

Re: [PATCH] NFC: trf7970a: fix check of clock frequencies, use && instead of ||

if ((clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) || > - (clk_freq != TRF7970A_13MHZ_CLOCK_FREQUENCY)) { > + if ((clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) && > + (clk_freq != TRF7970A_13MHZ_CLOCK_FREQUENCY)) { > dev_err(trf->dev, > "clock-frequency (%u Hz) unsupported\n", > clk_freq); > -- > 2.11.0 > Nice catch. Acked-by: Geoff Lansberry <ge...@kuvee.com>

Re: [PATCH] NFC: trf7970a: fix check of clock frequencies, use && instead of ||

{ > + if ((clk_freq != TRF7970A_27MHZ_CLOCK_FREQUENCY) && > + (clk_freq != TRF7970A_13MHZ_CLOCK_FREQUENCY)) { > dev_err(trf->dev, > "clock-frequency (%u Hz) unsupported\n", > clk_freq); > -- > 2.11.0 > Nice catch. Acked-by: Geoff Lansberry

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

On Tue, Jan 3, 2017 at 4:21 PM, Mark Greer <mgr...@animalcreek.com> wrote: > On Tue, Jan 03, 2017 at 01:35:18PM -0500, Geoff Lansberry wrote: >> On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer <mgr...@animalcreek.com> wrote: >> > On Tue, Dec 27, 2016 at 09:18:32A

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

On Tue, Jan 3, 2017 at 4:21 PM, Mark Greer wrote: > On Tue, Jan 03, 2017 at 01:35:18PM -0500, Geoff Lansberry wrote: >> On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer wrote: >> > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: > >> >> In the meanti

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer <mgr...@animalcreek.com> wrote: > [Please stop top-posting. Bottom-post only to these lists.] Sorry; gmail keeps baiting me to do it... > > Hi Geoff & happy new year. > > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lan

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer wrote: > [Please stop top-posting. Bottom-post only to these lists.] Sorry; gmail keeps baiting me to do it... > > Hi Geoff & happy new year. > > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: >> Mark - I

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

pening due to cycling through other tag types. It didn't seem to make any difference, but I have not gone back to default. Geoff Geoff Lansberry Engineering Guy Kuvée, Inc 125 Kingston St., 3rd Floor Boston, MA 02111 1-617-290-1118 (m) geoff.lansberry (skype) http://www.kuvee.com On Sat, Dec 24, 201

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

pening due to cycling through other tag types. It didn't seem to make any difference, but I have not gone back to default. Geoff Geoff Lansberry Engineering Guy Kuvée, Inc 125 Kingston St., 3rd Floor Boston, MA 02111 1-617-290-1118 (m) geoff.lansberry (skype) http://www.kuvee.com On Sat, Dec 24, 201

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

me know. If you don't have the email from Jaret, also please let me know and I will forward it to you. Geoff Geoff Lansberry Engineering Guy Kuvée, Inc 125 Kingston St., 3rd Floor Boston, MA 02111 1-617-290-1118 (m) geoff.lansberry (skype) http://www.kuvee.com On Sat, Dec 24, 2016 at 1:01 AM

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

me know. If you don't have the email from Jaret, also please let me know and I will forward it to you. Geoff Geoff Lansberry Engineering Guy Kuvée, Inc 125 Kingston St., 3rd Floor Boston, MA 02111 1-617-290-1118 (m) geoff.lansberry (skype) http://www.kuvee.com On Sat, Dec 24, 2016 at 1:01 AM

[PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

aiting reading (workqueue) before failing on the send. Signed-off-by: Geoff Lansberry <ge...@kuvee.com> --- drivers/nfc/trf7970a.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c index e3c72c6..ba5f9b8 100644 --- a/drivers/nfc/trf7

[PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

failing on the send. Signed-off-by: Geoff Lansberry --- drivers/nfc/trf7970a.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c index e3c72c6..ba5f9b8 100644 --- a/drivers/nfc/trf7970a.c +++ b/drivers/nfc/trf7970a.c @@ -1496,6 +1496,10

[PATCH v3 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

configuration. Signed-off-by: Geoff Lansberry <ge...@kuvee.com> --- .../devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ drivers/nfc/trf7970a.c | 26 +- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindin

[PATCH v3 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

configuration. Signed-off-by: Geoff Lansberry --- .../devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ drivers/nfc/trf7970a.c | 26 +- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt

[PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock

The TRF7970A has configuration options to support hardware designs which use a 27.12MHz clock. This commit adds a device tree option 'clock-frequency' to support configuring the this chip for default 13.56MHz clock or the optional 27.12MHz clock. Signed-off-by: Geoff Lansberry <ge...@kuvee.

[PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock

The TRF7970A has configuration options to support hardware designs which use a 27.12MHz clock. This commit adds a device tree option 'clock-frequency' to support configuring the this chip for default 13.56MHz clock or the optional 27.12MHz clock. Signed-off-by: Geoff Lansberry

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

Thanks Mark. Should I resubmit patches with the requested edits today, or wait a bit for more comments? What is the desired etiquette? > On Dec 20, 2016, at 9:23 PM, Mark Greer <mgr...@animalcreek.com> wrote: > >> On Tue, Dec 20, 2016 at 11:16:31AM -0500, Geoff Lansbe

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

Thanks Mark. Should I resubmit patches with the requested edits today, or wait a bit for more comments? What is the desired etiquette? > On Dec 20, 2016, at 9:23 PM, Mark Greer wrote: > >> On Tue, Dec 20, 2016 at 11:16:31AM -0500, Geoff Lansberry wrote: >> Fro

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

On Tue, Dec 20, 2016 at 1:11 PM, Mark Greer wrote: > Hi Geoff. > > Please put the version in your subjects when submitting anything but the > initial version of a patch (e.g., [PATCH v2 1/3]). > > Which series do you want reviewed? > > Mark > -- Sorry about the double

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

On Tue, Dec 20, 2016 at 1:11 PM, Mark Greer wrote: > Hi Geoff. > > Please put the version in your subjects when submitting anything but the > initial version of a patch (e.g., [PATCH v2 1/3]). > > Which series do you want reviewed? > > Mark > -- Sorry about the double posting, I had forgotten to

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

TRF7970A_ST_WAIT_FOR_RX_DATA || + trf->state == TRF7970A_ST_WAIT_FOR_RX_DATA_CONT) + trf->ignore_timeout = + !cancel_delayed_work(>timeout_work); ret = -EIO; goto out_err; } -

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

trf->state == TRF7970A_ST_WAIT_FOR_RX_DATA_CONT) + trf->ignore_timeout = + !cancel_delayed_work(>timeout_work); ret = -EIO; goto out_err; } -- Signed-off-by: Geoff Lansberry

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

From: Geoff Lansberry <ge...@kuvee.com> The TRF7970A has configuration options to support hardware designs which use a 27.12MHz clock. This commit adds a device tree option 'clock-frequency' to support configuring the this chip for default 13.56MHz clock or the optional 27.12MHz

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

From: Geoff Lansberry The TRF7970A has configuration options to support hardware designs which use a 27.12MHz clock. This commit adds a device tree option 'clock-frequency' to support configuring the this chip for default 13.56MHz clock or the optional 27.12MHz clock. --- .../devicetree

[PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

From: Geoff Lansberry <ge...@kuvee.com> The TRF7970A has configuration options for supporting hardware designs with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, using a fixed regulator binding, for setting the io voltage to match the hardware configuration. If no

[PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

From: Geoff Lansberry The TRF7970A has configuration options for supporting hardware designs with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, using a fixed regulator binding, for setting the io voltage to match the hardware configuration. If no option is supplied

[PATCH 3/3] mod of frequency

property_read_bool(np, "en2-rf-quirk")) -- Signed-off-by: Geoff Lansberry <ge...@kuvee.com>

[PATCH 3/3] mod of frequency

property_read_bool(np, "en2-rf-quirk")) -- Signed-off-by: Geoff Lansberry

[PATCH 2/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

TRF7970A_ST_WAIT_FOR_RX_DATA || + trf->state == TRF7970A_ST_WAIT_FOR_RX_DATA_CONT) + trf->ignore_timeout = + !cancel_delayed_work(>timeout_work); ret = -EIO; goto out_err; } -

[PATCH 2/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

trf->state == TRF7970A_ST_WAIT_FOR_RX_DATA_CONT) + trf->ignore_timeout = + !cancel_delayed_work(>timeout_work); ret = -EIO; goto out_err; } -- Signed-off-by: Geoff Lansberry

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring <r...@kernel.org> wrote: > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: >> From: Geoff Lansberry <ge...@kuvee.com> >> >> --- >> Documentation/devicetree/bindings/net/nfc/trf7970a

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring wrote: > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: >> From: Geoff Lansberry >> >> --- >> Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ >> drivers/nfc/trf7970a.c

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

TRF7970A_ST_WAIT_FOR_RX_DATA || + trf->state == TRF7970A_ST_WAIT_FOR_RX_DATA_CONT) + trf->ignore_timeout = + !cancel_delayed_work(>timeout_work); ret = -EIO; goto out_err; } -

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

trf->state == TRF7970A_ST_WAIT_FOR_RX_DATA_CONT) + trf->ignore_timeout = + !cancel_delayed_work(>timeout_work); ret = -EIO; goto out_err; } -- Signed-off-by: Geoff Lansberry

[PATCH 4/4] mod of frequency

property_read_bool(np, "en2-rf-quirk")) -- Signed-off-by: Geoff Lansberry <ge...@kuvee.com>

[PATCH 4/4] mod of frequency

property_read_bool(np, "en2-rf-quirk")) -- Signed-off-by: Geoff Lansberry

[PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

From: Geoff Lansberry <ge...@kuvee.com> The TRF7970A has configuration options for supporting hardware designs with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, using a fixed regulator binding, for setting the io voltage to match the hardware configuration. If no

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

From: Geoff Lansberry <ge...@kuvee.com> The TRF7970A has configuration options to support hardware designs which use a 27.12MHz clock. This commit adds a device tree option 'clock-frequency' to support configuring the this chip for default 13.56MHz clock or the optional 27.12MHz

[PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

From: Geoff Lansberry The TRF7970A has configuration options for supporting hardware designs with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, using a fixed regulator binding, for setting the io voltage to match the hardware configuration. If no option is supplied

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

From: Geoff Lansberry The TRF7970A has configuration options to support hardware designs which use a 27.12MHz clock. This commit adds a device tree option 'clock-frequency' to support configuring the this chip for default 13.56MHz clock or the optional 27.12MHz clock. --- .../devicetree

[PATCH 1/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

From: Geoff Lansberry <ge...@kuvee.com> The TRF7970A has configuration options for supporting hardware designs with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, using a fixed regulator binding, for setting the io voltage to match the hardware configuration. If no

[PATCH 1/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

From: Geoff Lansberry The TRF7970A has configuration options for supporting hardware designs with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, using a fixed regulator binding, for setting the io voltage to match the hardware configuration. If no option is supplied

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

to hear your thoughts on my concern. Thanks Geoff Geoff Lansberry Engineering Guy Kuvée, Inc 125 Kingston St., 3rd Floor Boston, MA 02111 1-617-290-1118 (m) geoff.lansberry (skype) http://www.kuvee.com On Mon, Dec 19, 2016 at 5:31 PM, Rob Herring <r...@kernel.org> wrote: > On Thu, Dec

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

to hear your thoughts on my concern. Thanks Geoff Geoff Lansberry Engineering Guy Kuvée, Inc 125 Kingston St., 3rd Floor Boston, MA 02111 1-617-290-1118 (m) geoff.lansberry (skype) http://www.kuvee.com On Mon, Dec 19, 2016 at 5:31 PM, Rob Herring wrote: > On Thu, Dec 15, 2016 at 05:30:42PM -0

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

trf->state == TRF7970A_ST_WAIT_FOR_RX_DATA_CONT) + trf->ignore_timeout = + !cancel_delayed_work(>timeout_work); ret = -EIO; goto out_err; } -- Signed-off-by: Geoff Lansberry <ge...@kuvee.com>

[PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

trf->state == TRF7970A_ST_WAIT_FOR_RX_DATA_CONT) + trf->ignore_timeout = + !cancel_delayed_work(>timeout_work); ret = -EIO; goto out_err; } -- Signed-off-by: Geoff Lansberry

[PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

From: Geoff Lansberry <ge...@kuvee.com> --- Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ drivers/nfc/trf7970a.c | 13 - 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/n

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

From: Geoff Lansberry <ge...@kuvee.com> --- .../devicetree/bindings/net/nfc/trf7970a.txt | 3 ++ drivers/nfc/trf7970a.c | 42 -- 2 files changed, 34 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/n

[PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

From: Geoff Lansberry --- Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ drivers/nfc/trf7970a.c | 13 - 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b

[PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

From: Geoff Lansberry --- .../devicetree/bindings/net/nfc/trf7970a.txt | 3 ++ drivers/nfc/trf7970a.c | 42 -- 2 files changed, 34 insertions(+), 11 deletions(-) diff --git a/Documentation/devicetree/bindings/net/nfc/trf7970a.txt b