Re: [PATCH][next] net: spider_net: Use size_add() in call to struct_size()

rd; > > netdev = alloc_etherdev(struct_size(card, darray, > - tx_descriptors + rx_descriptors)); > + size_add(tx_descriptors, > rx_descriptors))); > if (!netdev) > return NULL; > Looks good to me. Thanks for your fix-up. Signed-off-by: Geoff Levand

Re: [PATCH] sound:ppc: fix spelling typo of values

On 3/23/21 1:55 AM, caizhichao wrote: > From: caizhichao > > vaules -> values > > Signed-off-by: caizhichao > --- > sound/ppc/snd_ps3_reg.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Seems fine. Thanks for your contribution. Acked-by: Geoff Levand

Re: [PATCH] dma-mapping: remove unneeded semicolon

Li > --- > arch/powerpc/platforms/ps3/system-bus.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks for your patch, it looks good. Acked-by: Geoff Levand -Geoff

Re: [PATCH] powerpc/ps3: use dma_mapping_error()

On 12/13/20 10:26 AM, Vincent Stehlé wrote: > The DMA address returned by dma_map_single() should be checked with > dma_mapping_error(). Fix the ps3stor_setup() function accordingly. > > Fixes: 80071802cb9c ("[POWERPC] PS3: Storage Driver Core") > Signed-off-by: Vincent S

Re: [PATCH v2 02/24] exec: Simplify unshare_files

aintainer for is very much dead, but there is apparently still some > activity on the Playstation 3 that Geoff Levand maintains. > > Eric correctly points out that the PS3 firmware no longer boots > Linux (OtherOS), but AFAIK there are both users with old firmware > and those that use a firmwa

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

ed with diff + objdump -Dr). Thanks for your patch. I tested this patch applied to v5.8-rc2 on a PS3 and it seems OK. Tested-by: Geoff Levand

Re: [PATCH] Move static keyword at beginning of declaration

_params; > +} saved_params; Seems fine. Acked-by: Geoff Levand

Re: [PATCH] powerpc/ps3: Use struct_size() in kzalloc()

Hi Gustavo, On 1/8/19 1:00 PM, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding the > size of a structure that has a zero-sized array at the end, along with memory > for some number of elements for that array. For example: > > struct foo { >

Re: [PATCH] ps3_gelic_net: Delete an error message for a failed memory allocation in gelic_descr_prepare_rx()

On 01/03/2018 06:40 AM, SF Markus Elfring wrote: > Omit an extra message for a memory allocation failure in this function. I applied this to my ps3-queue branch. As I mentioned to you several times before, please keep the commit subject line to less than 50 characters. Also, in this case the

Re: [PATCH] ps3_gelic_net: Delete an error message for a failed memory allocation in gelic_descr_prepare_rx()

On 01/03/2018 06:40 AM, SF Markus Elfring wrote: > Omit an extra message for a memory allocation failure in this function. I applied this to my ps3-queue branch. As I mentioned to you several times before, please keep the commit subject line to less than 50 characters. Also, in this case the

Re: ps3: Improve a size determination in five functions

On 12/20/2017 01:20 PM, SF Markus Elfring wrote: >> o Your patch fixes no bug nor replaces any depreciated feature. > > How do you think about information from the section “14) Allocating memory” > in the document “coding-style.rst” for the shown source code transformation? In terms of

Re: ps3: Improve a size determination in five functions

On 12/20/2017 01:20 PM, SF Markus Elfring wrote: >> o Your patch fixes no bug nor replaces any depreciated feature. > > How do you think about information from the section “14) Allocating memory” > in the document “coding-style.rst” for the shown source code transformation? In terms of

Re: [PATCH 2/2] ps3: Improve a size determination in five functions

Hi, On 12/16/2017 05:54 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 14:21:04 +0100 > > Replace the specification of data structures by variable references > as the parameter for the operator "sizeof" to make the corresponding size

Re: [PATCH 2/2] ps3: Improve a size determination in five functions

Hi, On 12/16/2017 05:54 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 14:21:04 +0100 > > Replace the specification of data structures by variable references > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer

Re: ps3: Improve a size determination in five functions

On 12/18/2017 12:45 PM, SF Markus Elfring wrote: >> but you are also removing empty lines and changing the coding format. > > * Why do you not like such a change combination? > > * Do you really want to integrate further update steps in this case? I want to keep the coding style consistent

Re: ps3: Improve a size determination in five functions

On 12/18/2017 12:45 PM, SF Markus Elfring wrote: >> but you are also removing empty lines and changing the coding format. > > * Why do you not like such a change combination? > > * Do you really want to integrate further update steps in this case? I want to keep the coding style consistent

Re: [PATCH 0/2] PS3: Adjustments for six function implementations

Hi, On 12/16/2017 05:50 AM, SF Markus Elfring wrote: > Markus Elfring (2): > Delete an error message for a failed memory allocation in two functions > Improve a size determination in five functions As I mentioned before, please keep your commit message subjects to 50 chars or less. -Geoff

Re: [PATCH 0/2] PS3: Adjustments for six function implementations

Hi, On 12/16/2017 05:50 AM, SF Markus Elfring wrote: > Markus Elfring (2): > Delete an error message for a failed memory allocation in two functions > Improve a size determination in five functions As I mentioned before, please keep your commit message subjects to 50 chars or less. -Geoff

Re: [PATCH 2/2] ps3: Improve a size determination in five functions

Hi, On 12/16/2017 05:54 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 14:21:04 +0100 > > Replace the specification of data structures by variable references > as the parameter for the operator "sizeof" to make the corresponding size

Re: [PATCH 2/2] ps3: Improve a size determination in five functions

Hi, On 12/16/2017 05:54 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 14:21:04 +0100 > > Replace the specification of data structures by variable references > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer

Re: [PATCH 1/2] ps3: Delete an error message for a failed memory allocation in two functions

On 12/16/2017 05:51 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 12:32:42 +0100 > > Omit an extra message for a memory allocation failure in these functions. This is OK, I'll add it to my ps3-queue branch. -Geoff

Re: [PATCH 1/2] ps3: Delete an error message for a failed memory allocation in two functions

On 12/16/2017 05:51 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Dec 2017 12:32:42 +0100 > > Omit an extra message for a memory allocation failure in these functions. This is OK, I'll add it to my ps3-queue branch. -Geoff

Re: [PATCH 0/2] PowerPC-PS3: Adjustments for three function implementations

On 10/17/2017 11:54 AM, SF Markus Elfring wrote: > Markus Elfring (2): > Delete an error message for a failed memory allocation in update_flash_db() > Improve a size determination in two functions For consistency, please use 'powerpc/ps3' not 'powerpc-ps3' as the commit log subject prefix.

Re: [PATCH 0/2] PowerPC-PS3: Adjustments for three function implementations

On 10/17/2017 11:54 AM, SF Markus Elfring wrote: > Markus Elfring (2): > Delete an error message for a failed memory allocation in update_flash_db() > Improve a size determination in two functions For consistency, please use 'powerpc/ps3' not 'powerpc-ps3' as the commit log subject prefix.

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 12:04 PM, SF Markus Elfring wrote: >> I think your original patch is OK, > > How does this feedback fit to the initial response “Not Applicable”? > https://patchwork.ozlabs.org/patch/798575/ I submitted your patch and a fix to ps3vram_probe() with the other patches in my queue.

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 12:04 PM, SF Markus Elfring wrote: >> I think your original patch is OK, > > How does this feedback fit to the initial response “Not Applicable”? > https://patchwork.ozlabs.org/patch/798575/ I submitted your patch and a fix to ps3vram_probe() with the other patches in my queue.

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 11:34 AM, SF Markus Elfring wrote: >> I didn't consider one would be triggered by the kzalloc failure. > > Do you reconsider any special system settings for further > software evolution then? Sorry, I don't quite understand your question. I think your original patch is OK, and I

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 11:34 AM, SF Markus Elfring wrote: >> I didn't consider one would be triggered by the kzalloc failure. > > Do you reconsider any special system settings for further > software evolution then? Sorry, I don't quite understand your question. I think your original patch is OK, and I

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 09:27 AM, SF Markus Elfring wrote: >>> Omit an extra message for a memory allocation failure in this function. >>> >>> This issue was detected by using the Coccinelle software. >> >> NACK >> >> When a user asks me for help I would certainly like to get >> 'Could not allocate cache

Re: block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 09:27 AM, SF Markus Elfring wrote: >>> Omit an extra message for a memory allocation failure in this function. >>> >>> This issue was detected by using the Coccinelle software. >> >> NACK >> >> When a user asks me for help I would certainly like to get >> 'Could not allocate cache

Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 03:52 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 7 Aug 2017 12:37:01 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. NACK When a

Re: [PATCH] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init()

On 08/07/2017 03:52 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 7 Aug 2017 12:37:01 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. NACK When a user asks me for help I would

Re: [PATCH 08/16] powerpc: ps3: use dev_groups and not dev_attrs for bus_type

On 06/06/2017 12:22 PM, Greg Kroah-Hartman wrote: > The dev_attrs field has long been "depreciated" and is finally being > removed, so move the driver to use the "correct" dev_groups field > instead for struct bus_type. > arch/powerpc/platforms/ps3/system-bus.c | 10 ++ > 1 file changed,

Re: [PATCH 08/16] powerpc: ps3: use dev_groups and not dev_attrs for bus_type

On 06/06/2017 12:22 PM, Greg Kroah-Hartman wrote: > The dev_attrs field has long been "depreciated" and is finally being > removed, so move the driver to use the "correct" dev_groups field > instead for struct bus_type. > arch/powerpc/platforms/ps3/system-bus.c | 10 ++ > 1 file changed,

Re: [PATCH] net: toshiba: ps3_genic_net: use new api ethtool_{get|set}_link_ksettings

OK. Thanks for your contribution. Tested-by: Geoff Levand <ge...@infradead.org>

Re: [PATCH] net: toshiba: ps3_genic_net: use new api ethtool_{get|set}_link_ksettings

OK. Thanks for your contribution. Tested-by: Geoff Levand

Re: [PATCH 06/35] powerpc: Convert remaining uses of pr_warning to pr_warn

On 02/16/2017 11:11 PM, Joe Perches wrote: > To enable eventual removal of pr_warning > --- > arch/powerpc/platforms/ps3/device-init.c| 14 +++--- > arch/powerpc/platforms/ps3/mm.c | 4 ++-- > arch/powerpc/platforms/ps3/os-area.c| 2 +- PS3 parts look

Re: [PATCH 06/35] powerpc: Convert remaining uses of pr_warning to pr_warn

On 02/16/2017 11:11 PM, Joe Perches wrote: > To enable eventual removal of pr_warning > --- > arch/powerpc/platforms/ps3/device-init.c| 14 +++--- > arch/powerpc/platforms/ps3/mm.c | 4 ++-- > arch/powerpc/platforms/ps3/os-area.c| 2 +- PS3 parts look

Re: [PATCH] powerpc: Use pr_warn instead of pr_warning

| 4 ++-- > arch/powerpc/platforms/ps3/os-area.c| 2 +- PS3 parts look OK. Acked-by: Geoff Levand <ge...@infradead.org>

Re: [PATCH] powerpc: Use pr_warn instead of pr_warning

| 4 ++-- > arch/powerpc/platforms/ps3/os-area.c| 2 +- PS3 parts look OK. Acked-by: Geoff Levand

Re: [PATCH 6/8] arm64: Introduce raw_{d,i}cache_line_size

some special users(e.g kexec, hibernate) would need the line > size on the CPU (rather than the system wide), when the system wide > feature may not be accessible. Provide another helper which will fetch > cache line size on the current CPU. > > Cc: James Morse <james.mo...@a

Re: [PATCH 6/8] arm64: Introduce raw_{d,i}cache_line_size

some special users(e.g kexec, hibernate) would need the line > size on the CPU (rather than the system wide), when the system wide > feature may not be accessible. Provide another helper which will fetch > cache line size on the current CPU. > > Cc: James Morse > Cc: Geoff Levand >

Re: [PATCH 0867/1285] Replace numeric parameter like 0444 with macro

On Tue, 2016-08-02 at 19:53 +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access > permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and

Re: [PATCH 0867/1285] Replace numeric parameter like 0444 with macro

On Tue, 2016-08-02 at 19:53 +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access > permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and

Re: [PATCH 6/8] arm64: Introduce raw_{d,i}cache_line_size

some special users(e.g kexec, hibernate) would need the line > size on the CPU (rather than the system wide), when the system wide > feature may not be accessible. Provide another helper which will fetch > cache line size on the current CPU. > Looks OK for what kexec needs. Ac

Re: [PATCH 6/8] arm64: Introduce raw_{d,i}cache_line_size

some special users(e.g kexec, hibernate) would need the line > size on the CPU (rather than the system wide), when the system wide > feature may not be accessible. Provide another helper which will fetch > cache line size on the current CPU. > Looks OK for what kexec needs. Acked-by: Geoff Levand

Re: [PATCH] powerpc: Kconfig: remove BE-only platforms from LE kernel build

On Mon, 2015-09-07 at 07:58 +0800, Boqun Feng wrote: > arch/powerpc/platforms/ps3/Kconfig | 2 +- Looks OK for PS3. Acked-by: Geoff Levand -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH] powerpc: Kconfig: remove BE-only platforms from LE kernel build

On Mon, 2015-09-07 at 07:58 +0800, Boqun Feng wrote: > arch/powerpc/platforms/ps3/Kconfig | 2 +- Looks OK for PS3. Acked-by: Geoff Levand <ge...@infradead.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

On Tue, 2015-09-01 at 11:21 +0100, Colin King wrote: > On the unlikely event that drv is null, the current code will > perform a null pointer dereference with it when printing a dev_dbg > message. Instead, the BUG_ON check on drv should be performed > before we emit the dev_dbg message. > >

Re: [PATCH] ps3-vuart: BUG_ON on null drv before dereferencing it on dev_dbg

On Tue, 2015-09-01 at 11:21 +0100, Colin King wrote: > On the unlikely event that drv is null, the current code will > perform a null pointer dereference with it when printing a dev_dbg > message. Instead, the BUG_ON check on drv should be performed > before we emit the dev_dbg message. > >

[PATCH] drivers/ps3: Fix ps3-lpm white space

From: Rudhresh Kumar J Fixed a coding style issue. Signed-off-by: Rudhresh Kumar J Signed-off-by: Geoff Levand --- Please apply to trivial. Thanks. -Geoff drivers/ps3/ps3-lpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ps3/ps3-lpm.c b/drivers/ps3/ps3

[PATCH] drivers/ps3: Fix ps3-lpm white space

From: Rudhresh Kumar J rudhresh...@gmail.com Fixed a coding style issue. Signed-off-by: Rudhresh Kumar J rudhresh...@gmail.com Signed-off-by: Geoff Levand ge...@infradead.org --- Please apply to trivial. Thanks. -Geoff drivers/ps3/ps3-lpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH] arm64: remove dead code

Hi, On Fri, 2015-07-17 at 08:50 +0200, Ard Biesheuvel wrote: > > On 16 July 2015 at 19:58, Mark Salter wrote: > >> Commit 68234df4ea79 ("arm64: kill flush_cache_all()") removed > >> soft_reset() from the kernel. This was the only caller of > >> setup_mm_for_reboot(), so remove that also. > > > >

Re: [PATCH] arm64: remove dead code

Hi, On Fri, 2015-07-17 at 08:50 +0200, Ard Biesheuvel wrote: On 16 July 2015 at 19:58, Mark Salter msal...@redhat.com wrote: Commit 68234df4ea79 (arm64: kill flush_cache_all()) removed soft_reset() from the kernel. This was the only caller of setup_mm_for_reboot(), so remove that also.

Re: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug

Hi Marc, On Mon, 2015-07-06 at 15:53 +0100, Marc Zyngier wrote: > So this has now been a whole month since I reviewed this, and I haven't > seen any repost of this series. Any hope to see this within a reasonable > time frame? Or is it considered dead already? I was hoping to do some work on

Re: [PATCH v5 1/2] arm64: kvm: allows kvm cpu hotplug

Hi Marc, On Mon, 2015-07-06 at 15:53 +0100, Marc Zyngier wrote: So this has now been a whole month since I reviewed this, and I haven't seen any repost of this series. Any hope to see this within a reasonable time frame? Or is it considered dead already? I was hoping to do some work on

[PATCH 1/3] block/ps3vram: Fix sparse warnings

Fix sparse warnings like these: drivers/block/ps3vram.c: warning: incorrect type in assignment (different address spaces) drivers/block/ps3vram.c:expected unsigned int [usertype] *ctrl drivers/block/ps3vram.c:got void [noderef] * Cc: Jim Paris Cc: Jens Axboe Signed-off-by: Geoff

[PATCH 0/3] block/ps3vram: Minor updates and fixes

to 1d082300a03a735c006739907e6aea082007663c: MAINTAINERS: Update ps3vram block driver (2015-06-10 10:46:25 -0700) Geert Uytterhoeven (1): block/ps3vram: Remove obsolete reference to MTD Geoff Levand (2): block/ps3vram: Fix sparse warnings

[PATCH 3/3] MAINTAINERS: Update ps3vram block driver

Add myself as co-maintainer of the ps3vram block driver, and add linuxppc-dev as a relevant mailing list. I have been acting as maintainer of this driver for the last several years, and if there is some inquiry regarding it I would like to be notified. Signed-off-by: Geoff Levand

[PATCH 3/3] MAINTAINERS: Update ps3vram block driver

Add myself as co-maintainer of the ps3vram block driver, and add linuxppc-dev as a relevant mailing list. I have been acting as maintainer of this driver for the last several years, and if there is some inquiry regarding it I would like to be notified. Signed-off-by: Geoff Levand ge

[PATCH 1/3] block/ps3vram: Fix sparse warnings

...@kernel.dk Signed-off-by: Geoff Levand ge...@infradead.org --- drivers/block/ps3vram.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/block/ps3vram.c b/drivers/block/ps3vram.c index ef45cfb..a7bf836 100644 --- a/drivers/block/ps3vram.c

[PATCH 0/3] block/ps3vram: Minor updates and fixes

to 1d082300a03a735c006739907e6aea082007663c: MAINTAINERS: Update ps3vram block driver (2015-06-10 10:46:25 -0700) Geert Uytterhoeven (1): block/ps3vram: Remove obsolete reference to MTD Geoff Levand (2): block/ps3vram: Fix sparse warnings

Re: [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel

On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote: > @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr) > setup_mm_for_reboot(); > > cpu_soft_restart(virt_to_phys(cpu_reset), > - is_hyp_mode_available(), addr); > +#ifdef CONFIG_KEXEC > +

Re: [PATCH 1/5] arm64: kdump: reserve memory for crash dump kernel

Hi Takahiro, On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote: > On system kernel, the memory region used by crash dump kernel must be > specified by "crashkernel=X@Y" boot parameter. reserve_crashkernel() > will allocate the region in "System RAM" and reserve it for later use. > > On

Re: [PATCH 1/5] arm64: kdump: reserve memory for crash dump kernel

Hi Takahiro, On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote: > On system kernel, the memory region used by crash dump kernel must be > specified by "crashkernel=X@Y" boot parameter. reserve_crashkernel() > will allocate the region in "System RAM" and reserve it for later use. > > On

Re: [PATCH 1/5] arm64: kdump: reserve memory for crash dump kernel

Hi Takahiro, On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote: On system kernel, the memory region used by crash dump kernel must be specified by crashkernel=X@Y boot parameter. reserve_crashkernel() will allocate the region in System RAM and reserve it for later use. On crash dump

Re: [PATCH 3/5] arm64: kdump: do not go into EL2 before starting a crash dump kernel

On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote: @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr) setup_mm_for_reboot(); cpu_soft_restart(virt_to_phys(cpu_reset), - is_hyp_mode_available(), addr); +#ifdef CONFIG_KEXEC + !in_crash_kexec

Re: [PATCH 1/5] arm64: kdump: reserve memory for crash dump kernel

Hi Takahiro, On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote: On system kernel, the memory region used by crash dump kernel must be specified by crashkernel=X@Y boot parameter. reserve_crashkernel() will allocate the region in System RAM and reserve it for later use. On crash dump

Re: [RFC 2/4] arm64: kexec: fix kvm issue

Hi Marc, On Tue, 2015-03-24 at 08:46 +, Marc Zyngier wrote: > "arm64: KVM: Allow EL2 context to be reset on shutdown" Sure, this sounds good. -Geoff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [RFC 2/4] arm64: kexec: fix kvm issue

Hi Marc, On Tue, 2015-03-24 at 08:46 +, Marc Zyngier wrote: arm64: KVM: Allow EL2 context to be reset on shutdown Sure, this sounds good. -Geoff -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [RFC 1/4] arm64: kvm: add a cpu tear-down function

Hi Takahiro, On Mon, 2015-03-23 at 20:53 +0900, AKASHI Takahiro wrote: > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c > index 3e6859b..428f41c 100644 > --- a/arch/arm/kvm/mmu.c > +++ b/arch/arm/kvm/mmu.c ... > +phys_addr_t kvm_get_stub_vectors(void) > +{ > + return

Re: [RFC 2/4] arm64: kexec: fix kvm issue

On Mon, 2015-03-23 at 20:53 +0900, AKASHI Takahiro wrote: > The current kvm implementation keeps EL2 vector table installed even > when the system is shut down. This prevents kexec from putting the system > with kvm back into EL2 when starting a new kernel. This is a kvm bug fix, so I think the

Re: [RFC 2/4] arm64: kexec: fix kvm issue

On Mon, 2015-03-23 at 20:53 +0900, AKASHI Takahiro wrote: The current kvm implementation keeps EL2 vector table installed even when the system is shut down. This prevents kexec from putting the system with kvm back into EL2 when starting a new kernel. This is a kvm bug fix, so I think the

Re: [RFC 1/4] arm64: kvm: add a cpu tear-down function

Hi Takahiro, On Mon, 2015-03-23 at 20:53 +0900, AKASHI Takahiro wrote: diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c index 3e6859b..428f41c 100644 --- a/arch/arm/kvm/mmu.c +++ b/arch/arm/kvm/mmu.c ... +phys_addr_t kvm_get_stub_vectors(void) +{ + return

Re: [PATCH] ps3: Fix trivial typos in comment and debug message

On Sat, 2015-03-07 at 13:03 +0100, Yannick Guerrini wrote: > Change 'prosessor' to 'processor' > Change 'set_inteval' to 'set_interval' > > Signed-off-by: Yannick Guerrini > --- > drivers/ps3/ps3-lpm.c | 4 ++-- Looks good. Thanks for the fixes. Acked-by: Geoff Levand -- T

Re: [PATCH] ps3: Fix trivial typos in comment and debug message

On Sat, 2015-03-07 at 13:03 +0100, Yannick Guerrini wrote: Change 'prosessor' to 'processor' Change 'set_inteval' to 'set_interval' Signed-off-by: Yannick Guerrini yguerr...@tomshardware.fr --- drivers/ps3/ps3-lpm.c | 4 ++-- Looks good. Thanks for the fixes. Acked-by: Geoff Levand ge

Re: [RFC PATCH 01/17] block: make generic_make_request handle arbitrarily sized bios

Hi, On Mon, 2014-12-22 at 12:48 +0100, Dongsu Park wrote: > From: Kent Overstreet > --- a/drivers/block/ps3vram.c > +++ b/drivers/block/ps3vram.c > @@ -603,6 +603,8 @@ static void ps3vram_make_request(struct request_queue *q, > struct bio *bio) > struct ps3vram_priv *priv =

Re: [RFC PATCH 01/17] block: make generic_make_request handle arbitrarily sized bios

Hi, On Mon, 2014-12-22 at 12:48 +0100, Dongsu Park wrote: From: Kent Overstreet k...@daterainc.com --- a/drivers/block/ps3vram.c +++ b/drivers/block/ps3vram.c @@ -603,6 +603,8 @@ static void ps3vram_make_request(struct request_queue *q, struct bio *bio) struct ps3vram_priv *priv =

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

Hi Michael, On Tue, 2014-12-23 at 11:26 +1100, Michael Ellerman wrote: > On Mon, 2014-12-22 at 09:26 -0800, Geoff Levand wrote: > > ps3_repository_write_highmem_info() is needed by otheros++. What we > > need is a kernel patch to add the highmem info to the repository once

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote: > Remove the function ps3_repository_write_highmem_info() that is not used > anywhere. NAK ps3_repository_write_highmem_info() is needed by otheros++. What we need is a kernel patch to add the highmem info to the repository once it

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

Hi Michael, On Tue, 2014-12-23 at 11:26 +1100, Michael Ellerman wrote: On Mon, 2014-12-22 at 09:26 -0800, Geoff Levand wrote: ps3_repository_write_highmem_info() is needed by otheros++. What we need is a kernel patch to add the highmem info to the repository once it is known. OK so

Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote: Remove the function ps3_repository_write_highmem_info() that is not used anywhere. NAK ps3_repository_write_highmem_info() is needed by otheros++. What we need is a kernel patch to add the highmem info to the repository once it is

[PATCH V3 3/4] kexec: Add bit definitions for kimage entry flags

and the chance that changes to the IND_* flags will not be propagated to assembly files. Signed-off-by: Geoff Levand Acked-by: Vivek Goyal --- include/linux/kexec.h | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/include/linux/kexec.h b/include/linux

[PATCH V3 2/4] kexec: Simplify conditional

for the conditional. There is no functional change to the code. Signed-off-by: Geoff Levand Acked-by: Vivek Goyal --- kernel/kexec.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/kernel/kexec.c b/kernel/kexec.c index 2abf9f6..650fcba 100644 --- a/kernel/kexec.c

[PATCH V3 4/4] kexec: Add IND_FLAGS macro

. Signed-off-by: Geoff Levand Acked-by: Benjamin Herrenschmidt Acked-by: Vivek Goyal --- arch/powerpc/kernel/machine_kexec_64.c | 2 -- include/linux/kexec.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch

[PATCH V3 1/4] kexec: Fix make headers_check

Remove the unneded declaration for a kexec_load() routine. Fixes errors like these when running 'make headers_check': include/uapi/linux/kexec.h: userspace cannot reference function or variable defined in the kernel Signed-off-by: Geoff Levand Acked-by: Paul Bolle Cc: H. Peter Anvin Cc

[PATCH V3 0/4] kexec: minor fixups and enhancements

changes up to 916ef4b8abaa4202ea43731b9cd3f8e0ea95f05b: kexec: Add IND_FLAGS macro (2014-11-12 15:27:54 -0800) Geoff Levand (4): kexec: Fix make headers_check kexec: Simplify conditional kexec: Add bit definitions

[PATCH V3] kexec: Add IND_FLAGS macro

. Signed-off-by: Geoff Levand Cc: Benjamin Herrenschmidt Acked-by: Vivek Goyal --- Hi Ben, Could you give your ack on this, then I'll try to get it merged with my other kexec patches. Thanks. -Geoff arch/powerpc/kernel/machine_kexec_64.c | 2 -- include/linux/kexec.h | 1 + 2

[PATCH V3] kexec: Add IND_FLAGS macro

. Signed-off-by: Geoff Levand ge...@infradead.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Acked-by: Vivek Goyal vgo...@redhat.com --- Hi Ben, Could you give your ack on this, then I'll try to get it merged with my other kexec patches. Thanks. -Geoff arch/powerpc/kernel

[PATCH V3 0/4] kexec: minor fixups and enhancements

changes up to 916ef4b8abaa4202ea43731b9cd3f8e0ea95f05b: kexec: Add IND_FLAGS macro (2014-11-12 15:27:54 -0800) Geoff Levand (4): kexec: Fix make headers_check kexec: Simplify conditional kexec: Add bit definitions

[PATCH V3 1/4] kexec: Fix make headers_check

Remove the unneded declaration for a kexec_load() routine. Fixes errors like these when running 'make headers_check': include/uapi/linux/kexec.h: userspace cannot reference function or variable defined in the kernel Signed-off-by: Geoff Levand ge...@infradead.org Acked-by: Paul Bolle pebo

[PATCH V3 4/4] kexec: Add IND_FLAGS macro

. Signed-off-by: Geoff Levand ge...@infradead.org Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org Acked-by: Vivek Goyal vgo...@redhat.com --- arch/powerpc/kernel/machine_kexec_64.c | 2 -- include/linux/kexec.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff

[PATCH V3 3/4] kexec: Add bit definitions for kimage entry flags

and the chance that changes to the IND_* flags will not be propagated to assembly files. Signed-off-by: Geoff Levand ge...@infradead.org Acked-by: Vivek Goyal vgo...@redhat.com --- include/linux/kexec.h | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/include

[PATCH V3 2/4] kexec: Simplify conditional

for the conditional. There is no functional change to the code. Signed-off-by: Geoff Levand ge...@infradead.org Acked-by: Vivek Goyal vgo...@redhat.com --- kernel/kexec.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/kernel/kexec.c b/kernel/kexec.c index 2abf9f6

Re: [PATCH] [SCSI] ps3rom: fix error return code

ev) > if (!host) { > dev_err(>sbd.core, "%s:%u: scsi_host_alloc failed\n", > __func__, __LINE__); > + error = -ENOMEM; > goto fail_teardown; > } > Looks OK. James, please apply. Acked-By:

Re: [PATCH] [SCSI] ps3rom: fix error return code

) if (!host) { dev_err(dev-sbd.core, %s:%u: scsi_host_alloc failed\n, __func__, __LINE__); + error = -ENOMEM; goto fail_teardown; } Looks OK. James, please apply. Acked-By: Geoff Levand ge...@infradead.org

Re: [PATCH V3 4/5] kexec: Add IND_FLAGS macro

. Signed-off-by: Geoff Levand Cc: Benjamin Herrenschmidt Acked-by: Vivek Goyal --- >From V2: Folded patch 5 into patch 4. arch/powerpc/kernel/machine_kexec_64.c | 2 -- include/linux/kexec.h | 1 + 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powe

Re: [PATCH V3 4/5] kexec: Add IND_FLAGS macro

. Signed-off-by: Geoff Levand ge...@infradead.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Acked-by: Vivek Goyal vgo...@redhat.com --- From V2: Folded patch 5 into patch 4. arch/powerpc/kernel/machine_kexec_64.c | 2 -- include/linux/kexec.h | 1 + 2 files changed, 1

[PATCH V25/5] powerpc/kexec: Use global IND_FLAGS macro

linux/kexec.h now defines an IND_FLAGS macro. Remove the local powerpc definition and use the generic one. Signed-off-by: Geoff Levand --- arch/powerpc/kernel/machine_kexec_64.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel

[PATCH V24/5] kexec: Add IND_FLAGS macro

Add a new kexec preprocessor macro IND_FLAGS, which is the bitwise OR of all the possible kexec IND_ kimage_entry indirection flags. Having this macro allows for simplified code in the prosessing of the kexec kimage_entry items. Signed-off-by: Geoff Levand Acked-by: Vivek Goyal --- include

  1   2   3   >