rd;
>
> netdev = alloc_etherdev(struct_size(card, darray,
> - tx_descriptors + rx_descriptors));
> + size_add(tx_descriptors,
> rx_descriptors)));
> if (!netdev)
> return NULL;
>
Looks good to me. Thanks for your fix-up.
Signed-off-by: Geoff Levand
On 3/23/21 1:55 AM, caizhichao wrote:
> From: caizhichao
>
> vaules -> values
>
> Signed-off-by: caizhichao
> ---
> sound/ppc/snd_ps3_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Seems fine. Thanks for your contribution.
Acked-by: Geoff Levand
Li
> ---
> arch/powerpc/platforms/ps3/system-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for your patch, it looks good.
Acked-by: Geoff Levand
-Geoff
On 12/13/20 10:26 AM, Vincent Stehlé wrote:
> The DMA address returned by dma_map_single() should be checked with
> dma_mapping_error(). Fix the ps3stor_setup() function accordingly.
>
> Fixes: 80071802cb9c ("[POWERPC] PS3: Storage Driver Core")
> Signed-off-by: Vincent S
ntainer for is very much dead, but there is apparently still some
> activity on the Playstation 3 that Geoff Levand maintains.
>
> Eric correctly points out that the PS3 firmware no longer boots
> Linux (OtherOS), but AFAIK there are both users with old firmware
> and those that use a firmw
ed with diff + objdump -Dr).
Thanks for your patch. I tested this patch applied to v5.8-rc2 on a
PS3 and it seems OK.
Tested-by: Geoff Levand
> -} static saved_params;
> +} saved_params;
Seems fine.
Acked-by: Geoff Levand
Hi Gustavo,
On 1/8/19 1:00 PM, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding the
> size of a structure that has a zero-sized array at the end, along with memory
> for some number of elements for that array. For example:
>
> struct foo {
>
On 01/03/2018 06:40 AM, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
I applied this to my ps3-queue branch.
As I mentioned to you several times before, please keep
the commit subject line to less than 50 characters.
Also, in this case the pref
On 12/20/2017 01:20 PM, SF Markus Elfring wrote:
>> o Your patch fixes no bug nor replaces any depreciated feature.
>
> How do you think about information from the section “14) Allocating memory”
> in the document “coding-style.rst” for the shown source code transformation?
In terms of importanc
Hi,
On 12/16/2017 05:54 AM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 16 Dec 2017 14:21:04 +0100
>
> Replace the specification of data structures by variable references
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer acco
On 12/18/2017 12:45 PM, SF Markus Elfring wrote:
>> but you are also removing empty lines and changing the coding format.
>
> * Why do you not like such a change combination?
>
> * Do you really want to integrate further update steps in this case?
I want to keep the coding style consistent throu
Hi,
On 12/16/2017 05:50 AM, SF Markus Elfring wrote:
> Markus Elfring (2):
> Delete an error message for a failed memory allocation in two functions
> Improve a size determination in five functions
As I mentioned before, please keep your commit message subjects to
50 chars or less.
-Geoff
Hi,
On 12/16/2017 05:54 AM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 16 Dec 2017 14:21:04 +0100
>
> Replace the specification of data structures by variable references
> as the parameter for the operator "sizeof" to make the corresponding size
> determination a bit safer acco
On 12/16/2017 05:51 AM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sat, 16 Dec 2017 12:32:42 +0100
>
> Omit an extra message for a memory allocation failure in these functions.
This is OK, I'll add it to my ps3-queue branch.
-Geoff
On 10/17/2017 11:54 AM, SF Markus Elfring wrote:
> Markus Elfring (2):
> Delete an error message for a failed memory allocation in update_flash_db()
> Improve a size determination in two functions
For consistency, please use 'powerpc/ps3' not 'powerpc-ps3' as
the commit log subject prefix. Al
On 08/07/2017 12:04 PM, SF Markus Elfring wrote:
>> I think your original patch is OK,
>
> How does this feedback fit to the initial response “Not Applicable”?
> https://patchwork.ozlabs.org/patch/798575/
I submitted your patch and a fix to ps3vram_probe() with
the other patches in my queue. Tha
On 08/07/2017 11:34 AM, SF Markus Elfring wrote:
>> I didn't consider one would be triggered by the kzalloc failure.
>
> Do you reconsider any special system settings for further
> software evolution then?
Sorry, I don't quite understand your question.
I think your original patch is OK, and I wo
On 08/07/2017 09:27 AM, SF Markus Elfring wrote:
>>> Omit an extra message for a memory allocation failure in this function.
>>>
>>> This issue was detected by using the Coccinelle software.
>>
>> NACK
>>
>> When a user asks me for help I would certainly like to get
>> 'Could not allocate cache ta
On 08/07/2017 03:52 AM, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Mon, 7 Aug 2017 12:37:01 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
NACK
When a user asks me for help I would cer
On 06/06/2017 12:22 PM, Greg Kroah-Hartman wrote:
> The dev_attrs field has long been "depreciated" and is finally being
> removed, so move the driver to use the "correct" dev_groups field
> instead for struct bus_type.
> arch/powerpc/platforms/ps3/system-bus.c | 10 ++
> 1 file changed,
ms to work OK.
Thanks for your contribution.
Tested-by: Geoff Levand
On 02/16/2017 11:11 PM, Joe Perches wrote:
> To enable eventual removal of pr_warning
> ---
> arch/powerpc/platforms/ps3/device-init.c| 14 +++---
> arch/powerpc/platforms/ps3/mm.c | 4 ++--
> arch/powerpc/platforms/ps3/os-area.c| 2 +-
PS3 parts look
| 4 ++--
> arch/powerpc/platforms/ps3/os-area.c| 2 +-
PS3 parts look OK.
Acked-by: Geoff Levand
some special users(e.g kexec, hibernate) would need the line
> size on the CPU (rather than the system wide), when the system wide
> feature may not be accessible. Provide another helper which will fetch
> cache line size on the current CPU.
>
> Cc: James Morse
> Cc: Geoff Levand
>
On Tue, 2016-08-02 at 19:53 +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access
> permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and
some special users(e.g kexec, hibernate) would need the line
> size on the CPU (rather than the system wide), when the system wide
> feature may not be accessible. Provide another helper which will fetch
> cache line size on the current CPU.
>
Looks OK for what kexec needs.
Acked-by: Geoff Levand
On Mon, 2015-09-07 at 07:58 +0800, Boqun Feng wrote:
> arch/powerpc/platforms/ps3/Kconfig | 2 +-
Looks OK for PS3.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More m
On Tue, 2015-09-01 at 11:21 +0100, Colin King wrote:
> On the unlikely event that drv is null, the current code will
> perform a null pointer dereference with it when printing a dev_dbg
> message. Instead, the BUG_ON check on drv should be performed
> before we emit the dev_dbg message.
>
> Signe
From: Rudhresh Kumar J
Fixed a coding style issue.
Signed-off-by: Rudhresh Kumar J
Signed-off-by: Geoff Levand
---
Please apply to trivial. Thanks.
-Geoff
drivers/ps3/ps3-lpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ps3/ps3-lpm.c b/drivers/ps3/ps3
Hi,
On Fri, 2015-07-17 at 08:50 +0200, Ard Biesheuvel wrote:
> > On 16 July 2015 at 19:58, Mark Salter wrote:
> >> Commit 68234df4ea79 ("arm64: kill flush_cache_all()") removed
> >> soft_reset() from the kernel. This was the only caller of
> >> setup_mm_for_reboot(), so remove that also.
> >
> >
Hi Marc,
On Mon, 2015-07-06 at 15:53 +0100, Marc Zyngier wrote:
> So this has now been a whole month since I reviewed this, and I haven't
> seen any repost of this series. Any hope to see this within a reasonable
> time frame? Or is it considered dead already?
I was hoping to do some work on upda
Fix sparse warnings like these:
drivers/block/ps3vram.c: warning: incorrect type in assignment (different
address spaces)
drivers/block/ps3vram.c:expected unsigned int [usertype] *ctrl
drivers/block/ps3vram.c:got void [noderef] *
Cc: Jim Paris
Cc: Jens Axboe
Signed-off-by: Geoff
1d082300a03a735c006739907e6aea082007663c:
MAINTAINERS: Update ps3vram block driver (2015-06-10 10:46:25 -0700)
Geert Uytterhoeven (1):
block/ps3vram: Remove obsolete reference to MTD
Geoff Levand (2):
block/ps3vram: Fix sparse warnings
Add myself as co-maintainer of the ps3vram block driver, and add linuxppc-dev
as a relevant mailing list.
I have been acting as maintainer of this driver for the last several years, and
if there is some inquiry regarding it I would like to be notified.
Signed-off-by: Geoff Levand
On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote:
> @@ -64,7 +65,11 @@ void soft_restart(unsigned long addr)
> setup_mm_for_reboot();
>
> cpu_soft_restart(virt_to_phys(cpu_reset),
> - is_hyp_mode_available(), addr);
> +#ifdef CONFIG_KEXEC
> + !in_crash_
Hi Takahiro,
On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote:
> On system kernel, the memory region used by crash dump kernel must be
> specified by "crashkernel=X@Y" boot parameter. reserve_crashkernel()
> will allocate the region in "System RAM" and reserve it for later use.
>
> On cra
Hi Takahiro,
On Thu, 2015-03-26 at 17:28 +0900, AKASHI Takahiro wrote:
> On system kernel, the memory region used by crash dump kernel must be
> specified by "crashkernel=X@Y" boot parameter. reserve_crashkernel()
> will allocate the region in "System RAM" and reserve it for later use.
>
> On cra
Hi Marc,
On Tue, 2015-03-24 at 08:46 +, Marc Zyngier wrote:
> "arm64: KVM: Allow EL2 context to be reset on shutdown"
Sure, this sounds good.
-Geoff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majord
Hi Takahiro,
On Mon, 2015-03-23 at 20:53 +0900, AKASHI Takahiro wrote:
> diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
> index 3e6859b..428f41c 100644
> --- a/arch/arm/kvm/mmu.c
> +++ b/arch/arm/kvm/mmu.c
...
> +phys_addr_t kvm_get_stub_vectors(void)
> +{
> + return virt_to_phys(__hyp
On Mon, 2015-03-23 at 20:53 +0900, AKASHI Takahiro wrote:
> The current kvm implementation keeps EL2 vector table installed even
> when the system is shut down. This prevents kexec from putting the system
> with kvm back into EL2 when starting a new kernel.
This is a kvm bug fix, so I think the su
On Sat, 2015-03-07 at 13:03 +0100, Yannick Guerrini wrote:
> Change 'prosessor' to 'processor'
> Change 'set_inteval' to 'set_interval'
>
> Signed-off-by: Yannick Guerrini
> ---
> drivers/ps3/ps3-lpm.c | 4 ++--
Looks good. Thanks for t
Hi,
On Mon, 2014-12-22 at 12:48 +0100, Dongsu Park wrote:
> From: Kent Overstreet
> --- a/drivers/block/ps3vram.c
> +++ b/drivers/block/ps3vram.c
> @@ -603,6 +603,8 @@ static void ps3vram_make_request(struct request_queue *q,
> struct bio *bio)
> struct ps3vram_priv *priv = ps3_system_bus
Hi Michael,
On Tue, 2014-12-23 at 11:26 +1100, Michael Ellerman wrote:
> On Mon, 2014-12-22 at 09:26 -0800, Geoff Levand wrote:
> > ps3_repository_write_highmem_info() is needed by otheros++. What we
> > need is a kernel patch to add the highmem info to the repository once
On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote:
> Remove the function ps3_repository_write_highmem_info() that is not used
> anywhere.
NAK
ps3_repository_write_highmem_info() is needed by otheros++. What we
need is a kernel patch to add the highmem info to the repository once it
i
and the chance that changes to the IND_* flags will not be propagated to
assembly files.
Signed-off-by: Geoff Levand
Acked-by: Vivek Goyal
---
include/linux/kexec.h | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/include/linux/kexec.h b/include/linux
conditional. There is no functional change to the code.
Signed-off-by: Geoff Levand
Acked-by: Vivek Goyal
---
kernel/kexec.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 2abf9f6..650fcba 100644
--- a/kernel/kexec.c
.
Signed-off-by: Geoff Levand
Acked-by: Benjamin Herrenschmidt
Acked-by: Vivek Goyal
---
arch/powerpc/kernel/machine_kexec_64.c | 2 --
include/linux/kexec.h | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/machine_kexec_64.c
b/arch
Remove the unneded declaration for a kexec_load() routine.
Fixes errors like these when running 'make headers_check':
include/uapi/linux/kexec.h: userspace cannot reference function or variable
defined in the kernel
Signed-off-by: Geoff Levand
Acked-by: Paul Bolle
Cc: H. Peter
changes up to 916ef4b8abaa4202ea43731b9cd3f8e0ea95f05b:
kexec: Add IND_FLAGS macro (2014-11-12 15:27:54 -0800)
Geoff Levand (4):
kexec: Fix make headers_check
kexec: Simplify conditional
kexec: Add bit definitions
.
Signed-off-by: Geoff Levand
Cc: Benjamin Herrenschmidt
Acked-by: Vivek Goyal
---
Hi Ben,
Could you give your ack on this, then I'll try to get it
merged with my other kexec patches.
Thanks.
-Geoff
arch/powerpc/kernel/machine_kexec_64.c | 2 --
include/linux/kexec.h | 1
ev)
> if (!host) {
> dev_err(&dev->sbd.core, "%s:%u: scsi_host_alloc failed\n",
> __func__, __LINE__);
> + error = -ENOMEM;
> goto fail_teardown;
> }
>
Looks OK. James, please apply.
.
Signed-off-by: Geoff Levand
Cc: Benjamin Herrenschmidt
Acked-by: Vivek Goyal
---
>From V2: Folded patch 5 into patch 4.
arch/powerpc/kernel/machine_kexec_64.c | 2 --
include/linux/kexec.h | 1 +
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powe
linux/kexec.h now defines an IND_FLAGS macro. Remove the local powerpc
definition and use the generic one.
Signed-off-by: Geoff Levand
---
arch/powerpc/kernel/machine_kexec_64.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kernel/machine_kexec_64.c
b/arch/powerpc/kernel
Add a new kexec preprocessor macro IND_FLAGS, which is the bitwise OR of
all the possible kexec IND_ kimage_entry indirection flags.
Having this macro allows for simplified code in the prosessing of the
kexec kimage_entry items.
Signed-off-by: Geoff Levand
Acked-by: Vivek Goyal
---
include
and the chance that changes to the IND_* flags will not be propagated to
assembly files.
Signed-off-by: Geoff Levand
Acked-by: Vivek Goyal
---
include/linux/kexec.h | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/include/linux/kexec.h b/include/linux
conditional. There is no functional change to the code.
Signed-off-by: Geoff Levand
Acked-by: Vivek Goyal
---
kernel/kexec.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 2bee072..4b8356b 100644
--- a/kernel/kexec.c
for you to fetch changes up to adf97d602657c72f6ee59aefe5d51149159a3e99:
powerpc/kexec: Use global IND_FLAGS macro (2014-10-06 17:06:26 -0700)
--------
Geoff Levand (5):
kexec: Fix make headers_check
kexec: Simplify conditional
Remove the unneded declaration for a kexec_load() routine.
Fixes errors like these when running 'make headers_check':
include/uapi/linux/kexec.h: userspace cannot reference function or variable
defined in the kernel
Signed-off-by: Geoff Levand
Acked-by: Paul Bolle
Cc: H. Peter
On Mon, 2014-10-06 at 20:21 +0200, Paul Bolle wrote:
> On Mon, 2014-10-06 at 10:34 -0700, Geoff Levand wrote:
> > On Mon, 2014-10-06 at 16:12 +0200, Paul Bolle wrote:
> > > It seems not much happened after I added my Acked-by. I assume you still
> > > want to get t
Hi,
On Mon, 2014-10-06 at 16:12 +0200, Paul Bolle wrote:
> On Sat, 2014-08-30 at 14:47 +0200, Paul Bolle wrote:
> > [Added Peter Anvin.]
> >
> > On Mon, 2014-08-25 at 13:22 -0400, Vivek Goyal wrote:
> > > On Fri, Aug 22, 2014 at 06:39:47PM +, Geoff Levand wro
Hi Vivek,
On Mon, 2014-08-25 at 12:59 -0400, Vivek Goyal wrote:
> Does arm64 has secureboot? If yes, then it might make sense to
> enable the new syscall kexec_file_load() on arm64 instead of trying
> to make old syscall work first.
Yes, arm64 should support secureboot, but I have not looked into
/kexec: Use global IND_FLAGS macro (2014-08-22 11:15:18 -0700)
Geoff Levand (5):
kexec: Fix make headers_check
kexec: Simplify conditional
kexec: Add bit definitions for kimage entry flags
kexec: Add IND_FLAGS macro
linux/kexec.h now defines an IND_FLAGS macro. Remove the local powerpc
definition and use the generic one.
Signed-off-by: Geoff Levand
---
arch/powerpc/kernel/machine_kexec_64.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kernel/machine_kexec_64.c
b/arch/powerpc/kernel
Remove the unneded declaration for a kexec_load() routine.
Fixes errors like these when running 'make headers_check':
include/uapi/linux/kexec.h: userspace cannot reference function or variable
defined in the kernel
Signed-off-by: Geoff Levand
---
include/uapi/linux/kexec.h | 6
Add a new kexec preprocessor macro IND_FLAGS, which is the bitwise OR of
all the possible kexec IND_ kimage_entry indirection flags.
Having this macro allows for simplified code in the prosessing of the
kexec kimage_entry items.
Signed-off-by: Geoff Levand
---
include/linux/kexec.h | 1 +
1
conditional. There is no functional change to the code.
Signed-off-by: Geoff Levand
---
kernel/kexec.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 0b49a0a..d04b56e 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
and the chance that changes to the IND_* flags will not be propagated to
assembly files.
Signed-off-by: Geoff Levand
---
include/linux/kexec.h | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/include/linux/kexec.h b/include/linux/kexec.h
index 4b2a0e1
Hi Hanjun,
On Tue, 2014-08-19 at 20:11 +0800, Hanjun Guo wrote:
> On 2014-8-19 2:56, Geoff Levand wrote:
> > message = acpi_disabled ? dn->full_name : "";
> >
> > ...
> >
> > pr_warn("CPU %d: %s unsupported enable-method p
Hi Hanjun,
On Mon, 2014-08-04 at 23:28 +0800, Hanjun Guo wrote:
> --- a/arch/arm64/include/asm/acpi.h
> +++ b/arch/arm64/include/asm/acpi.h
> @@ -14,6 +14,27 @@
>
> /* Basic configuration for ACPI */
> #ifdef CONFIG_ACPI
By having this preprocessor conditional in the header leads
to a p
Hi Hanjun,
On Thu, 2014-07-24 at 21:00 +0800, Hanjun Guo wrote:
> ACPI 5.1 only has two explicit methods to boot up SMP,
> PSCI and Parking protocol, but the Parking protocol is
> only suitable for ARMv7 now, so make PSCI as the only way
> for the SMP boot protocol before some updates for the
> AC
Signed-off-by: Geoff Levand
---
Hi Andrew,
Just a very minor comment fix. Please consider.
-Geoff
include/linux/byteorder/generic.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/byteorder/generic.h
b/include/linux/byteorder/generic.h
index 0846e6b
> + if (!*netdev) {
> kfree(card->unalign);
> return NULL;
> }
Looks good, thanks for posting.
Dave, please queue for merge upstream.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo
maintaining
linker script output section descriptions seems to be error prone, often
not having the correct section attributes. This new macro should help
to reduce these errors.
Signed-off-by: Geoff Levand
---
Hi,
I thought I'd send this out to see if this is of interest. If so, I can
go th
nction and remove the PREPARE_WORK() usage.
>
> It would probably be best to route this with other related updates
> through the workqueue tree.
I tested this on ps3 (DECR-1400) and it seems to work OK. Please queue
with your other workqueue changes. Thanks!
Acked-by: Geoff Levand
-
.
>
> arch/powerpc/kernel/time.c| 2 +-
> arch/powerpc/platforms/ps3/time.c | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
I tested the PS3 part of this patch and it seems to work OK.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "uns
@@
> /*
> - * ps3vram - Use extra PS3 video ram as MTD block device.
> + * ps3vram - Use extra PS3 video ram as block device.
> *
> * Copyright 2009 Sony Corporation
> *
Looks good.
Jens, could you please apply.
Acked-by: Geoff Levand
--
To unsubscribe from this list
drivers/block/ps3disk.c | 2 +-
> drivers/block/ps3vram.c | 2 +-
The PS3 parts look OK. Please try to test a powerpc build with
ps3_defconfig.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
out;
> }
Arnd is out on leave, so I'll say that this looks OK.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
3_gelic_wireless.h | 6 ++---
> drivers/net/ethernet/toshiba/spider_net.h | 4 ++--
> 3 files changed, 19 insertions(+), 20 deletions(-)
Looks good. Thanks.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body o
On Wed, 2013-09-11 at 08:21 +0530, Preeti U Murthy wrote:
> arch/powerpc/platforms/ps3/smp.c|2 +-
The PS3 part is trivial and looks OK.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mess
On Wed, 2013-09-11 at 08:21 +0530, Preeti U Murthy wrote:
> arch/powerpc/platforms/ps3/smp.c|2 +-
The PS3 part is trivial and looks OK.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mess
iter.bio), iter.bio->bi_iter.bi_sector);
>
> size = bvec->bv_len;
> buf = bvec_kmap_irq(bvec, &flags);
The ps3 part looks OK. Please try a build test with the powerpc
defconfig_ps3 if you can.
Acked-by: Geoff Levand
--
To unsubscribe from th
; drivers/block/ps3vram.c | 10 ++---
ps3vram part looks OK.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
3_get_spe_id(), so I think we should
remove it. I'll submit a patch.
-Geoff
Forwarded Message
From: Geoff Levand
To: cbe-oss-...@lists.ozlabs.org
Subject: Dropping PS3 oprofile support in v3.8
Date: Wed, 13 Feb 2013 17:30:39 -0800
Hi All,
I'll be dropping the PS3 op
; ---
> arch/powerpc/platforms/ps3/spu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Looks good, thanks.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
Hi Alan,
> Actually, I think this is not necessary. Instead those three glue
> files ought to be changed. They should not need to call
> ehci_shutdown() directly.
I sent out a separate patch that removes the ehci_shutdown()
call in ps3_ehci_remove(). I tested it by removing and
installing the
rch/powerpc/sysdev/rtc_cmos_setup.c |5 +
> 4 files changed, 4 insertions(+), 11 deletions(-)
ps3 part looks OK, thanks.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
On Tue, 2012-10-23 at 13:01 -0700, Kees Cook wrote:
>
> - depends on PPC_PS3 && EXPERIMENTAL
> + depends on PPC_PS3
Looks OK.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to maj
orms/ps3/os-area.c |6 +++---
> 10 files changed, 35 insertions(+), 37 deletions(-)
The ps3 part looks OK. Please do build test with ps3_defconfig.
Acked-by: Geoff Levand
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On 02/24/2008 12:06 AM, Samuel Tardieu wrote:
> Fix unlikely(plug) == NO_IRQ into unlikely(plug == NO_IRQ).
>
> Signed-off-by: Samuel Tardieu <[EMAIL PROTECTED]>
> ---
> arch/powerpc/platforms/ps3/interrupt.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks for the submission
On 02/16/2008 08:08 AM, Roel Kluin wrote:
> The patch below was not yet tested. If it's correct as it is, please comment.
> - if (unlikely(plug) == NO_IRQ) {
> + if (unlikely(plug == NO_IRQ)) {
A good catch! I'll put it in with some other 2.6.25 bug fixes.
-Geoff
--
To unsubscribe from
On 02/16/2008 09:42 AM, Arjan van de Ven wrote:
> On Sat, 16 Feb 2008 18:33:16 +0100
> Willy Tarreau <[EMAIL PROTECTED]> wrote:
>
>> On Sat, Feb 16, 2008 at 09:25:52AM -0800, Arjan van de Ven wrote:
>> > On Sat, 16 Feb 2008 17:08:01 +0100
>> > Roel Kluin <[EMAIL PROTECTED]> wrote:
>> >
>> > > The
An updated PS3 Linux Distributor's Starter Kit (v1.6) was released.
The CD-ROM iso image is here (171 MiB):
ftp://ftp.infradead.org/pub/Sony-PS3/CELL-Linux-CL_20080201-ADDON.iso
http://ftp.uk.linux.org/pub/linux/Sony-PS3/CELL-Linux-CL_20080201-ADDON.iso
I extracted files are here for conveni
[EMAIL PROTECTED]>
> Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
> ---
> include/asm-powerpc/percpu.h | 22 +++---
> 1 file changed, 3 insertions(+), 19 deletions(-)
Tested on PS3 with ps3_defconfig and works OK.
Acked-by: Geoff Levand <[EMAIL PROTECTED]
Ingo Molnar wrote:
> * Luck, Tony <[EMAIL PROTECTED]> wrote:
>
>> > Could you check the patch below? With this applied to latest -git,
>> > ia64 buils fine for me in a cross-compiling environment. (but i dont
>> > know whether it boots ...)
>>
>> Uni-processor build still fails with this patch
For those interested, an updated PS3 Linux Distributor's Starter Kit (v1.5.1)
was released.
This is a bug-fix release that only updates kboot and the linux kernel
with the fix for the PS3 system update 2.10 frame buffer bug.
The CD-ROM iso image is here (171 MiB):
ftp://ftp.infradead.org/pub/S
On 12/18/2007 05:10 PM, Andrew Morton wrote:
> On Wed, 12 Dec 2007 18:00:12 -0800
> Geoff Levand <[EMAIL PROTECTED]> wrote:
>
>> > This stray down would cause a permanent sleep which doesn't seem correct.
>> > The other uses of this semaphore appear fairly
iel Walker <[EMAIL PROTECTED]>
>
> ---
> drivers/ps3/ps3-vuart.c |1 -
> 1 file changed, 1 deletion(-)
Signed-off-by: Geoff Levand <[EMAIL PROTECTED]>
Looks, good.
Andrew, Please apply.
-Geoff
--
To unsubscribe from this list: send the line "unsubscribe linux-k
From: Geoff Levand <[EMAIL PROTECTED]>
SPARSEMEM_VMEMMAP needs to be a selectable config option to
support building the kernel both with and without sparsemem
vmemmap support. This selection is desirable for platforms
which could be configured one way for platform specific
builds and the
1 - 100 of 141 matches
Mail list logo
