[PATCH net-next 0/2] Add devlink health reporters for NIX block

2021-01-19 Thread George Cherian
same. George Cherian (2): octeontx2-af: Add devlink health reporters for NIX docs: octeontx2: Add Documentation for NIX health reporters .../ethernet/marvell/octeontx2.rst| 70 ++ .../marvell/octeontx2/af/rvu_devlink.c| 652 +- .../marvell/octeont

[PATCH net-next 2/2] docs: octeontx2: Add Documentation for NIX health reporters

2021-01-19 Thread George Cherian
Add devlink health reporter documentation for NIX block. Signed-off-by: George Cherian --- .../ethernet/marvell/octeontx2.rst| 70 +++ 1 file changed, 70 insertions(+) diff --git a/Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rst b

[PATCH net-next 1/2] octeontx2-af: Add devlink health reporters for NIX

2021-01-19 Thread George Cherian
: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 652 +- .../marvell/octeontx2/af/rvu_devlink.h| 27 + .../marvell/octeontx2/af/rvu_struct.h | 10 + 3 files changed, 688 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v2] docs: octeontx2: tune rst markup

2021-01-06 Thread George Cherian
> Jonathan, please pick this minor formatting clean-up patch. > Acked-by: George Cherian Regards -George

RE: [PATCH][next] octeontx2-af: Fix undetected unmap PF error check

2020-12-16 Thread George Cherian
> -Original Message- > From: Colin King > Sent: Wednesday, December 16, 2020 6:06 PM > To: Sunil Kovvuri Goutham ; Linu Cherian > ; Geethasowjanya Akula ; > Jerin Jacob Kollanukkaran ; David S . Miller > ; Jakub Kicinski ; George > Cherian ; net...@vger.kerne

[PATCHv6 net-next 0/3] Add devlink and devlink health reporters to

2020-12-10 Thread George Cherian
Added recover op too. v2 - Address Willem's comments on v1. - Fixed the sparse issues, reported by Jakub. George Cherian (3): octeontx2-af: Add devlink suppoort to af driver octeontx2-af: Add devlink health reporters for NPA docs: octeontx2: Add Documentation for NPA health reporte

[PATCHv6 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-12-10 Thread George Cherian
-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../net/ethernet/marvell/octeontx2/Kconfig| 1 + .../ethernet/marvell/octeontx2/af/Makefile| 2 +- .../net/ethernet/marvell/octeontx2/af/rvu.c | 9 ++- .../net/ethernet/marvell/octeontx2/af/rvu.h | 4 ++ .../marvell/octeontx2/af

[PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-12-10 Thread George Cherian
Each reporter dump shows the Register value and the description of the cause. Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 708 +- .../marvell/octeontx2/af/rvu_devlink.h

[PATCH 3/3] docs: octeontx2: Add Documentation for NPA health reporters

2020-12-10 Thread George Cherian
Add Documentation for devlink health reporters for NPA block. Signed-off-by: George Cherian --- .../ethernet/marvell/octeontx2.rst| 50 +++ 1 file changed, 50 insertions(+) diff --git a/Documentation/networking/device_drivers/ethernet/marvell/octeontx2.rst b

RE: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-30 Thread George Cherian
> -Original Message- > From: George Cherian > Sent: Tuesday, December 1, 2020 10:49 AM > To: 'Jakub Kicinski' > Cc: 'net...@vger.kernel.org' ; 'linux- > ker...@vger.kernel.org' ; > 'da...@davemloft.net' ; Sunil Kovvur

RE: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-30 Thread George Cherian
Jakub, > -Original Message- > From: George Cherian > Sent: Tuesday, December 1, 2020 9:06 AM > To: Jakub Kicinski > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; Sunil Kovvuri Goutham ; > Linu Cherian ; Geethasowjanya Akula >

Re: [PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-30 Thread George Cherian
Hi Jakub, > -Original Message- > From: Jakub Kicinski > Sent: Tuesday, December 1, 2020 7:59 AM > To: George Cherian > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > da...@davemloft.net; Sunil Kovvuri Goutham ; > Linu Cherian ; Geethasowjanya Akula >

[PATCHv5 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-26 Thread George Cherian
Poisoned data on WQE read from multicast buffer: 0 Poisoned data on NIX_RX_MCE_S read: 0 NIX_AF_RVU: Unmap Slot Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 414

[PATCHv5 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-26 Thread George Cherian
on NPA_AQ_RES_S write: 0 Poisoned data on HW context read: 0 NPA_AF_RVU: Unmap Slot Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 498 +- .../marvell

[PATCHv5 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-26 Thread George Cherian
Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../net/ethernet/marvell/octeontx2/Kconfig| 1 + .../ethernet/marvell/octeontx2/af/Makefile| 2 +- .../net/ethernet/marvell/octeontx2/af/rvu.c | 9 ++- .../net/ethernet/marvell/octeontx2

[PATCHv5 net-next 0/3] Add devlink and devlink health reporters to

2020-11-26 Thread George Cherian
recover op too. v2 - Address Willem's comments on v1. - Fixed the sparse issues, reported by Jakub. George Cherian (3): octeontx2-af: Add devlink suppoort to af driver octeontx2-af: Add devlink health reporters for NPA octeontx2-af: Add devlink health reporters for NIX .../

Re: [PATCHv4 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-23 Thread George Cherian
Hi Jiri, > -Original Message- > From: Jiri Pirko > Sent: Monday, November 23, 2020 3:52 PM > To: George Cherian > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > k...@kernel.org; da...@davemloft.net; Sunil Kovvuri Goutham > ; Linu Cherian ; > Geeth

Re: [PATCHv4 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-22 Thread George Cherian
> -Original Message- > From: Jiri Pirko > Sent: Saturday, November 21, 2020 7:44 PM > To: George Cherian > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; > k...@kernel.org; da...@davemloft.net; Sunil Kovvuri Goutham > ; Linu Cherian ; > Geeth

[PATCHv4 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-20 Thread George Cherian
read: 0 Poisoned data on NPA_AQ_RES_S write: 0 Poisoned data on HW context read: 0 NPA_AF_RVU: Unmap Slot Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 492

[PATCHv4 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-20 Thread George Cherian
Poisoned data on WQE read from multicast buffer: 0 Poisoned data on NIX_RX_MCE_S read: 0 NIX_AF_RVU: Unmap Slot Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 414

[PATCHv4 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-20 Thread George Cherian
Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../net/ethernet/marvell/octeontx2/Kconfig| 1 + .../ethernet/marvell/octeontx2/af/Makefile| 2 +- .../net/ethernet/marvell/octeontx2/af/rvu.c | 9 ++- .../net/ethernet/marvell/octeontx2

[PATCHv3 net-next 0/3] Add devlink and devlink health reporters to

2020-11-20 Thread George Cherian
ported by Jakub. George Cherian (3): octeontx2-af: Add devlink suppoort to af driver octeontx2-af: Add devlink health reporters for NPA octeontx2-af: Add devlink health reporters for NIX .../net/ethernet/marvell/octeontx2/Kconfig| 1 + .../ethernet/marvell/octeontx2/af/Makefile|

[PATCH] octeontx2-af: Add support for RSS hashing based on Transport protocol field

2020-11-20 Thread George Cherian
Add support to choose RSS flow key algorithm with IPv4 transport protocol field included in hashing input data. This will be enabled by default. There-by enabling 3/5 tuple hash Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: George Cherian --- drivers/net/ethernet/marvell/octeontx2/af

[PATCHv3 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-19 Thread George Cherian
read: 0 Poisoned data on NPA_AQ_RES_S write: 0 Poisoned data on HW context read: 0 NPA_AF_RVU: Unmap Slot Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 492

[PATCHv3 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-19 Thread George Cherian
Poisoned data on WQE read from multicast buffer: 0 Poisoned data on NIX_RX_MCE_S read: 0 NIX_AF_RVU: Unmap Slot Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 414

[PATCHv3 net-next 0/3] Add devlink and devlink health reporters to

2020-11-19 Thread George Cherian
hange-log: v3 - Address Saeed's comments on v2. - Renamed the reporter name as hw_*. - Call devlink_health_report() when an event is raised. - Added recover op too. v2 - Address Willem's comments on v1. - Fixed the sparse issues, reported by Jakub. George Cherian (3): octeontx2-

[PATCHv3 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-19 Thread George Cherian
Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../net/ethernet/marvell/octeontx2/Kconfig| 1 + .../ethernet/marvell/octeontx2/af/Makefile| 3 +- .../net/ethernet/marvell/octeontx2/af/rvu.c | 9 ++- .../net/ethernet/marvell/octeontx2

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-05 Thread George Cherian
Hi Saeed, Thanks for the review. > -Original Message- > From: Saeed Mahameed > Sent: Thursday, November 5, 2020 10:39 AM > To: George Cherian ; net...@vger.kernel.org; > linux-kernel@vger.kernel.org; Jiri Pirko > Cc: k...@kernel.org; da...@davemloft.net; Sunil Kovvur

[PATCH v2 net-next 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-04 Thread George Cherian
Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 432 +- .../marvell/octeontx2/af/rvu_devlink.h| 23 + .../marvell/octeontx2/af/rvu_struct.h | 23 + 3 files

[PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-04 Thread George Cherian
: Unmap Slot Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 360 +- .../marvell/octeontx2/af/rvu_devlink.h| 24 ++ .../marvell/octeontx2/af/rvu_struct.h

[PATCH v2 net-next 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-04 Thread George Cherian
Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../net/ethernet/marvell/octeontx2/Kconfig| 1 + .../ethernet/marvell/octeontx2/af/Makefile| 3 +- .../net/ethernet/marvell/octeontx2/af/rvu.c | 9 ++- .../net/ethernet/marvell/octeontx2

[PATCH v2 net-next 0/3] Add devlink and devlink health reporters to

2020-11-04 Thread George Cherian
hange-log: - Address Willem's comments on v1. - Fixed the sparse issues, reported by Jakub. George Cherian (3): octeontx2-af: Add devlink suppoort to af driver octeontx2-af: Add devlink health reporters for NPA octeontx2-af: Add devlink health reporters for NIX .../net/ethernet/marvell

Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-03 Thread George Cherian
Hi Willem, > -Original Message- > From: Willem de Bruijn > Sent: Tuesday, November 3, 2020 11:26 PM > To: George Cherian > Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller > ; Sunil Kovvuri Goutham > ; Linu Cherian

Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-03 Thread George Cherian
Hi Willem, > -Original Message- > From: Willem de Bruijn > Sent: Tuesday, November 3, 2020 7:21 PM > To: George Cherian > Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller > ; Sunil Kovvuri Goutham > ; Linu Cherian

Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-03 Thread George Cherian
Hi Willem, > -Original Message- > From: Willem de Bruijn > Sent: Tuesday, November 3, 2020 7:21 PM > To: George Cherian > Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller > ; Sunil Kovvuri Goutham > ; Linu Cherian

Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-02 Thread George Cherian
Hi Willem, Thanks for the review. > -Original Message- > From: Willem de Bruijn > Sent: Monday, November 2, 2020 7:12 PM > To: George Cherian > Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller > ; Sunil Kovvuri Gou

Re: [net-next PATCH 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-02 Thread George Cherian
Hi Willem, Thanks for the review. > -Original Message- > From: Willem de Bruijn > Sent: Monday, November 2, 2020 7:01 PM > To: George Cherian > Cc: Network Development ; linux-kernel ker...@vger.kernel.org>; Jakub Kicinski ; David Miller > ; Sunil Kovvuri Gou

[net-next PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA

2020-11-01 Thread George Cherian
Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 434 +- .../marvell/octeontx2/af/rvu_devlink.h| 23 + .../marvell/octeontx2/af/rvu_struct.h | 23 + 3 files

[net-next PATCH 1/3] octeontx2-af: Add devlink suppoort to af driver

2020-11-01 Thread George Cherian
Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../net/ethernet/marvell/octeontx2/Kconfig| 1 + .../ethernet/marvell/octeontx2/af/Makefile| 3 +- .../net/ethernet/marvell/octeontx2/af/rvu.c | 9 ++- .../net/ethernet/marvell/octeontx2

[net-next PATCH 0/3] Add devlink and devlink health reporters to

2020-11-01 Thread George Cherian
Add basic devlink and devlink health reporters. Devlink health reporters are added for NPA and NIX blocks. These reporters report the error count in respective blocks. Address Jakub's comment to add devlink support for error reporting. https://www.spinics.net/lists/netdev/msg670712.html G

[net-next PATCH 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-01 Thread George Cherian
: Unmap Slot Error: 0 Signed-off-by: Sunil Kovvuri Goutham Signed-off-by: Jerin Jacob Signed-off-by: George Cherian --- .../marvell/octeontx2/af/rvu_devlink.c| 376 +- .../marvell/octeontx2/af/rvu_devlink.h| 24 ++ .../marvell/octeontx2/af/rvu_struct.h

[net-next PATCH 2/2] octeontx2-pf: Support to change VLAN based RSS hash options via ethtool

2020-09-22 Thread George Cherian
-N rx-flow-hash sdfnv Signed-off-by: George Cherian Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 2 +- drivers/net/ethernet/marvell/octeontx2/nic/otx2_ethtool.c | 7 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers

[net-next PATCH 1/2] octeontx2-af: Add support for VLAN based RSS hashing

2020-09-22 Thread George Cherian
Added support for PF/VF drivers to choose RSS flow key algorithm with VLAN tag included in hashing input data. Only CTAG is considered. Signed-off-by: George Cherian Signed-off-by: Sunil Goutham --- drivers/net/ethernet/marvell/octeontx2/af/mbox.h| 1 + drivers/net/ethernet/marvell

[net-next PATCH 0/2] Add support for VLAN based flow distribution

2020-09-22 Thread George Cherian
- Single VLAN flow with multi SDFN All tests done for udp/tcp both v4 and v6 George Cherian (2): octeontx2-af: Add support for VLAN based RSS hashing octeontx2-pf: Support to change VLAN based RSS hash options via ethtool drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 1

Re: [PATCH v2 3/3] asm-generic/io.h: Fix !CONFIG_GENERIC_IOMAP pci_iounmap() implementation

2020-09-18 Thread George Cherian
> -Original Message- > From: Lorenzo Pieralisi > Sent: Thursday, September 17, 2020 3:00 PM > To: Catalin Marinas > Cc: linux-kernel@vger.kernel.org; George Cherian ; > Arnd Bergmann ; Will Deacon ; Bjorn > Helgaas ; Yang Yingliang > ; linux-...@vge

Re: [PATCH] arm64: PCI: fix memleak when calling pci_iomap/unmap()

2020-09-07 Thread George Cherian
> -Original Message- > From: Catalin Marinas > Sent: Monday, September 7, 2020 4:16 PM > To: Yang Yingliang > Cc: linux-kernel@vger.kernel.org; linux-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; will.dea...@arm.com; bhelg...@google.com; > Ge

Re: Re: [PATCH v3] PCI: Add pci_iounmap

2020-09-01 Thread George Cherian
Hi Yang, > -Original Message- > From: Yang Yingliang > Sent: Tuesday, September 1, 2020 6:59 PM > To: George Cherian ; linux-kernel@vger.kernel.org; > linux-a...@vger.kernel.org; linux-...@vger.kernel.org > Cc: kbuild-...@lists.01.org; bhelg...@google.com;

[PATCH v3] PCI: Add pci_iounmap

2020-08-24 Thread George Cherian
ind/unbind test of any pci driver using pcim_iomap/pci_iomap, would lead to the following error message after long hour tests "allocation failed: out of vmalloc space - use vmalloc= to increase size." Signed-off-by: George Cherian --- * Changes from v2 - Get rid of the #ifdefs ar

Re: [PATCHv2] PCI: Add pci_iounmap

2020-08-21 Thread George Cherian
Hi Bjorn, > -Original Message- > From: Bjorn Helgaas > Sent: Friday, August 21, 2020 3:26 AM > To: George Cherian > Cc: linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; linux- > p...@vger.kernel.org; bhelg...@google.com; a...@arndb.de; Michael S. > Tsirkin

[PATCHv2] PCI: Add pci_iounmap

2020-08-19 Thread George Cherian
age after long hour tests "allocation failed: out of vmalloc space - use vmalloc= to increase size." Signed-off-by: George Cherian --- * Changes from v1 - Fix the 0-day compilation error. - Mark the lib/iomap pci_iounmap call as weak incase if any archite

[PATCH] PCI: Add pci_iounmap

2020-08-19 Thread George Cherian
age after long hour tests "allocation failed: out of vmalloc space - use vmalloc= to increase size." Signed-off-by: George Cherian --- include/asm-generic/io.h | 4 lib/pci_iomap.c | 9 + 2 files changed, 13 insertions(+) diff --git a/include/asm-generic/io

Re: [EXT] Re: [PATCH] PCI: Enhance the ACS quirk for Cavium devices

2019-10-08 Thread George Cherian
19 14:48:13, Bjorn Helgaas wrote: >>> commit 37b22fbfec2d >>> Author: George Cherian >>> Date: Thu Sep 19 02:43:34 2019 + >>> >>> PCI: Apply Cavium ACS quirk to CN99xx and CN11xxx Root Ports >>> >>> Add an array of

[PATCH] PCI: Enhance the ACS quirk for Cavium devices

2019-09-18 Thread George Cherian
Enhance the ACS quirk for Cavium Processors. Add the root port vendor ID's in an array and use the same in match function. For newer devices add the vendor ID's in the array so that the match function is simpler. Signed-off-by: George Cherian --- drivers/pci/qui

Re: [RFC PATCH] cpufreq / cppc: Work around for Hisilicon CPPC cpufreq

2019-01-24 Thread George Cherian
Hi Wang, On Thu, Jan 24, 2019 at 12:27 PM Viresh Kumar wrote: > > +George/Prashanth. > > Guys please see if you have any objections to this patch. I am not > very familiar with this stuff and it would be good to get some > feedback from you guys. > > @Rafael: Do you have any comments on this ? >

Re: [PATCH] xhci: Add quirk to workaround the errata seen on Cavium Thunder-X2 Soc

2018-10-28 Thread George Cherian
Hi Alan, Thanks for the review. I will update the patch accordingly and send out v2. On 10/28/2018 10:48 PM, Alan Stern wrote: > > On Sat, 27 Oct 2018, Cherian, George wrote: > >> Implement workaround for ThunderX2 Errata-129 (documented in >> CN99XX Known Issues" available at Cavium support s

Re: [PATCH 2/2] ipmi_ssif: Fix crash seen while ipmi_unregister_smi

2018-08-26 Thread George Cherian
Hi Corey, On 08/24/2018 06:38 PM, Corey Minyard wrote: On 08/24/2018 06:10 AM, George Cherian wrote: Dont set ssif_info->intf to NULL before ipmi_unresgiter_smi. shutdown_ssif will anyways free ssif_info. This is correct, but it goes a little deeper.  I just sent out a patch yester

[PATCH v2] i2c: xlp9xx: Fix case where SSIF read transaction completes early

2018-08-08 Thread George Cherian
code to drain the RX fifo after the length update, so that the transaction completes correctly in all cases. Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 41 - 1 file changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/i2c

Re: Re: [PATCH] i2c: xlp9xx: Fix case where SSIF read transaction completes early

2018-08-02 Thread George Cherian
Hi Wolfran, Thanks for the review. I will update the patch with a small comment section above len --; so that there is no confusion. On 08/01/2018 02:35 AM, Wolfram Sang wrote: --- a/drivers/i2c/busses/i2c-xlp9xx.c +++ b/drivers/i2c/busses/i2c-xlp9xx.c @@ -191,28 +191,30 @@ static void xlp9xx_

[PATCH] i2c: xlp9xx: Fix case where SSIF read transaction completes early

2018-07-22 Thread George Cherian
code to drain the RX fifo after the length update, so that the transaction completes correctly in all cases. Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c

[PATCH v4] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-07-11 Thread George Cherian
counter). Implement the above and hook this to the cpufreq->get method. Signed-off-by: George Cherian Acked-by: Viresh Kumar --- drivers/cpufreq/cppc_cpufreq.c | 52 ++ 1 file changed, 52 insertions(+) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/driv

Re: [PATCH v3] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-07-10 Thread George Cherian
Hi Prakash, On 07/10/2018 09:19 PM, Prakash, Prashanth wrote: On 7/9/2018 11:42 PM, George Cherian wrote: Hi Prakash, On 07/09/2018 10:12 PM, Prakash, Prashanth wrote: Hi George, On 7/9/2018 4:10 AM, George Cherian wrote: Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides

Re: [PATCH v3] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-07-09 Thread George Cherian
Hi Prakash, On 07/09/2018 10:12 PM, Prakash, Prashanth wrote: Hi George, On 7/9/2018 4:10 AM, George Cherian wrote: Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance feedback via set of performance counters. To determine the actual performance level delivered over time

[PATCH v3] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-07-09 Thread George Cherian
counter). Implement the above and hook this to the cpufreq->get method. Signed-off-by: George Cherian Acked-by: Viresh Kumar --- drivers/cpufreq/cppc_cpufreq.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/driv

Re: [v2] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-06-20 Thread George Cherian
Hi JC, Thanks for the review. On 06/20/2018 02:09 AM, Jayachandran C wrote: Hi George, Few comments on your patch: On Fri, Jun 15, 2018 at 03:03:15AM -0700, George Cherian wrote: Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance feedback via set of performance counters

Re: [PATCH v2] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-06-20 Thread George Cherian
Hi Prakash, Thanks for the review. On 06/19/2018 01:51 AM, Prakash, Prashanth wrote: External Email Hi George, On 6/15/2018 4:03 AM, George Cherian wrote: Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance feedback via set of performance counters. To determine the actual

[PATCH v2] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-06-15 Thread George Cherian
counter). Implement the above and hook this to the cpufreq->get method. Signed-off-by: George Cherian Acked-by: Viresh Kumar --- drivers/cpufreq/cppc_cpufreq.c | 71 ++ 1 file changed, 71 insertions(+) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/driv

Re: [PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-05-30 Thread George Cherian
Hi Prashanth, On 05/29/2018 09:14 PM, Prakash, Prashanth wrote: On 5/28/2018 1:09 AM, George Cherian wrote: Hi Prashanth, On 05/26/2018 02:30 AM, Prakash, Prashanth wrote: On 5/25/2018 12:27 AM, George Cherian wrote: Hi Prashanth, On 05/25/2018 12:55 AM, Prakash, Prashanth wrote: Hi

Re: [PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-05-28 Thread George Cherian
Hi Prashanth, On 05/26/2018 02:30 AM, Prakash, Prashanth wrote: On 5/25/2018 12:27 AM, George Cherian wrote: Hi Prashanth, On 05/25/2018 12:55 AM, Prakash, Prashanth wrote: Hi George, On 5/22/2018 5:42 AM, George Cherian wrote: Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides

Re: [PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-05-24 Thread George Cherian
Hi Prashanth, On 05/25/2018 12:55 AM, Prakash, Prashanth wrote: Hi George, On 5/22/2018 5:42 AM, George Cherian wrote: Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance feedback via set of performance counters. To determine the actual performance level delivered over time

[PATCH] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-05-22 Thread George Cherian
counter). Implement the above and hook this to the cpufreq->get method. Signed-off-by: George Cherian --- drivers/cpufreq/cppc_cpufreq.c | 44 ++ 1 file changed, 44 insertions(+) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufre

[PATCH 1/4] i2c: xlp9xx: Add support for SMBAlert

2018-05-16 Thread George Cherian
Add support for SMBus alert mechanism to i2c-xlp9xx driver. The second interrupt is parsed to use for SMBus alert. The first interrupt is the i2c controller main interrupt. Signed-off-by: Kamlakant Patel Signed-off-by: George Cherian Reviewed-by: Jan Glauber --- drivers/i2c/busses/i2c

[PATCH 3/4] i2c: xlp9xx: Make sure the transfer size is not more than I2C_SMBUS_BLOCK_SIZE

2018-05-16 Thread George Cherian
-off-by: Jayachandran C Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c index c268fde..1f41a4f 100644

[PATCH 4/4] i2c: xlp9xx: Add MAINTAINERS entry

2018-05-16 Thread George Cherian
The i2c XLP9xx driver is maintained by Cavium. Add George Cherian and Jan Glauber as the Maintainers. Signed-off-by: George Cherian --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index df6e9bb..68da265 100644 --- a/MAINTAINERS +++ b

[PATCH 2/4] i2c: xlp9xx: Fix issue seen when updating receive length

2018-05-16 Thread George Cherian
sure that the new length written to hardware is at least few bytes more than the bytes received so far. While at that refactor the length updation to a new function. Signed-off-by: Jayachandran C Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 30

[PATCH 0/4] i2c-xlp9xx Add support for SMBAlert and minor fixes

2018-05-16 Thread George Cherian
MAINATINERS file to reflect the current maintainers of the driver. George Cherian (4): i2c: xlp9xx: Add support for SMBAlert i2c: xlp9xx: Fix issue seen when updating receive length i2c: xlp9xx: Make sure the transfer size is not more than I2C_SMBUS_BLOCK_SIZE i2c: xlp9xx: Add MAINTAINERS

[PATCH] cpufreq: cppc: Use transition_delay_us depending on the transition_latency

2018-03-23 Thread George Cherian
e0 (cpufreq: Cap the default transition delay value to 10 ms) Signed-off-by: George Cherian --- drivers/cpufreq/cppc_cpufreq.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c index a1c3025..dcb1cb9 100644 --- a/drivers/cpufreq/

Re: [PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173

2018-03-13 Thread George Cherian
Hi Bjorn, On 02/22/2018 08:39 PM, Bjorn Helgaas wrote: On Thu, Feb 22, 2018 at 06:43:34PM +0530, George Cherian wrote: On 02/22/2018 04:50 AM, Bjorn Helgaas wrote: On Wed, Feb 21, 2018 at 04:25:08PM +0530, George Cherian wrote: On 02/21/2018 03:24 PM, Lukas Wunner wrote: On Wed, Feb 21

[PATCH v2] i2c: xlp9xx: Add support for SMBAlert

2018-03-06 Thread George Cherian
Add support for SMBus alert mechanism to i2c-xlp9xx driver. The second interrupt is parsed to use for SMBus alert. The first interrupt is the i2c controller main interrupt. Signed-off-by: Kamlakant Patel Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 24

Re: [PATCH 3/3] i2c: xlp9xx: Add support for SMBAlert

2018-03-06 Thread George Cherian
On 03/06/2018 02:48 PM, Phil Reid wrote: On 6/03/2018 16:36, Jan Glauber wrote: On Tue, Feb 27, 2018 at 01:26:20PM +, George Cherian wrote: Add support for SMBus alert mechanism to i2c-xlp9xx driver. The second interrupt is parsed to use for SMBus alert. The first interrupt is the i2c

[PATCHv2 1/3] i2c: xlp9xx: Check for Bus state before every transfer

2018-02-27 Thread George Cherian
make sure the bus is not busy before every transaction. Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c index 1f6d780..42

[PATCH 3/3] i2c: xlp9xx: Add support for SMBAlert

2018-02-27 Thread George Cherian
Add support for SMBus alert mechanism to i2c-xlp9xx driver. The second interrupt is parsed to use for SMBus alert. The first interrupt is the i2c controller main interrupt. Signed-off-by: Kamlakant Patel Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 26

[PATCH 2/3] i2c: xlp9xx: Handle NACK on DATA properly

2018-02-27 Thread George Cherian
E for such transactions. Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c index 42dd1fa..eb8913e 100644 --- a/drivers/i2c/busses/i2

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread George Cherian
Hi Wolfram, On 02/27/2018 02:35 PM, Wolfram Sang wrote: Since you raised concern on the patch I thought of reworking this patch. But I can see that this patch is already applied for i2c/for-next. Kindly let me know whether I should be sending follow-up patches on top of i2c/for-next ? Oops,

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-27 Thread George Cherian
Hi Wolfram, On 02/27/2018 02:34 PM, Wolfram Sang wrote: On Tue, Feb 27, 2018 at 10:30:31AM +0530, George Cherian wrote: Hi Wolfram, Thanks for the review. On 02/27/2018 01:52 AM, Wolfram Sang wrote: On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: I2C bus enters the STOP

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-26 Thread George Cherian
Hi Wolfram, On 02/27/2018 10:30 AM, George Cherian wrote: Hi Wolfram, Thanks for the review. On 02/27/2018 01:52 AM, Wolfram Sang wrote: On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. Essentially

Re: [PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-02-26 Thread George Cherian
Hi Wolfram, Thanks for the review. On 02/27/2018 01:52 AM, Wolfram Sang wrote: On Thu, Jan 18, 2018 at 05:39:24AM +, George Cherian wrote: I2C bus enters the STOP condition after the DATA_DONE interrupt is raised. Essentially the driver should be checking the bus state before sending the

Re: [PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173

2018-02-22 Thread George Cherian
Hi Bjorn, On 02/22/2018 04:50 AM, Bjorn Helgaas wrote: On Wed, Feb 21, 2018 at 04:25:08PM +0530, George Cherian wrote: On 02/21/2018 03:24 PM, Lukas Wunner wrote: On Wed, Feb 21, 2018 at 02:58:13PM +0530, George Cherian wrote: I will explain the setup used To the Cavium ThunderX RC the

Re: [PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173

2018-02-21 Thread George Cherian
Hi Lukas, On 02/21/2018 03:24 PM, Lukas Wunner wrote: On Wed, Feb 21, 2018 at 02:58:13PM +0530, George Cherian wrote: I will explain the setup used To the Cavium ThunderX RC the following PLX device is connected. PLX Technology, Inc. PEX 8747 48-Lane, 5-Port PCI Express Gen 3 (8.0 GT/s) Switch

Re: [PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173

2018-02-21 Thread George Cherian
Hi Bjorn, On 02/21/2018 12:30 AM, Bjorn Helgaas wrote: [+cc Huang] On Tue, Feb 20, 2018 at 02:54:33AM +0100, Lukas Wunner wrote: On Mon, Feb 19, 2018 at 12:21:56PM +0100, Rafael J. Wysocki wrote: On Friday, February 16, 2018 9:34:34 PM CET Bjorn Helgaas wrote: On Fri, Feb 16, 2018 at 01:40:

[PATCH] ACPI / CPPC: Update all pr_(debug/err) messages to log the susbspace id

2018-02-20 Thread George Cherian
CPPC dirver is aware of multiple PCC subspace IDs. Enhance the debug and error messages in the driver to print the subspace id. In case of error it will be helpful to find which particular subspace is failing. Signed-off-by: George Cherian --- drivers/acpi/cppc_acpi.c | 27

Re: [PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173

2018-02-14 Thread George Cherian
Hi Bjorn, Thanks for the review. On 02/13/2018 08:39 PM, Bjorn Helgaas wrote: [+cc Lorenzo] On Fri, Feb 02, 2018 at 07:00:46AM +, George Cherian wrote: The PCIe Controller on Cavium ThunderX2 processors does not respond to downstream CFG/ECFG cycles when root port is in power management

[PATCH] PCI: Add quirk for Cavium Thunder-X2 PCIe erratum #173

2018-02-01 Thread George Cherian
a quirk that prevents the root port from entering D3 state. This is seen on both Ax/Bx variants of the processor. Signed-off-by: George Cherian --- drivers/pci/quirks.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 10684b1

Re: [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK

2018-01-30 Thread George Cherian
Gentle Ping on this series. On 01/18/2018 11:09 AM, George Cherian wrote: From: Dmitry Bazhenov Fix the driver violation of the common practice to return ENXIO error on a slave address NACK. Signed-off-by: Dmitry Bazhenov Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c

[PATCH 2/4] i2c: xlp9xx: Handle transactions with I2C_M_RECV_LEN properly

2018-01-17 Thread George Cherian
received length. Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 31 --- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c index 6d78cdc..b5b224e 100644 --- a/drivers/i2c

[PATCH 3/4] i2c: xlp9xx: report SMBus block read functionality

2018-01-17 Thread George Cherian
From: Dmitry Bazhenov Report SMBus block read functionality which is actually supported. Signed-off-by: Dmitry Bazhenov --- drivers/i2c/busses/i2c-xlp9xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c

[PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK

2018-01-17 Thread George Cherian
From: Dmitry Bazhenov Fix the driver violation of the common practice to return ENXIO error on a slave address NACK. Signed-off-by: Dmitry Bazhenov Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH 4/4] i2c: xlp9xx: Check for Bus state after every transfer

2018-01-17 Thread George Cherian
check to make sure the bus is not busy before next transaction. Signed-off-by: George Cherian --- drivers/i2c/busses/i2c-xlp9xx.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c index 1f6d780

Re: [PATCH] ACPI / CPPC: Fix negative array index read in cppc_set_perf

2017-12-15 Thread George Cherian
after the check on pcc_ss_id at line 1182: pcc_ss_data = pcc_data[pcc_ss_id]; Addresses-Coverity-ID: 1426090 ("Negative array index read") Fixes: 1ecbd7170d65 ("ACPI / CPPC: Fix KASAN global out of bounds warning") Reviewed-by: George Cherian Signed-off-by: Gustavo A. R.

Re: [PATCH] ptr_ring: add barriers

2017-12-11 Thread George Cherian
at producers do not need to read the value so we do not need to order these reads. Reported-by: George Cherian Suggested-by: Jason Wang Signed-off-by: Michael S. Tsirkin I'm asked for asking for testing feedback and did not get it in a reasonable amount of time. The tests have complete

[PATCH] ptr_ring: Add barriers to fix NULL-pointer exception

2017-12-06 Thread George Cherian
naked+0x24/0x28 [35322.773042] Code: d503201f f9400e93 b940e280 91051274 (f9403261) Reported-by: Joseph DeVincentis Signed-off-by: George Cherian --- include/linux/ptr_ring.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h

  1   2   3   4   5   6   >