Re: [PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Girish KS
On Wed, Mar 19, 2014 at 10:50 AM, Jassi Brar wrote: > On 19 March 2014 09:30, Girish KS wrote: >> On Wed, Mar 19, 2014 at 12:15 AM, Jassi Brar >> wrote: > >>> +int mbox_send_message(struct mbox_chan *chan, void *mssg) >>> +{ >>> + in

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-18 Thread Girish KS
On Mon, Mar 17, 2014 at 7:36 PM, Mark Rutland wrote: > On Mon, Mar 17, 2014 at 12:03:59PM +, Girish K S wrote: >> This patch adds the dt node for the mailbox IP >> >> Signed-off-by: Girish K S >> >> Change-Id: I35e45e9a62592887a84a909aee54f259a2f731fa >> --- >> .../bindings/mailbox/samsung-m

Re: [PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Girish KS
On Wed, Mar 19, 2014 at 12:15 AM, Jassi Brar wrote: > Introduce common framework for client/protocol drivers and > controller drivers of Inter-Processor-Communication (IPC). > > Client driver developers should have a look at > include/linux/mailbox_client.h to understand the part of > the API exp

Re: [PATCH 1/2] mailbox: samsung: added support for samsung mailbox

2014-03-18 Thread Girish KS
On Tue, Mar 18, 2014 at 4:26 PM, Joe Perches wrote: > On Tue, 2014-03-18 at 15:52 +0530, Girish KS wrote: >> On Mon, Mar 17, 2014 at 5:33 PM, Girish K S wrote: > > Hi, just some trivial notes about the patch > >> > diff --git a/drivers/mailbox/mailbox-samsung.c >

Re: [PATCH 1/2] mailbox: samsung: added support for samsung mailbox

2014-03-18 Thread Girish KS
On Mon, Mar 17, 2014 at 5:33 PM, Girish K S wrote: > This patch adds support to the samsung mailbox driver. > > Signed-off-by: Girish K S > --- > drivers/mailbox/Kconfig |8 + > drivers/mailbox/Makefile |2 + > drivers/mailbox/mailbox-samsung.c | 354 > ++

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-17 Thread Girish KS
On Mon, Mar 17, 2014 at 5:33 PM, Girish K S wrote: > This patch adds the dt node for the mailbox IP > > Signed-off-by: Girish K S > > Change-Id: I35e45e9a62592887a84a909aee54f259a2f731fa Sorry for this. will modify in the v2 with other comments > --- > .../bindings/mailbox/samsung-mailbox.txt

Re: [PATCH] spi: s3c64xx: add missing check for polling mode

2013-07-01 Thread Girish KS
On Thu, Jun 27, 2013 at 4:45 PM, Mark Brown wrote: > On Thu, Jun 27, 2013 at 12:26:53PM +0530, Girish K S wrote: >> After the patch "spi/s3c64xx: Fix non-dmaengine usage" >> with commit id 563b444e33810f3120838620c990480304e24e63 >> submitted by Mark Brown, the spi device detection in polling >> m

Re: [PATCH V2] ahci: sata: add support for exynos5440 sata

2013-06-24 Thread Girish KS
On Mon, Jun 17, 2013 at 11:54 PM, Tejun Heo wrote: > On Tue, Apr 16, 2013 at 02:58:02PM +0530, Girish K S wrote: >> This patch adds the compatible string of the exynos5440 sata controller >> compliant with the ahci 1.3 and sata 3.0 specification. >> >> Signed-off-by: Girish K S >> >> changes in v

Re: [PATCH v1 2/3] spi: s3c64xx: Added provision for dedicated cs pin

2013-06-20 Thread Girish KS
On Wed, Jun 19, 2013 at 11:53 PM, Mark Brown wrote: > On Mon, May 20, 2013 at 12:21:33PM +0530, Girish K S wrote: >> From: Girish K S >> >> The existing driver supports gpio based /cs signal. >> For controller's that have one device per controller, >> the slave device's /cs signal might be intern

Re: [PATCH V2] ahci: sata: add support for exynos5440 sata

2013-06-09 Thread Girish KS
HI, can this patch be pulled in for 3.11 On Tue, Apr 16, 2013 at 2:58 PM, Girish K S wrote: > This patch adds the compatible string of the exynos5440 sata controller > compliant with the ahci 1.3 and sata 3.0 specification. > > Signed-off-by: Girish K S > > changes in v2: > chang

Re: [PATCH v1 0/3] Polling support for s3c64xx spi controller

2013-06-09 Thread Girish KS
Hello Mark, pls let me know if there is any issue with this series On Mon, May 20, 2013 at 12:21 PM, Girish K S wrote: > This patch series adds support for the polling mode only. Also 2nd patch > in the series adds support for dedicated cs pin. After Thomas's patch for > using default gpio is

Re: [PATCH v1 0/3] Polling support for s3c64xx spi controller

2013-05-29 Thread Girish KS
Hello Mark, Can you please check the performance with this patch set On Mon, May 20, 2013 at 12:21 PM, Girish K S wrote: > This patch series adds support for the polling mode only. Also 2nd patch > in the series adds support for dedicated cs pin. After Thomas's patch for > using default gpio is

Re: [PATCH 2/3] spi: s3c64xx: Added provision for dedicated cs pin

2013-04-24 Thread Girish KS
On Tue, Apr 23, 2013 at 8:12 PM, Mark Brown wrote: > On Mon, Apr 22, 2013 at 12:39:24PM +0530, Girish K S wrote: >> From: Girish K S >> >> The existing driver supports gpio based /cs signal. >> For controller's that have one device per controller, >> the slave device's /cs signal might be interna

Re: [PATCH 1/3] spi: s3c64xx: added support for polling mode

2013-04-24 Thread Girish KS
On Tue, Apr 23, 2013 at 8:45 PM, Mark Brown wrote: > On Mon, Apr 22, 2013 at 12:39:23PM +0530, Girish K S wrote: >> From: Girish K S >> >> The 64xx spi driver supports partial polling mode. >> Only the last chunk of the transfer length is transferred >> or recieved in polling mode. > > This appea

Re: [PATCH V4 2/5] spi: s3c64xx: added support for polling mode

2013-04-17 Thread Girish KS
On Tue, Apr 16, 2013 at 5:42 PM, Mark Brown wrote: > On Tue, Apr 16, 2013 at 04:58:47PM +0530, Girish KS wrote: >> On Tue, Apr 16, 2013 at 4:50 PM, Mark Brown wrote: > >> > I'm missing patch 1 of this series. > >> its already merged to stable tree after

Re: [PATCH V4 2/5] spi: s3c64xx: added support for polling mode

2013-04-16 Thread Girish KS
On Tue, Apr 16, 2013 at 4:50 PM, Mark Brown wrote: > On Mon, Apr 15, 2013 at 02:10:27PM +0530, Girish K S wrote: >> From: Girish K S >> >> The 64xx spi driver supports partial polling mode. >> Only the last chunk of the transfer length is transferred >> or recieved in polling mode. > > I'm missin

Re: [PATCH] ahci: sata: add support for exynos5440 sata

2013-04-16 Thread Girish KS
On Tue, Apr 16, 2013 at 2:43 PM, Felipe Balbi wrote: > Hi, > > On Tue, Apr 16, 2013 at 02:40:04PM +0530, Girish K S wrote: >> This patch adds the compatible string of the exynos5440 sata controller >> compliant with the ahci 1.3 and sata 3.0 specification. >> >> Signed-off-by: Girish K S >> --- >

Re: [PATCH V3 4/5] spi: s3c64xx: Added provision for dedicated cs pin

2013-04-08 Thread Girish KS
On Mon, Apr 8, 2013 at 5:50 PM, Mark Brown wrote: > On Mon, Apr 08, 2013 at 05:15:26PM +0530, Girish KS wrote: >> On Mon, Apr 8, 2013 at 3:45 PM, Mark Brown > >> > Two options here, one is to just assume nobody will use GPIO 0 and the >> > other is to set the numbe

Re: [PATCH V3 4/5] spi: s3c64xx: Added provision for dedicated cs pin

2013-04-08 Thread Girish KS
On Mon, Apr 8, 2013 at 5:15 PM, Girish KS wrote: > On Mon, Apr 8, 2013 at 3:45 PM, Mark Brown > wrote: >> On Mon, Apr 08, 2013 at 03:21:03PM +0530, Girish KS wrote: >>> On Mon, Apr 1, 2013 at 6:27 PM, Mark Brown >> >>> > It's also a bit odd that we

Re: [PATCH V3 4/5] spi: s3c64xx: Added provision for dedicated cs pin

2013-04-08 Thread Girish KS
On Mon, Apr 8, 2013 at 3:45 PM, Mark Brown wrote: > On Mon, Apr 08, 2013 at 03:21:03PM +0530, Girish KS wrote: >> On Mon, Apr 1, 2013 at 6:27 PM, Mark Brown > >> > It's also a bit odd that we end up checking cs_gpio and then using line >> > in the code, it'

Re: [PATCH V3 4/5] spi: s3c64xx: Added provision for dedicated cs pin

2013-04-08 Thread Girish KS
On Mon, Apr 1, 2013 at 6:27 PM, Mark Brown wrote: > On Wed, Mar 13, 2013 at 12:13:33PM +0530, Girish K S wrote: >> From: Girish K S >> >> The existing driver supports gpio based /cs signal. >> For controller's that have one device per controller, >> the slave device's /cs signal might be internal

Re: [PATCH V3 2/5] spi: s3c64xx: added support for polling mode

2013-04-03 Thread Girish KS
On Wed, Apr 3, 2013 at 5:19 PM, Mark Brown wrote: > On Wed, Apr 03, 2013 at 05:00:04PM +0530, Girish KS wrote: >> On Mon, Apr 1, 2013 at 6:42 PM, Mark Brown > >> >> - if (!sdd->pdev->dev.of_node) { >> >> + if (!sdd->pdev->dev.of_nod

Re: [PATCH V3 2/5] spi: s3c64xx: added support for polling mode

2013-04-03 Thread Girish KS
On Mon, Apr 1, 2013 at 6:42 PM, Mark Brown wrote: > On Wed, Mar 13, 2013 at 12:13:31PM +0530, Girish K S wrote: > >> Some SoC's that adopt this controller might not have have dma >> interface. This patch adds support for complete polling mode >> and gives flexibity for the user to select poll/dma

Re: [PATCH V3 0/5] Add polling support for 64xx spi controller

2013-03-24 Thread Girish KS
Hello grant, any comments on this patch series? On Wed, Mar 13, 2013 at 12:13 PM, Girish K S wrote: > [PATCH 1/5]: fixes the error handling in the interrupt handler > [PATCH 2/5]: The existing driver support partial polling mode. > This patch modifies the current driver to support

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-08 Thread Girish KS
On Fri, Feb 8, 2013 at 12:58 AM, Girish KS wrote: > On Fri, Feb 8, 2013 at 12:33 AM, Tomasz Figa wrote: >> On Thursday 07 of February 2013 09:46:58 Girish KS wrote: >>> On Thu, Feb 7, 2013 at 3:09 AM, Tomasz Figa wrote: >>> > Hi Girish, >>> > >&

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-08 Thread Girish KS
On Fri, Feb 8, 2013 at 12:33 AM, Tomasz Figa wrote: > On Thursday 07 of February 2013 09:46:58 Girish KS wrote: >> On Thu, Feb 7, 2013 at 3:09 AM, Tomasz Figa wrote: >> > Hi Girish, >> > >> > On Wednesday 06 of February 2013 12:12:29 Girish KS wrote: >>

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-08 Thread Girish KS
On Thu, Feb 7, 2013 at 5:04 PM, Girish KS wrote: > On Wed, Feb 6, 2013 at 3:48 PM, Grant Likely > wrote: >> On Wed, Feb 6, 2013 at 8:12 PM, Girish KS wrote: >>> On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely >>> wrote: >>>> On Tue, 5 Feb 2013 15:09:41

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-07 Thread Girish KS
On Wed, Feb 6, 2013 at 3:48 PM, Grant Likely wrote: > On Wed, Feb 6, 2013 at 8:12 PM, Girish KS wrote: >> On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely >> wrote: >>> On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S >>> wrote: >>>> The status of the

Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-07 Thread Girish KS
On Thu, Feb 7, 2013 at 3:55 AM, Mark Brown wrote: > On Tue, Feb 05, 2013 at 03:09:43PM -0800, Girish K S wrote: >> This patch adds support for spi controllers with >> dedicated clk/miso/mosi/cs pins. It skips the gpio >> parsing and initialization for controllers that >> have dedicated pins. > >>

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-07 Thread Girish KS
On Thu, Feb 7, 2013 at 3:09 AM, Tomasz Figa wrote: > Hi Girish, > > On Wednesday 06 of February 2013 12:12:29 Girish KS wrote: >> On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely > wrote: >> > On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S > wrote: >> >> T

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-06 Thread Girish KS
On Wed, Feb 6, 2013 at 3:48 PM, Grant Likely wrote: > On Wed, Feb 6, 2013 at 8:12 PM, Girish KS wrote: >> On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely >> wrote: >>> On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S >>> wrote: >>>> The status of the

Re: [PATCH 3/4] spi: s3c64xx: add gpio quirk for controller

2013-02-06 Thread Girish KS
On Wed, Feb 6, 2013 at 2:40 AM, Grant Likely wrote: > On Tue, 5 Feb 2013 15:09:43 -0800, Girish K S wrote: >> This patch adds support for spi controllers with >> dedicated clk/miso/mosi/cs pins. It skips the gpio >> parsing and initialization for controllers that >> have dedicated pins. >> >> Si

Re: [PATCH 2/4] spi: s3c64xx: added support for polling mode

2013-02-06 Thread Girish KS
On Wed, Feb 6, 2013 at 2:35 AM, Grant Likely wrote: > On Tue, 5 Feb 2013 15:09:42 -0800, Girish K S wrote: >> The 64xx spi driver supports partial polling mode. >> Only the last chunk of the transfer length is transferred >> or recieved in polling mode. >> >> Some SoC's that adopt this controlle

Re: [PATCH 1/4] spi: s3c64xx: modified error interrupt handling and init

2013-02-06 Thread Girish KS
On Wed, Feb 6, 2013 at 2:26 AM, Grant Likely wrote: > On Tue, 5 Feb 2013 15:09:41 -0800, Girish K S wrote: >> The status of the interrupt is available in the status register, >> so reading the clear pending register and writing back the same >> value will not actually clear the pending interrupt