Re: [PATCH] crypto: hisilicon - check if debugfs opened

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 08:40:07PM +0800, tanghui20 wrote: > > > On 2021/3/30 20:23, Greg KH wrote: > > On Tue, Mar 30, 2021 at 08:09:46PM +0800, tanghui20 wrote: > > > > > > > > > On 2021/3/28 23:09, Greg KH wrote: > > > > On

Re: [PATCH] crypto: hisilicon - check if debugfs opened

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 08:09:46PM +0800, tanghui20 wrote: > > > On 2021/3/28 23:09, Greg KH wrote: > > On Sat, Mar 27, 2021 at 04:33:00PM +0800, Hui Tang wrote: > > > 'xx_debugfs_init' check if debugfs opened. > > > > > > Signed-off-by: Hui

Re: [PATCH v26 07/13] mm/damon: Implement a debugfs-based user space interface

2021-03-30 Thread Greg KH
On Tue, Mar 30, 2021 at 09:05:31AM +, sj38.p...@gmail.com wrote: > +static int __init __damon_dbgfs_init(void) > +{ > + struct dentry *dbgfs_root; > + const char * const file_names[] = {"monitor_on"}; > + const struct file_operations *fops[] = {&monitor_on_fops}; > + int i; > +

Re: [1/5] reporting-issues: header and TLDR

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 04:44:21PM -0600, Jonathan Corbet wrote: > Thorsten Leemhuis writes: > > > FWIW, on another channel someone mentioned the process in the TLDR is > > quite complicated when it comes to regressions in stable and longterm > > kernels. I looked at the text and it seemed like a

Re: Compiling kernel-3.4.xxx with gcc-9.x. Need some help.

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 09:20:32PM +0200, Fawad Lateef wrote: > Hi Greg, > > > > On Mon, 29 Mar 2021 at 06:57, Greg KH wrote: > > > > On Sun, Mar 28, 2021 at 10:20:50PM +0200, Fawad Lateef wrote: > > > Hi > > > > > > I am using an Ol

Re: [PATCH] wireless/nl80211.c: fix uninitialized variable

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 08:41:38PM +0200, Alaa Emad wrote: > On Mon, 29 Mar 2021 at 20:20, Greg KH wrote: > > > On Mon, Mar 29, 2021 at 06:30:36PM +0200, Alaa Emad wrote: > > > Reported-by: syzbot+72b99dcf4607e8c77...@syzkaller.appspotmail.com > > > Signed-off-by:

Re: [PATCH] wireless/nl80211.c: fix uninitialized variable

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 06:30:36PM +0200, Alaa Emad wrote: > Reported-by: syzbot+72b99dcf4607e8c77...@syzkaller.appspotmail.com > Signed-off-by: Alaa Emad You need to provide some changelog text here, I know I can not take patches without that, maybe the wireless maintainer is more flexible :) t

Re: [PATCH 5.11 000/252] 5.11.11-rc2 review

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 04:40:00PM +0200, Ronald Warsow wrote: > hello > > 5.11.11-rc2 compiles, boots and run fine here (on an i7-6700 with Fedora > 34 Beta) > > Thanks. > > but I see some error's/warning's with the new gcc-11.0.1 compared to the > elder gcc-10.2.1-11 Do you also see those gcc

Re: [PATCH 00/30] DMA: Mundane typo fixes

2021-03-29 Thread Greg KH
On Mon, Mar 29, 2021 at 11:25:11AM +0530, Bhaskar Chowdhury wrote: > On 07:29 Mon 29 Mar 2021, Christoph Hellwig wrote: > > I really don't think these typo patchbomb are that useful. I'm all > > for fixing typos when working with a subsystem, but I'm not sure these > > patchbombs help anything. >

Re: [PATCH v2 13/13] gpio: Use linux/gpio/driver.h

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 06:59:38PM -0700, Brad Larson wrote: > New drivers should include instead > of legacy . > > Signed-off-by: Brad Larson > --- > drivers/gpio/gpio-elba-spics.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-elba-spics.c b/driv

Re: linux-next: build failure after merge of the staging tree

2021-03-28 Thread Greg KH
On Mon, Mar 29, 2021 at 04:55:25PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the staging tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/iio/adc/ti-ads131e08.c: In function 'ads131e08_read_reg': > drivers/iio/adc/ti-ads131e08.c:180:5: error: '

Re: Compiling kernel-3.4.xxx with gcc-9.x. Need some help.

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 10:20:50PM +0200, Fawad Lateef wrote: > Hi > > I am using an Olimex A20 SOM with NAND and due to some binary blob for > NAND driver, I am stuck with the sunxi kernel 3.4.xxx version. (Repo > here: https://github.com/linux-sunxi/linux-sunxi) Please work with the vendor that

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 06:07:10PM +0200, Daniel Lezcano wrote: > On 28/03/2021 13:24, Greg KH wrote: > > On Sun, Mar 28, 2021 at 01:11:30PM +0200, Daniel Lezcano wrote: > >> > >> Hi Greg, > >> > >> On 28/03/2021 08:50, Greg KH wrote: > >> &g

Re: [PATCH] crypto: hisilicon - check if debugfs opened

2021-03-28 Thread Greg KH
On Sat, Mar 27, 2021 at 04:33:00PM +0800, Hui Tang wrote: > 'xx_debugfs_init' check if debugfs opened. > > Signed-off-by: Hui Tang > --- > drivers/crypto/hisilicon/hpre/hpre_main.c | 5 - > drivers/crypto/hisilicon/qm.c | 3 +++ > drivers/crypto/hisilicon/sec2/sec_main.c | 5 +++

Re: [PATCH v2 09/20] staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_debug.h

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 04:43:24PM +0200, Fabio Aiuto wrote: > On Sun, Mar 28, 2021 at 02:08:41PM +0200, Greg KH wrote: > > On Sat, Mar 27, 2021 at 03:24:08PM +0100, Fabio Aiuto wrote: > > > fix the following checkpatch warning: > > > > > > ERROR: Macros star

Re: [PATCH v12 0/2] UIO support for dfl devices

2021-03-28 Thread Greg KH
On Tue, Mar 16, 2021 at 01:10:05PM +0800, Xu Yilun wrote: > Hi Greg: > > I listed below some answers from Moritz and Yilun from previous mails for > your question. > > Do you have more comments? Nah, it's fine, now queued up, thanks. greg k-h

Re: [PATCH v8] add support for pci in the pvpanic driver

2021-03-28 Thread Greg KH
On Wed, Mar 24, 2021 at 04:49:13PM +0200, Mihai Carabas wrote: > This patchset adds support for PCI in the pvpanic driver. The device already > got in qemu [1]. > > v2: > - mmio -> MMIO, pci -> PCI suggested by Randy Dunlap. > - group pvpanic-common.c and mmio.c in the same module. The intention w

Re: [PATCH] scripts/spdxcheck.py: Fix a typo

2021-03-28 Thread Greg KH
On Fri, Mar 26, 2021 at 02:44:43PM +0530, Bhaskar Chowdhury wrote: > > s/Initilize/Initialize/ > > Signed-off-by: Bhaskar Chowdhury Now queued up, thanks. greg k-h

Re: [PATCH next 2/2] misc: Add Renesas Synchronization Management Unit (SMU) support

2021-03-28 Thread Greg KH
On Fri, Mar 26, 2021 at 11:34:11AM -0400, min.li...@renesas.com wrote: > From: Min Li > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide support

Re: [PATCH v2 19/20] staging: rtl8723bs: include macro in a do - while loop in core/rtw_security.c

2021-03-28 Thread Greg KH
On Sat, Mar 27, 2021 at 03:24:18PM +0100, Fabio Aiuto wrote: > fix the following checkpatch warning: > > ERROR: Macros with multiple statements should be enclosed > in a do - while loop > 2014: FILE: drivers/staging/rtl8723bs/core/rtw_security.c:2014: > +#define ROUND(i, d, s) \ > > Signed-off-by

Re: [PATCH v2 09/20] staging: rtl8723bs: put parentheses on macros with complex values in include/rtw_debug.h

2021-03-28 Thread Greg KH
On Sat, Mar 27, 2021 at 03:24:08PM +0100, Fabio Aiuto wrote: > fix the following checkpatch warning: > > ERROR: Macros starting with if should be enclosed by a > do - while loop to avoid possible if/else logic defects > + #define RT_PRINT_DATA(_Comp, _Level, > _TitleString, _HexData, _He

Re: [PATCH v4 1/2] char: xillybus: Move class-related functions to new xillybus_class.c

2021-03-28 Thread Greg KH
On Tue, Mar 23, 2021 at 02:05:23PM +0200, Eli Billauer wrote: > On 22/03/21 13:11, Greg KH wrote: > > > > > XILLYBUS and XILLYBUS_PCIE are currently enabled as M in several Linux > > > distributions. Making them depend on, rather than select XILLYBUS_CLASS is > >

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 01:11:30PM +0200, Daniel Lezcano wrote: > > Hi Greg, > > On 28/03/2021 08:50, Greg KH wrote: > > [ ... ] > > >>> And any reason why you are not using "real" struct devices in this > >>> subsystem? You seem to be r

Re: [1/5] reporting-issues: header and TLDR

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 11:23:30AM +0200, Thorsten Leemhuis wrote: > On 26.03.21 07:15, Thorsten Leemhuis wrote: > > On 26.03.21 07:13, Thorsten Leemhuis wrote: > >> > >> Lo! Since a few months mainline in > >> Documentation/admin-guide/reporting-issues.rst contains a text written > >> to obsolete

Re: [PATCH] tty: fix memory leak in vc_deallocate

2021-03-28 Thread Greg KH
On Sun, Mar 28, 2021 at 12:44:43AM +0300, Pavel Skripkin wrote: > syzbot reported memory leak in tty/vt. > The problem was in VT_DISALLOCATE ioctl cmd. > After allocating unimap with PIO_UNIMAP it wasn't > freed via VT_DISALLOCATE, but vc_cons[currcons].d was > zeroed. > > Signed-off-by: Pavel Skr

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

2021-03-27 Thread Greg KH
On Sat, Mar 27, 2021 at 08:41:24PM +0100, Daniel Lezcano wrote: > On 27/03/2021 13:50, Greg KH wrote: > > On Fri, Mar 12, 2021 at 02:04:08PM +0100, Daniel Lezcano wrote: > >> A SoC can be differently structured depending on the platform and the > >> kernel can not be aw

Re: [Patch v3] usb: dwc3: add cancelled reasons for dwc3 requests

2021-03-27 Thread Greg KH
On Sat, Mar 27, 2021 at 09:22:02PM +0800, Ray Chi wrote: > Currently, when dwc3 handles request cancelled, dwc3 just returns > -ECONNRESET for all requests. It will cause USB function drivers > can't know if the requests are cancelled by other reasons. > > This patch will replace DWC3_REQUEST_STAT

Re: [PATCH v4 2/5] powercap/drivers/dtpm: Create a registering system

2021-03-27 Thread Greg KH
On Fri, Mar 12, 2021 at 02:04:08PM +0100, Daniel Lezcano wrote: > A SoC can be differently structured depending on the platform and the > kernel can not be aware of all the combinations, as well as the > specific tweaks for a particular board. > > The creation of the hierarchy must be delegated to

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-27 Thread Greg KH
On Fri, Mar 26, 2021 at 02:09:36PM -0700, Don Bollinger wrote: > > You keep missing the point. I always refer to the KAPI. The driver we can > > rework and rework, throw away and reimplement, as much as we want. > > The KAPI cannot be changed, it is ABI. It is pretty much frozen the day > the > > c

Re: [GIT PULL] interconnect fixes for 5.12-rc

2021-03-27 Thread Greg KH
On Fri, Mar 26, 2021 at 06:46:03PM +0200, Georgi Djakov wrote: > Hello Greg, > > Here is a pull request with a few tiny interconnect fixes for 5.12-rc. > The details are in the signed tag. Please take them into char-misc-linus > when possible. The patches have been in linux-next for more than a we

Re: [PATCH v3 6/9] debugfs: Implement debugfs_create_str()

2021-03-27 Thread Greg KH
On Fri, Mar 26, 2021 at 03:50:00PM +0100, Peter Zijlstra wrote: > Subject: debugfs: Implement debugfs_create_str() > From: Peter Zijlstra > Date: Thu Mar 25 10:53:55 CET 2021 > > Implement debugfs_create_str() to easily display names and such in > debugfs. > > Signed-off-by: Peter Zijlstra (Inte

Re: [PATCH v2 6/9] debugfs: Implement debugfs_create_str()

2021-03-27 Thread Greg KH
On Fri, Mar 26, 2021 at 04:19:12PM +0100, Peter Zijlstra wrote: > On Fri, Mar 26, 2021 at 03:58:37PM +0100, Rasmus Villemoes wrote: > > > kmalloc(len + 2, ...); > > > > No, because nul-terminating the stuff you pass to > > simple_read_from_buffer is pointless cargo-culting. Yeah, read_file_bool

Re: Candidate Linux ABI for Intel AMX and hypothetical new related features

2021-03-27 Thread Greg KH
On Fri, Mar 26, 2021 at 11:39:18PM -0400, Len Brown wrote: > Hi Andy, > > Say a mainline links with a math library that uses AMX without the > knowledge of the mainline. What does this mean? What happened to the context here? > Say the mainline is also linked with a userspace threading library

Re: [PATCH] Fixes: 65f183001f6e (staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_INTERRUPT_BASED_TXBCN*)

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 04:52:52PM +0100, Fabio Aiuto wrote: > fix indentation broken by patch removing conditional > code blocks checked by unused > CONFIG_INTERRUPT_BASED_TXBCN family defines > > https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiut...@gmail

Re: [PATCH v2 6/9] debugfs: Implement debugfs_create_str()

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 03:12:35PM +0100, Peter Zijlstra wrote: > On Fri, Mar 26, 2021 at 02:10:41PM +0100, Rasmus Villemoes wrote: > > On 26/03/2021 13.57, Greg KH wrote: > > > On Fri, Mar 26, 2021 at 01:53:59PM +0100, Rasmus Villemoes wrote: > > >> On 26/03/20

Re: [PATCH] staging: fbtft: change '16 bit' to '16-bit'

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 10:09:30PM +0800, Carlis wrote: > From: "carlis.zhang_cp" > > Change '16 bit' to '16-bit' for a same style. Why? This is up to the author. > > Signed-off-by: carlis.zhang_cp Please use a real name, not an email-alias as a name. thanks, greg k-h

Re: [PATCH -next] staging: rtl8723bs: core: fix error return

2021-03-26 Thread Greg KH
On Thu, Mar 25, 2021 at 04:30:41PM +0800, Xu Jia wrote: > Function rtw_init_bcmc_stainfo() is always return success. > Variable 'ret' set but not used. > > Reported-by: Hulk Robot > Signed-off-by: Xu Jia > --- > drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +- > 1 file changed, 1 insertion(

Re: [PATCH 04/15] staging: rtl8723bs: put parentheses on macros with complex values in include/basic_types.h

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 12:12:42PM +0100, Fabio Aiuto wrote: > On Fri, Mar 26, 2021 at 01:04:08PM +0300, Dan Carpenter wrote: > > On Fri, Mar 26, 2021 at 10:09:11AM +0100, Fabio Aiuto wrote: > > > fix the following checkpatch warnings: > > > > > > ERROR: Macros with complex values should be enclos

Re: [PATCH] staging: rtl8723bs: fix indentation broken by previous patch

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 10:17:16AM +0100, Fabio Aiuto wrote: > fix indentation broken by patch removing conditional > code blocks checked by unused > CONFIG_INTERRUPT_BASED_TXBCN family defines > > https://lore.kernel.org/r/9157000821fd6febf25566b8c712fad1995c7c78.1615907632.git.fabioaiut...@gmail

Re: [PATCH resend] jfs: fix use-after-free in lbmIODone

2021-03-26 Thread Greg KH
On Mon, Mar 22, 2021 at 09:41:47PM +0530, Anirudh Rayabharam wrote: > Fix use-after-free by waiting for ongoing IO to complete before freeing > lbufs in lbmLogShutdown. Add a counter in struct jfs_log to keep track > of the number of in-flight IO operations and a wait queue to wait on for > the IO

Re: [PATCH v2] staging: fbtft: fix a typo

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 08:55:51PM +0800, Carlis wrote: > From: Xuezhi Zhang > > Change 'tft' to 'TFT' That says what you did, but not _why_ you did it. And this is not a "typo", as it is not misspelled and really is just fine as-is. thanks, greg k-h

Re: [PATCH v2 6/9] debugfs: Implement debugfs_create_str()

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 01:53:59PM +0100, Rasmus Villemoes wrote: > On 26/03/2021 12.38, Peter Zijlstra wrote: > > > Implement debugfs_create_str() to easily display names and such in > > debugfs. > > Patches 7-9 don't seem to add any users of this. What's it for precisely? It's used in patch 7,

Re: [PATCH v2 6/9] debugfs: Implement debugfs_create_str()

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 12:38:39PM +0100, Peter Zijlstra wrote: > On Fri, Mar 26, 2021 at 12:30:24PM +0100, Greg KH wrote: > > Great, change that and limit the size of the string that can be written > > and it looks good to me, thanks for adding this. > > Here goes.. Great,

Re: [PATCH 6/9] debugfs: Implement debugfs_create_str()

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 12:18:47PM +0100, Peter Zijlstra wrote: > On Fri, Mar 26, 2021 at 12:05:07PM +0100, Greg KH wrote: > > On Fri, Mar 26, 2021 at 11:33:58AM +0100, Peter Zijlstra wrote: > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > > > N

Re: [PATCH 4/9] sched: Move SCHED_DEBUG to debugfs

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 11:33:56AM +0100, Peter Zijlstra wrote: > Stop polluting sysctl with undocumented knobs that really are debug > only, move them all to /debug/sched/ along with the existing > /debug/sched_* files that already exist. > > Signed-off-by: Peter Zijlstra (Intel) > --- > includ

Re: [PATCH 8/9] sched: Move /proc/sched_debug to debugfs

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 11:34:00AM +0100, Peter Zijlstra wrote: > > Signed-off-by: Peter Zijlstra (Intel) > --- > kernel/sched/debug.c | 25 - > 1 file changed, 16 insertions(+), 9 deletions(-) Yes! Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 6/9] debugfs: Implement debugfs_create_str()

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 11:33:58AM +0100, Peter Zijlstra wrote: > > Signed-off-by: Peter Zijlstra (Intel) No changelog text? :( > +/** > + * debugfs_create_str - create a debugfs file that is used to read and write > a string value > + * @name: a pointer to a string containing the name of the

Re: [PATCH] staging: fbtft: fix a typo

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 05:16:34PM +0800, carlis wrote: > On Fri, 26 Mar 2021 09:37:48 +0100 > Greg KH wrote: > > > On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote: > > > From: "Carlis" > > > > > > Change 'tft' to &

Re: [Ksummit-discuss] FYI & RFC: obsoleting reporting-bugs and making reporting-issues official

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 07:13:09AM +0100, Thorsten Leemhuis wrote: > > Lo! Since a few months mainline in > Documentation/admin-guide/reporting-issues.rst contains a text written > to obsolete the good old reporting-bugs text. For now, the new document > still contains a warning at the top that ba

Re: [Ksummit-discuss] [2/5] reporting-issues: step-by-step-guide: main and two sub-processes for stable/longterm

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 07:16:40AM +0100, Thorsten Leemhuis wrote: > On 26.03.21 07:13, Thorsten Leemhuis wrote: > > Lo! Since a few months mainline in > > Documentation/admin-guide/reporting-issues.rst contains a text written > > to obsolete the good old reporting-bugs text. For now, the new docum

Re: [PATCH] staging: fbtft: fix a typo

2021-03-26 Thread Greg KH
On Fri, Mar 26, 2021 at 04:05:15PM +0800, Carlis wrote: > From: "Carlis" > > Change 'tft' to 'TFT' Why? What is wrong with "tft"? > > Signed-off-by: Carlis Full name please. thanks, greg k-h

Re: [PATCH] media: sq905.c: fix uninitialized variable

2021-03-26 Thread Greg KH
On Thu, Mar 25, 2021 at 11:22:02PM +0200, Alaa Emad wrote: > Reported-by: syzbot+a4e309017a5f3a24c...@syzkaller.appspotmail.com > Signed-off-by: Alaa Emad > --- I know I do not take patches with no changelog text, but other maintainers might be more leniant :( thanks, greg k-h

Re: [PATCH] media: uvcvideo: Fix pixel format change for Elgato Cam Link 4K

2021-03-26 Thread Greg KH
On Thu, Mar 25, 2021 at 10:34:59PM +0100, Benjamin Drung wrote: > The Elgato Cam Link 4K HDMI video capture card reports to support three > different pixel formats, where the first format depends on the connected > HDMI device. > > ``` > $ v4l2-ctl -d /dev/video0 --list-formats-ext > ioctl: VIDIOC

Re: [PATCH] staging: gasket: remove it from the kernel

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 03:46:10PM +0100, Jan Kiszka wrote: > On 15.03.21 17:10, Rob Springer wrote: > > Acked-by: Rob Springer > > > > > > On Mon, Mar 15, 2021 at 8:44 AM wrote: > >> > >> From: Greg Kroah-Hartman > >> > >> As none of the proposed things that need to be changed in the gasket >

Re: [RFC PATCH] USB:XHCI:Adjust the log level of hub

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 09:33:53PM +0800, liulongfang wrote: > On 2021/3/25 18:31, Greg KH wrote: > > On Thu, Mar 25, 2021 at 06:04:12PM +0800, Longfang Liu wrote: > >> When the number of ports of the hub is not between 1 and Maxports, > >> it will only exit the reg

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 07:03:39PM +0800, Jian Dong wrote: > On Thu, 25 Mar 2021 11:29:06 +0100 > Greg KH wrote: > > > On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > > > From: Jian Dong > > > > > > fixes coccicheck Error: > > >

Re: [RFC PATCH] USB:XHCI:Adjust the log level of hub

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 06:04:12PM +0800, Longfang Liu wrote: > When the number of ports of the hub is not between 1 and Maxports, > it will only exit the registration of the hub on the current controller, > but it will not affect the function of the controller itself. Its other > hubs can operate

Re: [PATCH] staging: greybus: fix fw is NULL but dereferenced

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 06:19:26PM +0800, Jian Dong wrote: > From: Jian Dong > > fixes coccicheck Error: > > drivers/staging/greybus/bootrom.c:301:41-45: ERROR: > fw is NULL but dereferenced. > > if procedure goto label directly, ret will be nefative, so the fw is NULL > and the if(conditi

Re: [PATCH v2] uacce: delete not be needed variable initialization

2021-03-25 Thread Greg KH
On Thu, Mar 25, 2021 at 03:18:49PM +0800, Kai Ye wrote: > delete not be needed variable initialization. I am sorry, but I can not parse this sentence. Can you try resending this with a better description? > Signed-off-by: Kai Ye > --- > drivers/misc/uacce/uacce.c | 2 +- > 1 file changed, 1 in

Re: [PATCH] tools: usbip: list.h: fix kernel-doc for list_del()

2021-03-24 Thread Greg KH
On Wed, Mar 24, 2021 at 06:35:01PM -0700, Randy Dunlap wrote: > On 3/24/21 4:32 PM, Shuah Khan wrote: > > On 3/23/21 6:02 PM, Randy Dunlap wrote: > >> In list.h, the kernel-doc for list_del() should be immediately > >> preceding the implementation and not separated from it by > >> another function

Re: [PATCH] soundwire: intel: move to auxiliary bus

2021-03-24 Thread Greg KH
On Wed, Mar 24, 2021 at 09:55:01AM -0500, Pierre-Louis Bossart wrote: > Note at this point it would mean an API change and impact the existing > Nvidia/Mellanox code, we are using the same sequence as them THere is no "stable api" in the kernel, so if something has to change, that's fine, we can c

Re: [PATCH 5.4 00/24] 5.4.105-rc1 review

2021-03-24 Thread Greg KH
gt; >> Hi Florian, > >> > >>> On 3/11/21 9:40 AM, Greg KH wrote: > >>>> On Thu, Mar 11, 2021 at 09:23:56AM -0800, Florian Fainelli wrote: > >>>>> On 3/11/21 5:08 AM, Greg KH wrote: > >>>>>> On Wed, Mar 10, 2021 at 08:19:4

Re: [PATCH] misc: rtsx: check the value returned from a function for errors before being used

2021-03-24 Thread Greg KH
On Wed, Mar 24, 2021 at 06:05:58PM +0800, Yang Li wrote: > Add missing return value check in pm_runtime_get disabling the > sensor. The issue is reported by coverity with the following error: > > Medium:Unchecked return value(CHECKED_RETURN) > CWE252: Value returned from a function is not checked

Re: [PATCH] soundwire: intel: move to auxiliary bus

2021-03-24 Thread Greg KH
On Tue, Mar 23, 2021 at 02:14:18PM -0500, Pierre-Louis Bossart wrote: > > > On 3/23/21 1:32 PM, Greg KH wrote: > > On Tue, Mar 23, 2021 at 01:04:49PM -0500, Pierre-Louis Bossart wrote: > > > > > > > > Note that the auxiliary bus API has separate init and a

Re: [PATCH] drivers:staging: NULL check before some freeing functions is not needed.

2021-03-24 Thread Greg KH
On Wed, Mar 24, 2021 at 04:41:26PM +0800, Zhichao Cai wrote: > From: Zhichao Cai > > Fixes coccicheck warning: > drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c:390:2-8: > WARNING: NULL check before some freeing functions is not needed. > drivers/staging/media/atom

Re: [PATCH] uacce: fixup coding style

2021-03-24 Thread Greg KH
On Wed, Mar 24, 2021 at 04:11:55PM +0800, Kai Ye wrote: > delete invalid and redundant variable initialization. Why is it "invalid"? Seems to just not be needed. And this isn't a coding style issue, your subject line is incorrect :( thanks, greg k-h

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-24 Thread Greg KH
On Tue, Mar 23, 2021 at 04:10:27PM +, Catangiu, Adrian Costin wrote: > Hi Greg, > > After your previous reply on this thread we started considering to provide > this interface and framework/functionality through a userspace service > instead of a kernel interface. > The latest iteration on t

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-23 Thread 'Greg KH'
On Tue, Mar 23, 2021 at 12:08:32PM -0700, Don Bollinger wrote: > On Tue, Mar 23, 2021 at 12:00AM -0700, Greg KH wrote: > > On Tue, Mar 23, 2021 at 11:43:55AM -0700, Don Bollinger wrote: > > > On Tue, Mar 23, 2021 at 7:12AM-0700, Greg KH wrote: > > > > On Mon, Feb 15,

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-23 Thread 'Greg KH'
On Tue, Mar 23, 2021 at 11:43:55AM -0700, Don Bollinger wrote: > On Tue, Mar 23, 2021 at 7:12AM-0700, Greg KH wrote: > > On Mon, Feb 15, 2021 at 11:38:21AM -0800, Don Bollinger wrote: > > > optoe is an i2c based driver that supports read/write access to all > > >

Re: [PATCH] soundwire: intel: move to auxiliary bus

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 01:04:49PM -0500, Pierre-Louis Bossart wrote: > > > > Note that the auxiliary bus API has separate init and add steps, which > > > requires more attention in the error unwinding paths. The main loop > > > needs to deal with kfree() and auxiliary_device_uninit() for the > >

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 04:10:27PM +, Catangiu, Adrian Costin wrote: > Hi Greg, > > After your previous reply on this thread we started considering to provide > this interface and framework/functionality through a userspace service > instead of a kernel interface. > The latest iteration on t

Re: [PATCH v7 1/3] misc/pvpanic: split-up generic and platform dependent code

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 03:59:36PM +0200, Mihai Carabas wrote: > Split-up generic and platform dependent code in order to be able to re-use > generic event handling code in pvpanic PCI device driver in the next patches. > > The code from pvpanic.c was split in two new files: > - pvpanic.c: generic

Re: [PATCH] USB: DWC2: Add VBUS overcurrent detection control.

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 11:24:26PM +0800, 周琰杰 (Zhou Yanjie) wrote: > Introduce configurable option for enabling GOTGCTL register > bits VbvalidOvEn and VbvalidOvVal. Once selected it disables > VBUS overcurrent detection. > > This patch is derived from Dragan Čečavac (in the kernel 3.18 > tree of

Re: [PATCH] PM / EM: postpone creating the debugfs dir till fs_initcall

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 02:56:08PM +, Lukasz Luba wrote: > The debugfs directory '/sys/kernel/debug/energy_model' is needed before > the Energy Model registration can happen. With the recent change in > debugfs subsystem it's not allowed to create this directory at early stage > (core_initcall)

Re: [PATCH v3 2/8] MAINTAINERS: Add entry for devm helpers

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 02:58:28PM +0100, Hans de Goede wrote: > Hi, > > On 3/23/21 2:56 PM, Matti Vaittinen wrote: > > Devm helper header containing small inline helpers was added. > > Hans promised to maintain it. > > > > Add Hans as maintainer and myself as designated reviewer. > > > > Signed

Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS EEPROMS

2021-03-23 Thread Greg KH
On Mon, Feb 15, 2021 at 11:38:21AM -0800, Don Bollinger wrote: > optoe is an i2c based driver that supports read/write access to all > the pages (tables) of MSA standard SFP and similar devices (conforming > to the SFF-8472 spec), MSA standard QSFP and similar devices (conforming > to the SFF-8636

Re: [PATCH] base: dd: fix error return code of driver_sysfs_add()

2021-03-23 Thread Greg KH
On Fri, Mar 05, 2021 at 02:24:05AM -0800, Jia-Ju Bai wrote: > When device_create_file() fails and returns a non-zero value, > no error return code of driver_sysfs_add() is assigned. > To fix this bug, ret is assigned with the return value of > device_create_file(), and then ret is checked. > > Re

Re: [PATCH] usb: dwc3: fix build error when POWER_SUPPLY is not enabled

2021-03-23 Thread Greg KH
On Fri, Mar 12, 2021 at 09:57:56PM +0800, Ray Chi wrote: > Hi Sebastian, > > Sorry for the late reply. > > On Wed, Mar 10, 2021 at 2:58 AM Sebastian Reichel wrote: > > > > Hi, > > > > On Mon, Mar 08, 2021 at 09:31:46PM +0800, Ray Chi wrote: > > > Fix build error when CONFIG_POWER_SUPPLY is not e

Re: [PATCH 0/4] nfc: fix Resource leakage and endless loop

2021-03-23 Thread Greg KH
On Wed, Mar 03, 2021 at 02:16:50PM +0800, Xiaoming Ni wrote: > fix Resource leakage and endless loop in net/nfc/llcp_sock.c, > reported by "kiyin(尹亮)". > > Link: https://www.openwall.com/lists/oss-security/2020/11/01/1 What happened to this series? Does it need to be resent against the latest n

Re: [PATCH] drivers: android: binder.c: Fix indentation of multi-line comment

2021-03-23 Thread Greg KH
On Sat, Mar 13, 2021 at 09:46:55PM +0530, Abhishek C wrote: > Fixed alignment of multi-line comment. > Added a * for each line of the comment. > > Signed-off-by: Abhishek C > --- > drivers/android/binder.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers

Re: [PATCH v2 0/9] fix extern declarations checkpatch issues

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 01:56:27PM +0100, Fabio Aiuto wrote: > Fix extern declaration issues warned by checkpatch. Nit, we have a new mailing list, you might want to use that now instead of driverdev in the future, thanks! greg k-h

Re: [PATCH v8] drivers/misc: sysgenid: add system generation id driver

2021-03-23 Thread Greg KH
On Mon, Mar 08, 2021 at 05:03:58PM +0100, Alexander Graf wrote: > > > On 08.03.21 15:36, Greg KH wrote: > > > > On Mon, Mar 08, 2021 at 04:18:03PM +0200, Adrian Catangiu wrote: > > > +static struct miscdevice sysgenid_misc = { > > > + .minor

Re: [PATCH 1/2] drivers: misc: kgdbts.c: Fix declaration warning.

2021-03-23 Thread Greg KH
On Sun, Mar 14, 2021 at 03:28:08AM +0530, Shubhankar Kuranagatti wrote: > A new line has been added after declaration. This is done to > maintain code uniformity. > > Signed-off-by: Shubhankar Kuranagatti > --- > drivers/misc/kgdbts.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/

Re: [RFC RESEND PATCH v2 0/8] Add managed version of delayed work init

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 09:41:13AM +0200, Matti Vaittinen wrote: > It's not rare that device drivers need delayed work. > It's not rare that this work needs driver's data. I don't normally comment on "RFC" patch series as I can't take them and the submitter doesn't feel right with them being merge

Re: [PATCH v6 1/3] misc/pvpanic: split-up generic and platform dependent code

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 06:44:25PM +0200, Mihai Carabas wrote: > Split-up generic and platform dependent code in order to be able to re-use > generic event handling code in pvpanic PCI device driver in the next patches. > > The code from pvpanic.c was split in two new files: > - pvpanic.c: generic

Re: [PATCH v3] tty:serial: fix spelling typo of values

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 07:53:27PM +0800, caizhichao wrote: > From: caizhichao > > vaules -> values > > Signed-off-by: Zhichao Cai > --- > v3: use full name and capitalize personal name. But now your From: and Signed-off-by: lines do not match :( Trivial patches are best learned in the driver

Re: [PATCH v4 2/2] usb: dwc3: Add driver for Xilinx platforms

2021-03-23 Thread Greg KH
On Wed, Mar 17, 2021 at 05:50:22PM +0800, kernel test robot wrote: > Hi Manish, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on usb/usb-testing] > [also build test WARNING on robh/for-next v5.12-rc3 next-20210316] > [If your patch is applied to the wrong

Re: [PATCH resend] usb: gadget: legacy: fix error return code of msg_bind()

2021-03-23 Thread Greg KH
On Sun, Mar 07, 2021 at 12:52:19AM -0800, Jia-Ju Bai wrote: > When usb_otg_descriptor_alloc() returns NULL to usb_desc, no error > return code of msg_bind() is assigned. > To fix this bug, status is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot > You have 2 '>' on the end of thi

Re: [PATCH] usb: gadget: legacy: fix error return code of msg_bind()

2021-03-23 Thread Greg KH
On Sun, Mar 07, 2021 at 12:49:15AM -0800, Jia-Ju Bai wrote: > When usb_otg_descriptor_alloc() returns NULL to usb_desc, no error > return code of msg_bind() is assigned. > To fix this bug, status is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot Reported-by: TOTE Robot > These l

Re: [PATCH resend] tty:serial: fix spelling typo of values

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 06:25:56PM +0800, caizhichao wrote: > From: zhichao Cai > > vaules -> values > > Signed-off-by: zhichao Cai Please capitalize your name. > --- > drivers/tty/serial/8250/8250_mtk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) What changed from the first ver

Re: [PATCH] driver core: Use unbound workqueue for deferred probes

2021-03-23 Thread Greg KH
On Mon, Mar 15, 2021 at 04:15:12PM +0530, Yogesh Lal wrote: > > > On 2/25/2021 5:14 PM, Greg KH wrote: > > On Thu, Feb 25, 2021 at 04:03:50PM +0530, Yogesh Lal wrote: > > > Hi Greg, > > > > > > > > > On 2/24/2021 6:13 PM, Greg KH wrote: >

Re: [PATCH v2] usb: Add a lock when freeing data in usbtmc_disconnect

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 02:28:54AM -0700, Lv Yunlong wrote: > In usbtmc_disconnect, data is got from intf with the initial reference. > There is no refcount inc operation before usbmc_free_int(data). In > usbmc_free_int(data), the data may be freed. > > But later in usbtmc_disconnect, there is ano

Re: [PATCH] tty:serial: fix spelling typo of values

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 05:28:46PM +0800, caizhichao wrote: > From: caizhichao > > vaules -> values > > Signed-off-by: caizhichao Please use your "full" name here. thanks, greg k-h

Re: [PATCH 3/3] w1: ds2438: adding support for accessing page1 registers

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 11:44:10PM -0300, Luiz Sampaio wrote: > @@ -395,6 +483,8 @@ static BIN_ATTR_RO(vdd, 0/* real length varies */); > static struct bin_attribute *w1_ds2438_bin_attrs[] = { > &bin_attr_iad, > &bin_attr_page0, > + &bin_attr_page1, > + &bin_attr_offset, You a

Re: [PATCH 0/3] w1: ds2438: adding support for calibration of current measurements

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 11:40:37PM -0300, Luiz Sampaio wrote: > The following patches aim to make a user able to calibrate the current > measurement of the ds2438. This chip uses a offset register in page1, which > is added to the current register to give the user the current measurement. If > t

Re: [PATCH V3 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 04:34:28PM +0530, Roja Rani Yarubandi wrote: > This reverts commit 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect > support to fix earlycon crash") > > ICC core and platforms drivers supports sync_state feature with > commit 7d3b0b0d8184 ("interconnect: qcom: Use icc_sy

Re: [PATCH] staging: rtl8723bs: Trivial typo fix

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 06:38:35AM +0530, Bhaskar Chowdhury wrote: > > s/netowrk/network/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c >

Re: [PATCH] soundwire: intel: move to auxiliary bus

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 12:18:46PM +0530, Vinod Koul wrote: > On 23-03-21, 08:43, Bard Liao wrote: > > From: Pierre-Louis Bossart > > > > Now that the auxiliary_bus exists, there's no reason to use platform > > devices as children of a PCI device any longer. > > > > This patch refactors the code

Re: [PATCH] soundwire: intel: move to auxiliary bus

2021-03-23 Thread Greg KH
On Tue, Mar 23, 2021 at 08:43:25AM +0800, Bard Liao wrote: > From: Pierre-Louis Bossart > > Now that the auxiliary_bus exists, there's no reason to use platform > devices as children of a PCI device any longer. > > This patch refactors the code by extending a basic auxiliary device > with Intel

Re: [PATCH] X86: __set_clr_pte_enc() miscalculates physical address

2021-03-23 Thread Greg KH
On Mon, Mar 22, 2021 at 04:02:11PM -0500, Tom Lendacky wrote: > On 3/18/21 3:26 PM, Isaku Yamahata wrote: > > __set_clr_pte_enc() miscalculates physical address to operate. > > pfn is in unit of PG_LEVEL_4K, not PGL_LEVEL_{2M, 1G}. > > Shift size to get physical address should be PAGE_SHIFT, > > no

<    1   2   3   4   5   6   7   8   9   10   >