Re: [PATCH] staging: gasket: fix indentation and lines ending with open parenthesis

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 07:39:28PM +0530, Mahak Gupta wrote: > This patch fixes warnings of 'checkpatch.pl'. According to > Linux coding guidelines, code should be aligned properly to > match with open parenthesis and lines should not end with > open parenthesis. > > Signed-off-by: Mahak Gupta >

Re: [PATCH v3] staging: emxx_udc: Make incorrectly defined global static

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 02:29:12PM +0530, Kumar Kartikeya Dwivedi wrote: > The global gpio_desc pointer and int vbus_irq were defined in the header, > instead put the definitions in the translation unit and make them static as > there's only a single consumer, and these symbols shouldn't pollute th

Re: [PATCH v2] staging: emxx_udc: Make incorrectly defined global static

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 02:16:58PM +0530, Kumar Kartikeya Dwivedi wrote: > The global gpio_desc pointer and int vbus_irq were defined in the header, > instead put the definitions in the translation unit and make them static as > there's only a single consumer, and these symbols shouldn't pollute th

Re: [PATCH] staging: gasket: Align code to match with open parenthesis and fix the lines ending with open parenthesis

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 01:11:36PM +0530, Mahak gupta wrote: > This patch fixes warnings of checkpatch.pl. According to the coding style > of linux, code should be aligned properly to match with open parenthesis > and lines should not end with open parenthesis. > > Signed-off-by: mhk19 > --- > d

Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 01:08:27PM +0530, Kumar Kartikeya Dwivedi wrote: > On Sun, Feb 07, 2021 at 12:04:41PM IST, Stephen Rothwell wrote: > > > > Given that drivers/staging/emxx_udc/emxx_udc.h is only included by > > drivers/staging/emxx_udc/emxx_udc.c, shouldn't these variables just be > > decla

Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global

2021-02-07 Thread Greg KH
On Sun, Feb 07, 2021 at 05:30:31AM +0530, Kumar Kartikeya Dwivedi wrote: > The global gpio_desc pointer and int were defined in the header, > instead put the definitions in the translation unit and add an extern > declaration for consumers of the header (currently only one, which is > perhaps why t

[GIT PULL] USB driver fixes for 5.11-rc7

2021-02-06 Thread Greg KH
The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04: Linux 5.11-rc5 (2021-01-24 16:47:14 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.11-rc7 for you to fetch changes up to f670e9f9c8cac716c3506

Re: [PATCH 3/3] kbuild: introduce KERNEL_VERSION2 and LINUX_VERSION_CODE2

2021-02-06 Thread Greg KH
On Fri, Feb 05, 2021 at 10:50:33PM -0500, Sasha Levin wrote: > SUBLEVEL only has 8 bits of space, which means that we'll overflow it > once it reaches 256. > > Few of the stable branches will imminently overflow SUBLEVEL while > there's no risk of overflowing VERSION. > > Thus, give SUBLEVEL 8 mo

Re: [PATCH 3/3] kbuild: introduce KERNEL_VERSION2 and LINUX_VERSION_CODE2

2021-02-06 Thread Greg KH
On Fri, Feb 05, 2021 at 10:50:33PM -0500, Sasha Levin wrote: > SUBLEVEL only has 8 bits of space, which means that we'll overflow it > once it reaches 256. > > Few of the stable branches will imminently overflow SUBLEVEL while > there's no risk of overflowing VERSION. > > Thus, give SUBLEVEL 8 mo

Re: [PATCH 2/3] kbuild: clamp SUBLEVEL to 255

2021-02-06 Thread Greg KH
On Fri, Feb 05, 2021 at 10:50:32PM -0500, Sasha Levin wrote: > Right now if SUBLEVEL becomes larger than 255 it will overflow into the > territory of PATCHLEVEL, causing havoc in userspace that tests for > specific kernel version. > > While userspace code tests for MAJOR and PATCHLEVEL, it doesn't

Re: [PATCH v3 1/7] seqnum_ops: Introduce Sequence Number Ops

2021-02-05 Thread Greg KH
On Wed, Feb 03, 2021 at 11:11:57AM -0700, Shuah Khan wrote: > +static inline u32 seqnum32_inc(struct seqnum32 *seq) > +{ > + atomic_t val = ATOMIC_INIT(seq->seqnum); > + > + seq->seqnum = (u32) atomic_inc_return(&val); > + if (seq->seqnum >= UINT_MAX) > + pr_info("Sequence N

Re: [PATCH v2 1/2] ima: Free IMA measurement buffer on error

2021-02-05 Thread Greg KH
On Thu, Feb 04, 2021 at 09:49:50AM -0800, Lakshmi Ramasubramanian wrote: > IMA allocates kernel virtual memory to carry forward the measurement > list, from the current kernel to the next kernel on kexec system call, > in ima_add_kexec_buffer() function. In error code paths this memory > is not fr

Re: [PATCH v2 2/2] ima: Free IMA measurement buffer after kexec syscall

2021-02-05 Thread Greg KH
On Thu, Feb 04, 2021 at 09:49:51AM -0800, Lakshmi Ramasubramanian wrote: > IMA allocates kernel virtual memory to carry forward the measurement > list, from the current kernel to the next kernel on kexec system call, > in ima_add_kexec_buffer() function. This buffer is not freed before > completin

Re: [GIT PULL] interconnect changes for 5.12

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 11:52:46AM +0200, Georgi Djakov wrote: > Hello Greg, > > This is the pull request with the interconnect changes for the 5.12-rc1 > merge window. These include two new drivers some driver consolidation. > > Patches have been in linux-next without any reported issues. Please

Re: [PATCH v24 07/14] mm/damon: Implement a debugfs-based user space interface

2021-02-05 Thread Greg KH
On Thu, Feb 04, 2021 at 04:31:43PM +0100, SeongJae Park wrote: > From: SeongJae Park > > DAMON is designed to be used by kernel space code such as the memory > management subsystems, and therefore it provides only kernel space API. > That said, letting the user space control DAMON could provide s

Re: [GIT PULL] MHI changes for v5.12

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 06:31:41PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > Here is the MHI Pull request for the v5.12 cycle. As like last time, I needed > to > do PR this time due to the immutable branches with net-next and ath11k-next. > > Patch details are in the signed tag, please

Re: [PATCH v7 00/14] Tegra XHCI controller ELPG support

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 05:15:21PM +0100, Thierry Reding wrote: > On Wed, Jan 20, 2021 at 03:34:00PM +0800, JC Kuo wrote: > > Tegra XHCI controler can be placed in ELPG (Engine Level PowerGated) > > state for power saving when all of the connected USB devices are in > > suspended state. This patch

Re: [PATCH 0/2] nvmem: patches (set 2) for 5.12

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 10:08:51AM +, Srinivas Kandagatla wrote: > Hi Greg, > > Here are some last nvmem patches (set 2) for 5.12 which includes > - fixing a typo in Kconfig > - a fix of uninitialized pointer > > If its not too late, Can you please queue them up for 5.12. Now merged, thanks!

Re: [PATCH 4/4] staging: comedi: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 05:44:15PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. Again, explain _why_. Please read the section entitled "The canonical patch format" in the ke

Re: [PATCH 1/4] driver core: Use subdir-ccflags-* to inherit debug flag

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 05:44:12PM +0800, Yicong Yang wrote: > From: Junhao He > > Use subdir-ccflags-* instead of ccflags-* to inherit the debug > settings from Kconfig when traversing subdirectories. That says what you do, but not _why_ you are doing it. What does this offer in benefit of the

Re: [PATCH] staging: fbtft replaced udelay with usleep_range

2021-02-05 Thread Greg KH
On Fri, Feb 05, 2021 at 02:41:13PM +0530, Mayank Suman wrote: > According to Documentation/timers/timers-howto.rst, usleep_range is > preffered over udelay for >=10us delay. > > Signed-off-by: Mayank Suman ALWAYS test build your patches before sending them out to the world for review. You don't

Re: [GIT PULL] Fix for cros_ec_typec for USB for v5.12 merge window

2021-02-05 Thread Greg KH
On Thu, Feb 04, 2021 at 11:24:59AM -0800, Benson Leung wrote: > Hi Greg, > > I found a bug in the typec driver you pulled earlier this week > and Prashant developed a fix. > > The following changes since commit 64eaa0fa66ac55965f793a8b65730299854e55cd: > > platform/chrome: cros_ec_typec: Fix c

Re: Linux 5.11-rc5

2021-02-04 Thread Greg KH
On Thu, Feb 04, 2021 at 10:32:56AM -0800, Linus Torvalds wrote: > On Thu, Feb 4, 2021 at 10:19 AM Mike Rapoport wrote: > > > > On Mon, Jan 25, 2021 at 12:49:39PM -0800, Linus Torvalds wrote: > > > > > > Mike: should we perhaps revert the first patch too (commit > > > bde9cfa3afe4: "x86/setup: don'

Re: Kernel version numbers after 4.9.255 and 4.4.255

2021-02-04 Thread Greg KH
On Thu, Feb 04, 2021 at 09:19:33PM +0100, Christoph Biedl wrote: > David Laight wrote... > > > A full wrap might catch checks for less than (say) 4.4.2 which > > might be present to avoid very early versions. > > So sticking at 255 or wrapping onto (say) 128 to 255 might be better. > > Hitting su

Re: [PATCH v3 2/2] tpm: in tpm2_del_space check if ops pointer is still valid

2021-02-04 Thread Greg KH
On Fri, Feb 05, 2021 at 12:50:43AM +0100, Lino Sanfilippo wrote: > From: Lino Sanfilippo > > In tpm2_del_space() chip->ops is used for flushing the sessions. However > this function may be called after tpm_chip_unregister() which sets > the chip->ops pointer to NULL. > Avoid a possible NULL point

Re: [PATCH v3 1/2] tpm: fix reference counting for struct tpm_chip

2021-02-04 Thread Greg KH
On Fri, Feb 05, 2021 at 12:50:42AM +0100, Lino Sanfilippo wrote: > From: Lino Sanfilippo > > The following sequence of operations results in a refcount warning: > > 1. Open device /dev/tpmrm > 2. Remove module tpm_tis_spi > 3. Write a TPM command to the file descriptor opened at step 1. > > ---

Re: [PATCH] staging: media: atomisp: fix coding style issues in timer.c

2021-02-04 Thread Greg KH
On Sun, Jan 31, 2021 at 11:55:29PM +0530, Ayush wrote: > - Fix unneeded brace in if condition(also, brace was on next line). > - Fix leading space warning before struct ia_css_clock_tick *curr_ts. > > compile tested only (on next-20210129) > > Signed-off-by: Ayush > --- > .../staging/media/atom

Re: [PATCH 00/31] coresight: Patches for v5.12

2021-02-04 Thread Greg KH
On Mon, Feb 01, 2021 at 11:13:20AM -0700, Mathieu Poirier wrote: > Good day Greg, > > Please consider the following patches for inclusion in the coming v5.12 cycle. > > Note that patches 11, 13 and 14 make checkpatch angry over the lack of > parentheses when defining complex macros but looking a

Re: [PATCH RESEND] random: fix the RNDRESEEDCRNG ioctl

2021-02-04 Thread Greg KH
On Mon, Feb 01, 2021 at 02:43:51PM -0800, Eric Biggers wrote: > On Tue, Jan 12, 2021 at 11:28:18AM -0800, Eric Biggers wrote: > > From: Eric Biggers > > > > The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which > > doesn't make sense. Reseed it from the input_pool instead. > > > >

Re: [git pull] habanalabs pull request for kernel 5.12

2021-02-04 Thread Greg KH
On Wed, Jan 27, 2021 at 09:29:22PM +0200, Oded Gabbay wrote: > Hi Greg, > > This is habanalabs pull request for the merge window of kernel 5.12. > It contains changes and new features, support for new firmware. > Details are in the tag. > > Thanks, > Oded > > The following changes since commit 0

Re: [PATCH v4] tty: make pl011 serial port driver support 485 mode

2021-02-04 Thread Greg KH
On Mon, Feb 01, 2021 at 03:30:43PM +0800, zhangqiumi...@huawei.com wrote: > From: Qiumiao Zhang > > make pl011 serial port support 485 mode full duplex communication > > Signed-off-by: Qiumiao Zhang > --- > Changes in v4: > -Add a bound to the loop in pl011_stop_tx > -Remove extra curly bra

Re: [PATCH] RFC syscore: add suspend type to syscore

2021-02-04 Thread Greg KH
On Thu, Feb 04, 2021 at 05:06:25PM +0800, Ruifeng Zhang wrote: > Greg KH 于2021年1月29日周五 下午4:53写道: > > > > On Fri, Jan 29, 2021 at 04:27:26PM +0800, Ruifeng Zhang wrote: > > > From: Ruifeng Zhang > > > > > > Suspend type contains s2ram and s2idle, but

Re: [PATCH] usb: cdnsp: Removes some useless trace events

2021-02-04 Thread Greg KH
On Thu, Feb 04, 2021 at 10:20:35AM +0100, Pawel Laszczak wrote: > Patch removes some useless trace events that can > be replaced by ftrace. > > Reported-by: Dan Carpenter > Signed-off-by: Pawel Laszczak > --- > drivers/usb/cdns3/cdnsp-ep0.c| 5 - > drivers/usb/cdns3/cdnsp-gadget.c | 2

Re: [PATCH] usb: pd: Reland VDO definitions of PD2.0

2021-02-03 Thread Greg KH
On Thu, Feb 04, 2021 at 02:17:56PM +0800, Kyle Tso wrote: > On Thu, Feb 4, 2021 at 8:55 AM Kyle Tso wrote: > > > > Hi, Benson and Prashant, > > > > On Thu, Feb 4, 2021 at 8:50 AM Kyle Tso wrote: > > > > > > Reland VDO definitions of PD Revision 2.0 as they are still used in > > > PD2.0 products.

Re: [PATCH] usb: typec: remove unused variable ‘ret’ in typec_partner_set_pd_revision

2021-02-03 Thread Greg KH
On Thu, Feb 04, 2021 at 09:24:30AM +0800, Ye Bin wrote: > Fix follow warning: > drivers/usb/typec/class.c:763:6: warning: unused variable ‘ret’ > [-Wunused-variable] > int ret; > ^~~ > > Reported-by: Hulk Robot > Signed-off-by: Ye Bin > --- > drivers/usb/typec/class.c | 2 -- > 1 file

Re: [PATCH v4 4/6] dm: new ioctl DM_DEV_REMAP_CMD

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 06:53:56PM +0300, Sergei Shtepa wrote: > --- a/include/uapi/linux/dm-ioctl.h > +++ b/include/uapi/linux/dm-ioctl.h > @@ -214,6 +214,15 @@ struct dm_target_msg { > char message[0]; > }; > > +enum { > + REMAP_START_CMD = 1, > + REMAP_FINISH_CMD, Don't you nee

Re: [PATCH 1/2] misc/pvpanic: split-up generic and platform dependent code

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 04:43:58PM +0200, Mihai Carabas wrote: > Split-up generic and platform dependent code in order to introduce pvpanic pci > device driver later. What is "later"? And did you just create a new driver/module in this change? Why? And how did you test? This new module looks to

Re: [PATCH 2/2] misc/pvpanic: add pci driver

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 04:43:59PM +0200, Mihai Carabas wrote: > Add pvpanic pci device driver support. > > Signed-off-by: Mihai Carabas > --- > drivers/misc/pvpanic/Kconfig | 16 ++- > drivers/misc/pvpanic/Makefile | 7 + > drivers/misc/pvpanic/pvpanic-pci.c | 54 >

Re: [PATCH 2/2] misc/pvpanic: add pci driver

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 04:43:59PM +0200, Mihai Carabas wrote: > Add pvpanic pci device driver support. What does that mean? Please provide more changelog text here. > > Signed-off-by: Mihai Carabas > --- > drivers/misc/pvpanic/Kconfig | 16 ++- > drivers/misc/pvpanic/Makefile

Re: [PATCH v5 2/8] usb: pd: Update VDO definitions

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 02:48:36PM +0200, Heikki Krogerus wrote: > On Wed, Feb 03, 2021 at 12:17:27AM +0800, Kyle Tso wrote: > > "PD Spec Revision 3.0 Version 2.0 + ECNs 2020-12-10" introduces several > > changes regarding the ID Header VDO and the Product Type VDOs. > > > > Signed-off-by: Kyle Ts

Re: [PATCH 2/2] bio: add limit_bio_size sysfs

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 08:21:07PM +0900, Changheun Lee wrote: > Add limit_bio_size block sysfs node to limit bio size. > Queue flag QUEUE_FLAG_LIMIT_BIO_SIZE will be set if limit_bio_size is set. > And bio max size will be limited by queue max sectors via > QUEUE_FLAG_LIMIT_BIO_SIZE set. > > Sign

Re: [PATCH v4 2/2] bio: add limit_bio_size sysfs

2021-02-03 Thread Greg KH
On Wed, Feb 03, 2021 at 06:22:47PM +0900, Changheun Lee wrote: > Add limit_bio_size block sysfs node to limit bio size. > Queue flag QUEUE_FLAG_LIMIT_BIO_SIZE will be set if limit_bio_size is set. > And bio max size will be limited by queue max sectors via > QUEUE_FLAG_LIMIT_BIO_SIZE set. > > Sign

Re: [BUG] copy_file_range with sysfs file as input

2021-02-03 Thread Greg KH
On Mon, Jan 25, 2021 at 03:54:31PM +0800, Nicolas Boichat wrote: > Hi copy_file_range experts, > > We hit this interesting issue when upgrading Go compiler from 1.13 to > 1.15 [1]. Basically we use Go's `io.Copy` to copy the content of > `/sys/kernel/debug/tracing/trace` to a temporary file. Nit,

Re: [PATCH v4 2/2] bio: add limit_bio_size sysfs

2021-02-03 Thread Greg KH
On Fri, Jan 29, 2021 at 12:49:09PM +0900, Changheun Lee wrote: > Add new sysfs node to limit bio size. You forgot to also add a new Documentation/ABI/ entry that describes what this new sysfs file does :( thanks, greg k-h

Re: [PATCH] usb: typec: Return void in typec_partner_set_pd_revision

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 05:55:12PM +0800, Kyle Tso wrote: > typec_partner_set_pd_revision doesn't need any return value. > > Fixes: 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision") > Signed-off-by: Kyle Tso Thanks, now queued up. greg k-h

Re: [PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 09:52:13AM -0800, Benson Leung wrote: > Hi Greg, > > On Tue, Feb 2, 2021 at 9:02 AM Greg KH wrote: > > > > On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote: > > > typec_partner_set_pd_revision returns void now. > > > >

Re: [PATCH v2] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 08:45:31AM -0800, Benson Leung wrote: > typec_partner_set_pd_revision returns void now. > > Fixes: cefc011f8daf ("platform/chrome: cros_ec_typec: Set Partner PD revision > from status") > Signed-off-by: Benson Leung > --- > drivers/platform/chrome/cros_ec_typec.c | 6 +--

Re: [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 08:32:48AM -0800, Benson Leung wrote: > typec_partner_set_pd_revision returns void now. > > Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision > from status Can you please use the documented format for the Fixes: tag (and for the use of any git id

Re: [PATCH] usb: typec: Return void in typec_partner_set_pd_revision

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 07:02:52AM -0800, Benson Leung wrote: > Hi Kyle, > > On Tue, Feb 02, 2021 at 05:55:12PM +0800, Kyle Tso wrote: > > typec_partner_set_pd_revision doesn't need any return value. > > > > Fixes: 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision") > > Signed-off-by:

Re: [GIT PULL] Immutable Branch between platform/chrome and USB for v5.12 merge window

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 12:06:03AM -0800, Benson Leung wrote: > Hi Greg, > > The following changes since commit 29b01295a829fba7399ee84afff4e64660e49f04: > > usb: typec: Add typec_partner_set_pd_revision (2021-02-01 15:31:34 +0100) > > are available in the Git repository at: > > git://git.k

Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver

2021-02-02 Thread Greg KH
On Mon, Feb 01, 2021 at 07:24:53PM +0200, Adrian Catangiu wrote: > +static long sysgenid_ioctl(struct file *file, > +unsigned int cmd, unsigned > long arg) Very odd indentation style, checkpatch.pl didn't catch this?

Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver

2021-02-02 Thread Greg KH
On Mon, Feb 01, 2021 at 07:24:53PM +0200, Adrian Catangiu wrote: > +config SYSGENID > + tristate "System Generation ID driver" > + default N "N" is always the default, no need to list it again :(

Re: [PATCH v5 1/2] drivers/misc: sysgenid: add system generation id driver

2021-02-02 Thread Greg KH
On Mon, Feb 01, 2021 at 07:24:53PM +0200, Adrian Catangiu wrote: > +EXPORT_SYMBOL(sysgenid_bump_generation); EXPORT_SYMBOL_GPL()? I have to ask...

Re: [Linux-kernel-mentees] Patches from the future - can checkpatch help?

2021-02-02 Thread Greg KH
On Mon, Feb 01, 2021 at 10:31:33PM +0530, Dwaipayan Ray wrote: > On Mon, Feb 1, 2021 at 10:07 PM Greg KH wrote: > > > > On Mon, Feb 01, 2021 at 10:04:01PM +0530, Dwaipayan Ray wrote: > > > Hi, > > > on linux-next, > > > $ git log --pretty=format:"%h

Re: [PATCH V2 0/3] SWIOTLB: Preserve swiotlb map offset when needed.

2021-02-02 Thread Greg KH
On Mon, Feb 01, 2021 at 10:30:14AM -0800, Jianxiong Gao wrote: > NVMe driver and other applications may depend on the data offset > to operate correctly. Currently when unaligned data is mapped via > SWIOTLB, the data is mapped as slab aligned with the SWIOTLB. This > patch adds an option to make s

Re: [PATCH v1 1/1] Firstly, as Andy mentioned, this should be smp_rmb() instead of rmb(). considering that TSYNC is a cross-thread situation, and rmb() is a mandatory barrier which should not be used

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 06:13:07PM +0800, wanghongzhe wrote: > Secondly, the smp_rmb() should be put between reading SYSCALL_WORK_SECCOMP > and reading Your subject line of the patch is a bit odd :)

Re: [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 11:24:04AM +, Avri Altman wrote: > > > > > On Tue, Feb 02, 2021 at 10:30:00AM +0200, Avri Altman wrote: > > > diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h > > > index afeb6365daf8..5ec4023db74d 100644 > > > --- a/drivers/scsi/ufs/ufshpb.h > > > +

Re: [PATCH v2 3/9] scsi: ufshpb: Add region's reads counter

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 11:23:17AM +, Avri Altman wrote: > > > > > > On Tue, Feb 02, 2021 at 10:30:01AM +0200, Avri Altman wrote: > > > @@ -175,6 +179,8 @@ struct ufshpb_lu { > > > > > > /* for selecting victim */ > > > struct victim_select_info lru_info; > > > + struct work_s

Re: [PATCH v2 9/9] scsi: ufshpb: Make host mode parameters configurable

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 10:30:07AM +0200, Avri Altman wrote: > +struct attribute_group ufs_sysfs_hpb_param_group = { > + .name = "hpb_param_sysfs", Shouldn't this be "hpb_param"? Why the trailing "_sysfs", doesn't that look odd in the directory path? thanks, greg k-h

Re: [PATCH v2 9/9] scsi: ufshpb: Make host mode parameters configurable

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 10:30:07AM +0200, Avri Altman wrote: > We can make use of this commit, to elaborate some more of the host > control mode logic, explaining what role play each and every variable: > > - activation_thld - In host control mode, reads are the major source of > activation t

Re: [PATCH v2 3/9] scsi: ufshpb: Add region's reads counter

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 10:30:01AM +0200, Avri Altman wrote: > In host control mode, reads are the major source of activation trials. > Keep track of those reads counters, for both active as well inactive > regions. > > We reset the read counter upon write - we are only interested in "clean" > rea

Re: [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 10:30:00AM +0200, Avri Altman wrote: > diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h > index afeb6365daf8..5ec4023db74d 100644 > --- a/drivers/scsi/ufs/ufshpb.h > +++ b/drivers/scsi/ufs/ufshpb.h > @@ -48,6 +48,11 @@ enum UFSHPB_MODE { > HPB_DEVICE_

Re: [PATCH v2 3/9] scsi: ufshpb: Add region's reads counter

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 10:30:01AM +0200, Avri Altman wrote: > @@ -175,6 +179,8 @@ struct ufshpb_lu { > > /* for selecting victim */ > struct victim_select_info lru_info; > + struct work_struct ufshpb_normalization_work; > + unsigned long work_data_bits; You only have 1 "bit"

Re: [PATCH v19 1/3] scsi: ufs: Introduce HPB feature

2021-02-02 Thread Greg KH
On Tue, Feb 02, 2021 at 07:46:47AM +, Avri Altman wrote: > Daejun, > > > static const struct attribute_group *ufshcd_driver_groups[] = { > > &ufs_sysfs_unit_descriptor_group, > > &ufs_sysfs_lun_attributes_group, > > +#ifdef CONFIG_SCSI_UFS_HPB > > + &ufs_sysfs_hpb_stat_g

Re: [PATCH 0/6] usb: typec: and platform/chrome: Add PD revision numbers

2021-02-01 Thread Greg KH
On Mon, Feb 01, 2021 at 11:04:15PM -0800, Benson Leung wrote: > Hi Greg, > > On Mon, Feb 01, 2021 at 03:32:47PM +0100, Greg KH wrote: > > On Thu, Jan 28, 2021 at 10:14:00PM -0800, Benson Leung wrote: > > > USB Power Delivery has a 3 entity handshake (port, cable, partner)

Re: [Linux-kernel-mentees] Patches from the future - can checkpatch help?

2021-02-01 Thread Greg KH
On Mon, Feb 01, 2021 at 10:04:01PM +0530, Dwaipayan Ray wrote: > Hi, > on linux-next, > $ git log --pretty=format:"%h%x09%ad" | awk '$6>2021 {print $1}' > gives: > 4a2d78822fdf > 12ca45fea91c > 09f2724a786f > > These are patches from the year 2085, 2037 and 2030 respectively. > > Would a checkpat

Re: [RESEND PATCH v2] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2021-02-01 Thread Greg KH
On Mon, Feb 01, 2021 at 05:56:19PM +0200, eli.billa...@gmail.com wrote: > From: Eli Billauer > > The XillyUSB driver is the USB variant for the Xillybus FPGA IP core. > Even though it presents a nearly identical API on the FPGA and host, > it's almost a complete rewrite of the driver: The framewo

Re: [PATCH v2] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2021-02-01 Thread Greg KH
On Mon, Feb 01, 2021 at 05:56:38PM +0200, Eli Billauer wrote: > Hello, Greg. > > On 01/02/21 16:25, Greg KH wrote: > > As this has nothing to do with the existing XillyBus code, and you > > aren't doing anything "fancy" with the character device nodes, why does

Re: [PATCH 0/6] usb: typec: and platform/chrome: Add PD revision numbers

2021-02-01 Thread Greg KH
On Thu, Jan 28, 2021 at 10:14:00PM -0800, Benson Leung wrote: > USB Power Delivery has a 3 entity handshake (port, cable, partner), and as > of USB PD R3.0, each entity may independently support either Revision 2 or > Revision 3 signaling and protocol. In order for userspace and the kernel > to pro

Re: [PATCH v2] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)

2021-02-01 Thread Greg KH
On Mon, Feb 01, 2021 at 04:16:51PM +0200, eli.billa...@gmail.com wrote: > From: Eli Billauer > > The XillyUSB driver is the USB variant for the Xillybus FPGA IP core. > Even though it presents a nearly identical API on the FPGA and host, > it's almost a complete rewrite of the driver: The framewo

Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio

2021-02-01 Thread Greg KH
On Mon, Feb 01, 2021 at 04:24:51AM +, Erich Ritz wrote: > On Friday, January 29, 2021 9:17 AM, Takashi Iwai wrote: > > > On Fri, 29 Jan 2021 17:12:08 +0100, > > Michael Catanzaro wrote: > > > > > On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro > > > mcatanz...@redhat.com wrote: > > > > > >

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-01 Thread Greg KH
On Mon, Feb 01, 2021 at 04:25:49PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 27, 2021 at 04:15:42PM +0100, Greg KH wrote: > > On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > > > Hi Greg, > > > > > > On Wed

Re: [PATCH 3/8] scsi: ufshpb: Add region's reads counter

2021-01-30 Thread Greg KH
On Sun, Jan 31, 2021 at 07:25:37AM +, Avri Altman wrote: > > > > > > + if (ufshpb_mode == HPB_HOST_CONTROL) > > > + reads = atomic64_inc_return(&rgn->reads); > > > + > > > if (!ufshpb_is_support_chunk(transfer_len)) > > > return; > > > > > > + if (ufshpb_

Re: [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init

2021-01-30 Thread Greg KH
On Sun, Jan 31, 2021 at 07:08:00AM +, Avri Altman wrote: > > > > > > +static enum UFSHPB_MODE ufshpb_mode; > > > > How are you allowed to have a single variable for a device-specific > > thing? What happens when you have two controllers or disks or whatever > > you are binding to here? How d

Re: [PATCH stable v5.4 2/2] IPv6: reply ICMP error if the first fragment don't include all headers

2021-01-30 Thread Greg KH
On Sat, Jan 30, 2021 at 05:24:52PM +0530, Aviraj CJ wrote: > From: Hangbin Liu > > commit 2efdaaaf883a143061296467913c01aa1ff4b3ce upstream. > > Based on RFC 8200, Section 4.5 Fragment Header: > > - If the first fragment does not include all headers through an > Upper-Layer header, then

Re: [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition

2021-01-30 Thread Greg KH
On Sat, Jan 30, 2021 at 11:31:11AM +, Aviraj Cj (acj) wrote: > > > On 30/01/21, 2:06 PM, "Greg KH" wrote: > > On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote: > > From: Hangbin Liu > > > > commit b59e286be280fa3c2e94a0716ddcee6ba

Re: [PATCH] media: allegro-dvt: Use __packed sentence

2021-01-30 Thread Greg KH
On Fri, Jan 29, 2021 at 05:01:54PM -0300, Emmanuel Arias wrote: > Fix coding style using __packed sentece instead of Spelling check please? And _why_ are you making this change, what does this do "better" than the original? thanks, greg k-h

Re: [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition

2021-01-30 Thread Greg KH
On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote: > From: Hangbin Liu > > commit b59e286be280fa3c2e94a0716ddcee6ba02bc8ba upstream. > > Based on RFC7112, Section 6: > >IANA has added the following "Type 4 - Parameter Problem" message to >the "Internet Control Message Protocol v

Re: linux-next: manual merge of the char-misc tree with the tty tree

2021-01-28 Thread Greg KH
On Fri, Jan 29, 2021 at 03:53:41PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the char-misc tree got conflicts in: > > drivers/tty/n_tracerouter.c > drivers/tty/n_tracesink.c > > between commit: > > 3b830a9c34d5 ("tty: convert tty_ldisc_ops 'read()' function

Re: [PATCH v12] staging: fbtft: add tearing signal detect

2021-01-28 Thread Greg KH
On Thu, Jan 28, 2021 at 08:53:55PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > > Signed-off-by: zhangxuezhi > --- > v12: change dev_err to dev_err_probe and add s

Re: [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0

2021-01-28 Thread Greg KH
On Wed, Jan 27, 2021 at 02:00:06PM -0800, Tom Rix wrote: > > On 1/27/21 1:43 PM, richard.g...@linux.intel.com wrote: > > From: Richard Gong > > > > Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which > > aligns with the firmware settings. > > For fixes, you need to have a 'Fi

Re: [PATCH 0/3] Adding offset keeping option when mapping data via SWIOTLB.*

2021-01-28 Thread Greg KH
On Wed, Jan 27, 2021 at 04:38:26PM -0800, Jianxiong Gao wrote: > NVMe driver and other applications may depend on the data offset > to operate correctly. Currently when unaligned data is mapped via > SWIOTLB, the data is mapped as slab aligned with the SWIOTLB. This > patch adds an option to make s

Re: [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0

2021-01-28 Thread Greg KH
On Wed, Jan 27, 2021 at 03:43:21PM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which > aligns with the firmware settings. > > Signed-off-by: Richard Gong > --- > include/linux/firmware/intel/stratix10-svc

Re: [PATCH] speakup: Make dectlk flush timeout configurable

2021-01-27 Thread Greg KH
On Thu, Jan 28, 2021 at 12:44:44AM +0100, Samuel Thibault wrote: > In case the serial port or cable got faulty, we may not be getting > acknowledgements any more. The driver then currently waits for 4s to > avoid jamming the device. This makes this delay configurable. > > Signed-off-by: Samuel Thi

Re: [PATCH 0/4] add xhci hooks for USB offload

2021-01-27 Thread Greg KH
On Thu, Jan 28, 2021 at 08:31:14AM +0200, Mathias Nyman wrote: > On 28.1.2021 5.38, Howard Yen wrote: > > On Tue, Jan 26, 2021 at 10:19 PM Greg KH wrote: > >> > >> On Fri, Jan 22, 2021 at 05:32:58PM +0200, Mathias Nyman wrote: > >>> > >>> Ok, b

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 05:49:46PM +0300, Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > > On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > > > On Wed, 27 Jan 2021 15:13:05 +0100 > > > Greg KH wrote: > > > > &

Re: [PATCH 7/8] scsi: ufshpb: Add "Cold" regions timer

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 05:12:16PM +0200, Avri Altman wrote: > In order not to hang on to “cold” regions, we shall inactivate a > region that has no READ access for a predefined amount of time - > READ_TO_MS. For that purpose we shall monitor the active regions list, > polling it on every POLLING_I

Re: [PATCH 3/8] scsi: ufshpb: Add region's reads counter

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 05:12:12PM +0200, Avri Altman wrote: > In host control mode, reads are the major source of activation trials. > Keep track of those reads counters, for both active as well inactive > regions. > > We reset the read counter upon write - we are only interested in "clean" > rea

Re: [PATCH 2/8] scsi: ufshpb: Add host control mode support to rsp_upiu

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 05:12:11PM +0200, Avri Altman wrote: > There are some limitations to activations / inactivations in host > control mode - Add those. I can not understand this changelog text, please make it more descriptive as I have no way to know how to review this patch :( thanks, greg

Re: [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 05:12:10PM +0200, Avri Altman wrote: > We will use it later, when we'll need to differentiate between device > and host control modes. > > Signed-off-by: Avri Altman > --- > drivers/scsi/ufs/ufshpb.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-01-27 Thread Greg KH
On Wed, Jan 13, 2021 at 08:56:25PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Jan 06, 2021 at 10:44:13AM -0800, Hemant Kumar wrote: > > This patch series adds support for UCI driver. UCI driver enables userspace > > clients to communicate to external MHI devices like modem. UCI dri

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > On Wed, 27 Jan 2021 15:13:05 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > > > On Wed, 27 Jan 2021 14:51:55 +0100 > > > Greg KH wrote: > > > > &

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > On Wed, 27 Jan 2021 14:51:55 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > From: zhangxuezhi > > > > > > For st7789v ic,when we need continuous ful

Re: [PATCH v11] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 10:02:29PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > > Signed-off-by: zhangxuezhi Again, slow down, and wait for comments before respon

Re: [PATCH v9 04/20] dlb: add device ioctl layer and first three ioctls

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 01:59:50PM +, Chen, Mike Ximing wrote: > > > -Original Message- > > From: Greg KH > > Sent: Wednesday, January 27, 2021 7:29 AM > > To: Chen, Mike Ximing > > Cc: linux-kernel@vger.kernel.org; a...@arndb.de; Willia

Re: [PATCH 0/5] bus: fsl-mc: add userspace support

2021-01-27 Thread Greg KH
On Thu, Jan 14, 2021 at 07:07:47PM +0200, Ioana Ciornei wrote: > From: Ioana Ciornei > > This patch set adds userspace support in the fsl-mc bus along with a > rescan attribute to the root DPRC container. An earlier discussion on > this functionality can be found at the link below. I didn't conti

Re: [PATCH 1/6] wlan-ng: clean up line ending

2021-01-27 Thread Greg KH
On Mon, Jan 18, 2021 at 02:09:51AM +0100, Johannes Czekay wrote: > This patch cleans up all the "Lines should not end with a '('" warnings. > > Signed-off-by: Johannes Czekay > Co-developed-by: Nicolai Fischer > Signed-off-by: Nicolai Fischer > --- > drivers/staging/wlan-ng/cfg80211.c | 6 ++--

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > > Signed-off-by: zhangxuezhi Please slow down and wait at least a day between patc

Re: [PATCH v9] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 08:57:37PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,add tearing signal detect to avoid screen tearing I need a much better changelog description here please. > > Signed-off-by: zhangxuezhi > --- > v9: change pr_* to dev_* > --- What changed in all o

Re: [PATCH v9 04/20] dlb: add device ioctl layer and first three ioctls

2021-01-27 Thread Greg KH
On Fri, Jan 22, 2021 at 01:01:22PM -0600, Mike Ximing Chen wrote: > --- /dev/null > +++ b/include/uapi/linux/dlb.h > @@ -0,0 +1,167 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ As the bot points out, this is an "odd" license for a uapi .h file, are you SURE about this? If so, I need an Intel

<    4   5   6   7   8   9   10   11   12   13   >