Re: [PATCH 5.11 000/120] 5.11.9-rc1 review

2021-03-22 Thread Guenter Roeck
> let me know. > > Responses should be made by Wed, 24 Mar 2021 12:19:09 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 437 pass: 437 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 000/156] 5.10.26-rc2 review

2021-03-22 Thread Guenter Roeck
On Mon, Mar 22, 2021 at 04:19:10PM +0100, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.10.26 release. > There are 156 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kno

Re: Linux 5.12-rc4

2021-03-22 Thread Guenter Roeck
On Sun, Mar 21, 2021 at 03:34:58PM -0700, Linus Torvalds wrote: > Very much an average rc4, possibly just a tad on the smaller side of average. > > Nothing here particularly stands out. The diffstat looks a bit more > spread out than it perhaps normally would do, because of the removal > of the (n

Re: [PATCH v2 1/4] iommu/vt-d: Enable write protect for supervisor SVM

2021-03-22 Thread Guenter Roeck
On Tue, Mar 02, 2021 at 02:13:57AM -0800, Jacob Pan wrote: > Write protect bit, when set, inhibits supervisor writes to the read-only > pages. In supervisor shared virtual addressing (SVA), where page tables > are shared between CPU and DMA, IOMMU PASID entry WPE bit should match > CR0.WP bit in th

Re: [PATCH] platform/chrome: cros_ec_typec: fix clang -Wformat warning

2021-03-22 Thread Guenter Roeck
dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \ > ~~~ ^~~ > > Use an explicit bit mask to limit the number to its lower eight bits > instead. > > Fixes: ad7c0510c99e ("platform/chrome: cros_ec_typec: Update port info from > EC&quo

Re: [RFC RESEND PATCH v2 8/8] watchdog: retu_wdt: Clean-up by using managed work init

2021-03-22 Thread Guenter Roeck
ile-tested only. All testing is appreciated. > > Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck > --- > drivers/watchdog/retu_wdt.c | 22 ++ > 1 file changed, 6 insertions(+), 16 deletions(-) > > diff --git a/drivers/watchdog/retu_wdt.c b

Re: [RFC RESEND PATCH v2 4/8] hwmon: raspberry-pi: Clean-up few drivers by using managed work init

2021-03-22 Thread Guenter Roeck
ile-tested only. All testing is appreciated. > > Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck > --- > drivers/hwmon/raspberrypi-hwmon.c | 17 ++--- > 1 file changed, 6 insertions(+), 11 deletions(-) > > diff --git a/drivers/hwmon/raspberrypi-hwmon.c &

Re: [PATCH] watchdog: Fix a typo

2021-03-22 Thread Guenter Roeck
On Sun, Mar 21, 2021 at 03:03:01AM +0530, Bhaskar Chowdhury wrote: > s/parmeter/parameter/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Guenter Roeck > --- > drivers/watchdog/sl28cpld_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] watchdog: fix syntactic kernel-doc issues

2021-03-22 Thread Guenter Roeck
nctions in the watchdog subsystem. > > Signed-off-by: Lukas Bulwahn Reviewed-by: Guenter Roeck > --- > Guenter, Wim, please pick this minor clean-up patch. > > drivers/watchdog/booke_wdt.c | 2 +- > drivers/watchdog/eurotechwdt.c | 2 +- > drivers

Re: [PATCH v4] RISC-V: enable XIP

2021-03-21 Thread Guenter Roeck
On Sat, Mar 06, 2021 at 02:14:38PM +0200, Vitaly Wool wrote: > Introduce XIP (eXecute In Place) support for RISC-V platforms. > It allows code to be executed directly from non-volatile storage > directly addressable by the CPU, such as QSPI NOR flash which can > be found on many RISC-V platforms. T

Re: [PATCH v2 net-next 2/2] net: socket: change MSG_CMSG_COMPAT to BIT(21)

2021-03-21 Thread Guenter Roeck
cvmsg functions: > > static int packet_recvmsg(struct socket *sock, struct msghdr *msg, > size_t len, > int flags) > > If MSG_CMSG_COMPAT is set in 'flags', it's value will be negative. > Once it perform bit o

Re: [PATCH v2 net-next 1/2] net: socket: use BIT() for MSG_*

2021-03-21 Thread Guenter Roeck
On 3/21/21 6:43 AM, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The bit mask for MSG_* seems a little confused here. Replace it > with BIT() to make it clear to understand. > > Signed-off-by: Menglong Dong With this patch sent as patch 1/2, any code trying to bisect a compat rela

Re: [PATCH] watchdog: Fix a typo

2021-03-20 Thread Guenter Roeck
On 3/20/21 2:33 PM, Bhaskar Chowdhury wrote: > s/parmeter/parameter/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Guenter Roeck > --- > drivers/watchdog/sl28cpld_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/

Re: [PATCH 11/14] watchdog: npcm: Add support for WPCM450

2021-03-20 Thread Guenter Roeck
On 3/20/21 11:16 AM, Jonathan Neuschäfer wrote: Patch description goes here. Guenter > Signed-off-by: Jonathan Neuschäfer > --- > drivers/watchdog/npcm_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/npcm_wdt.c b/drivers/watchdog/npcm_wdt.c > index 765577f11c8

Re: [PATCH v3 3/3] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-19 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 05:02:31PM +1300, Chris Packham wrote: > The BPA-RS600 is a compact 600W AC to DC removable power supply module. > > Signed-off-by: Chris Packham For my reference (aiting for bindings approval): Reviewed-by: Guenter Roeck Guenter > --- > > Notes: &

Re: [PATCH v3 1/3] dt-bindings: Add vendor prefix and trivial device for BluTek BPA-RS600

2021-03-19 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 05:02:29PM +1300, Chris Packham wrote: > Add vendor prefix "blutek" for BluTek Power. > Add trivial device entry for BPA-RS600. > > Signed-off-by: Chris Packham For my reference (waiting for bindings approval): Reviewed-by: Guenter Roeck Gue

Re: [PATCH v3 2/3] hwmon: (pmbus): Replace - with _ in device names before registration

2021-03-19 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 05:02:30PM +1300, Chris Packham wrote: > The hwmon sysfs ABI requires that the `name` property doesn't include > any dashes. But when the pmbus code picks the name up from the device > tree it quite often does. Replace '-' with '_' before registering the > device. > > Signe

Re: [PATCH 1/2] dt-bindings: Add trivial device entry for TPS53676

2021-03-19 Thread Guenter Roeck
On Thu, Mar 18, 2021 at 10:24:40PM +0100, Erik Rosen wrote: > Add trivial device entry for TPS53676 > > Signed-off-by: Erik Rosen For my reference (waiting for dt maintainer acceptance): Reviewed-by: Guenter Roeck > --- > Documentation/devicetree/bindings/trivial-devices.y

Re: [PATCH v2] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-19 Thread Guenter Roeck
On Fri, Mar 19, 2021 at 01:55:44AM -0300, Jonas Malaco wrote: > These are "all-in-one" CPU liquid coolers that can be monitored and > controlled through a proprietary USB HID protocol. > > While the models have differently sized radiators and come with varying > numbers of fans, they are all indis

Re: [PATCH 5.11 00/31] 5.11.8-rc1 review

2021-03-19 Thread Guenter Roeck
let me know. > > Responses should be made by Sun, 21 Mar 2021 12:17:37 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 437 pass: 437 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.10 00/13] 5.10.25-rc1 review

2021-03-19 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 21 Mar 2021 12:17:37 +. > Anything received after that time might be too late. > Build results: total: 156 pass: 156 fail: 0 Qemu test results: total: 432 pass: 432 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 5.4 00/18] 5.4.107-rc1 review

2021-03-19 Thread Guenter Roeck
> let me know. > > Responses should be made by Sun, 21 Mar 2021 12:17:37 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 431 pass: 431 fail: 0 Tested-by: Guenter Roeck Guenter

Re: [PATCH 4.19 0/8] 4.19.182-rc1 review

2021-03-19 Thread Guenter Roeck
re full instead of %pure-parser I tried to fix the problem in v4.9.y and v4.4.y as well, but that is pretty much hopeless. I'll have to stop testing perf builds for those kernels. Anyway, Tested-by: Guenter Roeck Guenter

Re: [PATCH v4] hwmon: corsair-psu: add support for critical values

2021-03-19 Thread Guenter Roeck
On 3/19/21 1:58 AM, Wilken Gottwalt wrote: > On Thu, 18 Mar 2021 12:01:50 -0700 > Guenter Roeck wrote: > >> On Thu, Mar 18, 2021 at 03:17:14PM +0100, Wilken Gottwalt wrote: >>> Adds support for reading the critical values of the temperature sensors >>> and the

Re: [PATCH] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-18 Thread Guenter Roeck
On Thu, Mar 18, 2021 at 08:15:06PM -0300, Jonas Malaco wrote: [ ... ] > > Either case, the spinlocks are overkill. It would be much easier to > > convert raw readings here into temperature and fan speed and store > > the resulting values in struct kraken2_priv_data, and then to > > just report it

Re: [PATCH 2/2] hwmon: (pmbus/tps53679) Add support for TPS53676

2021-03-18 Thread Guenter Roeck
On 3/18/21 2:24 PM, Erik Rosen wrote: > Add support for TI TPS53676 controller to the tps53679 pmbus driver > > The driver uses the USER_DATA_03 register to figure out how many phases are > enabled and to which channel they are assigned, and sets the number of pages checkpatch complains about the

Re: [PATCH] hwmon: Fix spelling typo

2021-03-18 Thread Guenter Roeck
On Thu, Mar 18, 2021 at 08:46:37PM +0800, zuoqil...@163.com wrote: > From: zuoqilin > > Change 'revsion' to 'revision'. > > Signed-off-by: zuoqilin Applied. In the future also please list the affected driver in the subject line. Thanks, Guenter > --- > drivers/hwmon/ftsteutates.c | 2 +- >

Re: [PATCH v4] hwmon: corsair-psu: add support for critical values

2021-03-18 Thread Guenter Roeck
On Thu, Mar 18, 2021 at 03:17:14PM +0100, Wilken Gottwalt wrote: > Adds support for reading the critical values of the temperature sensors > and the rail sensors (voltage and current) once and caches them. Updates > the naming of the constants following a more clear scheme. Also updates > the docum

Re: [PATCH] hwmon: add driver for NZXT Kraken X42/X52/X62/X72

2021-03-18 Thread Guenter Roeck
On 3/18/21 9:48 AM, Jonas Malaco wrote: > These are "all-in-one" CPU liquid coolers that can be monitored and > controlled through a proprietary USB HID protocol. > > While the models have differently sized radiators and come with varying > numbers of fans, they are all indistinguishable at the so

Re: [PATCH] watchdog: Remove MV64x60 watchdog driver

2021-03-18 Thread Guenter Roeck
Christophe Leroy Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconfig | 4 - > drivers/watchdog/Makefile | 1 - > drivers/watchdog/mv64x60_wdt.c | 324 - > include/linux/mv643xx.h| 8 - > 4 files changed, 337 de

Re: [PATCH v1] usb: typec: tcpm: PD3.0 sinks can send Discover Identity even in device mode

2021-03-18 Thread Guenter Roeck
nk is established PD3.0 sinks > can send out discover identity command/AMS once PD negotiation is done. > This allows discovering identity for PD3.0 UFP ports as well. > > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpm.c

Re: [PATCH v1] usb: typec: tcpm: Skip sink_cap query only when VDM sm is busy

2021-03-18 Thread Guenter Roeck
ng instead of checking for VDM_STATE_DONE. > > Fixes: 8dc4bd073663f ("usb: typec: tcpm: Add support for Sink Fast Role > SWAP(FRS)") > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpm.c | 2 +- > 1 file cha

Re: [PATCH 4.14 00/95] 4.14.226-rc1 review

2021-03-17 Thread Guenter Roeck
On 3/17/21 10:54 PM, Samuel Zou wrote: > > > On 2021/3/17 23:36, Greg KH wrote: >> On Tue, Mar 16, 2021 at 02:35:36PM +0800, Samuel Zou wrote: >>> >>> >>> On 2021/3/15 21:56, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle fo

Re: Errant readings on LM81 with T2080 SoC

2021-03-17 Thread Guenter Roeck
On 3/17/21 8:46 PM, Chris Packham wrote: > > On 12/03/21 10:34 am, Guenter Roeck wrote: >> On 3/11/21 1:17 PM, Chris Packham wrote: >>> On 11/03/21 9:18 pm, Wolfram Sang wrote: >>>>> Bummer. What is really weird is that you see clock stretching under >>

Re: [PATCH v1] usb: typec: tcpci: Added few missing TCPCI register definitions

2021-03-17 Thread Guenter Roeck
n Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpci.h | 16 > 1 file changed, 16 insertions(+) > > diff --git a/drivers/usb/typec/tcpm/tcpci.h b/drivers/usb/typec/tcpm/tcpci.h > index 57b6e24e0a0c..2be7a77d400e 100644 > --- a/drivers/usb/typec/tc

Re: [PATCH v1] usb: typec: tcpci: Added few missing TCPCI register definitions

2021-03-17 Thread Guenter Roeck
On 3/17/21 9:42 AM, Greg Kroah-Hartman wrote: > On Tue, Mar 16, 2021 at 03:52:58PM -0700, Guenter Roeck wrote: >> On 3/16/21 3:13 PM, Badhri Jagan Sridharan wrote: >>> This change adds some of the register bit definitions from the TCPCI spec: >>> https://www.usb.org/si

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-17 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 09:53:23PM +0800, Menglong Dong wrote: > On Wed, Mar 17, 2021 at 5:36 PM Andy Shevchenko > wrote: > > > ... > > > > The problematic code is negation of the flags when it's done in > > operations like &. > > It maybe fixed by swapping positions of the arguments, i.e. ~(FOO |

Re: [PATCH v3] hwmon: corsair-psu: add support for critical values

2021-03-17 Thread Guenter Roeck
On 3/17/21 8:13 AM, Wilken Gottwalt wrote: > Adds support for reading the critical values of the temperature sensors > and the rail sensors (voltage and current) once and caches them. Updates > the naming of the constants following a more clear scheme. Also updates > the documentation and fixes som

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-17 Thread Guenter Roeck
On 3/17/21 2:40 AM, Andy Shevchenko wrote: > On Wed, Mar 17, 2021 at 11:36 AM Andy Shevchenko > wrote: >> On Wed, Mar 17, 2021 at 10:21 AM Menglong Dong >> wrote: > > ... > >> It maybe fixed by swapping positions of the arguments, i.e. ~(FOO | >> BAR) & flags. > > ...and type casting will be

Re: [PATCH] watchdog: Fix a typo in the file orion_wdt.c

2021-03-16 Thread Guenter Roeck
On 3/16/21 10:17 PM, Bhaskar Chowdhury wrote: > > s/freqency/frequency/ > > Signed-off-by: Bhaskar Chowdhury Reviewed-by: Guenter Roeck > --- > drivers/watchdog/orion_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/wat

Re: [PATCH v2 3/3] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-16 Thread Guenter Roeck
On 3/16/21 1:30 PM, Chris Packham wrote: > The BPA-RS600 is a compact 600W AC to DC removable power supply module. > > Signed-off-by: Chris Packham > --- > > Notes: > Changes in v2: > - Whitespace and line length cleanup > - Add comments about commands that return data but shouldn't

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-16 Thread Guenter Roeck
On Wed, Mar 17, 2021 at 01:02:51AM +0200, Andy Shevchenko wrote: > On Wednesday, March 17, 2021, Guenter Roeck wrote: > > > Hi, > > > > On Tue, Mar 09, 2021 at 05:51:35PM -0800, menglong8.d...@gmail.com wrote: > > > From: Menglong Dong > > > > >

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-16 Thread Guenter Roeck
On 3/16/21 4:02 PM, Andy Shevchenko wrote: > > > On Wednesday, March 17, 2021, Guenter Roeck <mailto:li...@roeck-us.net>> wrote: > > Hi, > > On Tue, Mar 09, 2021 at 05:51:35PM -0800, menglong8.d...@gmail.com > <mailto:menglong8.d...@gmail.com

Re: [PATCH v1] usb: typec: tcpci: Added few missing TCPCI register definitions

2021-03-16 Thread Guenter Roeck
On 3/16/21 3:13 PM, Badhri Jagan Sridharan wrote: > This change adds some of the register bit definitions from the TCPCI spec: > https://www.usb.org/sites/default/files/documents/ > usb-port_controller_specification_rev2.0_v1.0_0.pdf > > Signed-off-by: Badhri Jagan Sridharan Are those going to b

Re: [PATCH] usb: typec: tcpm: Invoke power_supply_changed for tcpm-source-psy-

2021-03-16 Thread Guenter Roeck
. > > Fixes: f2a8aa053c176("typec: tcpm: Represent source supply through > power_supply") Is that supposed to be split ? > Signed-off-by: Badhri Jagan Sridharan Otherwise Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpm.c | 9 - >

Re: [PATCH v4 RESEND net-next] net: socket: use BIT() for MSG_*

2021-03-16 Thread Guenter Roeck
Hi, On Tue, Mar 09, 2021 at 05:51:35PM -0800, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The bit mask for MSG_* seems a little confused here. Replace it > with BIT() to make it clear to understand. > > Signed-off-by: Menglong Dong I must admit that I am a bit puzzled, but with

Re: [PATCH 03/10] dt-bindings: watchdog: Add compatible for Mediatek MT8195

2021-03-16 Thread Guenter Roeck
On Tue, Mar 16, 2021 at 07:14:36PM +0800, Seiya Wang wrote: > This commit adds dt-binding documentation of watchdog for Mediatek MT8195 SoC > Platform. > > Signed-off-by: Seiya Wang Reviewed-by: Guenter Roeck Guenter > --- > Documentation/devicetree/bindings/watchdog/mtk-

Re: [PATCH 5.11 000/306] 5.11.7-rc1 review

2021-03-16 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Wed, 17 Mar 2021 13:54:26 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 436 pass: 436 fai

Re: [PATCH 5.10 000/290] 5.10.24-rc1 review

2021-03-16 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Wed, 17 Mar 2021 13:55:02 +. > Anything received after that time might be too late. > Build results: total: 156 pass: 156 fail: 0 Qemu test results: total: 431 pass: 431 fai

Re: [PATCH 5.4 000/168] 5.4.106-rc1 review

2021-03-16 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Wed, 17 Mar 2021 13:55:26 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 431 pass: 431 fai

Re: [PATCH 4.19 000/120] 4.19.181-rc1 review

2021-03-16 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Wed, 17 Mar 2021 13:57:02 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 419 pass: 4

Re: [PATCH v2] hwmon: corsair-psu: add support for critical values

2021-03-16 Thread Guenter Roeck
On 3/16/21 7:21 AM, Wilken Gottwalt wrote: > On Mon, 15 Mar 2021 11:00:53 -0700 > Guenter Roeck wrote: > >> On 3/15/21 9:55 AM, Wilken Gottwalt wrote: >>> On Mon, 15 Mar 2021 08:53:25 -0700 >>> Guenter Roeck wrote: >>> >>>> On 3/15/21

Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-15 Thread Guenter Roeck
On 3/15/21 9:21 PM, Chris Packham wrote: > > On 16/03/21 4:43 pm, Guenter Roeck wrote: >> On 3/15/21 7:35 PM, Chris Packham wrote: >>> The BPA-RS600 is a compact 600W AC to DC removable power supply module. >>> >>> Signed-off-by: Chris Pa

Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-15 Thread Guenter Roeck
On 3/15/21 8:41 PM, Chris Packham wrote: > > On 16/03/21 4:35 pm, Guenter Roeck wrote: >> On 3/15/21 8:30 PM, Chris Packham wrote: >>> On 16/03/21 3:35 pm, Chris Packham wrote: >>>> The BPA-RS600 is a compact 600W AC to DC removable power supply module. >&

Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-15 Thread Guenter Roeck
On 3/15/21 7:35 PM, Chris Packham wrote: > The BPA-RS600 is a compact 600W AC to DC removable power supply module. > > Signed-off-by: Chris Packham > --- > Documentation/hwmon/bpa-rs600.rst | 74 > drivers/hwmon/pmbus/Kconfig | 10 ++ > drivers/hwmon/pmbus/Makefile |

Re: [PATCH 2/2] hwmon: (pmbus): Add driver for BluTek BPA-RS600

2021-03-15 Thread Guenter Roeck
On 3/15/21 8:30 PM, Chris Packham wrote: > > On 16/03/21 3:35 pm, Chris Packham wrote: >> The BPA-RS600 is a compact 600W AC to DC removable power supply module. >> >> Signed-off-by: Chris Packham >> >> +static const struct of_device_id __maybe_unused bpa_rs600_of_match[] = { >> +{ .compatibl

Re: [PATCH 9/9] watchdog: of_xilinx_wdt: Skip printing pointer value

2021-03-15 Thread Guenter Roeck
On 3/15/21 3:46 AM, Srinivas Neeli wrote: > "%p" is not printing the pointer value. > In driver, printing pointer value is not useful so avoiding print. > > Signed-off-by: Srinivas Neeli Reviewed-by: Guenter Roeck > --- > drivers/watchdog/of_xilinx_wdt.c |

Re: [PATCH 8/9] watchdog: of_xilinx_wdt: Remove passing null pointer

2021-03-15 Thread Guenter Roeck
> > Signed-off-by: Srinivas Neeli Reviewed-by: Guenter Roeck > --- > drivers/watchdog/of_xilinx_wdt.c | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/watchdog/of_xilinx_wdt.c > b/drivers/watchdog/of_xilinx_wdt

Re: [PATCH 7/9] watchdog: of_xilinx_wdt: Add Versal Window watchdog support

2021-03-15 Thread Guenter Roeck
On 3/15/21 3:46 AM, Srinivas Neeli wrote: > Versal watchdog driver uses Window watchdog mode. Window watchdog > timer(WWDT) contains closed(first) and open(second) window with > 32 bit width. WWDT will generate an interrupt after the first window > timeout and reset signal after the second window t

Re: [PATCH 3/9] watchdog: of_xilinx_wdt: Used dev_dbg()

2021-03-15 Thread Guenter Roeck
On 3/15/21 3:46 AM, Srinivas Neeli wrote: > From: Srinivas Goud > > This patch removes pr_info in stop function and adds dev_dbg() > in start/stop function to display device specific debug info. > > Signed-off-by: Srinivas Goud > Signed-off-by: Michal Simek > Signed-off-by: Srinivas Neeli > -

Re: [PATCH 2/9] watchdog: of_xilinx_wdt: Used BIT macro

2021-03-15 Thread Guenter Roeck
On 3/15/21 3:46 AM, Srinivas Neeli wrote: > From: Srinivas Goud > > Used BIT macro instead of mask value. > > Signed-off-by: Srinivas Goud > Signed-off-by: Michal Simek > Signed-off-by: Srinivas Neeli > --- > drivers/watchdog/of_xilinx_wdt.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [PATCH 1/9] watchdog: of_xilinx_wdt: Add comment to spinlock

2021-03-15 Thread Guenter Roeck
> + spinlock_t spinlock; > > Signed-off-by: Srinivas Goud > Signed-off-by: Michal Simek > Signed-off-by: Srinivas Neeli Reviewed-by: Guenter Roeck > --- > drivers/watchdog/of_xilinx_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: Linux 5.12-rc3

2021-03-15 Thread Guenter Roeck
On Sun, Mar 14, 2021 at 03:00:21PM -0700, Linus Torvalds wrote: > So rc3 is pretty big this time around, but that's entirely artificial, > and due to how I released rc2 early. So I'm not going to read anything > more into this, 5.12 still seems to actually be on the smaller side > overall. Also, be

Re: [PATCH 4.14 00/95] 4.14.226-rc1 review

2021-03-15 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Wed, 17 Mar 2021 13:57:24 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 406 pass: 4

Re: [PATCH 4.9 00/78] 4.9.262-rc1 review

2021-03-15 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Wed, 17 Mar 2021 13:51:58 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 382 pass: 382 fai

Re: [PATCH 4.4 00/75] 4.4.262-rc1 review

2021-03-15 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Wed, 17 Mar 2021 13:51:52 +. > Anything received after that time might be too late. > Build results: total: 165 pass: 165 fail: 0 Qemu test results: total: 328 pass: 328 fai

Re: [PATCH v2] hwmon: corsair-psu: add support for critical values

2021-03-15 Thread Guenter Roeck
On 3/15/21 9:55 AM, Wilken Gottwalt wrote: > On Mon, 15 Mar 2021 08:53:25 -0700 > Guenter Roeck wrote: > >> On 3/15/21 8:02 AM, Wilken Gottwalt wrote: >>> Adds support for reading the critical values of the temperature sensors >>> and the rail sensors (voltage

Re: [PATCH v2] hwmon: corsair-psu: add support for critical values

2021-03-15 Thread Guenter Roeck
On 3/15/21 8:02 AM, Wilken Gottwalt wrote: > Adds support for reading the critical values of the temperature sensors > and the rail sensors (voltage and current) once and caches them. Updates > the naming of the constants following a more clear scheme. Also updates > the documentation and fixes a t

Re: [PATCH v2 3/4] watchdog: simatic-ipc-wdt: add new driver for Siemens Industrial PCs

2021-03-15 Thread Guenter Roeck
On 3/15/21 2:57 AM, Henning Schild wrote: > This driver adds initial support for several devices from Siemens. It is > based on a platform driver introduced in an earlier commit. > > Signed-off-by: Henning Schild Reviewed-by: Guenter Roeck > --- > drivers/watchdog/Kconf

Re: [PATCH] dt-bindings: watchdog: Add compatible for SC7280 SoC

2021-03-15 Thread Guenter Roeck
On 3/14/21 11:05 PM, Rajendra Nayak wrote: > From: Sai Prakash Ranjan > > Add compatible for watchdog timer on SC7280 SoC. > > Signed-off-by: Sai Prakash Ranjan > Signed-off-by: Rajendra Nayak > Reviewed-by: Stephen Boyd > Acked-by: Rob Herring Reviewed-by: Guenter

Re: [PATCH] hwmon: corsair-psu: add support for critical values

2021-03-14 Thread Guenter Roeck
On 3/14/21 5:42 AM, Wilken Gottwalt wrote: > Adds support for reading the critical values of the temperature sensors > and the rail sensors (voltage and current) once and caches them. Updates > the naming of the constants following a more clear scheme. Also updates > the documentation and fixes a t

Re: [PATCH RESEND v3 0/5] media: uvcvideo: Fix race conditions

2021-03-12 Thread Guenter Roeck
On 3/11/21 11:36 PM, Dominique MARTINET wrote: > Hi, > > Guenter Roeck wrote on Thu, Sep 17, 2020 at 07:16:17PM -0700: >> On 9/17/20 5:47 AM, Laurent Pinchart wrote: >>> On Wed, Sep 16, 2020 at 07:25:42PM -0700, Guenter Roeck wrote: >>>> Something seems to h

Re: [PATCH v2 2/2] usb: typec: tcpci_maxim: configure charging & data paths

2021-03-11 Thread Guenter Roeck
On 3/11/21 9:24 PM, Badhri Jagan Sridharan wrote: > The change exposes the data_role and the orientation as a extcon > interface for configuring the USB data controller. > > Signed-off-by: Badhri Jagan Sridharan > --- > Changes since V1: > - Dropped changes related to get_/set_current_limit and p

Re: [PATCH] hwmon: (pmbus): Fix Documentation kernel-doc warning

2021-03-11 Thread Guenter Roeck
On 3/11/21 8:06 PM, Chris Packham wrote: > Fix Documentation/hwmon/ kernel-doc warning: > > Documentation/hwmon/ir36021.rst:34: WARNING: Malformed table. > No bottom table border found. > > Fixes: 0be9fee30ff9 ("hwmon: (pmbus) Add driver for Infineon IR36021") > Signed-off-by: Chris Packham Squ

Re: Errant readings on LM81 with T2080 SoC

2021-03-11 Thread Guenter Roeck
On 3/11/21 3:47 PM, Chris Packham wrote: > > On 12/03/21 10:34 am, Guenter Roeck wrote: >> On 3/11/21 1:17 PM, Chris Packham wrote: >>> On 11/03/21 9:18 pm, Wolfram Sang wrote: >>>>> Bummer. What is really weird is that you see clock stretching under >>

Re: [PATCH v3 2/2] hwmon: (pmbus/stpddc60) Add ST STPDDC60 pmbus driver

2021-03-11 Thread Guenter Roeck
On Thu, Feb 18, 2021 at 12:52:49PM +0100, Erik Rosen wrote: > Add hardware monitoring support for ST STPDDC60 Unversal Digital > Multicell Controller. > > Signed-off-by: Erik Rosen Applied but ... > --- a/drivers/hwmon/pmbus/Makefile > +++ b/drivers/hwmon/pmbus/Makefile > @@ -28,9 +28,11 @@ obj

Re: [PATCH v3 1/2] hwmon: (pmbus) Add pmbus_set_update() function to set update flag

2021-03-11 Thread Guenter Roeck
On Thu, Feb 18, 2021 at 12:52:48PM +0100, Erik Rosen wrote: > For the STPDDC60 chip, the vout alarm-limits are represented as an offset > relative to the commanded output voltage. This means that the limits are > dynamic and must not be cached by the pmbus driver. This patch adds a > pmbus_set_sens

Re: [PATCH v2] hwmon: (nct6883) Support NCT6686D

2021-03-11 Thread Guenter Roeck
Nuvoton NCT6683D/NCT6686D/NCT6687D eSIO > * > * Copyright (C) 2013 Guenter Roeck > * > @@ -12,6 +12,7 @@ > * > * Chip#vin#fan#pwm#temp chip ID > * nct6683d 21(1) 16 8 32(1) 0xc730 > + * nct6686d 21(1) 16 8

Re: [PATCH v2 2/2] hwmon: (pmbus): Add driver for Infineon IR36021

2021-03-11 Thread Guenter Roeck
On Mon, Mar 01, 2021 at 04:59:54PM +1300, Chris Packham wrote: > The IR36021 is a dual‐loop digital multi‐phase buck controller. > > Signed-off-by: Chris Packham Applied. Thanks, Guenter > --- > Changes in v2: > - update against latest kernel for pmbus API changes > - avoid double negation >

Re: [PATCH v2 1/2] dt-bindings: trivial-devices: Add infineon,ir36021

2021-03-11 Thread Guenter Roeck
On Mon, Mar 01, 2021 at 04:59:53PM +1300, Chris Packham wrote: > Add infineon,ir36021 to trivial-devices.yaml. > > Signed-off-by: Chris Packham > Acked-by: Rob Herring Applied. Thanks, Guenter > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertio

Re: [PATCH v2 5/9] hwmon/drivers/mr75203: Use HZ macros

2021-03-11 Thread Guenter Roeck
On Wed, Feb 24, 2021 at 03:42:15PM +0100, Daniel Lezcano wrote: > HZ unit conversion macros are available in units.h, use them and > remove the duplicate definition. I assume the idea is to submit the series together, so Acked-by: Guenter Roeck Guenter > > Signed-off-by: Da

Re: [PATCH] hwmon: corsair-psu: update calculation of LINEAR11 values

2021-03-11 Thread Guenter Roeck
On Sat, Feb 27, 2021 at 10:34:42AM +0100, Wilken Gottwalt wrote: > Changes the way how LINEAR11 values are calculated. The new method > increases the precision of 2-3 digits. > > old method: > corsairpsu-hid-3-1 > Adapter: HID adapter > v_in:230.00 V > v_out +12v:

Re: [PATCH] hwmon: Switch to using the new API kobj_to_dev()

2021-03-11 Thread Guenter Roeck
On Tue, Feb 23, 2021 at 05:14:27PM +0800, Yang Li wrote: > fixed the following coccicheck: > ./drivers/hwmon/hwmon.c:82:60-61: WARNING opportunity for kobj_to_dev() > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Applied. Thanks, Guenter > --- > drivers/hwmon/hwmon.c | 2 +- > 1 file c

Re: Errant readings on LM81 with T2080 SoC

2021-03-11 Thread Guenter Roeck
On 3/11/21 1:17 PM, Chris Packham wrote: > > On 11/03/21 9:18 pm, Wolfram Sang wrote: >>> Bummer. What is really weird is that you see clock stretching under >>> CPU load. Normally clock stretching is triggered by the device, not >>> by the host. >> One example: Some hosts need an interrupt per by

Re: Errant readings on LM81 with T2080 SoC

2021-03-11 Thread Guenter Roeck
On 3/11/21 12:18 AM, Wolfram Sang wrote: > >> Bummer. What is really weird is that you see clock stretching under >> CPU load. Normally clock stretching is triggered by the device, not >> by the host. > > One example: Some hosts need an interrupt per byte to know if they > should send ACK or NACK

Re: sensors-detect: Found unknown chip with ID 0x0404

2021-03-11 Thread Guenter Roeck
On 3/11/21 6:17 AM, Corentin Labbe wrote: > Hello > > I have a server where sensors-detecte gives: > Some Super I/O chips contain embedded sensors. We have to write to > standard I/O ports to probe them. This is usually safe. > Do you want to scan for Super I/O sensors? (YES/no): > Probing for Su

Re: Errant readings on LM81 with T2080 SoC

2021-03-10 Thread Guenter Roeck
On 3/10/21 1:48 PM, Chris Packham wrote: > > On 10/03/21 6:06 pm, Guenter Roeck wrote: >> On 3/9/21 6:19 PM, Chris Packham wrote: >>> On 9/03/21 9:27 am, Chris Packham wrote: >>>> On 8/03/21 5:59 pm, Guenter Roeck wrote: >>>>> Other than that, the

Re: [PATCH v1] usb: typec: tcpci: Refactor tcpc_presenting_cc1_rd macro

2021-03-10 Thread Guenter Roeck
1.1947316-1-bad...@google.com/ > > Signed-off-by: Badhri Jagan Sridharan Reviewed-by: Guenter Roeck Guenter > --- > drivers/usb/typec/tcpm/tcpci.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typ

Re: [PATCH 5.11 00/36] 5.11.6-rc1 review

2021-03-10 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Fri, 12 Mar 2021 13:23:09 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 437 pass: 437 fai

Re: [PATCH 5.10 00/47] 5.10.23-rc2 review

2021-03-10 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Fri, 12 Mar 2021 18:28:23 +. > Anything received after that time might be too late. > Build results: total: 156 pass: 156 fail: 0 Qemu test results: total: 432 pass: 432 fai

Re: [PATCH 5.4 00/24] 5.4.105-rc1 review

2021-03-10 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Fri, 12 Mar 2021 13:23:09 +. > Anything received after that time might be too late. > Build results: total: 157 pass: 157 fail: 0 Qemu test results: total: 431 pass: 431 fai

Re: [PATCH 4.19 00/39] 4.19.180-rc1 review

2021-03-10 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Fri, 12 Mar 2021 13:23:09 +. > Anything received after that time might be too late. > Build results: total: 155 pass: 155 fail: 0 Qemu test results: total: 420 pass: 4

Re: [PATCH 4.14 00/20] 4.14.225-rc1 review

2021-03-10 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Fri, 12 Mar 2021 13:23:09 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 406 pass: 4

Re: [PATCH 4.4 0/7] 4.4.261-rc1 review

2021-03-10 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Fri, 12 Mar 2021 13:23:09 +. > Anything received after that time might be too late. > Build results: total: 165 pass: 165 fail: 0 Qemu test results: total: 331 pass: 331 fai

Re: [PATCH 4.9 00/11] 4.9.261-rc1 review

2021-03-10 Thread Guenter Roeck
any issues with these being applied, please > let me know. > > Responses should be made by Fri, 12 Mar 2021 13:23:09 +. > Anything received after that time might be too late. > Build results: total: 168 pass: 168 fail: 0 Qemu test results: total: 383 pass: 383 fai

Re: [PATCH] watchdog: qcom: Move suspend/resume to suspend_late/resume_early

2021-03-10 Thread Guenter Roeck
ure that the watchdog > is suspended late and resumed early so that it can catch such issues. > > Signed-off-by: Sai Prakash Ranjan Reviewed-by: Guenter Roeck > --- > drivers/watchdog/qcom-wdt.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a

Re: [PATCH 5.10 00/49] 5.10.23-rc1 review

2021-03-10 Thread Guenter Roeck
On Wed, Mar 10, 2021 at 11:08:10PM +0530, Naresh Kamboju wrote: > On Wed, 10 Mar 2021 at 18:54, wrote: > > > > From: Greg Kroah-Hartman > > > > This is the start of the stable review cycle for the 5.10.23 release. > > There are 49 patches in this series, all will be posted as a response > > to th

Re: Errant readings on LM81 with T2080 SoC

2021-03-09 Thread Guenter Roeck
On 3/9/21 6:19 PM, Chris Packham wrote: > On 9/03/21 9:27 am, Chris Packham wrote: >> On 8/03/21 5:59 pm, Guenter Roeck wrote: >>> Other than that, the only other real idea I have would be to monitor >>> the i2c bus. >> I am in the fortunate position of bei

Re: [PATCH] hwmon: (adm9240): Don't re-read config/limits

2021-03-09 Thread Guenter Roeck
On 3/9/21 7:36 PM, Chris Packham wrote: > The hwmon chip is configured either via sysfs or by an earlier boot > stage (e.g. bootloader/bios). In the sysfs case we already store the > configuration values before it's written to the device. Reading in the > configuration only needs to be done once at

Re: Errant readings on LM81 with T2080 SoC

2021-03-09 Thread Guenter Roeck
On 3/9/21 3:35 PM, Chris Packham wrote: > > On 8/03/21 1:31 pm, Guenter Roeck wrote: >> On 3/7/21 2:52 PM, Chris Packham wrote: >>> Fundamentally I think this is a problem with the fact that the LM81 is >>> an SMBus device but the T2080 (and other Freescale SoCs) use

<    1   2   3   4   5   6   7   8   9   10   >