Re: linux-next: Fixes tag needs some work in the drivers-x86 tree

2021-03-08 Thread Hans de Goede
Hi, On 3/8/21 7:06 AM, Stephen Rothwell wrote: > Hi all, > > In commit > > b5b5ff84fd93 ("platform/surface: aggregator: Make > SSAM_DEFINE_SYNC_REQUEST_x define static functions") > > Fixes tag > > Fixes: 510c8114fc74 ("platform/surface: Add platform profile driver") > > has these

Re: [RFC PATCH v2 2/8] MAINTAINERS: Add entry for devm helpers

2021-03-08 Thread Hans de Goede
> diff --git a/MAINTAINERS b/MAINTAINERS > index d92f85ca831d..ffcb6e14 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5169,6 +5169,12 @@ M: Torben Mathiasen > S: Maintained > W: http://lanana.org/docs/device-list/index.html > > +DEVICE RESOURCE MANAGEME

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-07 Thread Hans de Goede
Hi, On 3/7/21 9:39 AM, Neftin, Sasha wrote: > On 3/5/2021 21:06, David E. Box wrote: >> Due to a HW limitation, the Latency Tolerance Reporting (LTR) value >> programmed in the Tiger Lake GBE controller is not large enough to allow >> the platform to enter Package C10, which in turn prevents the

Re: [PATCH] leds: trigger: fix potential deadlock with libata

2021-03-07 Thread Hans de Goede
Hi, On 3/7/21 5:13 PM, Pavel Machek wrote: > Hi! > >>> --- a/drivers/leds/led-triggers.c >>> +++ b/drivers/leds/led-triggers.c >>> @@ -378,14 +378,15 @@ void led_trigger_event(struct led_trigger *trig, >>> enum led_brightness brightness) >>> { >>> struct led_classdev

[PATCH v4 resend 13/13] ASoC: Intel: bytcr_wm5102: Add jack detect support

2021-03-07 Thread Hans de Goede
Add jack detect support by creating a jack and calling snd_soc_component_set_jack to register the created jack with the codec. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/intel/boards/bytcr_wm5102.c | 28 ++- 1 file changed, 27 insertions

[PATCH v4 resend 11/13] ASoC: arizona-jack: Cleanup logging

2021-03-07 Thread Hans de Goede
-by: Hans de Goede --- Changes in v4: - While at it also change (on adjescent lines) "if (ret != 0)" into "if (ret)" - Do not unnecessary split one of the dev_err_probe() calls over multiple lines Changes in v3: - This is a new patch in v3 of this patch-series --- sound/soc/c

[PATCH v4 resend 12/13] ASoC: arizona: Make the wm5102, wm5110, wm8997 and wm8998 drivers use the new jack library

2021-03-07 Thread Hans de Goede
y: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/wm5102.c | 12 +++- sound/soc/codecs/wm5110.c | 12 +++- sound/soc/codecs/wm8997.c | 14 -- sound/soc/codecs/wm8998.c | 9 + 4 files changed, 43 insertions(+), 4

[PATCH v4 resend 10/13] ASoC: arizona-jack: Use snd_soc_jack to report jack events

2021-03-07 Thread Hans de Goede
d-by: Andy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 149 +--- sound/soc/codecs/arizona.h | 7 +- 2 files changed, 47 insertions(+), 109 deletions(-) diff --git a/sound/

[PATCH v4 resend 08/13] ASoC: arizona-jack: Use arizona->dev for runtime-pm

2021-03-07 Thread Hans de Goede
ndy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 42 ++--- sound/soc/codecs/arizona.h | 1 - 2 files changed, 18 insertions(+), 25 deletions(-) diff --git a/sound/soc/codecs/arizona-jac

[PATCH v4 resend 06/13] ASoC/extcon: arizona: Move arizona jack code to sound/soc/codecs/arizona-jack.c

2021-03-07 Thread Hans de Goede
ound/soc/codecs/arizona-jack.c . This is a preparation patch for converting the arizona extcon-driver into a helper library for letting the arizona codec-drivers directly report jack state through the standard sound/soc/soc-jack.c functions. Acked-by: Charles Keepax Tested-by: Charles Keepax Acked-by: Chanwo

[PATCH v4 resend 07/13] ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv

2021-03-07 Thread Hans de Goede
. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 97 ++--- sound/soc/codecs/arizona.h | 36 2 files changed, 65 insertions(+), 68 deletions(-) diff

[PATCH v4 resend 09/13] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-03-07 Thread Hans de Goede
ted-by: Charles Keepax Signed-off-by: Hans de Goede --- Changes in v3: - Pass dev (the codec-device) to devm_regulator_get instead of passing arizona->dev. This is necessary so that the regulator gets properly released when the coded driver unbinds. --- sound/soc/codecs/Makefile | 2 +- sou

[PATCH v4 resend 03/13] extcon: arizona: Fix various races on driver unbind

2021-03-07 Thread Hans de Goede
-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 40 + 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index f7ef247de46a..76aacbac5869 100644 --- a/drivers/extcon/extcon-arizona.c

[PATCH v4 resend 05/13] extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake

2021-03-07 Thread Hans de Goede
(). Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Acked-by: Chanwoo Choi Signed-off-by: Hans de Goede --- Changes in v3: - This is a new patch in v3 of this patch-set --- drivers/extcon/extcon-arizona.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v4 resend 04/13] extcon: arizona: Fix flags parameter to the gpiod_get("wlf,micd-pol") call

2021-03-07 Thread Hans de Goede
ked-by: Charles Keepax Acked-by: Chanwoo Choi Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 76aacbac5869..72d23b15108c 100644 --- a/drivers/ext

[PATCH v4 resend 02/13] extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged

2021-03-07 Thread Hans de Goede
2 steps when arizona_hpdet_irq runs after the jack has been unplugged. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Acked-by: Chanwoo Choi Signed-off-by: Hans de Goede --- drivers/extcon/extcon-arizona.c | 17 + 1 file changed, 9 insertions(+),

[PATCH v4 resend 01/13] mfd: arizona: Drop arizona-extcon cells

2021-03-07 Thread Hans de Goede
es Signed-off-by: Hans de Goede --- drivers/mfd/arizona-core.c | 20 1 file changed, 20 deletions(-) diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c index 75f1bc671d59..ce6fe6de34f8 100644 --- a/drivers/mfd/arizona-core.c +++ b/drivers/mfd/arizona-core.c

[PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-03-07 Thread Hans de Goede
codec driver do this. This was developed and tested on a Lenovo Yoga Tablet 1051L with a WM5102 codec. This was also tested by Charles Keepax, one of the Cirrus Codec folks. Regards, Hans Hans de Goede (13): mfd: arizona: Drop arizona-extcon cells extcon: arizona: Fix some issues when HPDET

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Hans de Goede
Hi, On 3/5/21 5:25 PM, Andy Shevchenko wrote: > On Fri, Mar 5, 2021 at 6:14 PM Hans de Goede wrote: >> On 3/5/21 4:42 PM, Andy Shevchenko wrote: >>> On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote: >>>> On 3/4/21 11:11 AM, Andy Shevchenko wrote: >>>&g

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-05 Thread Hans de Goede
Hi, On 3/5/21 4:42 PM, Andy Shevchenko wrote: > On Thu, Mar 4, 2021 at 3:47 PM Hans de Goede wrote: >> On 3/4/21 11:11 AM, Andy Shevchenko wrote: >>> On Thu, Mar 4, 2021 at 8:36 AM Henning Schild >>> wrote: > > ... > >>>>

Re: [PATCH] platform/surface: aggregator: Make SSAM_DEFINE_SYNC_REQUEST_x define static functions

2021-03-04 Thread Hans de Goede
Hi, On 3/4/21 8:05 PM, Maximilian Luz wrote: > The SSAM_DEFINE_SYNC_REQUEST_x() macros are intended to reduce > boiler-plate code for SSAM request definitions by defining a wrapper > function for the specified request. The client device variants of those > macros, i.e.

Re: [V1,1/1] platform/x86: add support for Advantech software defined button

2021-03-04 Thread Hans de Goede
Hi Andrea, On 3/2/21 7:44 AM, andrea...@advantech.com.tw wrote: > From: "Andrea.Ho" > > Advantech sw_button is a ACPI event trigger button. > > With this driver, we can report KEY_EVENT on the > Advantech Tabletop Network Appliances products and it has been > tested in FWA1112VC. > > Add the

Re: [PATCH] WMI: asus: Reduce G14 and G15 match to min product name

2021-03-04 Thread Hans de Goede
Hi, On 2/27/21 11:20 AM, Luke D Jones wrote: > This patch reduces the product match for GA401 series laptops to > the minimum string required. > > The GA401 series of laptops has a lengthy list of product > variations in the 2020 series and the 2021 series refresh > is using the same base

Re: [PATCH v1] platform: x86: ACPI: Get rid of ACPICA message printing

2021-03-04 Thread Hans de Goede
Hi, On 2/24/21 7:41 PM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > A few x86 platform drivers use ACPI_DEBUG_PRINT() or ACPI_EXCEPTION() > for printing messages, but that is questionable, because those macros > belong to ACPICA and they should not be used elsewhere. In addition, >

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-04 Thread Hans de Goede
Hi, On 3/2/21 5:33 PM, Henning Schild wrote: > +static inline u32 simatic_ipc_get_station_id(u8 *data) > +{ > + u32 station_id = SIMATIC_IPC_INVALID_STATION_ID; > + int i; > + struct { > + u8 type; /* type (0xff = binary) */ > + u8 len;

Re: [PATCH 1/4] platform/x86: simatic-ipc: add main driver for Siemens devices

2021-03-04 Thread Hans de Goede
Hi, On 3/4/21 11:11 AM, Andy Shevchenko wrote: > On Thu, Mar 4, 2021 at 8:36 AM Henning Schild > wrote: >> >> From: Henning Schild >> >> This mainly implements detection of these devices and will allow >> secondary drivers to work on such machines. >> >> The identification is DMI-based with a

Re: [PATCH] platform/x86: intel-hid: Support Lenovo ThinkPad X1 Tablet Gen 2

2021-03-04 Thread Hans de Goede
Hi, On 2/22/21 3:15 PM, Alban Bedel wrote: > Like a few other system the Lenovo ThinkPad X1 Tablet Gen 2 miss the > HEBC method, which prevent the power button from working. Add a quirk > to enable the button array on this system family and fix the power > button. > > Signed-off-by: Alban Bedel

Re: [PATCH v3 0/6] Introduce intel_skl_int3472 module

2021-03-04 Thread Hans de Goede
Hi, On 2/22/21 2:07 PM, Daniel Scally wrote: > v1 for this series was originally 14-18 of this series: > https://lore.kernel.org/linux-media/20201130133129.1024662-1-djrsca...@gmail.com/T/#m91934e12e3d033da2e768e952ea3b4a125ee3e67 > > v2 was here: >

Re: [PATCH] platform/x86: Switch to using the new API kobj_to_dev()

2021-03-04 Thread Hans de Goede
Hi, On 2/22/21 8:00 AM, Yang Li wrote: > fixed the following coccicheck: > ./drivers/platform/x86/ideapad-laptop.c:523:60-61: WARNING opportunity > for kobj_to_dev() > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Patch does not apply, please resend it rebased on the latest

Re: [PATCH v3 2/2] platform/x86: hp-wmi: add platform profile support

2021-03-04 Thread Hans de Goede
Hi, On 2/21/21 11:13 PM, Elia Devito wrote: > Implement support for cool, balanced and performance thermal profile > > Signed-off-by: Elia Devito > --- > the "quiet" profile will be implemented with a further patch > > v2: added platform_profile_remove() missing call > v3: apply Barnabás

Re: [PATCH 1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile"

2021-03-04 Thread Hans de Goede
Hi, On 2/21/21 10:02 PM, Elia Devito wrote: > rename "thermal policy" with the more appropriate term "thermal profile" > > Signed-off-by: Elia Devito Thank you for your patch, I've applied this patch to my review-hans branch:

Re: [PATCH] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

2021-03-04 Thread Hans de Goede
Hi, On 3/4/21 12:59 PM, Borislav Petkov wrote: > On Thu, Mar 04, 2021 at 12:55:49PM +0100, Hans de Goede wrote: >> Since this documentation documents the interface exposed by: >> drivers/platform/x86/uv_sysfs.c >> >> I've applied this patch to the pdx86 tree now:

Re: [PATCH] x86/platform/uv: Fix indentation warning in Documentation/ABI/testing/sysfs-firmware-sgi_uv

2021-03-04 Thread Hans de Goede
Hi, On 2/19/21 6:28 PM, Justin Ernst wrote: > commit c9624cb7db1c ("x86/platform/uv: Update sysfs documentation") > > misplaced the first line of a codeblock section, causing the reported > warning message: > Documentation/ABI/testing/sysfs-firmware-sgi_uv:2: WARNING: Unexpected > indentation.

Re: [PATCH] platform/x86: fix typo in Kconfig

2021-03-04 Thread Hans de Goede
Hi, On 2/16/21 10:36 PM, Petr Vaněk wrote: > uses by -> used by > > Signed-off-by: Petr Vaněk Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in

Re: [PATCH v2 4/4] platform/surface: Add platform profile driver

2021-03-04 Thread Hans de Goede
Hi, On 2/11/21 9:17 PM, Maximilian Luz wrote: > Add a driver to provide platform profile support on 5th- and later > generation Microsoft Surface devices with a Surface System Aggregator > Module. On those devices, the platform profile can be used to influence > cooling behavior and power

Re: [PATCH v3 0/6] platform/surface: Add Surface Aggregator device registry

2021-03-04 Thread Hans de Goede
Hi, On 2/12/21 12:54 PM, Maximilian Luz wrote: > The Surface System Aggregator Module (SSAM) subsystem provides various > functionalities, which are separated by spreading them across multiple > devices and corresponding drivers. Parts of that functionality / some of > those devices, however, can

Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy

2021-03-04 Thread Hans de Goede
Hi, On 2/16/21 8:24 AM, Perry Yuan wrote: > Hi Hans: > > On 2021/1/13 2:37, Hans de Goede wrote: >> Hi, >> >> I know there already is a v3 out and I will try to get around to reviewing >> that soon, still 1 remark about the discussion surrounding v2: >>

Re: [PATCH V2 1/2] MFD: intel_pmt: Fix nuisance messages and handling of disabled capabilities

2021-02-24 Thread Hans de Goede
sabled by quirk to > prevent them from keeping the driver loaded if only disabled capabilities > are found. > > Fixes: 4f8217d5b0ca ("mfd: Intel Platform Monitoring Technology support") > Signed-off-by: David E. Box > Reviewed-by: Hans de Goede > --- > For merge in platfo

Re: [PATCH v1 1/1] i2c: cht-wc: Use fwnode for the controller and IRQ domain

2021-02-24 Thread Hans de Goede
Hi, On 2/24/21 1:51 PM, Andy Shevchenko wrote: > On Tue, Feb 23, 2021 at 08:25:35PM +0100, Hans de Goede wrote: >> On 2/23/21 6:22 PM, Andy Shevchenko wrote: >>> It's better to describe the I²C controller and associated IRQ domain with >>> fwnode, so they will find t

Re: [PATCH v1] platform: x86: ACPI: Get rid of ACPICA message printing

2021-02-24 Thread Hans de Goede
fixed the acer-wmi.c case a couple of weeks ago, and that fiox was merged into Linus' tree already: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ef14f0e82c9b225ae19476fa5bed89d55b2a96d5 I can drop the acer-wmi.c chunks when I merge this, so there is no need to send

Re: [PATCH v1 1/1] i2c: cht-wc: Use fwnode for the controller and IRQ domain

2021-02-23 Thread Hans de Goede
Hi, On 2/23/21 6:22 PM, Andy Shevchenko wrote: > It's better to describe the I²C controller and associated IRQ domain with > fwnode, so they will find their place in the hierarchy in sysfs and also > make easier to debug. > > Signed-off-by: Andy Shevchenko > --- > > Hans, unfortunately I have

Re: [PATCH v3 5/6] platform/x86: Add intel_skl_int3472 driver

2021-02-22 Thread Hans de Goede
Hi, On 2/22/21 2:19 PM, Daniel Scally wrote: > Hi all > > On 22/02/2021 13:07, Daniel Scally wrote: >> diff --git a/drivers/platform/x86/intel-int3472/Kconfig >> b/drivers/platform/x86/intel-int3472/Kconfig >> new file mode 100644 >> index ..b94622245c21 >> --- /dev/null >> +++

Re: [PATCH v3 2/2] platform/x86: hp-wmi: add platform profile support

2021-02-22 Thread Hans de Goede
Hi, On 2/21/21 11:13 PM, Elia Devito wrote: > Implement support for cool, balanced and performance thermal profile > > Signed-off-by: Elia Devito Thanks, patch looks good to me: Reviewed-by: Hans de Goede I will merge this once we are out of the merge-window / once 5.12-rc1 is out.

Re: [PATCH 1/2] platform/x86: hp-wmi: rename "thermal policy" to "thermal profile"

2021-02-22 Thread Hans de Goede
Hi, On 2/21/21 10:02 PM, Elia Devito wrote: > rename "thermal policy" with the more appropriate term "thermal profile" > > Signed-off-by: Elia Devito Thanks, patch looks good to me: Reviewed-by: Hans de Goede I will merge this once we are out of the merge-

Re: [PATCH] platform/x86: dell-wmi-sysman: correct an initialization failure

2021-02-19 Thread Hans de Goede
Hi, On 2/19/21 12:26 AM, Limonciello, Mario wrote: > > >> -Original Message- >> From: mark gross >> Sent: Thursday, February 18, 2021 16:49 >> To: Limonciello, Mario >> Cc: Hans De Goede; Mark Gross; LKML; platform-driver-...@vger.kernel.org; &

[PATCH 1/3] misc: lis3lv02d: Fix false-positive WARN on various HP models

2021-02-17 Thread Hans de Goede
bug.cgi?id=1817027 BugLink: https://bugs.centos.org/view.php?id=10720 Fixes: 1510dd5954be ("lis3lv02d: avoid divide by zero due to unchecked") Cc: sta...@vger.kernel.org Signed-off-by: Hans de Goede --- drivers/misc/lis3lv02d/lis3lv02d.c | 21 - 1 file changed, 16

[PATCH 2/3] misc: lis3lv02d: Change lis3lv02d_init_device() return value for unknown sensors to -ENODEV

2021-02-17 Thread Hans de Goede
will not be handling the device and it silences the pr_warn printing the third message. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=199715 Signed-off-by: Hans de Goede --- Note this does not resolve the bko 199715 bug, it merely silences the message which was used in the Summary when the bug was first

[PATCH 3/3] misc: lis3lv02d: Do not log an error when kmalloc fails

2021-02-17 Thread Hans de Goede
Logging an error when kmalloc fails is not necessary (and in general should be avoided) because the malloc failure will already complain loudly itself. Signed-off-by: Hans de Goede --- drivers/misc/lis3lv02d/lis3lv02d.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 4:29 PM, Rafael J. Wysocki wrote: > On Mon, Feb 15, 2021 at 4:22 PM Hans de Goede wrote: >> >> Hi, >> >> On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: >>> On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: >>>> >>>

Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: > On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: >> >> Hi, >> >> On 2/11/21 9:16 PM, Maximilian Luz wrote: >>> This series adds a driver to provide platform profile support on 5th- >>> a

Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 3:54 PM, Rafael J. Wysocki wrote: > On Mon, Feb 15, 2021 at 3:36 PM Hans de Goede wrote: >> >> Hi, >> >> On 2/11/21 9:16 PM, Maximilian Luz wrote: >>> This series adds a driver to provide platform profile support on 5th- >>> a

Re: [PATCH v2 0/4] platform/surface: Add platform profile driver for Surface devices

2021-02-15 Thread Hans de Goede
Changes in v2: > - Introduce new 'balanced-performance' platform profile and change >profile mapping in driver. > - Perform some fix-ups for the ACPI platform profile implementation: >- Fix some references to documentation in a comment. >- Hide CONFIG_ACPI_PLATFORM_PROFILE T

[GIT PULL] platform-drivers-x86 for 5.12-1

2021-02-15 Thread Hans de Goede
Make INTEL_PMT_CLASS non-user-selectable platform/x86: intel_pmt_telemetry: Add dependency on MFD_INTEL_PMT platform/x86: intel_pmt_crashlog: Add dependency on MFD_INTEL_PMT Geert Uytterhoeven (1): platform/surface: SURFACE_PLATFORMS should depend on ACPI Hans de Goede (19): platform/x86

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 12:31 PM, gre...@linuxfoundation.org wrote: > On Mon, Feb 15, 2021 at 11:37:26AM +0100, Hans de Goede wrote: >> Hi, >> >> On 2/15/21 8:22 AM, Vaittinen, Matti wrote: >>> >>> On Sat, 2021-02-13 at 16:59 +0100, Hans de Goede wrote: >>>&

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-15 Thread Hans de Goede
Hi, On 2/15/21 8:22 AM, Vaittinen, Matti wrote: > > On Sat, 2021-02-13 at 16:59 +0100, Hans de Goede wrote: >> Hi, >> >> On 2/13/21 4:27 PM, Guenter Roeck wrote: >>> On 2/13/21 7:03 AM, Hans de Goede wrote: >>> [ ... ] >>>> I think

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-13 Thread Hans de Goede
Hi, On 2/13/21 4:27 PM, Guenter Roeck wrote: > On 2/13/21 7:03 AM, Hans de Goede wrote: > [ ... ] >> >> I think something like this should work: >> >> static int devm_delayed_work_autocancel(struct device *dev, struct >> delayed_work *w, >>

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-13 Thread Hans de Goede
Hi, On 2/13/21 12:58 PM, Matti Vaittinen wrote: > A few drivers which need a delayed work-queue must cancel work at exit. > Some of those implement remove solely for this purpose. Help drivers > to avoid unnecessary remove and error-branch implementation by adding > managed verision of delayed

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-13 Thread Hans de Goede
Hi, On 2/13/21 3:38 PM, Hans de Goede wrote: > Hi, > > On 2/13/21 2:33 PM, Greg Kroah-Hartman wrote: > Having this new devm_delayed_work_autocancel() helper will allow a > bunch of drivers to move away from mixing the 2, which is a good thing > in my book. > > A

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-13 Thread Hans de Goede
Hi, On 2/13/21 2:33 PM, Greg Kroah-Hartman wrote: > On Sat, Feb 13, 2021 at 02:18:06PM +0100, Hans de Goede wrote: >> Hi, >> >> On 2/13/21 1:16 PM, Greg Kroah-Hartman wrote: >>> On Sat, Feb 13, 2021 at 01:58:44PM +0200, Matti Vaittinen wrote: >>>> A f

Re: [RFC PATCH 1/7] drivers: base: Add resource managed version of delayed work init

2021-02-13 Thread Hans de Goede
Hi, On 2/13/21 1:16 PM, Greg Kroah-Hartman wrote: > On Sat, Feb 13, 2021 at 01:58:44PM +0200, Matti Vaittinen wrote: >> A few drivers which need a delayed work-queue must cancel work at exit. >> Some of those implement remove solely for this purpose. Help drivers >> to avoid unnecessary remove

Re: [PATCH] platform/surface: Add platform profile driver

2021-02-11 Thread Hans de Goede
Hi, On 2/11/21 5:34 PM, Maximilian Luz wrote: > > > On 2/11/21 5:31 PM, Hans de Goede wrote: >> Hi, >> >> On 2/11/21 5:17 PM, Maximilian Luz wrote: >>> >>> >>> On 2/11/21 4:56 PM, Hans de Goede wrote: >>>> Hi, >>>> &

Re: [PATCH] platform/surface: Add platform profile driver

2021-02-11 Thread Hans de Goede
Hi, On 2/11/21 5:17 PM, Maximilian Luz wrote: > > > On 2/11/21 4:56 PM, Hans de Goede wrote: >> Hi, >> >> On 2/8/21 10:38 PM, Maximilian Luz wrote: >>> >>> >>> On 2/8/21 9:27 PM, Hans de Goede wrote: >> >> >>

Re: [PATCH] platform/surface: Add platform profile driver

2021-02-11 Thread Hans de Goede
Hi, On 2/8/21 10:38 PM, Maximilian Luz wrote: > > > On 2/8/21 9:27 PM, Hans de Goede wrote: >>> +static int convert_ssam_to_profile(struct ssam_device *sdev, enum >>> ssam_tmp_profile p) >>> +{ >>> +    switch (p) { >>>

Re: [PATCH] platform/x86: intel_scu_ipc: Increase virtual timeout from 3 to 5 seconds

2021-02-11 Thread Hans de Goede
Hi, On 2/10/21 8:20 PM, Casey Bowman wrote: > Increasing the virtual timeout time to account for scenarios > that may require more time, like DisplayPort Multi-Stream Transport > (DP MST), where the disconnect time can be extended longer than > usual. > > The recommended timeout range is 5-10

Re: [PATCH v2] platform/surface: aggregator: Fix access of unaligned value

2021-02-11 Thread Hans de Goede
Hi, On 2/11/21 1:41 PM, Maximilian Luz wrote: > The raw message frame length is unaligned and explicitly marked as > little endian. It should not be accessed without the appropriate > accessor functions. Fix this. > > Note that payload.len already contains the correct length after parsing > via

Re: [PATCH v1 0/9] x86/platform: Remove SFI framework and users

2021-02-11 Thread Hans de Goede
gt; delete mode 100644 >> arch/x86/platform/intel-mid/device_libs/platform_tc35876x.c >> delete mode 100644 >> arch/x86/platform/intel-mid/device_libs/platform_tca6416.c >> delete mode 100644 arch/x86/platform/intel-mid/sfi.c >> delete mode 100644 arch/x86/platform/sfi/Makefile >> delete mode 100644 arch/x86/platform/sfi/sfi.c >> delete mode 100644 drivers/cpufreq/sfi-cpufreq.c >> delete mode 100644 drivers/sfi/Kconfig >> delete mode 100644 drivers/sfi/Makefile >> delete mode 100644 drivers/sfi/sfi_acpi.c >> delete mode 100644 drivers/sfi/sfi_core.c >> delete mode 100644 drivers/sfi/sfi_core.h >> delete mode 100644 include/linux/sfi.h >> delete mode 100644 include/linux/sfi_acpi.h >> >> -- > > All of this looks good to me, so I'm going to queue it up for 5.12 > unless there are objections against doing that. That is fine by me (for the drivers/platform/x86 bits) : Acked-by: Hans de Goede Regards, Hans

Re: [PATCH -next] mfd: arizona: Make some symbols static

2021-02-10 Thread Hans de Goede
y: Wei Yongjun Thank you for catching this. Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/mfd/arizona-spi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c &g

Re: [PATCH] IOCTL support for dell-wmi-sysman driver

2021-02-09 Thread Hans de Goede
to need a long explanation why this is necessary over the existing sysfs API. To be honest ATM I'm not inclined to accept this patch and it is going to take some very strong arguments to change my mind. Regards, Hans > > Cc: Hans de Goede > > Signed-off-by: Prasanth KSR > Co-develo

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-09 Thread Hans de Goede
Hi, On 2/9/21 4:45 PM, Lee Jones wrote: > On Tue, 09 Feb 2021, Hans de Goede wrote: > >> Hi, >> >> On 2/9/21 3:14 PM, Lee Jones wrote: >>> On Mon, 08 Feb 2021, Hans de Goede wrote: >>> >>>> Hi Mark, Lee, >>>> >>>>

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-09 Thread Hans de Goede
Hi, On 2/9/21 3:14 PM, Lee Jones wrote: > On Mon, 08 Feb 2021, Hans de Goede wrote: > >> Hi Mark, Lee, >> >> On 2/4/21 12:24 PM, Hans de Goede wrote: >>> Hi all, >>> >>> Here is v4 of my series to rework the arizona codec jack-detect support &g

Re: drivers/platform/surface/surface3-wmi.c:60:14: warning: variable 'status' set but not used

2021-02-09 Thread Hans de Goede
Hi All, On 2/9/21 2:52 AM, kernel test robot wrote: > Hi Maximilian, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 61556703b610a104de324e4f061dc6cf7b218b46 > commit:

Re: [PATCH] platform/surface: Add platform profile driver

2021-02-08 Thread Hans de Goede
Hi, On 2/8/21 8:49 PM, Maximilian Luz wrote: > Add a driver to provide platform profile support on 5th- and later > generation Microsoft Surface devices with a Surface System Aggregator > Module. On those devices, the platform profile can be used to influence > cooling behavior and power

Re: [PATCH 0/6] platform/surface: Add Surface Aggregator device registry

2021-02-08 Thread Hans de Goede
Hi, On 2/8/21 9:04 PM, Maximilian Luz wrote: > On 2/8/21 8:55 PM, Hans de Goede wrote: >> Hi, >> >> On 2/8/21 8:35 PM, Maximilian Luz wrote: >>> The Surface System Aggregator Module (SSAM) subsystem provides various >>> functionalities, which are sepa

Re: [PATCH 0/6] platform/surface: Add Surface Aggregator device registry

2021-02-08 Thread Hans de Goede
Hi, On 2/8/21 8:35 PM, Maximilian Luz wrote: > The Surface System Aggregator Module (SSAM) subsystem provides various > functionalities, which are separated by spreading them across multiple > devices and corresponding drivers. Parts of that functionality / some of > those devices, however, can

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-08 Thread Hans de Goede
Hi Mark, Lee, On 2/4/21 12:24 PM, Hans de Goede wrote: > Hi all, > > Here is v4 of my series to rework the arizona codec jack-detect support > to use the snd_soc_jack helpers instead of direct extcon reporting. > > This is a resend with some extra *-by tags collected and with

Re: (subset) [PATCH v4 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-02-08 Thread Hans de Goede
Hi Mark, On 2/8/21 7:38 PM, Mark Brown wrote: > On Wed, 20 Jan 2021 22:49:52 +0100, Hans de Goede wrote: >> Here is v4 of my series to add support for Intel Bay Trail based devices >> which use a WM5102 codec for audio output/input. >> >> This was developed and tes

Re: [PATCH] Platform: OLPC: Constify static struct regulator_ops

2021-02-08 Thread Hans de Goede
Hi, On 2/7/21 12:21 AM, Rikard Falkeborn wrote: > The only usage of it is to assign its address to the ops field in the > regulator_desc struct, which is a pointer to const struct regulator_ops. > Make it const to allow the compiler to put it in read-only memory. > > Signed-off-by: Rikard

Re: [PATCH] platform/surface: Add Surface Hot-Plug driver

2021-02-08 Thread Hans de Goede
Hi, On 2/5/21 2:26 AM, Maximilian Luz wrote: > Some Surface Book 2 and 3 models have a discrete GPU (dGPU) that is > hot-pluggable. On those devices, the dGPU is contained in the base, > which can be separated from the tablet part (containing CPU and > touchscreen) while the device is running. >

Re: [PATCH] Input: synaptic - reverting dcb00fc799dc03fd320e123e4c81b3278c763ea5 because it breaks the touchpad for one guy on Reddit.

2021-02-07 Thread Hans de Goede
Hi, On 2/7/21 11:18 AM, Hans de Goede wrote: > Hi, > > On 2/7/21 4:50 AM, Colton Booth wrote: >> I can't test myself since I don't have the correct hardware, BUT this change >> seems to work for him. I'm thinking he has an early version of the X1E which >> may use

Re: [PATCH] Input: synaptic - reverting dcb00fc799dc03fd320e123e4c81b3278c763ea5 because it breaks the touchpad for one guy on Reddit.

2021-02-07 Thread Hans de Goede
Hi, On 2/7/21 4:50 AM, Colton Booth wrote: > I can't test myself since I don't have the correct hardware, BUT this change > seems to work for him. I'm thinking he has an early version of the X1E which > may use slightly different trackpad revision. Who is "him"? Do you have a bug-report link

[tip: irq/urgent] genirq: Prevent [devm_]irq_alloc_desc from returning irq 0

2021-02-05 Thread tip-bot2 for Hans de Goede
The following commit has been merged into the irq/urgent branch of tip: Commit-ID: 4c7bcb51ae25f79e3733982e5d0cd8ce8640ddfc Gitweb: https://git.kernel.org/tip/4c7bcb51ae25f79e3733982e5d0cd8ce8640ddfc Author:Hans de Goede AuthorDate:Mon, 21 Dec 2020 19:56:47 +01:00

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-05 Thread Hans de Goede
Hi, On 2/5/21 3:00 AM, Chanwoo Choi wrote: > On 2/4/21 8:24 PM, Hans de Goede wrote: >> Hi all, >> >> Here is v4 of my series to rework the arizona codec jack-detect support >> to use the snd_soc_jack helpers instead of direct extcon reporting. >> >> Thi

[PATCH 0/1] genirq: Fix [devm_]irq_alloc_desc returning irq 0

2021-02-04 Thread Hans de Goede
this, then please let me know. The WARN can also be avoided with a simple i915 driver patch, but this seems to be the more correct way to fix this. Regards, Hans Hans de Goede (1): genirq: Fix [devm_]irq_alloc_desc returning irq 0 include/linux/irq.h | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 1/1] genirq: Fix [devm_]irq_alloc_desc returning irq 0

2021-02-04 Thread Hans de Goede
end trace ceece38854223a0b ]--- Change the 'from' parameter passed to __[devm_]irq_alloc_descs() by the [devm_]irq_alloc_desc macros from 0 to 1, so that these macros will no longer return 0. Cc: Bjorn Helgaas Fixes: a85a6c86c25b ("driver core: platform: Clarify that IRQ 0 is invalid") Si

Re: [PATCH v3 5/5] ACPI: thermal: Clean up printing messages

2021-02-04 Thread Hans de Goede
ilitate easier identification of the message source. > > Signed-off-by: Rafael J. Wysocki > Reviewed-by: Hanjun Guo Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > v2 -> v3: Add R-by tag. > > v1 -> v2: Changelog update. >

Re: [PATCH v3 4/5] ACPI: video: Clean up printing messages

2021-02-04 Thread Hans de Goede
l definition which is not necessary any more > from acpi_video.c. > > Also make unrelated janitorial changes to fix up white space and > use ACPI_FAILURE() instead of negating ACPI_SUCCESS(). > > Signed-off-by: Rafael J. Wysocki Thanks, patch looks good to me: Reviewed-by: Hans de Goe

Re: [PATCH v3 2/5] ACPI: battery: Clean up printing messages

2021-02-04 Thread Hans de Goede
Hi, On 2/4/21 7:27 PM, Hans de Goede wrote: > Hi, > > On 2/3/21 7:44 PM, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> Replace the ACPI_DEBUG_PRINT() and ACPI_EXCEPTION() instances >> in battery.c with acpi_handle_debug() and acpi_handle_info() ca

Re: [PATCH v3 2/5] ACPI: battery: Clean up printing messages

2021-02-04 Thread Hans de Goede
y->device)) { > - ACPI_EXCEPTION((AE_INFO, AE_ERROR, "Evaluating _STA")); > + acpi_handle_info(battery->device->handle, > + "_STA evaluation failed\n"); Missing ": %s", acpi_format_e

Re: [PATCH v3 3/5] ACPI: button: Clean up printing messages

2021-02-04 Thread Hans de Goede
n from battery.c. > > Signed-off-by: Rafael J. Wysocki > Reviewed-by: Hanjun Guo Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > > v2 -> v3: Add R-by tag. > > v1 -> v2: Changelog update. > > --- > Docum

Re: [PATCH v3 1/5] ACPI: AC: Clean up printing messages

2021-02-04 Thread Hans de Goede
dingly. > > While at it, replace the direct printk() invocation with pr_info(), > add a pr_fmt() definition to ac.c and drop the unneeded PREFIX > symbol definition from there. > > Signed-off-by: Rafael J. Wysocki Thanks, patch looks good to me: Reviewed-by: Hans de Goede Rega

Re: [PATCH] platform/x86: ideapad-laptop/thinkpad_acpi: mark conflicting symbols static

2021-02-04 Thread Hans de Goede
Hi Arnd, On 2/4/21 4:38 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > Three of the newly added functions are accidently not marked 'static' which > causes a warning when building with W=1 > > drivers/platform/x86/thinkpad_acpi.c:10081:5: warning: no previous prototype > for function

Re: [PATCH v4 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec

2021-02-04 Thread Hans de Goede
Hi, On 2/4/21 1:43 PM, Mark Brown wrote: > On Thu, Feb 04, 2021 at 12:07:49PM +0100, Hans de Goede wrote: >> On 2/4/21 11:57 AM, Lee Jones wrote: >>> On Thu, 04 Feb 2021, Hans de Goede wrote: > >>>> series are both ready for merging. All patches have Reviewed

Re: [PATCH v2] platform/x86: Move all dell drivers to their own subdirectory

2021-02-04 Thread Hans de Goede
Hi, On 2/3/21 8:58 PM, Mario Limonciello wrote: > A user without a Dell system doesn't need to pick any of these > drivers. > > Users with a Dell system can enable this submenu and all drivers > behind it will be enabled. > > Suggested-by: Andy Shevchenko > Signed-off-by: Mario Limonciello

Re: drivers/platform/surface/surface3-wmi.c:60:14: warning: variable 'status' set but not used

2021-02-04 Thread Hans de Goede
Hi, On 1/4/21 4:24 PM, Maximilian Luz wrote: > On 1/4/21 3:52 PM, Hans de Goede wrote: >> Hi, >> >> On 12/29/20 4:58 AM, kernel test robot wrote: >>> Hi Maximilian, >>> >>> FYI, the error/warning still remains. >>> >>> tree:  

[PATCH v4 resend 07/13] ASoC: arizona-jack: Move jack-detect variables to struct arizona_priv

2021-02-04 Thread Hans de Goede
. Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- sound/soc/codecs/arizona-jack.c | 97 ++--- sound/soc/codecs/arizona.h | 36 2 files changed, 65 insertions(+), 68 deletions(-) diff

[PATCH v4 resend 05/13] extcon: arizona: Always use pm_runtime_get_sync() when we need the device to be awake

2021-02-04 Thread Hans de Goede
(). Reviewed-by: Andy Shevchenko Acked-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Hans de Goede --- Changes in v3: - This is a new patch in v3 of this patch-set --- drivers/extcon/extcon-arizona.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/extcon

[PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-02-04 Thread Hans de Goede
ers may we have your ack for merging these through the MFD tree ? Regards, Hans Hans de Goede (13): mfd: arizona: Drop arizona-extcon cells extcon: arizona: Fix some issues when HPDET IRQ fires after the jack has been unplugged extcon: arizona: Fix various races on driver unbind

[PATCH v4 resend 09/13] ASoC: arizona-jack: convert into a helper library for codec drivers

2021-02-04 Thread Hans de Goede
ted-by: Charles Keepax Signed-off-by: Hans de Goede --- Changes in v3: - Pass dev (the codec-device) to devm_regulator_get instead of passing arizona->dev. This is necessary so that the regulator gets properly released when the coded driver unbinds. --- sound/soc/codecs/Makefile | 2 +- sou

[PATCH v4 resend 13/13] ASoC: Intel: bytcr_wm5102: Add jack detect support

2021-02-04 Thread Hans de Goede
Add jack detect support by creating a jack and calling snd_soc_component_set_jack to register the created jack with the codec. Reviewed-by: Andy Shevchenko Signed-off-by: Hans de Goede --- sound/soc/intel/boards/bytcr_wm5102.c | 28 ++- 1 file changed, 27 insertions

[PATCH v4 resend 11/13] ASoC: arizona-jack: Cleanup logging

2021-02-04 Thread Hans de Goede
-by: Hans de Goede --- Changes in v4: - While at it also change (on adjescent lines) "if (ret != 0)" into "if (ret)" - Do not unnecessary split one of the dev_err_probe() calls over multiple lines Changes in v3: - This is a new patch in v3 of this patch-series --- sound/soc/c

<    1   2   3   4   5   6   7   8   9   10   >