de Goede
Cc: Andy Shevchenko
Cc: mark gross
Co-developed-by: Mario Limonciello
Signed-off-by: Mario Limonciello
Co-developed-by: Prasanth KSR
Signed-off-by: Prasanth KSR
Signed-off-by: Divya Bharathi
---
Changes from v3 to v4:
- Create a firmware-attributes class and tie ksets
Cc: Rajat Jain
Cc: platform-driver-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Reported-by: Maximilian Luz
Fixes: b02f6a2ef0a1 ("platform/x86: intel_pmc_core: Attach using APCI HID
"INT33A1"")
Signed-off-by: Greg Kroah-Hartman
Patch looks good to me:
Rev
Hi,
On 9/21/20 8:23 PM, Limonciello, Mario wrote:
+
+ "integer"-type specific properties:
+
+ min_value: A file that can be read to obtain the lower
+ bound value of the
+
+ max_value: A file that can be read to obtain the
Hi,
On 9/22/20 10:57 AM, Hans de Goede wrote:
Hi,
On 9/21/20 5:26 PM, Limonciello, Mario wrote:
I will do another more detailed reply in another email, but I would like to
focus
at the main pain point here, which is the using a generic sysfs-ABI/class vs
using
a Dell specific sysfs-ABI
Hi,
On 9/21/20 5:26 PM, Limonciello, Mario wrote:
Well if different schemes are supported and each scheme has its own type,
then I would expect there to be say / e.g.:
/sys/class/firmware-attributes/dell/authentication/admin-password
(with a type of "password") and:
Hi,
On 9/21/20 5:26 PM, Limonciello, Mario wrote:
I will do another more detailed reply in another email, but I would like to
focus
at the main pain point here, which is the using a generic sysfs-ABI/class vs
using
a Dell specific sysfs-ABI.
I guess a could way to look at the generic
Hi,
On 9/21/20 3:57 PM, Alexander Duyck wrote:
On Mon, Sep 21, 2020 at 6:16 AM Hans de Goede wrote:
Hi,
On 9/17/20 11:35 PM, Alexander Duyck wrote:
On Thu, Sep 17, 2020 at 5:12 AM Hans de Goede wrote:
Hi,
On 9/15/20 12:35 AM, Alexander Duyck wrote:
On Mon, Sep 14, 2020 at 11:07 AM
Hi,
On 9/21/20 3:11 PM, Qinglang Miao wrote:
Simplify the return expression.
Signed-off-by: Qinglang Miao
Thank you, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/virt/vboxguest/vboxguest_linux.c | 7 +--
1 file changed, 1 insertion(+), 6
Hi,
On 9/17/20 11:35 PM, Alexander Duyck wrote:
On Thu, Sep 17, 2020 at 5:12 AM Hans de Goede wrote:
Hi,
On 9/15/20 12:35 AM, Alexander Duyck wrote:
On Mon, Sep 14, 2020 at 11:07 AM Alexander Duyck
wrote:
On Mon, Sep 14, 2020 at 6:42 AM Hans de Goede wrote:
Hi,
On 9/11/20 9:45 PM
Hi,
On 9/17/20 11:35 PM, Alexander Duyck wrote:
On Thu, Sep 17, 2020 at 5:12 AM Hans de Goede wrote:
Hi,
On 9/15/20 12:35 AM, Alexander Duyck wrote:
On Mon, Sep 14, 2020 at 11:07 AM Alexander Duyck
wrote:
On Mon, Sep 14, 2020 at 6:42 AM Hans de Goede wrote:
Hi,
On 9/11/20 9:45 PM
available in Setup (F2) screen.
Cc: Hans de Goede
Cc: Andy Shevchenko
Cc: mark gross
Co-developed-by: Mario Limonciello
Signed-off-by: Mario Limonciello
Co-developed-by: Prasanth KSR
Signed-off-by: Prasanth KSR
Signed-off-by: Divya Bharathi
---
Changes from v2 to v3:
- Fix a possible NULL
interface. To facilitate this, the patch
introduces a generic way for driver to be able to create
configurable BIOS Attributes available in Setup (F2) screen.
Cc: Hans de Goede
Cc: Andy Shevchenko
Cc: mark gross
Co-developed-by: Mario Limonciello
Signed-off-by: Mario Limonciello
Co-developed
Hi,
On 9/17/20 6:18 PM, Limonciello, Mario wrote:
Those are very different flows to get to and change the same "types" of
data. By Dell's interface
being Dell specific we can guarantee that the documented flow works how it
should.
Documenting the flow could be part of the documentation for
Hi,
On 9/17/20 7:22 AM, Bharathi, Divya wrote:
+
+/**
+ * exit_enum_attributes() - Clear all attribute data
+ * @kset: The kset to free
+ *
+ * Clears all data allocated for this group of attributes **/ void
+exit_enum_attributes(struct kset *kset) {
+ struct kobject *pos, *next;
+
+
Hi,
On 9/15/20 6:28 PM, Bharathi, Divya wrote:
+/* kept variable names same as in sysfs file name for sysfs_show
+macro
definition */
+struct enumeration_data {
+ char display_name_language_code[MAX_BUFF];
+ char attribute_name[MAX_BUFF];
+ char display_name[MAX_BUFF];
+
Hi,
On 9/14/20 7:12 PM, Limonciello, Mario wrote:
+static int call_biosattributes_interface(struct wmi_device *wdev, char
*in_args, size_t size,
+ int method_id)
+{
+ struct acpi_buffer output = {ACPI_ALLOCATE_BUFFER, NULL};
+ struct
S is subordinate to NEW_LEDS.
Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
Reported-by: Hans de Goede
Fixes: d89bcc83e709 ("platform/x86: fujitsu-laptop: select LEDS_CLASS")
Signed-off-by: Necip Fazil Yildiran
Thank you, patch looks good to me:
Reviewed-by
a followup to "platform/x86: asus-wmi: Fix SW_TABLET_MODE
always reporting 1 on many different models" by Hans de Goede.
Signed-off-by: Samuel Čavoj
Cc: Hans de Goede
---
v1 -> v2:
- inherit wmi_backlight_set_devstate from default quirk
v2 looks good to me:
Reviewed-by: Hans de
Hi,
On 9/17/20 3:12 PM, Samuel Čavoj wrote:
Hi.
On 17.09.2020 14:23, Hans de Goede wrote:
Hi,
On 9/16/20 9:12 PM, Samuel Čavoj wrote:
The UX360CA has a WMI device id 0x00060062, which reports whether the
lid is flipped in tablet mode (1) or in normal laptop mode (0).
This commit adds
a followup to "platform/x86: asus-wmi: Fix SW_TABLET_MODE
always reporting 1 on many different models" by Hans de Goede.
Signed-off-by: Samuel Čavoj
Cc: Hans de Goede
---
drivers/platform/x86/asus-nb-wmi.c | 14 +
drivers/platform/x86/asus-w
move kconfig dependency warnings.
Fixes: dbf0c5a6b1f8 ("platform/x86: Add LG Gram laptop special features driver")
Signed-off-by: Necip Fazil Yildiran
Thnak you, patch looks good to me:
Reviewed-by: Hans de Goede
Note it seems that the FUJITSU_LAPTOP Kconfig symbol has the same
issue, can yo
Hi,
On 9/15/20 12:35 AM, Alexander Duyck wrote:
On Mon, Sep 14, 2020 at 11:07 AM Alexander Duyck
wrote:
On Mon, Sep 14, 2020 at 6:42 AM Hans de Goede wrote:
Hi,
On 9/11/20 9:45 PM, David E. Box wrote:
From: Alexander Duyck
Add support for the Intel Platform Monitoring Technology
Hi,
On 9/14/20 8:07 PM, Alexander Duyck wrote:
On Mon, Sep 14, 2020 at 6:42 AM Hans de Goede wrote:
Hi,
On 9/11/20 9:45 PM, David E. Box wrote:
From: Alexander Duyck
Add support for the Intel Platform Monitoring Technology crashlog
interface. This interface provides a few sysfs values
Hi,
On 9/14/20 7:02 PM, Elia Devito wrote:
HP Spectre notebooks (and probabily other model as well)
support at least 3 thermal policy:
- Default
- Performance
- Cool
the correct thermal policy configuration make the firmware to correctly
set OEM variables for Intel DPTF and optimize fan
Hi,
On 9/14/20 6:06 PM, Limonciello, Mario wrote:
So my thinking here is as follows:
1. AFAIK other vendors may want to do something similar in the near future
2. The interface you (Dell) have come up with looks pretty generic / complete
to me
Dell sets precedent here by having the first
Hi,
On 9/15/20 6:03 PM, Colin King wrote:
From: Colin Ian King
The comparison of signed char constants with unsigned char array
elements leads to checks that are always false. Fix this by declaring
the VBSF_MOUNT_SIGNATURE_BYTE* macros as octal unsigned int constants
rather than as signed
Hi,
Like last-time I will split this review in 2,
this second email focusses on the code.
Note I'm still mainly focusing on the overall
structure and how you handle locking here.
Further reviews (of newer versions) will look
at the per function code in more detail.
On 9/4/20 4:28 PM, Divya
Hi,
On 9/11/20 9:45 PM, David E. Box wrote:
Add PMT support for Alder Lake (ADL). Use same quirks as Tiger Lake since
the design is the same, meaning no support for Watcher or Crashlog.
Signed-off-by: David E. Box
Looks good to me:
Acked-by: Hans de Goede
Lee, I expect you will pick
Hi,
On 9/11/20 9:45 PM, David E. Box wrote:
From: Alexander Duyck
Add support for the Intel Platform Monitoring Technology crashlog
interface. This interface provides a few sysfs values to allow for
controlling the crashlog telemetry interface as well as a character driver
to allow for
Hi,
On 9/11/20 9:45 PM, David E. Box wrote:
Add Out of Band Management Services Module device ID to Intel PMT driver.
Signed-off-by: Alexander Duyck
Signed-off-by: David E. Box
Looks good to me:
Acked-by: Hans de Goede
Lee, I expect you will pick this-one up (and the next also
Dell Systems.
This driver allows user to configure Dell systems with a
uniform common interface. To facilitate this, the patch
introduces a generic way for driver to be able to create
configurable BIOS Attributes available in Setup (F2) screen.
Cc: Hans de Goede
Cc: Andy Shevchenko
Co-developed
Hi,
On 9/3/20 4:27 PM, Limonciello, Mario wrote:
+ /* look up if user set a password for the requests */
+ current_password = get_current_password("Admin");
+ if (!current_password)
+ return -ENODEV;
Can we instead of passing "Admin" and "System" to this function
Hi,
On 9/1/20 4:17 PM, Limonciello, Mario wrote:
So first of all some comments on the userspace (sysfs) API for that. Getting
this
part right is the most important part of this patch, as that will be set in
stone
once merged.
My first reaction to the suggest API is that I find the sorting
Hi,
On 9/1/20 4:17 PM, Limonciello, Mario wrote:
So first of all some comments on the userspace (sysfs) API for that. Getting
this
part right is the most important part of this patch, as that will be set in
stone
once merged.
My first reaction to the suggest API is that I find the sorting
Hi,
On 9/14/20 10:45 AM, Hans de Goede wrote:
+ lower_bound: A file that can be read to obtain the lower
+ bound value of the
+
+ modifier: A file that can be read to obtain attribute-level
+ dependency rule which has to be met to configure
Hi,
Sorry for being slow with getting back to you on this.
On 9/1/20 4:22 PM, Limonciello, Mario wrote:
"A read-only attribute enumerating if a reboot is pending on any BIOS attribute
change."
does not really seem to make much sense. I guess what this is trying to say is:
"This read-only
et si = so so then this can also not happen.
I can understand the static-analyzer warning about this, and fixing
that warning is good. But I doubt that this warrants a fixes tag.
So with the Fixes tag dropped this is:
Reviewed-by: Hans de Goede
Signed-off-by: Tom Rix
---
drivers/platform/x86/thinkp
Hi,
On 9/14/20 8:54 AM, Liu Shixin wrote:
module_platform_driver() makes the code simpler by eliminating
boilerplate code.
Signed-off-by: Liu Shixin
Thank you for the cleanup, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/extcon/extcon-axp288.c | 13
Hi,
On 9/11/20 12:31 AM, Samuel Čavoj wrote:
Hello!
On 10.09.2020 19:44, Hans de Goede wrote:
Hi,
On 9/4/20 7:17 PM, Samuel Čavoj wrote:
Hi,
On 04.09.2020 12:06, Hans de Goede wrote:
Hi,
On 9/4/20 11:45 AM, Samuel Čavoj wrote:
Hello!
On 02.09.2020 14:52, Samuel Čavoj wrote:
Hello
de Goede
Regards,
Hans
---
fs/vboxsf/vboxsf_wrappers.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/vboxsf/vboxsf_wrappers.c b/fs/vboxsf/vboxsf_wrappers.c
index bfc78a097dae..3b6630e2847d 100644
--- a/fs/vboxsf/vboxsf_wrappers.c
+++ b/fs/vboxsf/vboxsf_wrappers.c
Hi,
On 9/4/20 7:17 PM, Samuel Čavoj wrote:
Hi,
On 04.09.2020 12:06, Hans de Goede wrote:
Hi,
On 9/4/20 11:45 AM, Samuel Čavoj wrote:
Hello!
On 02.09.2020 14:52, Samuel Čavoj wrote:
Hello,
On 02.09.2020 13:52, Hans de Goede wrote:
But I would rather try to figure out a better way. Can
Hi,
On 9/8/20 1:04 PM, Stephen Rothwell wrote:
Hi Hans,
On Tue, 8 Sep 2020 10:22:06 +0200 Hans de Goede wrote:
On 9/8/20 6:00 AM, Stephen Rothwell wrote:
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/gpu/drm/i915/display/intel_panel.c
between commit
Hi Stephen,
On 9/8/20 6:00 AM, Stephen Rothwell wrote:
Hi all,
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/gpu/drm/i915/display/intel_panel.c
between commit:
f8bd54d21904 ("drm/i915: panel: Use atomic PWM API for devs with an external PWM
controller")
point it mainly becomes a power-saving
feature).
So if the BYD zhaoxin notebook has the same issue, then
adding a quirk to disable remote-wakeup is likely still the
right thing to do. But first I would like to understand the
problem better.
Regards,
Hans
在 2020/9/4 下午6:05, Hans de Goede 写道
Hi,
On 9/4/20 11:13 AM, Penghao wrote:
Add a USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for the BYD zhaoxin notebook.
This notebook come with usb touchpad. And we would like to disable touchpad
wakeup on this notebook by default.
You are still not explaining why this is necessary ?
And you did not
Hi,
On 9/3/20 12:03 PM, Penghao wrote:
Add a USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for the BYD zhaoxin notebook.
This notebook come with usb touchpad. And we would like to disable touchpad
wakeup on this notebook by default.
2 questions:
1. Why do you want to enable remote wakeup by default ?
Hi,
On 9/1/20 11:55 PM, Samuel Čavoj wrote:
Hello!
A bug was introduced with the following commit[1]:
b0dbd97de: platform/x86: asus-wmi: Add support for SW_TABLET_MODE
The SW_TABLET_MODE switch seems to be always 1 on some devices,
including my UX360CA and a UX390UAK[2].
This can be
Hi,
So as promised a third mail with a review focused some more on the code.
On 7/30/20 4:31 PM, Divya Bharathi wrote:
From: Divya Bharathi
The Dell WMI Systems Management Driver provides a sysfs
interface for systems management to enable BIOS configuration
capability on certain Dell
Hi,
I promised a second review focussed on the code, but first a bit more
detailed review of the sysfs-files for the different attribute types...
On 7/30/20 4:31 PM, Divya Bharathi wrote:
From: Divya Bharathi
The Dell WMI Systems Management Driver provides a sysfs
interface for systems
Hi All,
Going forward I will be helping Andy and Darren with maintaining the
drivers/platform/x86/* drivers.
So one of the first things which I'm doing with that hat on,
is review this patch.
On 7/30/20 4:31 PM, Divya Bharathi wrote:
From: Divya Bharathi
The Dell WMI Systems Management
.
Regards,
Hans
Thanks,
Badhri
On Tue, Jul 14, 2020 at 6:55 AM Lee Jones wrote:
On Tue, 14 Jul 2020, Hans de Goede wrote:
Hi,
On 7/6/20 4:20 PM, Lee Jones wrote:
On Mon, 06 Jul 2020, Hans de Goede wrote:
Hi,
On 7/6/20 3:33 PM, Lee Jones wrote:
Looks as though a079973f462a3 (&quo
Hi,
As someone who has added the if (error != -EPROBE_DEFER) dev_err()
pattern in way too many places myself, I'm quite happy to see this
new (I presume?) helper and this nice cleanup series.
The entire series looks good to me, and you can add my:
Reviewed-by: Hans de Goede
To the entire
Hi Dmitry,
On 7/22/20 7:41 AM, Dmitry Torokhov wrote:
On Sun, Jul 19, 2020 at 07:56:49PM -0300, Henrique de Moraes Holschuh wrote:
On Fri, 17 Jul 2020, Hans de Goede wrote:
This is a simple patch-series adding support for 3 new hotkeys found
on various new Lenovo Thinkpad models.
For all
Hi,
On 8/24/20 2:53 PM, Denis Efremov wrote:
Modify vbg_misc_device_requestor() to use current_uid() wrapper.
Signed-off-by: Denis Efremov
Thank you, patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
drivers/virt/vboxguest/vboxguest_linux.c | 2 +-
1 file
Hi,
On 8/11/20 8:00 AM, Kai-Heng Feng wrote:
Hi Hans,
On Aug 11, 2020, at 00:13, Hans de Goede wrote:
Hi,
On 10-08-2020 16:29, Kai-Heng Feng wrote:
Goodix touchpad fails to operate in I2C mode after system suspend.
According to the vendor, Windows is more forgiving and there's a 60ms
Hi,
On 10-08-2020 16:29, Kai-Heng Feng wrote:
Goodix touchpad fails to operate in I2C mode after system suspend.
According to the vendor, Windows is more forgiving and there's a 60ms
delay after SET_POWER ON command.
So let's do the same here, to workaround for the touchpads that depend
on
Hi,
On 7/27/20 2:50 AM, Henrique de Moraes Holschuh wrote:
On Tue, 21 Jul 2020, Dmitry Torokhov wrote:
On Sun, Jul 19, 2020 at 07:56:49PM -0300, Henrique de Moraes Holschuh wrote:
On Fri, 17 Jul 2020, Hans de Goede wrote:
This is a simple patch-series adding support for 3 new hotkeys found
Hi,
On 7/21/20 4:37 AM, Nicolas Boichat wrote:
HCI_UART_RESET_ON_INIT belongs in hdev_flags, not flags.
Fixes: ce945552fde4a09 ("Bluetooth: hci_h5: Add support for serdev enumerated
devices")
Signed-off-by: Nicolas Boichat
Patch looks good to me:
Reviewed-by: Hans de Goede
incoming calls"
This commit adds support for these 3 new hotkeys.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.
of starting at 0x27b.
Signed-off-by: Hans de Goede
---
include/uapi/linux/input-event-codes.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/uapi/linux/input-event-codes.h
b/include/uapi/linux/input-event-codes.h
index b6a835d37826..8d605a6df502 100644
--- a/include/uapi/l
keycode for it."
Support for this "snip" key seems like it is also a good match for the
clipping/snipping tool hotkey, so map this hotkey to the new
KEY_SELECTIVE_SCREENSHOT key-code.
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 file changed, 1 in
Hi All,
This is a simple patch-series adding support for 3 new hotkeys found
on various new Lenovo Thinkpad models.
There is one small complication, these 3 new hotkeys also require
the addition of new key-codes to include/uapi/linux/input-event-codes.h.
And those changes have to land first. It
Hi,
On 7/14/20 5:32 PM, Pierre-Louis Bossart wrote:
On 7/14/20 8:33 AM, Hans de Goede wrote:
Hi,
On 7/14/20 10:09 AM, Jing Xiangfeng wrote:
snd_byt_cht_es8316_mc_probe() misses to call put_device() in an error
path. Add the missed function call to fix it.
Fixes: ba49cf6f8e4a ("ASoC:
g
Patch looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
sound/soc/intel/boards/bytcht_es8316.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/intel/boards/bytcht_es8316.c
b/sound/soc/intel/boards/bytcht_es8316.c
index 9e5fc9430628..ecbc58e8a
Hi,
On 7/6/20 4:20 PM, Lee Jones wrote:
On Mon, 06 Jul 2020, Hans de Goede wrote:
Hi,
On 7/6/20 3:33 PM, Lee Jones wrote:
Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config
configuration mechanism") pulled out the only use of 'tcpm_altmode_ops'
last year. No ne
Hi,
On 7/14/20 10:27 AM, Andy Shevchenko wrote:
On Tue, Jul 14, 2020 at 11:21 AM Andy Shevchenko
wrote:
On Tue, Jul 14, 2020 at 11:15 AM Hans de Goede wrote:
Commit 35d13c7a0512 ("platform/x86: thinkpad_acpi: Use strndup_user()
in dispatch_proc_write()") cleaned up dispatch_
extra
junk at the end.
Fixes: 35d13c7a0512 ("platform/x86: thinkpad_acpi: Use strndup_user() in
dispatch_proc_write()")
Signed-off-by: Hans de Goede
---
drivers/platform/x86/thinkpad_acpi.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x8
A. Klimov
The "new" https link works for me and I see no reason why
not to do this, other then that some weird site might still
only do http, so:
Reviewed-by: Hans de Goede
(oh on second reading I see that the script already checks
that the new link works, ah well)
Rega
Hi,
On 7/6/20 4:20 PM, Lee Jones wrote:
On Mon, 06 Jul 2020, Hans de Goede wrote:
Hi,
On 7/6/20 3:33 PM, Lee Jones wrote:
Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config
configuration mechanism") pulled out the only use of 'tcpm_altmode_ops'
last year. No ne
://bugzilla.redhat.com/show_bug.cgi?id=1789545
Acked-by: Arnd Bergmann
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 ++
include/uapi/linux/vbox_vmmdev_types.h | 3 +++
2 files changed, 5 insertions(+)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers
The session lock is a mutex, not a spinlock, fix the comments to match.
Acked-by: Arnd Bergmann
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers
Rename guest_caps[_tracker] struct members to set_guest_caps[_tracker]
this is a preparation patch for adding support for the
VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Acked-by: Arnd Bergmann
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 20 ++--
drivers
Add vbg_set_host_capabilities() helper function, this is a preparation
patch for adding support for the VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Acked-by: Arnd Bergmann
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 79 ++---
1 file changed, 46
Every now and then upstream adds new ioctls without notifying us,
log unknown ioctl requests as an error to catch these.
Acked-by: Arnd Bergmann
Signed-off-by: Hans de Goede
---
Changes in v2:
- Rate-limit the error logging to avoid userspace potentially DOS-ing the log
---
drivers/virt
=1789545
Acked-by: Arnd Bergmann
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 163 +++-
drivers/virt/vboxguest/vboxguest_core.h | 14 ++
include/uapi/linux/vboxguest.h | 24
3 files changed, 200 insertions(+), 1 deletion(-)
diff
Hi Greg,
As requested by Arnd, here is a resend of v2 of my vboxguest driver patch-set,
adding support for the new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl, with
Arnd's Acked-by added. Can you pick this up and merge it into the next
branch of your char/misc tree?
Regards,
Hans
.org
Acked-by: Arnd Bergmann
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 +-
drivers/virt/vboxguest/vmmdev.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest/vboxguest_co
request defines so as
to not break the kernel ABI in case someone has been using the old
request defines.
Fixes: f6ddd094f579 ("virt: Add vboxguest driver for Virtual Box Guest
integration UAPI")
Cc: sta...@vger.kernel.org
Acked-by: Arnd Bergmann
Reviewed-by: Arnd Bergmann
Signed-off-by: Han
disable the wakeup by default, but enable the wakeup capability
so users can enable it at their own discretion.
Signed-off-by: Kai-Heng Feng
Thank you, this version looks good to me:
Reviewed-by: Hans de Goede
Regards,
Hans
---
v4:
- Enable the capability, but disable the wakeup default
Hi,
On 7/8/20 1:55 PM, Luis Chamberlain wrote:
On Wed, Jul 08, 2020 at 01:37:41PM +0200, Hans de Goede wrote:
Hi,
On 7/8/20 1:01 PM, Hans de Goede wrote:
Hi,
On 7/7/20 10:19 AM, Kees Cook wrote:
Hi,
In looking for closely at the additions that got made to the
kernel_read_file() enums, I
Hi,
On 7/8/20 1:01 PM, Hans de Goede wrote:
Hi,
On 7/7/20 10:19 AM, Kees Cook wrote:
Hi,
In looking for closely at the additions that got made to the
kernel_read_file() enums, I noticed that FIRMWARE_PREALLOC_BUFFER
and FIRMWARE_EFI_EMBEDDED were added, but they are not appropriate
*kinds
fine, so this series is;
Tested-by: Hans de Goede
Regards,
Hans
-Kees
Kees Cook (4):
firmware_loader: EFI firmware loader must handle pre-allocated buffer
fs: Remove FIRMWARE_PREALLOC_BUFFER from kernel_read_file() enums
fs: Remove FIRMWARE_EFI_EMBEDDED from kernel_read_file()
Hi Arnd,
On 6/23/20 4:23 PM, Hans de Goede wrote:
Hi All,
Here is v2 of my vboxguest driver patch-set adding support for the
new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl which is necessary to
make guest resizing work with the new(ish) VMSVGA emulation in vbox +
some other small fixes
typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’ defined
but not used [-Wunused-const-variable=]
1551 | static const struct typec_altmode_ops tcpm_altmode_ops = {
| ^~~~
Cc: Guenter Roeck
Cc: Heikki Krogerus
Cc: Hans de Goede
Signed-off-by: Lee Jones
This is necessary
Hi,
On 3/12/20 7:56 PM, Rajat Jain wrote:
Add support for an ACPI based integrated privacy screen that is
available on some systems.
Signed-off-by: Rajat Jain
So as discussed a while ago I'm working on adding support for the
privacy-screen on Lenovo Thinkpads, introducing a small new
Hi,
On 7/3/20 4:01 PM, Matthias Brugger wrote:
On 02/07/2020 20:00, Hans de Goede wrote:
Hi,
On 7/1/20 5:46 PM, Matthias Brugger wrote:
Hi Hans,
On 01/07/2020 17:38, Hans de Goede wrote:
Hi,
On 7/1/20 5:31 PM, matthias@kernel.org wrote:
From: Matthias Brugger
Apart from
Hi,
On 7/1/20 8:46 AM, Kai-Heng Feng wrote:
On Jun 19, 2020, at 17:56, Hans de Goede wrote:
Hi,
On 6/19/20 6:16 AM, Kai-Heng Feng wrote:
Hi,
On Jun 18, 2020, at 23:28, Hans de Goede wrote:
Hi,
On 6/18/20 4:55 PM, Kai-Heng Feng wrote:
Many laptops can be woken up from Suspend-to-Idle
Hi,
On 7/1/20 5:46 PM, Matthias Brugger wrote:
Hi Hans,
On 01/07/2020 17:38, Hans de Goede wrote:
Hi,
On 7/1/20 5:31 PM, matthias@kernel.org wrote:
From: Matthias Brugger
Apart from a firmware binary the chip needs a config file used by the
FW. Add the config files to modinfo so
Hi,
On 7/1/20 5:31 PM, matthias@kernel.org wrote:
From: Matthias Brugger
Apart from a firmware binary the chip needs a config file used by the
FW. Add the config files to modinfo so that they can be read by
userspace.
The configfile firmware filename is dynamically generated, just
be able to load the config file, even when the compatible has a
'/'. This fixes explicitly the firmware loading for
"solidrun,cubox-i/q".
Signed-off-by: Matthias Brugger
---
Changes in v3:
- use len variable to store length of string (Hans de Goede)
- fix for loop to stop on first NULL-
be able to load the config file, even when the compatible has a
'/'. This fixes explicitly the firmware loading for
"solidrun,cubox-i/q".
Signed-off-by: Matthias Brugger
---
Changes in v2:
- use strscpy instead of strncpy (Hans de Goede)
- use strlen(tmp) + 1 for allocation (Hans de Goe
Hi,
On 6/25/20 6:07 PM, matthias@kernel.org wrote:
From: Matthias Brugger
The driver relies on the compatible string from DT to determine which
FW configuration file it should load. The DTS spec allows for '/' as
part of the compatible string. We change this to '-' so that we will
still
Hi All,
Here is v2 of my vboxguest driver patch-set adding support for the
new VBG_IOCTL_ACQUIRE_GUEST_CAPABILITIES ioctl which is necessary to
make guest resizing work with the new(ish) VMSVGA emulation in vbox +
some other small fixes.
The only change since v2 is rate-limiting the
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 +-
drivers/virt/vboxguest/vmmdev.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest/vboxguest_core.c
index 8fab04e76c14..18
The session lock is a mutex, not a spinlock, fix the comments to match.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest
Every now and then upstream adds new ioctls without notifying us,
log unknown ioctl requests as an error to catch these.
Signed-off-by: Hans de Goede
---
Changes in v2:
- Rate-limit the error logging to avoid userspace potentially DOS-ing the log
---
drivers/virt/vboxguest/vboxguest_core.c | 2
://bugzilla.redhat.com/show_bug.cgi?id=1789545
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 2 ++
include/uapi/linux/vbox_vmmdev_types.h | 3 +++
2 files changed, 5 insertions(+)
diff --git a/drivers/virt/vboxguest/vboxguest_core.c
b/drivers/virt/vboxguest
Rename guest_caps[_tracker] struct members to set_guest_caps[_tracker]
this is a preparation patch for adding support for the
VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 20 ++--
drivers/virt/vboxguest
=1789545
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 163 +++-
drivers/virt/vboxguest/vboxguest_core.h | 14 ++
include/uapi/linux/vboxguest.h | 24
3 files changed, 200 insertions(+), 1 deletion(-)
diff --git a/drivers/virt
Add vbg_set_host_capabilities() helper function, this is a preparation
patch for adding support for the VBGL_IOCTL_GUEST_CAPS_ACQUIRE ioctl.
Signed-off-by: Hans de Goede
---
drivers/virt/vboxguest/vboxguest_core.c | 79 ++---
1 file changed, 46 insertions(+), 33 deletions
601 - 700 of 4303 matches
Mail list logo
