Re: [PATCH v1 08/10] kgdb: Remove "weak" from kgdb_arch_pc() declaration

lways prefer a > non-weak definition over the weak one, independent of link order. > > Fixes: 688b744d8bc8 ("kgdb: fix signedness mixmatches, add statics, add > declaration to header") > Signed-off-by: Bjorn Helgaas > CC: Harvey Harrison Reviewed-by: Harvey Harriso

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: > On Thu, 24 Jul 2014 12:50:31 -0400 > Nick Krause wrote: > >> I am have this discussion with other kernel developers and just >> because I send out one patch as a newbie like this doesn't mean I >> don't known C. > > It's not just one patc

Re: [PATCH 7/8] dmaengine: ste_dma40: Use the BIT macro to replace ugly '(1 << x)'s

On Tue, Apr 9, 2013 at 11:39 AM, Lee Jones wrote: > > The aim is to make the code that little more readable. > > Signed-off-by: Lee Jones > --- > > #define MAX(a, b) (((a) < (b)) ? (b) : (a)) Not part of your patch, but probably a good idea to switch to the generic MAX macro, this one is evalu

Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

On Wed, Mar 6, 2013 at 4:32 PM, Viresh Kumar wrote: > clk[cluster] = clk_get_sys(name, NULL); > - if (!IS_ERR(clk[cluster])) { > + if (!IS_ERR_OR_NULL(clk[cluster])) { > pr_debug("%s: clk: %p & freq table: %p, cluster: %d\n", > _

[PATCH] cifs: remove GLOBAL_EXTERN macro

) Remove GLOBAL_EXTERN Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Steven, here is a revised patch that has a bit more thought behind it. fs/cifs/cifsfs.c | 31 - fs/cifs/cifsglob.h | 76 2 files chang

[PATCH] fbcon: replace mono_col macro with static inline

iginally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/video/console/fbcon.h | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/video/console/fbcon.h b/drivers/video/console/fbcon.h index 3706307..51a6bf4 100644 --- a

[PATCH] radeon: fix integer as NULL pointer warnings in radeon_mem.c

: Using plain integer as NULL pointer drivers/char/drm/radeon_mem.c:177:53: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/drm/radeon_mem.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/driver

[PATCH] video: add a clamp() macro to kernel.h and replace two existing defs

Clamps a value to be within a given range with strict typechecking. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- akpm: I've submitted a clamp_t version previously for use in libata. You may want to just roll this into that one so clamp/clamp_t go in together. drivers/media/

[PATCH] md: fix integer as NULL pointer warnings in md.c

drivers/md/md.c:734:16: warning: Using plain integer as NULL pointer drivers/md/md.c:1115:16: warning: Using plain integer as NULL pointer Add some braces to match the else-block as well. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/md/md.c |8 1 files chan

[PATCH] smack: fix integer as NULL pointer warning in smack_lsm.c

security/smack/smack_lsm.c:1257:16: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- security/smack/smack_lsm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/security/smack/smack_lsm.c b/security/smack/smack

[PATCH 6/6] block: fix shadowed variable warning in blk-map.c

Introduced between 2.6.25-rc2 and -rc3 block/blk-map.c:154:14: warning: symbol 'bio' shadows an earlier one block/blk-map.c:110:13: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- block/blk-map.c |6 +++--- 1 files changed, 3 insertions

[PATCH 4/6] smack: make functions static

t be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- security/smack/smackfs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c index 358c92c..cb26951 100644 --- a/security/smack/smackfs.c +++

[PATCH 3/6] agp: fix shadowed variable warning in amd-k7-agp.c

Introduced between 2.6.25-rc2 and -rc3 drivers/char/agp/amd-k7-agp.c:439:6: warning: symbol 'cap_ptr' shadows an earlier one drivers/char/agp/amd-k7-agp.c:414:5: originally declared here cap_ptr is never used again in this function, don't bother redeclaring. Signed-off-by:

[PATCH 5/6] block: remove extern on function definition

Intoduced between 2.6.25-rc2 and -rc3 block/blk-settings.c:319:12: warning: function 'blk_queue_dma_drain' with external linkage has definition Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- block/blk-settings.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(

[PATCH 1/6] markers: make marker_debug static

Introduced between 2.6.25-rc2 and -rc3 kernel/marker.c:31:11: warning: symbol 'marker_debug' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- kernel/marker.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/k

[PATCH 2/6] xen: make blkif_getgeo static

Introduced between 2.6.25-rc2 and -rc3 drivers/block/xen-blkfront.c:139:5: warning: symbol 'blkif_getgeo' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/block/xen-blkfront.c |2 +- 1 files changed, 1 insertions(+), 1 de

[PATCHv2 2/2] char: fix possible double-unlock in esp.c

pected unlock Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/esp.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/esp.c b/drivers/char/esp.c index 01fbddd..0a33d09 100644 --- a/drivers/char/esp.c +++ b/drivers/char/esp.c @@ -2030,10

[PATCH 1/2] char: hide sparse expensive pointer subtraction warning in specialix.c

The warnings come from two static inlines so the ugliness in hiding them is well contained. drivers/char/specialix.c:238:19: warning: potentially expensive pointer subtraction drivers/char/specialix.c:245:19: warning: potentially expensive pointer subtraction Signed-off-by: Harvey Harrison

[PATCH 2/2] char: fix possible double-unlock in specialix.c

Noticed by sparse, trivial to see: drivers/char/specialix.c:2112:3: warning: context imbalance in 'sx_throttle' - unexpected unlock Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- And with the torrent of warnings fixed, here we find a double-unlock. drivers/char/special

[PATCH 1/2] char: hide sparse expensive pointer subtraction warning in specialix.c

The warnings come from two static inlines so the ugliness in hiding them is well contained. drivers/char/specialix.c:238:19: warning: potentially expensive pointer subtraction drivers/char/specialix.c:245:19: warning: potentially expensive pointer subtraction Signed-off-by: Harvey Harrison

[PATCH] char: static functions and integer as NULL pointer fixes in epca.c

7; was not declared. Should it be static? drivers/char/epca.c:2881:12: warning: symbol 'init_PCI' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/epca.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --g

[PATCH] char: fix sparse shadowed variable warnings in cyclades.c

eclared here drivers/char/cyclades.c:2750:7: warning: symbol '_y' shadows an earlier one drivers/char/cyclades.c:2750:7: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/cyclades.c |4 ++-- 1 files changed, 2 insertions(+), 2 del

[PATCH] char: fix sparse variable shadowing and int as NULL pointer in rocket.c

/char/rocket.c:1751:20: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/rocket.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/char/rocket.c b/drivers/char/rocket.c index 72f2892..2778

[PATCH 2/2] char: fix possible double-unlock in esp.c

pected unlock Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/esp.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/char/esp.c b/drivers/char/esp.c index 01fbddd..2b14814 100644 --- a/drivers/char/esp.c +++ b/drivers/char/esp.c @

[PATCH 1/2] char: fix sparse shadowed variable warnings in esp.c

ags' shadows an earlier one drivers/char/esp.c:1517:16: originally declared here drivers/char/esp.c:1631:17: warning: symbol 'flags' shadows an earlier one drivers/char/esp.c:1517:16: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/esp

Re: linux-next: first tree

On Thu, 2008-02-21 at 16:12 -0800, Randy Dunlap wrote: > Frank Seidel wrote: > > Randy Dunlap wrote: > >> I'd like to see tarballs too, please... > > > > Hi, i'll provide tars of the current linux-next tree reachable > > via my http://linux-next.f-seidel.de wiki ("Tar Downloads"). > > Is that what

Re: [PATCH] saa7146: fix sparse warnings

On Thu, 2008-02-21 at 21:19 +, Al Viro wrote: > On Thu, Feb 21, 2008 at 09:52:36AM -0800, Harvey Harrison wrote: > > Could you please use more descriptive names? NULL noise removal > is not the same as shadowing or endianness annotations or endianness > fixes or __user/__io

Re: [PATCH] mac80211: check endianness/types in sparse runs

On Thu, 2008-02-21 at 21:29 +0100, Johannes Berg wrote: > > Clean, or did you specifically mean bitwise-clean? > > bitwise-clean. But I don't do full-mac drivers so most of what you quote > I don't compile, and the mac80211-based drivers only have few problems. > This wasn't meant as any sort of

Re: [PATCH] mac80211: check endianness/types in sparse runs

On Thu, 2008-02-21 at 21:09 +0100, Johannes Berg wrote: > > > In any case, I would love to have __CHECK_ENDIAN__ enabled by default at > > > least on the wireless code (just caught another bug with it...) > > > > I should then add support for something like: > > > > checkflags-y := -D__CHECK_ENDI

Re: [PATCH] mac80211: check endianness/types in sparse runs

On Thu, 2008-02-21 at 13:42 +0100, Johannes Berg wrote: > >> [patch doing CHECKFLAGS += -D__CHECK_ENDIAN__ in the > >> net/mac80211/Makefile] > > > I would prefer it to be kernel wide enabled. > > Tried a defconfig build. > > Hm. I tend to think there was a reason for this, since this is actually

[PATCH] eicon: fix sparse integer as NULL pointer warnings

/eicon/message.c:9147:16: warning: Using plain integer as NULL pointer drivers/isdn/hardware/eicon/message.c:9173:14: warning: Using plain integer as NULL pointer drivers/isdn/hardware/eicon/divasmain.c:396:23: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EM

[PATCH] avm: fix sparse warning using integer as NULL pointer

drivers/isdn/hardware/avm/c4.c:1294:37: warning: Using plain integer as NULL pointer drivers/isdn/hardware/avm/c4.c:1296:33: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/isdn/hardware/avm/b1.c | 10 +- driver

[PATCH] capi: fix sparse warnings using integer as NULL pointer

/capidrv.c:2341:33: warning: Using plain integer as NULL pointer drivers/isdn/capi/capifs.c:192:37: warning: Using plain integer as NULL pointer drivers/isdn/capi/capifs.c:194:33: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/isd

[PATCH] saa7146: fix sparse warnings

/saa7146_fops.c:275:12: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/media/common/saa7146_core.c |8 drivers/media/common/saa7146_fops.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/d

acpi: new sparse warnings in 2.6.25-rc2

Introduced between 2.6.25-rc1 and -rc2. drivers/acpi/executer/exregion.c:369:8: warning: incorrect type in argument 3 (different type sizes) drivers/acpi/executer/exregion.c:369:8:expected unsigned int [usertype] *value drivers/acpi/executer/exregion.c:369:8:got unsigned long long [usert

[PATCH] markers: fix sparse warnings in markers.c

char can be unsigned kernel/marker.c:64:20: error: dubious one-bit signed bitfield kernel/marker.c:65:14: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Introduced between -rc1 and -rc2 kernel/marker.c |4 ++-- 1 files changed, 2 inse

Re: [PATCH 1/2] moxa: make functions static

On Thu, 2008-02-21 at 00:12 +0100, Jiri Slaby wrote: > On 02/20/2008 11:14 PM, Harvey Harrison wrote: > > All were forward declared static already. > > > Thanks, but I have similar fixes for both issues you address in my tree. I'll > post it in few days. Great. Harv

Re: sparse - make __CHECK_ENDIAN__ default enabled?

On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote: > Hi Harvey. > > Can I ask you to look into the worst offenders so we > can make -D__CHECK_ENDIAN__ enabled per default > in the kernel. > Or maybe we should do it anyway? >From a quick test, the same places that spew sparse warnings, spew lo

Re: sparse - make __CHECK_ENDIAN__ default enabled?

On Wed, 2008-02-20 at 23:03 +0100, Sam Ravnborg wrote: > Hi Harvey. > > Can I ask you to look into the worst offenders so we > can make -D__CHECK_ENDIAN__ enabled per default > in the kernel. > Or maybe we should do it anyway? Well, I've got the worst of fs and drivers/ata done so far, still weep

[PATCH 2/2] moxa: fix sparse warnings

drivers/char/moxa.c:873:26: warning: Using plain integer as NULL pointer drivers/char/moxa.c:2037:49: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/char/moxa.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 1/2] moxa: make functions static

78:6: warning: symbol 'MoxaPortTxEnable' was not declared. Should it be static? drivers/char/moxa.c:2387:5: warning: symbol 'MoxaPortResetBrkCnt' was not declared. Should it be static? drivers/char/moxa.c:2396:6: warning: symbol 'MoxaPortSendBreak' was not declared. Should it be stat

[PATCH] char: make functions static in synclinkmp.c

1:15: warning: symbol 'read_reg' was not declared. Should it be static? drivers/char/synclinkmp.c:5586:6: warning: symbol 'write_reg' was not declared. Should it be static? drivers/char/synclinkmp.c:5592:5: warning: symbol 'read_reg16' was not declared. Should it be st

[PATCH] nfs: fix sparse warnings

/callback_xdr.c:270:6: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:281:6: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Rollup patches 1-4. fs/nfs/callback_xdr.c |6 +++--- fs/nfs/delegation.c |2 +- fs/nfs/i

[PATCH 1/2] nfsd: fix sparse warnings

c, forward declaration was already marked static. fs/nfsd/nfs4idmap.c:206:1: warning: symbol 'idtoname_parse' was not declared. Should it be static? fs/nfsd/vfs.c:1156:1: warning: symbol 'nfsd_create_setattr' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[

[PATCH 2/2] nfsd: fix sparse warning in vfs.c

fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/nfsd/vfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index 0265310..17ac51b 100644 --- a/fs/nfsd/vfs.c

[PATCH 4/4] nfs: fix sparse warnings in callback_xdr.c

fs/nfs/callback_xdr.c:257:6: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:270:6: warning: Using plain integer as NULL pointer fs/nfs/callback_xdr.c:281:6: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> ---

[PATCH 3/4] nfs: fix sparse warning in idmap.c

fs/nfs/idmap.c:312:12: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/nfs/idmap.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c index 8ae5dba..86147b0 100644 --- a/fs/nfs/i

[PATCH 2/4] nfs: fix sparse warning in delegation.c

fs/nfs/delegation.c:52:34: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/nfs/delegation.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c index b9eadd1..00a5e44

[PATCH 1/4] nfs: fix sparse warning in nfs4state.c

fs/nfs/nfs4state.c:788:34: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/nfs/nfs4state.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index 6233eb5..b962397 100644

[PATCH] ata: use clamp_t macro to avoid sparse warnings

Nesting min_t/max_t macros produces many shadowed variable warnings due to use of __x. Add a clamp_t macro to linux/kernel.h and use it in the FIT macro. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- include/linux/kernel.h |9 + include/linux/libata.h |2 +- 2

Re: [PATCH 1/5] signal(x86_32): Improve the signal stack overflow check

On Tue, 2008-02-19 at 18:49 -0800, Roland McGrath wrote: > > I spent some time read you mail carefully and dig into the code again. > > > > And yes, you are right. It's possible that SA_ONSTACK has been cleared > > before the second signal on the same stack comes. > > It's not necessary for SA_ON

Re: [2.6 patch] drivers/thermal/thermal.c: fix a check-after-use

On Wed, 2008-02-20 at 02:14 +0200, Adrian Bunk wrote: > This patch fixes a check-after-use spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > 570462ca4441d8d63dfd46efe6e5b2b1c251a611 diff --git > a/drivers/thermal/thermal.c b/drivers/thermal/thermal.c >

Re: Unable to continue testing of 2.6.25

On Tue, 2008-02-19 at 22:55 +0100, Frans Pop wrote: > On Sunday 17 February 2008, Adrian Bunk wrote: > > The real problem is that the kernel seems to lack functionality you > > require for doing some work. > > Not sure how you reached that conclusion. > > > Why does your work on the Debian Instal

[PATCH] ata: simplify clock divisor logic in pata_amd.c

re Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, this is a replacement for: pata_amd-replace-macro-with-static-inline-in-libatah.patch It is the same patch, but with a corrected description. drivers/ata/pata_amd.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(

[PATCH] kvm: fix sparse warnings in x86_emulate.c

: warning: symbol '_tmp' shadows an earlier one arch/x86/kvm/x86_emulate.c:1091:3: originally declared here [18 more warnings suppressed] Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/x86_emulate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] kvm: make iopm_base static

Fixes sparse warning as well. arch/x86/kvm/svm.c:69:15: warning: symbol 'iopm_base' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/svm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch

[PATCH] kvm: sparse fixes for kvm/x86.c

x86/kvm/x86.c:2878:2: warning: returning void-valued expression arch/x86/kvm/x86.c:2944:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Ingo, I had originally sent this to you, please drop it if you haven't already done so, I'l

Re: [PATCH 1/3] x86, kvm: add ad_mask static inline

On Tue, 2008-02-19 at 10:39 +0200, Avi Kivity wrote: > Harvey Harrison wrote: > > Replaces open-coded mask calculation in macros. > > > > > Please regenerate against kvm.git (patch 2 doesn't apply; see > http://kvm.qumranet.com/kvmwiki/Code). Also please

[PATCH] serial: remove double initializer

Commit: 02c9b5cf9acd8a85313b892dc5196ccf133d4884 serial: add ADDI-DATA GmbH Communication cardsin8250_pci.c and pci_ids.h Added a second initializer, perhaps sopmething else was intended? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/serial/8250_pci.c |7 --- 1

[PATCH] bttv: struct member initialized twice

fixes sparse warning: drivers/media/video/bt8xx/bttv-driver.c:3391:3: warning: Initializer entry defined twice drivers/media/video/bt8xx/bttv-driver.c:3392:3: also defined here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/media/video/bt8xx/bttv-driver.c |1 - 1

[PATCH] cifs: remove GLOBAL_EXTERN macro

) Remove GLOBAL_EXTERN Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, Steve, this is a revised patch that addresses your comments on the patch withdrawn from -mm. fs/cifs/cifsfs.c | 31 - fs/cifs/cifsglob.h

Re: [RFC] [PATCH] Fix b43 driver build for arm

On Mon, 2008-02-18 at 23:43 +0100, Michael Buesch wrote: > On Monday 18 February 2008 23:34:10 Russell King wrote: > > > > Well, don't expect this driver to work until you fix your broken > > assumptions about alignment requirements. > > Mr King, I'm not an idiot! > > Can you _please_ explain wh

[PATCH 6/6] reiserfs: fix sparse warning in journal.c

fs/reiserfs/journal.c:4319:2: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/reiserfs/journal.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c index bb05a3e..0

[PATCH 4/6] reiserfs: fix sparse warnings in lbalance.c

fs/reiserfs/lbalance.c:629:2: warning: Using plain integer as NULL pointer fs/reiserfs/lbalance.c:629:2: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/reiserfs/lbalance.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 5/6] reiserfs: fix sparse warnings in do_balan.c

fs/reiserfs/do_balan.c:1467:10: warning: symbol 'ret_val' shadows an earlier one fs/reiserfs/do_balan.c:275:6: originally declared here fs/reiserfs/do_balan.c:1471:23: warning: symbol 'ih' shadows an earlier one fs/reiserfs/do_balan.c:249:67: originally declared here S

[PATCH 2/6] reiserfs: fix sparse warnings in do_balan.c

pointer fs/reiserfs/do_balan.c:1844:2: warning: Using plain integer as NULL pointer fs/reiserfs/do_balan.c:1844:2: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/reiserfs/do_balan.c |8 1 files changed, 4 insertions

[PATCH 1/6] reiserfs: fix sparse warnings in fix_node.c

pointer fs/reiserfs/fix_node.c:881:70: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/reiserfs/fix_node.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/reiserfs/fix_node.c b/fs/reiserfs/fix_node.c

[PATCH 3/6] reiserfs: fix sparse warning in namei.c

fs/reiserfs/namei.c:455:17: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/reiserfs/namei.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/reiserfs/namei.c b/fs/reiserfs/namei.c index b378eea..8867533

[PATCH 3/3] x86, kvm: make register_address_increment and JMP_REL static inlines

Change to jmp_rel now that it is a function. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/x86_emulate.c | 58 --- 1 files changed, 27 insertions(+), 31 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x

[PATCH 2/3] x86, kvm: make register_address, address_mask static inlines

Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/x86_emulate.c | 50 ++- 1 files changed, 30 insertions(+), 20 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index 7460432..5b2cc50 100644 ---

[PATCH 1/3] x86, kvm: add ad_mask static inline

Replaces open-coded mask calculation in macros. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/x86/kvm/x86_emulate.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/x86_emulate.c b/arch/x86/kvm/x86_emulate.c index 7958600..7

[PATCH] tlan: add static to function definitions

: symbol 'TLan_EeSendStart' was not declared. Should it be static? drivers/net/tlan.c:3187:5: warning: symbol 'TLan_EeSendByte' was not declared. Should it be static? drivers/net/tlan.c:3248:6: warning: symbol 'TLan_EeReceiveByt

[PATCH] ata: replace macro with static inline in libata.h

Avoid ~70 sparse warnings like: drivers/ata/pata_ali.c:176:14: warning: symbol '__x' shadows an earlier one drivers/ata/pata_ali.c:176:14: originally declared here Due to nesting min_t macro inside max_t macro which both use a __x identifier internally. Signed-off-by: Harvey Harris

Re: [PATCH] x86: include prototype for no_broadcast in mach-default/setup.c

On Sun, 2008-02-17 at 21:09 +0100, Ingo Molnar wrote: > * Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > > config attached. The include file dependencies in this area are a > > > bit of a mess - perhaps they need some cleanups? > > > > OK, I'm b

[PATCH] udf: fix sparse warning in namei.c

Let's use bsize instead. fs/udf/namei.c:960:12: warning: symbol 'elen' shadows an earlier one fs/udf/namei.c:937:15: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/udf/namei.c |8 1 files changed, 4 insertions(+), 4 deletion

[PATCH] lockd: fix sparse warning in svcshare.c

fs/lockd/svcshare.c:74:50: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/lockd/svcshare.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/lockd/svcshare.c b/fs/lockd/svcshare.c index 068886d..c42fcf0

[PATCH 3/4] jffs2: fix sparse warning in write.c

fs/jffs2/write.c:585:28: warning: symbol 'fd' shadows an earlier one fs/jffs2/write.c:536:27: originally declared here No need to redeclare fd, use the original one, after this point, fd is always reassigned before it used again. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]&g

[PATCH 2/4] jffs2: fix sparse warning in nodemgmt.c

fs/jffs2/nodemgmt.c:60:8: warning: symbol 'ret' shadows an earlier one fs/jffs2/nodemgmt.c:45:6: originally declared here Use a different var (gc) in the inner loop to test the condition. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/jffs2/nodemgmt.c |8

[PATCH 4/4] jffs2: fix sparse warnings in gc.c

es as they are taken from the super_blocks list. It appears jffs2_garbage_collect_dnode never uses its jeb argument, so as an alternative that could be dropped and the one caller adusted then the inner variables would not need to be touched. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]>

[PATCH 1/4] jffs2: include function prototype for jffs2_ioctl

fs/jffs2/ioctl.c:14:5: warning: symbol 'jffs2_ioctl' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/jffs2/ioctl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/jffs2/ioctl.c b/fs/jffs2/ioctl.c index

Re: [PATCHv2] autofs4: fix sparse warning in root.c

fs/autofs4/root.c:536:23: warning: symbol 'ino' shadows an earlier one fs/autofs4/root.c:510:22: originally declared here There is no need to redeclare, we are at the end of the loop and in the next iteration of the loop, ino will be reset. Signed-off-by: Harvey Harrison <[EM

[RFC-PATCH] cifs: remove GLOBAL_EXTERN macro

d it be static? fs/cifs/cifsglob.h:657:28: warning: symbol 'CIFSMaxBufSize' was not declared. Should it be static? fs/cifs/cifsglob.h:658:28: warning: symbol 'cifs_min_rcv' was not declared. Should it be static? fs/cifs/cifsglob.h:659:28: warning: symbol 'cifs_min_small&#x

[PATCH] autofs4: fix sparse warning in root.c

fs/autofs4/root.c:536:23: warning: symbol 'ino' shadows an earlier one fs/autofs4/root.c:510:22: originally declared here There is no need to redeclare, we are at the end of the loop and in the next iteration of the loop, ino will be reset. Signed-off-by: Harvey Harrison <[EM

[PATCH] acpi: sparse fix, replace macro with static function

earlier one drivers/acpi/utils.c:348:21: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- drivers/acpi/utils.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c index 34f

Re: [PATCH] befs: fix sparse warning in linuxvfs.c

On Fri, 2008-02-15 at 13:19 -0800, Andrew Morton wrote: > On Fri, 15 Feb 2008 10:46:04 -0800 > Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > Use link as the variable name to avoid shadowing the arg. > > > > fs/befs/linuxvfs.c:492:8: warning: symbol '

Re: [patch] fuse: fix permission checking

On Fri, 2008-02-15 at 11:23 +0100, Miklos Szeredi wrote: > This is for 2.6.25 and 2.6.24.y, but NOT for 2.6.23.y. > > Thanks, > Miklos > > > From: Miklos Szeredi <[EMAIL PROTECTED]> > > I added a nasty local variable shadowing bug to fuse in 2.6.24, with > the result, that the 'default_perm

[PATCH 2/3] ncpfs: fix sparse warnings in ioctl.c

: symbol 'inode' shadows an earlier one fs/ncpfs/ioctl.c:264:28: originally declared here In this case, we are about to return anyway, just reuse result. fs/ncpfs/ioctl.c:521:8: warning: symbol 'result' shadows an earlier one fs/ncpfs/ioctl.c:268:6: originally declared here Sig

[PATCH 3/3] ncpfs: fix sparse warning in ncpsign_kernel.c

got int * Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/ncpfs/ncpsign_kernel.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/ncpfs/ncpsign_kernel.c b/fs/ncpfs/ncpsign_kernel.c index 749a18d..7c0b5c2 100644 --- a/fs/ncpfs/ncpsign_kernel.c +++

[PATCH 1/3] ncpfs: add prototypes to ncp_fs.h

pfs/symlink.c:101:39: warning: symbol 'ncp_symlink_aops' was not declared. Should it be static? Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/ncpfs/inode.c |6 -- include/linux/ncp_fs.h |7 +++ 2 files changed, 7 insertions(+), 6 deletions(-) diff

Re: [RFC-PATCH] fuse: shadowed variable warning

On Fri, 2008-02-15 at 20:13 +0100, Miklos Szeredi wrote: > > > > fs/fuse/dir.c:909:7: warning: symbol 'err' shadows an earlier one > > fs/fuse/dir.c:893:6: originally declared here > > > > This means that an error between lines 909 and 923 will not be > > returned. > > Right. Just submitted the

[RFC-PATCH] fuse: shadowed variable warning

fs/fuse/dir.c:909:7: warning: symbol 'err' shadows an earlier one fs/fuse/dir.c:893:6: originally declared here This means that an error between lines 909 and 923 will not be returned. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Miklos, could you confirm whether or

[PATCH] befs: fix sparse warning in linuxvfs.c

Use link as the variable name to avoid shadowing the arg. fs/befs/linuxvfs.c:492:8: warning: symbol 'p' shadows an earlier one fs/befs/linuxvfs.c:488:77: originally declared here Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- This should be checked in case there is a

[PATCH] coda: add static to functions in dir.c

coda_unlink, coda_rmdir, coda_readdir can all be static, the forward declarations already were. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- fs/coda/dir.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/coda/dir.c b/fs/coda/dir.c index f89ff08..3

[PATCH 2/3] sched: trivial sparse warning in sched.c

kernel/sched.c:3680:3: warning: returning void-valued expression Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- kernel/sched.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/sched.c b/kernel/sched.c index f28f19e..824d5a9 100644 --- a/kernel/s

[PATCH 1/3] sched: add declaration of sched_tail to sched.h

Avoids sparse warnings: kernel/sched.c:2170:17: warning: symbol 'schedule_tail' was not declared. Should it be static? Avoids the need for an external declaration in arch/um/process.c Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- arch/um/kernel/process.c |2 -

[PATCH 3/3] sched: fix signedness warnings in sched.c

: warning: incorrect type in assignment (different signedness) kernel/sched.c:3921:16:expected long *switch_count kernel/sched.c:3921:16:got unsigned long * Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- kernel/sched.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH] ubi: fix sparse errors in ubi.h

-bit signed bitfield drivers/mtd/ubi/ubi.h:222:18: error: dubious one-bit signed bitfield drivers/mtd/ubi/ubi.h:223:16: error: dubious one-bit signed bitfield drivers/mtd/ubi/ubi.h:224:20: error: dubious one-bit signed bitfield Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Sorry, no

[PATCH] checkpatch: remove fastcall

fastcall no longer exists in tree, remove it from checkpatch. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- scripts/checkpatch.pl |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2086a85..6f9b391 100755

[PATCH] kernel-doc: remove fastcall

fastcall is gone from the tree, no need to adjust the function prototypes anymore for this. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- scripts/kernel-doc |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/scripts/kernel-doc b/scripts/kernel-doc index 6

[PATCH 05/11v2] ata: replace macro with static inline in libata.h

in_t macro inside max_t macro which both use a __x identifier internally. Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Alan, is this more to your liking? include/linux/libata.h |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/include/linux/libata.h

  1   2   3   4   5   >