On Fri, Dec 4, 2020 at 2:38 PM Johan Hovold wrote:
>
> Hi Himadri,
>
> and sorry about the late feedback on this one. I'm still trying to dig
> myself out of some backlog.
>
> On Wed, Nov 04, 2020 at 12:16:48PM +0530, Himadri Pandya wrote:
> > There are many usag
The new usb_control_msg_send() nicely wraps usb_control_msg() with proper
error check. Hence use the wrapper instead of calling usb_control_msg()
directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/ipaq.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/f81534.c | 63 +++--
1
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/ftdi_sio.c | 182 +++---
1
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/f81232.c | 88 -
1
The new usb_control_msg_send() nicely wraps usb_control_msg() with proper
error check. Hence use the wrapper instead of calling usb_control_msg()
directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/iuu_phoenix.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/kl5kusb105.c | 94 +++--
1 file
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/io_ti.c | 28 ++--
1 file changed
The new usb_control_msg_send() nicely wraps usb_control_msg() with proper
error check. Hence use the wrapper instead of calling usb_control_msg()
directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/ipw.c | 107 +--
1 file changed, 36 insertions
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/keyspan_pda.c | 172 +--
1
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/io_edgeport.c | 73
1
The new usb_control_msg_send() nicely wraps usb_control_msg() with
proper error check. Hence use the wrapper instead of calling
usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/belkin_sa.c | 35 +-
1 file changed, 17 insertions
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/cypress_m8.c | 38 +
1
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/cp210x.c | 148 ++--
1
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/ark3116.c | 29 -
1 file
There are many usages of usb_control_msg() that can use the new wrapper
functions usb_contro_msg_send() & usb_control_msg_recv() for better
error checks on short reads and writes. Hence use them whenever possible
and avoid using usb_control_msg() directly.
Himadri Pandya (15):
usb: se
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/usb/serial/ch341.c | 45 --
1
On Thu, Sep 24, 2020 at 5:06 PM Oliver Neukum wrote:
>
> Am Mittwoch, den 23.09.2020, 20:02 +0530 schrieb Himadri Pandya:
>
> > I meant that it was stupid to change it without properly understanding
> > the significance of GFP_NOIO in this context.
> >
> > S
On Wed, Sep 23, 2020 at 7:51 PM Oliver Neukum wrote:
>
> Am Mittwoch, den 23.09.2020, 19:36 +0530 schrieb Himadri Pandya:
> > On Wed, Sep 23, 2020 at 3:52 PM Oliver Neukum wrote:
> > >
> > > Am Mittwoch, den 23.09.2020, 14:35 +0530 schrieb Himadri Pandya:
>
On Wed, Sep 23, 2020 at 3:52 PM Greg KH wrote:
>
> On Wed, Sep 23, 2020 at 02:35:19PM +0530, Himadri Pandya wrote:
> > The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
> > usb_control_msg() with proper error check. Hence use the wrappers
>
On Wed, Sep 23, 2020 at 3:54 PM Greg KH wrote:
>
> On Wed, Sep 23, 2020 at 02:35:16PM +0530, Himadri Pandya wrote:
> > Potential incorrect use of usb_control_msg() has resulted in new wrapper
> > functions to enforce its correct usage with proper error check. Hence
> &g
On Wed, Sep 23, 2020 at 3:52 PM Oliver Neukum wrote:
>
> Am Mittwoch, den 23.09.2020, 14:35 +0530 schrieb Himadri Pandya:
>
> Hi,
>
> > Many usage of usb_control_msg() do not have proper error check on return
> > value leaving scope for bugs on short reads. New usb
The new usb_control_msg_recv() and usb_control_msg_send() nicely wraps
usb_control_msg() with proper error check. Hence use the wrappers
instead of calling usb_control_msg() directly.
Signed-off-by: Himadri Pandya
---
drivers/net/usb/rndis_host.c | 44 ++--
1
Potential incorrect use of usb_control_msg() has resulted in new wrapper
functions to enforce its correct usage with proper error check. Hence
use these new wrapper functions instead of calling usb_control_msg()
directly.
Signed-off-by: Himadri Pandya
---
drivers/net/usb/usbnet.c | 46
.
Himadri Pandya (4):
net: usbnet: use usb_control_msg_recv() and usb_control_msg_send()
net: sierra_net: use usb_control_msg_recv()
net: usb: rtl8150: use usb_control_msg_recv() and
usb_control_msg_send()
net: rndis_host: use usb_control_msg_recv() and usb_control_msg_send()
drivers/net
.
Signed-off-by: Himadri Pandya
---
drivers/net/usb/rtl8150.c | 32 ++--
1 file changed, 6 insertions(+), 26 deletions(-)
diff --git a/drivers/net/usb/rtl8150.c b/drivers/net/usb/rtl8150.c
index 733f120c852b..e3002b675921 100644
--- a/drivers/net/usb/rtl8150.c
+++ b
The new usb api function usb_control_msg_recv() nicely wrapps
usb_control_msg() with proper error check. Hence use it instead of
directly calling usb_control_msg().
Signed-off-by: Himadri Pandya
---
drivers/net/usb/sierra_net.c | 17 +++--
1 file changed, 7 insertions(+), 10
On Thu, Aug 27, 2020 at 1:28 PM Sergei Shtylyov
wrote:
>
> Hello!
>
> On 27.08.2020 9:53, Himadri Pandya wrote:
>
> > The buffer size is 2 Bytes and we expect to receive the same amount of
> > data. But sometimes we receive less data and run into uninit-was-stored
+a7e220df5a81d1ab4...@syzkaller.appspotmail.com
Signed-off-by: Himadri Pandya
---
drivers/net/usb/asix_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
index e39f41efda3e..7bc6e8f856fe 100644
--- a/drivers/net/usb
On Mon, Aug 24, 2020 at 11:16:55AM -0700, Jakub Kicinski wrote:
> On Sun, 23 Aug 2020 13:50:42 +0530 Himadri Pandya wrote:
> > Initialize the buffer before passing it to usb_read_cmd() function(s) to
> > fix the uninit-was-stored issue in asix_read_cmd().
> >
> > Fixes
Initialize the buffer before passing it to usb_read_cmd() function(s) to
fix the uninit-was-stored issue in asix_read_cmd().
Fixes: KMSAN: kernel-infoleak in raw_ioctl
Reported by: syzbot+a7e220df5a81d1ab4...@syzkaller.appspotmail.com
Signed-off-by: Himadri Pandya
---
drivers/net/usb
granularities to handle larger page sizes correctly.
Signed-off-by: Himadri Pandya
---
drivers/hv/hv_balloon.c | 25 -
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
index 34bd73526afd..935904830d42 100644
. The second patch removes dependencies on
guest page size in vmbus by using hyper-v specific page symbol and
functions.
Himadri Pandya (2):
x86: hv: Add function to allocate zeroed page for Hyper-V
Drivers: hv: vmbus: Remove dependencies on guest page size
arch/x86/hyperv/hv_init.c
hyper-v's assumed page size and actual guest page size.
Signed-off-by: Himadri Pandya
---
arch/x86/hyperv/hv_init.c | 8
arch/x86/include/asm/mshyperv.h | 1 +
2 files changed, 9 insertions(+)
diff --git a/arch/x86/hyperv/hv_init.c b/arch/x86/hyperv/hv_init.c
index d314cf1
Hyper-V assumes page size to be 4K. This might not be the case for ARM64
architecture. Hence use hyper-v page size and page allocation function
to avoid conflicts between different host and guest page size on ARM64.
Signed-off-by: Himadri Pandya
---
drivers/hv/connection.c | 14
]
This patch should be applied to linux-next git tree.
Thank you.
- Himadri
url:
https://github.com/0day-ci/linux/commits/Himadri-Pandya/hv_sock-use-HV_HYP_PAGE_SIZE-instead-of-PAGE_SIZE_4K/20190726-085229
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-10
ARM64 architecture.
Signed-off-by: Himadri Pandya
---
net/vmw_vsock/hyperv_transport.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/net/vmw_vsock/hyperv_transport.c b/net/vmw_vsock/hyperv_transport.c
index f2084e3f7aa4..ecb5d72d8010 100644
--- a/net
receive.
Signed-off-by: Himadri Pandya
---
drivers/hv/hv_fcopy.c| 3 ++-
drivers/hv/hv_kvp.c | 3 ++-
drivers/hv/hv_snapshot.c | 3 ++-
drivers/hv/hv_util.c | 8
4 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/hv/hv_fcopy.c b/drivers/hv/hv_fcopy.c
index
VMbus ring buffers are sized based on the 4K page size used by
Hyper-V. The Linux guest page size may not be 4K on all architectures
so use the Hyper-V page size to specify the ring buffer size.
Signed-off-by: Himadri Pandya
---
drivers/hv/hv_util.c | 5 +++--
1 file changed, 3 insertions(+), 2
recv_buffer and VMbus ring buffers are sized based on guest page size
which Hyper-V assumes to be 4KB. It might not be the case for some
architectures. Hence instead use the Hyper-V page size.
Himadri Pandya (2):
Drivers: hv: Specify receive buffer size using Hyper-V page size
Drivers: hv
The SPDX license identifier should have the form
// SPDX-License-Identifier:
for a .c source file. File hfa384x_usb.c has instead the form
/* SPDX-License-Identifier: */
which is the form for C header files. Hence this patch corrects it.
Issue identified by checkpatch.
Signed-off-by: Himadri
On 10/04/19 4:12 PM, Dan Carpenter wrote:
On Wed, Apr 10, 2019 at 03:30:22PM +0530, Himadri Pandya wrote:
Fix checkpatch warning "Alignment should match open parenthesis".
Signed-off-by: Himadri Pandya
---
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
1 file changed, 1 inser
Resolve checkpatch warning for using symbolic permissions by replacing
them with octal permissions.
Signed-off-by: Himadri Pandya
---
drivers/staging/gasket/gasket_sysfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_sysfs.h
b/drivers
Fix checkpatch warning "Alignment should match open parenthesis".
Signed-off-by: Himadri Pandya
---
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_tinylcd.c
b/drivers/staging/fbtft/fb_tinylcd.c
index 94
On 22/02/19 8:06 PM, Andrew Lunn wrote:
On Fri, Feb 22, 2019 at 04:48:18PM +0530, Himadri Pandya wrote:
Decrement the reference count on port while returning out of the
loop. Issue identified by Coccinelle.
You and Wen Yang are both fixing the same issue. Maybe you can
coordinate?
Sure
Decrement the reference count on port while returning out of the
loop. Issue identified by Coccinelle.
Signed-off-by: Himadri Pandya
---
net/dsa/dsa2.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index a1917025e155
On 20/02/19 9:23 AM, Vaishali Thakkar wrote:
On Wed, Feb 20, 2019 at 8:54 AM Himadri Pandya wrote:
Hi Himadri,
Thanks for the patch!
For the scope of Outreachy, we prefer that you send patches in staging
directory as Greg makes sure to pick them during the application
period. Of course
Decrement the reference count on port while returning out of the loop.
Signed-off-by: Himadri Pandya
---
net/dsa/dsa2.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c
index a1917025e155..396e7433dd8f 100644
--- a/net/dsa/dsa2
48 matches
Mail list logo