Re: [PATCH] drivers: target: target_core_pr.c: Fix tabspace error

(pr_reg_type)); > + > + return 0; > + } > + } this last one has one too many tab. > pr_debug("%s Conflict for %sregistered nexus %s CDB: 0x%2x" > " for %s reservation\n", transport_dump_cmd_direction(cmd), > (registered_nexus) ? "" : "un", > -- > 2.17.1 > -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH -next] scsi: qla2xxx: remove unneeded if-null-free check

> for (j = 0; j < 2; j++, fwdt++) { > - if (fwdt->template) > - vfree(fwdt->template); > + vfree(fwdt->template); > fwdt->template = NULL; > fwdt->length = 0; > } > -- > 2.31.1 > Looks Good. Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH] nvme: Export fast_io_fail_tmo to sysfs

nvme_ctrl_fast_io_fail_tmo_show, nvme_ctrl_fast_io_fail_tmo_store); > + > static struct attribute *nvme_dev_attrs[] = { > _attr_reset_controller.attr, > _attr_rescan_controller.attr, > @@ -3715,6 +3745,7 @@ static struct attribute *nvme_dev_attrs[] = { > _attr_hostid.attr, > _attr_ctrl_loss_tmo.attr, > _attr_reconnect_delay.attr, > + _attr_fast_io_fail_tmo.attr, > NULL > }; > > -- > 2.29.2 > Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: use dma_pool_zalloc instead

"sf_init_cb=%p.\n", ha->sf_init_cb); > } > -- > 2.7.4 > Looks Good. Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: Simplify the calculation of variables

tatus_subcode == ELS_PLOGI))) { > + (own->iocb.u.isp24.status_subcode == ELS_PLOGI)) { > rc = qla2x00_post_async_logout_work(vha, sess, > NULL); > if (rc != QLA_SUCCES

Re: [PATCH] scsi: qla2xxx: Simplify the calculation of variables

ivers/scsi/qla2xxx/qla_nvme.c > @@ -285,7 +285,7 @@ static int qla_nvme_ls_req(struct nvme_fc_local_port > *lport, > srb_t *sp; > > > - if (!fcport || (fcport && fcport->deleted)) > + if (!fcport || fcport->deleted) > return

Re: [PATCH 1/2] scsi: qla2xxx: remove redundant NULL check

;template = NULL; > fwdt->length = 0; > > @@ -8174,8 +8170,7 @@ bool qla24xx_risc_firmware_invalid(uint32_t *dword) > return QLA_SUCCESS; > > failed: > - if (fwdt->template) > - vfree(fwdt->template); > + vfree(fwdt->template); > fwdt->template = NULL; > fwdt->length = 0; > > -- > 1.8.3.1 > Make Sense. Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: fix description for parameter ql2xenforce_iocb_limit

gt; + "Enforce IOCB throttling, to avoid FW congestion. (default: > 1)"); > > /* > * CT6 CTX allocation cache > -- > 2.29.2 > Good Catch. Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: fix return of uninitialized value in rval

al_port > *lport, > vha = fcport->vha; > > if (!(fcport->nvme_flag & NVME_FLAG_REGISTERED)) > - return rval; > + return -ENODEV; > > if (test_bit(ABORT_ISP_ACTIVE, >dpc_flags) || > (qpair && !qpair->fw_started) || fcport->deleted) > -- > 2.27.0 > Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH] qla2xxx: Do not consume srb greedily

a, > (struct abort_entry_24xx *)pkt); > break; > case MBX_IOCB_TYPE: > - qla24xx_process_mbx_iocb_response(vha, rsp, pkt); > + qla24xx_mbx_iocb_entry(vha, rsp->req, > + (struct mbx_24xx_entry *)pkt); > break; > case VP_CTRL_IOCB_TYPE: > qla_ctrlvp_completed(vha, rsp->req, > -- > 2.16.4 > Makes sense :) Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH -next v2] scsi: qla2xxx: Convert to DEFINE_SHOW_ATTRIBUTE

s_dir, vha, _dfs_tgt_port_database_fops); > > ha->dfs_fce = debugfs_create_file("fce", S_IRUSR, ha->dfs_dir, vha, > _fce_ops); > > ha->tgt.dfs_tgt_sess = debugfs_create_file("tgt_sess", > - S_IRUSR, ha->dfs_dir, vha, _tgt_sess_ops); > + S_IRUSR, ha->dfs_dir, vha, _dfs_tgt_sess_fops); > > if (IS_QLA27XX(ha) || IS_QLA83XX(ha) || IS_QLA28XX(ha)) > ha->tgt.dfs_naqp = debugfs_create_file("naqp", > -- > 2.23.0 > Nice cleanup. Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: initialize value

la2xxx/qla_nx2.c > @@ -659,7 +659,7 @@ static int > qla8044_poll_reg(struct scsi_qla_host *vha, uint32_t addr, > int duration, uint32_t test_mask, uint32_t test_result) > { > - uint32_t value; > + uint32_t value = 0; > int timeout_error; > uint8_t retries

Re: [PATCH] qla2xxx: Use constant when it is known.

;fw_started) || > (fcport && fcport->deleted)) > - return rval; > + return -ENODEV; > > vha = fcport->vha; > /* > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) > http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH] use cpu_to_le{16,32} instead of __constant_cpu_to_

Bart, > On Aug 27, 2020, at 4:01 PM, Rene Rebe wrote: > > So following your recommendation here is a RFC removing all the other > few remaining __constant_cpu_to_le{16,32} instances. RFC looks fine. Please add RB to official patch when you send it out. Reviewed-by: Hima

Re: [PATCH] qla2xxx: Set NVME status code for failed NVME FCP request

gt;transferred_length = 0; + fd->status = NVME_SC_INTERNAL; } - fd->status = 0; spin_unlock_irqrestore(>cmd_lock, flags); fd->done(fd); Makes sense. Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH] nvme-fc: Only call nvme_cleanup_cmd() for normal operations

_state == FC_OBJSTATE_ONLINE && Reviewed-by: Himanshu Madhani

Re: [PATCH] MAINTAINER: Update my email address

On 5/7/20 12:23 PM, Joe Perches wrote: On Thu, 2020-05-07 at 12:08 -0500, himanshu.madh...@oracle.com wrote: On 5/7/20 11:57 AM, Joe Perches wrote: On Thu, 2020-05-07 at 11:12 -0500, Himanshu Madhani wrote: I do not have access to my @marvell.com email ID anymore. Lets map my new email

[PATCH v2] .mailmap: Update address of Himanshu Madhani

I do not have access to my @marvell.com email ID anymore. Lets map my new email address correctly in .mailmap Signed-off-by: Himanshu Madhani --- Changes from v1 - Update patch subject line to reflect .mailmap changes. --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap

Re: [PATCH] MAINTAINER: Update my email address

On 5/7/20 11:57 AM, Joe Perches wrote: On Thu, 2020-05-07 at 11:12 -0500, Himanshu Madhani wrote: I do not have access to my @marvell.com email ID anymore. Lets map my new email address correctly in .mailmap Bad patch subject, this is a .mailmap patch. Maybe [PATCH] .mailmap: Update

[PATCH] MAINTAINER: Update my email address

I do not have access to my @marvell.com email ID anymore. Lets map my new email address correctly in .mailmap Signed-off-by: Himanshu Madhani --- .mailmap | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.mailmap b/.mailmap index db3754a41018..30d8c3f10ca7 100644 --- a/.mailmap +++ b

Re: [PATCH] scsi: qla2xxx: use true,false for need_mpi_reset

;mpi_fw_dump_len = len; Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [PATCH][next] scsi: qla2xxx: make 1 bit bit-fields unsigned int

int mpi_fw_dumped:1; + unsigned intmpi_fw_dump_reading:1; + unsigned intmpi_fw_dumped:1; int prev_minidump_failed; dma_addr_t eft_dma; void*eft; Reviewed-by: Himanshu Madhani -- Himanshu Madhani Oracle Linux Engineering

Re: [EXT] VPD access Blocked by commit 0d5370d1d85251e5893ab7c90a429464de2e140b

Hi Bjorn, > On May 30, 2019, at 1:58 PM, Bjorn Helgaas wrote: > > On Thu, May 30, 2019 at 07:33:01PM +, Himanshu Madhani wrote: > >> We are able to successfully read VPD config data using lspci and cat >> command > > Yes, you mentioned that in the very

Re: [EXT] VPD access Blocked by commit 0d5370d1d85251e5893ab7c90a429464de2e140b

aas > Date: Tue, May 21, 2019 at 3:02 PM > To: Himanshu Madhani > Cc: ethan.z...@oracle.com, Andrew Vasquez, Girish Basrur, Giridhar > Malavali, Myron Stowe, , Linux Kernel Mailing > List, Quinn Tran > >> [+cc Myron, Quinn, linux-pci, linux-kernel] >> >> F

Re: [PATCH 3/4] scsi: qla2xxx: avoid printf format warning

dma_sg_len: %x dif_bundl_len: %x ldma_needed: %x\n", - __func__, i, sg_phys(sg), sglen, ldma_sg_len, + __func__, i, (u64)sg_phys(sg), sglen, ldma_sg_len, difctx->dif_bundl_len, ldma_needed); while (sglen) { -- 2.20.0 Looks good Acked-by: Himanshu Madhani

Re: [PATCH][V2] scsi: qla2xxx: remove redundant null check on pointer sess

>base_qpair, NULL, >tm_iocb2, 1, 0); -- 2.20.1 Thanks for the Patch. Looks good Acked-by: Himanshu Madhani

Re: [PATCH] scsi: qla2xxx: remove some redundant pointer assignments

00_remove_one(struct pci_dev *pdev) > > pci_release_selected_regions(ha->pdev, ha->bars); > kfree(ha); > - ha = NULL; > > pci_disable_pcie_error_reporting(pdev); > > @@ -3568,7 +3563,6 @@ void qla2x00_free_fcports(struct scsi_qla_host *vha) > list_del(>list); > qla2x00_clear_loop_id(fcport); > kfree(fcport); > - fcport = NULL; > } > } > > Looks Good. Acked-By: Himanshu Madhani <himanshu.madh...@cavium.com>

Re: [PATCH] scsi: qla2xxx: remove some redundant pointer assignments

elease_selected_regions(ha->pdev, ha->bars); > kfree(ha); > - ha = NULL; > > pci_disable_pcie_error_reporting(pdev); > > @@ -3568,7 +3563,6 @@ void qla2x00_free_fcports(struct scsi_qla_host *vha) > list_del(>list); > qla2x00_clear_loop_id(fcport); > kfree(fcport); > - fcport = NULL; > } > } > > Looks Good. Acked-By: Himanshu Madhani

Re: Capturing crash with 4.6.0 and above kernel does not work

On 8/26/16, 5:15 PM, "Baoquan He" <b...@redhat.com> wrote: >On 08/26/16 at 04:47pm, Himanshu Madhani wrote: >> >> >> On 8/25/16, 10:39 PM, "Baoquan He" <b...@redhat.com> wrote: >> >> >On 08/25/16 at 05:45pm, H

Re: Capturing crash with 4.6.0 and above kernel does not work

On 8/26/16, 5:15 PM, "Baoquan He" wrote: >On 08/26/16 at 04:47pm, Himanshu Madhani wrote: >> >> >> On 8/25/16, 10:39 PM, "Baoquan He" wrote: >> >> >On 08/25/16 at 05:45pm, Himanshu Madhani wrote: >> >> >> >

Re: [PATCH] qla2xxx: fix spelling mistake "retyring" -> "retrying"

,7 +4718,7 @@ retry_unlock2: > qla83xx_wait_logic(); > retry++; > ql_dbg(ql_dbg_p3p, base_vha, 0xb066, >- "Failed to release IDC lock, retyring=%d\n", retry); >+ "Failed to r

Re: [PATCH] qla2xxx: fix spelling mistake "retyring" -> "retrying"

retry++; > ql_dbg(ql_dbg_p3p, base_vha, 0xb066, >- "Failed to release IDC lock, retyring=%d\n", retry); >+ "Failed to release IDC lock, retrying=%d\n", retry); > goto retry_unlock2; > } > } >-- >2.9.3 > Thanks Colin. Looks Good. Acked-by: Himanshu Madhani >

Re: Capturing crash with 4.6.0 and above kernel does not work

On 8/25/16, 10:03 PM, "Dave Young" <dyo...@redhat.com> wrote: >On 08/25/16 at 05:45pm, Himanshu Madhani wrote: >> >> >> On 8/25/16, 1:10 AM, "Michal Hocko" <mho...@kernel.org> wrote: >> >> >[Let's add kdump people] >>

Re: Capturing crash with 4.6.0 and above kernel does not work

On 8/25/16, 10:03 PM, "Dave Young" wrote: >On 08/25/16 at 05:45pm, Himanshu Madhani wrote: >> >> >> On 8/25/16, 1:10 AM, "Michal Hocko" wrote: >> >> >[Let's add kdump people] >> > >> >On Wed 24-08-16 16:38:56, Himans

Re: Capturing crash with 4.6.0 and above kernel does not work

On 8/25/16, 10:39 PM, "Baoquan He" <b...@redhat.com> wrote: >On 08/25/16 at 05:45pm, Himanshu Madhani wrote: >> > >crashkernel has been reserved successfully. >Aug 25 10:36:44 dut4062 kernel: Reserving 512MB of memory at 368MB for >crashkernel (System R

Re: Capturing crash with 4.6.0 and above kernel does not work

On 8/25/16, 10:39 PM, "Baoquan He" wrote: >On 08/25/16 at 05:45pm, Himanshu Madhani wrote: >> > >crashkernel has been reserved successfully. >Aug 25 10:36:44 dut4062 kernel: Reserving 512MB of memory at 368MB for >crashkernel (System RAM: 130847MB) > >So

Re: Capturing crash with 4.6.0 and above kernel does not work

On 8/25/16, 1:10 AM, "Michal Hocko" <mho...@kernel.org> wrote: >[Let's add kdump people] > >On Wed 24-08-16 16:38:56, Himanshu Madhani wrote: >> Hello list, >> >> I am wondering if anybody has issue capturing crash dump with the 4.6.0 and >>

Re: Capturing crash with 4.6.0 and above kernel does not work

On 8/25/16, 1:10 AM, "Michal Hocko" wrote: >[Let's add kdump people] > >On Wed 24-08-16 16:38:56, Himanshu Madhani wrote: >> Hello list, >> >> I am wondering if anybody has issue capturing crash dump with the 4.6.0 and >> above kenrel. >>

Capturing crash with 4.6.0 and above kernel does not work

Hello list, I am wondering if anybody has issue capturing crash dump with the 4.6.0 and above kenrel. I have a system, when booted in 4.5.7 kernel is able to capture crash dump. However, when I boot this system in 4.6.4 and 4.7.2 kernel, crash dump is not able to capture any crash. I am

Capturing crash with 4.6.0 and above kernel does not work

Hello list, I am wondering if anybody has issue capturing crash dump with the 4.6.0 and above kenrel. I have a system, when booted in 4.5.7 kernel is able to capture crash dump. However, when I boot this system in 4.6.4 and 4.7.2 kernel, crash dump is not able to capture any crash. I am

Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

eld. A possible case for such a race would be in the kdump >Johannes> case when the HBA's IRQs are still enabled but the driver is >Johannes> undergoing a new initialisation and thus is not aware of >Johannes> already activated IRQs in the HBA. > >Qlogic folks: Please review!

Re: [PATCH] qla2xxx: setup data needed in ISR before setting up the ISR

he kdump >Johannes> case when the HBA's IRQs are still enabled but the driver is >Johannes> undergoing a new initialisation and thus is not aware of >Johannes> already activated IRQs in the HBA. > >Qlogic folks: Please review! Looks Good. Reviewed-by: Himanshu Madhani > >-- >Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

On 7/8/16, 12:27 AM, "Thorsten Leemhuis" wrote: >Bruno Prémont wrote on 30.06.2016 17:00: >> In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL >> pointer dereference when rsp->msix is NULL: >> […] >> The affected code was introduced by commit >>

Re: [PATCH] qla2xxx: Fix NULL pointer deref in QLA interrupt

On 7/8/16, 12:27 AM, "Thorsten Leemhuis" wrote: >Bruno Prémont wrote on 30.06.2016 17:00: >> In qla24xx_process_response_queue() rsp->msix->cpuid may trigger NULL >> pointer dereference when rsp->msix is NULL: >> […] >> The affected code was introduced by commit >>

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

ly add initializations to >the variables when the compiler should have figured it out. > >In this case, I wouldn't expect the compiler to ever see through >the unlikely() macro, and I'm not adding a potentially counterproductive >initialization, so I see no reason not to apply the patch. I

Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning

>the variables when the compiler should have figured it out. > >In this case, I wouldn't expect the compiler to ever see through >the unlikely() macro, and I'm not adding a potentially counterproductive >initialization, so I see no reason not to apply the patch. I would like to kee

Re: [Y2038] [PATCH, RESEND 2] qla2xxx: Remove use of 'struct timeval'

nnes Thumshirn >> Signed-off-by: Arnd Bergmann >> > > > >I was missing > >From: Tina Ruchandani > >If anyone is going to pick this up, let me know whether you will fix >it up yourself or if I should resend. Please resend the patch and add Acked-by: Himans

Re: [Y2038] [PATCH, RESEND 2] qla2xxx: Remove use of 'struct timeval'

t; > >If anyone is going to pick this up, let me know whether you will fix >it up yourself or if I should resend. Please resend the patch and add Acked-by: Himanshu Madhani <himanshu.madh...@qlogic.com> >-- >To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >the body of a message to majord...@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html Thanks, - Himanshu

Re: [PATCH] qla2xxx: remove unused rval

clear_bit(LOOP_RESYNC_ACTIVE, > _vha->dpc_flags); >-- >2.5.0.rc3 > >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majord...@vger.kernel.org &g

Re: [PATCH] qla2xxx: remove unused rval

-by: Himanshu Madhani himanshu.madh...@qlogic.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

t: send the line "unsubscribe linux-kernel" in >the body of a message to majord...@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ Looks Good. Acked-by: Himanshu Madhani > -- To u

Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ Looks Good. Acked-by: Himanshu Madhani himanshu.madh...@qlogic.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH] [RESEND] qla2xxx: prevent board_disable from running during EEH

el_offline(vha->hw->pdev)) { > if (!test_and_set_bit(PFLG_DISCONNECTED, >pci_flags) && > !test_bit(PFLG_DRIVER_REMOVING, >pci_flags) && > !test_bit(PFLG_DRIVER_PROBING, >pci_flags)) { >-- >1.7.10.4 > > L

Re: [PATCH] [RESEND] qla2xxx: prevent board_disable from running during EEH

) !test_bit(PFLG_DRIVER_REMOVING, vha-pci_flags) !test_bit(PFLG_DRIVER_PROBING, vha-pci_flags)) { -- 1.7.10.4 Looks good. Acked-by: Himanshu Madhani himanshu.madh...@qlogic.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body