> Hello,
>
> On Thu, 14 Jan 2021, at 09:08, Hongwei Zhang wrote:
> > Add gpio base address reading in the driver; in old code, it just
> > returns -1 to gpio->chip.base.
>
> Why do you want to do this? It feels hacky. The base address only affects the
> legac
Dear Reviewer,
Add gpio base address reading in the driver; in old code, it just
returns -1 to gpio->chip.base. In this patch, the code first try to
read base address from of_property_read_u32(), if it fails, then
return -1.
Hongwei Zhang (1):
gpio: aspeed: Add gpio base address read
Add gpio base address reading in the driver; in old code, it just
returns -1 to gpio->chip.base.
Fixes: 7ee2d5b4d4340353 ("ARM: dts: nuvoton: Add Fii Kudo system")
Signed-off-by: Hongwei Zhang
---
drivers/gpio/gpio-aspeed.c | 7 +--
1 file changed, 5 insertions(+), 2 delet
>
> From: Jakub Kicinski
> Sent: Monday, December 21, 2020 5:10 PM
> To: Hongwei Zhang
>
> On Mon, 21 Dec 2020 14:40:26 -0500 Hongwei Zhang wrote:
> > When FTGMAC100 driver is used on other NCSI Ethernet controllers, few
>
> When you say NCSI Ethernet controller
mac100@1e66 for NCSI, and this is also true for
AST2500.
--Hongwei
> > -Original Message-
> > From: Linux-aspeed
> > [mailto:linux-aspeed-bounces+dylan_hung=aspeedtech@lists.ozlabs.or
> > g]
> > On Behalf Of Joel Stanley
> > Sent: 2020?12?22? 10
> From: Jakub Kicinski
> Sent: Monday, December 28, 2020 5:01 PM
>
> On Tue, 22 Dec 2020 22:00:34 +0100 Andrew Lunn wrote:
> > On Tue, Dec 22, 2020 at 09:46:52PM +0100, Heiner Kallweit wrote:
> > > On 22.12.2020 21:14, Hongwei Zhang wrote:
> > > > Dear R
I've update the patch to fix the comments.
>
> > Fixes: 35c54922dc97 ("ARM: dts: tacoma: Add reserved memory for
> > ramoops")
> > Signed-off-by: Hongwei Zhang
> > ---
> > drivers/net/ethernet/faraday/ftgmac100.c | 22 +-
> > 1 file changed, 13 insertions(+), 9 deletions(-)
--Hongwei
://patchwork.ozlabs.org/project/linux-aspeed/list/?series=221576
- Initial submission
Hongwei Zhang (1):
net: ftgmac100: Change the order of getting MAC address
drivers/net/ethernet/faraday/ftgmac100.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
--
2.17.1
Change the order of reading MAC address, try to read it from MAC chip
first, if it's not availabe, then try to read it from device tree.
Fixes: 35c54922dc97 ("ARM: dts: tacoma: Add reserved memory for ramoops")
Signed-off-by: Hongwei Zhang
---
drivers/net/ethernet/faraday/ftgmac
Change the order of reading MAC address, try to read it from MAC chip
first, if it's not availabe, then try to read it from device tree.
Fixes: 35c54922dc97 ("ARM: dts: tacoma: Add reserved memory for ramoops")
Signed-off-by: Hongwei Zhang
---
drivers/net/ethernet/faraday/ftgmac
Dear Reviewer,
Use native MAC address is preferred over other choices, thus change the order
of reading MAC address, try to read it from MAC chip first, if it's not
availabe, then try to read it from device tree.
Hongwei Zhang (1):
net: ftgmac100: Change the order of getting MAC address
When FTGMAC100 driver is used on other NCSI Ethernet controllers, few
controllers have compatible issue, removing FTGMAC100_RXDES0_RX_ERR bit
from RXDES0_ANY_ERROR can fix the issue.
Fixes: 7ee2d5b4d4340353 ("ARM: dts: nuvoton: Add Fii Kudo system")
Signed-off-by: Hongwei Zhang
---
d
. If it is needed, user can set the flag to NO to remove
the RXDES0_RX_ERR bit, to fix the issue.
Hongwei Zhang (1):
net: ftgmac100: Fix AST2600 EVB NCSI RX issue
drivers/net/ethernet/faraday/Kconfig | 9 +
drivers/net/ethernet/faraday/ftgmac100.h | 8
2 files changed, 17
Hi Andrew,
> From: Andrew Jeffery
>
> > Fix AST2600 EVB NCSI RX timeout issue by removing
> > FTGMAC100_RXDES0_RX_ERR bit from macro RXDES0_ANY_ERROR.
>
> But why? What is wrong with the EVB that this change resolves? Which revision
> of the EVB?
>
> The change affects all designs using the
Hi Jakub,
> From: Jakub Kicinski
>
> > ...
> > Signed-off-by: Hongwei Zhang
>
> Thanks for the patch. Please repost CCing the netdev mailing list so it can
> be merged to the networking
> tree (which I assume is your intent).
> Please also include a Fixes
When FTGMAC100 driver is used on other NCSI Ethernet controllers, few
controllers have compatible issue, removing FTGMAC100_RXDES0_RX_ERR bit
from RXDES0_ANY_ERROR can fix the issue.
Fixes: 7ee2d5b4d4340353 ("ARM: dts: nuvoton: Add Fii Kudo system")
Signed-off-by: Hongwei Zhang
---
d
. If it is needed, user can set the flag to NO to remove
the RXDES0_RX_ERR bit, to fix the issue.
Hongwei Zhang (1):
net: ftgmac100: Fix AST2600 EVB NCSI RX issue
drivers/net/ethernet/faraday/Kconfig | 9 +
drivers/net/ethernet/faraday/ftgmac100.h | 8
2 files changed, 17
Fix AST2600 EVB NCSI RX timeout issue by removing FTGMAC100_RXDES0_RX_ERR bit
from macro RXDES0_ANY_ERROR.
Signed-off-by: Hongwei Zhang
---
drivers/net/ethernet/faraday/ftgmac100.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/faraday/ftgmac100.h
b/drivers/net
Dear Reviewer,
Fix AST2600 EVB NCSI RX timeout issue by removing FTGMAC100_RXDES0_RX_ERR bit
from macro RXDES0_ANY_ERROR.
Hongwei Zhang (1):
net: ftgmac100: Fix AST2600 EVB NCSI RX issue
drivers/net/ethernet/faraday/ftgmac100.h | 1 -
1 file changed, 1 deletion(-)
--
2.17.1
Thanks Linus,
>
> I sent a separate patch to fix this up the way I want it with the file named
> gpio-aspeed-sgpio.c and
> CONFIG_GPIO_ASPEED_SGPIO.
>
> I don't want to mix up the namespaces of something Aspeed-generic with the
> namespace of the GPIO
> subsystem. SGPIO is the name of a
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
arch/arm/Kconfig | 2 ++
arch/arm/boot/dts/aspeed-g5.dtsi | 16 +++-
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 2436021..c9f08ab 100644
--- a/arch/arm/Kconfig
+++ b/arch
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/Kconfig | 8
drivers/gpio/Makefile| 1 +
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index bb13c26..e94f903 100644
--- a/drivers/gpio/Kconfig
+++ b
been accepted and merged into v5.4:
_http://patchwork.ozlabs.org/patch/1150357/
The related SGPM pinmux dt-binding document, dts, and pinctrl driver
updates have been accepted and merged:
_http://patchwork.ozlabs.org/patch/1110210/
Thanks!
Hongwei Zhang (1):
gpio: dts: aspeed: Add SGPIO driver
>
> > The related SGPIO driver has been accepted and merged into v5.4:
> > _http://patchwork.ozlabs.org/patch/1150357/
>
> Oh what a mess, it didn't add the necessary code into Kconfig and Makefile,
> also names it sgpio-gpio.c
> when everything else is named gpio-sgpio.c.
>
> I guess I have
> > obj-$(CONFIG_GPIO_BD70528) += gpio-bd70528.o
> > --
> > 2.7.4
> >
>
> This should be split into separate patches with one extending the binding
> document and one adding
> actual support.
>
> Bart
Thanks Bart,
I just submitted splitted patches.
--Hongwei
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
arch/arm/Kconfig | 2 ++
arch/arm/boot/dts/aspeed-g5.dtsi | 16 +++-
drivers/gpio/Kconfig | 8
drivers/gpio/Makefile| 1 +
4 files changed, 26
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
arch/arm/Kconfig | 2 ++
arch/arm/boot/dts/aspeed-g5.dtsi | 16 +++-
drivers/gpio/Kconfig | 8
drivers/gpio/Makefile| 1 +
4 files changed, 26
SGPM pinmux dt-binding document, dts, and pinctrl driver
updates have been accepted and merged:
_http://patchwork.ozlabs.org/patch/1110210/
Thanks!
Hongwei Zhang (1):
gpio: dts: aspeed: Add SGPIO driver
arch/arm/Kconfig | 2 ++
arch/arm/boot/dts/aspeed-g5.dtsi | 16
P.S. sorry previous response used wrong In-Reply-To ID, so resent it again.
> From: Linus Walleij
> Sent: Wednesday, August 14, 2019 4:09 AM
> To: Hongwei Zhang
> Cc: Andrew Jeffery; open list:GPIO SUBSYSTEM; Joel Stanley; linux-aspeed;
> Bartosz Golaszewski;
> linux-kern
> From: Linus Walleij
> Sent: Wednesday, August 14, 2019 4:09 AM
> To: Hongwei Zhang
> Cc: Andrew Jeffery; open list:GPIO SUBSYSTEM; Joel Stanley; linux-aspeed;
> Bartosz Golaszewski;
> linux-kernel@vger.kernel.org; Linux ARM
> Subject: Re: [v7 2/2] gpio: aspeed: Add
cleanup
The related SGPM pinmux dt-binding document, dts, and pinctrl driver
updates have been accepted and merged:
_http://patchwork.ozlabs.org/patch/1110210/
Hongwei Zhang (1):
gpio: aspeed: Add SGPIO driver
drivers/gpio/sgpio-aspeed.c | 533
1 file
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
Reviewed-by: Andrew Jeffery
---
drivers/gpio/sgpio-aspeed.c | 533
1 file changed, 533 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git
Hello Andrew,
Thanks so much for your help.
> From: Andrew Jeffery
> Sent: Tuesday, July 30, 2019 8:19 PM
> To: Hongwei Zhang; Linus Walleij; linux-g...@vger.kernel.org
> Cc: Joel Stanley; linux-asp...@lists.ozlabs.org; Bartosz Golaszewski;
> linux-kernel@vger.kernel.org;
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
Reviewed-by: Andrew Jeffery
---
drivers/gpio/sgpio-aspeed.c | 530
1 file changed, 530 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
Reviewed-by: Andrew Jeffery
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio
:
- fix a bug in aspeed_sgpio_dir_out()
- v5 feedback updates, some comments cleanup
The related SGPM pinmux dt-binding document, dts, and pinctrl driver
updates have been accepted and merged:
_http://patchwork.ozlabs.org/patch/1110210/
Hongwei Zhang (2):
dt-bindings: gpio
proper
serial
title and one of the patch is missing.
--Hongwei
> From: Linus Walleij
> Sent: Monday, July 29, 2019 5:57 PM
> To: Andrew Jeffery
> Cc: Hongwei Zhang; open list:GPIO SUBSYSTEM; Joel Stanley; open list:OPEN
> FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS; lin
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 521
1 file changed, 521 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
document, dts, and pinctrl driver
updates have been accepted and merged:
_http://patchwork.ozlabs.org/patch/1110210/
Hongwei Zhang (2):
dt-bindings: gpio: aspeed: Add SGPIO support
gpio: aspeed: Add SGPIO driver
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 +++
drivers/gpio/sgpio
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 521
1 file changed, 521 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers
:38 PM
> To: Hongwei Zhang
> Cc: Andrew Jeffery; linux-gpio; Joel Stanley; linux-aspeed; Bartosz
> Golaszewski; linux-kernel; linux-
> arm-kernel
> Subject: Re: [v5 2/2] gpio: aspeed: Add SGPIO driver
>
> On Mon, Jul 22, 2019 at 10:37 PM Hongwei Zhang wrote:
>
>
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 521
1 file changed, 521 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers
Hello Linus,
Thanks for your reviewing, please find my inline comment on why we group the
("A", "B", "C", "D") etc. together at below. We will address other concerns
separately.
--Hongwei
> From: Linus Walleij
> Sent: Saturday, July 20, 201
pins".
Would you please give us some hints on how to configure the SGPIO pins so that
we can use them as input and output 'concurrently' ?
Thanks,
--Hongwei
> From: Andrew Jeffery
> Sent: Wednesday, July 17, 2019 9:45 PM
> To: Hongwei Zhang; Bartosz Golaszewski; Joel Stanley;
Hello Andrew,
Thanks for reviewing and please see my inline comments.
--Hongwei
> From: Andrew Jeffery
> Sent: Wednesday, July 17, 2019 9:48 PM
> To: Hongwei Zhang; Joel Stanley; Linus Walleij; devicet...@vger.kernel.org
> Cc: Rob Herring; Mark Rutland; Bartosz Golaszewski;
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 522
1 file changed, 522 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
Hello,
This short series introduce dt-binding document and a driver for the
Aspeed AST2500 SGPIO controller. Please review.
The related SGPM pinmux dt-binding document, dts, and pinctrl driver
updates have been accepted and merged:
_http://patchwork.ozlabs.org/patch/1110210/
Hongwei Zhang (2
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 518
1 file changed, 518 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers
Hello Andrew,
Thanks for your review, please find the v4 in separate email. We merged all
your suggestion in v4.
Best Regards,
--Hongwei
-Original Message-
> From: Andrew Jeffery
> Sent: Tuesday, July 16, 2019 11:26 PM
> To: Hongwei Zhang; Bartosz Golaszewski; Joel Stanl
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 55 ++
1 file changed, 55 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 487
1 file changed, 487 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers
Thanks for your review, Andrew,
Just submitted an updated binding document, with new proper subject line:
[PATCH 2/3 v2] dt-bindings: gpio: aspeed: Add SGPIO support
Regards,
--Hongwei
-Original Message-
From: Andrew Jeffery
Sent: Tuesday, July 9, 2019 10:16 PM
To: Hongwei Zhang
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 43 ++
1 file changed, 43 insertions(+)
create mode 100755 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 450
1 file changed, 450 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers
see it at below.
Best Regards,
-- Hongwei
> From: Andrew Jeffery
> Sent: Wednesday, July 3, 2019 8:06 PM
> To: Hongwei Zhang; Bartosz Golaszewski; Joel Stanley; Linus Walleij
> Cc: linux-g...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;
> linux-asp...@lists.ozlab
Add SGPIO driver support for Aspeed AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
drivers/gpio/sgpio-aspeed.c | 470
1 file changed, 470 insertions(+)
create mode 100644 drivers/gpio/sgpio-aspeed.c
diff --git a/drivers/gpio/sgpio-aspeed.c b/drivers
Add bindings to support SGPIO on AST2400 or AST2500.
Signed-off-by: Hongwei Zhang
---
.../devicetree/bindings/gpio/sgpio-aspeed.txt | 36 ++
1 file changed, 36 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/sgpio-aspeed.txt
diff --git
-Original Message-
From: Linus Walleij
Sent: Monday, June 3, 2019 7:08 PM
To: Hongwei Zhang
Cc: Joel Stanley ; Andrew Jeffery ; Rob
Herring ; Mark Rutland ; open
list:GPIO SUBSYSTEM ; open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS ; Linux ARM
; linux-asp
Add SGPM pinmux to ast2500-pinctrl function and group, to prepare for
supporting SGPIO in AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 2 +-
drivers/pinctrl/aspeed/pinctrl-aspeed-g5.c | 4
2 files changed, 5
Add SGPM pinmux to ast2500-pinctrl function and group, to prepare for
supporting SGPIO in AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
arch/arm/boot/dts/aspeed-g5.dtsi | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
Add SGPM pinmux to ast2500-pinctrl function and group, to prepare for
supporting SGPIO in AST2500 SoC.
Signed-off-by: Hongwei Zhang
---
Documentation/devicetree/bindings/pinctrl/pinctrl-aspeed.txt | 2 +-
arch/arm/boot/dts/aspeed-g5.dtsi | 5 +
drivers/pinctrl
64 matches
Mail list logo
