Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-30 Thread Ingi Kim
Hi Jacek, On 2015년 11월 30일 19:59, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/30/2015 03:31 AM, Ingi Kim wrote: >> Hi Jacek, >> >> On 2015년 11월 26일 18:43, Jacek Anaszewski wrote: >>> Hi Ingi, >>> >>> On 11/26/2015 09

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-30 Thread Ingi Kim
Hi Jacek, On 2015년 11월 30일 19:59, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/30/2015 03:31 AM, Ingi Kim wrote: >> Hi Jacek, >> >> On 2015년 11월 26일 18:43, Jacek Anaszewski wrote: >>> Hi Ingi, >>> >>> On 11/26/2015 09

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-29 Thread Ingi Kim
Hi, Lee Thanks to the review, I'll carry your Ack when I reflect Jacek's comment. On 2015년 11월 26일 18:11, Lee Jones wrote: > On Wed, 25 Nov 2015, Ingi Kim wrote: > >> This patch adds device driver of Richtek RT5033 PMIC. >> The RT5033 Flash LED Circuit is designed for one o

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-29 Thread Ingi Kim
Hi Jacek, On 2015년 11월 26일 18:43, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/26/2015 09:02 AM, Ingi Kim wrote: > [...] >>>> +torch_unlock: >>>> +mutex_unlock(>lock); >>>> +return ret; >>>> +} >>>> +

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-29 Thread Ingi Kim
Hi, Lee Thanks to the review, I'll carry your Ack when I reflect Jacek's comment. On 2015년 11월 26일 18:11, Lee Jones wrote: > On Wed, 25 Nov 2015, Ingi Kim wrote: > >> This patch adds device driver of Richtek RT5033 PMIC. >> The RT5033 Flash LED Circuit is designed for one o

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-29 Thread Ingi Kim
Hi Jacek, On 2015년 11월 26일 18:43, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/26/2015 09:02 AM, Ingi Kim wrote: > [...] >>>> +torch_unlock: >>>> +mutex_unlock(>lock); >>>> +return ret; >>>> +} >>>> +

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-26 Thread Ingi Kim
Hi Jacek, Thanks for the review. On 2015년 11월 26일 00:13, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. > > On 11/25/2015 11:22 AM, Ingi Kim wrote: >> This patch adds device driver of Richtek RT5033 PMIC. >> The RT5033 Flash LED Circuit is designed

Re: [PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-26 Thread Ingi Kim
Hi Jacek, Thanks for the review. On 2015년 11월 26일 00:13, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. > > On 11/25/2015 11:22 AM, Ingi Kim wrote: >> This patch adds device driver of Richtek RT5033 PMIC. >> The RT5033 Flash LED Circuit is designed

[PATCH v6 1/2] leds: rt5033: Add DT binding for RT5033

2015-11-25 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim Acked-by: Rob Herring --- .../devicetree/bindings/leds/leds-rt5033.txt | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds

[PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-25 Thread Ingi Kim
their setting, and can be connected together for a single connected LED. One LED is represented by one child node. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-rt5033.c | 541

[PATCH v6 0/2] Add RT5033 Flash LED driver

2015-11-25 Thread Ingi Kim
ister back again - Fix compile error Original cover letter: This patch supports flash led of RT5033 PMIC. [1] https://lkml.org/lkml/2015/8/20/426 Ingi Kim (2): leds: rt5033: Add DT binding for RT5033 leds: rt5033: Add RT5033 Flash led device driver .../devicetree/bindings/leds/leds

Re: [PATCH v5 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-25 Thread Ingi Kim
Hi Jacek, Thanks for the review I'm trying to fix all things what you mentioned. I'll push next version soon. On 2015년 11월 24일 21:16, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/19/2015 11:07 AM, Ingi Kim wrote: >> Hi Jacek, >> >> Thanks for the review. > >

[PATCH v6 0/2] Add RT5033 Flash LED driver

2015-11-25 Thread Ingi Kim
ister back again - Fix compile error Original cover letter: This patch supports flash led of RT5033 PMIC. [1] https://lkml.org/lkml/2015/8/20/426 Ingi Kim (2): leds: rt5033: Add DT binding for RT5033 leds: rt5033: Add RT5033 Flash led device driver .../devicetree/bindings/leds/leds

[PATCH v6 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-25 Thread Ingi Kim
their setting, and can be connected together for a single connected LED. One LED is represented by one child node. Signed-off-by: Ingi Kim <ingi2@samsung.com> --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-rt5033.c

[PATCH v6 1/2] leds: rt5033: Add DT binding for RT5033

2015-11-25 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim <ingi2@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/leds/leds-rt5033.txt | 46 ++ 1 file changed, 46 insertions(+) create

Re: [PATCH v5 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-25 Thread Ingi Kim
Hi Jacek, Thanks for the review I'm trying to fix all things what you mentioned. I'll push next version soon. On 2015년 11월 24일 21:16, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/19/2015 11:07 AM, Ingi Kim wrote: >> Hi Jacek, >> >> Thanks for the review. > >

Re: [PATCH v5 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-19 Thread Ingi Kim
1/17/2015 10:04 AM, Ingi Kim wrote: >> This patch adds device driver of Richtek RT5033 PMIC. >> The RT5033 Flash LED Circuit is designed for one or two LEDs driving >> for torch and strobe applications, it provides an I2C software command >> to trigger the torch and strobe o

Re: [PATCH v5 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-19 Thread Ingi Kim
1/17/2015 10:04 AM, Ingi Kim wrote: >> This patch adds device driver of Richtek RT5033 PMIC. >> The RT5033 Flash LED Circuit is designed for one or two LEDs driving >> for torch and strobe applications, it provides an I2C software command >> to trigger the torch and strobe o

[PATCH v5 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-17 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The RT5033 Flash LED Circuit is designed for one or two LEDs driving for torch and strobe applications, it provides an I2C software command to trigger the torch and strobe operation. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig

[PATCH v5 0/2] Add RT5033 Flash LED driver

2015-11-17 Thread Ingi Kim
ix typo error - Change naming of mfd register back again - Fix compile error Original cover letter: This patch supports flash led of RT5033 PMIC. [1] https://lkml.org/lkml/2015/8/20/426 Ingi Kim (2): leds: rt5033: Add DT binding for RT5033 leds: rt5033: Add RT5033 Flash led device driver

[PATCH v5 1/2] leds: rt5033: Add DT binding for RT5033

2015-11-17 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim Acked-by: Rob Herring --- .../devicetree/bindings/leds/leds-rt5033.txt | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds

[PATCH v5 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-17 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The RT5033 Flash LED Circuit is designed for one or two LEDs driving for torch and strobe applications, it provides an I2C software command to trigger the torch and strobe operation. Signed-off-by: Ingi Kim <ingi2@samsung.com> --- d

[PATCH v5 1/2] leds: rt5033: Add DT binding for RT5033

2015-11-17 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim <ingi2@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/leds/leds-rt5033.txt | 46 ++ 1 file changed, 46 insertions(+) create

[PATCH v5 0/2] Add RT5033 Flash LED driver

2015-11-17 Thread Ingi Kim
ix typo error - Change naming of mfd register back again - Fix compile error Original cover letter: This patch supports flash led of RT5033 PMIC. [1] https://lkml.org/lkml/2015/8/20/426 Ingi Kim (2): leds: rt5033: Add DT binding for RT5033 leds: rt5033: Add RT5033 Flash led device driver

Re: [PATCH] leds: ktd2692: Add missing of_node_put

2015-11-16 Thread Ingi Kim
i, Rob, >>> >>> With this patch we will be leaking of_node when parsing succeeds. >>> I think that "return 0" should be removed. I can remove it and apply, >>> provided that Rob's ack is still in force with this. Rob? >> >> Okay. &g

Re: [PATCH] leds: ktd2692: Add missing of_node_put

2015-11-16 Thread Ingi Kim
gt;> Okay. > > Removed discussed line and applied, thanks. > >>> On 11/10/2015 04:00 AM, Ingi Kim wrote: >>>> >>>> The refcount of device_node increases after of_node_get() is called. >>>> So, a break out of the loop requires of_node_put(). &

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-12 Thread Ingi Kim
Hi Jacek, On 2015년 11월 12일 18:21, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/12/2015 08:57 AM, Ingi Kim wrote: > [...] >>>> +regmap_write(led->regmap, RT5033_REG_FLED_FUNCTION1, val); >>>> +} else { >>>> +regmap

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-12 Thread Ingi Kim
Hi Jacek, On 2015년 11월 12일 18:21, Jacek Anaszewski wrote: > Hi Ingi, > > On 11/12/2015 08:57 AM, Ingi Kim wrote: > [...] >>>> +regmap_write(led->regmap, RT5033_REG_FLED_FUNCTION1, val); >>>> +} else { >>>> +regmap

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-11 Thread Ingi Kim
Hi Jacek, Thanks for the review. your feedback is highly appreciated :) I'll send next patch set soon. On 2015년 11월 11일 01:30, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. Please find my comments below. > > On 11/10/2015 03:17 AM, Ingi Kim wrote: >> T

Re: [PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-11 Thread Ingi Kim
Hi Jacek, Thanks for the review. your feedback is highly appreciated :) I'll send next patch set soon. On 2015년 11월 11일 01:30, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. Please find my comments below. > > On 11/10/2015 03:17 AM, Ingi Kim wrote: >> T

[PATCH] leds: ktd2692: Add missing of_node_put

2015-11-09 Thread Ingi Kim
The refcount of device_node increases after of_node_get() is called. So, a break out of the loop requires of_node_put(). This patch adds missing of_node_put() when loop breaks. Signed-off-by: Ingi Kim --- drivers/leds/leds-ktd2692.c | 11 --- 1 file changed, 8 insertions(+), 3

[PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-09 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-rt5033.c | 502

[PATCH v4 0/2] Add RT5033 Flash LED driver

2015-11-09 Thread Ingi Kim
- Fix compile error Ingi Kim (2): leds: rt5033: Add DT binding for RT5033 leds: rt5033: Add RT5033 Flash led device driver .../devicetree/bindings/leds/leds-rt5033.txt | 46 ++ drivers/leds/Kconfig | 8 + drivers/leds/Makefile

[PATCH v4 1/2] leds: rt5033: Add DT binding for RT5033

2015-11-09 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim Acked-by: Rob Herring --- .../devicetree/bindings/leds/leds-rt5033.txt | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds

[PATCH v4 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-11-09 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs. Signed-off-by: Ingi Kim <ingi2@samsung.com> --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-rt

[PATCH v4 1/2] leds: rt5033: Add DT binding for RT5033

2015-11-09 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim <ingi2@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/leds/leds-rt5033.txt | 46 ++ 1 file changed, 46 insertions(+) create

[PATCH v4 0/2] Add RT5033 Flash LED driver

2015-11-09 Thread Ingi Kim
- Fix compile error Ingi Kim (2): leds: rt5033: Add DT binding for RT5033 leds: rt5033: Add RT5033 Flash led device driver .../devicetree/bindings/leds/leds-rt5033.txt | 46 ++ drivers/leds/Kconfig | 8 + drivers/leds/Makefile

[PATCH] leds: ktd2692: Add missing of_node_put

2015-11-09 Thread Ingi Kim
The refcount of device_node increases after of_node_get() is called. So, a break out of the loop requires of_node_put(). This patch adds missing of_node_put() when loop breaks. Signed-off-by: Ingi Kim <ingi2@samsung.com> --- drivers/leds/leds-ktd2692.c | 11 --- 1 file chan

Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

2015-10-27 Thread Ingi Kim
Hi Jacek, Oh, I see. I'll add. Thanks for the review. On 2015년 10월 26일 19:11, Jacek Anaszewski wrote: > Hi Ingi, > > On 10/23/2015 07:48 AM, Ingi Kim wrote: >> This patch adds the device tree bindings for RT5033 flash LEDs. >> >> Signed-off-by: Ingi Ki

Re: [PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

2015-10-27 Thread Ingi Kim
Hi Jacek, Oh, I see. I'll add. Thanks for the review. On 2015년 10월 26일 19:11, Jacek Anaszewski wrote: > Hi Ingi, > > On 10/23/2015 07:48 AM, Ingi Kim wrote: >> This patch adds the device tree bindings for RT5033 flash LEDs. >> >> Signed-off-by: Ingi Kim <ingi2

Re: [PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-26 Thread Ingi Kim
Hi Jacek, Thanks for the review I can make this code better :) On 2015년 10월 26일 19:10, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. I've found a few minor issues, please > refer to my comments below. > > On 10/23/2015 07:48 AM, Ingi Kim wrote: >> This

Re: [PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-26 Thread Ingi Kim
Hi Jacek, Thanks for the review I can make this code better :) On 2015년 10월 26일 19:10, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. I've found a few minor issues, please > refer to my comments below. > > On 10/23/2015 07:48 AM, Ingi Kim wrote: >> This

[PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

2015-10-22 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim Acked-by: Rob Herring --- .../devicetree/bindings/leds/leds-rt5033.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds

[PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-22 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/leds/leds-rt5033.c | 314

[PATCH v3 2/3] mfd: rt5033: Add RT5033 Flash led sub device

2015-10-22 Thread Ingi Kim
This patch adds rt5033-led sub device to support it. Signed-off-by: Ingi Kim Acked-by: Lee Jones --- drivers/mfd/rt5033.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c index d60f916..035421c 100644 --- a/drivers/mfd/rt5033.c +++ b/drivers

[PATCH v3 0/3] Add RT5033 Flash LED driver

2015-10-22 Thread Ingi Kim
led patch - Fix typo error - Change naming of mfd register back again - Fix compile error Ingi Kim (3): leds: rt5033: Add DT binding for RT5033 mfd: rt5033: Add RT5033 Flash led sub device leds: rt5033: Add RT5033 Flash led device driver .../devicetree/bindings/leds/leds-rt5033.txt

[PATCH v3 2/3] mfd: rt5033: Add RT5033 Flash led sub device

2015-10-22 Thread Ingi Kim
This patch adds rt5033-led sub device to support it. Signed-off-by: Ingi Kim <ingi2@samsung.com> Acked-by: Lee Jones <lee.jo...@linaro.org> --- drivers/mfd/rt5033.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c index d60f

[PATCH v3 0/3] Add RT5033 Flash LED driver

2015-10-22 Thread Ingi Kim
led patch - Fix typo error - Change naming of mfd register back again - Fix compile error Ingi Kim (3): leds: rt5033: Add DT binding for RT5033 mfd: rt5033: Add RT5033 Flash led sub device leds: rt5033: Add RT5033 Flash led device driver .../devicetree/bindings/leds/leds-rt5033.txt

[PATCH v3 1/3] leds: rt5033: Add DT binding for RT5033

2015-10-22 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim <ingi2@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/leds/leds-rt5033.txt | 38 ++ 1 file changed, 38 insertions(+) create

[PATCH v3 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-22 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by: Ingi Kim <ingi2@samsung.com> --- drivers/leds/Kconfig | 8 + drivers/leds/Makefile | 1 + drivers/led

[PATCH] leds: aat1290: Fix property naming of flash-timeout-us

2015-10-21 Thread Ingi Kim
flash-timeout-us property name is changed to flash-max-timeout-us. This patch fixes that name Signed-off-by: Ingi Kim --- Documentation/devicetree/bindings/leds/leds-aat1290.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/leds

[PATCH] leds: aat1290: Fix property naming of flash-timeout-us

2015-10-21 Thread Ingi Kim
flash-timeout-us property name is changed to flash-max-timeout-us. This patch fixes that name Signed-off-by: Ingi Kim --- Documentation/devicetree/bindings/leds/leds-aat1290.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/leds

[PATCH] leds: aat1290: Fix property naming of flash-timeout-us

2015-10-21 Thread Ingi Kim
flash-timeout-us property name is changed to flash-max-timeout-us. This patch fixes that name Signed-off-by: Ingi Kim <ingi2@samsung.com> --- Documentation/devicetree/bindings/leds/leds-aat1290.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documen

[PATCH] leds: aat1290: Fix property naming of flash-timeout-us

2015-10-21 Thread Ingi Kim
flash-timeout-us property name is changed to flash-max-timeout-us. This patch fixes that name Signed-off-by: Ingi Kim <ingi2@samsung.com> --- Documentation/devicetree/bindings/leds/leds-aat1290.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Documen

Re: [PATCH v2 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-16 Thread Ingi Kim
Hi Jacek, Sorry I'm late :( I'll send version3 patch soon On 2015년 10월 13일 17:53, Jacek Anaszewski wrote: > Hi Ingi, > > On 10/13/2015 04:58 AM, Ingi Kim wrote: >> Hi Jacek, >> >> Thanks for your kind comments >> I also append reply below >> >> O

Re: [PATCH v2 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-16 Thread Ingi Kim
Hi Jacek, Sorry I'm late :( I'll send version3 patch soon On 2015년 10월 13일 17:53, Jacek Anaszewski wrote: > Hi Ingi, > > On 10/13/2015 04:58 AM, Ingi Kim wrote: >> Hi Jacek, >> >> Thanks for your kind comments >> I also append reply below >> >> O

Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

2015-10-13 Thread Ingi Kim
Hi Lee Jones, Okay, I'm try to remove needless part and resend it Thanks for the review Thank you On 2015년 10월 13일 16:06, Lee Jones wrote: > On Mon, 12 Oct 2015, Ingi Kim wrote: > >> This patch adds rt5033-led sub device to support it. >> >> Signed-off-by: Ingi Kim

Re: [PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

2015-10-13 Thread Ingi Kim
Hi Lee Jones, Okay, I'm try to remove needless part and resend it Thanks for the review Thank you On 2015년 10월 13일 16:06, Lee Jones wrote: > On Mon, 12 Oct 2015, Ingi Kim wrote: > >> This patch adds rt5033-led sub device to support it. >> >> Signed-off-by: Ingi Ki

Re: [PATCH v2 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-12 Thread Ingi Kim
Hi Jacek, Thanks for your kind comments I also append reply below On 2015년 10월 13일 00:10, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. Few comments below. > > On 10/12/2015 03:12 PM, Ingi Kim wrote: >> This patch adds device driver of Richtek RT503

[PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

2015-10-12 Thread Ingi Kim
This patch adds rt5033-led sub device to support it. Signed-off-by: Ingi Kim --- drivers/mfd/rt5033.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c index d60f916..b7f374b 100644 --- a/drivers/mfd/rt5033.c +++ b/drivers/mfd

[PATCH v2 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-12 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig | 8 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-rt5033.c

[PATCH v2 1/3] leds: rt5033: Add DT binding for RT5033

2015-10-12 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim Acked-by: Rob Herring --- .../devicetree/bindings/leds/leds-rt5033.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds

[PATCH v2 0/3] Add RT5033 Flash LED driver

2015-10-12 Thread Ingi Kim
This patch supports flash led of RT5033 PMIC. Changes since v2: - Split MFC code from rt5033 flash led patch - Fix typo error - Change naming of mfd register back again - Fix compile error Ingi Kim (3): leds: rt5033: Add DT binding for RT5033 mfd: rt5033: Add RT5033 Flash led sub device

[PATCH v2 0/3] Add RT5033 Flash LED driver

2015-10-12 Thread Ingi Kim
This patch supports flash led of RT5033 PMIC. Changes since v2: - Split MFC code from rt5033 flash led patch - Fix typo error - Change naming of mfd register back again - Fix compile error Ingi Kim (3): leds: rt5033: Add DT binding for RT5033 mfd: rt5033: Add RT5033 Flash led sub device

[PATCH v2 1/3] leds: rt5033: Add DT binding for RT5033

2015-10-12 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim <ingi2@samsung.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/leds/leds-rt5033.txt | 38 ++ 1 file changed, 38 insertions(+) create

[PATCH v2 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-12 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by: Ingi Kim <ingi2@samsung.com> --- drivers/leds/Kconfig | 8 ++ drivers/leds/Makefile | 1 + driver

[PATCH v2 2/3] mfd: rt5033: Add RT5033 Flash led sub device

2015-10-12 Thread Ingi Kim
This patch adds rt5033-led sub device to support it. Signed-off-by: Ingi Kim <ingi2@samsung.com> --- drivers/mfd/rt5033.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c index d60f916..b7f374b 100644 --- a/drive

Re: [PATCH v2 3/3] leds: rt5033: Add RT5033 Flash led device driver

2015-10-12 Thread Ingi Kim
Hi Jacek, Thanks for your kind comments I also append reply below On 2015년 10월 13일 00:10, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the update. Few comments below. > > On 10/12/2015 03:12 PM, Ingi Kim wrote: >> This patch adds device driver of Richtek RT503

Re: [PATCH 1/2] leds: rt5033: add DT binding for RT5033

2015-10-05 Thread Ingi Kim
Hello, Rob Herring I'll push ver2 patch soon with your acked because other patch has some issues. Thanks for the review. On 2015년 10월 02일 23:31, Rob Herring wrote: > On Fri, Oct 2, 2015 at 4:41 AM, Ingi Kim wrote: >> This patch adds the device tree bindings for RT5033 flash LEDs. >

Re: [PATCH 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-10-05 Thread Ingi Kim
Hello Lee Jones, Thanks for the review. I'll try to divide this patch and change name and comment. Then push ver2 patch soon. On 2015년 10월 05일 16:21, Lee Jones wrote: > On Fri, 02 Oct 2015, Ingi Kim wrote: > >> This patch adds device driver of Richtek RT5033 PMIC. >> T

Re: [PATCH 1/2] leds: rt5033: add DT binding for RT5033

2015-10-05 Thread Ingi Kim
Hello, Rob Herring I'll push ver2 patch soon with your acked because other patch has some issues. Thanks for the review. On 2015년 10월 02일 23:31, Rob Herring wrote: > On Fri, Oct 2, 2015 at 4:41 AM, Ingi Kim <ingi2@samsung.com> wrote: >> This patch adds the device tree bind

Re: [PATCH 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-10-05 Thread Ingi Kim
Hello Lee Jones, Thanks for the review. I'll try to divide this patch and change name and comment. Then push ver2 patch soon. On 2015년 10월 05일 16:21, Lee Jones wrote: > On Fri, 02 Oct 2015, Ingi Kim wrote: > >> This patch adds device driver of Richtek RT5033 PMIC. >> T

Re: [PATCH 0/2] Add RT5033 Flash LED driver

2015-10-04 Thread Ingi Kim
Hi, Jacek Thanks for review my patch Oops! old version patch is sent. I should have checked.. I'll send new patch, soon. Thanks Ingi Kim On 2015년 10월 02일 23:59, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the patches. Please fix build errors > and resubmit. > > On 1

Re: [PATCH 0/2] Add RT5033 Flash LED driver

2015-10-04 Thread Ingi Kim
Hi, Jacek Thanks for review my patch Oops! old version patch is sent. I should have checked.. I'll send new patch, soon. Thanks Ingi Kim On 2015년 10월 02일 23:59, Jacek Anaszewski wrote: > Hi Ingi, > > Thanks for the patches. Please fix build errors > and resubmit. > > On 1

[PATCH 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-10-02 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by: Ingi Kim --- drivers/leds/Kconfig | 8 ++ drivers/leds/Makefile | 1 + drivers/leds/leds-rt5033.c

[PATCH 0/2] Add RT5033 Flash LED driver

2015-10-02 Thread Ingi Kim
This patch adds ktd2692 Flash LED driver with LED Flash class Ingi Kim (2): leds: rt5033: add DT binding for RT5033 leds: rt5033: Add RT5033 Flash led device driver .../devicetree/bindings/leds/leds-rt5033.txt | 38 drivers/leds/Kconfig | 8

[PATCH 1/2] leds: rt5033: add DT binding for RT5033

2015-10-02 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim --- .../devicetree/bindings/leds/leds-rt5033.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-rt5033.txt diff --git

[PATCH] drm/exynos: fix spelling errors

2015-10-02 Thread Ingi Kim
This patch fixes spelling errors in drm fimc/gsc inavild -> invaild Signed-off-by: Ingi Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 16 drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12 ++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/driv

[PATCH 1/2] s5p-mfc: fix spelling errors

2015-10-02 Thread Ingi Kim
This patch fixes spelling errors in mfc encoder. inavild -> invaild Signed-off-by: Ingi Kim --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform/s5p-

[PATCH 1/2] s5p-mfc: fix spelling errors

2015-10-02 Thread Ingi Kim
This patch fixes spelling errors in mfc encoder. inavild -> invaild Signed-off-by: Ingi Kim <ingi2@samsung.com> --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c

[PATCH] drm/exynos: fix spelling errors

2015-10-02 Thread Ingi Kim
This patch fixes spelling errors in drm fimc/gsc inavild -> invaild Signed-off-by: Ingi Kim <ingi2@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_fimc.c | 16 drivers/gpu/drm/exynos/exynos_drm_gsc.c | 12 ++-- 2 files changed, 14 insertions(+), 14

[PATCH 2/2] leds: rt5033: Add RT5033 Flash led device driver

2015-10-02 Thread Ingi Kim
This patch adds device driver of Richtek RT5033 PMIC. The driver supports a current regulated output to drive white LEDs for camera flash. Signed-off-by: Ingi Kim <ingi2@samsung.com> --- drivers/leds/Kconfig | 8 ++ drivers/leds/Makefile | 1 + driver

[PATCH 1/2] leds: rt5033: add DT binding for RT5033

2015-10-02 Thread Ingi Kim
This patch adds the device tree bindings for RT5033 flash LEDs. Signed-off-by: Ingi Kim <ingi2@samsung.com> --- .../devicetree/bindings/leds/leds-rt5033.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/led

[PATCH 0/2] Add RT5033 Flash LED driver

2015-10-02 Thread Ingi Kim
This patch adds ktd2692 Flash LED driver with LED Flash class Ingi Kim (2): leds: rt5033: add DT binding for RT5033 leds: rt5033: Add RT5033 Flash led device driver .../devicetree/bindings/leds/leds-rt5033.txt | 38 drivers/leds/Kconfig | 8

[PATCH v9 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-05-12 Thread Ingi Kim
This patch adds the device tree bindings for ktd2692 flash LEDs. Add Optional properties of child node for Flash LED Signed-off-by: Ingi Kim Acked-by: Seung-Woo Kim Reviewed-by: Varka Bhadram --- .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ++ 1 file changed

[PATCH v9 3/3] leds: Add ktd2692 flash LED driver

2015-05-12 Thread Ingi Kim
This patch adds a driver to support the ktd2692 flash LEDs. ktd2692 can control flash current by ExpressWire interface. Signed-off-by: Ingi Kim Acked-by: Seung-Woo Kim Reviewed-by: Varka Bhadram --- drivers/leds/Kconfig| 9 + drivers/leds/Makefile | 1 + drivers/leds/leds

[PATCH v9 1/3] of: Add vendor prefix for Kinetic technologies

2015-05-12 Thread Ingi Kim
This patch adds vendor prefix for Kinetic technologies Signed-off-by: Ingi Kim Acked-by: Rob Herring Acked-by: Seung-Woo Kim Reviewed-by: Varka Bhadram --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH v9 0/3] Add ktd2692 Flash LED driver using LED Flash class

2015-05-12 Thread Ingi Kim
Flash class as Jacek's comment - Supplement of binding documentation - Rename gpio control pin and remove unused pin - Add regulator for the Flash LED Ingi Kim (3): of: Add vendor prefix for Kinetic technologies leds: ktd2692: add device tree bindings for ktd2692 leds

[PATCH v9 1/3] of: Add vendor prefix for Kinetic technologies

2015-05-12 Thread Ingi Kim
This patch adds vendor prefix for Kinetic technologies Signed-off-by: Ingi Kim ingi2@samsung.com Acked-by: Rob Herring r...@kernel.org Acked-by: Seung-Woo Kim sw0312@samsung.com Reviewed-by: Varka Bhadram varkabhad...@gmail.com --- Documentation/devicetree/bindings/vendor-prefixes.txt

[PATCH v9 0/3] Add ktd2692 Flash LED driver using LED Flash class

2015-05-12 Thread Ingi Kim
Flash class as Jacek's comment - Supplement of binding documentation - Rename gpio control pin and remove unused pin - Add regulator for the Flash LED Ingi Kim (3): of: Add vendor prefix for Kinetic technologies leds: ktd2692: add device tree bindings for ktd2692 leds

[PATCH v9 3/3] leds: Add ktd2692 flash LED driver

2015-05-12 Thread Ingi Kim
This patch adds a driver to support the ktd2692 flash LEDs. ktd2692 can control flash current by ExpressWire interface. Signed-off-by: Ingi Kim ingi2@samsung.com Acked-by: Seung-Woo Kim sw0312@samsung.com Reviewed-by: Varka Bhadram varkabhad...@gmail.com --- drivers/leds/Kconfig

[PATCH v9 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-05-12 Thread Ingi Kim
This patch adds the device tree bindings for ktd2692 flash LEDs. Add Optional properties of child node for Flash LED Signed-off-by: Ingi Kim ingi2@samsung.com Acked-by: Seung-Woo Kim sw0312@samsung.com Reviewed-by: Varka Bhadram varkabhad...@gmail.com --- .../devicetree/bindings/leds

Re: [PATCH v8 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-05-10 Thread Ingi Kim
Hi Jacek, On 2015년 05월 08일 17:33, Jacek Anaszewski wrote: > Hi Ingi, > > On 05/08/2015 05:03 AM, Ingi Kim wrote: >> This patch adds the device tree bindings for ktd2692 flash LEDs. >> Add Optional properties of child node for Flash LED >> >> Signed-off-by: Ing

Re: [PATCH v8 3/3] leds: Add ktd2692 flash LED driver

2015-05-10 Thread Ingi Kim
can see only two minor issues. > > On 05/08/2015 05:03 AM, Ingi Kim wrote: >> This patch adds a driver to support the ktd2692 flash LEDs. >> ktd2692 can control flash current by ExpressWire interface. >> >> Signed-off-by: Ingi Kim >> Acked-by: Seung-Woo Kim &g

Re: [PATCH v8 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-05-10 Thread Ingi Kim
Hi Jacek, On 2015년 05월 08일 17:33, Jacek Anaszewski wrote: Hi Ingi, On 05/08/2015 05:03 AM, Ingi Kim wrote: This patch adds the device tree bindings for ktd2692 flash LEDs. Add Optional properties of child node for Flash LED Signed-off-by: Ingi Kim ingi2@samsung.com Acked-by: Seung

Re: [PATCH v8 3/3] leds: Add ktd2692 flash LED driver

2015-05-10 Thread Ingi Kim
minor issues. On 05/08/2015 05:03 AM, Ingi Kim wrote: This patch adds a driver to support the ktd2692 flash LEDs. ktd2692 can control flash current by ExpressWire interface. Signed-off-by: Ingi Kim ingi2@samsung.com Acked-by: Seung-Woo Kim sw0312@samsung.com Reviewed-by: Varka Bhadram

[PATCH v8 3/3] leds: Add ktd2692 flash LED driver

2015-05-07 Thread Ingi Kim
This patch adds a driver to support the ktd2692 flash LEDs. ktd2692 can control flash current by ExpressWire interface. Signed-off-by: Ingi Kim Acked-by: Seung-Woo Kim Reviewed-by: Varka Bhadram --- drivers/leds/Kconfig| 9 + drivers/leds/Makefile | 1 + drivers/leds/leds

[PATCH v8 1/3] of: Add vendor prefix for Kinetic technologies

2015-05-07 Thread Ingi Kim
This patch adds vendor prefix for Kinetic technologies Signed-off-by: Ingi Kim Acked-by: Rob Herring Acked-by: Seung-Woo Kim Reviewed-by: Varka Bhadram --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree

[PATCH v8 0/3] Add ktd2692 Flash LED driver using LED Flash class

2015-05-07 Thread Ingi Kim
control pin and remove unused pin - Add regulator for the Flash LED Ingi Kim (3): of: Add vendor prefix for Kinetic technologies leds: ktd2692: add device tree bindings for ktd2692 leds: Add ktd2692 flash LED driver .../devicetree/bindings/leds/leds-ktd2692.txt | 50

[PATCH v8 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-05-07 Thread Ingi Kim
This patch adds the device tree bindings for ktd2692 flash LEDs. Add Optional properties of child node for Flash LED Signed-off-by: Ingi Kim Acked-by: Seung-Woo Kim Reviewed-by: Varka Bhadram --- .../devicetree/bindings/leds/leds-ktd2692.txt | 50 ++ 1 file changed

  1   2   >