Re: [PATCH] ipv6: no addrconf for slave devices

2015-10-16 Thread Jan Blunck
On Fri, Oct 16, 2015 at 6:14 PM, David Ahern wrote: > On 10/16/15 10:12 AM, Jan Blunck wrote: >> >> On Fri, Oct 16, 2015 at 6:02 PM, David Ahern >> wrote: >>> >>> On 10/16/15 9:57 AM, Jan Blunck wrote: >>>> >>>> >>>>

Re: [PATCH] ipv6: no addrconf for slave devices

2015-10-16 Thread Jan Blunck
On Fri, Oct 16, 2015 at 6:02 PM, David Ahern wrote: > On 10/16/15 9:57 AM, Jan Blunck wrote: >> >> >> I don't think that enslaved ports should get network layer addresses. >> This is one example with a team device: > > > for VRF devices we do want the en

Re: [PATCH] ipv6: no addrconf for slave devices

2015-10-16 Thread Jan Blunck
ated and a link-local address is added to the slave interface. >> >>This patch alters the behavior so that addrconf will only run on the master >>device itself. This is achieved by checking the device tree instead of >>checking for a specific flag. >> >>Si

[PATCH] ipv6: no addrconf for slave devices

2015-10-16 Thread Jan Blunck
itself. This is achieved by checking the device tree instead of checking for a specific flag. Signed-off-by: Jan Blunck --- net/ipv6/addrconf.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 9001133..26d61f0 100644 --- a/net

Re: [PATCH] team: set IFF_SLAVE on team ports

2015-07-09 Thread Jan Blunck
On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko wrote: > Thu, Jul 09, 2015 at 11:58:34AM CEST, jblu...@infradead.org wrote: >>The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to >>decide if it should start the address configuration. Since team ports >>shouldn't get link-local addr

[PATCH] team: set IFF_SLAVE on team ports

2015-07-09 Thread Jan Blunck
The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to decide if it should start the address configuration. Since team ports shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking a port to the team master. Signed-off-by: Jan Blunck --- drivers/net

Re: [PATCH -mmotm] fs/sysfs/file.c d_path fix

2008-02-18 Thread Jan Blunck
On Sun, Feb 17, Christoph Hellwig wrote: > On Sat, Feb 16, 2008 at 02:12:05PM -0500, Erez Zadok wrote: > > diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c > > index 02223e2..a57b024 100644 > > --- a/fs/sysfs/file.c > > +++ b/fs/sysfs/file.c > > @@ -329,9 +329,11 @@ static int sysfs_open_file(struct

Re: [RFC PATCH 0/5] Union Mount: A Directory listing approach with lseek support

2007-12-06 Thread Jan Blunck
7;t run out of memory while doing a readdir yet ;) The proper way to implement this would be to cache the offsets on a per inode base. Otherwise the user could easily DoS this by opening a number of directories and never close them. Regards, Jan -- Jan Blunck <[EMAIL PROTECTED

Re: 2.6.24-rc2-mm1

2007-11-16 Thread Jan Blunck
exists > > treogen x # mkdir bla > > treogen x # touch bla/bla > > touch: cannot touch `bla/bla': File exists > > treogen x # ls -lad * > > drwxr-xr-x 2 root root 6 Nov 14 20:03 bla > > treogen x # ls -la * > > total 0 > > drwxr-x

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Jan Blunck
On Wed, Nov 14, Torsten Kaiser wrote: > > > So I can create new directories, but not new files. Reading files works > > > normal. > > >> > > > The client is 2.6.24-rc2-mm1, the server 2.6.22-gentoo-r9. > > I added Jan Blunck to the recipents, as he

Re: oops in oprofile/dump_trace/X86 with 2.6.24-rcX

2007-11-09 Thread Jan Blunck
s when I introduced stack_pointer(). Here is a patch that fixes the problem. Thanks, Jan -- Subject: oprofile: Fix oops on x86 32-bit x86 32-bit isn't saving the stack pointer to pt_regs->esp on when an interrupt occures. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- include/asm-x86/p

[PATCH 4/9] d_path: Make proc_get_link() use a struct path argument

2007-11-05 Thread Jan Blunck
proc_get_link() is always called with a dentry and a vfsmount from a struct path. Make proc_get_link() take it directly as an argument. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- fs/proc/base.c

[PATCH 6/9] Use struct path in struct svc_export

2007-11-05 Thread Jan Blunck
I'm embedding struct path into struct svc_export. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: J. Bruce Fields <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- fs/nfsd/export.c| 68 +

[PATCH 2/9] d_path: kerneldoc cleanup

2007-11-05 Thread Jan Blunck
Move and update d_path() kernel API documentation. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- fs/dcache.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) Index: b

[PATCH 8/9] d_path: Make seq_path() use a struct path argument

2007-11-05 Thread Jan Blunck
seq_path() is always called with a dentry and a vfsmount from a struct path. Make seq_path() take it directly as an argument. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- drivers/md/md.c |3 +-- fs/namespace.c |6 -- fs/nfsd/export.c |4 ++

[PATCH 0/9] struct path related cleanups of d_path() code (V2)

2007-11-05 Thread Jan Blunck
Andrew, please apply this series to -mm. I just added the seq_file patch, another nfsd cleanup and changed the patch order. This patch series changes d_path() to take a struct path argument. The existing users are changed to give struct path more deeply into the call chain. In some cases I replac

[PATCH 3/9] d_path: Use struct path in struct avc_audit_data

2007-11-05 Thread Jan Blunck
audit_log_d_path() is a d_path() wrapper that is used by the audit code. To use a struct path in audit_log_d_path() I need to embed it into struct avc_audit_data. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- include/l

[PATCH 9/9] d_path: Make d_path() use a struct path

2007-11-05 Thread Jan Blunck
d_path() is used on a pair. Lets use a struct path to reflect this. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Bryan Wu <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- arch/blackfin/kernel/traps.c | 12 +--- d

[PATCH 5/9] d_path: Make get_dcookie() use a struct path argument

2007-11-05 Thread Jan Blunck
get_dcookie() is always called with a dentry and a vfsmount from a struct path. Make get_dcookie() take it directly as an argument. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- arch/powerpc/oprofile/cell/spu_task_s

[PATCH 1/9] One less parameter to __d_path

2007-11-05 Thread Jan Blunck
All callers to __d_path pass the dentry and vfsmount of a struct path to __d_path. Pass the struct path directly, instead. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> ---

[PATCH 7/9] Use struct path in struct svc_expkey

2007-11-05 Thread Jan Blunck
I'm embedding struct path into struct svc_expkey. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/nfsd/export.c| 30 +- include/linux/nfsd/export.h |3 +-- 2 files changed, 14 insertions(+), 19 deletions(-) Index: b/fs/nf

[PATCH 6/7] d_path: Make d_path() use a struct path (2nd try)

2007-11-02 Thread Jan Blunck
d_path() is used on a pair. Lets use a struct path to reflect this. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- arch/blackfin/kernel/traps.c | 12 +--- drivers/md/bitmap.c |8 +--- drivers/usb/gadget/file_storage.c |8 +++- fs/compat_i

Re: [PATCH 6/7] d_path: Make d_path() use a struct path

2007-11-02 Thread Jan Blunck
On Fri, Nov 02, Bharata B Rao wrote: > > Did you miss the d_path() caller > arch/blackfin/kernel/traps.c:printk_address() ? > Sorry, yes I missed that one. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

[PATCH 3/7] d_path: Use struct path in struct avc_audit_data

2007-11-01 Thread Jan Blunck
audit_log_d_path() is a d_path() wrapper that is used by the audit code. To use a struct path in audit_log_d_path() I need to embed it into struct avc_audit_data. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- include/linux/audit.h |5 ++--- kernel/audit.c

[PATCH 7/7] Use struct path in struct svc_export

2007-11-01 Thread Jan Blunck
I'm embedding struct path into struct svc_export. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/nfsd/export.c| 69 +--- fs/nfsd/nfs3proc.c |2 - fs/nfsd/nfs3xdr.c |4 +- fs/nfsd/nfs4proc.c

[PATCH 6/7] d_path: Make d_path() use a struct path

2007-11-01 Thread Jan Blunck
d_path() is used on a pair. Lets use a struct path to reflect this. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- drivers/md/bitmap.c |8 +--- drivers/usb/gadget/file_storage.c |3 +-- fs/compat_ioctl.c |2 +- fs/dc

[PATCH 5/7] d_path: Make get_dcookie() use a struct path argument

2007-11-01 Thread Jan Blunck
get_dcookie() is always called with a dentry and a vfsmount from a struct path. Make get_dcookie() take it directly as an argument. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- arch/powerpc/oprofile/cell/spu_task_sync.c | 15 +- drivers/oprofile/buffer_

[PATCH 4/7] d_path: Make proc_get_link() use a struct path argument

2007-11-01 Thread Jan Blunck
proc_get_link() is always called with a dentry and a vfsmount from a struct path. Make proc_get_link() take it directly as an argument. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/proc/base.c | 60 fs/proc/inte

[PATCH 0/7] struct path related cleanups of d_path() code

2007-11-01 Thread Jan Blunck
Here are some more struct path cleanups. This patch series changes d_path() to take a struct path argument. The existing users are changed to give struct path more deeply into the call chain. In some structures I need to replace existing pairs and embed a struct path instead. Andreas, since JJ j

[PATCH 2/7] d_path: kerneldoc cleanup

2007-11-01 Thread Jan Blunck
Move and update d_path() kernel API documentation. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/dcache.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) Index: b/fs/dc

[PATCH 1/7] One less parameter to __d_path

2007-11-01 Thread Jan Blunck
All callers to __d_path pass the dentry and vfsmount of a struct path to __d_path. Pass the struct path directly, instead. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/dcache.c | 12 +--- 1 file changed, 5 inse

Re: [PATCH 00/13] Use struct path in struct nameidata

2007-10-23 Thread Jan Blunck
On Tue, Oct 23, Bharata B Rao wrote: > On Mon, Oct 22, 2007 at 03:57:58PM +0200, Christoph Hellwig wrote: > > > > Any reason we've got this patchset posted by three people now? :) > > Two reasons actually ! > > - The set of patches posted by Jan last was on 2.6.23-rc8-mm1. So I > thought let me

Re: [PATCH 00/13] Use struct path in struct nameidata

2007-10-23 Thread Jan Blunck
On Mon, Oct 22, Andrew Morton wrote: > On Mon, 22 Oct 2007 15:57:58 +0200 > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > > Any reason we've got this patchset posted by three people now? :) > > presumably because I haven't been merging it. > > I was in bugfix-only mode from a week prior

[RFC 1/2] i_op->readdir: Change readdir() to be an inode operation

2007-10-20 Thread Jan Blunck
entry: the dentry of the directory @pos: pointer to the cookie @private: the credentials (at the moment it is still filp->private_data @filler: the filldir to call @dirent: the dirent buffer Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/readdir.c | 14 -- includ

[RFC 2/2] i_op->readdir: Change libfs users to the new interface

2007-10-20 Thread Jan Blunck
This patch changes dcache_readdir() to the new inode operations readdir interface. Hence all the users of libfs.c are changed to use the new interface too. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/autofs4/autofs_i.h |5 ++--- fs/autofs4/root.c

[RFC 0/2] readdir() as an inode operation

2007-10-20 Thread Jan Blunck
This is a first try to move readdir() to become an inode operation. This is necessary for a VFS implementation of "something like union-mounts" where a readdir() needs to read the directory contents of multiple directories. Besides that the new interface is no longer giving the struct file to the f

[patch 2/2] r/o bind mounts: Accept passing a mnt NULL pointer to mnt_drop_write()

2007-10-12 Thread Jan Blunck
In case of somebody opens a file with dentry_open(dentry, NULL, ...) we don't want to stumble on the NULL pointer mnt in struct file. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namespace.c |3 +++ 1 file changed, 3 insertions(+) Index: b/fs/

[patch 0/2] r/o bind mount fixes for 2.6.23-mm1

2007-10-12 Thread Jan Blunck
Here are two small patches for 2.6.23-mm1 that fix some issues with the r/o bind mount code. Besides that, I can see that you handle files opened by dentry_open() somewhere. Nevertheless this files are also fput'ed later. Regards, Jan -- - To unsubscribe from this list: send the line "unsubscri

[patch 1/2] r/o bind mounts: Dont touch the vfsmount after path_put()

2007-10-12 Thread Jan Blunck
mnt_drop_write() is called after releasing the reference to the path with path_put(). Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- net/unix/af_unix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/net/unix/af_

[PATCH] VFS: Remove lives_below_in_same_fs()

2007-10-12 Thread Jan Blunck
This is another cleanup which removes lives_below_in_same_fs() since is_subdir() from fs/dcache.c is providing the same functionality and is more widespreadly used. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namespace.c | 13 + 1 file changed, 1 insertion(+), 12 del

Re: kernel NULL pointer dereference in check_spread+0x0/0x26

2007-10-12 Thread Jan Blunck
On Fri, Oct 12, Frederik Deweerdt wrote: > On Fri, Oct 12, 2007 at 02:40:54PM +0200, Jan Blunck wrote: > > This is with 2.6.23-mm1 and allmodconfig. > This generates a .config with CONFIG_SCHED_DEBUG=y and > CONFIG_FAIR_GROUP_SCHED=n (The latter causes parent_entity to return

kernel NULL pointer dereference in check_spread+0x0/0x26

2007-10-12 Thread Jan Blunck
This is with 2.6.23-mm1 and allmodconfig. Seems that se in the following is a NULL pointer. 453 static void check_spread(struct cfs_rq *cfs_rq, struct sched_entity *se) 454 { 455 #ifdef CONFIG_SCHED_DEBUG 456 s64 d = se->vruntime - cfs_rq->min_vruntime; 457 458

[patch 09/10] Use struct path in fs_struct

2007-10-09 Thread Jan Blunck
* Use struct path in fs_struct. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- fs/dcache.c | 34 --- fs/namei.c

[patch 10/10] Make set_fs_{root,pwd} take a struct path

2007-10-09 Thread Jan Blunck
In nearly all cases the set_fs_{root,pwd}() calls work on a struct path. Change the function to reflect this and use path_get() here. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROT

[patch 06/10] Introduce path_put()

2007-10-09 Thread Jan Blunck
* Add path_put() functions for releasing a reference to the dentry and vfsmount of a struct path in the right order * Switch from path_release(nd) to path_put(&nd->path) * Rename dput_path() to path_put_conditional() Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-of

[patch 01/10] Dont touch fs_struct in drivers

2007-10-09 Thread Jan Blunck
The sound drivers and the pnpbios core test for current->root != NULL. This test seems to be unnecessary since we always have rootfs mounted before initializing the drivers. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- driv

[patch 07/10] Use path_put() in a few places instead of {mnt,d}put()

2007-10-09 Thread Jan Blunck
Use path_put() in a few places instead of {mnt,d}put() Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- fs/afs/mntpt.c |3 +-- fs/namei.c | 15 +--

[patch 04/10] Move struct path into its own header

2007-10-09 Thread Jan Blunck
Move the definition of struct path into its own header file for further patches. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- include/linux/namei.h |6 +- in

[patch 02/10] Dont touch fs_struct in usermodehelper

2007-10-09 Thread Jan Blunck
This test seems to be unnecessary since we always have rootfs mounted before calling a usermodehelper. Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> Acked-by: Greg KH

[patch 00/10] Use struct path in struct nameidata

2007-10-09 Thread Jan Blunck
This is a respin for inclusion into -mm of the patch series I send on 27th September. I haven't changed the patches except for letting them apply on 2.6.23-rc8-mm1. Andrew, please add this to -mm. Thanks, Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

[patch 03/10] Remove path_release_on_umount()

2007-10-09 Thread Jan Blunck
path_release_on_umount() should only be called from sys_umount(). I merged the function into sys_umount() instead of having in in namei.c. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROTECTED]> --- fs/namei.c| 10 -- fs

[patch 08/10] Introduce path_get()

2007-10-09 Thread Jan Blunck
This introduces the symmetric function to path_put() for getting a reference to the dentry and vfsmount of a struct path in the right order. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Andreas Gruenbacher <[EMAIL PROTECTED]> Acked-by: Christoph Hellwig <[EMAIL PROT

Re: [patch] Combine path_put and path_put_conditional

2007-09-29 Thread Jan Blunck
On Fri, Sep 28, Andreas Gruenbacher wrote: > The name path_put_conditional (formerly, dput_path) is a little unclear. > Replace (path_put_conditional + path_put) with path_walk_put_both, > "put a pair of paths after a path_walk" (see the kerneldoc). Hmm, I don't know. To put both the nd and path

Re: Testing the Current Upstream Kernel

2007-08-15 Thread Jan Blunck
On Wed, 15 Aug 2007 13:14:04 +0200, Sam Ravnborg wrote: > On Wed, Aug 15, 2007 at 01:08:51PM +0200, Jan Blunck wrote: >> (besides those we need for building a RPM). > > Are these openSUSE specific or something we ought to apply to mainline? > If there are patches (at the mom

Testing the Current Upstream Kernel

2007-08-15 Thread Jan Blunck
h the RPMs itself or have general questions about the Kernel:Vanilla project use the [EMAIL PROTECTED] mailing list. Andreas Jaeger <[EMAIL PROTECTED]> and Jan Blunck <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [dm-devel] [patch 01/11] dm-snap: Replace special round_down()

2007-08-13 Thread Jan Blunck
On Fri, Aug 10, Jan Blunck wrote: > This patch removes the special round_down() to next power of 2 implementation > used only at one place in the snapshot target. It is replaced by an equivalent > 1 << fls() which might use an architecture specific implementation. Err, ok this is

Re: [patch 03/11] dm-snap: Remove dead queued_bios code

2007-08-13 Thread Jan Blunck
On Fri, Aug 10, Alasdair G Kergon wrote: > On Fri, Aug 10, 2007 at 10:02:07PM +0200, Jan Blunck wrote: > > This patch removes the unused queued_bios handling code. > > Well I'm going to leave this in for now (as one existing unfinished > patch series does build upon i

Re: [patch 05/11] dm-snap: remove SECTOR_SHIFT define

2007-08-13 Thread Jan Blunck
On Fri, Aug 10, Alasdair G Kergon wrote: > On Fri, Aug 10, 2007 at 10:02:09PM +0200, Jan Blunck wrote: > > Sector size on Linux is always 512 bytes. Don't even try to give the > > impression this is changeable. > > If that's what worries you, add a comment ne

Re: [patch 01/11] dm-snap: Replace special round_down()

2007-08-12 Thread Jan Blunck
On Fri, 10 Aug 2007 22:02:05 +0200, Jan Blunck wrote: > This patch removes the special round_down() to next power of 2 implementation > used only at one place in the snapshot target. It is replaced by an equivalent > 1 << fls() which might use an architecture specific implementati

Re: [PATCH 1/2] oprofile: Make callgraph use dump_trace() on i386/x86_64

2007-08-10 Thread Jan Blunck
On Fri, Aug 10, Andi Kleen wrote: > On Friday 10 August 2007 15:35:29 [EMAIL PROTECTED] wrote: > > This patch improves oprofile callgraphs for i386/x86_64. The old backtracing > > code was unable to produce even kernel backtraces if the kernel wasn't > > compiled with framepointers. The code now u

Re: [RFC 12/26] ext2 white-out support

2007-08-02 Thread Jan Blunck
On Thu, Aug 02, Ph. Marek wrote: > On Mittwoch, 1. August 2007, Josef Sipek wrote: > > Alright not the greatest of examples, there is something to be said about > > symmetry, so...let me try again :) > ... > > Oops! There's a whiteout in /b that hides the directory in /c -- rename(2) > > shouldn't

Re: [RFC 12/26] ext2 white-out support

2007-08-02 Thread Jan Blunck
On Wed, Aug 01, Erez Zadok wrote: > There are three other reasons why Unionfs and our users like to have > multiple writable branches: > ... >And yes, it does make our implementation more complex. And error-prone and unflexible wrt to changes. When XIP was introduced, unionfs crashed all o

Re: [RFC 12/26] ext2 white-out support

2007-08-02 Thread Jan Blunck
On Wed, Aug 01, Josef Sipek wrote: > This brings up an very interesting (but painful) question...which makes more > sense? Allowing the modifications in only the top-most branch, or any branch > (given the user allows it at mount-time)? My implementation is keeping things simple because of reason

Re: [RFC 12/26] ext2 white-out support

2007-08-02 Thread Jan Blunck
On Tue, Jul 31, Josef Sipek wrote: > > So you think that just because you mounted the filesystem somewhere else it > > should look different? This is what sharing is all about. If you share a > > filesystem you also share the removal of objects. > > The removal happens at the union level, not the

Re: [RFC 00/26] VFS based Union Mount (V2)

2007-08-02 Thread Jan Blunck
On Thu, Aug 02, Bharata B Rao wrote: > On Mon, Jul 30, 2007 at 06:13:23PM +0200, Jan Blunck wrote: > > Here is another post of the VFS based union mount implementation. Unlike the > > traditional mount which hides the contents of the mount point, union mounts > > present t

Re: [RFC 12/26] ext2 white-out support

2007-07-31 Thread Jan Blunck
On Tue, Jul 31, Josef Sipek wrote: > On Mon, Jul 30, 2007 at 06:13:35PM +0200, Jan Blunck wrote: > > Introduce white-out support to ext2. > > I think storing whiteouts on the branches is wrong. It creates all sort of > nasty cases when people actually try to use unioning

Re: [RFC 12/26] ext2 white-out support

2007-07-31 Thread Jan Blunck
On Tue, Jul 31, Andreas Dilger wrote: > On Jul 31, 2007 09:44 +0200, Jan Blunck wrote: > > Ok, this is pretty similar to the way I implemented this for tmpfs. The > > problem is that the union mount code is explicitly checking if the > > filesystem > > is supportin

Re: [RFC 12/26] ext2 white-out support

2007-07-31 Thread Jan Blunck
On Mon, Jul 30, Theodore Tso wrote: > On Mon, Jul 30, 2007 at 06:13:35PM +0200, Jan Blunck wrote: > > Introduce white-out support to ext2. > > > > Known Bugs: > > - Needs a reserved inode number for white-outs > > You picked different reserved inodes for the ext

[RFC 00/26] VFS based Union Mount (V2)

2007-07-30 Thread Jan Blunck
Here is another post of the VFS based union mount implementation. Unlike the traditional mount which hides the contents of the mount point, union mounts present the merged view of the mount point and the mounted filesytem. Recent changes: - brand new union structure no longer tied to the dentryn,

[RFC 08/26] VFS: Export lives_below_in_same_fs()

2007-07-30 Thread Jan Blunck
Export lives_below_in_same_fs() for use in union mount code. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namespace.c|3 ++- include/linux/mount.h |1 + 2 files changed, 3 insertions(+), 1 deletion(-) --- a/fs/namespace.c +++ b/fs/namespace.c @@ -793,7 +793,7 @@

[RFC 22/26] union-mount: white-out changes for copy-on-open

2007-07-30 Thread Jan Blunck
When files on an upper layer of the union stack are removed we need to white-out the removed filename. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namei.c | 46 -- 1 file changed, 44 insertions(+), 2 deletions(-) --- a/fs/namei.c ++

[RFC 26/26] union-mount: Debug code

2007-07-30 Thread Jan Blunck
Some debugging code itself. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namei.c| 26 ++ fs/union.c| 27 +++ include/linux/namei.h |4 3 files changed, 57 insertions(+) --- a/fs/namei.c +++ b/fs/n

[RFC 07/26] VFS: Introduce dput() variante that maintains a kill-list

2007-07-30 Thread Jan Blunck
l dentries __d_kill_final() is called. __d_kill_final() is actually doing the dentry_iput() and is also dereferencing the parent. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/dcache.c | 60 +++- 1 file changed, 55 insertions(+), 5 del

[RFC 12/26] ext2 white-out support

2007-07-30 Thread Jan Blunck
Introduce white-out support to ext2. Known Bugs: - Needs a reserved inode number for white-outs - S_OPAQUE isn't persistently stored Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/ext2/dir.c |2 ++ fs/ext2/namei.c | 18 ++ fs/e

[RFC 03/26] VFS: Make lookup_hash() return a struct path

2007-07-30 Thread Jan Blunck
This patch changes lookup_hash() into returning a struct path. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namei.c | 113 ++--- 1 file changed, 57 insertions(+), 56 deletions(-) --- a/fs/namei.c +++ b/fs/namei.c @@ -1

[RFC 13/26] ext3 whiteout support

2007-07-30 Thread Jan Blunck
Introduce whiteout support for ext3. - Needs a reserved inode number for white-outs - S_OPAQUE isn't persistently stored Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/ext3/dir.c |3 ++- fs/ext3/namei.c | 33 + fs/e

[RFC 23/26] union-mount: copyup on rename

2007-07-30 Thread Jan Blunck
Add copyup renaming of regular files on union mounts. Directories are still lazyly copied with the help of user-space. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namei.c | 133 - fs/union.c |8 ++- 2 files change

[RFC 04/26] VFS: Make lookup_create() return a struct path

2007-07-30 Thread Jan Blunck
This patch changes lookup_create() into returning a struct path. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- arch/powerpc/platforms/cell/spufs/inode.c | 15 ++ fs/namei.c| 75 +- include/linux/dc

[RFC 11/26] tmpfs white-out support

2007-07-30 Thread Jan Blunck
Introduce white-out support to tmpfs. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- include/linux/shmem_fs.h |1 mm/shmem.c | 54 +++ 2 files changed, 55 insertions(+) --- a/include/linux/shmem_fs.h +++ b/include

[RFC 06/26] VFS: Make real_lookup() return a struct path

2007-07-30 Thread Jan Blunck
This patch changes real_lookup() into returning a struct path. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namei.c | 77 ++--- 1 file changed, 48 insertions(+), 29 deletions(-) --- a/fs/namei.c +++ b/fs/namei.c @@ -

[RFC 24/26] union-mount: dont report EROFS for union mounts

2007-07-30 Thread Jan Blunck
SuS v2 requires we report a read only fs too. For union-mounts this is a very expensive check. So I'm lazy and just disable the check if we are on a lower layer of an union. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/open.c |2 +- 1 file changed, 1 insertion(+),

[RFC 25/26] union-mount: Debug Infrastructure

2007-07-30 Thread Jan Blunck
are different levels of debugging output available which can be ORed together. For the valid sysctl values see include/linux/union_debug.h. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- include/linux/union_debug.h | 91 ++ lib/Kconfig.debug |9 + lib

[RFC 14/26] union-mount: Documentation

2007-07-30 Thread Jan Blunck
Add simple documentation about union mounting in general and this implementation in specific. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- Documentation/filesystems/union-mounts.txt | 172 + 1 file changed, 172 insertions(+) --- /dev/null +++ b/Documen

[RFC 21/26] union-mount: in-kernel file copy between union mounted filesystems

2007-07-30 Thread Jan Blunck
-off-by: Bharata B Rao <[EMAIL PROTECTED]> Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namei.c| 73 ++- fs/union.c| 312 ++ include/linux/union.h |9 + 3 files changed, 389 insertions(+),

[RFC 19/26] union-mount: Make lookup work for union-mounted file systems

2007-07-30 Thread Jan Blunck
, follow union, follow symlinks - single pathname component, doesn't follow mounts, follow union, doesn't follow symlinks - single pathname component doesn't follow mounts, doesn't follow unions, doesn't follow symlinks Signed-off-by: Jan Blunck <[EMAIL

[RFC 15/26] union-mount: Add union-mount mount flag

2007-07-30 Thread Jan Blunck
Introduce MNT_UNION and MS_UNION flags. You need additional patches for util-linux for that to work. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namespace.c|6 +- include/linux/fs.h|1 + include/linux/mount.h |1 + 3 files changed, 7 insertions(+), 1 de

[RFC 18/26] union-mount: Changes to the namespace handling

2007-07-30 Thread Jan Blunck
Creates the proper struct union_mount when mounting something into a union. If the topmost filesystem isn't capable of handling the white-out filetype it could only be mount read-only. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namespace.c

[RFC 16/26] union-mount: Introduce union_mount structure

2007-07-30 Thread Jan Blunck
e the union stack when de/referencing a dentry - caching of union stack information still driven by dentry cache Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/Kconfig |8 + fs/Makefile|2 fs/dcache.c|4 fs/union.c

[RFC 20/26] union-mount: Simple union-mount readdir implementation

2007-07-30 Thread Jan Blunck
nd newly read entires are compared against these for duplicates before being they are returned to user space. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> Signed-off-by: Bharata B Rao <[EMAIL PROTECTED]> --- fs/readdir.c | 11 - fs/union

[RFC 17/26] union-mount: Drive the union cache via dcache

2007-07-30 Thread Jan Blunck
If a dentry is removed from dentry cache because its usage count drops to zero, the references to the underlying layer of the unions the dentry is in are droped too. Therefore the union cache is driven by the dentry cache. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/dc

[RFC 09/26] linux/stat.h: Add the filetype white-out

2007-07-30 Thread Jan Blunck
A white-out stops the VFS from further lookups of the white-out's name and returns -ENOENT. This is the same behaviour as if the filename isn't found. This can be used in combination with union mounts to virtually delete (white-out) files by creating a file of this file type. Signed-o

[RFC 10/26] VFS white-out handling

2007-07-30 Thread Jan Blunck
Introduce white-out handling in the VFS. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/inode.c | 22 ++ fs/namei.c | 417 +++-- fs/readdir.c |6 include/linux/fs.h |7 4 files changed, 441 insertions(

[RFC 01/26] [PATCH 14/18] shmem: convert to using splice instead of sendfile()

2007-07-30 Thread Jan Blunck
From: Hugh Dickins <[EMAIL PROTECTED]> Remove shmem_file_sendfile and resurrect shmem_readpage, as used by tmpfs to support loop and sendfile in 2.4 and 2.5. Now tmpfs can support splice, loop and sendfile in the simplest way, using generic_file_splice_read and generic_file_splice_write (with the

[RFC 05/26] VFS: cache_lookup() cleanup

2007-07-30 Thread Jan Blunck
cache_lookup() can directly use d_lookup() instead of calling __d_lookup() first since rename_lock is a seq_lock. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namei.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) --- a/fs/namei.c +++ b/fs/namei.c @@ -

[RFC 02/26] VFS: Export dput_path() and path_to_nameidata()

2007-07-30 Thread Jan Blunck
This patch makes dput_path() and path_to_nameidata() general available. Signed-off-by: Jan Blunck <[EMAIL PROTECTED]> --- fs/namei.c| 16 include/linux/namei.h | 15 +++ 2 files changed, 15 insertions(+), 16 deletions(-) --- a/fs/namei.c ++

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-20 Thread Jan Blunck
On Tue, 19 Jun 2007 22:59:51 -0700, Arjan van de Ven wrote: > user does on FS A: > mkdir /mnt/A/somedir > touch /mnt/A/somedir/somefile > > and then 2 things happen in parallel > 1) touch /mnt/B/somefile > 2) mv /mnt/union/somedir /mnt/union/somefile > > since the underlying FS for 2) is FS A.

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-20 Thread Jan Blunck
On Wed, 20 Jun 2007 13:32:23 +0100, Christoph Hellwig wrote: > On Wed, Jun 20, 2007 at 07:29:55AM +0000, Jan Blunck wrote: >> Mounting a file system twice is bad in the first place. This should be >> done by using bind mounts and bind a mounted file system into a union. >>

Re: [RFC PATCH 1/4] Union mount documentation.

2007-06-20 Thread Jan Blunck
On Wed, 20 Jun 2007 11:21:57 +0530, Bharata B Rao wrote: > +4. Union stack: building and traversal > +-- +Union stack needs to be built > from two places: during an explicit union +mount (or mount propagation) > and during the lookup of a directory that +appears

Re: [RFC PATCH 3/4] Lookup changes to support union mount.

2007-06-20 Thread Jan Blunck
On Wed, 20 Jun 2007 11:23:26 +0530, Bharata B Rao wrote: > +/* > + * Looks for the given @name in dcache by walking through all the layers > + * of the union stack, starting from the top. > + * FIXME: If we don't find the dentry in a upper layer, we descend to the > + * next layer. So there is a c

Re: [RFC PATCH 2/4] Mount changes to support union mount.

2007-06-20 Thread Jan Blunck
On Wed, 20 Jun 2007 11:22:41 +0530, Bharata B Rao wrote: > +/* > + * When propagating mount events to peer group, this is called under > + * vfsmount_lock. Hence using GFP_ATOMIC for kmalloc here. > + * TODO: Can we use a separate kmem cache for union_mount ? > + */ > +struct union_mount *alloc_un

  1   2   >