Re: Merging of completely unreviewed drivers

2008-02-23 Thread Jan Engelhardt
On Feb 21 2008 22:37, Ray Lee wrote: >On Thu, Feb 21, 2008 at 7:13 PM, Linus Torvalds ><[EMAIL PROTECTED]> wrote: >> So I'd be happier with warnings about deep indentation (but how do you >> count it? Will people then try to fake things out by using 4-space indents >> and then "deep"

Re: Merging of completely unreviewed drivers

2008-02-23 Thread Jan Engelhardt
On Feb 21 2008 22:37, Ray Lee wrote: On Thu, Feb 21, 2008 at 7:13 PM, Linus Torvalds [EMAIL PROTECTED] wrote: So I'd be happier with warnings about deep indentation (but how do you count it? Will people then try to fake things out by using 4-space indents and then deep indentations will look

Re: Question about your git habits

2008-02-22 Thread Jan Engelhardt
On Feb 22 2008 18:37, Chase Venters wrote: > >I've been making myself more familiar with git lately and I'm curious what >habits others have adopted. (I know there are a few documents in circulation >that deal with using git to work on the kernel but I don't think this has >been specifically

Re: Question about your git habits

2008-02-22 Thread Jan Engelhardt
On Feb 22 2008 18:37, Chase Venters wrote: I've been making myself more familiar with git lately and I'm curious what habits others have adopted. (I know there are a few documents in circulation that deal with using git to work on the kernel but I don't think this has been specifically

Re: Xtables, Xtables-addons 1.5.1

2008-02-21 Thread Jan Engelhardt
On Feb 21 2008 20:49, Patrick McHardy wrote: > Jan Engelhardt wrote: >> I have released “Xtables” 1.5.1, which is a package of my ongoing >> iptables development¹ that I did lately. Patrick McHardy was not >> available last week to merge patches due to higher powers,

[announce] Xtables, Xtables-addons 1.5.1 and Writing Xtables Modules

2008-02-21 Thread Jan Engelhardt
Hello everyone, I have released “Xtables” 1.5.1, which is a package of my ongoing iptables development¹ that I did lately. Patrick McHardy was not available last week to merge patches due to higher powers, so I branched off the iptables subversion trunk into git since quilting on top of svn was

[announce] Xtables, Xtables-addons 1.5.1 and Writing Xtables Modules

2008-02-21 Thread Jan Engelhardt
Hello everyone, I have released “Xtables” 1.5.1, which is a package of my ongoing iptables development¹ that I did lately. Patrick McHardy was not available last week to merge patches due to higher powers, so I branched off the iptables subversion trunk into git since quilting on top of svn was

Re: Xtables, Xtables-addons 1.5.1

2008-02-21 Thread Jan Engelhardt
On Feb 21 2008 20:49, Patrick McHardy wrote: Jan Engelhardt wrote: I have released “Xtables” 1.5.1, which is a package of my ongoing iptables development¹ that I did lately. Patrick McHardy was not available last week to merge patches due to higher powers, so I branched off the iptables

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 18:19, Pavel Machek wrote: >> >> For ordinary desktop people, memory controller is what developers >> know as MMU or sometimes even some other mysterious piece of silicon >> inside the heavy box. > >Actually I'd guess 'memory controller' == 'DRAM controller' == part of

Re: very poor ext3 write performance on big filesystems?

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 09:44, David Rees wrote: >On Wed, Feb 20, 2008 at 2:57 AM, Jan Engelhardt <[EMAIL PROTECTED]> wrote: >> But GNU tar does not handle acls and xattrs. So back to rsync/cp/mv. > >Huh? The version of tar on my Fedora 8 desktop (tar-1.17-7) does. Just >add th

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 17:27, Patrick McHardy wrote: >> Striking. How can this even happen? A callsite which calls >> >> dev_alloc_skb(n) >> >> is just equivalent to >> >> __dev_alloc_skb(n, GFP_ATOMIC); >> >> which means there's like 4 (or 8 if it's long) bytes more on the >> stack. For a worst

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 15:47, Ilpo Järvinen wrote: > >-23668 392 funcs, 104 +, 23772 -, diff: -23668 --- dev_alloc_skb > >-static inline struct sk_buff *dev_alloc_skb(unsigned int length) >-{ >- return __dev_alloc_skb(length, GFP_ATOMIC); >-} >+extern struct sk_buff *dev_alloc_skb(unsigned int

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 20:50, Balbir Singh wrote: >John Stoffel wrote: >> I know this is a pedantic comment, but why the heck is it called such >> a generic term as "Memory Controller" which doesn't give any >> indication of what it does. >> >> Shouldn't it be something like "Memory Quota Controller",

Re: very poor ext3 write performance on big filesystems?

2008-02-20 Thread Jan Engelhardt
On Feb 18 2008 10:35, Theodore Tso wrote: >On Mon, Feb 18, 2008 at 04:57:25PM +0100, Andi Kleen wrote: >> > Use cp >> > or a tar pipeline to move the files. >> >> Are you sure cp handles hardlinks correctly? I know tar does, >> but I have my doubts about cp. > >I *think* GNU cp does the right

Re: vfat32 Free Cluster Count Update

2008-02-20 Thread Jan Engelhardt
On Feb 19 2008 19:23, OGAWA Hirofumi wrote: > >This problem was introduced by it ignores a free cluster count (not >"usefree"). If we was not using "usefree" option, FAT doesn't trust the >"free cluster count" anymore. > >So, it doesn't update until re-count. Um.. yes, it's a bit >problem. Ah..

Re: adapter, what's in a name

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 10:38, Stefan Richter wrote: >Karl Dahlke wrote: >> The longer I stay on this list, the more I will learn. >> But it's high volume, so I may not be able to stay for long. > >Because of the high volume at this list, it is essential that > - you keep everyone who posted in a tread

Re: adapter, what's in a name

2008-02-20 Thread Jan Engelhardt
On Feb 19 2008 18:16, Karl Dahlke wrote: > >I completely understand your point about the word adapter. >It is highly overloaded, to the point that it is almost meaningless. >How about "accessibility"? >Drivers and modules designed to make linux more accessible >could be placed in

Re: adapter, what's in a name

2008-02-20 Thread Jan Engelhardt
On Feb 19 2008 18:16, Karl Dahlke wrote: I completely understand your point about the word adapter. It is highly overloaded, to the point that it is almost meaningless. How about accessibility? Drivers and modules designed to make linux more accessible could be placed in drivers/accessibility in

Re: vfat32 Free Cluster Count Update

2008-02-20 Thread Jan Engelhardt
On Feb 19 2008 19:23, OGAWA Hirofumi wrote: This problem was introduced by it ignores a free cluster count (not usefree). If we was not using usefree option, FAT doesn't trust the free cluster count anymore. So, it doesn't update until re-count. Um.. yes, it's a bit problem. Ah.. it can fix we

Re: very poor ext3 write performance on big filesystems?

2008-02-20 Thread Jan Engelhardt
On Feb 18 2008 10:35, Theodore Tso wrote: On Mon, Feb 18, 2008 at 04:57:25PM +0100, Andi Kleen wrote: Use cp or a tar pipeline to move the files. Are you sure cp handles hardlinks correctly? I know tar does, but I have my doubts about cp. I *think* GNU cp does the right thing with

Re: adapter, what's in a name

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 10:38, Stefan Richter wrote: Karl Dahlke wrote: The longer I stay on this list, the more I will learn. But it's high volume, so I may not be able to stay for long. Because of the high volume at this list, it is essential that - you keep everyone who posted in a tread in the

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 20:50, Balbir Singh wrote: John Stoffel wrote: I know this is a pedantic comment, but why the heck is it called such a generic term as Memory Controller which doesn't give any indication of what it does. Shouldn't it be something like Memory Quota Controller, or Memory

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 17:27, Patrick McHardy wrote: Striking. How can this even happen? A callsite which calls dev_alloc_skb(n) is just equivalent to __dev_alloc_skb(n, GFP_ATOMIC); which means there's like 4 (or 8 if it's long) bytes more on the stack. For a worst case, count in another

Re: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 15:47, Ilpo Järvinen wrote: -23668 392 funcs, 104 +, 23772 -, diff: -23668 --- dev_alloc_skb -static inline struct sk_buff *dev_alloc_skb(unsigned int length) -{ - return __dev_alloc_skb(length, GFP_ATOMIC); -} +extern struct sk_buff *dev_alloc_skb(unsigned int length);

Re: very poor ext3 write performance on big filesystems?

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 09:44, David Rees wrote: On Wed, Feb 20, 2008 at 2:57 AM, Jan Engelhardt [EMAIL PROTECTED] wrote: But GNU tar does not handle acls and xattrs. So back to rsync/cp/mv. Huh? The version of tar on my Fedora 8 desktop (tar-1.17-7) does. Just add the --xattrs option (which turns

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Jan Engelhardt
On Feb 20 2008 18:19, Pavel Machek wrote: For ordinary desktop people, memory controller is what developers know as MMU or sometimes even some other mysterious piece of silicon inside the heavy box. Actually I'd guess 'memory controller' == 'DRAM controller' == part of northbridge that

Re: Where to put adapters

2008-02-19 Thread Jan Engelhardt
On Feb 19 2008 08:01, Karl Dahlke wrote: > >Now that notifiers are in, (yay!), people are going to start writing adapters >for visually and motor impaired individuals. >I suggest we place them in drivers/adapters in the source tree, Umph, that sounds a bit generic. Network cards are sometimes

Re: Where to put adapters

2008-02-19 Thread Jan Engelhardt
On Feb 19 2008 08:01, Karl Dahlke wrote: Now that notifiers are in, (yay!), people are going to start writing adapters for visually and motor impaired individuals. I suggest we place them in drivers/adapters in the source tree, Umph, that sounds a bit generic. Network cards are sometimes

Re: 2.6.25-rc1/2 CD/DVD burning broken

2008-02-18 Thread Jan Engelhardt
On Feb 18 2008 11:31, Frans Pop wrote: >> > >> > There is also the 100% certainty that this reply was from a known troll >> > and should just be ignored. >> >> That was rude, crude and uncalled for. > >I have no problems with my reply being called "rude" or "crude". After all, >I wasn't even

Re: 2.6.25-rc1/2 CD/DVD burning broken

2008-02-18 Thread Jan Engelhardt
On Feb 18 2008 12:28, Joerg Schilling wrote: > >> >This fragment is much too short to allow to judge on possible reasons. >> >There is a high probability that your problem is caused by the cdrecord >> >fork called "wodim". >> > >> [...] >> > >> >As a general advise: if you have problems, always

Re: 2.6.25-rc1/2 CD/DVD burning broken

2008-02-18 Thread Jan Engelhardt
On Feb 18 2008 12:28, Joerg Schilling wrote: This fragment is much too short to allow to judge on possible reasons. There is a high probability that your problem is caused by the cdrecord fork called wodim. [...] As a general advise: if you have problems, always first try recent

Re: 2.6.25-rc1/2 CD/DVD burning broken

2008-02-18 Thread Jan Engelhardt
On Feb 18 2008 11:31, Frans Pop wrote: There is also the 100% certainty that this reply was from a known troll and should just be ignored. That was rude, crude and uncalled for. I have no problems with my reply being called rude or crude. After all, I wasn't even remotely trying to be

Re: 2.6.25-rc1/2 CD/DVD burning broken

2008-02-17 Thread Jan Engelhardt
On Feb 18 2008 00:21, Joerg Schilling wrote: > >> changing ide-cd (take 4)] I cannot burn any CD/DVD any more, getting the >> following error from wodim: > >> Errno: 0 (Success), write_g1 scsi sendcmd: no error >> CDB: 2A 00 00 00 00 00 00 00 1F 00 >> status: 0x2 (CHECK CONDITION) >> Sense

Re: 2.6.25-rc1/2 CD/DVD burning broken

2008-02-17 Thread Jan Engelhardt
On Feb 18 2008 00:21, Joerg Schilling wrote: changing ide-cd (take 4)] I cannot burn any CD/DVD any more, getting the following error from wodim: Errno: 0 (Success), write_g1 scsi sendcmd: no error CDB: 2A 00 00 00 00 00 00 00 1F 00 status: 0x2 (CHECK CONDITION) Sense Bytes: 70 00

Re: Compiling with 2.6.25-rc2 with binutils 2.17 fails?

2008-02-16 Thread Jan Engelhardt
On Feb 16 2008 17:27, Rob Landley wrote: >The build does this: >> VDSOSYM arch/x86/vdso/vdso32-syms.lds >> --- - Fri Feb 15 23:38:41 2008 >> +++ arch/x86/vdso/vdso32-int80-syms.lds Fri Feb 15 23:38:41 2008 >> @@ -0,0 +1,5 @@ >> +VDSO32_PRELINK = 0x0; >> +VDSO32_rt_sigreturn = 0x040c; >>

Re: Linux 2.6.25-rc2

2008-02-16 Thread Jan Engelhardt
On Feb 15 2008 13:23, Linus Torvalds wrote: > >Just to show how _much_ of a winner it is, it's been awarded a coveted >"weasel" series name, which should tell you just how good it's going to >be. It's a name revered in Linux kernel history, and as such this brings >back the good old days where

Re: Linux 2.6.25-rc2

2008-02-16 Thread Jan Engelhardt
On Feb 15 2008 13:23, Linus Torvalds wrote: Just to show how _much_ of a winner it is, it's been awarded a coveted weasel series name, which should tell you just how good it's going to be. It's a name revered in Linux kernel history, and as such this brings back the good old days where if you

Re: Compiling with 2.6.25-rc2 with binutils 2.17 fails?

2008-02-16 Thread Jan Engelhardt
On Feb 16 2008 17:27, Rob Landley wrote: The build does this: VDSOSYM arch/x86/vdso/vdso32-syms.lds --- - Fri Feb 15 23:38:41 2008 +++ arch/x86/vdso/vdso32-int80-syms.lds Fri Feb 15 23:38:41 2008 @@ -0,0 +1,5 @@ +VDSO32_PRELINK = 0x0; +VDSO32_rt_sigreturn = 0x040c; +VDSO32_sigreturn =

Re: [PATCH] Make sysctl a separate filesystem

2008-02-15 Thread Jan Engelhardt
On Feb 15 2008 17:57, Oliver Pinter wrote: >> > >> >Doing it automatically is the only acceptable way, IMO. >> >> For time being only. >> >> The kernel (currently) only auto-mounts invisible filesystems. > and /selinux with selinuxfs, it is automounted ... but it is visible fs > Sorry if I do not

Re: [PATCH] Make sysctl a separate filesystem

2008-02-15 Thread Jan Engelhardt
On Feb 15 2008 08:34, Randy Dunlap wrote: >> > >> >Doing it automatically is the only acceptable way, IMO. >> >> For time being only. >> >> The kernel (currently) only auto-mounts invisible filesystems. > >like /root, sysfs, futexfs, pipefs, anon_inodefs, bdev, devpts, >hugetlbfs, inotifyfs ?

Re: [PATCH] Use directly kmalloc() and kfree() in init/initramfs.c

2008-02-15 Thread Jan Engelhardt
On Feb 15 2008 16:45, Thomas Petazzoni wrote: > >> Remove the cast while you are at it, thanks :) > >Right, thanks for the comment. Here is an updated patch. Who will pick >it up ? There doesn't seem to be a maintainer for the initramfs code >(not in MAINTAINERS, not in the init/initramfs.c file

Re: [PATCH] Use directly kmalloc() and kfree() in init/initramfs.c

2008-02-15 Thread Jan Engelhardt
On Feb 15 2008 12:13, Thomas Petazzoni wrote: >+++ linux/init/initramfs.c >@@ -57,7 +57,7 @@ > continue; > return (*p)->name; > } >- q = (struct hash *)malloc(sizeof(struct hash)); >+ q = (struct hash *)kmalloc(sizeof(struct hash), GFP_KERNEL);

Re: Disk schedulers

2008-02-15 Thread Jan Engelhardt
On Feb 14 2008 17:21, Lukas Hejtmanek wrote: >Hello, > >whom should I blame about disk schedulers? Also consider - DMA (e.g. only UDMA2 selected) - aging disk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 09/11] ata: fix sparse warning in pata_marvell.c

2008-02-15 Thread Jan Engelhardt
On Feb 13 2008 21:14, Harvey Harrison wrote: >drivers/ata/pata_marvell.c:88:2: warning: returning void-valued expression This is interesting. Why did not gcc warn us about this? (foo.c:3: warning: "return" with a value, in function returning void) -- To unsubscribe from this list: send the

Re: [PATCH] quota: Turn quotas off when remounting read-only

2008-02-15 Thread Jan Engelhardt
On Feb 11 2008 13:39, Jan Kara wrote: >> >> But... I'm thinking about this scenario: >> >> # mount /data >> # quotaon /data >> (some maintenance stuff to be planned) >> # mount -o remount,ro /data >> (do backup etc) >> # mount -r remount,rw /data >> >> at this point, it's expected that

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-15 Thread Jan Engelhardt
On Feb 12 2008 01:09, Bartlomiej Zolnierkiewicz wrote: > >> On a different note, i noticed ide-scsi might also need a cleanup >> similar to the other drivers. It is next on my TODO list in case >> you don't have anything with a higher prio. > >I was actually hoping that you'll continue unifying

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-15 Thread Jan Engelhardt
On Feb 13 2008 13:07, Boaz Harrosh wrote: >+static struct pci_device_id gdthtable[] __devinitdata = { >+ { PCI_VDEVICE(VORTEX, PCI_ANY_ID) }, >+ { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SRC) }, >+ { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SRC_XSCALE) }, >+ { } /* terminate

Re: REGRESSION: x86 vDSO: remove vdso-syms.o

2008-02-15 Thread Jan Engelhardt
On Feb 11 2008 15:29, Roland McGrath wrote: >Sam might want to experiment with something like: > > stdout_target = $(1) > $(@D)/.tmp_$(@F) && mv -f $(@D)/.tmp_$(@F) $@ > > cmd_foo = $(call stdout_target,blah | sed s/foo/bar/) > >to clean up all the places that would benefit from

Re: [PATCH 05/14] [ISDN] HiSax enternow: convert to PCI hotplug API

2008-02-15 Thread Jan Engelhardt
On Jul 17 2007 23:49, Jeff Garzik wrote: >+static struct pci_device_id en_pci_table[] = { >+ { PCI_VENDOR_ID_TIGERJET, PCI_DEVICE_ID_TIGERJET_300, 0x55, 0x02, }, >+ >+ { } /* terminate list */ >+}; This can be v v static

Re: [PATCH] Make sysctl a separate filesystem

2008-02-15 Thread Jan Engelhardt
On Feb 15 2008 12:35, Mikael Pettersson wrote: >Andi Kleen writes: > > Pavel Emelyanov <[EMAIL PROTECTED]> writes: > > >this subdir; > > > 3. sysctl inodes are now smaller than the procfs ones. > > > > That's always a good thing. > > > > > Note: update your initscripts to mount sysctl

Re: [PATCH 05/14] [ISDN] HiSax enternow: convert to PCI hotplug API

2008-02-15 Thread Jan Engelhardt
On Jul 17 2007 23:49, Jeff Garzik wrote: +static struct pci_device_id en_pci_table[] = { + { PCI_VENDOR_ID_TIGERJET, PCI_DEVICE_ID_TIGERJET_300, 0x55, 0x02, }, + + { } /* terminate list */ +}; This can be v v static const

Re: REGRESSION: x86 vDSO: remove vdso-syms.o

2008-02-15 Thread Jan Engelhardt
On Feb 11 2008 15:29, Roland McGrath wrote: Sam might want to experiment with something like: stdout_target = $(1) $(@D)/.tmp_$(@F) mv -f $(@D)/.tmp_$(@F) $@ cmd_foo = $(call stdout_target,blah | sed s/foo/bar/) to clean up all the places that would benefit from robust

Re: [PATCH] gdth: convert to PCI hotplug API

2008-02-15 Thread Jan Engelhardt
On Feb 13 2008 13:07, Boaz Harrosh wrote: +static struct pci_device_id gdthtable[] __devinitdata = { + { PCI_VDEVICE(VORTEX, PCI_ANY_ID) }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SRC) }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SRC_XSCALE) }, + { } /* terminate list

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-15 Thread Jan Engelhardt
On Feb 12 2008 01:09, Bartlomiej Zolnierkiewicz wrote: On a different note, i noticed ide-scsi might also need a cleanup similar to the other drivers. It is next on my TODO list in case you don't have anything with a higher prio. I was actually hoping that you'll continue unifying ATAPI

Re: [PATCH] quota: Turn quotas off when remounting read-only

2008-02-15 Thread Jan Engelhardt
On Feb 11 2008 13:39, Jan Kara wrote: But... I'm thinking about this scenario: # mount /data # quotaon /data (some maintenance stuff to be planned) # mount -o remount,ro /data (do backup etc) # mount -r remount,rw /data at this point, it's expected that quota on /data is

Re: [PATCH 09/11] ata: fix sparse warning in pata_marvell.c

2008-02-15 Thread Jan Engelhardt
On Feb 13 2008 21:14, Harvey Harrison wrote: drivers/ata/pata_marvell.c:88:2: warning: returning void-valued expression This is interesting. Why did not gcc warn us about this? (foo.c:3: warning: return with a value, in function returning void) -- To unsubscribe from this list: send the line

Re: [PATCH] Use directly kmalloc() and kfree() in init/initramfs.c

2008-02-15 Thread Jan Engelhardt
On Feb 15 2008 12:13, Thomas Petazzoni wrote: +++ linux/init/initramfs.c @@ -57,7 +57,7 @@ continue; return (*p)-name; } - q = (struct hash *)malloc(sizeof(struct hash)); + q = (struct hash *)kmalloc(sizeof(struct hash), GFP_KERNEL); Remove

Re: Disk schedulers

2008-02-15 Thread Jan Engelhardt
On Feb 14 2008 17:21, Lukas Hejtmanek wrote: Hello, whom should I blame about disk schedulers? Also consider - DMA (e.g. only UDMA2 selected) - aging disk -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] Use directly kmalloc() and kfree() in init/initramfs.c

2008-02-15 Thread Jan Engelhardt
On Feb 15 2008 16:45, Thomas Petazzoni wrote: Remove the cast while you are at it, thanks :) Right, thanks for the comment. Here is an updated patch. Who will pick it up ? There doesn't seem to be a maintainer for the initramfs code (not in MAINTAINERS, not in the init/initramfs.c file

Re: [PATCH] Make sysctl a separate filesystem

2008-02-15 Thread Jan Engelhardt
On Feb 15 2008 17:57, Oliver Pinter wrote: Doing it automatically is the only acceptable way, IMO. For time being only. The kernel (currently) only auto-mounts invisible filesystems. and /selinux with selinuxfs, it is automounted ... but it is visible fs Sorry if I do not know all the

Re: [PATCH] Make sysctl a separate filesystem

2008-02-15 Thread Jan Engelhardt
On Feb 15 2008 08:34, Randy Dunlap wrote: Doing it automatically is the only acceptable way, IMO. For time being only. The kernel (currently) only auto-mounts invisible filesystems. like /root, sysfs, futexfs, pipefs, anon_inodefs, bdev, devpts, hugetlbfs, inotifyfs ? Yes? / (double

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-14 Thread Jan Engelhardt
On Feb 14 2008 10:06, Andy Whitcroft wrote: >On Wed, Feb 13, 2008 at 08:43:58PM +0100, Jan Engelhardt wrote: >> >> On Feb 10 2008 15:33, Marcin Slusarz wrote: >> >Checkpatch in current mainline outputs following errors: >> > >> >$ ./scripts/checkpatch.pl

Re: Is there a "blackhole" /dev/null directory?

2008-02-14 Thread Jan Engelhardt
On Feb 14 2008 16:19, Hans-Jürgen Koch wrote: >> >> Q: What if a program attempts to mkdir /dev/nullmnt/foo to just >>create a file /dev/nullmnt/foo/barfile? >> A: /dev/nullmnt/foo must continue to exist or be accepted for a while, >>or perhaps for eternity. > >Well, the problem seems to

Re: Is there a "blackhole" /dev/null directory?

2008-02-14 Thread Jan Engelhardt
On Feb 14 2008 10:46, Andi Kleen wrote: >Jasper Bryant-Greene <[EMAIL PROTECTED]> writes: >> >> This could be done fairly trivially with FUSE, and IMHO is a good use >> for FUSE because since you're just throwing most data away, performance >> is not a concern. There is a much more interesting

Re: vmsplice exploits, stack protector and Makefiles

2008-02-14 Thread Jan Engelhardt
On Feb 13 2008 17:48, [EMAIL PROTECTED] wrote: >On 13 Feb 2008 at 8:29, Randy Dunlap wrote: > >> Is it signed-off-by: pageexec ? > >no it isn't, on purpose as i won't give out my real name that the >DCO requires. But could still add "Brought-to-attention-by: [EMAIL PROTECTED]" or something like

Re: vmsplice exploits, stack protector and Makefiles

2008-02-14 Thread Jan Engelhardt
On Feb 13 2008 17:48, [EMAIL PROTECTED] wrote: On 13 Feb 2008 at 8:29, Randy Dunlap wrote: Is it signed-off-by: pageexec ? no it isn't, on purpose as i won't give out my real name that the DCO requires. But could still add Brought-to-attention-by: [EMAIL PROTECTED] or something like that. --

Re: Is there a blackhole /dev/null directory?

2008-02-14 Thread Jan Engelhardt
On Feb 14 2008 10:46, Andi Kleen wrote: Jasper Bryant-Greene [EMAIL PROTECTED] writes: This could be done fairly trivially with FUSE, and IMHO is a good use for FUSE because since you're just throwing most data away, performance is not a concern. There is a much more interesting 'problem'

Re: Is there a blackhole /dev/null directory?

2008-02-14 Thread Jan Engelhardt
On Feb 14 2008 16:19, Hans-Jürgen Koch wrote: Q: What if a program attempts to mkdir /dev/nullmnt/foo to just create a file /dev/nullmnt/foo/barfile? A: /dev/nullmnt/foo must continue to exist or be accepted for a while, or perhaps for eternity. Well, the problem seems to be that a

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-14 Thread Jan Engelhardt
On Feb 14 2008 10:06, Andy Whitcroft wrote: On Wed, Feb 13, 2008 at 08:43:58PM +0100, Jan Engelhardt wrote: On Feb 10 2008 15:33, Marcin Slusarz wrote: Checkpatch in current mainline outputs following errors: $ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c ERROR: need consistent

Re: [2.6 patch] #if 0 aoedev_isbusy()

2008-02-13 Thread Jan Engelhardt
On Feb 13 2008 23:30, Adrian Bunk wrote: > >This patch #if 0's the no longer used aoedev_isbusy(). Why not just remove it? (It can be resurrected from earlier revisions should it be needed again.) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-13 Thread Jan Engelhardt
On Feb 10 2008 15:33, Marcin Slusarz wrote: >Checkpatch in current mainline outputs following errors: > >$ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c >ERROR: need consistent spacing around '*' (ctx:WxV) >#205: FILE: fs/udf/misc.c:205: >+ tag *tag_p; >^ I'd say "don't add

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Jan Engelhardt
On Feb 13 2008 11:03, Boaz Harrosh wrote: >> >> I've tested this patch now - and it works fine. Now rmmod, halt and >> reboot also works. >> >> Stefan Priebe >> >This is grate news Stefan. Thank you very much for all your time >and effort, with out we could not have fixed all this. Do you

Re: bug in checkpatch (on pointers to typedefs?)

2008-02-13 Thread Jan Engelhardt
On Feb 10 2008 15:33, Marcin Slusarz wrote: Checkpatch in current mainline outputs following errors: $ ./scripts/checkpatch.pl -q --file ./fs/udf/misc.c ERROR: need consistent spacing around '*' (ctx:WxV) #205: FILE: fs/udf/misc.c:205: + tag *tag_p; ^ I'd say don't add any new

Re: [BUGFIX 2/2] gdth: bugfix for the Timer at exit crash

2008-02-13 Thread Jan Engelhardt
On Feb 13 2008 11:03, Boaz Harrosh wrote: I've tested this patch now - and it works fine. Now rmmod, halt and reboot also works. Stefan Priebe This is grate news Stefan. Thank you very much for all your time and effort, with out we could not have fixed all this. Do you have a git tree

Re: [2.6 patch] #if 0 aoedev_isbusy()

2008-02-13 Thread Jan Engelhardt
On Feb 13 2008 23:30, Adrian Bunk wrote: This patch #if 0's the no longer used aoedev_isbusy(). Why not just remove it? (It can be resurrected from earlier revisions should it be needed again.) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 15:38, David Miller wrote: > >> I still don't like the idea of btrfs trying to be smarter than a user >> who can partition up his system according to >> (a) his likes >> (b) system or hardware requirements or recommendations >> to align the superblock to a specific

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 15:26, David Miller wrote: > >> (Yes, I had xfs on sparc before, so it's not like you NEED the >> whitespace at the start of a partition.) > >You actully do unless you want to lose significant chunks of your disk >space. > >The Sun disk label only allows you to specify the start

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Jan Engelhardt
On Feb 11 2008 20:21, Greg KH wrote: >> >> I hope to recreate this tree every day automatically. In order to do >> this, any tree that has a conflict will be dropped from that days tree. > >Oh oh oh, I get merged first! me me me! No, you can't have a tree like that. [森林 Not yours. 森林] Let's

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
> On Feb 12 2008 09:35, Chris Mason wrote: >> >> and slap the bootloader into "MBR", just like on x86. >> Or I am missing something.. > >It was a request from hpa, and he clearly had something in mind. He kindly >offered to review the disk format for bootloaders and other lower level >issues

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 09:08, Chris Mason wrote: >> > >> >So, if Btrfs starts zeroing at 1k, will that be acceptable for you? >> >> Something looks wrong here. Why would btrfs need to zero at all? >> Superblock at 0, and done. Just like xfs. >> (Yes, I had xfs on sparc before, so it's not like you NEED

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 08:49, Chris Mason wrote: >> > >> > This is a real issue on sparc where the default sun disk labels >> > created use an initial partition where block zero aliases the disk >> > label. It took me a few iterations before I figured out why every >> > btrfs make would zero out my disk

Re: Announce: Linux-next (Or Andrew's dream :-))

2008-02-12 Thread Jan Engelhardt
On Feb 11 2008 20:21, Greg KH wrote: I hope to recreate this tree every day automatically. In order to do this, any tree that has a conflict will be dropped from that days tree. Oh oh oh, I get merged first! me me me! No, you can't have a tree like that. [森林 Not yours. 森林] Let's

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 15:26, David Miller wrote: (Yes, I had xfs on sparc before, so it's not like you NEED the whitespace at the start of a partition.) You actully do unless you want to lose significant chunks of your disk space. The Sun disk label only allows you to specify the start of a

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 15:38, David Miller wrote: I still don't like the idea of btrfs trying to be smarter than a user who can partition up his system according to (a) his likes (b) system or hardware requirements or recommendations to align the superblock to a specific location. All of

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 09:35, Chris Mason wrote: and slap the bootloader into MBR, just like on x86. Or I am missing something.. It was a request from hpa, and he clearly had something in mind. He kindly offered to review the disk format for bootloaders and other lower level issues but I asked him

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 09:08, Chris Mason wrote: So, if Btrfs starts zeroing at 1k, will that be acceptable for you? Something looks wrong here. Why would btrfs need to zero at all? Superblock at 0, and done. Just like xfs. (Yes, I had xfs on sparc before, so it's not like you NEED the whitespace

Re: BTRFS partition usage...

2008-02-12 Thread Jan Engelhardt
On Feb 12 2008 08:49, Chris Mason wrote: This is a real issue on sparc where the default sun disk labels created use an initial partition where block zero aliases the disk label. It took me a few iterations before I figured out why every btrfs make would zero out my disk label :-/

Re: [PATCH] make /dev/kmem a config option

2008-02-10 Thread Jan Engelhardt
On Feb 10 2008 15:55, Arjan van de Ven wrote: >+#ifdef CONFIG_DEVKMEM > /* > * This function reads the *virtual* memory as seen by the kernel. > */ >@@ -585,6 +588,11 @@ static ssize_t write_kmem(struct file * file, const char >__user * buf, > *ppos = p; > return virtr + wrote; > }

Netfilter fixes to 2.6.24-git

2008-02-10 Thread Jan Engelhardt
Hi to everyone, I have been unable to reach the netfilter and net maintainers the past week regarding inclusion of patches, but most importantly a group of fixes at [0]-[3]. I am kind of at a loss here but to turn up the volume and write to more people on how to proceed. thanks, Jan [0]

Re: Faster way to run through building single modules

2008-02-10 Thread Jan Engelhardt
On Feb 10 2008 20:28, Sam Ravnborg wrote: >On Sun, Feb 10, 2008 at 07:51:29PM +0100, Jan Engelhardt wrote: >> >> I was wondering whether there is a shortcut in kbuild I can take if I >> just want to rebuild one module. Currently, I have: >> >> make net/bri

Faster way to run through building single modules

2008-02-10 Thread Jan Engelhardt
Hi, I was wondering whether there is a shortcut in kbuild I can take if I just want to rebuild one module. Currently, I have: make net/bridge/netfilter/ebtables.ko the modpost stage ("MODPOST 2018 modules") does quite a lot of disk I/O, most of which I probably do not need anyway. Can this

Re: [10/19] ftrace: add basic support for gcc profiler instrumentation

2008-02-10 Thread Jan Engelhardt
On Feb 10 2008 08:20, Ingo Molnar wrote: >--- linux.orig/Makefile >+++ linux/Makefile >@@ -509,6 +509,9 @@ endif > > include $(srctree)/arch/$(SRCARCH)/Makefile > >+ifdef CONFIG_FTRACE >+KBUILD_CFLAGS += -pg >+endif > ifdef CONFIG_FRAME_POINTER > KBUILD_CFLAGS += -fno-omit-frame-pointer

Re: [10/19] ftrace: add basic support for gcc profiler instrumentation

2008-02-10 Thread Jan Engelhardt
On Feb 10 2008 08:20, Ingo Molnar wrote: --- linux.orig/Makefile +++ linux/Makefile @@ -509,6 +509,9 @@ endif include $(srctree)/arch/$(SRCARCH)/Makefile +ifdef CONFIG_FTRACE +KBUILD_CFLAGS += -pg +endif ifdef CONFIG_FRAME_POINTER KBUILD_CFLAGS += -fno-omit-frame-pointer

Faster way to run through building single modules

2008-02-10 Thread Jan Engelhardt
Hi, I was wondering whether there is a shortcut in kbuild I can take if I just want to rebuild one module. Currently, I have: make net/bridge/netfilter/ebtables.ko the modpost stage (MODPOST 2018 modules) does quite a lot of disk I/O, most of which I probably do not need anyway. Can this

Re: Faster way to run through building single modules

2008-02-10 Thread Jan Engelhardt
On Feb 10 2008 20:28, Sam Ravnborg wrote: On Sun, Feb 10, 2008 at 07:51:29PM +0100, Jan Engelhardt wrote: I was wondering whether there is a shortcut in kbuild I can take if I just want to rebuild one module. Currently, I have: make net/bridge/netfilter/ebtables.ko Fool kbuild to think

Netfilter fixes to 2.6.24-git

2008-02-10 Thread Jan Engelhardt
Hi to everyone, I have been unable to reach the netfilter and net maintainers the past week regarding inclusion of patches, but most importantly a group of fixes at [0]-[3]. I am kind of at a loss here but to turn up the volume and write to more people on how to proceed. thanks, Jan [0]

Re: [PATCH] make /dev/kmem a config option

2008-02-10 Thread Jan Engelhardt
On Feb 10 2008 15:55, Arjan van de Ven wrote: +#ifdef CONFIG_DEVKMEM /* * This function reads the *virtual* memory as seen by the kernel. */ @@ -585,6 +588,11 @@ static ssize_t write_kmem(struct file * file, const char __user * buf, *ppos = p; return virtr + wrote; } +#else

Re: [RFC] Sectionized printk data

2008-02-09 Thread Jan Engelhardt
On Feb 9 2008 21:54, Arnaldo Carvalho de Melo wrote: >> To drop strings that are only shown once anyway, such as: >> >> static int __init ebtables_init(void) >> { >> int ret; >> >> mutex_lock(_mutex); >> list_add(_standard_target.list, _targets); >>

Re: [patch 0/4] make pr_debug() dynamic

2008-02-09 Thread Jan Engelhardt
On Feb 8 2008 10:52, Jason Baron wrote: >On Thu, Feb 07, 2008 at 02:42:14PM -0800, Joe Perches wrote: >> On Thu, 2008-02-07 at 16:03 -0500, Jason Baron wrote: >> > make the pr_debug() function dependent upon the new immediate >> > infrastruture. >> >> What's wrong with klogd -c 8 or equivalent?

Re: [RFC] Sectionized printk data

2008-02-09 Thread Jan Engelhardt
On Feb 4 2008 19:07, Sam Ravnborg wrote: >> The attached patch allows something along the lines: >> >> int __init some_function(void) >> { >> [...] >> pr_init(KERN_WARNING "failure %s in %s\n", ...); >> [...] >> } >> >> Another idea I had was to make printk a macro that

<    1   2   3   4   5   6   7   8   9   10   >