Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer

On Mon, Feb 15, 2016 at 5:47 PM, Sudeep Holla wrote: > Hi Jassi, > > On 11/02/16 17:13, Sudeep Holla wrote: >> >> Hi Lee, Jassi, >> >> Assuming mailbox-test was designed to be generic, I am trying to extend >> it to support single channel with separate Tx and Rx buffer. With

Re: [PATCH 0/4] mailbox: mailbox-test: support single channel with separate Tx and Rx buffer

On Mon, Feb 15, 2016 at 5:47 PM, Sudeep Holla wrote: > Hi Jassi, > > On 11/02/16 17:13, Sudeep Holla wrote: >> >> Hi Lee, Jassi, >> >> Assuming mailbox-test was designed to be generic, I am trying to extend >> it to support single channel with separate Tx and Rx buffer. With these >> changes I am

Re: [PATCH v7 0/4] mailbox: hisilicon: add Hi6220 mailbox driver

On Thu, Feb 4, 2016 at 8:54 PM, Leo Yan wrote: > Hi6220 mailbox supports up to 32 channels. Each channel is unidirectional > with a maximum message size of 8 words. I/O is performed using register > access (there is no DMA) and the cell raises an interrupt when messages > are

Re: [PATCH v7 0/4] mailbox: hisilicon: add Hi6220 mailbox driver

On Thu, Feb 4, 2016 at 8:54 PM, Leo Yan wrote: > Hi6220 mailbox supports up to 32 channels. Each channel is unidirectional > with a maximum message size of 8 words. I/O is performed using register > access (there is no DMA) and the cell raises an interrupt when messages > are received. > > This

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

On Tue, Feb 9, 2016 at 11:40 PM, Nishanth Menon wrote: > On 09:43-20160209, Nishanth Menon wrote: >> On Tue, Feb 9, 2016 at 8:54 AM, Jassi Brar wrote: > [..] >> Let me prototype this as part of of_xlate and see if I can pull the >> qinst data back out.. obviously one

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

On Tue, Feb 9, 2016 at 11:40 PM, Nishanth Menon <n...@ti.com> wrote: > On 09:43-20160209, Nishanth Menon wrote: >> On Tue, Feb 9, 2016 at 8:54 AM, Jassi Brar <jassisinghb...@gmail.com> wrote: > [..] >> Let me prototype this as part of of_xlate and see if I can p

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

On Tue, Feb 9, 2016 at 8:24 PM, Jassi Brar wrote: > On Tue, Feb 9, 2016 at 6:01 PM, Nishanth Menon wrote: >> On 02/08/2016 10:14 PM, Jassi Brar wrote: >> >>>> + >>> I think we should get rid of consumer specifics from the provider node... >> >> &

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

On Tue, Feb 9, 2016 at 6:01 PM, Nishanth Menon wrote: > On 02/08/2016 10:14 PM, Jassi Brar wrote: > > Thanks for the review. > >> On Fri, Feb 5, 2016 at 10:04 PM, Nishanth Menon wrote: >>> + >>> + msgmgr: msgmgr@02a0 { >>> +

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

On Tue, Feb 9, 2016 at 6:01 PM, Nishanth Menon <n...@ti.com> wrote: > On 02/08/2016 10:14 PM, Jassi Brar wrote: > > Thanks for the review. > >> On Fri, Feb 5, 2016 at 10:04 PM, Nishanth Menon <n...@ti.com> wrote: >>> + >>> + msgmgr: msgmgr@02a

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

On Tue, Feb 9, 2016 at 8:24 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: > On Tue, Feb 9, 2016 at 6:01 PM, Nishanth Menon <n...@ti.com> wrote: >> On 02/08/2016 10:14 PM, Jassi Brar wrote: >> >>>> + >>> I think we should get rid of consumer speci

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

On Fri, Feb 5, 2016 at 10:04 PM, Nishanth Menon wrote: > + > + msgmgr: msgmgr@02a0 { > + compatible = "ti,k2g-message-manager", "ti,message-manager"; > + #mbox-cells = <1>; > + reg-names = "queue_proxy_region", "queue_state_debug_region"; > +

Re: [PATCH 1/2] Documentation: dt: mailbox: Add TI Message Manager

On Fri, Feb 5, 2016 at 10:04 PM, Nishanth Menon wrote: > + > + msgmgr: msgmgr@02a0 { > + compatible = "ti,k2g-message-manager", "ti,message-manager"; > + #mbox-cells = <1>; > + reg-names = "queue_proxy_region",

[GIT PULL] Mailbox fixes for -rc3

Hi Linus, The following changes since commit 34229b277480f46c1e9a19f027f30b074512e68b: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2016-02-01 15:56:08 -0800) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git

[GIT PULL] Mailbox fixes for -rc3

Hi Linus, The following changes since commit 34229b277480f46c1e9a19f027f30b074512e68b: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2016-02-01 15:56:08 -0800) are available in the git repository at: git://git.linaro.org/landing-teams/working/fujitsu/integration.git

Re: [PATCH] mailbox: pcc: fix channel calculation in get_pcc_channel()

On Tue, Feb 2, 2016 at 2:21 AM, Rafael J. Wysocki wrote: > On Mon, Feb 1, 2016 at 4:43 PM, Jassi Brar wrote: >> On Mon, Feb 1, 2016 at 8:49 PM, Alexey Klimov wrote: >>> (adding Rafael and linux-acpi) >>> >>> On Fri, Jan 15, 2016 at 6:22 PM, Ashwin Chaugule &

Re: [PATCH] mailbox: pcc: fix channel calculation in get_pcc_channel()

On Tue, Feb 2, 2016 at 2:21 AM, Rafael J. Wysocki <raf...@kernel.org> wrote: > On Mon, Feb 1, 2016 at 4:43 PM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Mon, Feb 1, 2016 at 8:49 PM, Alexey Klimov <alexey.kli...@arm.com> wrote: >>> (adding Rafael an

Re: [PATCH v4 1/3] mailbox: Add support for APM X-Gene platform mailbox driver

On Tue, Feb 2, 2016 at 1:08 AM, Duc Dang wrote: > Hi Jassi, > > On Fri, Jan 15, 2016 at 6:57 PM, Duc Dang wrote: >> X-Gene mailbox controller provides 8 mailbox channels, with >> each channel has a dedicated interrupt line. > > Did you have a chance to look into this version 4 of my mail-box

Re: [PATCH v5 1/4] dt-bindings: mailbox: Document Hi6220 mailbox driver

On Mon, Feb 1, 2016 at 8:53 PM, Leo Yan wrote: > Hi Rob, > > Thanks for reviewing, please see below inline comments. > > On Mon, Feb 01, 2016 at 08:08:28AM -0600, Rob Herring wrote: >> On Mon, Feb 01, 2016 at 09:34:44PM +0800, Leo Yan wrote: >> > Document DT binding for Hisilicon Hi6220 mailbox

Re: [PATCH] mailbox: pcc: fix channel calculation in get_pcc_channel()

On Mon, Feb 1, 2016 at 8:49 PM, Alexey Klimov wrote: > (adding Rafael and linux-acpi) > > On Fri, Jan 15, 2016 at 6:22 PM, Ashwin Chaugule > wrote: >> + Jassi (Linaro addr) >> >> On 15 January 2016 at 13:20, Ashwin Chaugule >> wrote: >>> Jassi, >>> >>> On 10 December 2015 at 13:19, Ashwin

Re: [PATCH v5 1/4] dt-bindings: mailbox: Document Hi6220 mailbox driver

On Mon, Feb 1, 2016 at 8:53 PM, Leo Yan wrote: > Hi Rob, > > Thanks for reviewing, please see below inline comments. > > On Mon, Feb 01, 2016 at 08:08:28AM -0600, Rob Herring wrote: >> On Mon, Feb 01, 2016 at 09:34:44PM +0800, Leo Yan wrote: >> > Document DT binding for

Re: [PATCH v4 1/3] mailbox: Add support for APM X-Gene platform mailbox driver

On Tue, Feb 2, 2016 at 1:08 AM, Duc Dang wrote: > Hi Jassi, > > On Fri, Jan 15, 2016 at 6:57 PM, Duc Dang wrote: >> X-Gene mailbox controller provides 8 mailbox channels, with >> each channel has a dedicated interrupt line. > > Did you have a chance to look into

Re: [PATCH] mailbox: pcc: fix channel calculation in get_pcc_channel()

On Mon, Feb 1, 2016 at 8:49 PM, Alexey Klimov wrote: > (adding Rafael and linux-acpi) > > On Fri, Jan 15, 2016 at 6:22 PM, Ashwin Chaugule > wrote: >> + Jassi (Linaro addr) >> >> On 15 January 2016 at 13:20, Ashwin Chaugule

Re: [PATCH 1/4] mailbox: mailbox-test: Use more consistent format for calling copy_from_user()

On Thu, Jan 14, 2016 at 12:41 PM, Lee Jones wrote: > While we're at it, ensure copy-to location is NULL'ed in the error path. > > Suggested-by: Dan Carpenter > Signed-off-by: Lee Jones > --- > drivers/mailbox/mailbox-test.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH 1/4] mailbox: mailbox-test: Use more consistent format for calling copy_from_user()

On Thu, Jan 14, 2016 at 12:41 PM, Lee Jones wrote: > While we're at it, ensure copy-to location is NULL'ed in the error path. > > Suggested-by: Dan Carpenter > Signed-off-by: Lee Jones > --- > drivers/mailbox/mailbox-test.c

Re: [PATCHv7 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

On 2 December 2015 at 22:56, Moritz Fischer wrote: > Hi Jassi, > > thanks for your feedback. > > On Mon, Aug 10, 2015 at 1:05 AM, Jassi Brar wrote: >> On Wed, Jul 15, 2015 at 6:30 AM, Moritz Fischer >> wrote: >> >>> + >>> +sta

Re: [PATCHv7 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

On 2 December 2015 at 22:56, Moritz Fischer <moritz.fisc...@ettus.com> wrote: > Hi Jassi, > > thanks for your feedback. > > On Mon, Aug 10, 2015 at 1:05 AM, Jassi Brar <jassisinghb...@gmail.com> wrote: >> On Wed, Jul 15, 2015 at 6:30 AM, Moritz Fischer &g

Re: [PATCH] mailbox: constify mbox_chan_ops structure

On Sun, Nov 29, 2015 at 6:20 PM, Julia Lawall wrote: > This mbox_chan_ops structure is never modified, so declare it as const, > like all the other mbox_chan_ops structures. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Applied, Thanks. -- To unsubscribe from this list:

Re: [PATCH] mailbox: constify mbox_chan_ops structure

On Sun, Nov 29, 2015 at 6:20 PM, Julia Lawall wrote: > This mbox_chan_ops structure is never modified, so declare it as const, > like all the other mbox_chan_ops structures. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall >

Re: [PATCH v3 1/3] mailbox: Add support for APM X-Gene platform mailbox driver

On Mon, Nov 9, 2015 at 11:35 PM, Duc Dang wrote: > X-Gene mailbox controller provides 8 mailbox channels, with > each channel has a dedicated interrupt line. > > [dhdang: rebase over 4.3-rc5, some minor changes to > address comment in v2 patch set] > Do you want this to go into git logs? >

Re: [PATCH v3 1/3] mailbox: Add support for APM X-Gene platform mailbox driver

On Mon, Nov 9, 2015 at 11:35 PM, Duc Dang wrote: > X-Gene mailbox controller provides 8 mailbox channels, with > each channel has a dedicated interrupt line. > > [dhdang: rebase over 4.3-rc5, some minor changes to > address comment in v2 patch set] > Do you want this to go into

Re: [RFC 2/8] mailbox: Add NVIDIA Tegra XUSB mailbox driver

On Mon, Nov 2, 2015 at 5:25 PM, Martyn Welch wrote: > From: Andrew Bresticker > > The Tegra xHCI controller's firmware communicates requests to the host > processor through a mailbox interface. While there is only a single > physical channel, messages sent by the controller can be divided >

Re: [RFC 2/8] mailbox: Add NVIDIA Tegra XUSB mailbox driver

On Mon, Nov 2, 2015 at 5:25 PM, Martyn Welch wrote: > From: Andrew Bresticker > > The Tegra xHCI controller's firmware communicates requests to the host > processor through a mailbox interface. While there is only a single > physical channel,

[GIT PULL] Mailbox changes for v4.4

quirk to fix AM33xx CPU Idle Jassi Brar (1): mailbox: mailbox-test: avoid reading iomem twice Lee Jones (5): mailbox: dt: Supply bindings for ST's Mailbox IP mailbox: Add support for ST's Mailbox IP mailbox: Add generic mechanism for testing Mailbox Controllers mailbox

[GIT PULL] Mailbox changes for v4.4

quirk to fix AM33xx CPU Idle Jassi Brar (1): mailbox: mailbox-test: avoid reading iomem twice Lee Jones (5): mailbox: dt: Supply bindings for ST's Mailbox IP mailbox: Add support for ST's Mailbox IP mailbox: Add generic mechanism for testing Mailbox Controllers mailbox

Re: linux-next: build failure after merge of the mailbox tree

On 1 November 2015 at 17:42, Stephen Rothwell wrote: > Hi Jassi, > > After merging the mailbox tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/mailbox/mailbox-test.c: In function 'mbox_test_receive_message': > drivers/mailbox/mailbox-test.c:226:11: error:

Re: linux-next: build failure after merge of the mailbox tree

On 1 November 2015 at 17:42, Stephen Rothwell wrote: > Hi Jassi, > > After merging the mailbox tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/mailbox/mailbox-test.c: In function 'mbox_test_receive_message': >

Re: [PATCH v3 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle

On 22 October 2015 at 05:35, Suman Anna wrote: >> Anyways I am OK too, if you guys want to fix it with a platform >> specific quirk. Let me know I'll pick this patch. > > I haven't gotten a chance to try #1, and I won't be able to look at it > atleast for another month. I suggest that you go

Re: [PATCH v3 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle

On 22 October 2015 at 05:35, Suman Anna wrote: >> Anyways I am OK too, if you guys want to fix it with a platform >> specific quirk. Let me know I'll pick this patch. > > I haven't gotten a chance to try #1, and I won't be able to look at it > atleast for another month. I

Re: [PATCH v3 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle

On Wed, Sep 23, 2015 at 5:44 AM, Dave Gerlach wrote: > The mailbox framework controls the transmission queue and requires > either its controller implementations or clients to run the state > machine for the Tx queue. The OMAP mailbox controller uses a Tx-ready > interrupt as the equivalent of a

Re: [PATCH v3 1/3] mailbox/omap: Add ti,mbox-send-noirq quirk to fix AM33xx CPU Idle

On Wed, Sep 23, 2015 at 5:44 AM, Dave Gerlach wrote: > The mailbox framework controls the transmission queue and requires > either its controller implementations or clients to run the state > machine for the Tx queue. The OMAP mailbox controller uses a Tx-ready > interrupt as

Re: [RESEND v4.1 0/5] Mailbox: Provide support STi based platforms

On 16 October 2015 at 12:51, Lee Jones wrote: > Hi Jassi, > > [Resending the updated patch-set this time] > > This should be it. Exciting times! > > ST's platforms currently support a maximum of 5 Mailboxes, one for > each of the supported co-processors situated on the platform. Each > Mailbox

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

On 16 October 2015 at 11:38, Leo Yan wrote: > On Fri, Oct 16, 2015 at 11:17:32AM +0530, Jassi Brar wrote: >> On Fri, Oct 16, 2015 at 10:59 AM, Leo Yan wrote: >> > On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote: >> >> On Mon, Oct 12, 20

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

On 16 October 2015 at 11:38, Leo Yan <leo@linaro.org> wrote: > On Fri, Oct 16, 2015 at 11:17:32AM +0530, Jassi Brar wrote: >> On Fri, Oct 16, 2015 at 10:59 AM, Leo Yan <leo@linaro.org> wrote: >> > On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote: &g

Re: [RESEND v4.1 0/5] Mailbox: Provide support STi based platforms

On 16 October 2015 at 12:51, Lee Jones wrote: > Hi Jassi, > > [Resending the updated patch-set this time] > > This should be it. Exciting times! > > ST's platforms currently support a maximum of 5 Mailboxes, one for > each of the supported co-processors situated on the

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

On Fri, Oct 16, 2015 at 10:59 AM, Leo Yan wrote: > On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote: >> On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: >> >> > + >> > +#define MBOX_CHAN_MAX 32 >> > +#define MBOX_CHAN

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: > + > +#define MBOX_CHAN_MAX 32 > +#define MBOX_CHAN_NUM 2 > + You mean the hardware has 32 channels but this driver can not manage more than 2 ? OR, there are 32 interfaces but only 2 physical 'floating' links,

Re: [PATCH v4 1/4] dt-bindings: mailbox: Document Hi6220 mailbox driver

On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: > + > +Mailbox Device Node: > + > + > +Required properties: > + > +- compatible: Shall be "hisilicon,hi6220-mbox" > +- reg: Contains the mailbox register address range (base > +

Re: [PATCH v4 0/5] Mailbox: Provide support STi based platforms

On 5 October 2015 at 18:32, Lee Jones wrote: > Hi Jassi, > > This should be it. Exciting times! > > ST's platforms currently support a maximum of 5 Mailboxes, one for > each of the supported co-processors situated on the platform. Each > Mailbox is divided up into 4 instances which consist of

Re: [PATCH v4 0/5] Mailbox: Provide support STi based platforms

On 5 October 2015 at 18:32, Lee Jones wrote: > Hi Jassi, > > This should be it. Exciting times! > > ST's platforms currently support a maximum of 5 Mailboxes, one for > each of the supported co-processors situated on the platform. Each > Mailbox is divided up into 4

Re: [PATCH v4 1/4] dt-bindings: mailbox: Document Hi6220 mailbox driver

On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: > + > +Mailbox Device Node: > + > + > +Required properties: > + > +- compatible: Shall be "hisilicon,hi6220-mbox" > +- reg: Contains the mailbox register address

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan wrote: > + > +#define MBOX_CHAN_MAX 32 > +#define MBOX_CHAN_NUM 2 > + You mean the hardware has 32 channels but this driver can not manage more than 2 ? OR, there are 32 interfaces but only 2

Re: [PATCH v4 2/4] mailbox: Hi6220: add mailbox driver

On Fri, Oct 16, 2015 at 10:59 AM, Leo Yan <leo@linaro.org> wrote: > On Fri, Oct 16, 2015 at 10:43:00AM +0530, Jassi Brar wrote: >> On Mon, Oct 12, 2015 at 10:02 PM, Leo Yan <leo@linaro.org> wrote: >> >> > + >> > +#define MBOX_CHAN_MAX

Re: [PATCH 2/3] mailbox: rockchip: Add Rockchip mailbox driver

On Mon, Sep 14, 2015 at 4:36 PM, Caesar Wang wrote: > This driver is found on RK3368 SoCs. > > The Mailbox module is a simple APB peripheral that allows both > the Cortex-A53 MCU system to communicate by writing operation to > generate interrupt. > The registers are accessible by both CPU via APB

Re: [PATCH 1/3] dt-bindings: Add document of Rockchip mailbox

On Mon, Sep 14, 2015 at 4:36 PM, Caesar Wang wrote: > This add the necessary binding documentation for mailbox > found on RK3368 SoC. > > Signed-off-by: Caesar Wang > --- > > .../bindings/mailbox/rockchip-mailbox.txt | 33 > ++ > 1 file changed, 33 insertions(+) >

Re: [PATCH 1/3] dt-bindings: Add document of Rockchip mailbox

On Mon, Sep 14, 2015 at 4:36 PM, Caesar Wang wrote: > This add the necessary binding documentation for mailbox > found on RK3368 SoC. > > Signed-off-by: Caesar Wang > --- > > .../bindings/mailbox/rockchip-mailbox.txt | 33 >

Re: [PATCH 2/3] mailbox: rockchip: Add Rockchip mailbox driver

On Mon, Sep 14, 2015 at 4:36 PM, Caesar Wang wrote: > This driver is found on RK3368 SoCs. > > The Mailbox module is a simple APB peripheral that allows both > the Cortex-A53 MCU system to communicate by writing operation to > generate interrupt. > The registers are

Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP

On 2 October 2015 at 15:02, Lee Jones wrote: > On Fri, 02 Oct 2015, Jassi Brar wrote: > >> On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones wrote: >> >> >> >> > + >> > +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4)) >>

Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP

On 2 October 2015 at 15:02, Lee Jones <lee.jo...@linaro.org> wrote: > On Fri, 02 Oct 2015, Jassi Brar wrote: > >> On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones <lee.jo...@linaro.org> wrote: >> >> >> >> > + >> > +#define MBOX_BASE

Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP

On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones wrote: > + > +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4)) > It should be(inst) * 4 > +/** > + * STi Mailbox device data > + * > + * An IP Mailbox is currently composed of 4 instances > + * Each instance is currently composed

Re: [PATCH v3 2/5] mailbox: Add support for ST's Mailbox IP

On Wed, Aug 19, 2015 at 7:52 PM, Lee Jones wrote: > + > +#define MBOX_BASE(mdev, inst) ((mdev)->base + (inst * 4)) > It should be(inst) * 4 > +/** > + * STi Mailbox device data > + * > + * An IP Mailbox is currently composed of 4 instances > + * Each instance

Re: [PATCH 0/3] mailbox: rockchip: Add mailbox driver for Rockchip platform

On Sun, Sep 27, 2015 at 7:09 PM, Caesar Wang wrote: > Hello Jassi, > > Friendly Ping! > > Could you review this series patchs if you have free time? > It's been only 2 weeks since you posted the driver and I have been busy with stuff that missed the last release. I did not miss your patchset.

Re: [PATCH 0/3] mailbox: rockchip: Add mailbox driver for Rockchip platform

On Sun, Sep 27, 2015 at 7:09 PM, Caesar Wang wrote: > Hello Jassi, > > Friendly Ping! > > Could you review this series patchs if you have free time? > It's been only 2 weeks since you posted the driver and I have been busy with stuff that missed the last release. I did

[GIT PULL] Mailbox changes for v4.3

Hi Linus, The following changes since commit 4e6b6ee253ce58aa156d7f1448d1038679b26783: Merge tag 'md/4.2-rc5-fixes' of git://neil.brown.name/md (2015-08-05 11:02:42 +0200) are available in the git repository at: http://git.linaro.org/landing-teams/working/fujitsu/integration.git

[GIT PULL] Mailbox changes for v4.3

Hi Linus, The following changes since commit 4e6b6ee253ce58aa156d7f1448d1038679b26783: Merge tag 'md/4.2-rc5-fixes' of git://neil.brown.name/md (2015-08-05 11:02:42 +0200) are available in the git repository at: http://git.linaro.org/landing-teams/working/fujitsu/integration.git

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

On Fri, Aug 14, 2015 at 12:03 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >> >> > + >> > +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) >> > +{ >> > +

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

On Fri, Aug 14, 2015 at 12:03 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: + +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) +{ + struct sti_channel *chan_info

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > + > +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) > +{ > + struct sti_channel *chan_info = chan->con_priv; > + struct sti_mbox_device *mdev = chan_info->mdev; > + unsigned int instance = chan_info->instance; > +

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 6:37 PM, Lee Jones wrote: > > Now just agree with me that mbox_request_chan() should fail on request > of a known bad configuration request and I can code all this up and > re-submit. :D > You make me look like a jerk :( My problem is not with validation as such. I see

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 5:10 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones wrote: >> > On Thu, 13 Aug 2015, Jassi Brar wrote: >> > >> >> On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrot

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrote: >> > On Thu, 13 Aug 2015, Jassi Brar wrote: >> > >> >> On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrot

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: > >> On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrote: >> > On Thu, 13 Aug 2015, Jassi Brar wrote: >> >> >> >> > + >> >> >> &

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones wrote: > On Thu, 13 Aug 2015, Jassi Brar wrote: >> >> > + >> >> > +static void mbox_test_prepare_message(struct mbox_client *client, void >> >> > *message) >> >> > +{ >> >

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Wed, Aug 12, 2015 at 3:53 PM, Lee Jones wrote: > On Mon, 10 Aug 2015, Jassi Brar wrote: > >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >> > This particular Client implementation uses shared memory in order >> > to pass messages between Mailbox us

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Wed, Aug 12, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 10 Aug 2015, Jassi Brar wrote: On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: This particular Client implementation uses shared memory in order to pass messages between Mailbox users

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones lee.jo...@linaro.org wrote

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: + +static void mbox_test_prepare_message(struct mbox_client *client, void *message) +{ + struct mbox_test_device *tdev = dev_get_drvdata(client-dev

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 2:49 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: + +static void mbox_test_prepare_message(struct mbox_client

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 5:10 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 4:30 PM, Lee Jones lee.jo...@linaro.org wrote: On Thu, 13 Aug 2015, Jassi Brar wrote: On Thu, Aug 13, 2015 at 3:53 PM, Lee Jones lee.jo...@linaro.org wrote

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Thu, Aug 13, 2015 at 6:37 PM, Lee Jones lee.jo...@linaro.org wrote: Now just agree with me that mbox_request_chan() should fail on request of a known bad configuration request and I can code all this up and re-submit. :D You make me look like a jerk :( My problem is not with validation

Re: [PATCH v2 3/6] mailbox: Add support for ST's Mailbox IP

On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: + +static bool sti_mbox_tx_is_ready(struct mbox_chan *chan) +{ + struct sti_channel *chan_info = chan-con_priv; + struct sti_mbox_device *mdev = chan_info-mdev; + unsigned int instance =

Re: [PATCH v2 2/6] mailbox: dt-bindings: Add shared [driver <=> device tree] defines

On Wed, Aug 12, 2015 at 2:23 PM, Lee Jones wrote: > On Mon, 10 Aug 2015, Jassi Brar wrote: > >> On Mon, Aug 10, 2015 at 1:54 PM, Lee Jones wrote: >> > On Mon, 10 Aug 2015, Jassi Brar wrote: >> >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >>

Re: [PATCH v2 2/6] mailbox: dt-bindings: Add shared [driver = device tree] defines

On Wed, Aug 12, 2015 at 2:23 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 10 Aug 2015, Jassi Brar wrote: On Mon, Aug 10, 2015 at 1:54 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 10 Aug 2015, Jassi Brar wrote: On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote

Re: [PATCH v2 2/6] mailbox: dt-bindings: Add shared [driver <=> device tree] defines

On Mon, Aug 10, 2015 at 1:54 PM, Lee Jones wrote: > On Mon, 10 Aug 2015, Jassi Brar wrote: >> On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: >> > This header is currently only used for defines pertaining to data >> > direction i.e. Rx, Tx or Loopback. >>

Re: [PATCHv7 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

On Wed, Jul 15, 2015 at 6:30 AM, Moritz Fischer wrote: > + > +static void xilinx_mbox_rx_data(struct mbox_chan *chan) > +{ > + struct xilinx_mbox *mbox = mbox_chan_to_xilinx_mbox(chan); > + u32 data; > + > + if (xilinx_mbox_pending(mbox)) { > + data =

Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver

On Thu, Aug 6, 2015 at 4:47 AM, Leo Yan wrote: > Hi Jassi, > > Thanks for review. > > On Wed, Aug 05, 2015 at 04:22:01PM +0530, Jassi Brar wrote: >> On Mon, Aug 3, 2015 at 6:43 AM, Leo Yan wrote: > > [...] > >> > For easily extending for Hisilico

Re: [PATCH v2 2/6] mailbox: dt-bindings: Add shared [driver <=> device tree] defines

On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > This header is currently only used for defines pertaining to data > direction i.e. Rx, Tx or Loopback. > > Signed-off-by: Lee Jones > --- > include/dt-bindings/mailbox/mailbox.h | 14 ++ > 1 file changed, 14 insertions(+) > create

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones wrote: > This particular Client implementation uses shared memory in order > to pass messages between Mailbox users; however, it can be easily > hacked to support any type of Controller. > > Signed-off-by: Lee Jones > --- > drivers/mailbox/Kconfig

Re: [PATCHv7 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

On Wed, Jul 15, 2015 at 6:30 AM, Moritz Fischer moritz.fisc...@ettus.com wrote: + +static void xilinx_mbox_rx_data(struct mbox_chan *chan) +{ + struct xilinx_mbox *mbox = mbox_chan_to_xilinx_mbox(chan); + u32 data; + + if (xilinx_mbox_pending(mbox)) { +

Re: [PATCH v2 2/6] mailbox: dt-bindings: Add shared [driver = device tree] defines

On Mon, Aug 10, 2015 at 1:54 PM, Lee Jones lee.jo...@linaro.org wrote: On Mon, 10 Aug 2015, Jassi Brar wrote: On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: This header is currently only used for defines pertaining to data direction i.e. Rx, Tx or Loopback. Signed

Re: [PATCH v2 5/6] mailbox: Add generic mechanism for testing Mailbox Controllers

On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: This particular Client implementation uses shared memory in order to pass messages between Mailbox users; however, it can be easily hacked to support any type of Controller. Signed-off-by: Lee Jones lee.jo...@linaro.org

Re: [PATCH v2 2/6] mailbox: dt-bindings: Add shared [driver = device tree] defines

On Mon, Jul 27, 2015 at 3:14 PM, Lee Jones lee.jo...@linaro.org wrote: This header is currently only used for defines pertaining to data direction i.e. Rx, Tx or Loopback. Signed-off-by: Lee Jones lee.jo...@linaro.org --- include/dt-bindings/mailbox/mailbox.h | 14 ++ 1 file

Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver

On Thu, Aug 6, 2015 at 4:47 AM, Leo Yan leo@linaro.org wrote: Hi Jassi, Thanks for review. On Wed, Aug 05, 2015 at 04:22:01PM +0530, Jassi Brar wrote: On Mon, Aug 3, 2015 at 6:43 AM, Leo Yan leo@linaro.org wrote: [...] For easily extending for Hisilicon series SoCs (SoCs may

Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver

On Mon, Aug 3, 2015 at 6:43 AM, Leo Yan wrote: > This patch series is to implement Hisilicon's mailbox driver and enable > the mailbox controller on Hi6220. > Cool. > The Hisilicon mailbox supports up to 32 channels. Each channel is > unidirectional with a maximum message size of 8 words. I/O is

Re: [RFC PATCH 0/3] mailbox: hisilicon: add mailbox driver

On Mon, Aug 3, 2015 at 6:43 AM, Leo Yan leo@linaro.org wrote: This patch series is to implement Hisilicon's mailbox driver and enable the mailbox controller on Hi6220. Cool. The Hisilicon mailbox supports up to 32 channels. Each channel is unidirectional with a maximum message size of 8

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

On Fri, Jul 31, 2015 at 6:38 PM, Sudeep Holla wrote: > > > On 31/07/15 11:43, Sudeep Holla wrote: >> >> >> >> On 31/07/15 11:38, Jassi Brar wrote: >>> >>> On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla >>> wrote: >>>

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla wrote: > > I forgot to mention, we have a the following description in > mbox_client_txdone which is misleading: > > "The client/protocol had received some 'ACK' packet and it notifies the > API that the last packet was sent successfully. This only

Re: [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling

On Fri, Jul 31, 2015 at 3:22 PM, Sudeep Holla wrote: > >>> >>> Again, sorry for misleading comment, we do need hrtimer as replied on >>> scpi thread. Any other concern with this patch ? >>> >> Polling by hrtimers is OK. Not to mean this is the best solution for >> your platform. Please revise the

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

On Fri, Jul 31, 2015 at 6:38 PM, Sudeep Holla sudeep.ho...@arm.com wrote: On 31/07/15 11:43, Sudeep Holla wrote: On 31/07/15 11:38, Jassi Brar wrote: On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla sudeep.ho...@arm.com wrote: I forgot to mention, we have a the following description

Re: [PATCH 1/2] mailbox: switch to hrtimer for tx_complete polling

On Fri, Jul 31, 2015 at 3:22 PM, Sudeep Holla sudeep.ho...@arm.com wrote: Again, sorry for misleading comment, we do need hrtimer as replied on scpi thread. Any other concern with this patch ? Polling by hrtimers is OK. Not to mean this is the best solution for your platform. Please revise

Re: [PATCH v5 2/8] firmware: add support for ARM System Control and Power Interface(SCPI) protocol

On Fri, Jul 31, 2015 at 3:10 PM, Sudeep Holla sudeep.ho...@arm.com wrote: I forgot to mention, we have a the following description in mbox_client_txdone which is misleading: The client/protocol had received some 'ACK' packet and it notifies the API that the last packet was sent successfully.

<    1   2   3   4   5   6   7   8   9   10   >