[PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 589 + include/linux/mailbox.h| 18 ++ include/linux/mailbox_client.h | 48

[PATCHv4 3/5] mailbox: pl320: Introduce common API driver

2014-03-18 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar --- drivers/cpufreq/highbank-cpufreq.c | 24 - drivers/mailbox/Makefile

[PATCHv4 4/5] mailbox: Fix TX completion init

2014-03-18 Thread Jassi Brar
From: LeyFoon Tan For fast TX the complete could be called before being initialized as follows mbox_send_message --> poll_txdone --> tx_tick --> complete(>tx_complete) Init the completion early enough to fix the race. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Brar --- dri

[PATCHv4 0/5] Common Mailbox Framework

2014-03-18 Thread Jassi Brar
Hi, Here is the next revision of Mailbox code. Changes since v3: o Change name of symbols from ipc to mbox o Return real types instead of void * o Align structures o Change some symbol names rxcb -> rx_callback txcb -> tx_done o Added kernel-doc for exported API o Dropped

[PATCHv4 0/5] Common Mailbox Framework

2014-03-18 Thread Jassi Brar
Hi, Here is the next revision of Mailbox code. Changes since v3: o Change name of symbols from ipc to mbox o Return real types instead of void * o Align structures o Change some symbol names rxcb - rx_callback txcb - tx_done o Added kernel-doc for exported API o Dropped

[PATCHv4 3/5] mailbox: pl320: Introduce common API driver

2014-03-18 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/cpufreq/highbank-cpufreq.c | 24

[PATCHv4 4/5] mailbox: Fix TX completion init

2014-03-18 Thread Jassi Brar
Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 79d576e..cdf7d45 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c

[PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 589 + include/linux/mailbox.h| 18 ++ include/linux

[PATCHv4 1/5] mailbox: rename pl320-ipc specific mailbox.h

2014-03-18 Thread Jassi Brar
From: Suman Anna s-a...@ti.com The patch 30058677 ARM / highbank: add support for pl320 IPC added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf

[PATCHv4 5/5] mailbox: Fix deleteing poll timer

2014-03-18 Thread Jassi Brar
From: LeyFoon Tan lftan.li...@gmail.com Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan lftan.li...@gmail.com Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Jassi Brar
On 19 March 2014 09:30, Girish KS girishks2...@gmail.com wrote: On Wed, Mar 19, 2014 at 12:15 AM, Jassi Brar jassisinghb...@gmail.com wrote: +int mbox_send_message(struct mbox_chan *chan, void *mssg) +{ + int t; + + if (!chan || !chan-cl) + return -EINVAL

Re: [PATCHv4 3/5] mailbox: pl320: Introduce common API driver

2014-03-18 Thread Jassi Brar
On 19 March 2014 00:40, Rob Herring robherri...@gmail.com wrote: On Tue, Mar 18, 2014 at 1:45 PM, Jassi Brar jassisinghb...@gmail.com wrote: Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-17 Thread Jassi Brar
On Mon, Mar 17, 2014 at 5:45 PM, Arnd Bergmann wrote: > On Monday 17 March 2014 17:33:59 Girish K S wrote: >> +Samsung Mailbox Driver >> + >> +Required properties: >> +- compatible: Should be one of the following, >> + "samsung,gh7-mailbox" for >> +

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-17 Thread Jassi Brar
On Mon, Mar 17, 2014 at 5:45 PM, Arnd Bergmann a...@arndb.de wrote: On Monday 17 March 2014 17:33:59 Girish K S wrote: +Samsung Mailbox Driver + +Required properties: +- compatible: Should be one of the following, + samsung,gh7-mailbox for +

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-11 Thread Jassi Brar
On 11 March 2014 00:00, Srikanth Thokala wrote: > On Mon, Mar 10, 2014 at 9:30 PM, Jassi Brar wrote: >> On Thu, Mar 6, 2014 at 7:18 PM, Srikanth Thokala wrote: >> >>> +static struct dma_async_tx_descriptor * >>> +xilinx_vdma_dma_prep_i

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-11 Thread Jassi Brar
On 11 March 2014 00:00, Srikanth Thokala stho...@xilinx.com wrote: On Mon, Mar 10, 2014 at 9:30 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Mar 6, 2014 at 7:18 PM, Srikanth Thokala stho...@xilinx.com wrote: +static struct dma_async_tx_descriptor * +xilinx_vdma_dma_prep_interleaved

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-10 Thread Jassi Brar
On Thu, Mar 6, 2014 at 7:18 PM, Srikanth Thokala wrote: > +static struct dma_async_tx_descriptor * > +xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, > +struct dma_interleaved_template *xt, > +unsigned long flags) > +{ > +

Re: [PATCH v4 2/2] dma: Add Xilinx AXI Video Direct Memory Access Engine driver support

2014-03-10 Thread Jassi Brar
On Thu, Mar 6, 2014 at 7:18 PM, Srikanth Thokala stho...@xilinx.com wrote: +static struct dma_async_tx_descriptor * +xilinx_vdma_dma_prep_interleaved(struct dma_chan *dchan, +struct dma_interleaved_template *xt, +unsigned long

Re: [PATCHv3] Generic Mailbox API

2014-03-05 Thread Jassi Brar
On Sun, Feb 16, 2014 at 2:22 AM, Jassi Brar wrote: > Hello, > > Here is what the generic mailbox api looks like after modifications > to make it work with 5 different platforms. > Major feedback from Suman Anna(TI), LeyFoon Tan(Intel), > Craig McGeachie(Broadcom) an

Re: [PATCHv3] Generic Mailbox API

2014-03-05 Thread Jassi Brar
On Sun, Feb 16, 2014 at 2:22 AM, Jassi Brar jassisinghb...@gmail.com wrote: Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan(Intel), Craig McGeachie(Broadcom) and Loic

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-26 Thread Jassi Brar
On 26 February 2014 23:21, Srikanth Thokala wrote: > On Mon, Feb 24, 2014 at 7:39 AM, Jassi Brar > wrote: >> On 21 February 2014 23:37, Srikanth Thokala wrote: >>> On Thu, Feb 20, 2014 at 3:23 PM, Jassi Brar >>> wrote: >>>> On 20 February 2014 14:54,

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-26 Thread Jassi Brar
On 26 February 2014 23:21, Srikanth Thokala stho...@xilinx.com wrote: On Mon, Feb 24, 2014 at 7:39 AM, Jassi Brar jaswinder.si...@linaro.org wrote: On 21 February 2014 23:37, Srikanth Thokala stho...@xilinx.com wrote: On Thu, Feb 20, 2014 at 3:23 PM, Jassi Brar jaswinder.si...@linaro.org

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-23 Thread Jassi Brar
On 21 February 2014 23:37, Srikanth Thokala wrote: > On Thu, Feb 20, 2014 at 3:23 PM, Jassi Brar > wrote: >> On 20 February 2014 14:54, Srikanth Thokala wrote: >>> On Wed, Feb 19, 2014 at 12:33 AM, Jassi Brar >>> wrote: >>>> On 18 February 2014 23:16,

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-23 Thread Jassi Brar
On 21 February 2014 23:37, Srikanth Thokala stho...@xilinx.com wrote: On Thu, Feb 20, 2014 at 3:23 PM, Jassi Brar jaswinder.si...@linaro.org wrote: On 20 February 2014 14:54, Srikanth Thokala stho...@xilinx.com wrote: On Wed, Feb 19, 2014 at 12:33 AM, Jassi Brar jaswinder.si...@linaro.org

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-20 Thread Jassi Brar
On 20 February 2014 14:54, Srikanth Thokala wrote: > On Wed, Feb 19, 2014 at 12:33 AM, Jassi Brar > wrote: >> On 18 February 2014 23:16, Srikanth Thokala wrote: >>> On Tue, Feb 18, 2014 at 10:20 PM, Jassi Brar >>> wrote: >>>> On 18 February 2014 16

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-20 Thread Jassi Brar
On 20 February 2014 14:54, Srikanth Thokala stho...@xilinx.com wrote: On Wed, Feb 19, 2014 at 12:33 AM, Jassi Brar jaswinder.si...@linaro.org wrote: On 18 February 2014 23:16, Srikanth Thokala stho...@xilinx.com wrote: On Tue, Feb 18, 2014 at 10:20 PM, Jassi Brar jaswinder.si...@linaro.org

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-19 Thread Jassi Brar
On 19 February 2014 01:17, Courtney Cavin wrote: > On Tue, Feb 18, 2014 at 08:06:55AM +0100, Jassi Brar wrote: >> >> >> +void *ipc_request_channel(struct ipc_client *cl) >> >> +{ > [...] >> >> + spin_lock_irqsave(>lock, f

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-19 Thread Jassi Brar
Hi Kumar, On 19 February 2014 03:02, Kumar Gala wrote: > > On Feb 15, 2014, at 12:25 PM, Jassi Brar wrote: > >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client dri

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-19 Thread Jassi Brar
Hi Kumar, On 19 February 2014 03:02, Kumar Gala ga...@codeaurora.org wrote: On Feb 15, 2014, at 12:25 PM, Jassi Brar jassisinghb...@gmail.com wrote: Introduce common framework for client/protocol drivers and controller drivers of Inter-Processor-Communication (IPC). Client driver

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-19 Thread Jassi Brar
On 19 February 2014 01:17, Courtney Cavin courtney.ca...@sonymobile.com wrote: On Tue, Feb 18, 2014 at 08:06:55AM +0100, Jassi Brar wrote: +void *ipc_request_channel(struct ipc_client *cl) +{ [...] + spin_lock_irqsave(chan-lock, flags); + chan

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-18 Thread Jassi Brar
On 18 February 2014 23:16, Srikanth Thokala wrote: > On Tue, Feb 18, 2014 at 10:20 PM, Jassi Brar > wrote: >> On 18 February 2014 16:58, Srikanth Thokala wrote: >>> On Mon, Feb 17, 2014 at 3:27 PM, Jassi Brar >>> wrote: >>>> On 15 Fe

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-18 Thread Jassi Brar
On Tue, Feb 18, 2014 at 11:00 PM, Bjorn Andersson wrote: > On Mon, Feb 17, 2014 at 11:06 PM, Jassi Brar > wrote: >> Hi Courtney, >> >> On 18 February 2014 06:22, Courtney Cavin >> wrote: >>> On Sat, Feb 15, 2014 at 07:25:27PM +0100, Jassi Brar

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-18 Thread Jassi Brar
On 18 February 2014 16:58, Srikanth Thokala wrote: > On Mon, Feb 17, 2014 at 3:27 PM, Jassi Brar > wrote: >> On 15 February 2014 17:30, Srikanth Thokala wrote: >>> The current implementation of interleaved DMA API support multiple >>> frames only when the memory

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-18 Thread Jassi Brar
On 18 February 2014 16:58, Srikanth Thokala stho...@xilinx.com wrote: On Mon, Feb 17, 2014 at 3:27 PM, Jassi Brar jaswinder.si...@linaro.org wrote: On 15 February 2014 17:30, Srikanth Thokala stho...@xilinx.com wrote: The current implementation of interleaved DMA API support multiple frames

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-18 Thread Jassi Brar
On Tue, Feb 18, 2014 at 11:00 PM, Bjorn Andersson bj...@kryo.se wrote: On Mon, Feb 17, 2014 at 11:06 PM, Jassi Brar jaswinder.si...@linaro.org wrote: Hi Courtney, On 18 February 2014 06:22, Courtney Cavin courtney.ca...@sonymobile.com wrote: On Sat, Feb 15, 2014 at 07:25:27PM +0100, Jassi

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-18 Thread Jassi Brar
On 18 February 2014 23:16, Srikanth Thokala stho...@xilinx.com wrote: On Tue, Feb 18, 2014 at 10:20 PM, Jassi Brar jaswinder.si...@linaro.org wrote: On 18 February 2014 16:58, Srikanth Thokala stho...@xilinx.com wrote: On Mon, Feb 17, 2014 at 3:27 PM, Jassi Brar jaswinder.si...@linaro.org

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-17 Thread Jassi Brar
Hi Courtney, On 18 February 2014 06:22, Courtney Cavin wrote: > On Sat, Feb 15, 2014 at 07:25:27PM +0100, Jassi Brar wrote: >> +request_token_t ipc_send_message(void *channel, void *mssg) >> +{ >> + struct ipc_chan *chan = (struct ipc_chan *)channel; >>

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-17 Thread Jassi Brar
On 15 February 2014 17:30, Srikanth Thokala wrote: > The current implementation of interleaved DMA API support multiple > frames only when the memory is contiguous by incrementing src_start/ > dst_start members of interleaved template. > > But, when the memory is non-contiguous it will restrict

Re: [PATCH v3 1/3] dma: Support multiple interleaved frames with non-contiguous memory

2014-02-17 Thread Jassi Brar
On 15 February 2014 17:30, Srikanth Thokala stho...@xilinx.com wrote: The current implementation of interleaved DMA API support multiple frames only when the memory is contiguous by incrementing src_start/ dst_start members of interleaved template. But, when the memory is non-contiguous it

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-17 Thread Jassi Brar
Hi Courtney, On 18 February 2014 06:22, Courtney Cavin courtney.ca...@sonymobile.com wrote: On Sat, Feb 15, 2014 at 07:25:27PM +0100, Jassi Brar wrote: +request_token_t ipc_send_message(void *channel, void *mssg) +{ + struct ipc_chan *chan = (struct ipc_chan *)channel

Re: [PATCHv3] Generic Mailbox API

2014-02-16 Thread Jassi Brar
On Mon, Feb 17, 2014 at 11:33 AM, Craig McGeachie wrote: > On 16/02/14 07:22, Jassi Brar wrote: >> >> Hello, >> >>Here is what the generic mailbox api looks like after modifications >> to make it work with 5 different platforms. >> Major feedback

Re: [PATCHv3] Generic Mailbox API

2014-02-16 Thread Jassi Brar
On 17 February 2014 11:27, Craig McGeachie wrote: > On 16/02/14 07:22, Jassi Brar wrote: >> >> Hello, >> >>Here is what the generic mailbox api looks like after modifications >> to make it work with 5 different platforms. >> Major feedback from Suman

Re: [PATCHv3] Generic Mailbox API

2014-02-16 Thread Jassi Brar
On 17 February 2014 11:27, Craig McGeachie slap...@yahoo.com.au wrote: On 16/02/14 07:22, Jassi Brar wrote: Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan(Intel

Re: [PATCHv3] Generic Mailbox API

2014-02-16 Thread Jassi Brar
On Mon, Feb 17, 2014 at 11:33 AM, Craig McGeachie slap...@yahoo.com.au wrote: On 16/02/14 07:22, Jassi Brar wrote: Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan

Re: [PATCHv3 6/6] mailbox: move the internal definitions into a private file

2014-02-15 Thread Jassi Brar
On Sun, Feb 16, 2014 at 12:46 AM, Greg KH wrote: > On Sat, Feb 15, 2014 at 11:57:02PM +0530, Jassi Brar wrote: >> From: Suman Anna >> >> This is needed for extracting the omap_mbox. The OMAP mailbox >> code has a need for exporting some pre-existing API to not &

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-15 Thread Jassi Brar
[merging replies in one post] On Sun, Feb 16, 2014 at 12:45 AM, Greg KH wrote: > On Sat, Feb 15, 2014 at 11:55:27PM +0530, Jassi Brar wrote: >> +/* >> + * Call for IPC controller drivers to register a controller, adding >> + * its channels/mailboxes to the global

[PATCHv3 5/6] mailbox: Fix deleteing poll timer

2014-02-15 Thread Jassi Brar
From: LeyFoon Tan Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Brar --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index f8b31da

[PATCHv3 6/6] mailbox: move the internal definitions into a private file

2014-02-15 Thread Jassi Brar
From: Suman Anna This is needed for extracting the omap_mbox. The OMAP mailbox code has a need for exporting some pre-existing API to not break the current clients. Signed-off-by: Suman Anna --- drivers/mailbox/mailbox.c | 62 +-

[PATCHv3 3/6] mailbox: pl320: Introduce common API driver

2014-02-15 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar --- drivers/cpufreq/highbank-cpufreq.c | 22 +++- drivers/mailbox/Makefile

[PATCHv3 4/6] mailbox: Fix TX completion init

2014-02-15 Thread Jassi Brar
From: LeyFoon Tan For fast TX the complete could be called before being initialized as follows ipc_send_message --> poll_txdone --> tx_tick --> complete(>tx_complete) Init the completion early enough to fix the race. Signed-off-by: LeyFoon Tan Signed-off-by: Jassi Brar --- dri

[PATCHv3 1/6] mailbox: rename pl320-ipc specific mailbox.h

2014-02-15 Thread Jassi Brar
From: Suman Anna The patch 30058677 "ARM / highbank: add support for pl320 IPC" added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf Cc: Rafael J. Wysocki

[PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-15 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 534 + include/linux/mailbox.h| 17 ++ include/linux/mailbox_client.h | 87

[PATCHv3] Generic Mailbox API

2014-02-15 Thread Jassi Brar
Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan(Intel), Craig McGeachie(Broadcom) and Loic Pallardy(ST). Signed-off-by: Jassi Brar -- To unsubscribe from this list: send

[PATCHv3] Generic Mailbox API

2014-02-15 Thread Jassi Brar
Hello, Here is what the generic mailbox api looks like after modifications to make it work with 5 different platforms. Major feedback from Suman Anna(TI), LeyFoon Tan(Intel), Craig McGeachie(Broadcom) and Loic Pallardy(ST). Signed-off-by: Jassi Brar jaswinder.si...@linaro.org

[PATCHv3 1/6] mailbox: rename pl320-ipc specific mailbox.h

2014-02-15 Thread Jassi Brar
From: Suman Anna s-a...@ti.com The patch 30058677 ARM / highbank: add support for pl320 IPC added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf

[PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-15 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/Makefile | 4 + drivers/mailbox/mailbox.c | 534 + include/linux/mailbox.h| 17 ++ include/linux

[PATCHv3 4/6] mailbox: Fix TX completion init

2014-02-15 Thread Jassi Brar
Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index 3082f08..f8b31da 100644 --- a/drivers/mailbox/mailbox.c +++ b/drivers/mailbox/mailbox.c

[PATCHv3 3/6] mailbox: pl320: Introduce common API driver

2014-02-15 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/cpufreq/highbank-cpufreq.c | 22

[PATCHv3 6/6] mailbox: move the internal definitions into a private file

2014-02-15 Thread Jassi Brar
From: Suman Anna s-a...@ti.com This is needed for extracting the omap_mbox. The OMAP mailbox code has a need for exporting some pre-existing API to not break the current clients. Signed-off-by: Suman Anna s-a...@ti.com --- drivers/mailbox/mailbox.c | 62 +-

[PATCHv3 5/6] mailbox: Fix deleteing poll timer

2014-02-15 Thread Jassi Brar
From: LeyFoon Tan lftan.li...@gmail.com Try to delete the timer only if it was init/used. Signed-off-by: LeyFoon Tan lftan.li...@gmail.com Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/mailbox.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCHv3 2/6] mailbox: Introduce a new common API

2014-02-15 Thread Jassi Brar
[merging replies in one post] On Sun, Feb 16, 2014 at 12:45 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 11:55:27PM +0530, Jassi Brar wrote: +/* + * Call for IPC controller drivers to register a controller, adding + * its channels/mailboxes to the global pool

Re: [PATCHv3 6/6] mailbox: move the internal definitions into a private file

2014-02-15 Thread Jassi Brar
On Sun, Feb 16, 2014 at 12:46 AM, Greg KH gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 11:57:02PM +0530, Jassi Brar wrote: From: Suman Anna s-a...@ti.com This is needed for extracting the omap_mbox. The OMAP mailbox code has a need for exporting some pre-existing API

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
On 15 February 2014 09:41, Greg Kroah-Hartman wrote: > On Sat, Feb 15, 2014 at 09:27:48AM +0530, Jassi Brar wrote: >> On 15 February 2014 09:10, Greg Kroah-Hartman >> wrote: >> > On Sat, Feb 15, 2014 at 09:02:07AM +0530, Jassi Brar wrote: >> >> Hi, >> &

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
On 15 February 2014 09:10, Greg Kroah-Hartman wrote: > On Sat, Feb 15, 2014 at 09:02:07AM +0530, Jassi Brar wrote: >> Hi, >> >> On 8 February 2014 06:20, Courtney Cavin >> wrote: >> > There is currently no common framework for mailbox drivers, s

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
Hi, On 8 February 2014 06:20, Courtney Cavin wrote: > There is currently no common framework for mailbox drivers, so this is my > attempt to come up with something suitable. There seems to be a need for > making this generic, so I have attempted to do just that. Most of this is > modeled

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
Hi, On 8 February 2014 06:20, Courtney Cavin courtney.ca...@sonymobile.com wrote: There is currently no common framework for mailbox drivers, so this is my attempt to come up with something suitable. There seems to be a need for making this generic, so I have attempted to do just that. Most

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
On 15 February 2014 09:10, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 09:02:07AM +0530, Jassi Brar wrote: Hi, On 8 February 2014 06:20, Courtney Cavin courtney.ca...@sonymobile.com wrote: There is currently no common framework for mailbox drivers, so

Re: [RFC 0/6] mailbox: add common framework and port drivers

2014-02-14 Thread Jassi Brar
On 15 February 2014 09:41, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 09:27:48AM +0530, Jassi Brar wrote: On 15 February 2014 09:10, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Sat, Feb 15, 2014 at 09:02:07AM +0530, Jassi Brar wrote: Hi

Re: [PATCH] dma: pl330: ensure DMA descriptors are zero-initialised

2013-11-29 Thread Jassi Brar
ro-initialised during allocation and > remove the dummy, per-field initialisation. > > Cc: Jassi Brar > Cc: Vinod Koul > Cc: Dan Williams > Signed-off-by: Will Deacon > --- > drivers/dma/pl330.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > di

Re: [PATCH] dma: pl330: ensure DMA descriptors are zero-initialised

2013-11-29 Thread Jassi Brar
initialisation. Cc: Jassi Brar jaswinder.si...@linaro.org Cc: Vinod Koul vinod.k...@intel.com Cc: Dan Williams dan.j.willi...@intel.com Signed-off-by: Will Deacon will.dea...@arm.com --- drivers/dma/pl330.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/dma

Re: linux-next: manual merge of the arm-soc tree with the mailbox tree

2013-06-21 Thread Jassi Brar
On 21 June 2013 12:42, Tony Lindgren wrote: > > Arnd pulled in tags/omap-for-v3.11/mailbox-signed, which is the branch > that should get merged to the mainline tree while we're waiting for > the generic mailbox framework from Jassi. > FYKI I, Suman and Loic have been co-ordinating offline. The

Re: linux-next: manual merge of the arm-soc tree with the mailbox tree

2013-06-21 Thread Jassi Brar
On 21 June 2013 12:42, Tony Lindgren t...@atomide.com wrote: Arnd pulled in tags/omap-for-v3.11/mailbox-signed, which is the branch that should get merged to the mainline tree while we're waiting for the generic mailbox framework from Jassi. FYKI I, Suman and Loic have been co-ordinating

Re: [PATCH] ARM: tegra: add basic SecureOS support

2013-06-07 Thread Jassi Brar
On Fri, Jun 7, 2013 at 12:43 PM, Alexandre Courbot wrote: > On Thu, Jun 6, 2013 at 9:26 PM, Jassi Brar wrote: >> On Thu, Jun 6, 2013 at 12:58 PM, Alexandre Courbot >> wrote: >>> Boot loaders on some Tegra devices can be unlocked but do not let the >>> system o

Re: [PATCH] ARM: tegra: add basic SecureOS support

2013-06-07 Thread Jassi Brar
On Fri, Jun 7, 2013 at 12:43 PM, Alexandre Courbot gnu...@gmail.com wrote: On Thu, Jun 6, 2013 at 9:26 PM, Jassi Brar jassisinghb...@gmail.com wrote: On Thu, Jun 6, 2013 at 12:58 PM, Alexandre Courbot acour...@nvidia.com wrote: Boot loaders on some Tegra devices can be unlocked but do not let

Re: [PATCH] ARM: tegra: add basic SecureOS support

2013-06-06 Thread Jassi Brar
On Thu, Jun 6, 2013 at 12:58 PM, Alexandre Courbot wrote: > Boot loaders on some Tegra devices can be unlocked but do not let the > system operate without SecureOS. SecureOS prevents access to some > registers and requires the operating system to perform certain > operations through Secure

Re: [PATCH] ARM: tegra: add basic SecureOS support

2013-06-06 Thread Jassi Brar
On Thu, Jun 6, 2013 at 12:58 PM, Alexandre Courbot acour...@nvidia.com wrote: Boot loaders on some Tegra devices can be unlocked but do not let the system operate without SecureOS. SecureOS prevents access to some registers and requires the operating system to perform certain operations

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-10 Thread Jassi Brar
Hello Suman, On 10 May 2013 05:48, Suman Anna wrote: >> No, please. The controller driver should not implement any policy (of >> allowing/disallowing requests). It should simply try to do as >> directed. If the client screwed up even after getting info from >> platform_data/DT, let it suffer. >

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-10 Thread Jassi Brar
Hello Suman, On 10 May 2013 05:48, Suman Anna s-a...@ti.com wrote: No, please. The controller driver should not implement any policy (of allowing/disallowing requests). It should simply try to do as directed. If the client screwed up even after getting info from platform_data/DT, let it

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
On 9 May 2013 23:35, Suman Anna wrote: >> >> Perhaps we should change the following >> >>void ipc_link_txdone(struct ipc_link *link, enum xfer_result r) >> to >>void ipc_link_txdone(struct ipc_link *link, enum xfer_result r, void >> *data) >> >> So that the API could pass that onto

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
On Thu, May 9, 2013 at 10:10 PM, Suman Anna wrote: > On 05/09/2013 11:41 AM, Jassi Brar wrote: >> On 9 May 2013 22:01, Suman Anna wrote: >>> Hi Jassi, >>> >>> On 05/06/2013 02:24 AM, Jassi Brar wrote: >>>> +++ b/include/linux/mailbox_client.h >

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
On 9 May 2013 22:01, Suman Anna wrote: > Hi Jassi, > > On 05/06/2013 02:24 AM, Jassi Brar wrote: >> +++ b/include/linux/mailbox_client.h >> @@ -0,0 +1,85 @@ >> +/* >> + * This program is free software; you can redistribute it and/or modify >> + * it un

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
Hi Suman, On 9 May 2013 06:55, Suman Anna wrote: >> so it can't be driven by the controller. We could make it a Kconfig option. >> What do you suggest? > > I am saying controller/link because they are the ones that knows how the > physical transport is, and it may vary from one to another. I

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
Hi Suman, On 9 May 2013 06:55, Suman Anna s-a...@ti.com wrote: so it can't be driven by the controller. We could make it a Kconfig option. What do you suggest? I am saying controller/link because they are the ones that knows how the physical transport is, and it may vary from one to

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
On 9 May 2013 22:01, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 05/06/2013 02:24 AM, Jassi Brar wrote: +++ b/include/linux/mailbox_client.h @@ -0,0 +1,85 @@ +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
On Thu, May 9, 2013 at 10:10 PM, Suman Anna s-a...@ti.com wrote: On 05/09/2013 11:41 AM, Jassi Brar wrote: On 9 May 2013 22:01, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 05/06/2013 02:24 AM, Jassi Brar wrote: +++ b/include/linux/mailbox_client.h @@ -0,0 +1,85 @@ +/* + * This program

Re: [PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-09 Thread Jassi Brar
On 9 May 2013 23:35, Suman Anna s-a...@ti.com wrote: Perhaps we should change the following void ipc_link_txdone(struct ipc_link *link, enum xfer_result r) to void ipc_link_txdone(struct ipc_link *link, enum xfer_result r, void *data) So that the API could pass that onto clients ?

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-07 Thread Jassi Brar
On 8 May 2013 03:18, Suman Anna wrote: > Hi Jassi, > >> On 7 May 2013 05:15, Suman Anna wrote: The client(s) can always generate TX requests at a rate greater than the API could transmit on the physical link. So as much as we dislike it, we have to buffer TX requests,

Re: [PATCHv2 3/4] mailbox: pl320: Introduce common API driver

2013-05-07 Thread Jassi Brar
On 7 May 2013 07:28, Rob Herring wrote: > On 05/06/2013 02:24 AM, Jassi Brar wrote: >> Convert the PL320 controller driver to work with the common >> mailbox API. Also convert the only user of PL320, highbank-cpufreq.c >> to work with thee API. Drop the obsoleted driver pl3

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-07 Thread Jassi Brar
Hi Suman, On 7 May 2013 05:15, Suman Anna wrote: >> >> The client(s) can always generate TX requests at a rate greater than >> the API could transmit on the physical link. So as much as we dislike >> it, we have to buffer TX requests, otherwise N clients would. > > The current code doesn't

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-07 Thread Jassi Brar
Hi Suman, On 7 May 2013 05:15, Suman Anna s-a...@ti.com wrote: The client(s) can always generate TX requests at a rate greater than the API could transmit on the physical link. So as much as we dislike it, we have to buffer TX requests, otherwise N clients would. The current code doesn't

Re: [PATCHv2 3/4] mailbox: pl320: Introduce common API driver

2013-05-07 Thread Jassi Brar
On 7 May 2013 07:28, Rob Herring robherri...@gmail.com wrote: On 05/06/2013 02:24 AM, Jassi Brar wrote: Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c

Re: [RFC 2/3] mailbox: Introduce a new common API

2013-05-07 Thread Jassi Brar
On 8 May 2013 03:18, Suman Anna s-a...@ti.com wrote: Hi Jassi, On 7 May 2013 05:15, Suman Anna s-a...@ti.com wrote: The client(s) can always generate TX requests at a rate greater than the API could transmit on the physical link. So as much as we dislike it, we have to buffer TX requests,

[PATCHv2 4/4] mailbox: omap2: Introduce common API driver

2013-05-06 Thread Jassi Brar
A new driver conforming to the common API. Signed-off-by: Jassi Brar --- arch/arm/mach-omap2/omap_hwmod_2420_data.c | 12 + arch/arm/mach-omap2/omap_hwmod_2430_data.c | 11 + arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 11 + arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 13 + drivers

[PATCHv2 3/4] mailbox: pl320: Introduce common API driver

2013-05-06 Thread Jassi Brar
Convert the PL320 controller driver to work with the common mailbox API. Also convert the only user of PL320, highbank-cpufreq.c to work with thee API. Drop the obsoleted driver pl320-ipc.c Signed-off-by: Jassi Brar --- drivers/cpufreq/highbank-cpufreq.c | 22 +++- drivers/mailbox/Makefile

[PATCHv2 1/4] mailbox: rename pl320-ipc specific mailbox.h

2013-05-06 Thread Jassi Brar
From: Suman Anna The patch 30058677 "ARM / highbank: add support for pl320 IPC" added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf Cc: Rafael J. Wysocki

[PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-06 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar --- drivers/mailbox/Makefile |4 + drivers/mailbox/mailbox.c | 494 include/linux/mailbox.h| 17 ++ include/linux/mailbox_client.h

[PATCHv2 0/4] mailbox: Common API

2013-05-06 Thread Jassi Brar
Hello, I have made the implementation look more proper. Also made some changes suggested by Suman. Changes since V1: * Delete timer upon mailbox release * Filled in the stub ipc_links_unregister() * Check kzalloc return for errors. * Add the controller driver for OMAP2 class. I have taken the

[PATCHv2 0/4] mailbox: Common API

2013-05-06 Thread Jassi Brar
Hello, I have made the implementation look more proper. Also made some changes suggested by Suman. Changes since V1: * Delete timer upon mailbox release * Filled in the stub ipc_links_unregister() * Check kzalloc return for errors. * Add the controller driver for OMAP2 class. I have taken the

[PATCHv2 1/4] mailbox: rename pl320-ipc specific mailbox.h

2013-05-06 Thread Jassi Brar
From: Suman Anna s-a...@ti.com The patch 30058677 ARM / highbank: add support for pl320 IPC added a pl320 IPC specific header file as a generic mailbox.h. This file has been renamed appropriately to allow the introduction of the generic mailbox API framework. Acked-by: Mark Langsdorf

[PATCHv2 2/4] mailbox: Introduce a new common API

2013-05-06 Thread Jassi Brar
should have a look at include/linux/mailbox_controller.h Signed-off-by: Jassi Brar jaswinder.si...@linaro.org --- drivers/mailbox/Makefile |4 + drivers/mailbox/mailbox.c | 494 include/linux/mailbox.h| 17 ++ include/linux

<    5   6   7   8   9   10   11   >