Drop the header and numbering of types. This format was confusing as
it suggested one could pass the number instead of the type name,
however it did not actually work, and numbering wasn't stable anyway.
Signed-off-by: Jean Delvare
Cc: Andy Whitcroft
Cc: Joe Perches
---
scripts/checkpatch.pl
On Sat, 02 Sep 2017 15:58:05 -0700, Joe Perches wrote:
> On Sat, 2017-09-02 at 23:03 +0200, Jean Delvare wrote:
> > Oh, btw, is there any purpose in listing a number in front of each
> > type?
>
> Not really. I did that because I wanted a header
> and because I had n
On Sat, 02 Sep 2017 15:58:05 -0700, Joe Perches wrote:
> On Sat, 2017-09-02 at 23:03 +0200, Jean Delvare wrote:
> > Oh, btw, is there any purpose in listing a number in front of each
> > type?
>
> Not really. I did that because I wanted a header
> and because I had n
the output and simply print the list of type names?
Thanks,
--
Jean Delvare
SUSE L3 Support
the output and simply print the list of type names?
Thanks,
--
Jean Delvare
SUSE L3 Support
Hi Joe,
On Sat, 02 Sep 2017 09:25:29 -0700, Joe Perches wrote:
> On Sat, 2017-09-02 at 17:51 +0200, Jean Delvare wrote:
> > [PATCH 1/3] checkpatch: fix typo in comment
> > [PATCH 2/3] checkpatch: rename variables to avoid confusion
> > [PATCH 3/3] checkpatch: add 6 missing
Hi Joe,
On Sat, 02 Sep 2017 09:25:29 -0700, Joe Perches wrote:
> On Sat, 2017-09-02 at 17:51 +0200, Jean Delvare wrote:
> > [PATCH 1/3] checkpatch: fix typo in comment
> > [PATCH 2/3] checkpatch: rename variables to avoid confusion
> > [PATCH 3/3] checkpatch: add 6 missing
and AVOID_BUG
are passed with a variable level, causing the parser to miss them
too.
So modify the regex to also catch these special cases.
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Fixes: 3beb42eced39 ("checkpatch: add --list-types to show message types to
show or ignore")
Cc
and AVOID_BUG
are passed with a variable level, causing the parser to miss them
too.
So modify the regex to also catch these special cases.
Signed-off-by: Jean Delvare
Fixes: 3beb42eced39 ("checkpatch: add --list-types to show message types to
show or ignore")
Cc: Andy Whitcroft
Cc: J
The variable name "$msg_type" is sometimes used to set the message
type, and sometimes used to set the message level. This works but is
kind of confusing. Use "$msg_level" in the latter case instead, to
make the code clearer.
Signed-off-by: Jean Delvare <jdelv...@suse
The variable name "$msg_type" is sometimes used to set the message
type, and sometimes used to set the message level. This works but is
kind of confusing. Use "$msg_level" in the latter case instead, to
make the code clearer.
Signed-off-by: Jean Delvare
Cc: Andy Whitcr
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Cc: Andy Whitcroft <a...@canonical.com>
Cc: Joe Perches <j...@perches.com>
---
scripts/checkpatch.pl |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-4.13-rc7.orig/scripts/checkpatch.pl 2017-07-30 21:40:3
Signed-off-by: Jean Delvare
Cc: Andy Whitcroft
Cc: Joe Perches
---
scripts/checkpatch.pl |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-4.13-rc7.orig/scripts/checkpatch.pl 2017-07-30 21:40:36.0
+0200
+++ linux-4.13-rc7/scripts/checkpatch.pl2017-09-01 15
[PATCH 1/3] checkpatch: fix typo in comment
[PATCH 2/3] checkpatch: rename variables to avoid confusion
[PATCH 3/3] checkpatch: add 6 missing types to --list-types
---
scripts/checkpatch.pl | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
--
Jean
[PATCH 1/3] checkpatch: fix typo in comment
[PATCH 2/3] checkpatch: rename variables to avoid confusion
[PATCH 3/3] checkpatch: add 6 missing types to --list-types
---
scripts/checkpatch.pl | 37 +++--
1 file changed, 19 insertions(+), 18 deletions(-)
--
Jean
nux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
--
Jean Delvare
SUSE L3 Support
nux-next is concerned, but any non trivial
> conflicts should be mentioned to your upstream maintainer when your tree
> is submitted for merging. You may also want to consider cooperating
> with the maintainer of the conflicting tree to minimise any particularly
> complex conflicts.
--
Jean Delvare
SUSE L3 Support
On mer., 2017-08-09 at 09:18 -0700, Matt Roper wrote:
> On Mon, Jul 31, 2017 at 10:36:05AM +0200, Jean Delvare wrote:
> >
> > Hi Matt, Mauro,
> >
> > On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote:
> > >
> > > On Tue,
On mer., 2017-08-09 at 09:18 -0700, Matt Roper wrote:
> On Mon, Jul 31, 2017 at 10:36:05AM +0200, Jean Delvare wrote:
> >
> > Hi Matt, Mauro,
> >
> > On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote:
> > >
> > > On Tue,
= { .attrs = in5_attrs };
> +static const struct attribute_group vid_attr_group = { .attrs = vid_attrs };
>
> static int adt7475_detect(struct i2c_client *client,
> struct i2c_board_info *info)
Looks good to me.
Reviewed-by: Jean Delvare <jdelv...@suse.de>
--
Jean Delvare
SUSE L3 Support
const struct attribute_group vid_attr_group = { .attrs = vid_attrs };
>
> static int adt7475_detect(struct i2c_client *client,
> struct i2c_board_info *info)
Looks good to me.
Reviewed-by: Jean Delvare
--
Jean Delvare
SUSE L3 Support
t; ---
> drivers/misc/ds1682.c | 2 +-
> drivers/misc/eeprom/eeprom.c | 2 +-
> drivers/misc/eeprom/max6875.c | 2 +-
> drivers/misc/pch_phub.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
> (...)
Reviewed-by: Jean Delvare <jdelv...@suse.de>
Thanks,
--
Jean Delvare
SUSE L3 Support
ds1682.c | 2 +-
> drivers/misc/eeprom/eeprom.c | 2 +-
> drivers/misc/eeprom/max6875.c | 2 +-
> drivers/misc/pch_phub.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
> (...)
Reviewed-by: Jean Delvare
Thanks,
--
Jean Delvare
SUSE L3 Support
my area, but after
a quick look at the code I strongly suspect this is not the case.
> > Fixes: ea8b1c4a6019 ("drivers: psci: PSCI checker module")
> > Signed-off-by: Arnd Bergmann <a...@arndb.de>
>
> Acked-by: Kevin Brodsky <kevin.brod...@arm.com>
Reviewed-by: Jean Delvare <jdelv...@suse.de>
--
Jean Delvare
SUSE L3 Support
my area, but after
a quick look at the code I strongly suspect this is not the case.
> > Fixes: ea8b1c4a6019 ("drivers: psci: PSCI checker module")
> > Signed-off-by: Arnd Bergmann
>
> Acked-by: Kevin Brodsky
Reviewed-by: Jean Delvare
--
Jean Delvare
SUSE L3 Support
Hi Matt, Mauro,
On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote:
> On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote:
> > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for
> > decoding DMI memory device entries. Move the structure definition
Hi Matt, Mauro,
On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote:
> On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote:
> > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for
> > decoding DMI memory device entries. Move the structure definition
en/htcpen.c, I'll take care of that.
Lastly checkpatch complains about the position of __initconst on 18
instances, I'll fix that as well.
Thanks,
--
Jean Delvare
SUSE L3 Support
en/htcpen.c, I'll take care of that.
Lastly checkpatch complains about the position of __initconst on 18
instances, I'll fix that as well.
Thanks,
--
Jean Delvare
SUSE L3 Support
("DMI: Introduce dmi_first_match to make the interface
more flexible").
* Don't check for the exact_match flag again when we already know its
value.
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Daniel Vetter <daniel.vet
("DMI: Introduce dmi_first_match to make the interface
more flexible").
* Don't check for the exact_match flag again when we already know its
value.
Signed-off-by: Jean Delvare
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Rafael J. Wysocki
Cc: Jeff Garzik
---
Regarding dmi_initialize
mediatek.com>
> Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
> Reviewed-by: Jean Delvare <jdelv...@suse.de>
Confirmed, looks good to me.
Thanks,
--
Jean Delvare
SUSE L3 Support
with operating-points-v2
> bindings. Also, this driver actually supports all MediaTek SoCs, the
> Kconfig menu entry and file name itself should be updated with more
> generic name to drop "MT8173"
>
> Signed-off-by: Sean Wang
> Acked-by: Viresh Kumar
> Reviewed-
. I'm not going to send any patch to rename any of these
drivers, as I have many tasks of higher priority on my own plate. And I
agree that renaming existing drivers does have a cost as well. So
whatever is decided is fine with me, really.
--
Jean Delvare
SUSE L3 Support
. I'm not going to send any patch to rename any of these
drivers, as I have many tasks of higher priority on my own plate. And I
agree that renaming existing drivers does have a cost as well. So
whatever is decided is fine with me, really.
--
Jean Delvare
SUSE L3 Support
= {
>
> /* List of machines supported by this driver */
> static const struct of_device_id mt8173_cpufreq_machines[] __initconst = {
> + { .compatible = "mediatek,mt2701", },
> + { .compatible = "mediatek,mt7623", },
> { .compatible = "mediatek,mt817x", },
> { .compatible = "mediatek,mt8173", },
> { .compatible = "mediatek,mt8176", },
Reviewed-by: Jean Delvare <jdelv...@suse.de>
--
Jean Delvare
SUSE L3 Support
mt8173_cpufreq_machines[] __initconst = {
> + { .compatible = "mediatek,mt2701", },
> + { .compatible = "mediatek,mt7623", },
> { .compatible = "mediatek,mt817x", },
> { .compatible = "mediatek,mt8173", },
> { .compatible = "mediatek,mt8176", },
Reviewed-by: Jean Delvare
--
Jean Delvare
SUSE L3 Support
es. If you just do what libsensors does, you'll be
on the safe side.
--
Jean Delvare
SUSE L3 Support
es. If you just do what libsensors does, you'll be
on the safe side.
--
Jean Delvare
SUSE L3 Support
| 2 +-
3 files changed, 40 insertions(+), 15 deletions(-)
---
Andy Lutomirski (1):
firmware: dmi_scan: Make dmi_walk and dmi_walk_early return real error
codes
Jean Delvare (3):
firmware: dmi_scan: Look for SMBIOS 3 entry point first
firmware: dmi: Fix permissions
| 2 +-
3 files changed, 40 insertions(+), 15 deletions(-)
---
Andy Lutomirski (1):
firmware: dmi_scan: Make dmi_walk and dmi_walk_early return real error
codes
Jean Delvare (3):
firmware: dmi_scan: Look for SMBIOS 3 entry point first
firmware: dmi: Fix permissions
s a base for today (the patches applied cleanly).
Oops, sorry about that. Fixed.
--
Jean Delvare
SUSE L3 Support
s a base for today (the patches applied cleanly).
Oops, sorry about that. Fixed.
--
Jean Delvare
SUSE L3 Support
On Sat, 3 Jun 2017 11:05:00 -0700, Andy Lutomirski wrote:
> Currently they return -1 on error, which will confuse callers if
> they try to interpret it as a normal negative error code.
>
> Signed-off-by: Andy Lutomirski <l...@kernel.org>
> Cc: Jean Delvare <jdelv..
On Sat, 3 Jun 2017 11:05:00 -0700, Andy Lutomirski wrote:
> Currently they return -1 on error, which will confuse callers if
> they try to interpret it as a normal negative error code.
>
> Signed-off-by: Andy Lutomirski
> Cc: Jean Delvare
> Signed-off-by: Darren Hart (VMware)
On Fri, 2 Jun 2017 21:45:37 +0300, Andy Shevchenko wrote:
> On Fri, Jun 2, 2017 at 9:40 PM, Jean Delvare <jdelv...@suse.de> wrote:
> > On Thu, 1 Jun 2017 19:06:36 +0300, Andy Shevchenko wrote:
> >> Your commit message should answer to the question why and w
On Fri, 2 Jun 2017 21:45:37 +0300, Andy Shevchenko wrote:
> On Fri, Jun 2, 2017 at 9:40 PM, Jean Delvare wrote:
> > On Thu, 1 Jun 2017 19:06:36 +0300, Andy Shevchenko wrote:
> >> Your commit message should answer to the question why and what.
> >> You didn't
On Thu, 1 Jun 2017 19:06:36 +0300, Andy Shevchenko wrote:
> On Thu, Jun 1, 2017 at 5:40 PM, Jean Delvare <jdelv...@suse.de> wrote:
> > On Thu, 1 Jun 2017 16:16:05 +0300, Andy Shevchenko wrote:
> >> On Thu, Jun 1, 2017 at 4:08 PM, Jean Delvare <jdelv...@suse.de> wr
On Thu, 1 Jun 2017 19:06:36 +0300, Andy Shevchenko wrote:
> On Thu, Jun 1, 2017 at 5:40 PM, Jean Delvare wrote:
> > On Thu, 1 Jun 2017 16:16:05 +0300, Andy Shevchenko wrote:
> >> On Thu, Jun 1, 2017 at 4:08 PM, Jean Delvare wrote:
>
> >> > -
Hi Andy,
Thanks for the review.
On Thu, 1 Jun 2017 16:16:05 +0300, Andy Shevchenko wrote:
> On Thu, Jun 1, 2017 at 4:08 PM, Jean Delvare <jdelv...@suse.de> wrote:
> > Before accessing DMI data to record it for later, we should ensure
> > that the DMI structures are la
Hi Andy,
Thanks for the review.
On Thu, 1 Jun 2017 16:16:05 +0300, Andy Shevchenko wrote:
> On Thu, Jun 1, 2017 at 4:08 PM, Jean Delvare wrote:
> > Before accessing DMI data to record it for later, we should ensure
> > that the DMI structures are large enough to contain the data
This is not sensitive information like serial numbers, we can allow
all users to read it.
Fix odd alignment while we're here.
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Fixes: c61872c9833d ("firmware: dmi: Add DMI_PRODUCT_FAMILY identification
string")
Cc: Dmitry Torokh
This is not sensitive information like serial numbers, we can allow
all users to read it.
Fix odd alignment while we're here.
Signed-off-by: Jean Delvare
Fixes: c61872c9833d ("firmware: dmi: Add DMI_PRODUCT_FAMILY identification
string")
Cc: Dmitry Torokhov
Cc: Mika Westerberg
Before accessing DMI data to record it for later, we should ensure
that the DMI structures are large enough to contain the data in
question.
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Cc: Dmitry Torokhov <dmitry.torok...@gmail.com>
Cc: Mika Westerberg <mika.westerb...@linu
Before accessing DMI data to record it for later, we should ensure
that the DMI structures are large enough to contain the data in
question.
Signed-off-by: Jean Delvare
Cc: Dmitry Torokhov
Cc: Mika Westerberg
Cc: Andy Shevchenko
Cc: Linus Walleij
---
drivers/firmware/dmi_scan.c | 23
sers. Permissions 0444 would
seem more appropriate. I'll include that change in my patch if there
are no objections.
--
Jean Delvare
SUSE L3 Support
sers. Permissions 0444 would
seem more appropriate. I'll include that change in my patch if there
are no objections.
--
Jean Delvare
SUSE L3 Support
On Thu, 1 Jun 2017 13:09:40 +0300, Mika Westerberg wrote:
> On Thu, Jun 01, 2017 at 11:29:26AM +0200, Jean Delvare wrote:
> > Hi all,
> >
> > Sorry for the late reply.
> >
> > On Wed, 17 May 2017 13:25:12 +0300, Mika Westerberg wrote:
> > > Sometimes
On Thu, 1 Jun 2017 13:09:40 +0300, Mika Westerberg wrote:
> On Thu, Jun 01, 2017 at 11:29:26AM +0200, Jean Delvare wrote:
> > Hi all,
> >
> > Sorry for the late reply.
> >
> > On Wed, 17 May 2017 13:25:12 +0300, Mika Westerberg wrote:
> > > Sometimes
_no_valid_mask[] =
> {
> DMI_MATCH(DMI_PRODUCT_NAME, "Edgar"),
> DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"),
> },
> - }
> + },
> + {}
> };
>
> static int chv_gpio_probe(struct chv
"Edgar"),
> DMI_MATCH(DMI_BIOS_DATE, "05/21/2016"),
> },
> - }
> + },
> + {}
> };
>
> static int chv_gpio_probe(struct chv_pinctrl *pctrl, int irq)
Reviewed-by: Jean Delvare
This should go to stable trees IMHO.
--
Jean Delvare
SUSE L3 Support
devicetable.h b/include/linux/mod_devicetable.h
> index 566fda587fcf..3f74ef2281e8 100644
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -467,6 +467,7 @@ enum dmi_field {
> DMI_PRODUCT_VERSION,
> DMI_PRODUCT_SERIAL,
> DMI_PRODUCT_UUID,
> + DMI_PRODUCT_FAMILY,
> DMI_BOARD_VENDOR,
> DMI_BOARD_NAME,
> DMI_BOARD_VERSION,
--
Jean Delvare
SUSE L3 Support
7fcf..3f74ef2281e8 100644
> --- a/include/linux/mod_devicetable.h
> +++ b/include/linux/mod_devicetable.h
> @@ -467,6 +467,7 @@ enum dmi_field {
> DMI_PRODUCT_VERSION,
> DMI_PRODUCT_SERIAL,
> DMI_PRODUCT_UUID,
> + DMI_PRODUCT_FAMILY,
> DMI_BOARD_VENDOR,
> DMI_BOARD_NAME,
> DMI_BOARD_VERSION,
--
Jean Delvare
SUSE L3 Support
dy, but apparently not.
> Signed-off-by: Andy Lutomirski <l...@kernel.org>
> Cc: Jean Delvare <jdelv...@suse.com>
> Signed-off-by: Darren Hart (VMware) <dvh...@infradead.org>
> ---
> drivers/firmware/dmi_scan.c | 9 +
> include/linux/dmi.h |
> Signed-off-by: Andy Lutomirski
> Cc: Jean Delvare
> Signed-off-by: Darren Hart (VMware)
> ---
> drivers/firmware/dmi_scan.c | 9 +
> include/linux/dmi.h | 2 +-
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/firmware/d
DMI_MATCH(DMI_SYS_VENDOR, "Magicfoo"),
DMI_MATCH(DMI_CHASSIS_TYPE, "9"), /*Laptop*/
},
},
to drivers/platform/x86/dell-laptop.c and be done with it? The driver
can simply bail out if loaded on a system where it isn't actually
needed. Isn't it good enough?
--
Jean Delvare
SUSE L3 Support
DMI_MATCH(DMI_SYS_VENDOR, "Magicfoo"),
DMI_MATCH(DMI_CHASSIS_TYPE, "9"), /*Laptop*/
},
},
to drivers/platform/x86/dell-laptop.c and be done with it? The driver
can simply bail out if loaded on a system where it isn't actually
needed. Isn't it good enough?
--
Jean Delvare
SUSE L3 Support
= {
>
> /* List of machines supported by this driver */
> static const struct of_device_id mt8173_cpufreq_machines[] __initconst = {
> + { .compatible = "mediatek,mt2701", },
> + { .compatible = "mediatek,mt7623", },
> { .compatible = "mediatek,mt817x", },
> { .compatible = "mediatek,mt8173", },
> { .compatible = "mediatek,mt8176", },
--
Jean Delvare
SUSE L3 Support
ver */
> static const struct of_device_id mt8173_cpufreq_machines[] __initconst = {
> + { .compatible = "mediatek,mt2701", },
> + { .compatible = "mediatek,mt7623", },
> { .compatible = "mediatek,mt817x", },
> { .compatible = "mediatek,mt8173", },
> { .compatible = "mediatek,mt8176", },
--
Jean Delvare
SUSE L3 Support
Hans de Goede <hdego...@redhat.com>
> Cc: Andy Shevchenko <a...@infradead.org>
> Cc: Jean Delvare <jdelv...@suse.de>
> Cc: Dmitry Torokhov <dmitry.torok...@gmail.com>
> ---
> drivers/platform/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
ACPI && DMI && I2C=y && INPUT && TOUCHSCREEN_SILEAD
> ---help---
> Certain ACPI based tablets with Silead touchscreens do not have
> enough data in ACPI tables for the touchscreen driver to handle
Reviewed-by: Jean Delvare
Thanks Darren,
--
Jean Delvare
SUSE L3 Support
Hi Mario, Allen,
Sorry for taking so long to get back to you. No excuses really :-(
On Thu, 1 Sep 2016 19:14:54 +, mario_limoncie...@dell.com wrote:
> > -Original Message-
> > From: Jean Delvare [mailto:jdelv...@suse.de]
> > Sent: Thursday, Septemb
Hi Mario, Allen,
Sorry for taking so long to get back to you. No excuses really :-(
On Thu, 1 Sep 2016 19:14:54 +, mario_limoncie...@dell.com wrote:
> > -Original Message-
> > From: Jean Delvare [mailto:jdelv...@suse.de]
> > Sent: Thursday, Septemb
straight: we will not take any patch from you. You are
an annoyance we don't need. Do not waste our time. Go away.
--
Jean Delvare
SUSE L3 Support
m you. You are
an annoyance we don't need. Do not waste our time. Go away.
--
Jean Delvare
SUSE L3 Support
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Fixes: 97b50a654d5d ("virtio_blk: make SCSI passthrough support configurable")
Cc: Christoph Hellwig <h...@lst.de>
Cc: Jens Axboe <ax...@fb.com>
---
drivers/block/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 del
Signed-off-by: Jean Delvare
Fixes: 97b50a654d5d ("virtio_blk: make SCSI passthrough support configurable")
Cc: Christoph Hellwig
Cc: Jens Axboe
---
drivers/block/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-4.11-rc8.orig/drivers/block/Kconfig 2017-0
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Fixes: c61f13eaa1ee ("gcc-plugins: Add structleak for more stack
initialization")
Cc: Kees Cook <keesc...@chromium.org>
---
arch/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-4.11-rc8.orig/arch/Kc
Signed-off-by: Jean Delvare
Fixes: c61f13eaa1ee ("gcc-plugins: Add structleak for more stack
initialization")
Cc: Kees Cook
---
arch/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-4.11-rc8.orig/arch/Kconfig2017-04-03 02:23:54.0 +0200
+++ linu
y i2c_algo->master_xfer() for
validity, this should be done in __i2c_transfer(). But then again, I
find it hard to justify the run-time overhead for working drivers, so
maybe it should only be done if CONFIG_I2C_DEBUG_BUS is enabled.
--
Jean Delvare
SUSE L3 Support
--
Jean Delvare
SUSE L3 Support
--
Jean Delvare
SUSE L3 Support
lidity, this should be done in __i2c_transfer(). But then again, I
find it hard to justify the run-time overhead for working drivers, so
maybe it should only be done if CONFIG_I2C_DEBUG_BUS is enabled.
--
Jean Delvare
SUSE L3 Support
--
Jean Delvare
SUSE L3 Support
--
Jean Delvare
SUSE L3 Support
.
>
> Suggested-by: Alan Cox <gno...@lxorguk.ukuu.org.uk>
> Signed-off-by: David Howells <dhowe...@redhat.com>
> cc: Wolfram Sang <w...@the-dreams.de>
> cc: Jean Delvare <jdelv...@suse.com>
> cc: linux-...@vger.kernel.org
> (...)
Acked-by: Jean Delvare <jdelv...@suse.de>
--
Jean Delvare
SUSE L3 Support
i2c/.
>
> Suggested-by: Alan Cox
> Signed-off-by: David Howells
> cc: Wolfram Sang
> cc: Jean Delvare
> cc: linux-...@vger.kernel.org
> (...)
Acked-by: Jean Delvare
--
Jean Delvare
SUSE L3 Support
"ar1021_i2c", ar1021);
> if (error) {
> dev_err(>dev,
Acked-by: Jean Delvare <jdelv...@suse.de>
--
Jean Delvare
SUSE L3 Support
error = devm_request_threaded_irq(>dev, client->irq,
> NULL, ar1021_i2c_irq,
> - IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> + IRQF_ONESHOT,
> "ar1021_i2c", a
en")
> Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com>
> ---
>
> V2: Changed MICROCHIP_AR1021 -> ar1021 as Jean suggested.
>
> drivers/input/touchscreen/ar1021_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> (...)
Reviewed-by: Jean Delvare &l
creen")
> Signed-off-by: Dmitry Torokhov
> ---
>
> V2: Changed MICROCHIP_AR1021 -> ar1021 as Jean suggested.
>
> drivers/input/touchscreen/ar1021_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> (...)
Reviewed-by: Jean Delvare
> diff --git a/driv
uld suggest to drop all the
stubs and simply depend on RPMSG_QCOM_SMD || QCOM_SMD, for the sake of
simplicity.)
Don't get me wrong, I am a big fan of COMPILE_TEST, but only when we
can use it to get build testing coverage for free. If you have to change
the code itself in order to be able to get the extra build testing
coverage, I don't think it is a good idea. The kernel and the Kconfig
dependencies can be complex enough as is.
--
Jean Delvare
SUSE L3 Support
the
stubs and simply depend on RPMSG_QCOM_SMD || QCOM_SMD, for the sake of
simplicity.)
Don't get me wrong, I am a big fan of COMPILE_TEST, but only when we
can use it to get build testing coverage for free. If you have to change
the code itself in order to be able to get the extra build testing
coverage, I don't think it is a good idea. The kernel and the Kconfig
dependencies can be complex enough as is.
--
Jean Delvare
SUSE L3 Support
ever add another type to the bus,
> > so let's export i2c_client_type as well.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torok...@gmail.com>
> > ---
> >
> > Wolfram, this is the patch I was talking about in the other mail.
>
> I see. From a gl
ever add another type to the bus,
> > so let's export i2c_client_type as well.
> >
> > Signed-off-by: Dmitry Torokhov
> > ---
> >
> > Wolfram, this is the patch I was talking about in the other mail.
>
> I see. From a glimpse, I am fine with the patch. I
Hi Hans,
On ven., 2017-03-03 at 15:27 +0100, Hans de Goede wrote:
> On 03-03-17 10:24, Jean Delvare wrote:
> > On Sat, 25 Feb 2017 18:23:55 +0100, Hans de Goede wrote:
> > > 1) Rather then add cmdline options for all things which can be DMI quirked
> > > and th
Hi Hans,
On ven., 2017-03-03 at 15:27 +0100, Hans de Goede wrote:
> On 03-03-17 10:24, Jean Delvare wrote:
> > On Sat, 25 Feb 2017 18:23:55 +0100, Hans de Goede wrote:
> > > 1) Rather then add cmdline options for all things which can be DMI quirked
> > > and th
Jean, that was easy.
You're welcome, glad I could help :-)
> Looking forward to see it in some future kernel.
--
Jean Delvare
SUSE L3 Support
Jean, that was easy.
You're welcome, glad I could help :-)
> Looking forward to see it in some future kernel.
--
Jean Delvare
SUSE L3 Support
final buffer.
>
> The idea was that the called code would return a pointer to a constant string,
> ie one that isn't changing from call to call.
In that case, what about the following change?
Subject: hwmon: Constify str parameter of hwmon_ops->read_string
The read_string callback is sup
final buffer.
>
> The idea was that the called code would return a pointer to a constant string,
> ie one that isn't changing from call to call.
In that case, what about the following change?
Subject: hwmon: Constify str parameter of hwmon_ops->read_string
The read_string callback is
u could give a try to this
standalone driver:
http://jdelvare.nerim.net/devel/lm-sensors/drivers/dell-smm-hwmon/
Instructions are at:
http://jdelvare.nerim.net/devel/lm-sensors/drivers/INSTALL
--
Jean Delvare
SUSE L3 Support
u could give a try to this
standalone driver:
http://jdelvare.nerim.net/devel/lm-sensors/drivers/dell-smm-hwmon/
Instructions are at:
http://jdelvare.nerim.net/devel/lm-sensors/drivers/INSTALL
--
Jean Delvare
SUSE L3 Support
Hi Peter,
On Fri, 3 Mar 2017 01:33:01 +0100, Peter Hüwe wrote:
> is anybody else working on the conversion of the w83627ehf to the new
> hwmon_device_register_with_info interface?
Not me.
--
Jean Delvare
SUSE L3 Support
301 - 400 of 3166 matches
Mail list logo
