On 06/17/2014 23:50 PM, Greg KH wrote:
> On Tue, Jun 17, 2014 at 10:56:04PM +0800, Jeff Liu wrote:
>>
>> On 06/17/2014 22:42 PM, James Bottomley wrote:
>>> On Tue, 2014-06-17 at 22:25 +0800, Jeff Liu wrote:
>>>> From: Jie Liu
>>>>
>>>
On 06/17/2014 22:42 PM, James Bottomley wrote:
> On Tue, 2014-06-17 at 22:25 +0800, Jeff Liu wrote:
>> From: Jie Liu
>>
>> It's better to return the actual error rather than NULL because
>> kset_register() can failed due to other reasons.
>>
>> Cc:
From: Jie Liu
This patch fix all sysfs init functions under drivers core to
return the actual error code than the hardcoded ENOMEM.
Cc: Greg Kroah-Hartman
Signed-off-by: Jie Liu
---
drivers/base/bus.c | 16
drivers/base/class.c | 4 ++--
drivers/base/core.c | 4 ++--
3 f
From: Jie Liu
It's better to return the actual error rather than NULL because
kset_register() can failed due to other reasons.
Cc: Christoph Lameter
Cc: Greg Kroah-Hartman
Cc: Andrew Morton
Cc: Pekka Enberg
Cc: Matt Mackall
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Martin Schwidef
From: Jie Liu
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Signed-off-by: Jie Liu
---
arch/powerpc/platforms/powernv/opal-dump.c | 2 +-
arch/powerpc/platforms/powernv/opal-elog.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal-dum
From: Jie Liu
kset_create_and_add() has been fixed to return the actual error
code ptr rather than NULL, so update iommu_init() to check the
return value via IS_ERR() accordingly.
Cc: Joerg Roedel
Signed-off-by: Jie Liu
---
drivers/iommu/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
From: Jie Liu
Return the actual error code if call kset_create_and_add() failed
Cc: Greg Kroah-Hartman
Signed-off-by: Jie Liu
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/of/base.c b/drivers/of/base.c
index 8368d96..8f8efa1 100644
--- a
From: Jie Liu
Return the actual error code if call kset_create_and_add() failed
Cc: Herbert Xu
Cc: David S. Miller"
Signed-off-by: Jie Liu
---
crypto/pcrypt.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c
index 309d345..053fb10 10
From: Jie Liu
This patch fix all sysfs init functions under firmware subsystems
to return the actual error if call kset_create_and_add() failed.
Cc: Stefan Richter
Signed-off-by: Jie Liu
---
drivers/firmware/dmi-sysfs.c | 4 +++-
drivers/firmware/edd.c | 4 ++--
drivers/firm
From: Jie Liu
Return the actual error code if kset_create_and_add() failed
Cc: Andrew Morton
Cc: Christoph Lameter
Signed-off-by: Jie Liu
---
kernel/params.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/kernel/params.c b/kernel/params.c
index 1e52ca2..a110987 10
fail
due to other reasons, hence it's better to return the actual error on
kset_create_and_add(), this patch series is just did that and this is
inspired by Christoph in another thread:
http://www.spinics.net/lists/linux-mm/msg74729.html
Jeff Liu (24)
kobject: return actual err
From: Jie Liu
Subject: sample/kobject: update kset-example code
Check and return the error ptr if call kset_create_and_add() failed
Cc: Christoph Lameter
Cc: Greg Kroah-Hartman
Cc: Andrew Morton
Signed-off-by: Jie Liu
---
samples/kobject/kset-example.c | 4 ++--
1 file changed, 2 insertions
Hi,
On 05/23/2014 04:46 AM, Rickard Strandqvist wrote:
> There is otherwise a risk of a possible null pointer dereference.
>
> Was largely found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> fs/ocfs2/move_extents.c |4 +++-
> 1 file
On 04/12 2014 22:36 PM, Brian Foster wrote:
> On Mon, Apr 21, 2014 at 10:01:34PM +0800, Jeff Liu wrote:
>>
>> On 04/21 2014 21:09 PM, Brian Foster wrote:
>>> On Mon, Apr 21, 2014 at 08:46:39PM +0800, Jeff Liu wrote:
>>>> Hi Tuomas,
>>>>
>
On 04/21 2014 21:09 PM, Brian Foster wrote:
> On Mon, Apr 21, 2014 at 08:46:39PM +0800, Jeff Liu wrote:
>> Hi Tuomas,
>>
>> On 04/21 2014 18:04 PM, Tuomas Tynkkynen wrote:
>>> xfs_{compat_,}attrmulti_by_handle could return an errno with incorrect
>>> sig
Hi Tuomas,
On 04/21 2014 18:04 PM, Tuomas Tynkkynen wrote:
> xfs_{compat_,}attrmulti_by_handle could return an errno with incorrect
> sign in some cases. While at it, make sure ENOMEM is returned instead of
> E2BIG if kmalloc fails.
>
> Signed-off-by: Tuomas Tynkkynen
> ---
> Compile tested only
On 01/10 2014 21:33 PM, Christoph Hellwig wrote:
> On Fri, Jan 10, 2014 at 09:22:10PM +0800, Jeff Liu wrote:
>> Hi Fengguang,
>>
>> Thanks for help catching up this. I think the below patch can fix it
>> up, but maybe there would have a neater solution once Christoph is
Hi Fengguang,
Thanks for help catching up this. I think the below patch can fix it
up, but maybe there would have a neater solution once Christoph is back.
Thanks,
-Jeff
From: Jie Liu
Subject: xfs: fix ctime and mtime update for truncate(2)
There is a semantic difference between truncate(2) a
Hi Chuansheng,
On 01/07 2014 16:53 PM, Chuansheng Liu wrote:
>
> In case CONFIG_DEBUG_OBJECTS_WORK is defined, it is needed to
> call destroy_work_on_stack() which frees the debug object to pair
> with INIT_WORK_ONSTACK().
>
> Signed-off-by: Liu, Chuansheng
> ---
> fs/xfs/xfs_bmap_util.c |
On 12/14 2013 00:32 AM, Christoph Hellwig wrote:
>> +static inline prid_t xfs_get_initial_prid(struct xfs_inode *dp)
>> +{
>> +if (dp->i_d.di_flags & XFS_DIFLAG_PROJINHERIT)
>> +return xfs_get_projid(dp);
>> +else
>> +return XFS_PROJID_DEFAULT;
>> +}
>
> You could s
Hi Oleg,
Sorry for my late response!
On 11/16/2013 01:12 AM, Oleg Nesterov wrote:
> On 11/15, Oleg Nesterov wrote:
>>
>> But probably list_last_entry() makes sense in the "else" branch,
>> athough this is minor.
>>
>>
>> Off-topic. Not sure this really makes sense, but I was thinking about
>>
>>
On 11/15 2013 22:11, Christoph Hellwig wrote:
> On Fri, Nov 15, 2013 at 12:29:48PM +0800, Jeff Liu wrote:
>> Hi Folks,
>>
>> This patch is trying to introduce a new list helper to retrieve the
>> last entry or return NULL if the list is empty corresponding to it,
&
Hi Dave and all,
Please ignore this patch from this series.
On 11/15 2013 12:35 PM, Jeff Liu wrote:
> From: Jie Liu
>
> Simplify the code in lmLogSync() via list_last_entry_or_null().
>
> Signed-off-by: Jie Liu
> ---
> fs/jfs/jfs_logmgr.c | 10 +++---
> 1 fi
From: Jie Liu
Simplify the code in lmLogSync() via list_last_entry_or_null().
Signed-off-by: Jie Liu
---
fs/jfs/jfs_logmgr.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 7b565d0..2f90779 100644
--- a/fs/jfs/jfs_l
From: Jie Liu
Simplify the code in lmNextPage via list_last_entry_or_null().
Signed-off-by: Jie Liu
---
fs/jfs/jfs_logmgr.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c
index 360d27c..7b565d0 100644
--- a/fs/jfs/jfs_logmgr.c
From: Jie Liu
Simplify the code in drop_last_node() via list_last_entry_or_null().
Signed-off-by: Jie Liu
---
fs/ubifs/recovery.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/fs/ubifs/recovery.c b/fs/ubifs/recovery.c
index 065096e..e46c394 100644
--- a/fs/ubifs/r
From: Jie Liu
Simplify the code in current_tail() via list_last_entry_or_null().
Signed-off-by: Jie Liu
---
fs/gfs2/log.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/fs/gfs2/log.c b/fs/gfs2/log.c
index 610613f..555f767 100644
--- a/fs/gfs2/log.c
+++ b/fs/gfs2
From: Jie Liu
Simplify xfs_ail_max() with list_last_entry_or_null(), and move it to
xfs_trans_priv.h as an inline function as now it is one line.
Signed-off-by: Jie Liu
---
fs/xfs/xfs_trans_ail.c | 14 --
fs/xfs/xfs_trans_priv.h | 12
2 files changed, 12 insertions(+)
From: Jie Liu
Introduce a trivial helper list_last_entry_or_null() to fetch the
last entry from a list, return NULL if the list is empty.
Signed-off-by: Jie Liu
---
include/linux/list.h | 11 +++
1 file changed, 11 insertions(+)
diff --git a/include/linux/list.h b/include/linux/list.h
Hi Folks,
This patch is trying to introduce a new list helper to retrieve the
last entry or return NULL if the list is empty corresponding to it,
which is inspired by Jiri Pirko's list_first_entry_or_null().
With this trivial helper, we could get a little benefit to simplify
the code logic of xfs
Thanks for your prompt response!
On 11/07/2013 01:13 PM, Stephan Mueller wrote:
> Am Donnerstag, 7. November 2013, 12:14:17 schrieb Jeff Liu:
>
> Hi Jeff,
>
>> Hi Stephan,
>>
>> As per your previous comments for this fix, you have promised another
>>
Hi Stephan,
As per your previous comments for this fix, you have promised another approach
which
is promising to avoid entropy starvation, I got this info from the following
thread:
[PATCH] avoid entropy starvation due to stack protection
https://lkml.org/lkml/2012/12/14/267
My current fix has
On 09/03/2013 02:42 PM, Richard Weinberger wrote:
> Hi!
>
> Am 03.09.2013 05:17, schrieb Jeff Liu:
>> Hello,
>>
>> It seems like Sunil has fixed a similar issue against ocfs2-1.4
>> several years ago:
>> https://oss.oracle.com/gi
Hello,
It seems like Sunil has fixed a similar issue against ocfs2-1.4
several years ago:
https://oss.oracle.com/git/?p=ocfs2-1.4.git;a=commitdiff_plain;h=2fd250839d0f5073af8d42e97f1db74beb621674;hp=e882faf84930431524f84598caea7d4e9a9529c5
https://oss.oracle.com/git/?p=ocfs2-1.4.git;a=commitdiff_p
On 08/15/2013 01:53 PM, Dan Carpenter wrote:
> The "di_size" variable comes from the disk and it's a signed 64 bit.
> We check the upper limit but we should check for negative numbers as
> well.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/fs/xfs/xfs_inode_fork.c b/fs/xfs/xfs_inode_fork.c
Hi Dong,
On 07/31/2013 12:00 AM, Dong Fang wrote:
> On 07/29/2013 04:06 AM, Dan Carpenter wrote:
>> Oh. It appears that nothing changed between v1 and v2. Only the CC
>> list.
>>
>> It's probably that the list moderation on ocfs2-devel was confusing
>> for non-native English speakers the patch
On 07/17/2013 06:58 PM, James Bottomley wrote:
> On Wed, 2013-07-17 at 17:15 +0800, Jeff Liu wrote:
>> On 07/17/2013 08:51 AM, Steven Rostedt wrote:
>>
>>> On Wed, 2013-07-17 at 08:32 +0800, Jeff Liu wrote:
>>>
>>>> Another thing might deviated
On 07/17/2013 08:51 AM, Steven Rostedt wrote:
> On Wed, 2013-07-17 at 08:32 +0800, Jeff Liu wrote:
>
>> Another thing might deviated from the main theme, but I'd like to raise it
>> here because I would like to see what's the proper way for that.
>>
>> F
On 07/17/2013 07:12 AM, Sarah Sharp wrote:
> On Tue, Jul 16, 2013 at 06:54:59PM -0400, Steven Rostedt wrote:
>> On Tue, 2013-07-16 at 15:43 -0700, Sarah Sharp wrote:
>>
>>> Yes, that's true. Some kernel developers are better at moderating their
>>> comments and tone towards individuals who are "s
On 06/16/2013 08:46 AM, Richard Yao wrote:
> On 06/15/2013 01:09 AM, Jeff Liu wrote:
>> [Add ocfs2-devel to CC-list]
>>
>> Hello Richard,
>>
>> Thanks for your patch.
>>
>> On 06/15/2013 03:23 AM, Richard Yao wrote:
>>
>>> There are mul
ny of
> the same flaws, which I caught during review. I addressed the issues
> with his patch with one that I wrote. Since a small percentage of Gentoo
> Linux users are affected by these flaws, I decided to adapt that code
> that to btrfs (separate patch) and ocfs2.
>
> Note that
Hi Andrew and David,
On 02/15/2013 07:21 AM, Andrew Morton wrote:
> On Sat, 02 Feb 2013 13:04:52 +0800
> Jeff Liu wrote:
>
>> The return statement after BUG() is invalid, move BUG() to the default
>> choice of the switch.
>>
>> Signed-off-by: Jie Liu
>&
The return statement after BUG() is invalid, move BUG() to the default choice
of the switch.
Signed-off-by: Jie Liu
---
kernel/res_counter.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/kernel/res_counter.c b/kernel/res_counter.c
index ff55247..748a3bc 100644
---
On 01/09/2013 10:04 PM, Abhijit Pawar wrote:
> This patch replaces usages of obsolete simple_strtoul with kstrtoint in
> xfs_args and suffix_strtoul.
>
> Signed-off-by: Abhijit Pawar
> ---
> fs/xfs/xfs_super.c | 29 +++--
> 1 files changed, 19 insertions(+), 10 deletio
On 01/12/2013 06:52 AM, Dave Chinner wrote:
> On Fri, Jan 11, 2013 at 02:36:46PM +0800, Jeff Liu wrote:
>> On 01/09/2013 10:04 PM, Abhijit Pawar wrote:
>>> This patch replaces usages of obsolete simple_strtoul with kstrtoint in
>>> xfs_args and suffix_strtoul.
>>&
On 01/09/2013 10:04 PM, Abhijit Pawar wrote:
> This patch replaces usages of obsolete simple_strtoul with kstrtoint in
> xfs_args and suffix_strtoul.
>
> Signed-off-by: Abhijit Pawar
> ---
> fs/xfs/xfs_super.c | 29 +++--
> 1 files changed, 19 insertions(+), 10 deletio
On 11/29/2012 02:53 PM, Jim Meyering wrote:
> Jeff Liu wrote:
>
>> On 11/29/2012 12:15 PM, Jim Meyering wrote:
>>> Hugh Dickins wrote:
>>>> On Thu, 29 Nov 2012, Jaegeuk Hanse wrote:
>>> ...
>>>>> But this time in which scenario will use it
On 11/29/2012 12:15 PM, Jim Meyering wrote:
> Hugh Dickins wrote:
>> On Thu, 29 Nov 2012, Jaegeuk Hanse wrote:
> ...
>>> But this time in which scenario will use it?
>>
>> I was not very convinced by the grep argument from Jim and Paul:
>> that seemed to be grep holding on to a no-arbitrary-limits
Hello,
For blkio controller of cgroup, both disk_time and disk_sectors were
obsolated file names. Now we're using blkio.time and blkio.sectors to
examine how much disk time each cgroup got and how many sectors each
cgroup dispatched separately.
This patch fix the document to reflect those change
Hello,
The problems have been fixed in this version as per Kees's comments for v3.
Hi Kees,
Would you please ACK this patch if you think it is ok except the strength
of these various RNGs you are concerned?
Changes:
v4->v3:
- s/random_stack_user()/get_atrandom_bytes()/
- Move this func
On 11/07/2012 11:10 PM, Kees Cook wrote:
> On Wed, Nov 7, 2012 at 1:32 AM, Theodore Ts'o wrote:
>> On Tue, Nov 06, 2012 at 05:11:17PM -0800, Kees Cook wrote:
>>> Hrm, I don't like this. get_random_int() specifically says: "Get a
>>> random word for internal kernel use only." The intent of AT_RANDO
On 11/07/2012 02:21 PM, Kees Cook wrote:
> On Tue, Nov 6, 2012 at 10:11 PM, Jeff Liu wrote:
>> Hello,
>>
>> This is the revised patch for fix entropy depleting.
>>
>> Changes:
>>
>> v3->v2:
>> - Tweak code comments of random_stack_
Hello,
This is the revised patch for fix entropy depleting.
Changes:
v3->v2:
- Tweak code comments of random_stack_user().
- Remove redundant bits mask and shift upon the random variable.
v2->v1:
Fix random copy to check up buffer length that are not 4-byte multiples.
v2 can be found a
Please ignore this patch since I forgot revising the comments of this
new wrapper according to Andrew's, will re-send it a little while, sorry
for the noise!
-Jeff
On 11/07/2012 01:27 PM, Jeff Liu wrote:
> Hello,
>
> We have observed entropy quickly depleting under normal I/O bet
Hello,
We have observed entropy quickly depleting under normal I/O between 2.6.30 to
upstream, for instance:
$ cat /proc/sys/kernel/random/entropy_avail
3428
$ cat /proc/sys/kernel/random/entropy_avail
2911
$cat /proc/sys/kernel/random/entropy_avail
2620
It has been occurred with fs/binfmt_e
On 11/07/2012 12:29 PM, Kees Cook wrote:
> On Tue, Nov 6, 2012 at 8:21 PM, Jeff Liu wrote:
>> Hi Andrew and Kees,
>>
>> Great thanks for both your comments!
>>
>> On 11/07/2012 09:11 AM, Kees Cook wrote:
>>> Hrm, I don't like this. get_random_int(
e original patch on the mailing list and do a
>> reply-to-all to that, adding suitable additional cc's
>>
>> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>>
>> The -mm tree is included into linux-next and is updated
>> there ev
Hello,
In general we can get the symbol name of a particular lock and print it out if
something
went wrong regarding lock/unlock stuff.
However, I observed the following info(3.5.0-rc4) when running quotacheck(1)
yesterday.
It has occurred only once, I can not reproduced it afterwards.
[15800.
On 07/17/2012 05:33 PM, Chen Baozi wrote:
>
> On Jul 17, 2012, at 3:06 PM, Christoph Hellwig wrote:
>
>> On Tue, Jul 17, 2012 at 11:33:33AM +0800, Chen Baozi wrote:
>>> I'd really love to. Right now, I am working on syslinux to support booting
>>> on xfs partition (under pcacjr's mentoring)???
On 07/16/2012 05:28 PM, Hugh Dickins wrote:
> On Thu, 12 Jul 2012, Jeff Liu wrote:
>> On 07/12/2012 07:01 AM, Dave Chinner wrote:
>>> On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote:
>>>>
>>>> But your vote would count for a lot more if yo
Hey Namhyung,
Thanks for your response!
On 07/16/2012 01:16 PM, Namhyung Kim wrote:
> Hi,
>
> (CC-ing Jiri)
>
> On Sun, 15 Jul 2012 22:32:14 +0800, Jeff Liu wrote:
>> Hello,
>>
>> I failed to compile perf tools on 3.5.0-rc7 with bison && flex
>>
Hello,
I failed to compile perf tools on 3.5.0-rc7 with bison && flex
pre-installed.
The error seems something like this,
libperf.a(pmu.o): In function `pmu_format_parse':
/usr/src/linux/tools/perf/util/pmu.c:47: undefined reference to
`perf_pmu_in'
libperf.a(pmu-bison.o): In function `perf_pmu_
On 07/12/2012 07:01 AM, Dave Chinner wrote:
> On Wed, Jul 11, 2012 at 11:55:34AM -0700, Hugh Dickins wrote:
>> On Wed, 11 Jul 2012, Cong Wang wrote:
>>> On Mon, 09 Jul 2012 at 22:41 GMT, Hugh Dickins wrote:
Revert 4fb5ef089b28 ("tmpfs: support SEEK_DATA and SEEK_HOLE").
I believe it's c
63 matches
Mail list logo
