ents to drivers/bus/mhi/host/ so
that
- we can include driver header files.
- Use macros directly in the trace events as suggested Jeffrey Hugo.
- Reorder the structure in the events as suggested by steve to avoid holes in
the buffer.
- removed the mhi_to_physical function as this can give secu
On 10/23/2023 1:11 AM, Krishna Chaitanya Chundru wrote:
On 10/20/2023 8:33 PM, Jeffrey Hugo wrote:
On 10/13/2023 3:52 AM, Krishna chaitanya chundru wrote:
This change adds ftrace support for following functions which
helps in debugging the issues when there is Channel state & MHI
state ch
On 10/13/2023 3:52 AM, Krishna chaitanya chundru wrote:
This change adds ftrace support for following functions which
helps in debugging the issues when there is Channel state & MHI
state change and also when we receive data and control events:
1. mhi_intvec_threaded_handler
2. mhi_process_data_e
On Thu, Mar 18, 2021 at 11:06 AM Bjorn Andersson
wrote:
>
> On Thu 18 Mar 11:56 CDT 2021, Jeffrey Hugo wrote:
>
> > form -> from in the subject?
> >
>
> Seems like I only failed in the cover letter, right?
Looks like. I didn't even parse that this was the cover letter.
Nothing to see here.
form -> from in the subject?
On Thu, Mar 11, 2021 at 5:34 PM Bjorn Andersson
wrote:
>
> The wireless subsystem found in Qualcomm MSM8974 and MSM8916 among others
> needs
> platform-, and perhaps even board-, specific firmware. Add support for
> providing this in devicetree.
On 3/17/2021 3:26 PM, Bhaumik Bhatt wrote:
On 2021-03-11 11:59 AM, Jeffrey Hugo wrote:
On 3/11/2021 1:00 AM, Loic Poulain wrote:
Hi Bhaumik,
On Thu, 11 Mar 2021 at 00:31, Bhaumik Bhatt
wrote:
Introduce helper function to allow MHI core driver to poll for
a value in a register field. This
On 3/16/2021 12:14 AM, Manivannan Sadhasivam wrote:
On Wed, Mar 10, 2021 at 01:41:58PM -0700, Jeffrey Hugo wrote:
After the device has signaled the end of reset by clearing the reset bit,
it will automatically reinit MHI and the internal device structures. Once
That is done, the device will
ing if us scale timing is a
benefit in any way.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
valid data or crash if the values are corrupted.
If validation fails, drop the relevant event.
Signed-off-by: Jeffrey Hugo
---
v3: Add the channel validation example to commit text
v2: Fix subject
drivers/bus/mhi/core/main.c | 81 +
1 file change
: Jeffrey Hugo
---
v3: Move the pm_lock use up
v2: Fix subject and tweak the locking to avoid needless lock/unlock/relock
drivers/bus/mhi/core/pm.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index 414da4f
e the device hits the ready state before the host
completes its reset processing.
Signed-off-by: Jeffrey Hugo
---
drivers/bus/mhi/core/pm.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index adb0e80..41
From: Fan Wu
Currently ENOMEM is returned when MHI ring is full. This error code is
very misleading. Change to EAGAIN instead.
Signed-off-by: Fan Wu
Signed-off-by: Jeffrey Hugo
Reviewed-by: Hemant Kumar
Reviewed-by: Manivannan Sadhasivam
---
drivers/bus/mhi/core/main.c | 2 +-
1 file
On 2/23/2021 8:44 PM, Bhaumik Bhatt wrote:
Make use of mhi_poll_reg_field() API in order to poll for RDDM
download in panic path to employ a common approach throughout the
driver.
Signed-off-by: Bhaumik Bhatt
Seems ok to me.
Reviewed-by: Jeffrey Hugo
--
Jeffrey Hugo
Qualcomm Technologies
comment the macro as well).
+ if (ret) {
+ dev_err(dev, "Device failed to enter MHI Ready\n");
return -ETIMEDOUT;
}
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
u32 offset, u32 val)
{
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
before
proceeding with the registration.
Signed-off-by: Bhaumik Bhatt
---
Reviewed-by: Jeffrey Hugo
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
optional to accommodate different bootup modes.
Suggested-by: Loic Poulain
Signed-off-by: Bhaumik Bhatt
Reviewed-by: Jeffrey Hugo
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
before
proceeding with the registration.
Signed-off-by: Bhaumik Bhatt
Reviewed-by: Jeffrey Hugo
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
sc minor numbers used, and this particular server has a fresh distro
install on it. I would expect that number to go up as it gets
provisioned for use.
I guess, the question to you is, how many misc minor numbers is "too
much" for a single driver to expect to consume?
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
Node ID) are the node IDs that
is unique per mhi device.
Changes since v1:
- Addressed review comments by Jeffrey Hugo.
No, you didn't. You fixed the DT comment, but didn't address the rest.
This gets a NACK from me.
Gokul Sriram Palanisamy (1):
bus: mhi: core: Add unique qr
FT, instance);
+
write_lock_irq(&mhi_cntrl->pm_lock);
mhi_cntrl->dev_state = MHI_STATE_RESET;
write_unlock_irq(&mhi_cntrl->pm_lock);
NACK. Please see my comments on v1.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
On 2/24/2021 2:55 AM, Manivannan Sadhasivam wrote:
On Wed, Feb 17, 2021 at 09:43:31AM -0700, Jeffrey Hugo wrote:
We cannot process a power_down if the power state is DISABLED. There is
no valid mhi_ctxt in that case, so attepting to process the power_down
will likely result in a null pointer
On 2/24/2021 2:47 AM, Manivannan Sadhasivam wrote:
On Wed, Feb 17, 2021 at 09:20:22AM -0700, Jeffrey Hugo wrote:
When parsing the structures in the shared memory, there are values which
come from the remote device. For example, a transfer completion event
will have a pointer to the tre in the
he calls that are checked for existence are implemented on
firmware running on sc7180. If such a call needs to be checked for
existence in the future, we presume that firmware will implement this
API and then things will "just work".
Cc: Elliot Berman
Cc: Brian Masney
Cc: Stephan Ger
s anything preventing
that in future.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
oll_timeout() would not.
I'm fine with this concept, but I think the implementation needs to be
adjusted.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
e the device hits the ready state before the host
completes its reset processing.
Signed-off-by: Jeffrey Hugo
---
v2: Fix subject and remove use of cur_state
drivers/bus/mhi/core/pm.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/p
: Jeffrey Hugo
---
v2: Fix subject and tweak the locking to avoid needless lock/unlock/relock
drivers/bus/mhi/core/pm.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index 56ba3ab..47f6621 100644
--- a/drivers/bus/mhi
From: Fan Wu
Currently ENOMEM is returned when MHI ring is full. This error code is
very misleading. Change to EAGAIN instead.
Signed-off-by: Fan Wu
Signed-off-by: Jeffrey Hugo
---
v3: Fix subject
v2: Change from EBUSY to EAGAIN
drivers/bus/mhi/core/main.c | 2 +-
1 file changed, 1
If we blindly use such values, we may access invalid data or crash
if the values are corrupted.
If validation fails, drop the relevant event.
Signed-off-by: Jeffrey Hugo
---
v2: Fix subject
drivers/bus/mhi/core/main.c | 81 +
1 file changed, 74 inser
If we blindly use such values, we may access invalid data or crash
if the values are corrupted.
If validation fails, drop the relevant event.
Signed-off-by: Jeffrey Hugo
---
drivers/bus/mhi/core/main.c | 81 +
1 file changed, 74 insertions(+), 7 dele
On 2/17/2021 8:02 AM, Loic Poulain wrote:
On Tue, 16 Feb 2021 at 19:50, Jeffrey Hugo wrote:
From: Fan Wu
Currently ENOMEM is returned when MHI ring is full. This error code is
very misleading. Change to EBUSY instead.
Well, there is no space left in the ring, so it's no so misle
: Jeffrey Hugo
---
drivers/bus/mhi/core/pm.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index 56ba3ab..dc69074 100644
--- a/drivers/bus/mhi/core/pm.c
+++ b/drivers/bus/mhi/core/pm.c
@@ -1144,6 +1144,7 @@ int mhi_async_power_up(struct
From: Fan Wu
Currently ENOMEM is returned when MHI ring is full. This error code is
very misleading. Change to EAGAIN instead.
Signed-off-by: Fan Wu
Signed-off-by: Jeffrey Hugo
---
v2: Change from EBUSY to EAGAIN
drivers/bus/mhi/core/main.c | 2 +-
1 file changed, 1 insertion(+), 1
On 2/16/2021 1:22 PM, Bhaumik Bhatt wrote:
On 2021-02-16 10:48 AM, Jeffrey Hugo wrote:
From: Fan Wu
Currently ENOMEM is returned when MHI ring is full. This error code is
very misleading. Change to EBUSY instead.
Signed-off-by: Fan Wu
Signed-off-by: Jeffrey Hugo
---
drivers/bus/mhi/core
e the device hits the ready state before the host
completes its reset processing.
Signed-off-by: Jeffrey Hugo
---
drivers/bus/mhi/core/pm.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
index ef
From: Fan Wu
Currently ENOMEM is returned when MHI ring is full. This error code is
very misleading. Change to EBUSY instead.
Signed-off-by: Fan Wu
Signed-off-by: Jeffrey Hugo
---
drivers/bus/mhi/core/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi
On 2/16/2021 10:36 AM, Bhaumik Bhatt wrote:
On 2021-02-15 11:32 PM, Manivannan Sadhasivam wrote:
On Fri, Feb 12, 2021 at 05:40:14PM -0700, Jeffrey Hugo wrote:
The intvec handler stores the caches ee in a local variable for use in
processing the intvec. When determining if a syserr is a fatal
PBL ee as the result of a fatal error, but the cached ee might
be AMSS, which would cause the intvec handler to incorrectly signal a
non-fatal syserr.
Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
Signed-off-by: Jeffrey Hugo
---
drivers/bus/mhi/core/main.c
detected at power_up. Fix this.
Fixes: e18d4e9fa79b ("bus: mhi: core: Handle syserr during power_up")
Signed-off-by: Jeffrey Hugo
---
drivers/bus/mhi/core/pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
ind
Well. You sure know how to aggravate people. I said clearly that you
can move forward on purpose build drivers (e.g. for WWAN). There is no
way forward on this common shim driver as far as I'm concerned.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
On Thu, Jan 14, 2021 at 4:05 PM AngeloGioacchino Del Regno
wrote:
>
> Il 14/01/21 23:37, Jeffrey Hugo ha scritto:
> > On Thu, Jan 14, 2021 at 3:13 PM AngeloGioacchino Del Regno
> > wrote:
> >>
> >> The GPU IOMMU depends on this clock and the hypervisor will c
On Thu, Jan 14, 2021 at 3:40 PM AngeloGioacchino Del Regno
wrote:
>
> Il 14/01/21 23:33, Jeffrey Hugo ha scritto:
> > On Thu, Jan 14, 2021 at 3:13 PM AngeloGioacchino Del Regno
> > wrote:
> >>
> >> Il 14/01/21 23:12, Jeffrey Hugo ha scritto:
> >>>
On Thu, Jan 14, 2021 at 3:13 PM AngeloGioacchino Del Regno
wrote:
>
> The GPU IOMMU depends on this clock and the hypervisor will crash
> the SoC if this clock gets disabled because the secure contexts
> that have been set on this IOMMU by the bootloader will become
> unaccessible (or they get res
On Thu, Jan 14, 2021 at 3:13 PM AngeloGioacchino Del Regno
wrote:
>
> Il 14/01/21 23:12, Jeffrey Hugo ha scritto:
> > On Sat, Jan 9, 2021 at 6:47 AM AngeloGioacchino Del Regno
> > wrote:
> >>
> >> This clock enables the GPLL0 output to the multim
On Sat, Jan 9, 2021 at 6:47 AM AngeloGioacchino Del Regno
wrote:
>
> This clock enables the GPLL0 output to the multimedia subsystem
> clock controller.
>
> Signed-off-by: AngeloGioacchino Del Regno
>
Any reason why you are not also adding the div_clk?
release() is called on UCI device file node. Device
file node is created with format
/dev/
Currently it supports QMI channel.
Signed-off-by: Hemant Kumar
Reviewed-by: Manivannan Sadhasivam
Reviewed-by: Jeffrey Hugo
Tested-by: Loic Poulain
---
Can you provide a pointer to the open-source
7 @@ struct mhi_controller {
bool fbc_download;
bool pre_init;
bool wake_set;
+ unsigned long irq_flags;
You don't document this. That gets a NACK from me.
};
/**
Thanks,
Hemant
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
node is created with format
/dev/
Currently it supports QMI channel.
Signed-off-by: Hemant Kumar
Reviewed-by: Manivannan Sadhasivam
Reviewed-by: Jeffrey Hugo
You dropped Loic's tested by. Was that a mistake, or did something
actually change which would invalidate his testing?
--
Je
node is created with format
/dev/
Currently it supports QMI channel.
Signed-off-by: Hemant Kumar
Reviewed-by: Manivannan Sadhasivam
Tested-by: Loic Poulain
Reviewed-by: Jeffrey Hugo
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation
On 12/1/2020 7:55 PM, Jakub Kicinski wrote:
On Tue, 1 Dec 2020 13:48:36 -0700 Jeffrey Hugo wrote:
On 12/1/2020 1:03 PM, Jakub Kicinski wrote:
On Tue, 1 Dec 2020 12:40:50 -0700 Jeffrey Hugo wrote:
On 12/1/2020 12:29 PM, Jakub Kicinski wrote:
On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Kumar
On 12/1/2020 1:03 PM, Jakub Kicinski wrote:
On Tue, 1 Dec 2020 12:40:50 -0700 Jeffrey Hugo wrote:
On 12/1/2020 12:29 PM, Jakub Kicinski wrote:
On Fri, 27 Nov 2020 19:26:02 -0800 Hemant Kumar wrote:
This patch series adds support for UCI driver. UCI driver enables userspace
clients to
ators.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
On 12/1/2020 11:05 AM, Loic Poulain wrote:
On Tue, 1 Dec 2020 at 18:51, Jeffrey Hugo wrote:
On 12/1/2020 10:52 AM, Loic Poulain wrote:
On Tue, 1 Dec 2020 at 18:37, Jeffrey Hugo wrote:
On 12/1/2020 10:36 AM, Loic Poulain wrote:
On Tue, 1 Dec 2020 at 02:16, Hemant Kumar wrote:
Hi Loic
On 12/1/2020 10:52 AM, Loic Poulain wrote:
On Tue, 1 Dec 2020 at 18:37, Jeffrey Hugo wrote:
On 12/1/2020 10:36 AM, Loic Poulain wrote:
On Tue, 1 Dec 2020 at 02:16, Hemant Kumar wrote:
Hi Loic,
On 11/30/20 10:22 AM, Loic Poulain wrote:
On Sat, 28 Nov 2020 at 04:26, Hemant Kumar wrote
nces to
expect, and only call mhi_unprepare_for_transfer() for the last one.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
On 11/19/2020 12:02 PM, Bhaumik Bhatt wrote:
On 2020-11-18 11:34 AM, Jeffrey Hugo wrote:
On 11/18/2020 12:14 PM, Loic Poulain wrote:
Le mer. 18 nov. 2020 à 19:34, Jeffrey Hugo <mailto:jh...@codeaurora.org>> a écrit :
On 11/18/2020 11:20 AM, Bhaumik Bhatt wrote:
> Rese
On 11/18/2020 12:14 PM, Loic Poulain wrote:
Le mer. 18 nov. 2020 à 19:34, Jeffrey Hugo <mailto:jh...@codeaurora.org>> a écrit :
On 11/18/2020 11:20 AM, Bhaumik Bhatt wrote:
> Reset MHI device channels when driver remove is called due to
> module unload or any
on to the auto-start being removed,
but this seems odd to me.
As a client, the MHI device is being removed, likely because of some
factor outside of my control, but I still need to clean it up? This
really feels like something MHI should be handling.
--
Jeffrey Hugo
Qualcomm Technologies, In
On 11/10/2020 12:32 PM, John Stultz wrote:
On Tue, Nov 10, 2020 at 11:29 AM Jeffrey Hugo wrote:
On 11/10/2020 12:00 PM, John Stultz wrote:
One fixup following my patch commit be117ca32261 ("pinctrl:
qcom: Kconfig: Rework PINCTRL_MSM to be a depenency rather then
a selected config&qu
mm MSM8953 platform.
Subject should indicate msm8953, no?
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
: Rikard Falkeborn
Reviewed-by: Jeffrey Hugo
d-but-set-variable]
>
> Cc: Andy Gross
> Cc: Bjorn Andersson
> Cc: Greg Kroah-Hartman
> Cc: Jiri Slaby
> Cc: Robert Love
> Cc: linux-arm-...@vger.kernel.org
> Cc: linux-ser...@vger.kernel.org
> Signed-off-by: Lee Jones
Reviewed-by: Jeffrey Hugo
On 10/28/2020 7:12 PM, Carl Yin(殷张成) wrote:
Hi Jeffery:
On Wednesday, October 28, 2020 10:24 PM, jhugo wrote:
On 10/27/2020 7:39 PM, Carl Yin(殷张成) wrote:
Hi Hemant and Jeffery:
On Wednesday, October 28, 2020 7:02 AM, hemantk wrote:
Hi Jeff,
On 10/27/20 8:11 AM, Jeffrey Hugo wrote:
On 10
On 10/27/2020 7:39 PM, Carl Yin(殷张成) wrote:
Hi Hemant and Jeffery:
On Wednesday, October 28, 2020 7:02 AM, hemantk wrote:
Hi Jeff,
On 10/27/20 8:11 AM, Jeffrey Hugo wrote:
On 10/27/2020 3:43 AM, carl@quectel.com wrote:
From: "carl.yin"
MHI wwan modems support download firmwa
On 10/27/2020 5:01 PM, Hemant Kumar wrote:
Hi Jeff,
On 10/27/20 8:11 AM, Jeffrey Hugo wrote:
On 10/27/2020 3:43 AM, carl@quectel.com wrote:
From: "carl.yin"
MHI wwan modems support download firmware to nand or emmc
by firehose protocol, process as next:
1. wwan modem normal
On 10/27/2020 7:18 PM, Carl Yin(殷张成) wrote:
Hi Jeffery and Hemant:
On Wednesday, October 28, 2020 6:44 AM, hemantk wrote:
On 10/27/20 8:06 AM, Jeffrey Hugo wrote:
Hi Carl,
On 10/27/20 8:06 AM, Jeffrey Hugo wrote:
On 10/27/2020 3:43 AM, carl@quectel.com wrote:
From: "carl.yin&qu
I_EE_WFW,
MHI_EE_PTHRU,
MHI_EE_EDL,
- MHI_EE_MAX_SUPPORTED = MHI_EE_EDL,
+ MHI_EE_FP,
+ MHI_EE_MAX_SUPPORTED = MHI_EE_FP,
MHI_EE_DISABLE_TRANSITION, /* local EE, not related to mhi spec */
MHI_EE_NOT_SUPPORTED,
MHI_EE_MAX,
This gets a
serspace should be basing
decisions on the channel name.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
On 10/26/2020 7:46 AM, Dan Williams wrote:
On Mon, 2020-10-26 at 07:38 -0600, Jeffrey Hugo wrote:
On 10/25/2020 3:46 PM, Jakub Kicinski wrote:
On Fri, 23 Oct 2020 16:17:54 -0700 Hemant Kumar wrote:
+UCI driver enables userspace clients to communicate to external
MHI devices
+like modem and
other common channel that is usually used for the multistage
firmware loading process.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
On 10/21/2020 11:46 AM, Hemant Kumar wrote:
Hi Jeff,
On 10/21/20 8:28 AM, Jeffrey Hugo wrote:
On 10/16/2020 10:04 PM, Hemant Kumar wrote:
+release
Should this be "close" since close() is the actual function userspace
would call?
I was keeping kernel driver in mind while writing t
HI channel moves to disabled
+state and inbound buffers are freed.
+
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
the macro parameter can prevent such issues.
Signed-off-by: Jeffrey Hugo
---
drivers/bus/mhi/core/internal.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/mhi/core/internal.h b/drivers/bus/mhi/core/internal.h
index 7989269..78e4e84 100644
--- a/drivers/bus
its node id based on the assigned PCI bus address
(SBDF) The current Router maintainers should probably weigh in to
ensure that won't cause conflicts in the node id space.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
ush.
Are you okay with this?
Nope :)
AIC100 has a single interrupt for BHI/MHI activity, so this needs to be
shared.
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
hi_chan->db_cfg.db_val);
+ seq_printf(m, " local rp: 0x%px local wp: 0x%px db: 0x%pad\n",
+ ring->rp, ring->wp,
+ &mhi_chan->db_cfg.db_val);
}
return 0;
Documentation/printk-formats.txt seems
*/
+static const struct mhi_device_id mhi_uci_match_table[] = {
+ { .chan = "LOOPBACK", .driver_data = 0x1000},
+ {},
+};
+MODULE_DEVICE_TABLE(mhi, mhi_uci_match_table);
+
+static struct mhi_driver mhi_uci_driver = {
+ .id_table = mhi_uci_match_table,
+ .remove = mhi_
T_SYMBOL_GPL(mhi_device_put);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("MHI Host Interface");
I would expect you only need to add the MODULE_* once per module, in
which case main.c is probably the only place that needs it.
--
Jeffrey Hugo
Qualcomm Technolo
On Mon, Jul 20, 2020 at 12:39 AM Can Guo wrote:
>
> Dumping testbus registers needs to sleep a bit intermittently as there are
> too many of them. Skip them for those contexts where sleep is not allowed.
>
> Meanwhile, if ufs_qcom_dump_dbg_regs() calls ufs_qcom_testbus_config() from
> ufshcd_suspe
On Mon, Jul 13, 2020 at 5:50 PM Doug Anderson wrote:
>
> Hi,
>
> On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote:
> >
> > On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote:
> > >
> > > Hi,
> > >
> > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote:
> > > >
> > > > On Fri, Jul 10, 2020 at
On Mon, Jul 13, 2020 at 8:11 AM Rob Herring wrote:
>
> On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson
> wrote:
> >
> > I found that if I ever had a little mistake in my kernel config,
> > or device tree, or graphics driver that my system would sit in a loop
> > at bootup trying again and again
On Mon, Jun 22, 2020 at 4:03 PM Bjorn Andersson
wrote:
>
> The SM8250 pinctrl driver provides pin configuration, pin muxing and
> GPIO pin control for many pins on the SM8250 SoC.
>
> Signed-off-by: Bjorn Andersson
Looks sane to me.
Reviewed-by: Jeffrey Hugo
0x0
+#define QFPROM_MAJOR_VERSION_SHIFT 28
+#define QFPROM_MAJOR_VERSION_MASK 0xf
+#define QFPROM_MINOR_VERSION_SHIFT 16
+#define QFPROM_MINOR_VERSION_MASK 0xf
Minor looks wrong. Documentation says bits 27:16 are the minor version,
and bits 15:0 are step. I think your minor mask needs
On Mon, Jun 15, 2020 at 4:51 PM wrote:
>
> On 2020-06-12 16:26, Stephen Boyd wrote:
>
> Thanks for reviews Stephen.
>
> > Quoting Tanmay Shah (2020-06-11 18:50:25)
> >> These patches add support for Display-Port driver on SnapDragon
> >> hardware. It adds
> >> DP driver and DP PLL driver files alo
By specifying the modem firmware files, we can boot the modem subsystem
which also gives us wifi.
Signed-off-by: Jeffrey Hugo
---
arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts | 5 +
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/msm8998-lenovo-miix-630.dts
b
RPMPD provides us the CS/MX power domains needed to boot the modem
subsystem on msm8998 for wifi.
Signed-off-by: Jeffrey Hugo
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 5212e9c0883f
The label on the l15 regulator node does not follow the style of the
rest of the regulator nodes. Luckily, no one has used the label yet,
so lets fix it.
Fixes: 2c6d2d3a580a ("arm64: dts: qcom: Add Lenovo Miix 630")
Signed-off-by: Jeffrey Hugo
---
arch/arm64/boot/dts/qc
The label on the l15 regulator node does not follow the style of the
rest of the regulator nodes. Luckily, no one has used the label yet,
so lets fix it.
Fixes: 31c1f0e33deb ("arm64: dts: qcom: msm8998: Add RPM and regulators for
MTP")
Signed-off-by: Jeffrey Hugo
---
arch/arm64/boo
ufs_unipro_core_clk_src is required to allow UFS to clock scale for power
savings.
Fixes: b5f5f525c547 ("clk: qcom: Add MSM8998 Global Clock Control (GCC) driver")
Signed-off-by: Jeffrey Hugo
---
drivers/clk/qcom/gcc-msm8998.c | 27
include/dt-bind
On Tue, May 26, 2020 at 11:17 AM Asutosh Das (asd)
wrote:
>
> Hi Jeffrey
> On 5/25/2020 3:19 PM, Jeffrey Hugo wrote:
> > On Wed, Mar 25, 2020 at 12:29 PM Asutosh Das
> > wrote:
> >>
> >> Currently, the frequency that devfreq provides the
> >> dr
On Wed, Mar 25, 2020 at 12:29 PM Asutosh Das wrote:
>
> Currently, the frequency that devfreq provides the
> driver to set always leads the clocks to be scaled up.
> Hence, round the clock-rate to the nearest frequency
> before deciding to scale.
>
> Also update the devfreq statistics of current f
ot crash on the Lenovo Miix 630 when the interrupt is
handled on the idle thread.
Fix the issue by switching to udelay().
Fixes: 9c46b8676271 ("scsi: ufs-qcom: dump additional testbus registers")
Signed-off-by: Jeffrey Hugo
---
drivers/scsi/ufs/ufs-qcom.c | 6 +++---
1 file changed, 3 i
On 5/20/2020 1:44 PM, bbh...@codeaurora.org wrote:
On 2020-05-20 12:06, Jeffrey Hugo wrote:
On 5/20/2020 12:43 PM, bbh...@codeaurora.org wrote:
On 2020-05-20 09:54, Jeffrey Hugo wrote:
On 5/18/2020 2:03 PM, Bhaumik Bhatt wrote:
Allow independent votes from clients such that they can choose
On 5/20/2020 12:43 PM, bbh...@codeaurora.org wrote:
On 2020-05-20 09:54, Jeffrey Hugo wrote:
On 5/18/2020 2:03 PM, Bhaumik Bhatt wrote:
Allow independent votes from clients such that they can choose to vote
for either the device or the bus or both. This helps in cases where the
device supports
. Clients can also vote only to
keep the underlying bus active without having the device in M0 state to
support offload use cases.
Signed-off-by: Bhaumik Bhatt
---
I wonder, why doesn't this fit with runtimePM?
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora For
transfers.
Signed-off-by: Bhaumik Bhatt
---
Reviewed-by: Jeffrey Hugo
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
On 5/20/2020 9:59 AM, Greg Kroah-Hartman wrote:
On Wed, May 20, 2020 at 08:48:13AM -0600, Jeffrey Hugo wrote:
On 5/20/2020 2:34 AM, Daniel Vetter wrote:
On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman
wrote:
On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote:
On Tue, May 19
On 5/20/2020 2:34 AM, Daniel Vetter wrote:
On Wed, May 20, 2020 at 7:15 AM Greg Kroah-Hartman
wrote:
On Tue, May 19, 2020 at 10:41:15PM +0200, Daniel Vetter wrote:
On Tue, May 19, 2020 at 07:41:20PM +0200, Greg Kroah-Hartman wrote:
On Tue, May 19, 2020 at 08:57:38AM -0600, Jeffrey Hugo
On 5/19/2020 12:12 PM, Greg Kroah-Hartman wrote:
On Tue, May 19, 2020 at 12:07:03PM -0600, Jeffrey Hugo wrote:
On 5/19/2020 11:41 AM, Greg Kroah-Hartman wrote:
On Tue, May 19, 2020 at 08:57:38AM -0600, Jeffrey Hugo wrote:
On 5/18/2020 11:08 PM, Dave Airlie wrote:
On Fri, 15 May 2020 at 00:12
1 - 100 of 595 matches
Mail list logo
