[PATCH 2/2] arm64: dts: meson-axg: drop FW reserved memory

2018-10-15 Thread Jerome Brunet
The axg does not require the FW memory region for all we know. This seems to be something we carried for the gx family for no reason. Fixes: 9d59b708500f ("arm64: dts: meson-axg: add initial A113D SoC DT support") Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-ax

[PATCH 2/2] arm64: dts: meson-axg: drop FW reserved memory

2018-10-15 Thread Jerome Brunet
The axg does not require the FW memory region for all we know. This seems to be something we carried for the gx family for no reason. Fixes: 9d59b708500f ("arm64: dts: meson-axg: add initial A113D SoC DT support") Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-ax

[PATCH 2/2] arm64: dts: meson-axg: s400: disable emmc

2018-10-02 Thread Jerome Brunet
do for the reserved memory regions. Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts index

[PATCH 2/2] arm64: dts: meson-axg: s400: disable emmc

2018-10-02 Thread Jerome Brunet
do for the reserved memory regions. Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts index

[PATCH 1/2] arm64: dts: meson-axg: s400: add missing emmc pwrseq

2018-10-02 Thread Jerome Brunet
eMMC pwrseq is defined in the s400 dts but not used in the emmc node. This is probably just a copy/paste error Fixes: 221cf34bac54 ("ARM64: dts: meson-axg: enable the eMMC controller") Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 2 ++ 1 file

[PATCH 0/2] arm64: dts: meson: s400: emmc updates

2018-10-02 Thread Jerome Brunet
This patchset adds the emmc pwrseq to the emmc node and disable the device by default, since eMMC is not the default option for this board. Jerome Brunet (2): arm64: dts: meson-axg: s400: add missing emmc pwrseq arm64: dts: meson-axg: s400: disable emmc arch/arm64/boot/dts/amlogic/meson-axg

[PATCH 1/2] arm64: dts: meson-axg: s400: add missing emmc pwrseq

2018-10-02 Thread Jerome Brunet
eMMC pwrseq is defined in the s400 dts but not used in the emmc node. This is probably just a copy/paste error Fixes: 221cf34bac54 ("ARM64: dts: meson-axg: enable the eMMC controller") Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 2 ++ 1 file

[PATCH 0/2] arm64: dts: meson: s400: emmc updates

2018-10-02 Thread Jerome Brunet
This patchset adds the emmc pwrseq to the emmc node and disable the device by default, since eMMC is not the default option for this board. Jerome Brunet (2): arm64: dts: meson-axg: s400: add missing emmc pwrseq arm64: dts: meson-axg: s400: disable emmc arch/arm64/boot/dts/amlogic/meson-axg

Re: [PATCH 2/2] clk: meson-g12a: Add AO Clock controller driver

2018-09-14 Thread Jerome Brunet
On Tue, 2018-08-28 at 11:35 +0800, Jian Hu wrote: > Hi: Jerome > > On 2018/8/27 21:07, Jerome Brunet wrote: > > On Fri, 2018-08-24 at 21:34 +0800, Jian Hu wrote: > > > > > > > > > > I am confued about aoclk81's parent clocks. > > > >

Re: [PATCH 2/2] clk: meson-g12a: Add AO Clock controller driver

2018-09-14 Thread Jerome Brunet
On Tue, 2018-08-28 at 11:35 +0800, Jian Hu wrote: > Hi: Jerome > > On 2018/8/27 21:07, Jerome Brunet wrote: > > On Fri, 2018-08-24 at 21:34 +0800, Jian Hu wrote: > > > > > > > > > > I am confued about aoclk81's parent clocks. > > > >

Re: [PATCH] leds: pwm: silently error out on EPROBE_DEFER

2018-09-07 Thread Jerome Brunet
On Thu, 2018-09-06 at 17:35 +0200, Pavel Machek wrote: > On Thu 2018-09-06 15:59:04, Jerome Brunet wrote: > > When probing, if we fail to get the pwm due to probe deferal, we shouldn't > > print an error message. Just be silent in this case. > > > > S

Re: [PATCH] leds: pwm: silently error out on EPROBE_DEFER

2018-09-07 Thread Jerome Brunet
On Thu, 2018-09-06 at 17:35 +0200, Pavel Machek wrote: > On Thu 2018-09-06 15:59:04, Jerome Brunet wrote: > > When probing, if we fail to get the pwm due to probe deferal, we shouldn't > > print an error message. Just be silent in this case. > > > > S

[PATCH] leds: pwm: silently error out on EPROBE_DEFER

2018-09-06 Thread Jerome Brunet
When probing, if we fail to get the pwm due to probe deferal, we shouldn't print an error message. Just be silent in this case. Signed-off-by: Jerome Brunet --- drivers/leds/leds-pwm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-pwm.c b/drivers

[PATCH] leds: pwm: silently error out on EPROBE_DEFER

2018-09-06 Thread Jerome Brunet
When probing, if we fail to get the pwm due to probe deferal, we shouldn't print an error message. Just be silent in this case. Signed-off-by: Jerome Brunet --- drivers/leds/leds-pwm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-pwm.c b/drivers

Re: [PATCH 2/3] arm64: dts: meson-axg: s400: add dmic codec

2018-09-03 Thread Jerome Brunet
On Sat, 2018-09-01 at 18:24 -0300, Fabio Estevam wrote: > Hi Jerome, > > On Fri, Aug 31, 2018 at 12:02 PM, Jerome Brunet wrote: > > There are 7 digital mics on the MIC daughter board attached > > to the s400 board, so add the digital microphone codec to > > its DTS >

Re: [PATCH 2/3] arm64: dts: meson-axg: s400: add dmic codec

2018-09-03 Thread Jerome Brunet
On Sat, 2018-09-01 at 18:24 -0300, Fabio Estevam wrote: > Hi Jerome, > > On Fri, Aug 31, 2018 at 12:02 PM, Jerome Brunet wrote: > > There are 7 digital mics on the MIC daughter board attached > > to the s400 board, so add the digital microphone codec to > > its DTS >

[PATCH 0/3] arm64: dts: meson-axg: add pdm support

2018-08-31 Thread Jerome Brunet
://lkml.kernel.org/r/20180829154551.26729-1-jbru...@baylibre.com [1]: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/?h=for-4.20 [2]: https://lkml.kernel.org/r/20180829150051.18190-1-jbru...@baylibre.com Jerome Brunet (3): arm64: dts: meson-axg: add pdm arm64: dts: meson-axg

[PATCH 0/3] arm64: dts: meson-axg: add pdm support

2018-08-31 Thread Jerome Brunet
://lkml.kernel.org/r/20180829154551.26729-1-jbru...@baylibre.com [1]: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/?h=for-4.20 [2]: https://lkml.kernel.org/r/20180829150051.18190-1-jbru...@baylibre.com Jerome Brunet (3): arm64: dts: meson-axg: add pdm arm64: dts: meson-axg

[PATCH 2/3] arm64: dts: meson-axg: s400: add dmic codec

2018-08-31 Thread Jerome Brunet
There are 7 digital mics on the MIC daughter board attached to the s400 board, so add the digital microphone codec to its DTS Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic

[PATCH 1/3] arm64: dts: meson-axg: add pdm

2018-08-31 Thread Jerome Brunet
Add the PDM device of the axg audio subsystem Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index 36be63d69e7f

[PATCH 3/3] arm64: dts: meson-axg: s400: add pdm to the sound card

2018-08-31 Thread Jerome Brunet
Enable the PDM input device on the S400 and it to the sound card Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic

[PATCH 2/3] arm64: dts: meson-axg: s400: add dmic codec

2018-08-31 Thread Jerome Brunet
There are 7 digital mics on the MIC daughter board attached to the s400 board, so add the digital microphone codec to its DTS Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic

[PATCH 1/3] arm64: dts: meson-axg: add pdm

2018-08-31 Thread Jerome Brunet
Add the PDM device of the axg audio subsystem Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi index 36be63d69e7f

[PATCH 3/3] arm64: dts: meson-axg: s400: add pdm to the sound card

2018-08-31 Thread Jerome Brunet
Enable the PDM input device on the S400 and it to the sound card Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic

[PATCH] arm64: dts: meson: libretech: update board model

2018-08-30 Thread Jerome Brunet
There is actually several different libretech board with the CC suffix so the model name is not appropriate here. Update to something more specific Reported-by: Da Xue Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 2 +- 1 file changed, 1

[PATCH] arm64: dts: meson: libretech: update board model

2018-08-30 Thread Jerome Brunet
There is actually several different libretech board with the CC suffix so the model name is not appropriate here. Update to something more specific Reported-by: Da Xue Signed-off-by: Jerome Brunet --- arch/arm64/boot/dts/amlogic/meson-gxl-s905x-libretech-cc.dts | 2 +- 1 file changed, 1

Re: [PATCH v2 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller

2018-08-30 Thread Jerome Brunet
On Thu, 2018-08-30 at 15:37 +0800, Hanjie Lin wrote: > > On 2018/8/29 8:41, Rob Herring wrote: > > On Mon, Aug 27, 2018 at 04:55:20PM +0800, Hanjie Lin wrote: > > > > > > > > > On 2018/8/24 16:22, Jerome Brunet wrote: > > > > On Fri, 2018-08-

Re: [PATCH v2 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller

2018-08-30 Thread Jerome Brunet
On Thu, 2018-08-30 at 15:37 +0800, Hanjie Lin wrote: > > On 2018/8/29 8:41, Rob Herring wrote: > > On Mon, Aug 27, 2018 at 04:55:20PM +0800, Hanjie Lin wrote: > > > > > > > > > On 2018/8/24 16:22, Jerome Brunet wrote: > > > > On Fri, 2018-08-

[PATCH] arm64: dts: meson-axg: sort nodes consistently

2018-08-29 Thread Jerome Brunet
Sort DT nodes by address when possible, by node node name otherwise. Signed-off-by: Jerome Brunet --- Hi Kevin, This patch is same kind of clean-up we already did on gxbb and gxl some time ago. In the same fashion, it ends up being and ugly and almost unreadable patch, sorry about that :( I

[PATCH] arm64: dts: meson-axg: sort nodes consistently

2018-08-29 Thread Jerome Brunet
Sort DT nodes by address when possible, by node node name otherwise. Signed-off-by: Jerome Brunet --- Hi Kevin, This patch is same kind of clean-up we already did on gxbb and gxl some time ago. In the same fashion, it ends up being and ugly and almost unreadable patch, sorry about that :( I

[PATCH 4/4] ASoC: meson: add axg pdm input

2018-08-29 Thread Jerome Brunet
Add pdm input driver for the device found on the amlogic AXG SoC family Signed-off-by: Jerome Brunet --- sound/soc/meson/Kconfig | 9 + sound/soc/meson/Makefile | 2 + sound/soc/meson/axg-pdm.c | 654 ++ 3 files changed, 665 insertions(+) create mode

[PATCH 2/4] ASoC: dmic: add DT module alias

2018-08-29 Thread Jerome Brunet
: of:N*T*Cdmic-codec Now the dmic codec probes automatically when instantiated from DT. Signed-off-by: Jerome Brunet --- sound/soc/codecs/dmic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c index 8c4926df9286..71322e0410ee 100644

[PATCH 4/4] ASoC: meson: add axg pdm input

2018-08-29 Thread Jerome Brunet
Add pdm input driver for the device found on the amlogic AXG SoC family Signed-off-by: Jerome Brunet --- sound/soc/meson/Kconfig | 9 + sound/soc/meson/Makefile | 2 + sound/soc/meson/axg-pdm.c | 654 ++ 3 files changed, 665 insertions(+) create mode

[PATCH 2/4] ASoC: dmic: add DT module alias

2018-08-29 Thread Jerome Brunet
: of:N*T*Cdmic-codec Now the dmic codec probes automatically when instantiated from DT. Signed-off-by: Jerome Brunet --- sound/soc/codecs/dmic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/codecs/dmic.c b/sound/soc/codecs/dmic.c index 8c4926df9286..71322e0410ee 100644

[PATCH 3/4] ASoC: meson: add axg pdm input DT binding documentation

2018-08-29 Thread Jerome Brunet
Add the DT binding documentation for axg's PDM input Signed-off-by: Jerome Brunet --- .../bindings/sound/amlogic,axg-pdm.txt| 24 +++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-pdm.txt diff --git

[PATCH 3/4] ASoC: meson: add axg pdm input DT binding documentation

2018-08-29 Thread Jerome Brunet
Add the DT binding documentation for axg's PDM input Signed-off-by: Jerome Brunet --- .../bindings/sound/amlogic,axg-pdm.txt| 24 +++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/amlogic,axg-pdm.txt diff --git

[PATCH 1/4] ASoC: dmic: add Kconfig prompt for the generic dmic codec.

2018-08-29 Thread Jerome Brunet
Add Kconfig prompt for the generic digital mic to make it configurable through menuconfig Signed-off-by: Jerome Brunet --- sound/soc/codecs/Kconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index adaf26e1989c

[PATCH 0/4] ASoC: meson-axg: add pdm input support

2018-08-29 Thread Jerome Brunet
The purpose of this patchset is to add the support for PDM input backend found on the AXG SoC family. The first 2 patches, for the dmic, are not specific to this amlogic driver but it is useful to have them since the PDM input will use this dmic codec. Jerome Brunet (4): ASoC: dmic: add

[PATCH 1/4] ASoC: dmic: add Kconfig prompt for the generic dmic codec.

2018-08-29 Thread Jerome Brunet
Add Kconfig prompt for the generic digital mic to make it configurable through menuconfig Signed-off-by: Jerome Brunet --- sound/soc/codecs/Kconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index adaf26e1989c

[PATCH 0/4] ASoC: meson-axg: add pdm input support

2018-08-29 Thread Jerome Brunet
The purpose of this patchset is to add the support for PDM input backend found on the AXG SoC family. The first 2 patches, for the dmic, are not specific to this amlogic driver but it is useful to have them since the PDM input will use this dmic codec. Jerome Brunet (4): ASoC: dmic: add

[PATCH] arm64: defconfig: enable modules for amlogic s400 sound card

2018-08-28 Thread Jerome Brunet
Compile the necessary drivers as modules, including codecs, for the s400 sound card. Signed-off-by: Jerome Brunet --- arch/arm64/configs/defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f67e8d5e93ad..6b1daea53bd3

[PATCH] arm64: defconfig: enable modules for amlogic s400 sound card

2018-08-28 Thread Jerome Brunet
Compile the necessary drivers as modules, including codecs, for the s400 sound card. Signed-off-by: Jerome Brunet --- arch/arm64/configs/defconfig | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index f67e8d5e93ad..6b1daea53bd3

[PATCH] ASoC: meson: imply clock and reset controllers

2018-08-28 Thread Jerome Brunet
Add audio clock controller and ARB reset controller module implication for the device using them Signed-off-by: Jerome Brunet --- sound/soc/meson/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/sound/soc/meson/Kconfig b/sound/soc/meson/Kconfig index 8af8bc358a90..2ccbadc387de

[PATCH] ASoC: meson: imply clock and reset controllers

2018-08-28 Thread Jerome Brunet
Add audio clock controller and ARB reset controller module implication for the device using them Signed-off-by: Jerome Brunet --- sound/soc/meson/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/sound/soc/meson/Kconfig b/sound/soc/meson/Kconfig index 8af8bc358a90..2ccbadc387de

[PATCH] ASoC: meson: axg-tdm: restrict formats depending on slot width

2018-08-27 Thread Jerome Brunet
Restrict the formats possible on the TDM interface depending on the width of the TDM slot and let dpcm merging do the rest. Fixes: d60e4f1e4be5 ("ASoC: meson: add tdm interface driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdm-interface.c | 50 +-

[PATCH] ASoC: meson: axg-tdm: restrict formats depending on slot width

2018-08-27 Thread Jerome Brunet
Restrict the formats possible on the TDM interface depending on the width of the TDM slot and let dpcm merging do the rest. Fixes: d60e4f1e4be5 ("ASoC: meson: add tdm interface driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdm-interface.c | 50 +-

[PATCH] ASoC: meson: axg-fifo: report interrupt request failure

2018-08-27 Thread Jerome Brunet
Return value of request_irq() was irgnored. Fix this and report the failure if any Fixes: 6dc4fa179fb8 ("ASoC: meson: add axg fifo base driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-fifo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/meson/axg-fifo

[PATCH] ASoC: meson: axg-fifo: report interrupt request failure

2018-08-27 Thread Jerome Brunet
Return value of request_irq() was irgnored. Fix this and report the failure if any Fixes: 6dc4fa179fb8 ("ASoC: meson: add axg fifo base driver") Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-fifo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/meson/axg-fifo

Re: [PATCH] clk: meson-axg: pcie: drop the mpll3 clock parent

2018-08-27 Thread Jerome Brunet
On Wed, 2018-08-01 at 12:16 +, Yixun Lan wrote: > We found the PCIe driver doesn't really work with > the mpll3 clock which is actually reserved for debug, > So drop it from the mux list. > > Fixes: 33b89db68236 ("clk: meson-axg: add clocks required by pcie driver") > Tested-by: Jianxin Qin

Re: [PATCH] clk: meson-axg: pcie: drop the mpll3 clock parent

2018-08-27 Thread Jerome Brunet
On Wed, 2018-08-01 at 12:16 +, Yixun Lan wrote: > We found the PCIe driver doesn't really work with > the mpll3 clock which is actually reserved for debug, > So drop it from the mux list. > > Fixes: 33b89db68236 ("clk: meson-axg: add clocks required by pcie driver") > Tested-by: Jianxin Qin

Re: [PATCH 2/2] clk: meson-g12a: Add AO Clock controller driver

2018-08-27 Thread Jerome Brunet
On Fri, 2018-08-24 at 21:34 +0800, Jian Hu wrote: > > > > I am confued about aoclk81's parent clocks. > > I can not get the example of axg audio clock driver, Could you provide > the link? Had it merged into clk-meson.git? Yes and mainline as well : drivers/clk/meson/axg-audio.c Basically

Re: [PATCH 2/2] clk: meson-g12a: Add AO Clock controller driver

2018-08-27 Thread Jerome Brunet
On Fri, 2018-08-24 at 21:34 +0800, Jian Hu wrote: > > > > I am confued about aoclk81's parent clocks. > > I can not get the example of axg audio clock driver, Could you provide > the link? Had it merged into clk-meson.git? Yes and mainline as well : drivers/clk/meson/axg-audio.c Basically

Re: [PATCH] clk: meson: axg: round audio system master clocks down

2018-08-27 Thread Jerome Brunet
On Wed, 2018-08-01 at 16:07 +0200, Jerome Brunet wrote: > Some of the master clocks provided by the axg audio clock controller are > system clock (spdifin and pdm sysclk). They are used to clock an internal > DSP of the related devices. Having them constantly rounded down instead >

Re: [PATCH] clk: meson: axg: round audio system master clocks down

2018-08-27 Thread Jerome Brunet
On Wed, 2018-08-01 at 16:07 +0200, Jerome Brunet wrote: > Some of the master clocks provided by the axg audio clock controller are > system clock (spdifin and pdm sysclk). They are used to clock an internal > DSP of the related devices. Having them constantly rounded down instead >

Re: [PATCH v2 0/4] clk: meson: clk-pll driver update

2018-08-27 Thread Jerome Brunet
On Sun, 2018-08-12 at 20:26 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Wed, Aug 1, 2018 at 4:00 PM Jerome Brunet wrote: > > > > This patchset is yet another round of update to the amlogic pll driver. > > > > 1) Enable bit is added so we don't r

Re: [PATCH v2 0/4] clk: meson: clk-pll driver update

2018-08-27 Thread Jerome Brunet
On Sun, 2018-08-12 at 20:26 +0200, Martin Blumenstingl wrote: > Hi Jerome, > > On Wed, Aug 1, 2018 at 4:00 PM Jerome Brunet wrote: > > > > This patchset is yet another round of update to the amlogic pll driver. > > > > 1) Enable bit is added so we don't r

Re: [PATCH v2 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller

2018-08-24 Thread Jerome Brunet
On Fri, 2018-08-24 at 15:36 +0800, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds documentation for the DT bindings in Meson PCIe > controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin

Re: [PATCH v2 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller

2018-08-24 Thread Jerome Brunet
On Fri, 2018-08-24 at 15:36 +0800, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds documentation for the DT bindings in Meson PCIe > controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin

Re: [PATCH v2 2/2] PCI: meson: add the Amlogic Meson PCIe controller driver

2018-08-24 Thread Jerome Brunet
On Fri, 2018-08-24 at 15:36 +0800, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds the driver support for Meson PCIe controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin > --- >

Re: [PATCH v2 2/2] PCI: meson: add the Amlogic Meson PCIe controller driver

2018-08-24 Thread Jerome Brunet
On Fri, 2018-08-24 at 15:36 +0800, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds the driver support for Meson PCIe controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin > --- >

Re: [PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver

2018-08-17 Thread Jerome Brunet
On Fri, 2018-08-17 at 14:12 +0800, Hanjie Lin wrote: > > On 2018/8/16 16:33, Jerome Brunet wrote: > > On Thu, 2018-08-16 at 11:05 +0800, Hanjie Lin wrote: > > > > > > On 2018/8/14 18:41, Jerome Brunet wrote: > > > > On Tue, 2018-08-14 at 02:12 -0400,

Re: [PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver

2018-08-17 Thread Jerome Brunet
On Fri, 2018-08-17 at 14:12 +0800, Hanjie Lin wrote: > > On 2018/8/16 16:33, Jerome Brunet wrote: > > On Thu, 2018-08-16 at 11:05 +0800, Hanjie Lin wrote: > > > > > > On 2018/8/14 18:41, Jerome Brunet wrote: > > > > On Tue, 2018-08-14 at 02:12 -0400,

Re: [PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver

2018-08-16 Thread Jerome Brunet
On Thu, 2018-08-16 at 11:05 +0800, Hanjie Lin wrote: > > On 2018/8/14 18:41, Jerome Brunet wrote: > > On Tue, 2018-08-14 at 02:12 -0400, Hanjie Lin wrote: > > > From: Yue Wang > > > > > > The Meson-PCIE-PHY controller supports the 5-Gbps data rate >

Re: [PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver

2018-08-16 Thread Jerome Brunet
On Thu, 2018-08-16 at 11:05 +0800, Hanjie Lin wrote: > > On 2018/8/14 18:41, Jerome Brunet wrote: > > On Tue, 2018-08-14 at 02:12 -0400, Hanjie Lin wrote: > > > From: Yue Wang > > > > > > The Meson-PCIE-PHY controller supports the 5-Gbps data rate >

Re: [PATCH 2/2] clk: meson-g12a: Add AO Clock controller driver

2018-08-14 Thread Jerome Brunet
On Fri, 2018-08-10 at 17:54 +0800, Jian Hu wrote: > Add a Clock driver for the ALways-On part > of the Amlogic Meson-G12A SoC. > > Signed-off-by: Jian Hu > --- > drivers/clk/meson/Makefile | 2 +- > drivers/clk/meson/g12a-aoclk.c | 170 > + >

Re: [PATCH 2/2] clk: meson-g12a: Add AO Clock controller driver

2018-08-14 Thread Jerome Brunet
On Fri, 2018-08-10 at 17:54 +0800, Jian Hu wrote: > Add a Clock driver for the ALways-On part > of the Amlogic Meson-G12A SoC. > > Signed-off-by: Jian Hu > --- > drivers/clk/meson/Makefile | 2 +- > drivers/clk/meson/g12a-aoclk.c | 170 > + >

Re: [PATCH v3 0/2] arm64: dts: meson-g12a: Introduce new DT files for Meson-G12A SoC

2018-08-14 Thread Jerome Brunet
rm64/boot/dts/amlogic/meson-g12a-u200.dts | 22 +++ > arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 172 > ++ > 4 files changed, 201 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts > create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a.dtsi > Series looks good as far as I can tell Reviewed-by: Jerome Brunet

Re: [PATCH v3 0/2] arm64: dts: meson-g12a: Introduce new DT files for Meson-G12A SoC

2018-08-14 Thread Jerome Brunet
rm64/boot/dts/amlogic/meson-g12a-u200.dts | 22 +++ > arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 172 > ++ > 4 files changed, 201 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a-u200.dts > create mode 100644 arch/arm64/boot/dts/amlogic/meson-g12a.dtsi > Series looks good as far as I can tell Reviewed-by: Jerome Brunet

Re: [PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver

2018-08-14 Thread Jerome Brunet
On Tue, 2018-08-14 at 02:12 -0400, Hanjie Lin wrote: > From: Yue Wang > > The Meson-PCIE-PHY controller supports the 5-Gbps data rate > of the PCI Express Gen 2 specification and is backwardcompatible > with the 2.5-Gbps Gen 1.1 specification with only > inferred idle detection supported on

Re: [PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe phy driver

2018-08-14 Thread Jerome Brunet
On Tue, 2018-08-14 at 02:12 -0400, Hanjie Lin wrote: > From: Yue Wang > > The Meson-PCIE-PHY controller supports the 5-Gbps data rate > of the PCI Express Gen 2 specification and is backwardcompatible > with the 2.5-Gbps Gen 1.1 specification with only > inferred idle detection supported on

Re: [PATCH 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller

2018-08-14 Thread Jerome Brunet
On Tue, 2018-08-14 at 02:18 -0400, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds documentation for the DT bindings in Meson PCIe > controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin

Re: [PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe controller driver

2018-08-14 Thread Jerome Brunet
On Tue, 2018-08-14 at 02:18 -0400, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds the driver support for Meson PCIe controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin > --- >

Re: [PATCH 1/2] dt-bindings: PCI: meson: add DT bindings for Amlogic Meson PCIe controller

2018-08-14 Thread Jerome Brunet
On Tue, 2018-08-14 at 02:18 -0400, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds documentation for the DT bindings in Meson PCIe > controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin

Re: [PATCH 2/2] PCI: meson: add the Amlogic Meson PCIe controller driver

2018-08-14 Thread Jerome Brunet
On Tue, 2018-08-14 at 02:18 -0400, Hanjie Lin wrote: > From: Yue Wang > > The Amlogic Meson PCIe host controller is based on the Synopsys DesignWare > PCI core. This patch adds the driver support for Meson PCIe controller. > > Signed-off-by: Yue Wang > Signed-off-by: Hanjie Lin > --- >

Re: [PATCH v2 2/2] arm64: dts: meson-g12a: add initial g12a s905d2 SoC DT support

2018-08-13 Thread Jerome Brunet
On Mon, 2018-08-13 at 19:48 +0800, Jianxin Pan wrote: > Try to add basic DT support for the Amlogic's Meson-G12A S905D2 SoC, > which describe components as follows: Reserve Memory, CPU, GIC, IRQ, > Timer, UART. It's capable of booting up into the serial console. > > Signed-off-by: Jianxin Pan >

Re: [PATCH v2 2/2] arm64: dts: meson-g12a: add initial g12a s905d2 SoC DT support

2018-08-13 Thread Jerome Brunet
On Mon, 2018-08-13 at 19:48 +0800, Jianxin Pan wrote: > Try to add basic DT support for the Amlogic's Meson-G12A S905D2 SoC, > which describe components as follows: Reserve Memory, CPU, GIC, IRQ, > Timer, UART. It's capable of booting up into the serial console. > > Signed-off-by: Jianxin Pan >

Re: [PATCH v4 3/3] clk: meson: add sub MMC clock controller driver

2018-08-10 Thread Jerome Brunet
file mode 100644 > index ..6aa055f7e62c > --- /dev/null > +++ b/drivers/clk/meson/mmc-clkc.c > @@ -0,0 +1,275 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Amlogic Meson MMC Sub Clock Controller Driver > + * > + * Copyright (c) 2017 Baylibre SAS. > + * Aut

Re: [PATCH v4 3/3] clk: meson: add sub MMC clock controller driver

2018-08-10 Thread Jerome Brunet
file mode 100644 > index ..6aa055f7e62c > --- /dev/null > +++ b/drivers/clk/meson/mmc-clkc.c > @@ -0,0 +1,275 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Amlogic Meson MMC Sub Clock Controller Driver > + * > + * Copyright (c) 2017 Baylibre SAS. > + * Aut

Re: [PATCH v4 1/3] clk: meson: add emmc sub clock phase delay driver

2018-08-10 Thread Jerome Brunet
elay.c > b/drivers/clk/meson/clk-phase-delay.c > new file mode 100644 > index ..6f226814cfec > --- /dev/null > +++ b/drivers/clk/meson/clk-phase-delay.c > @@ -0,0 +1,96 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Amlogic Meson MMC Sub Clock Controll

Re: [PATCH v4 1/3] clk: meson: add emmc sub clock phase delay driver

2018-08-10 Thread Jerome Brunet
elay.c > b/drivers/clk/meson/clk-phase-delay.c > new file mode 100644 > index ..6f226814cfec > --- /dev/null > +++ b/drivers/clk/meson/clk-phase-delay.c > @@ -0,0 +1,96 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Amlogic Meson MMC Sub Clock Controll

Re: [PATCH 2/2] arm64: dts: meson-g12a: add initial g12a s905d2 SoC DT support

2018-08-10 Thread Jerome Brunet
On Thu, 2018-08-09 at 16:22 +0800, Jianxin Pan wrote: > Try to add basic DT support for the Amlogic's Meson-G12A S905D2 SoC, > which describe components as follows: Reserve Memory, CPU, GIC, IRQ, > Timer, UART. It's capable of booting up into the serial console. > > Signed-off-by: Jianxin Could

Re: [PATCH 2/2] arm64: dts: meson-g12a: add initial g12a s905d2 SoC DT support

2018-08-10 Thread Jerome Brunet
On Thu, 2018-08-09 at 16:22 +0800, Jianxin Pan wrote: > Try to add basic DT support for the Amlogic's Meson-G12A S905D2 SoC, > which describe components as follows: Reserve Memory, CPU, GIC, IRQ, > Timer, UART. It's capable of booting up into the serial console. > > Signed-off-by: Jianxin Could

Re: [PATCH v2 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes.

2018-08-08 Thread Jerome Brunet
On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote: > Wrap the canvas node in a syscon node. > > Signed-off-by: Maxime Jourdan > --- > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 + > 1 file changed, 17 insertions(+) > > diff --git

Re: [PATCH v2 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes.

2018-08-08 Thread Jerome Brunet
On Wed, 2018-08-08 at 00:00 +0200, Maxime Jourdan wrote: > Wrap the canvas node in a syscon node. > > Signed-off-by: Maxime Jourdan > --- > arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 17 + > 1 file changed, 17 insertions(+) > > diff --git

Re: [PATCH v2 1/4] soc: amlogic: add meson-canvas driver

2018-08-08 Thread Jerome Brunet
h some answers to the nitpicks below, feel free to add : Reviewed-by: Jerome Brunet > --- > drivers/soc/amlogic/Kconfig | 7 + > drivers/soc/amlogic/Makefile | 1 + > drivers/soc/amlogic/meson-canvas.c | 185 +++ > i

Re: [PATCH v2 1/4] soc: amlogic: add meson-canvas driver

2018-08-08 Thread Jerome Brunet
h some answers to the nitpicks below, feel free to add : Reviewed-by: Jerome Brunet > --- > drivers/soc/amlogic/Kconfig | 7 + > drivers/soc/amlogic/Makefile | 1 + > drivers/soc/amlogic/meson-canvas.c | 185 +++ > i

Re: [PATCH 2/5] pinctrl: meson: Add support to set direction with a secure monitor call

2018-08-02 Thread Jerome Brunet
On Thu, 2018-08-02 at 09:52 +0200, Neil Armstrong wrote: > On 01/08/2018 22:23, Martin Blumenstingl wrote: > > Hi Neil, > > > > On Wed, Aug 1, 2018 at 12:05 PM Neil Armstrong > > wrote: > > > > > > The Amlogic Meson GX and AXG SoCs needs to do a Secure Monitor call to > > > set the TEST_N pin

Re: [PATCH 2/5] pinctrl: meson: Add support to set direction with a secure monitor call

2018-08-02 Thread Jerome Brunet
On Thu, 2018-08-02 at 09:52 +0200, Neil Armstrong wrote: > On 01/08/2018 22:23, Martin Blumenstingl wrote: > > Hi Neil, > > > > On Wed, Aug 1, 2018 at 12:05 PM Neil Armstrong > > wrote: > > > > > > The Amlogic Meson GX and AXG SoCs needs to do a Secure Monitor call to > > > set the TEST_N pin

Re: [PATCH v2 2/2] reset: meson: add meson audio arb driver

2018-08-02 Thread Jerome Brunet
On Fri, 2018-07-20 at 18:19 +0200, Philipp Zabel wrote: > Hi Jerome, > > On Fri, 2018-07-20 at 17:26 +0200, Jerome Brunet wrote: > > The Amlogic Audio ARB is a simple device which enables or > > disables the access of Audio FIFOs to DDR on AXG based SoC. > > >

Re: [PATCH v2 2/2] reset: meson: add meson audio arb driver

2018-08-02 Thread Jerome Brunet
On Fri, 2018-07-20 at 18:19 +0200, Philipp Zabel wrote: > Hi Jerome, > > On Fri, 2018-07-20 at 17:26 +0200, Jerome Brunet wrote: > > The Amlogic Audio ARB is a simple device which enables or > > disables the access of Audio FIFOs to DDR on AXG based SoC. > > >

[PATCH] clk: meson: axg: round audio system master clocks down

2018-08-01 Thread Jerome Brunet
Some of the master clocks provided by the axg audio clock controller are system clock (spdifin and pdm sysclk). They are used to clock an internal DSP of the related devices. Having them constantly rounded down instead of closest is preferable. Signed-off-by: Jerome Brunet --- drivers/clk/meson

[PATCH] clk: meson: axg: round audio system master clocks down

2018-08-01 Thread Jerome Brunet
Some of the master clocks provided by the axg audio clock controller are system clock (spdifin and pdm sysclk). They are used to clock an internal DSP of the related devices. Having them constantly rounded down instead of closest is preferable. Signed-off-by: Jerome Brunet --- drivers/clk/meson

[PATCH v2 4/4] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-08-01 Thread Jerome Brunet
from the tables. Acked-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 73 +++--- drivers/clk/meson/clk-pll.c | 69 ++--- drivers/clk/meson/clkc.h| 8 +-- drivers/clk/meson/gxbb.c| 120

[PATCH v2 4/4] clk: meson: clk-pll: drop hard-coded rates from pll tables

2018-08-01 Thread Jerome Brunet
from the tables. Acked-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 73 +++--- drivers/clk/meson/clk-pll.c | 69 ++--- drivers/clk/meson/clkc.h| 8 +-- drivers/clk/meson/gxbb.c| 120

[PATCH v2 3/4] clk: meson: clk-pll: remove od parameters

2018-08-01 Thread Jerome Brunet
and whether or not it depends on the input clock rate. Acked-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 284 +++-- drivers/clk/meson/axg.h | 8 +- drivers/clk/meson/clk-pll.c | 40 +-- drivers/clk/meson/clkc.h| 9 +- drivers/clk/meson

[PATCH v2 3/4] clk: meson: clk-pll: remove od parameters

2018-08-01 Thread Jerome Brunet
and whether or not it depends on the input clock rate. Acked-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 284 +++-- drivers/clk/meson/axg.h | 8 +- drivers/clk/meson/clk-pll.c | 40 +-- drivers/clk/meson/clkc.h| 9 +- drivers/clk/meson

[PATCH v2 1/4] clk: meson: clk-pll: add enable bit

2018-08-01 Thread Jerome Brunet
using generic clocks elements Acked-by: Neil Armstrong Acked-by: Martin Blumenstingl Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 28 +++--- drivers/clk/meson/clk-pll.c | 47 + drivers/clk/meson/clkc.h| 1 + drivers/clk

[PATCH v2 2/4] clk: meson: clk-pll: drop CLK_GET_RATE_NOCACHE where unnecessary

2018-08-01 Thread Jerome Brunet
. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 1 - drivers/clk/meson/gxbb.c| 12 drivers/clk/meson/meson8b.c | 3 --- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 6d8976554656..991fa511c05a

[PATCH v2 1/4] clk: meson: clk-pll: add enable bit

2018-08-01 Thread Jerome Brunet
using generic clocks elements Acked-by: Neil Armstrong Acked-by: Martin Blumenstingl Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 28 +++--- drivers/clk/meson/clk-pll.c | 47 + drivers/clk/meson/clkc.h| 1 + drivers/clk

[PATCH v2 2/4] clk: meson: clk-pll: drop CLK_GET_RATE_NOCACHE where unnecessary

2018-08-01 Thread Jerome Brunet
. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 1 - drivers/clk/meson/gxbb.c| 12 drivers/clk/meson/meson8b.c | 3 --- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 6d8976554656..991fa511c05a

<    5   6   7   8   9   10   11   12   13   14   >