and
narrow it down to one (or a few) commits that are causing your trouble.
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line unsubscribe linux
There is no need to include version.h in sound/soc/codecs/isabelle.c -
this patch removes the pointless include.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
sound/soc/codecs/isabelle.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/codecs/isabelle.c b/sound/soc/codecs
On Fri, 10 Aug 2012, Mark Brown wrote:
On Fri, Aug 10, 2012 at 08:12:57PM +0200, Jesper Juhl wrote:
There is no need to include version.h in sound/soc/codecs/isabelle.c -
this patch removes the pointless include.
Not sure what this patch is against, there appears to be no include
Include version.h where actually needed, remove where unneeded.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/csr/csr_panic.c| 1 -
drivers/staging/csr/drv.c | 3 +--
drivers/staging/csr/io.c | 2 +-
drivers/staging/csr/monitor.c
On Wed, 8 Aug 2012, Jesper Juhl wrote:
> On Wed, 8 Aug 2012, Alexei Kornienko wrote:
>
> > Seems like I have a bug in audio driver on my laptop. Cause of this I
> > don't have any sound card detected.
> > Please find more details below:
> >
> > ** Version:
&g
nel. So,
perhaps you could test the 3.5 kernel and tell us if you still see the
problem with that one or not?
If you are feeling adventurous you could also try a snapshot of the latest
Linus (to become 3.6) kernel and tell us your experiences with that...?
--
Jesper Juhlhttp://www.ch
mon *common;
> int err;
>
> - memset(, 0, sizeof fsg);
> + memset(, 0, sizeof(fsg));
> fsg.nluns = 1;
> fsg.luns[0].removable = 1;
> fsg.vendor_name = iManufacturer;
>
Looks good to me.
Reviewed-by: Jesper Juhl
--
Jesper Juhlht
On Wed, 8 Aug 2012, Dmitry Torokhov wrote:
> On Wednesday, August 08, 2012 09:36:51 PM Jesper Juhl wrote:
> > On Wed, 8 Aug 2012, Sachin Kamat wrote:
> > > On 7 August 2012 23:46, Jesper Juhl wrote:
> > > > If omap4_keypad_parse_dt() does not return 0 (zero) in
&
On Wed, 8 Aug 2012, Sachin Kamat wrote:
> On 7 August 2012 23:46, Jesper Juhl wrote:
> > If omap4_keypad_parse_dt() does not return 0 (zero) in
> > omap4_keypad_probe() we will leak the memory we allocated for
> > 'keypad_data' with kzalloc() when we return and the variable
there.
While I was there I noticed that the error message that is printet if
setsockopt() fails was broken over two lines - put that on a single
line so it is easier to grep for.
Signed-off-by: Jesper Juhl
---
Documentation/accounting/getdelays.c | 5 ++---
1 file changed, 2 insertions(+), 3
there.
While I was there I noticed that the error message that is printet if
setsockopt() fails was broken over two lines - put that on a single
line so it is easier to grep for.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
Documentation/accounting/getdelays.c | 5 ++---
1 file changed, 2
On Wed, 8 Aug 2012, Sachin Kamat wrote:
On 7 August 2012 23:46, Jesper Juhl j...@chaosbits.net wrote:
If omap4_keypad_parse_dt() does not return 0 (zero) in
omap4_keypad_probe() we will leak the memory we allocated for
'keypad_data' with kzalloc() when we return and the variable goes out
On Wed, 8 Aug 2012, Dmitry Torokhov wrote:
On Wednesday, August 08, 2012 09:36:51 PM Jesper Juhl wrote:
On Wed, 8 Aug 2012, Sachin Kamat wrote:
On 7 August 2012 23:46, Jesper Juhl j...@chaosbits.net wrote:
If omap4_keypad_parse_dt() does not return 0 (zero) in
omap4_keypad_probe
;
- memset(fsg, 0, sizeof fsg);
+ memset(fsg, 0, sizeof(fsg));
fsg.nluns = 1;
fsg.luns[0].removable = 1;
fsg.vendor_name = iManufacturer;
Looks good to me.
Reviewed-by: Jesper Juhl j...@chaosbits.net
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net
the 3.5 kernel and tell us if you still see the
problem with that one or not?
If you are feeling adventurous you could also try a snapshot of the latest
Linus (to become 3.6) kernel and tell us your experiences with that...?
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top
On Wed, 8 Aug 2012, Jesper Juhl wrote:
On Wed, 8 Aug 2012, Alexei Kornienko wrote:
Seems like I have a bug in audio driver on my laptop. Cause of this I
don't have any sound card detected.
Please find more details below:
** Version:
Linux version 3.2.0-29-generic-pae (buildd
If write fails, remember to close(fd) before returning.
Signed-off-by: Jesper Juhl
---
Documentation/ia64/aliasing-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/ia64/aliasing-test.c
b/Documentation/ia64/aliasing-test.c
index 5caa2af..62a190d 100644
the memory we allocated.
Deal with the leak by always calling 'usb_free_urb(req)' when entering
the branch. If 'req' happens to be 0 then the call is harmless, if it
is not 0 then we free the memory we allocated but don't need.
Signed-off-by: Jesper Juhl
---
drivers/net/usb/cdc-phonet.c | 1 +
1
.
Unfortunately we just get NULL back, so we can't really tell the user
exactely what went wrong, but we can at least avoid crashing and
return an error (-EIO seemed more generic and more suitable here than
-ENOMEM or something else, so I picked that).
Signed-off-by: Jesper Juhl
---
drivers/char
Signed-off-by: Jesper Juhl
---
drivers/acpi/osl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 9eaf708..b9eb753 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1061,7 +1061,7 @@ acpi_status acpi_os_wait_semaphore
If we end up returning -EINVAL from the function we will leak the
memory allocated to 'newstr' which has been allocated but not yet
assigned to anything.
Fix the leak by properly freeing the memory again before we return.
Signed-off-by: Jesper Juhl
---
drivers/staging/speakup/i18n.c | 1 +
1
On Tue, 7 Aug 2012, Jesper Juhl wrote:
> Memory is allocated for 'tt_change_node' with kmalloc().
> 'tt_change_node' may go out of scope really being used for anything
This should of course read "... go out of scope without really being used ..." .
> (except have a few
Memory is allocated for 'tt_change_node' with kmalloc().
'tt_change_node' may go out of scope really being used for anything
(except have a few members initialized) if we hit the 'del:' label.
This patch makes sure we free the memory in that case.
Signed-off-by: Jesper Juhl
---
net/batman-adv
, instead of returning directly.
Signed-off-by: Jesper Juhl
---
drivers/input/keyboard/omap4-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Compile tested only.
diff --git a/drivers/input/keyboard/omap4-keypad.c
b/drivers/input/keyboard/omap4-keypad.c
index c05f98c..9c2ac87
If prepare_reply() succeeds we have allocated memory for 'rep_skb'. If
nla_reserve() then subsequently fails and returns NULL we fail to
release the memory we allocated, thus causing a leak.
Signed-off-by: Jesper Juhl
---
kernel/taskstats.c | 1 +
1 file changed, 1 insertion(+)
Compile tested
If prepare_reply() succeeds we have allocated memory for 'rep_skb'. If
nla_reserve() then subsequently fails and returns NULL we fail to
release the memory we allocated, thus causing a leak.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
kernel/taskstats.c | 1 +
1 file changed, 1 insertion
, instead of returning directly.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/input/keyboard/omap4-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Compile tested only.
diff --git a/drivers/input/keyboard/omap4-keypad.c
b/drivers/input/keyboard/omap4-keypad.c
index
Memory is allocated for 'tt_change_node' with kmalloc().
'tt_change_node' may go out of scope really being used for anything
(except have a few members initialized) if we hit the 'del:' label.
This patch makes sure we free the memory in that case.
Signed-off-by: Jesper Juhl j...@chaosbits.net
On Tue, 7 Aug 2012, Jesper Juhl wrote:
Memory is allocated for 'tt_change_node' with kmalloc().
'tt_change_node' may go out of scope really being used for anything
This should of course read ... go out of scope without really being used ... .
(except have a few members initialized) if we hit
If we end up returning -EINVAL from the function we will leak the
memory allocated to 'newstr' which has been allocated but not yet
assigned to anything.
Fix the leak by properly freeing the memory again before we return.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/speakup
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/acpi/osl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 9eaf708..b9eb753 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1061,7 +1061,7 @@ acpi_status
.
Unfortunately we just get NULL back, so we can't really tell the user
exactely what went wrong, but we can at least avoid crashing and
return an error (-EIO seemed more generic and more suitable here than
-ENOMEM or something else, so I picked that).
Signed-off-by: Jesper Juhl j...@chaosbits.net
the memory we allocated.
Deal with the leak by always calling 'usb_free_urb(req)' when entering
the branch. If 'req' happens to be 0 then the call is harmless, if it
is not 0 then we free the memory we allocated but don't need.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/net/usb/cdc
If write fails, remember to close(fd) before returning.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
Documentation/ia64/aliasing-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/ia64/aliasing-test.c
b/Documentation/ia64/aliasing-test.c
index 5caa2af..62a190d 100644
On Sun, 5 Aug 2012, Daniel Vetter wrote:
> On Tue, Jul 31, 2012 at 10:31:15PM +0200, Jesper Juhl wrote:
> > If the allocation of 'buf' succeeds but the allocation of 'msgs' fails
> > we'll return false and leak 'buf' when it goes out of scope.
> >
> > Signed-off
On Sun, 5 Aug 2012, Daniel Vetter wrote:
On Tue, Jul 31, 2012 at 10:31:15PM +0200, Jesper Juhl wrote:
If the allocation of 'buf' succeeds but the allocation of 'msgs' fails
we'll return false and leak 'buf' when it goes out of scope.
Signed-off-by: Jesper Juhl j...@chaosbits.net
I've
In bnx2x_mcast_enqueue_cmd() we'll leak the memory allocated to
'new_cmd' if we hit the deafault case of the 'switch (cmd)'.
Add a 'kfree(new_cmd)' to that case to avoid the leak.
Signed-off-by: Jesper Juhl
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 1 +
1 file changed, 1 insertion
On Tue, 31 Jul 2012, Jeff Kirsher wrote:
> On Tue, 2012-07-31 at 22:23 +0200, Jesper Juhl wrote:
> > On Wed, 25 Jul 2012, Wyborny, Carolyn wrote:
> >
> > >
> > > > -Original Message-
> > > > From: Jesper Juhl [mailto:j...@chaosbits.net]
If the allocation of 'buf' succeeds but the allocation of 'msgs' fails
we'll return false and leak 'buf' when it goes out of scope.
Signed-off-by: Jesper Juhl
---
drivers/gpu/drm/i915/intel_sdvo.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
note: compile tested only due
On Wed, 25 Jul 2012, Wyborny, Carolyn wrote:
>
> > -Original Message-
> > From: Jesper Juhl [mailto:j...@chaosbits.net]
> > Sent: Wednesday, July 25, 2012 12:06 PM
> > To: linux-kernel@vger.kernel.org
> > Cc: net...@vger.kernel.org; e1000-de.
On Wed, 25 Jul 2012, Wyborny, Carolyn wrote:
-Original Message-
From: Jesper Juhl [mailto:j...@chaosbits.net]
Sent: Wednesday, July 25, 2012 12:06 PM
To: linux-kernel@vger.kernel.org
Cc: net...@vger.kernel.org; e1000-de...@lists.sourceforge.net; Wyborny,
Carolyn; Pieper
If the allocation of 'buf' succeeds but the allocation of 'msgs' fails
we'll return false and leak 'buf' when it goes out of scope.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/gpu/drm/i915/intel_sdvo.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
note
On Tue, 31 Jul 2012, Jeff Kirsher wrote:
On Tue, 2012-07-31 at 22:23 +0200, Jesper Juhl wrote:
On Wed, 25 Jul 2012, Wyborny, Carolyn wrote:
-Original Message-
From: Jesper Juhl [mailto:j...@chaosbits.net]
Sent: Wednesday, July 25, 2012 12:06 PM
To: linux-kernel
In bnx2x_mcast_enqueue_cmd() we'll leak the memory allocated to
'new_cmd' if we hit the deafault case of the 'switch (cmd)'.
Add a 'kfree(new_cmd)' to that case to avoid the leak.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c | 1 +
1 file
Git has the code if we ever need it, so instead of having chunks of
commented out code clutter up the file get rid of it.
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6656/hostap.c | 45 +
1 file changed, 1 insertion(+), 44 deletions(-)
diff --git
Convert a few tabs to spaces, remove some pointless whitespace, add
some missing whitespace (in drivers/staging/vt6656/hostap.c).
All quite small and trivial.
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6656/hostap.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff
We use tabs for indentation, not spaces.
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6656/hostap.c | 644 +++-
1 file changed, 301 insertions(+), 343 deletions(-)
diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656/hostap.c
index
This trivial patch simply removes some completely redundant blank
lines from drivers/staging/vt6656/hostap.c
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6656/hostap.c | 40
1 file changed, 40 deletions(-)
diff --git a/drivers/staging/vt6656
Don't return -EOPNOTSUPP directly in switch case's since it'll leak
the memory allocated to 'param' when that variable goes out of scope
without having been assigned to anything.
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6656/hostap.c | 12 ++--
1 file changed, 6 insertions(+), 6
Hi Greg
Here's a small series of patches that fixes some memory leaks and cleans
up the code a bit for vt6656 hostapd.c - done on top of Linus' tree as of
today.
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails
Hi Greg
Here's a small series of patches that fixes some memory leaks and cleans
up the code a bit for vt6656 hostapd.c - done on top of Linus' tree as of
today.
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Don't return -EOPNOTSUPP directly in switch case's since it'll leak
the memory allocated to 'param' when that variable goes out of scope
without having been assigned to anything.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/vt6656/hostap.c | 12 ++--
1 file changed
This trivial patch simply removes some completely redundant blank
lines from drivers/staging/vt6656/hostap.c
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/vt6656/hostap.c | 40
1 file changed, 40 deletions(-)
diff --git a/drivers
We use tabs for indentation, not spaces.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/vt6656/hostap.c | 644 +++-
1 file changed, 301 insertions(+), 343 deletions(-)
diff --git a/drivers/staging/vt6656/hostap.c b/drivers/staging/vt6656
Convert a few tabs to spaces, remove some pointless whitespace, add
some missing whitespace (in drivers/staging/vt6656/hostap.c).
All quite small and trivial.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/vt6656/hostap.c | 11 +--
1 file changed, 5 insertions(+), 6
Git has the code if we ever need it, so instead of having chunks of
commented out code clutter up the file get rid of it.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/vt6656/hostap.c | 45 +
1 file changed, 1 insertion(+), 44
Even when they go beyond 80 characters, user visible strings should be
on one line to make them easy to grep for.
Signed-off-by: Jesper Juhl
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
This patch
is on, so it is
compile tested only.
Signed-off-by: Jesper Juhl
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c
b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index a19c84c..ad489
it is
compile tested only.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c
b/drivers/net/ethernet/intel/igb/igb_ethtool.c
index a19c84c
Even when they go beyond 80 characters, user visible strings should be
on one line to make them easy to grep for.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/net/ethernet/intel/igb/igb_ethtool.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions
On Mon, 23 Jul 2012, Al Viro wrote:
> On Mon, Jul 23, 2012 at 08:09:14PM +0200, Jesper Juhl wrote:
> > So, from my point of view it looks like procfs is the one who has got it
> > wrong.
> > We should probably fix that (IMVHO).
>
> Fix it _how_?
By returning the
ot 15 Jul 23 19:46 /dev/stderr -> /proc/self/fd/2
Also looks OK...
So, from my point of view it looks like procfs is the one who has got it
wrong.
We should probably fix that (IMVHO).
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-p
On Mon, 23 Jul 2012, Dan Carpenter wrote:
> On Sun, Jul 22, 2012 at 10:57:09PM +0200, Jesper Juhl wrote:
> > Make it match CodingStyle a bit better, tab/space wise.
> >
> > Signed-off-by: Jesper Juhl
> > ---
> > dri
On Mon, 23 Jul 2012, Dan Carpenter wrote:
On Sun, Jul 22, 2012 at 10:57:09PM +0200, Jesper Juhl wrote:
Make it match CodingStyle a bit better, tab/space wise.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/slicoss/slic.h | 751
it looks like procfs is the one who has got it
wrong.
We should probably fix that (IMVHO).
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line
On Mon, 23 Jul 2012, Al Viro wrote:
On Mon, Jul 23, 2012 at 08:09:14PM +0200, Jesper Juhl wrote:
So, from my point of view it looks like procfs is the one who has got it
wrong.
We should probably fix that (IMVHO).
Fix it _how_?
By returning the size as the number of bytes
(cm),
data, cmlen - sizeof(struct compat_cmsghdr))' there's no telling what
it may be refering to - not good.
Fix the problem by simply giving 'ctv' and 'cts' function scope.
Signed-off-by: Jesper Juhl
---
net/compat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net
On Mon, 30 Jan 2012, J. Bruce Fields wrote:
> On Sun, Jan 29, 2012 at 10:29:24PM +0100, Jesper Juhl wrote:
> > The Coverity checker noticed a path through nfsd4_lock() where we call
> > release_lockowner(lock_sop); (at the 'out:' label) where 'lock_sop' is
> > NULL.
&g
Make it match CodingStyle a bit better, space/tab wise.
Signed-off-by: Jesper Juhl
---
drivers/staging/slicoss/slicoss.c | 809 +++---
1 file changed, 397 insertions(+), 412 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers/staging/slicoss
Make it match CodingStyle a bit better, tab/space wise.
Signed-off-by: Jesper Juhl
---
drivers/staging/slicoss/slic.h | 751 -
1 file changed, 374 insertions(+), 377 deletions(-)
diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss
Make it match CodingStyle a bit better, tab/space wise.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/slicoss/slic.h | 751 -
1 file changed, 374 insertions(+), 377 deletions(-)
diff --git a/drivers/staging/slicoss/slic.h b/drivers
Make it match CodingStyle a bit better, space/tab wise.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/slicoss/slicoss.c | 809 +++---
1 file changed, 397 insertions(+), 412 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c
b/drivers
On Mon, 30 Jan 2012, J. Bruce Fields wrote:
On Sun, Jan 29, 2012 at 10:29:24PM +0100, Jesper Juhl wrote:
The Coverity checker noticed a path through nfsd4_lock() where we call
release_lockowner(lock_sop); (at the 'out:' label) where 'lock_sop' is
NULL.
That goes bad since
(cm),
data, cmlen - sizeof(struct compat_cmsghdr))' there's no telling what
it may be refering to - not good.
Fix the problem by simply giving 'ctv' and 'cts' function scope.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
net/compat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
put rather
than on a new line.
B) Some tools that process files line-by-line may get confused by the
lack of a newline on the last line.
C) The "\ No newline at end of file" line in diffs annoys me for some
reason.
So, let's just add the missing newline once and for all.
Signed
Ping ?
This issue seems to still be present. Any chance we could merge the patch
below?
/Jesper
On Mon, 6 Feb 2012, Jesper Juhl wrote:
> On Mon, 6 Feb 2012, Dave Chinner wrote:
>
> > On Sun, Feb 05, 2012 at 10:23:44PM +0100, Jesper Juhl wrote:
> > > In xfs_setattr_nonsi
Signed-off-by: Jesper Juhl
---
Documentation/ia64/aliasing-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/ia64/aliasing-test.c
b/Documentation/ia64/aliasing-test.c
index 5caa2af..62a190d 100644
--- a/Documentation/ia64/aliasing-test.c
+++ b/Documentation/ia64/aliasing
fails then we'll leak the memory allocated for 'sysram'
with vmalloc().
Signed-off-by: Jesper Juhl
---
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
b/drivers/gpu/drm/cirrus/cirrus_fbdev.c
index
' if the framebuffer_alloc()
call fails and the variable goes out of scope.
Signed-off-by: Jesper Juhl
---
drivers/gpu/drm/ast/ast_fb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 2fc8e9e..260a760 100644
--- a/drivers/gpu/drm/ast
' if the framebuffer_alloc()
call fails and the variable goes out of scope.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/gpu/drm/ast/ast_fb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c
index 2fc8e9e..260a760 100644
fails then we'll leak the memory allocated for 'sysram'
with vmalloc().
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/gpu/drm/cirrus/cirrus_fbdev.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_fbdev.c
b/drivers/gpu/drm/cirrus
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
Documentation/ia64/aliasing-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/ia64/aliasing-test.c
b/Documentation/ia64/aliasing-test.c
index 5caa2af..62a190d 100644
--- a/Documentation/ia64/aliasing-test.c
+++ b
Ping ?
This issue seems to still be present. Any chance we could merge the patch
below?
/Jesper
On Mon, 6 Feb 2012, Jesper Juhl wrote:
On Mon, 6 Feb 2012, Dave Chinner wrote:
On Sun, Feb 05, 2012 at 10:23:44PM +0100, Jesper Juhl wrote:
In xfs_setattr_nonsize(), xfs_trans_alloc() gets
than on a new line.
B) Some tools that process files line-by-line may get confused by the
lack of a newline on the last line.
C) The \ No newline at end of file line in diffs annoys me for some
reason.
So, let's just add the missing newline once and for all.
Signed-off-by: Jesper Juhl j
Andrew Morton (commit_signer:6/17=35%)
Kay Sievers (commit_signer:5/17=29%)
Jeff Moyer (commit_signer:2/17=12%)
Dmitry Monakhov (commit_signer:2/17=12%)
linux-kernel@vger.kernel.org (open list)
Please try again.
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-
try again.
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
there that everyone could count on. If people want
to deviate from the default minimum, sure, let them, but put it under
*custom*, *embedded*, *specialized distro*, *you know what you are doing*
menu options.
Configurabillity is good, but only to a certain degree - I think we could
bennefit from r
to a certain degree - I think we could
bennefit from removing a *lot* of options and instead just decreeing that
a linux system has this..
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please
k corresponding to the clock producer, or
> * valid IS_ERR() condition containing errno. The implementation
>
Looks correct to me :-)
Acked-by: Jesper Juhl
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
errno. The implementation
Looks correct to me :-)
Acked-by: Jesper Juhl j...@chaosbits.net
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
On Sun, 8 Jul 2012, Joe Perches wrote:
> On Mon, 2012-07-09 at 00:58 +0200, Jesper Juhl wrote:
> > A few cases were missed in my previous cleanup, this takes care of the
> > last cases of missing space (or too much space (as in a newline))
> > around operators ('=', '==', '
On Sun, 8 Jul 2012, Joe Perches wrote:
> On Mon, 2012-07-09 at 00:59 +0200, Jesper Juhl wrote:
> > I missed a few redundant newlines the first time.
> []
> > diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
> []
> > @@ -964,7 +964,6
I missed a few redundant newlines the first time.
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6656/iwctl.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
index 13ad62c..8b9894b 100644
--- a/drivers
My previous cleanup patches missed a few cases of
redundant/missing/replaced curly braces. This should fix up the last
ones.
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6656/iwctl.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/drivers
A few cases were missed in my previous cleanup, this takes care of the
last cases of missing space (or too much space (as in a newline))
around operators ('=', '==', ',', '<').
Signed-off-by: Jesper Juhl
---
drivers/staging/vt6656/iwctl.c | 13 ++---
1 file changed, 6 insertions(+)
.
The series is on top of linux-next (next-20120706).
--
Jesper Juhlhttp://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
.
The series is on top of linux-next (next-20120706).
--
Jesper Juhl j...@chaosbits.net http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
A few cases were missed in my previous cleanup, this takes care of the
last cases of missing space (or too much space (as in a newline))
around operators ('=', '==', ',', '').
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/vt6656/iwctl.c | 13 ++---
1 file changed, 6
My previous cleanup patches missed a few cases of
redundant/missing/replaced curly braces. This should fix up the last
ones.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/vt6656/iwctl.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff
I missed a few redundant newlines the first time.
Signed-off-by: Jesper Juhl j...@chaosbits.net
---
drivers/staging/vt6656/iwctl.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
index 13ad62c..8b9894b
101 - 200 of 2260 matches
Mail list logo