[PATCH 09/30] mtd: Don't cast kmalloc() return value in drivers/mtd/maps/pmcmsp-flash.c

2007-08-23 Thread Jesper Juhl
kmalloc() returns a void pointer. No need to cast it. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/mtd/maps/pmcmsp-flash.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/maps/pmcmsp-flash.c b/drivers/mtd/maps/pmcmsp-flash.c index

[PATCH 10/30] irda: Do not do pointless kmalloc return value cast in KingSun driver

2007-08-23 Thread Jesper Juhl
kmalloc() returns a void pointer, so there is no need to cast it in drivers/net/irda/kingsun-sir.c::kingsun_probe(). Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/net/irda/kingsun-sir.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/irda

[PATCH 14/30] net: Kill some unneeded allocation return value casts in libertas

2007-08-23 Thread Jesper Juhl
kmalloc() and friends return void*, no need to cast it. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/net/wireless/libertas/debugfs.c |2 +- drivers/net/wireless/libertas/ethtool.c |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless

[PATCH 16/30] net: Avoid pointless allocation casts in BSD compression module

2007-08-23 Thread Jesper Juhl
The general kernel memory allocation functions return void pointers and there is no need to cast their return values. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/net/bsd_comp.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/bsd_comp.c b

[PATCH 17/30] isdn: Get rid of some pointless allocation casts in common and bsd comp.

2007-08-23 Thread Jesper Juhl
vmalloc() returns a void pointer - no need to cast the return value. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/isdn/i4l/isdn_bsdcomp.c |5 ++--- drivers/isdn/i4l/isdn_common.c |2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/isdn/i4l

[PATCH 18/30] isdn: eicon - get rid of a pointless vmalloc() return value cast

2007-08-23 Thread Jesper Juhl
vmalloc() returns void*. No need to cast in drivers/isdn/hardware/eicon/platform.h::diva_os_malloc() Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/isdn/hardware/eicon/platform.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/isdn/hardware/eicon

[PATCH 19/30] scsi: Remove explicit casts of [kv]alloc return values in osst driver

2007-08-23 Thread Jesper Juhl
[kv]alloc() return void *. No need to cast the return value. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/scsi/osst.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/osst.c b/drivers/scsi/osst.c index 08060fb..3ad9d49 100644 --- a/drivers

[PATCH 20/30] scsi: In the Advansys driver, do not cast allocation function return values

2007-08-23 Thread Jesper Juhl
There's no reason to cast void pointers returned by the generic memory allocation functions. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/scsi/advansys.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c

[PATCH 21/30] oss: Remove unneeded vmalloc() return value casts in OSS

2007-08-23 Thread Jesper Juhl
vmalloc() returns a void pointer that we don't need to cast. This patch should clean this up in sound/oss/. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- sound/oss/midibuf.c |4 ++-- sound/oss/pss.c |6 +++--- sound/oss/sequencer.c |4 ++-- sound/oss/sscape.c|2

[PATCH 22/30] ivtv: kzalloc() returns void pointer, no need to cast

2007-08-23 Thread Jesper Juhl
Since kzalloc() returns a void pointer, we don't need to cast the return value in drivers/media/video/ivtv/ivtv-queue.c Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/media/video/ivtv/ivtv-queue.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media

[PATCH 23/30] video: Remove pointless kmalloc() return value cast in Zoran PCI controller driver

2007-08-23 Thread Jesper Juhl
No need to cast the void pointer returned by kmalloc() in drivers/media/video/zoran_driver.c::v4l_fbuffer_alloc(). Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/media/video/zoran_driver.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/media/video

[PATCH 24/30] dvb: remove some unneeded vmalloc() return value casts from av7110

2007-08-23 Thread Jesper Juhl
vmalloc() returns void * - no need to cast it. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/media/dvb/ttpci/av7110.c|2 +- drivers/media/dvb/ttpci/av7110_ir.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/ttpci/av7110.c b/drivers

[PATCH 25/30] tty: dont needlessly cast kmalloc() return value

2007-08-23 Thread Jesper Juhl
kmalloc() hands us a void pointer, we don't need to cast it. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/char/tty_io.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/char/tty_io.c b/drivers/char/tty_io.c index 51ea93c..9c867cf 100644

[PATCH 26/30] md: vmalloc() returns void pointer so we don't need to cast it in dm-ioctl

2007-08-23 Thread Jesper Juhl
In drivers/md/dm-ioctl.c::copy_params() there's a call to vmalloc() where we currently cast the return value, but that's pretty pointles given that vmalloc() returns void *. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/md/dm-ioctl.c |2 +- 1 files changed, 1 insertions(+), 1

[PATCH 27/30] usb: avoid redundant cast of kmalloc() return value in OTi-6858 driver

2007-08-23 Thread Jesper Juhl
In drivers/usb/serial/oti6858.c::pl2303_buf_alloc() the return value of kmalloc() is being cast to struct pl2303_buf *, but that need not be done here since kmalloc() returns void *. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/usb/serial/oti6858.c |2 +- 1 files changed, 1

[PATCH 28/30] jfs: avoid pointless casts of kmalloc() return val

2007-08-23 Thread Jesper Juhl
There's no need to cast the, void *, return value of kmalloc() when assigning to a pointer variable. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- fs/jfs/jfs_dtree.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/jfs/jfs_dtree.c b/fs/jfs/jfs_dtree.c index

[PATCH 29/30] mm: No need to cast vmalloc() return value in zone_wait_table_init()

2007-08-23 Thread Jesper Juhl
vmalloc() returns a void pointer, so there's no need to cast its return value in mm/page_alloc.c::zone_wait_table_init(). Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- mm/page_alloc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c

[PATCH 30/30] emu10k1: There's no need to cast vmalloc() return value in snd_emu10k1_create()

2007-08-23 Thread Jesper Juhl
vmalloc() returns void *. no need to cast. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- sound/pci/emu10k1/emu10k1_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c index 404ae1b..91d986b

Re: [PATCH 0/30] Remove unneeded casts of [kv][mzc]alloc() return values

2007-08-23 Thread Jesper Juhl
On 24/08/07, Jesper Juhl [EMAIL PROTECTED] wrote: [snip] The patches in this series are Damn, I managed to mess up that list. Here's how it should have looked : [PATCH 01/30] ia64: Remove unnecessary cast of allocation return value in sn_hwperf_enum_objects() [PATCH 02/30] cris: Remove

Re: How to learn Linux Kernel Programming

2007-08-22 Thread Jesper Juhl
erimental > kernel where I can experiment with? > A cross compiler is used to compile a kernel for one architecture while running a different one. for example; building a kernel to run on ppc64 while running i386. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/ja

Re: How to learn Linux Kernel Programming

2007-08-22 Thread Jesper Juhl
with? A cross compiler is used to compile a kernel for one architecture while running a different one. for example; building a kernel to run on ppc64 while running i386. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please

Re: [PATCH] ver_linux is [censored]

2007-08-21 Thread Jesper Juhl
then simply put into patch form. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Signed-off-by: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- scripts/ver_linux |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/v

Re: How to learn Linux Kernel Programming

2007-08-21 Thread Jesper Juhl
; An other question I'd like to ask is how and where did you start? I'd > like to know how you manage to became > linux kernel developers. > Most people start out fixing small bugs, cleanups etc or by implementing some small feature or driver that they need. There's no fixed way. -- Jes

Re: [PATCH] ver_linux is [censored]

2007-08-21 Thread Jesper Juhl
On 22/08/07, Al Viro <[EMAIL PROTECTED]> wrote: > On Tue, Aug 21, 2007 at 11:56:32AM +0200, Jesper Juhl wrote: > > On 21/08/07, Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > > Commit 4a645d5ea65baaa5736bcb566673bf4a351b2ad8 broke ver_linux > > > on etch

Re: [PATCH] ver_linux is [censored]

2007-08-21 Thread Jesper Juhl
on gentoo, etch, centos 4.2. > I tested your patch on Slackware 12.0, Debian 3.1 & Gentoo Base System release 1.12.9 and it works fine on those as well. > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Tested-by: Jesper Juhl <[EMAIL PROTECTED]> > --- > > scripts/

Re: [PATCH] ver_linux is [censored]

2007-08-21 Thread Jesper Juhl
tested your patch on Slackware 12.0, Debian 3.1 Gentoo Base System release 1.12.9 and it works fine on those as well. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] Tested-by: Jesper Juhl [EMAIL PROTECTED] --- scripts/ver_linux |6 +++--- 1 file changed, 3 insertions(+), 3 deletions

Re: [PATCH] ver_linux is [censored]

2007-08-21 Thread Jesper Juhl
On 22/08/07, Al Viro [EMAIL PROTECTED] wrote: On Tue, Aug 21, 2007 at 11:56:32AM +0200, Jesper Juhl wrote: On 21/08/07, Alexey Dobriyan [EMAIL PROTECTED] wrote: Commit 4a645d5ea65baaa5736bcb566673bf4a351b2ad8 broke ver_linux on etch which glibc has 3-digit version number. Whoops

Re: How to learn Linux Kernel Programming

2007-08-21 Thread Jesper Juhl
to know how you manage to became linux kernel developers. Most people start out fixing small bugs, cleanups etc or by implementing some small feature or driver that they need. There's no fixed way. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html

Re: [PATCH] ver_linux is [censored]

2007-08-21 Thread Jesper Juhl
then simply put into patch form. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] Signed-off-by: Al Viro [EMAIL PROTECTED] Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- scripts/ver_linux |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/ver_linux b/scripts/ver_linux

Re: Fork Bombing Patch

2007-08-20 Thread Jesper Juhl
rs somehow disable it completely. Personally I'm wondering if we even want/need this at all. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: se

Re: Fork Bombing Patch

2007-08-20 Thread Jesper Juhl
. Personally I'm wondering if we even want/need this at all. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux

Re: convert #include "linux/..." to #include [PATCH]s follow

2007-08-19 Thread Jesper Juhl
onversions are correct and work fine, how about a patch (or patches)? -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the lin

Re: [no patch] Remove more double inclusions

2007-08-19 Thread Jesper Juhl
g the next merge window, so before doing a lot of duplicate work I'd suggest waiting for 2.6.24-rc1 before working on this any further - or at least check -mm and the various maintainer/subsystem trees first. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/htm

Re: [PATCH] Remove double inclusion of linux/capability.h

2007-08-19 Thread Jesper Juhl
xed by one of my patches currently sitting in -mm. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH] Remove double inclusion of linux/capability.h

2007-08-19 Thread Jesper Juhl
in -mm. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [no patch] Remove more double inclusions

2007-08-19 Thread Jesper Juhl
for 2.6.24-rc1 before working on this any further - or at least check -mm and the various maintainer/subsystem trees first. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html

Re: convert #include linux/... to #include linux/... [PATCH]s follow

2007-08-19 Thread Jesper Juhl
about a patch (or patches)? -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

Re: + cifs-check-for-granted-memory.patch added to -mm tree

2007-08-17 Thread Jesper Juhl
big enough to fit max user, domain, NOS name etc. */ > str_area = kmalloc(2000, GFP_KERNEL); > + if (str_area == NULL) { > + cifs_small_buf_release(smb_buf); > + return -ENOMEM; > + } The patch, as such, is fine - not arguing agains

Re: how to add debug information into the vmlinux

2007-08-17 Thread Jesper Juhl
go into "make menuconfig", enter the "Kernel hacking" menu and select the "Kernel debugging" and "Compile the kernel with debug info" options. You may also want to enable "Compile the kernel with frame pointers" and various other options in that menu to

[PATCH] IRDA: Avoid a label defined but not used warning in irda_init()

2007-08-17 Thread Jesper Juhl
; one line above it. This patch moves the label and buys us one less warning with no ill effects. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- net/irda/irmod.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/irda/irmod.c b/net/irda/irmod.c index 1900937

[PATCH] Cyclades: Avoid label defined but not used warning

2007-08-17 Thread Jesper Juhl
consider applying. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/char/cyclades.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c index 9e0adfe..858bdab 100644 --- a/drivers/char/cyclades.c

Re: SVr4/SVID/SUS IPC conformance

2007-08-17 Thread Jesper Juhl
test for the error code being (EINVAL || EIDRM)... Or am I missing something? -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send t

Re: how to send a text format emai?

2007-08-17 Thread Jesper Juhl
On 17/08/07, Xu Yang <[EMAIL PROTECTED]> wrote: > how to send a email of text format? Depends on your email program. But looking at your email you managed to do it: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -- Jesper Juhl <[EMAIL PROTECTED

Re: how to send a text format emai?

2007-08-17 Thread Jesper Juhl
On 17/08/07, Xu Yang [EMAIL PROTECTED] wrote: how to send a email of text format? Depends on your email program. But looking at your email you managed to do it: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit -- Jesper Juhl [EMAIL PROTECTED] Don't top-post

Re: SVr4/SVID/SUS IPC conformance

2007-08-17 Thread Jesper Juhl
of the question since that would break userspace applications currently depending on it. So I guess that the only way to write applications that are portable between Linux and other *NIX clones is to test for the error code being (EINVAL || EIDRM)... Or am I missing something? -- Jesper Juhl [EMAIL

[PATCH] Cyclades: Avoid label defined but not used warning

2007-08-17 Thread Jesper Juhl
consider applying. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/char/cyclades.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/cyclades.c b/drivers/char/cyclades.c index 9e0adfe..858bdab 100644 --- a/drivers/char/cyclades.c +++ b/drivers

[PATCH] IRDA: Avoid a label defined but not used warning in irda_init()

2007-08-17 Thread Jesper Juhl
it. This patch moves the label and buys us one less warning with no ill effects. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- net/irda/irmod.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/irda/irmod.c b/net/irda/irmod.c index 1900937..8ba703d 100644

Re: how to add debug information into the vmlinux

2007-08-17 Thread Jesper Juhl
the Kernel hacking menu and select the Kernel debugging and Compile the kernel with debug info options. You may also want to enable Compile the kernel with frame pointers and various other options in that menu to get more debug info. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http

Re: + cifs-check-for-granted-memory.patch added to -mm tree

2007-08-17 Thread Jesper Juhl
) { + cifs_small_buf_release(smb_buf); + return -ENOMEM; + } The patch, as such, is fine - not arguing against it, but as a matter of style; don't we usually prefer the if (!foo) form over if (foo == NULL) ?? -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T

[PATCH] Moxa: Fix warning: 'CheckIsMoxaMust' defined but not used

2007-08-16 Thread Jesper Juhl
. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- mxser.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6/drivers/char/mxser.c~ 2007-08-17 00:11:23.0 +0200 +++ linux-2.6/drivers/char/mxser.c 2007-08-17 00:11:23.0 +0200 @@ -424,7

[PATCH] Moxa: Fix tiny compiler warning when building withoug CONFIG_PCI

2007-08-16 Thread Jesper Juhl
Fix this tiny compiler warning in Moxa driver : drivers/char/mxser.c:386: warning: 'mxser_get_PCI_conf' declared 'static' but never defined when building without CONFIG_PCI. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/char/mxser.c |2 ++ 1 files changed, 2 inse

Re: sysctl_tcp_keepalive_time

2007-08-16 Thread Jesper Juhl
urable and MUST default to no less than two hours. " This page may also be of interrest to you : http://www.uic.rsu.ru/doc/inet/tcp_stevens/tcp_keep.htm Also see "man 7 tcp" -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.h

Re: sysctl_tcp_keepalive_time

2007-08-16 Thread Jesper Juhl
. This page may also be of interrest to you : http://www.uic.rsu.ru/doc/inet/tcp_stevens/tcp_keep.htm Also see man 7 tcp -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html

[PATCH] Moxa: Fix tiny compiler warning when building withoug CONFIG_PCI

2007-08-16 Thread Jesper Juhl
Fix this tiny compiler warning in Moxa driver : drivers/char/mxser.c:386: warning: 'mxser_get_PCI_conf' declared 'static' but never defined when building without CONFIG_PCI. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- drivers/char/mxser.c |2 ++ 1 files changed, 2 insertions

[PATCH] Moxa: Fix warning: 'CheckIsMoxaMust' defined but not used

2007-08-16 Thread Jesper Juhl
. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- mxser.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6/drivers/char/mxser.c~ 2007-08-17 00:11:23.0 +0200 +++ linux-2.6/drivers/char/mxser.c 2007-08-17 00:11:23.0 +0200 @@ -424,7 +424,7

Re: [PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-13 Thread Jesper Juhl
Signed-off-by: Keir Fraser <[EMAIL PROTECTED]> Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- drivers/net/xen-netfront.c |4 +++- 1 files changed, 3 insertions(+), 1 delet

Re: Unexpected busfree in Message-in phase

2007-08-13 Thread Jesper Juhl
On 13/08/07, Michal Piotrowski <[EMAIL PROTECTED]> wrote: > Hi Jesper, > > On 11/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > > Hi, > > > > I just noticed this in dmesg : > > > > [ 3216.262987] (scsi0:A:4:0): Unexpected busfree in M

Re: [PATCH 4/6][RESEND] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-13 Thread Jesper Juhl
; Since this really is just something to keep the tools happy - I'll recind the > NACK. > I'll worry about simply removing this if-check later... > > James/Andrew, accept this patch - ACK. > -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/j

Re: [PATCH 4/6][RESEND] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-13 Thread Jesper Juhl
sumed it had not been merged. I just looked again, at the source this time, up-to-date mainline git tree, and I still see hbqno = tag >> 16; if (hbqno > LPFC_MAX_HBQS) return NULL; in drivers/scsi/lpfc/lpfc_sli.c ??? > -- james s > > Jesper Juh

Re: [PATCH 4/6][RESEND] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-13 Thread Jesper Juhl
just looked again, at the source this time, up-to-date mainline git tree, and I still see hbqno = tag 16; if (hbqno LPFC_MAX_HBQS) return NULL; in drivers/scsi/lpfc/lpfc_sli.c ??? -- james s Jesper Juhl wrote: (previously send on 09-Aug-2007 20:47) Hi

Re: [PATCH 4/6][RESEND] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-13 Thread Jesper Juhl
recind the NACK. I'll worry about simply removing this if-check later... James/Andrew, accept this patch - ACK. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html

Re: Unexpected busfree in Message-in phase

2007-08-13 Thread Jesper Juhl
On 13/08/07, Michal Piotrowski [EMAIL PROTECTED] wrote: Hi Jesper, On 11/08/07, Jesper Juhl [EMAIL PROTECTED] wrote: Hi, I just noticed this in dmesg : [ 3216.262987] (scsi0:A:4:0): Unexpected busfree in Message-in phase [ 3216.263058] SEQADDR == 0x16c [ 3216.263724] target0:0:4

Re: [PATCH] xen-netfront: Avoid deref'ing skbafter it is potentially freed.

2007-08-13 Thread Jesper Juhl
that we generally want to do as little work as possible while holding a lock, wouldn't the following be slightly better? Signed-off-by: Keir Fraser [EMAIL PROTECTED] Signed-off-by: Jeremy Fitzhardinge [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Jesper Juhl [EMAIL PROTECTED

Re: [PATCH 2/5] 4KSTACKS, remove DEBUG_KERNEL dependency for sh

2007-08-12 Thread Jesper Juhl
On 13/08/07, Paul Mundt <[EMAIL PROTECTED]> wrote: > On Sun, Aug 12, 2007 at 10:53:23PM +0200, Jesper Juhl wrote: > > > > 4K Stacks is no longer a debug feature, so remove the DEBUG_KERNEL > > dependancy for 4KSTACKS for sh. > > > > While it may n

[PATCH 6/6][RESEND] Avoid possible NULL pointer deref in 3c359 driver

2007-08-12 Thread Jesper Juhl
sts for a NULL 'dev', then that NULL deref can never happen. It never hurts to be safe :-) Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c index e22a3f5..671f4da 100644 --- a/drivers/net/tokenring/3c359.c +++ b/dr

[PATCH 4/6][RESEND] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-12 Thread Jesper Juhl
S' into 'hbqno >= LPFC_MAX_HBQS' as a possible fix. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Acked-by: James Smart <[EMAIL PROTECTED]> --- drivers/scsi/lpfc/lpfc_sli.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/driv

[PATCH 5/6][RESEND] fix tiny spelling error in comment in cfi_cmdset_0001.c

2007-08-12 Thread Jesper Juhl
(previously send on 05-Jul-2007 02:18, 04-Aug-2007 20:31) Trivial fix of a spelling error in a comment in cfi_cmdset_0001.c s/ships/chips/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c index 2

[PATCH 3/6][RESEND] Reduce size of the xterm-linux.xpm image by 12 bytes.

2007-08-12 Thread Jesper Juhl
for every future Linux kernel source user to download - that can't be bad. Ok, ok, so it does have the drawback of being 99,999% churn and you could argue that it'll clutter the git history. So if you don't apply it I won't hate you (too much) ;-) Signed-off-by: Jesper Juhl <[EMAIL PROTEC

[PATCH 5/5] 4KSTACKS, make 'default y', -mm patch only.

2007-08-12 Thread Jesper Juhl
To get more testing of 4K Stacks, make the feature 'default y'. note: this patch is *NOT* intended for mainline atm, only for -mm. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig index d4988cd..15b1a25 100644 --- a/arch/i386/Kconfig

[PATCH 3/5] 4KSTACKS, move out of Kernel hacking menu (i386)

2007-08-12 Thread Jesper Juhl
Since 4KSTACKS is nolonger a debug only feature, move it out of the Kernel Hacking menu (i386). Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig index f952493..d4988cd 100644 --- a/arch/i386/Kconfig +++ b/arch/i386/Kconfig @@ -922,6 +

[PATCH 4/5] 4KSTACKS, move out of Kernel hacking menu (sh)

2007-08-12 Thread Jesper Juhl
Since 4KSTACKS is nolonger a debug only feature, move it out of the Kernel Hacking menu (sh). Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 54878f0..43e79f4 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -205,6 +205,15 @@

[PATCH 2/5] 4KSTACKS, remove DEBUG_KERNEL dependency for sh

2007-08-12 Thread Jesper Juhl
4K Stacks is no longer a debug feature, so remove the DEBUG_KERNEL dependancy for 4KSTACKS for sh. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- diff --git a/arch/sh/Kconfig.debug b/arch/sh/Kconfig.debug index 52f6a99..5bb4bd7 100644 --- a/arch/sh/Kconfig.debug +++ b/arch/sh/Kconfig

[PATCH 1/5] 4KSTACKS, remove DEBUG_KERNEL dependency for i386

2007-08-12 Thread Jesper Juhl
4K Stacks is no longer a debug feature, so remove the DEBUG_KERNEL dependancy for 4KSTACKS for i386. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- diff --git a/arch/i386/Kconfig.debug b/arch/i386/Kconfig.debug index f03531e..7131a16 100644 --- a/arch/i386/Kconfig.debug +++ b/arc

[PATCH 0/5] 4KSTACKS no longer a debug feature and doesn't belong in "Kernel hacking".

2007-08-12 Thread Jesper Juhl
, so I'd like your input. I'm adding a few people from the previous thread to Cc, but far from everyone as then the Cc list would become too big. For the patches themselves I'm just sending them to LKML, Andrew & Paul, so pick them up on LKML please (sending as replies to this ma

Re: [PATCH] Minor fix to Documentation/powerpc/00-INDEX

2007-08-12 Thread Jesper Juhl
orm I'd ever seen - I didn't know if it was a rule or not, but it seemed pretty sensible for an index. It's also the form I've stuck to for the new files I send patches for recently. So for whatever my oppinion is worth; I think we may as well make it a rule for the 00-INDEX files. -- Jesper Juhl <[EMAI

Re: [PATCH 0/5] Add some missing Documentation/*/00-INDEX files

2007-08-12 Thread Jesper Juhl
ted writing such a script myself yesterday, but it's not done yet. If you already have one that works could I have a copy please? That would make my life easier if I'm to help you with this. -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/html/T/top

Re: [PATCH 0/5] Add some missing Documentation/*/00-INDEX files

2007-08-12 Thread Jesper Juhl
On 12/08/07, Stefan Richter <[EMAIL PROTECTED]> wrote: > Jesper Juhl wrote: > > Rob Landley is trying to organize Linux kernel documentation. One > > thing he is doing is generating index.html files based on our > > 00-INDEX files in the Documentation directory. He has m

Re: Build failure in advansys driver - error: implicit declaration of function 'to_pci_dev'

2007-08-12 Thread Jesper Juhl
On 12/08/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Sun, Aug 12, 2007 at 01:43:16AM +0200, Jesper Juhl wrote: > > Trying to build current Linus git tree (head at > > ac07860264bd2b18834d3fa3be47032115524cea) using the attached config > > file (generated by '

Re: Build failure in advansys driver - error: implicit declaration of function 'to_pci_dev'

2007-08-12 Thread Jesper Juhl
On 12/08/07, Matthew Wilcox [EMAIL PROTECTED] wrote: On Sun, Aug 12, 2007 at 01:43:16AM +0200, Jesper Juhl wrote: Trying to build current Linus git tree (head at ac07860264bd2b18834d3fa3be47032115524cea) using the attached config file (generated by 'make randconfig') the build fails for me

Re: [PATCH 0/5] Add some missing Documentation/*/00-INDEX files

2007-08-12 Thread Jesper Juhl
On 12/08/07, Stefan Richter [EMAIL PROTECTED] wrote: Jesper Juhl wrote: Rob Landley is trying to organize Linux kernel documentation. One thing he is doing is generating index.html files based on our 00-INDEX files in the Documentation directory. He has met with a small problem however

Re: [PATCH 0/5] Add some missing Documentation/*/00-INDEX files

2007-08-12 Thread Jesper Juhl
already have one that works could I have a copy please? That would make my life easier if I'm to help you with this. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html

Re: [PATCH] Minor fix to Documentation/powerpc/00-INDEX

2007-08-12 Thread Jesper Juhl
for the 00-INDEX files. -- Jesper Juhl [EMAIL PROTECTED] Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[PATCH 0/5] 4KSTACKS no longer a debug feature and doesn't belong in Kernel hacking.

2007-08-12 Thread Jesper Juhl
a few people from the previous thread to Cc, but far from everyone as then the Cc list would become too big. For the patches themselves I'm just sending them to LKML, Andrew Paul, so pick them up on LKML please (sending as replies to this mail). Kind regards, Jesper Juhl - To unsubscribe

[PATCH 1/5] 4KSTACKS, remove DEBUG_KERNEL dependency for i386

2007-08-12 Thread Jesper Juhl
4K Stacks is no longer a debug feature, so remove the DEBUG_KERNEL dependancy for 4KSTACKS for i386. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- diff --git a/arch/i386/Kconfig.debug b/arch/i386/Kconfig.debug index f03531e..7131a16 100644 --- a/arch/i386/Kconfig.debug +++ b/arch/i386

[PATCH 2/5] 4KSTACKS, remove DEBUG_KERNEL dependency for sh

2007-08-12 Thread Jesper Juhl
4K Stacks is no longer a debug feature, so remove the DEBUG_KERNEL dependancy for 4KSTACKS for sh. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- diff --git a/arch/sh/Kconfig.debug b/arch/sh/Kconfig.debug index 52f6a99..5bb4bd7 100644 --- a/arch/sh/Kconfig.debug +++ b/arch/sh/Kconfig.debug

[PATCH 3/5] 4KSTACKS, move out of Kernel hacking menu (i386)

2007-08-12 Thread Jesper Juhl
Since 4KSTACKS is nolonger a debug only feature, move it out of the Kernel Hacking menu (i386). Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig index f952493..d4988cd 100644 --- a/arch/i386/Kconfig +++ b/arch/i386/Kconfig @@ -922,6 +922,15

[PATCH 4/5] 4KSTACKS, move out of Kernel hacking menu (sh)

2007-08-12 Thread Jesper Juhl
Since 4KSTACKS is nolonger a debug only feature, move it out of the Kernel Hacking menu (sh). Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig index 54878f0..43e79f4 100644 --- a/arch/sh/Kconfig +++ b/arch/sh/Kconfig @@ -205,6 +205,15 @@ config

[PATCH 5/5] 4KSTACKS, make 'default y', -mm patch only.

2007-08-12 Thread Jesper Juhl
To get more testing of 4K Stacks, make the feature 'default y'. note: this patch is *NOT* intended for mainline atm, only for -mm. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig index d4988cd..15b1a25 100644 --- a/arch/i386/Kconfig +++ b

[PATCH 3/6][RESEND] Reduce size of the xterm-linux.xpm image by 12 bytes.

2007-08-12 Thread Jesper Juhl
for every future Linux kernel source user to download - that can't be bad. Ok, ok, so it does have the drawback of being 99,999% churn and you could argue that it'll clutter the git history. So if you don't apply it I won't hate you (too much) ;-) Signed-off-by: Jesper Juhl [EMAIL PROTECTED

[PATCH 4/6][RESEND] Emulex FC HBA driver: fix overflow of statically allocated array

2007-08-12 Thread Jesper Juhl
= LPFC_MAX_HBQS' as a possible fix. Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Acked-by: James Smart [EMAIL PROTECTED] --- drivers/scsi/lpfc/lpfc_sli.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index ce5ff2b

[PATCH 5/6][RESEND] fix tiny spelling error in comment in cfi_cmdset_0001.c

2007-08-12 Thread Jesper Juhl
(previously send on 05-Jul-2007 02:18, 04-Aug-2007 20:31) Trivial fix of a spelling error in a comment in cfi_cmdset_0001.c s/ships/chips/ Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- diff --git a/drivers/mtd/chips/cfi_cmdset_0001.c b/drivers/mtd/chips/cfi_cmdset_0001.c index 2f19fa7

[PATCH 6/6][RESEND] Avoid possible NULL pointer deref in 3c359 driver

2007-08-12 Thread Jesper Juhl
for a NULL 'dev', then that NULL deref can never happen. It never hurts to be safe :-) Signed-off-by: Jesper Juhl [EMAIL PROTECTED] --- diff --git a/drivers/net/tokenring/3c359.c b/drivers/net/tokenring/3c359.c index e22a3f5..671f4da 100644 --- a/drivers/net/tokenring/3c359.c +++ b/drivers/net

Re: [PATCH 2/5] 4KSTACKS, remove DEBUG_KERNEL dependency for sh

2007-08-12 Thread Jesper Juhl
On 13/08/07, Paul Mundt [EMAIL PROTECTED] wrote: On Sun, Aug 12, 2007 at 10:53:23PM +0200, Jesper Juhl wrote: 4K Stacks is no longer a debug feature, so remove the DEBUG_KERNEL dependancy for 4KSTACKS for sh. While it may no longer be a debugging feature on i386, it certainly is on sh

Re: Are we properly prepared to handle 3 Socket setups?

2007-08-11 Thread Jesper Juhl
On 12/08/07, Rene Herman <[EMAIL PROTECTED]> wrote: > On 08/12/2007 03:08 AM, Jesper Juhl wrote: > > > This may be a little off topic, but I think it's interresting enough > > to warrent a single mail. > > > > I just saw a news article (http://www.theinquir

Are we properly prepared to handle 3 Socket setups?

2007-08-11 Thread Jesper Juhl
on, so for those of you employed by big business with the cash to purchase a test box, it would at least be an interresting one to add to the mix :) Anyway, just wanted to give everyone a heads-up, bye bye... -- Jesper Juhl <[EMAIL PROTECTED]> Don't top-post http://www.catb.org/~esr/jargon/

Re: cciss: warning: right shift count >= width of type

2007-08-11 Thread Jesper Juhl
(whoops, forgot to add maintainer to Cc - now added) On 12/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > Hi, > > I've been building some randconfig kernels lately and I've noticed > this in a few builds : > > drivers/block/cciss.c:2614: warning: right shift count &g

cciss: warning: right shift count >= width of type

2007-08-11 Thread Jesper Juhl
eal with that is, so I'll just report it so hopefully someone else can fix it. By the way; I'm building current Linus git tree, head at commit ac07860264bd2b18834d3fa3be47032115524cea Kind regards, Jesper Juhl - To unsubscribe from this list: send the line "unsubscribe linux-kernel

mtd: build failure in drivers/mtd/chips/chipreg.c / include/linux/mtd/map.h

2007-08-11 Thread Jesper Juhl
ine k8temp I've also attached a complete build log. If you need any further details, just ask. Kind regards, Jesper Juhl config.70.gz Description: GNU Zip compressed data build.log.70.gz Description: GNU Zip compressed data

mtd: build failure - error: implicit declaration of function 'cfi_interleave'

2007-08-11 Thread Jesper Juhl
firmware_class snd_ac97_codec nvidia ac97_bus snd_pcm snd_seq_device snd_timer snd_page_alloc snd_util_mem agpgart sg snd_hwdep evdev ehci_hcd via_rhine k8temp I've also attached a complete build log. If you need any further details, just ask. Kind regards, Jesper Juhl build.log.55.gz

Build failure in advansys driver - error: implicit declaration of function 'to_pci_dev'

2007-08-11 Thread Jesper Juhl
evdev ehci_hcd via_rhine k8temp I've also attached a complete build log. If you need any further details, just ask. Kind regards, Jesper Juhl config.24.gz Description: GNU Zip compressed data build.log.24.gz Description: GNU Zip compressed data

<    1   2   3   4   5   6   7   8   9   10   >