Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

Fri, Mar 11, 2016 at 11:37:09AM CET, ouli...@huawei.com wrote: >The driver for Hisilicon RoCE is a platform driver. >The driver will support mulitple versions of hardware. Currently only "v1" >for hip06 SOC is supported. >The driver includes two parts: common driver and hardware-specific

Re: [RFC PATCH net-next 2/2] net: dsa: support SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF

Wed, Mar 09, 2016 at 07:32:13PM CET, and...@lunn.ch wrote: >Hi Vivien > >> -static bool dsa_slave_dev_check(struct net_device *dev) >> -{ >> -return dev->netdev_ops == _slave_netdev_ops; >> -} > >Where is the equivalent of this happening? Where do we check that the >interface added to the

Re: [RFC PATCH net-next 2/2] net: dsa: support SWITCHDEV_ATTR_ID_PORT_BRIDGE_IF

Wed, Mar 09, 2016 at 07:32:13PM CET, and...@lunn.ch wrote: >Hi Vivien > >> -static bool dsa_slave_dev_check(struct net_device *dev) >> -{ >> -return dev->netdev_ops == _slave_netdev_ops; >> -} > >Where is the equivalent of this happening? Where do we check that the >interface added to the

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

Wed, Mar 09, 2016 at 12:18:06PM CET, ouli...@huawei.com wrote: >Hi Jiri Pirko, thanks for reviewing >On 2016/3/4 17:16, Jiri Pirko wrote: >> Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote: >> >> >> >>> +int hns_roce_buf_alloc( >

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

Wed, Mar 09, 2016 at 12:18:06PM CET, ouli...@huawei.com wrote: >Hi Jiri Pirko, thanks for reviewing >On 2016/3/4 17:16, Jiri Pirko wrote: >> Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote: >> >> >> >>> +int hns_roce_buf_alloc( >

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote: >+int hns_roce_buf_alloc( >+ struct hns_roce_dev *hr_dev, >+ int size, int max_direct, >+ struct hns_roce_buf *buf) >+ >+ pages =

Re: [PATCH 3/4] infiniband: hns: add Hisilicon RoCE support(driver code)

Fri, Mar 04, 2016 at 09:41:16AM CET, xavier.hu...@huawei.com wrote: >+int hns_roce_buf_alloc( >+ struct hns_roce_dev *hr_dev, >+ int size, int max_direct, >+ struct hns_roce_buf *buf) >+ >+ pages =

Re: [PATCH] net: mellanox: add DEVLINK dependencies

ediate symbol that drivers can depend on, and changes >the three drivers using it. Approach a) looks like the best. Thanks for taking care of this. > >Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Jiri Pirko <j...@mellanox.com>

Re: [PATCH] net: mellanox: add DEVLINK dependencies

ediate symbol that drivers can depend on, and changes >the three drivers using it. Approach a) looks like the best. Thanks for taking care of this. > >Signed-off-by: Arnd Bergmann Acked-by: Jiri Pirko

Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

t), so I understand the issue. > > Thinking about the prior discussion, the rx_drop_inactive is >still a good idea, but I'd actually today get good use from a >"rx_drop_unforwardable" (or an equivalent but shorter name) counter that >counts every time a packet is dropped d

Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

packets without incrementing a counter. At >least, that's probably what would make someone who has complained loudly >about this issue happy, as they have monitoring tools that are squaking >loudly at any increments to rx_dropped. > >CC: "David S. Miller" >CC: Eric Dumazet &

Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

ime a packet is dropped due to is_skb_forwardable() >returning false. __dev_forward_skb does this (and hits rx_dropped), as >does the bridge (and does not count it). > > -J > >>CC: "David S. Miller" <da...@davemloft.net> >>CC: Eric Dumazet <edum

Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

packets without incrementing a counter. At >least, that's probably what would make someone who has complained loudly >about this issue happy, as they have monitoring tools that are squaking >loudly at any increments to rx_dropped. > >CC: "David S. Miller" <da...@davemloft.net&

Re: [PATCH] net : To avoid execution of extra instructions in NET RX path when rps_map is not set but rps_needed is true.

Wed, Dec 09, 2015 at 11:35:21AM CET, rahul.j...@samsung.com wrote: >From: Ashutosh Kaushik > >The patch fixes the issues with check of global flag "rps_needed" in RX Path >(which process packets in TCP/IP stack like netif_rx and netif_receive_skb >functions) First of all, if you want people to

Re: [PATCH] net : To avoid execution of extra instructions in NET RX path when rps_map is not set but rps_needed is true.

Wed, Dec 09, 2015 at 11:35:21AM CET, rahul.j...@samsung.com wrote: >From: Ashutosh Kaushik > >The patch fixes the issues with check of global flag "rps_needed" in RX Path >(which process packets in TCP/IP stack like netif_rx and netif_receive_skb >functions) First of

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

Fri, Nov 13, 2015 at 01:26:18AM CET, f.faine...@gmail.com wrote: >On 04/11/15 18:56, David Miller wrote: >>> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev >>> features down stack") >> ... >>> Reported-by: Nikolay Aleksandrov >>> Signed-off-by: Jarod Wilson >>> --- >>>

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

Fri, Nov 13, 2015 at 01:26:18AM CET, f.faine...@gmail.com wrote: >On 04/11/15 18:56, David Miller wrote: >>> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev >>> features down stack") >> ... >>> Reported-by: Nikolay Aleksandrov >>> Signed-off-by:

Re: [PATCH] ipv6: no addrconf for slave devices

Fri, Oct 16, 2015 at 12:21:51PM CEST, jblu...@infradead.org wrote: >If a device without the IFF_SLAVE flag set (e.g. team, bridge, openvswitch >vport, batman) is enslaved and IPv6 is active then addrconf will be >initiated and a link-local address is added to the slave interface. > >This patch

Re: [PATCH] ipv6: no addrconf for slave devices

Fri, Oct 16, 2015 at 12:21:51PM CEST, jblu...@infradead.org wrote: >If a device without the IFF_SLAVE flag set (e.g. team, bridge, openvswitch >vport, batman) is enslaved and IPv6 is active then addrconf will be >initiated and a link-local address is added to the slave interface. > >This patch

Re: [PATCH net-next] net: hns: fix the unknown phy_nterface_t type error

Sat, Oct 10, 2015 at 11:20:38AM CEST, huangda...@hisilicon.com wrote: >This patch fix the building error reported by Jiri Pirko > >drivers/net/ethernet/hisilicon/hns/hnae.h:465:2: error: unknown type >name 'phy_interface_t' >phy_interface_t phy_if; > ^ &

Re: [PATCH net-next] net: hns: fix the unknown phy_nterface_t type error

Sat, Oct 10, 2015 at 11:20:38AM CEST, huangda...@hisilicon.com wrote: >This patch fix the building error reported by Jiri Pirko <j...@resnulli.us> > >drivers/net/ethernet/hisilicon/hns/hnae.h:465:2: error: unknown type >name 'phy_interface_t' >phy_interface_t phy_if

Re: [PATCH net-next v2 3/3] net: dsa: use switchdev obj in port_fdb_del

Thu, Oct 08, 2015 at 05:35:14PM CEST, vivien.dide...@savoirfairelinux.com wrote: >For consistency with the FDB add operation, propagate the >switchdev_obj_port_fdb structure in the DSA drivers. > >Signed-off-by: Vivien Didelot Reviewed-by: Jiri Pirko -- To unsubscribe from thi

Re: [PATCH net-next v2 2/3] net: dsa: push prepare phase in port_fdb_add

Thu, Oct 08, 2015 at 05:35:13PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Now that the prepare phase is pushed down to the DSA drivers, propagate >it to the port_fdb_add function. > >Signed-off-by: Vivien Didelot Reviewed-by: Jiri Pirko -- To unsubscribe from this list: s

Re: [PATCH net-next v2 1/3] net: dsa: add port_fdb_prepare

Thu, Oct 08, 2015 at 05:35:12PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Push the prepare phase for FDB operations down to the DSA drivers, with >a new port_fdb_prepare function. Currently only mv88e6xxx is affected. > >Signed-off-by: Vivien Didelot Reviewed-by

Re: [PATCH net-next 0/6] net: dsa: push switchdev prepare phase in FDB ops

Thu, Oct 08, 2015 at 03:32:51PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Hi David, > >On Oct. Thursday 08 (41) 05:28 AM, David Miller wrote: >> From: Vivien Didelot >> Date: Wed, 7 Oct 2015 19:48:25 -0400 >> >> > The first 3 patches removes the dsa.h include from linux/netdevice.h,

Re: [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h

Thu, Oct 08, 2015 at 02:11:11PM CEST, huangda...@hisilicon.com wrote: >On 2015/10/8 17:18, Jiri Pirko wrote: >>Thu, Oct 08, 2015 at 11:04:48AM CEST, l...@intel.com wrote: >>>Hi Vivien, >>> >>>[auto build test ERROR on net-next/master -- if it's inappropriate ba

Re: [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h

Thu, Oct 08, 2015 at 11:04:48AM CEST, l...@intel.com wrote: >Hi Vivien, > >[auto build test ERROR on net-next/master -- if it's inappropriate base, >please ignore] > >config: arm64-allyesconfig (attached as .config) >reproduce: >wget >

Re: [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h

Thu, Oct 08, 2015 at 11:04:48AM CEST, l...@intel.com wrote: >Hi Vivien, > >[auto build test ERROR on net-next/master -- if it's inappropriate base, >please ignore] > >config: arm64-allyesconfig (attached as .config) >reproduce: >wget >

Re: [PATCH net-next 3/6] net: remove dsa.h include from linux/netdevice.h

Thu, Oct 08, 2015 at 02:11:11PM CEST, huangda...@hisilicon.com wrote: >On 2015/10/8 17:18, Jiri Pirko wrote: >>Thu, Oct 08, 2015 at 11:04:48AM CEST, l...@intel.com wrote: >>>Hi Vivien, >>> >>>[auto build test ERROR on net-next/master -- if it's inappropriate ba

Re: [PATCH net-next 0/6] net: dsa: push switchdev prepare phase in FDB ops

Thu, Oct 08, 2015 at 03:32:51PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Hi David, > >On Oct. Thursday 08 (41) 05:28 AM, David Miller wrote: >> From: Vivien Didelot >> Date: Wed, 7 Oct 2015 19:48:25 -0400 >> >> > The first 3 patches removes the

Re: [PATCH net-next v2 3/3] net: dsa: use switchdev obj in port_fdb_del

Thu, Oct 08, 2015 at 05:35:14PM CEST, vivien.dide...@savoirfairelinux.com wrote: >For consistency with the FDB add operation, propagate the >switchdev_obj_port_fdb structure in the DSA drivers. > >Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed

Re: [PATCH net-next v2 2/3] net: dsa: push prepare phase in port_fdb_add

Thu, Oct 08, 2015 at 05:35:13PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Now that the prepare phase is pushed down to the DSA drivers, propagate >it to the port_fdb_add function. > >Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Reviewed

Re: [PATCH net-next v2 1/3] net: dsa: add port_fdb_prepare

rfairelinux.com> Reviewed-by: Jiri Pirko <j...@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h

Tue, Oct 06, 2015 at 11:54:24PM CEST, vivien.dide...@savoirfairelinux.com wrote: >In order to push switchdev objects down to DSA drivers, I need to include >switchdev.h in dsa.h. But compilation fails because of a circular dependency >issue, since dsa.h is also included in linux/netdevice.h. >

Re: [PATCH v2] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

ct the bits while avoiding that warning. > >Signed-off-by: Arnd Bergmann >Acked-by: Jiri Pirko >Fixes: eda6500a987a "mlxsw: Add PCI bus implementation" >--- >I've kept Jiri's Ack despite having in effect a completely different >patch here, as the effect and the changelog

Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

Wed, Oct 07, 2015 at 08:53:02AM CEST, j...@perches.com wrote: >On Tue, 2015-10-06 at 23:47 +0200, Arnd Bergmann wrote: >> The recently added mlxsw driver produces warnings in ARM >> allmodconfig: >> >> drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec': >>

Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

to u64, which gets rid of the >warning and seems nicer than adding #ifdefs. > >Signed-off-by: Arnd Bergmann >Fixes: eda6500a987a "mlxsw: Add PCI bus implementation" Acked-by: Jiri Pirko Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

Wed, Oct 07, 2015 at 08:53:02AM CEST, j...@perches.com wrote: >On Tue, 2015-10-06 at 23:47 +0200, Arnd Bergmann wrote: >> The recently added mlxsw driver produces warnings in ARM >> allmodconfig: >> >> drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec': >>

Re: [PATCH v2] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

ct the bits while avoiding that warning. > >Signed-off-by: Arnd Bergmann <a...@arndb.de> >Acked-by: Jiri Pirko <j...@mellanox.com> >Fixes: eda6500a987a "mlxsw: Add PCI bus implementation" >--- >I've kept Jiri's Ack despite having in effect a completely different >pat

Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

to u64, which gets rid of the >warning and seems nicer than adding #ifdefs. > >Signed-off-by: Arnd Bergmann <a...@arndb.de> >Fixes: eda6500a987a "mlxsw: Add PCI bus implementation" Acked-by: Jiri Pirko <j...@mellanox.com> Thanks! -- To unsubscribe from thi

Re: [PATCH net-next 0/3] net: remove dsa.h from netdevice.h

Tue, Oct 06, 2015 at 11:54:24PM CEST, vivien.dide...@savoirfairelinux.com wrote: >In order to push switchdev objects down to DSA drivers, I need to include >switchdev.h in dsa.h. But compilation fails because of a circular dependency >issue, since dsa.h is also included in linux/netdevice.h. >

Re: [PATCH v2 net-next 6/6] net: switchdev: extract struct switchdev_obj_*

Wed, Sep 30, 2015 at 04:58:38PM CEST, sfel...@gmail.com wrote: >On Wed, Sep 30, 2015 at 3:36 AM, Jiri Pirko wrote: >> Tue, Sep 29, 2015 at 06:07:18PM CEST, vivien.dide...@savoirfairelinux.com >> wrote: >>>Now that switchdev and its drivers directly use specific switc

Re: [PATCH v2 net-next 0/6] net: switchdev: use specific switchdev_obj_*

Tue, Sep 29, 2015 at 06:07:12PM CEST, vivien.dide...@savoirfairelinux.com wrote: >This patchset changes switchdev add, del, dump operations from this: > >int (*switchdev_port_obj_add)(struct net_device *dev, > struct switchdev_obj *obj, >

Re: [PATCH v2 net-next 4/6] net: switchdev: pass callback to dump operation

Tue, Sep 29, 2015 at 06:07:16PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Similar to the notifier_call callback of a notifier_block, change the >function signature of switchdev dump operation to: > >int switchdev_port_obj_dump(struct net_device *dev, >

Re: [PATCH v2 net-next 6/6] net: switchdev: extract struct switchdev_obj_*

Tue, Sep 29, 2015 at 06:07:18PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Now that switchdev and its drivers directly use specific switchdev_obj_* >structures, move them out of the switchdev_obj union and get rif of this >outer structure. > >Signed-off-by: Vivien Didelot >--- >

Re: [PATCH v2 net-next 6/6] net: switchdev: extract struct switchdev_obj_*

Tue, Sep 29, 2015 at 06:07:18PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Now that switchdev and its drivers directly use specific switchdev_obj_* >structures, move them out of the switchdev_obj union and get rif of this >outer structure. > >Signed-off-by: Vivien Didelot

Re: [PATCH v2 net-next 0/6] net: switchdev: use specific switchdev_obj_*

Tue, Sep 29, 2015 at 06:07:12PM CEST, vivien.dide...@savoirfairelinux.com wrote: >This patchset changes switchdev add, del, dump operations from this: > >int (*switchdev_port_obj_add)(struct net_device *dev, > struct switchdev_obj *obj, >

Re: [PATCH v2 net-next 4/6] net: switchdev: pass callback to dump operation

Tue, Sep 29, 2015 at 06:07:16PM CEST, vivien.dide...@savoirfairelinux.com wrote: >Similar to the notifier_call callback of a notifier_block, change the >function signature of switchdev dump operation to: > >int switchdev_port_obj_dump(struct net_device *dev, >

Re: [PATCH v2 net-next 6/6] net: switchdev: extract struct switchdev_obj_*

Wed, Sep 30, 2015 at 04:58:38PM CEST, sfel...@gmail.com wrote: >On Wed, Sep 30, 2015 at 3:36 AM, Jiri Pirko <j...@resnulli.us> wrote: >> Tue, Sep 29, 2015 at 06:07:18PM CEST, vivien.dide...@savoirfairelinux.com >> wrote: >>>Now that switchdev and its drivers direct

Re: [PATCH net] net: bridge: check __vlan_vid_del for error

Sun, Sep 06, 2015 at 03:27:57AM CEST, vivien.dide...@savoirfairelinux.com wrote: >Since __vlan_del can return an error code, change its inner function >__vlan_vid_del to return an eventual error from switchdev_port_obj_del. > >Signed-off-by: Vivien Didelot Acked-by: Jiri Pirko -- To

Re: [PATCH] net: bridge: remove unnecessary switchdev include

Sun, Sep 06, 2015 at 03:49:41AM CEST, vivien.dide...@savoirfairelinux.com wrote: >Remove the unnecessary switchdev.h include from br_netlink.c. > >Signed-off-by: Vivien Didelot Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe linux-kerne

Re: [PATCH net] net: bridge: check __vlan_vid_del for error

rfairelinux.com> Acked-by: Jiri Pirko <j...@resnulli.us> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] net: bridge: remove unnecessary switchdev include

Sun, Sep 06, 2015 at 03:49:41AM CEST, vivien.dide...@savoirfairelinux.com wrote: >Remove the unnecessary switchdev.h include from br_netlink.c. > >Signed-off-by: Vivien Didelot <vivien.dide...@savoirfairelinux.com> Acked-by: Jiri Pirko <j...@resnulli.us> -- To unsubscribe

Re: linux-next: manual merge of the rdma tree with the net-next tree

Fri, Aug 28, 2015 at 03:26:50AM CEST, s...@canb.auug.org.au wrote: >Hi Doug, > >Today's linux-next merge of the rdma tree got a conflict in: > > net/core/dev.c > >between commit: > > 0e4ead9d7b36 ("net: introduce change upper device notifier change info") > >from the net-next tree and commit: >

Re: linux-next: manual merge of the rdma tree with the net-next tree

Fri, Aug 28, 2015 at 03:26:50AM CEST, s...@canb.auug.org.au wrote: Hi Doug, Today's linux-next merge of the rdma tree got a conflict in: net/core/dev.c between commit: 0e4ead9d7b36 (net: introduce change upper device notifier change info) from the net-next tree and commit: 133b5b93c734

Re: [PATCH 05/11] mlxsw: fix error return code

t;@@ >( >if (\(ret < 0\|ret != 0\)) > { ... return ret; } >| >ret = 0 >) >... when != ret = e1 >when != >*if(...) >{ > ... when != ret = e2 > when forall > return ret; >} >// > >Signed-off-by: Julia Lawall Acked-by: Jiri Pirko -- To

Re: [PATCH 05/11] mlxsw: fix error return code

\)) { ... return ret; } | ret = 0 ) ... when != ret = e1 when != ret *if(...) { ... when != ret = e2 when forall return ret; } // /smpl Signed-off-by: Julia Lawall julia.law...@lip6.fr Acked-by: Jiri Pirko j...@mellanox.com -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH v2 net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

aradhan Reviewed-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 net-next] net/vxlan: Fix kernel unaligned access in __vxlan_find_mac

...@oracle.com Reviewed-by: Jiri Pirko j...@resnulli.us -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] net: switchdev: don't abort unsupported operations

gt; >Signed-off-by: Vivien Didelot Sounds reasonable. Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] net: switchdev: don't abort unsupported operations

Didelot vivien.dide...@savoirfairelinux.com Sounds reasonable. Acked-by: Jiri Pirko j...@resnulli.us -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] team: set IFF_SLAVE on team ports

Thu, Jul 09, 2015 at 05:36:55PM CEST, jblu...@infradead.org wrote: >On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko wrote: >> Thu, Jul 09, 2015 at 11:58:34AM CEST, jblu...@infradead.org wrote: >>>The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to >>&g

Re: [PATCH] team: set IFF_SLAVE on team ports

Thu, Jul 09, 2015 at 05:36:55PM CEST, jblu...@infradead.org wrote: On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko j...@resnulli.us wrote: Thu, Jul 09, 2015 at 11:58:34AM CEST, jblu...@infradead.org wrote: The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to decide if it should

Re: [PATCH] team: set IFF_SLAVE on team ports

Thu, Jul 09, 2015 at 11:58:34AM CEST, jblu...@infradead.org wrote: >The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to >decide if it should start the address configuration. Since team ports >shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking >a port

Re: [PATCH] team: set IFF_SLAVE on team ports

Thu, Jul 09, 2015 at 11:58:34AM CEST, jblu...@infradead.org wrote: The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to decide if it should start the address configuration. Since team ports shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking a port to

Re: [PATCH] flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect()

Thu, Jun 25, 2015 at 03:33:31PM CEST, da...@davemloft.net wrote: >From: Geert Uytterhoeven >Date: Thu, 25 Jun 2015 15:10:32 +0200 > >> net/core/flow_dissector.c: In function ‘__skb_flow_dissect’: >> net/core/flow_dissector.c:132: warning: ‘ip_proto’ may be used uninitialized >> in this function

Re: [PATCH] flow_dissector: Pre-initialize ip_proto in __skb_flow_dissect()

Thu, Jun 25, 2015 at 03:33:31PM CEST, da...@davemloft.net wrote: From: Geert Uytterhoeven ge...@linux-m68k.org Date: Thu, 25 Jun 2015 15:10:32 +0200 net/core/flow_dissector.c: In function ‘__skb_flow_dissect’: net/core/flow_dissector.c:132: warning: ‘ip_proto’ may be used uninitialized in

Re: [PATCH] net: dsa: add support for switchdev VLAN objects

Tue, Jun 23, 2015 at 07:18:49PM CEST, vivien.dide...@savoirfairelinux.com wrote: >This patch adds the glue between DSA and switchdev operations to add, >delete and dump SWITCHDEV_OBJ_PORT_VLAN objects. > >This is a first step to link the "bridge vlan" command with hardware >entries for DSA

Re: [PATCH] net: dsa: add support for switchdev VLAN objects

Tue, Jun 23, 2015 at 07:18:49PM CEST, vivien.dide...@savoirfairelinux.com wrote: This patch adds the glue between DSA and switchdev operations to add, delete and dump SWITCHDEV_OBJ_PORT_VLAN objects. This is a first step to link the bridge vlan command with hardware entries for DSA compatible

Re: [PATCH] net: switchdev: ignore unsupported bridge flags

rrors different than -EOPNOTSUPP. > >(This is a follow-up patch for 7d4f8d8.) > >Signed-off-by: Vivien Didelot Fixes: 8793d0a664a8 ("switchdev: add new switchdev_port_bridge_getlink") Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH] net: switchdev: ignore unsupported bridge flags

-EOPNOTSUPP. (This is a follow-up patch for 7d4f8d8.) Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com Fixes: 8793d0a664a8 (switchdev: add new switchdev_port_bridge_getlink) Acked-by: Jiri Pirko j...@resnulli.us -- To unsubscribe from this list: send the line unsubscribe linux

Re: [LKP] [flow_dissect] 06635a35d13: kernel BUG at include/linux/skbuff.h:1702!

Tue, May 19, 2015 at 08:07:29AM CEST, j...@resnulli.us wrote: ... > >Hmm, looks like eth_get_headlen is not returning what it should. Looking >into this. update: I'm still trying to get hand on hw so I can debug this. I did not find the problem doing code inspection. -- To unsubscribe from this

Re: [LKP] [flow_dissect] 06635a35d13: kernel BUG at include/linux/skbuff.h:1702!

Tue, May 19, 2015 at 08:07:29AM CEST, j...@resnulli.us wrote: ... Hmm, looks like eth_get_headlen is not returning what it should. Looking into this. update: I'm still trying to get hand on hw so I can debug this. I did not find the problem doing code inspection. -- To unsubscribe from this

Re: [LKP] [flow_dissect] 06635a35d13: kernel BUG at include/linux/skbuff.h:1702!

Tue, May 19, 2015 at 03:33:49AM CEST, ying.hu...@linux.intel.com wrote: >FYI, we noticed the below changes on > >git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >commit 06635a35d13d42b95422bba6633f175245cc644e ("flow_dissect: use >programable dissector in skb_flow_dissect

Re: [LKP] [flow_dissect] 06635a35d13: kernel BUG at include/linux/skbuff.h:1702!

Tue, May 19, 2015 at 03:33:49AM CEST, ying.hu...@linux.intel.com wrote: FYI, we noticed the below changes on git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master commit 06635a35d13d42b95422bba6633f175245cc644e (flow_dissect: use programable dissector in skb_flow_dissect and

Re: [PATCH] netns: deinline net_generic()

> > text data bss dec hex filename >82447071 22255384 20627456 125329911 77861f7 vmlinux4 >82419165 22255384 20627456 125302005 777f4f5 vmlinux5 > >Signed-off-by: Denys Vlasenko >CC: Eric W. Biederman >CC: David S. Miller >CC: Jan Engelhardt >CC: Jir

Re: [PATCH] netns: deinline net_generic()

...@medozas.de CC: Jiri Pirko jpi...@redhat.com CC: linux-kernel@vger.kernel.org CC: net...@vger.kernel.org --- include/net/netns/generic.h | 15 +-- net/core/net_namespace.c| 16 2 files changed, 17 insertions(+), 14 deletions(-) diff --git a/include/net/netns

Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue

Sat, Mar 21, 2015 at 07:02:40PM CET, andreimar...@gmail.com wrote: >Fixed a space coding style issue found by checkpatch.pl in rocker.c > >Signed-off-by: Andrei Maresu >--- > drivers/net/ethernet/rocker/rocker.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git

Re: [PATCH] Net: ethernet: rocker: fixed a space coding style issue

Sat, Mar 21, 2015 at 07:02:40PM CET, andreimar...@gmail.com wrote: Fixed a space coding style issue found by checkpatch.pl in rocker.c Signed-off-by: Andrei Maresu andreimar...@gmail.com --- drivers/net/ethernet/rocker/rocker.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2] ipv6: expose RFC4191 route preference via rtnetlink

Wed, Mar 11, 2015 at 03:39:21PM CET, lkund...@v3.sk wrote: >This makes it possible to retain the route preference when RAs are handled in >userspace. > >Signed-off-by: Lubomir Rintel Reviewed-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: linux-next: Tree for Mar 10 (netdev/switchdev)

Wed, Mar 11, 2015 at 12:26:35AM CET, rdun...@infradead.org wrote: >On 03/09/15 22:59, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20150306: >> > > >on x86_64: > >net/built-in.o: In function `netdev_switch_fib_ipv4_abort': >(.text+0xf7811): undefined reference to `fib_flush_external' >

Re: [PATCH v2] ipv6: expose RFC4191 route preference via rtnetlink

Wed, Mar 11, 2015 at 03:39:21PM CET, lkund...@v3.sk wrote: This makes it possible to retain the route preference when RAs are handled in userspace. Signed-off-by: Lubomir Rintel lkund...@v3.sk Reviewed-by: Jiri Pirko j...@resnulli.us -- To unsubscribe from this list: send the line unsubscribe

Re: linux-next: Tree for Mar 10 (netdev/switchdev)

Wed, Mar 11, 2015 at 12:26:35AM CET, rdun...@infradead.org wrote: On 03/09/15 22:59, Stephen Rothwell wrote: Hi all, Changes since 20150306: on x86_64: net/built-in.o: In function `netdev_switch_fib_ipv4_abort': (.text+0xf7811): undefined reference to `fib_flush_external' I'm taking

Re: [PATCH] ipv6: expose RFC4191 route preference via rtnetlink

Tue, Mar 10, 2015 at 04:56:53PM CET, lkund...@v3.sk wrote: >On Tue, 2015-03-03 at 16:17 +0100, Jiri Pirko wrote: >> Tue, Mar 03, 2015 at 11:01:52AM CET, lkund...@v3.sk wrote: >> >This makes it possible to retain the route preference when RAs are handled >> >in >>

Re: [PATCH] ipv6: expose RFC4191 route preference via rtnetlink

Tue, Mar 10, 2015 at 04:56:53PM CET, lkund...@v3.sk wrote: On Tue, 2015-03-03 at 16:17 +0100, Jiri Pirko wrote: Tue, Mar 03, 2015 at 11:01:52AM CET, lkund...@v3.sk wrote: This makes it possible to retain the route preference when RAs are handled in userspace. Signed-off-by: Lubomir Rintel

Re: [PATCH] ipv6: expose RFC4191 route preference via rtnetlink

Tue, Mar 03, 2015 at 11:01:52AM CET, lkund...@v3.sk wrote: >This makes it possible to retain the route preference when RAs are handled in >userspace. > >Signed-off-by: Lubomir Rintel >--- > include/uapi/linux/rtnetlink.h | 1 + > net/ipv6/route.c | 16 +++- > 2 files

Re: [PATCH] ipv6: expose RFC4191 route preference via rtnetlink

Tue, Mar 03, 2015 at 11:01:52AM CET, lkund...@v3.sk wrote: This makes it possible to retain the route preference when RAs are handled in userspace. Signed-off-by: Lubomir Rintel lkund...@v3.sk --- include/uapi/linux/rtnetlink.h | 1 + net/ipv6/route.c | 16 +++- 2

Re: [patch 2/2] rocker: silence shift wrapping warning

till we may as well silence the warning even if it's not a >real bug. It can have up to 62 ports. > >Signed-off-by: Dan Carpenter Acked-by: Jiri Pirko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

Re: [patch 2/2] rocker: silence shift wrapping warning

the warning even if it's not a real bug. It can have up to 62 ports. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Jiri Pirko j...@resnulli.us -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

Fri, Dec 19, 2014 at 10:35:27AM CET, marichi...@gmail.com wrote: >On 19 December 2014 at 14:53, Jiri Pirko wrote: >> Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: >>>On 19 December 2014 at 13:57, Jiri Pirko wrote: >>>> Fri, Dec 19, 2014 at 06:14:

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

Fri, Dec 19, 2014 at 10:22:24AM CET, marichi...@gmail.com wrote: >On 19 December 2014 at 14:31, B Viswanath wrote: >> On 19 December 2014 at 13:57, Jiri Pirko wrote: >>> Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: >>>>On 19 December 2014 at 0

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

Fri, Dec 19, 2014 at 10:01:46AM CET, marichi...@gmail.com wrote: >On 19 December 2014 at 13:57, Jiri Pirko wrote: >> Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: >>>On 19 December 2014 at 05:18, Roopa Prabhu wrote: >>>> On 12/18/14, 3:2

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: >On 19 December 2014 at 05:18, Roopa Prabhu wrote: >> On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: >>> >>> >>> On 12/18/2014 3:07 PM, Roopa Prabhu wrote: On 12/18/14, 11:21 AM, John Fastabend wrote: > > On

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

Fri, Dec 19, 2014 at 12:48:28AM CET, ro...@cumulusnetworks.com wrote: >On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: >> >>On 12/18/2014 3:07 PM, Roopa Prabhu wrote: >>>On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014 10:14 AM, Roopa Prabhu wrote: >On 12/18/14, 10:02 AM,

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

opa Prabhu; Varlese, Marco >>Cc: net...@vger.kernel.org; Thomas Graf; Jiri Pirko; sfel...@gmail.com; linux- >>ker...@vger.kernel.org >>Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port >>configuration >> >>On 12/18/2014 10:14 AM, Roopa Prabhu wrote: &

Re: [RFC PATCH net-next v3 1/1] net: Support for switch port configuration

Fri, Dec 19, 2014 at 01:35:10AM CET, tg...@suug.ch wrote: >On 12/18/14 at 08:03am, John Fastabend wrote: >> On 12/18/2014 07:30 AM, Varlese, Marco wrote: >> Could you also document the attributes. I think they are mostly >> clear but what is IFLA_SW_LOOPBACK. It will help later when we >> try to

Re: [RFC PATCH net-next v3 1/1] net: Support for switch port configuration

Fri, Dec 19, 2014 at 01:35:10AM CET, tg...@suug.ch wrote: On 12/18/14 at 08:03am, John Fastabend wrote: On 12/18/2014 07:30 AM, Varlese, Marco wrote: Could you also document the attributes. I think they are mostly clear but what is IFLA_SW_LOOPBACK. It will help later when we try to read the

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

; Thomas Graf; Jiri Pirko; sfel...@gmail.com; linux- ker...@vger.kernel.org Subject: Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration On 12/18/2014 10:14 AM, Roopa Prabhu wrote: On 12/18/14, 10:02 AM, Varlese, Marco wrote: Removed unnecessary content for ease of reading

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

Fri, Dec 19, 2014 at 12:48:28AM CET, ro...@cumulusnetworks.com wrote: On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: On 12/18/2014 3:07 PM, Roopa Prabhu wrote: On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014 10:14 AM, Roopa Prabhu wrote: On 12/18/14, 10:02 AM, Varlese, Marco wrote:

Re: [RFC PATCH net-next v2 1/1] net: Support for switch port configuration

Fri, Dec 19, 2014 at 06:14:57AM CET, marichi...@gmail.com wrote: On 19 December 2014 at 05:18, Roopa Prabhu ro...@cumulusnetworks.com wrote: On 12/18/14, 3:26 PM, Samudrala, Sridhar wrote: On 12/18/2014 3:07 PM, Roopa Prabhu wrote: On 12/18/14, 11:21 AM, John Fastabend wrote: On 12/18/2014

<    1   2   3   4   5   6   7   8   9   >