Re: [PATCH v3] net: mvneta: support suspend and resume

ct net_device *dev = dev_get_drvdata(device); > + struct mvneta_port *pp = netdev_priv(dev); > + int err; > + > + clk_prepare_enable(pp->clk); > + clk_prepare_enable(pp->clk_bus); hmm, since clk_bus is optional, it's better to add check here. Except the abov

Re: [PATCH v2] net: mvneta: support suspend and resume

On Thu, 16 Mar 2017 11:19:10 +0800 Jane Li wrote: > Add basic support for handling suspend and resume. > > Signed-off-by: Jane Li > --- > Since v1: > - add mvneta_conf_mbus_windows() and mvneta_bm_port_init() in mvneta_resume() > > drivers/net/ethernet/marvell/mvneta.c | 62

Re: [PATCH v2] net: mvneta: support suspend and resume

On Thu, 16 Mar 2017 11:19:10 +0800 Jane Li wrote: > Add basic support for handling suspend and resume. > > Signed-off-by: Jane Li > --- > Since v1: > - add mvneta_conf_mbus_windows() and mvneta_bm_port_init() in mvneta_resume() > > drivers/net/ethernet/marvell/mvneta.c | 62 >

Re: [PATCH v6 08/14] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ziji On Wed, 15 Mar 2017 21:58:43 +0800 Ziji Hu wrote: > Hi Ulf, > > On 2017/3/15 21:11, Ulf Hansson wrote: > > On 14 February 2017 at 18:01, Gregory CLEMENT > > wrote: > >> From: Hu Ziji > > >> +config MMC_SDHCI_XENON > >> +

Re: [PATCH v6 08/14] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ziji On Wed, 15 Mar 2017 21:58:43 +0800 Ziji Hu wrote: > Hi Ulf, > > On 2017/3/15 21:11, Ulf Hansson wrote: > > On 14 February 2017 at 18:01, Gregory CLEMENT > > wrote: > >> From: Hu Ziji > > >> +config MMC_SDHCI_XENON > >> + tristate "Marvell Xenon eMMC/SD/SDIO SDHCI driver" >

Re: [PATCH] net: mvneta: support suspend and resume

Hi Jane, On Wed, 15 Mar 2017 15:08:34 +0800 Jane Li wrote: > Add basic support for handling suspend and resume. > > Signed-off-by: Jane Li > --- > drivers/net/ethernet/marvell/mvneta.c | 44 > +++ > 1 file changed, 44 insertions(+) > > diff

Re: [PATCH] net: mvneta: support suspend and resume

Hi Jane, On Wed, 15 Mar 2017 15:08:34 +0800 Jane Li wrote: > Add basic support for handling suspend and resume. > > Signed-off-by: Jane Li > --- > drivers/net/ethernet/marvell/mvneta.c | 44 > +++ > 1 file changed, 44 insertions(+) > > diff --git

Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq()

On Tue, 14 Mar 2017 17:59:01 +0200 Andy Shevchenko wrote: > On Tue, Mar 14, 2017 at 3:44 PM, Vignesh R wrote: > > On Monday 13 March 2017 01:35 AM, Andy Shevchenko wrote: > >> On Wed, Mar 8, 2017 at 2:19 PM, Vignesh R wrote: > >>> Passing "serial" as name

Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq()

On Tue, 14 Mar 2017 17:59:01 +0200 Andy Shevchenko wrote: > On Tue, Mar 14, 2017 at 3:44 PM, Vignesh R wrote: > > On Monday 13 March 2017 01:35 AM, Andy Shevchenko wrote: > >> On Wed, Mar 8, 2017 at 2:19 PM, Vignesh R wrote: > >>> Passing "serial" as name during request_irq() results in all

[PATCH 1/3] mmc: sdhci-pxav3: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, remove the unnecessary platform_set_drvdata() call. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- drivers/mmc/host/sdhci-pxav3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/d

[PATCH 2/3] mmc: sdhci-pxav2: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, remove the unnecessary platform_set_drvdata() call. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- drivers/mmc/host/sdhci-pxav2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav2.c b/d

[PATCH 1/3] mmc: sdhci-pxav3: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, remove the unnecessary platform_set_drvdata() call. Signed-off-by: Jisheng Zhang --- drivers/mmc/host/sdhci-pxav3.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3

[PATCH 2/3] mmc: sdhci-pxav2: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, remove the unnecessary platform_set_drvdata() call. Signed-off-by: Jisheng Zhang --- drivers/mmc/host/sdhci-pxav2.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-pxav2.c b/drivers/mmc/host/sdhci-pxav2

[PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, remove the unnecessary platform_set_drvdata() call. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- drivers/mmc/host/sdhci-st.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-st.c b/drive

[PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, so its users doesn't need to set the drvdata again. These patches clean up all unnecessary platform_set_drvdata() call. Jisheng Zhang (3): mmc: sdhci-pxav3: remove unnecessary platform_set_drvdata() call mmc: sdhci-pxav2: remove

[PATCH 3/3] mmc: sdhci-st: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, remove the unnecessary platform_set_drvdata() call. Signed-off-by: Jisheng Zhang --- drivers/mmc/host/sdhci-st.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-st.c b/drivers/mmc/host/sdhci-st.c index

[PATCH 0/3] mmc: sdhci: remove unnecessary platform_set_drvdata() call

sdhci_pltfm_init() has already set the platform drvdata for us, so its users doesn't need to set the drvdata again. These patches clean up all unnecessary platform_set_drvdata() call. Jisheng Zhang (3): mmc: sdhci-pxav3: remove unnecessary platform_set_drvdata() call mmc: sdhci-pxav2: remove

Re: [PATCH] mm: free reserved area's memmap if possiable

Add Chen, Catalin On Thu, 16 Feb 2017 09:11:29 +0800 zhouxianrong wrote: > > > On 2017/2/15 15:10, Ard Biesheuvel wrote: > > On 15 February 2017 at 01:44, zhouxianrong wrote: > >> > >> > >> On 2017/2/14 17:03, Ard Biesheuvel wrote: > >>> > >>> On 14 February 2017 at 06:53,

Re: [PATCH] mm: free reserved area's memmap if possiable

Add Chen, Catalin On Thu, 16 Feb 2017 09:11:29 +0800 zhouxianrong wrote: > > > On 2017/2/15 15:10, Ard Biesheuvel wrote: > > On 15 February 2017 at 01:44, zhouxianrong wrote: > >> > >> > >> On 2017/2/14 17:03, Ard Biesheuvel wrote: > >>> > >>> On 14 February 2017 at 06:53, wrote: >

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi David, Marcin, On Tue, 21 Feb 2017 11:16:02 -0500 David Miller wrote: > From: Jisheng Zhang <jszh...@marvell.com> > Date: Tue, 21 Feb 2017 12:37:40 +0800 > > > Thanks for your review. > > > > The measurement is simple: record how much time we spent in mvnet

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi David, Marcin, On Tue, 21 Feb 2017 11:16:02 -0500 David Miller wrote: > From: Jisheng Zhang > Date: Tue, 21 Feb 2017 12:37:40 +0800 > > > Thanks for your review. > > > > The measurement is simple: record how much time we spent in mvneta_rx_swbm() > >

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Gregory, On Mon, 20 Feb 2017 15:21:35 +0100 Gregory CLEMENT wrote: > Hi Jisheng, > > On lun., févr. 20 2017, Jisheng Zhang <jszh...@marvell.com> wrote: > > > In hot code path such as mvneta_rx_swbm(), we access fields of rx_desc > > and tx_desc.

Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

Hi Gregory, On Mon, 20 Feb 2017 15:21:35 +0100 Gregory CLEMENT wrote: > Hi Jisheng, > > On lun., févr. 20 2017, Jisheng Zhang wrote: > > > In hot code path such as mvneta_rx_swbm(), we access fields of rx_desc > > and tx_desc. These DMA descs are allocat

[PATCH net-next v3 1/4] net: mvneta: avoid getting status from rx_desc as much as possible

ory. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> Suggested-by: Arnd Bergmann <a...@arndb.de> Tested-by: Gregory CLEMENT <gregory.clem...@free-electrons.com> --- drivers/net/ethernet/marvell/mvneta.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

[PATCH net-next v3 1/4] net: mvneta: avoid getting status from rx_desc as much as possible

ory. Signed-off-by: Jisheng Zhang Suggested-by: Arnd Bergmann Tested-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/mvneta.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c in

[PATCH net-next v3 2/4] net: mvneta: avoid getting buf_phys_addr from rx_desc again

ing from uncached memory. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> Suggested-by: Gregory CLEMENT <gregory.clem...@free-electrons.com> --- drivers/net/ethernet/marvell/mvneta.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/marv

[PATCH net-next v3 2/4] net: mvneta: avoid getting buf_phys_addr from rx_desc again

ing from uncached memory. Signed-off-by: Jisheng Zhang Suggested-by: Gregory CLEMENT --- drivers/net/ethernet/marvell/mvneta.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 06df72b8d

[PATCH net-next v3 4/4] net: mvneta: Use cacheable memory to store the rx buffer DMA address

address. We get the following performance data on Marvell BG4CT Platforms (tested with iperf): before the patch: recving 1GB in mvneta_rx_swbm() costs 1492659600 ns after the patch: recving 1GB in mvneta_rx_swbm() costs 1421565640 ns We saved 4.76% time. Signed-off-by: Jisheng Zhang <j

[PATCH net-next v3 4/4] net: mvneta: Use cacheable memory to store the rx buffer DMA address

address. We get the following performance data on Marvell BG4CT Platforms (tested with iperf): before the patch: recving 1GB in mvneta_rx_swbm() costs 1492659600 ns after the patch: recving 1GB in mvneta_rx_swbm() costs 1421565640 ns We saved 4.76% time. Signed-off-by: Jisheng Zhang Suggested

[PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

wbm() - add patch 3 to avoid reading from tx_desc as much as possible Since v1: - correct the performance data typo Jisheng Zhang (4): net: mvneta: avoid getting status from rx_desc as much as possible net: mvneta: avoid getting buf_phys_addr from rx_desc again net: mvneta: avoid reading

[PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance

wbm() - add patch 3 to avoid reading from tx_desc as much as possible Since v1: - correct the performance data typo Jisheng Zhang (4): net: mvneta: avoid getting status from rx_desc as much as possible net: mvneta: avoid getting buf_phys_addr from rx_desc again net: mvneta: avoid reading

[PATCH net-next v3 3/4] net: mvneta: avoid reading from tx_desc as much as possible

. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- drivers/net/ethernet/marvell/mvneta.c | 50 ++- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index a25042

[PATCH net-next v3 3/4] net: mvneta: avoid reading from tx_desc as much as possible

. Signed-off-by: Jisheng Zhang --- drivers/net/ethernet/marvell/mvneta.c | 50 ++- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index a25042801eec..b6cda4131c78 100644

Re: [PATCH net-next v2 0/2] net: mvneta: improve rx performance

On Fri, 17 Feb 2017 11:37:21 +0100 Gregory CLEMENT wrote: > Hi Jisheng, > > On ven., févr. 17 2017, Jisheng Zhang <jszh...@marvell.com> wrote: > > > In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm(), we may > > access fields of rx_

Re: [PATCH net-next v2 0/2] net: mvneta: improve rx performance

On Fri, 17 Feb 2017 11:37:21 +0100 Gregory CLEMENT wrote: > Hi Jisheng, > > On ven., févr. 17 2017, Jisheng Zhang wrote: > > > In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm(), we may > > access fields of rx_desc. The rx_desc is allocated by >

Re: [PATCH net-next v2 0/2] net: mvneta: improve rx performance

On Fri, 17 Feb 2017 18:02:31 +0800 Jisheng Zhang <jszh...@marvell.com> wrote: > In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm(), we may > access fields of rx_desc. The rx_desc is allocated by > dma_alloc_coherent, it's uncacheable if the device isn't cache > cohe

Re: [PATCH net-next v2 0/2] net: mvneta: improve rx performance

On Fri, 17 Feb 2017 18:02:31 +0800 Jisheng Zhang wrote: > In hot code path such as mvneta_rx_hwbm() and mvneta_rx_swbm(), we may > access fields of rx_desc. The rx_desc is allocated by > dma_alloc_coherent, it's uncacheable if the device isn't cache > coherent, reading from unc

[PATCH net-next v2 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

the rx buffer DMA address. We get the following performance data on Marvell BG4CT Platforms (tested with iperf): before the patch: recving 1GB in mvneta_rx_swbm() costs 1492659600 ns after the patch: recving 1GB in mvneta_rx_swbm() costs 1421565640 ns We saved 4.76% time. Signed-off-by: Jisheng

[PATCH net-next v2 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

the rx buffer DMA address. We get the following performance data on Marvell BG4CT Platforms (tested with iperf): before the patch: recving 1GB in mvneta_rx_swbm() costs 1492659600 ns after the patch: recving 1GB in mvneta_rx_swbm() costs 1421565640 ns We saved 4.76% time. Signed-off-by: Jisheng

[PATCH net-next v2 1/2] net: mvneta: avoid getting status from rx_desc as much as possible

ory. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> Suggested-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/ethernet/marvell/mvneta.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell

[PATCH net-next v2 1/2] net: mvneta: avoid getting status from rx_desc as much as possible

ory. Signed-off-by: Jisheng Zhang Suggested-by: Arnd Bergmann --- drivers/net/ethernet/marvell/mvneta.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 61dd4462411c..06df72b8da85 100

[PATCH net-next v2 0/2] net: mvneta: improve rx performance

/msg405889.html Since v1: - correct the performance data typo Jisheng Zhang (2): net: mvneta: avoid getting status from rx_desc as much as possible net: mvneta: Use cacheable memory to store the rx buffer DMA address drivers/net/ethernet/marvell/mvneta.c | 36

[PATCH net-next v2 0/2] net: mvneta: improve rx performance

/msg405889.html Since v1: - correct the performance data typo Jisheng Zhang (2): net: mvneta: avoid getting status from rx_desc as much as possible net: mvneta: Use cacheable memory to store the rx buffer DMA address drivers/net/ethernet/marvell/mvneta.c | 36

[PATCH net-next 0/2] net: mvneta: improve rx performance

/msg405889.html Jisheng Zhang (2): net: mvneta: avoid getting status from rx_desc as much as possible net: mvneta: Use cacheable memory to store the rx buffer DMA address drivers/net/ethernet/marvell/mvneta.c | 36 --- 1 file changed, 21 insertions(+), 15

[PATCH net-next 0/2] net: mvneta: improve rx performance

/msg405889.html Jisheng Zhang (2): net: mvneta: avoid getting status from rx_desc as much as possible net: mvneta: Use cacheable memory to store the rx buffer DMA address drivers/net/ethernet/marvell/mvneta.c | 36 --- 1 file changed, 21 insertions(+), 15

[PATCH net-next 1/2] net: mvneta: avoid getting status from rx_desc as much as possible

ory. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> Suggested-by: Arnd Bergmann <a...@arndb.de> --- drivers/net/ethernet/marvell/mvneta.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell

[PATCH net-next 1/2] net: mvneta: avoid getting status from rx_desc as much as possible

ory. Signed-off-by: Jisheng Zhang Suggested-by: Arnd Bergmann --- drivers/net/ethernet/marvell/mvneta.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c index 61dd4462411c..06df72b8da85 100

[PATCH net-next 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

the rx buffer DMA address. We get the following performance data on Marvell BG4CT Platforms (tested with iperf): before the patch: recving 1GB in mvneta_rx_swbm() costs 149265960 ns after the patch: recving 1GB in mvneta_rx_swbm() costs 1421565640 ns We saved 4.76% time. Signed-off-by: Jisheng

[PATCH net-next 2/2] net: mvneta: Use cacheable memory to store the rx buffer DMA address

the rx buffer DMA address. We get the following performance data on Marvell BG4CT Platforms (tested with iperf): before the patch: recving 1GB in mvneta_rx_swbm() costs 149265960 ns after the patch: recving 1GB in mvneta_rx_swbm() costs 1421565640 ns We saved 4.76% time. Signed-off-by: Jisheng

[PATCH] net: mvneta: make mvneta_eth_tool_ops static

The mvneta_eth_tool_ops is only used internally in mvneta driver, so make it static. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/d

[PATCH] net: mvneta: make mvneta_eth_tool_ops static

The mvneta_eth_tool_ops is only used internally in mvneta driver, so make it static. Signed-off-by: Jisheng Zhang --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell

Re: [PATCH 3/3] pinctrl: berlin: make bool drivers explicitly non-modular

> We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij <linus.wall...@linaro.org> > Cc: "Antoine Ténart" <antoine.ten...@free-electrons.com> > Cc: Sebas

Re: [PATCH 3/3] pinctrl: berlin: make bool drivers explicitly non-modular

> We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij > Cc: "Antoine Ténart" > Cc: Sebastian Hesselbarth > Cc: Jisheng Zhang > Cc: Hongzhou Yang > Cc: Thom

Re: [PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol

On Mon, 6 Feb 2017 15:08:48 +0800 Jisheng Zhang wrote: > Hi Andrew, > > On Mon, 23 Jan 2017 19:10:34 +0100 Andrew Lunn wrote: > > > > > On Mon, Jan 23, 2017 at 02:55:07PM +0800, Jisheng Zhang wrote: > > > From: Jingju Hou <houji...@marvell.com&g

Re: [PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol

On Mon, 6 Feb 2017 15:08:48 +0800 Jisheng Zhang wrote: > Hi Andrew, > > On Mon, 23 Jan 2017 19:10:34 +0100 Andrew Lunn wrote: > > > > > On Mon, Jan 23, 2017 at 02:55:07PM +0800, Jisheng Zhang wrote: > > > From: Jingju Hou > > > > > > Fr

Re: [PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol

Hi Andrew, On Mon, 23 Jan 2017 19:10:34 +0100 Andrew Lunn wrote: > > On Mon, Jan 23, 2017 at 02:55:07PM +0800, Jisheng Zhang wrote: > > From: Jingju Hou <houji...@marvell.com> > > > > From: Jingju Hou <houji...@marvell.com> > > > > The mvnet

Re: [PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol

Hi Andrew, On Mon, 23 Jan 2017 19:10:34 +0100 Andrew Lunn wrote: > > On Mon, Jan 23, 2017 at 02:55:07PM +0800, Jisheng Zhang wrote: > > From: Jingju Hou > > > > From: Jingju Hou > > > > The mvneta itself does not support WOL, but the PHY mig

[PATCH v5 net-next] net: mvneta: implement .set_wol and .get_wol

From: Jingju Hou <houji...@marvell.com> The mvneta itself does not support WOL, but the PHY might. So pass the calls to the PHY Signed-off-by: Jingju Hou <houji...@marvell.com> Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- since v4: - address Andrew Lunn's comment s

[PATCH v5 net-next] net: mvneta: implement .set_wol and .get_wol

From: Jingju Hou The mvneta itself does not support WOL, but the PHY might. So pass the calls to the PHY Signed-off-by: Jingju Hou Signed-off-by: Jisheng Zhang --- since v4: - address Andrew Lunn's comment since v3: - really fix the build error since v2,v1: - using phy_dev member

[PATCH] pinctrl: berlin-bg4ct: fix the value for "sd1a" of pin SCRD0_CRD_PRES

This should be a typo. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- drivers/pinctrl/berlin/berlin-bg4ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/berlin/berlin-bg4ct.c b/drivers/pinctrl/berlin/berlin-bg4ct.c index 09172043d589..c617ec

[PATCH] pinctrl: berlin-bg4ct: fix the value for "sd1a" of pin SCRD0_CRD_PRES

This should be a typo. Signed-off-by: Jisheng Zhang --- drivers/pinctrl/berlin/berlin-bg4ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/berlin/berlin-bg4ct.c b/drivers/pinctrl/berlin/berlin-bg4ct.c index 09172043d589..c617ec49e9ed 100644 --- a/drivers

[RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code

ndant code at driver. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- drivers/usb/chipidea/ci_hdrc_usb2.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c index 4456d2cf80ff..d162cc0bb8ce 100644 --- a/driv

[RESEND PATCH] usb: chipidea: usb2: delete the redundant setting default DMA mask code

ndant code at driver. Signed-off-by: Jisheng Zhang --- drivers/usb/chipidea/ci_hdrc_usb2.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/usb/chipidea/ci_hdrc_usb2.c b/drivers/usb/chipidea/ci_hdrc_usb2.c index 4456d2cf80ff..d162cc0bb8ce 100644 --- a/drivers/usb/chipidea/ci_hdrc_us

[RESEND PATCH] usb: chipidea: delete an useless header include

is for net phy drivers, we don't need it. Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- drivers/usb/chipidea/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 3dbb4a21ab44..77078083e9fb 100644 --- a/drive

[RESEND PATCH] usb: chipidea: delete an useless header include

is for net phy drivers, we don't need it. Signed-off-by: Jisheng Zhang --- drivers/usb/chipidea/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c index 3dbb4a21ab44..77078083e9fb 100644 --- a/drivers/usb/chipidea/core.c +++ b

[PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol

From: Jingju Hou <houji...@marvell.com> From: Jingju Hou <houji...@marvell.com> The mvneta itself does not support WOL, but the PHY might. So pass the calls to the PHY Signed-off-by: Jingju Hou <houji...@marvell.com> Signed-off-by: Jisheng Zhang <jszh...@marvell.com> ---

[PATCH v4 net-next] net: mvneta: implement .set_wol and .get_wol

From: Jingju Hou From: Jingju Hou The mvneta itself does not support WOL, but the PHY might. So pass the calls to the PHY Signed-off-by: Jingju Hou Signed-off-by: Jisheng Zhang --- since v3: - really fix the build error since v2,v1: - using phy_dev member in struct net_device - add

Re: [PATCH] serial: 8250_dw: #ifdef out dw8250_acpi_match if ACPI isn't set

Hi Greg, On Fri, 23 Dec 2016 19:09:23 +0100 Greg KH wrote: > > On Fri, Dec 23, 2016 at 08:33:55PM +0800, Jisheng Zhang wrote: > > dw8250_acpi_match is used only when ACPI is enabled. Fix the following > > gcc warning when W=1 is set: > > > > drivers/tty/serial/

Re: [PATCH] serial: 8250_dw: #ifdef out dw8250_acpi_match if ACPI isn't set

Hi Greg, On Fri, 23 Dec 2016 19:09:23 +0100 Greg KH wrote: > > On Fri, Dec 23, 2016 at 08:33:55PM +0800, Jisheng Zhang wrote: > > dw8250_acpi_match is used only when ACPI is enabled. Fix the following > > gcc warning when W=1 is set: > > > > drivers/tty/serial/

[PATCH] serial: 8250_dw: #ifdef out dw8250_acpi_match if ACPI isn't set

dw8250_acpi_match is used only when ACPI is enabled. Fix the following gcc warning when W=1 is set: drivers/tty/serial/8250/8250_dw.c:640:36: warning: 'dw8250_acpi_match' defined but not used [-Wunused-const-variable=] Signed-off-by: Jisheng Zhang <jszh...@marvell.com> --- drivers/tty/

[PATCH] serial: 8250_dw: #ifdef out dw8250_acpi_match if ACPI isn't set

dw8250_acpi_match is used only when ACPI is enabled. Fix the following gcc warning when W=1 is set: drivers/tty/serial/8250/8250_dw.c:640:36: warning: 'dw8250_acpi_match' defined but not used [-Wunused-const-variable=] Signed-off-by: Jisheng Zhang --- drivers/tty/serial/8250/8250_dw.c | 2

Re: [PATCH v2] PCI: designware: add host_init error handling

Hi Srinivas, On Wed, 7 Dec 2016 10:32:49 + Srinivas Kandagatla wrote: > This patch add support to return value from host_init() callback from drivers, > so that the designware libary can handle or pass it to proper place. Issue > with > void return type is that errors or error handling

Re: [PATCH v2] PCI: designware: add host_init error handling

Hi Srinivas, On Wed, 7 Dec 2016 10:32:49 + Srinivas Kandagatla wrote: > This patch add support to return value from host_init() callback from drivers, > so that the designware libary can handle or pass it to proper place. Issue > with > void return type is that errors or error handling

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

On Thu, 1 Dec 2016 20:02:05 +0800 Jisheng Zhang wrote: > Hi Marcin, > > On Thu, 1 Dec 2016 12:48:39 +0100 Marcin Wojtas wrote: > > > Hi Jisheng, > > > > Which baseline do you use? > > > > It took me really lot of time to catch why RX broke after rebas

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

On Thu, 1 Dec 2016 20:02:05 +0800 Jisheng Zhang wrote: > Hi Marcin, > > On Thu, 1 Dec 2016 12:48:39 +0100 Marcin Wojtas wrote: > > > Hi Jisheng, > > > > Which baseline do you use? > > > > It took me really lot of time to catch why RX broke after rebas

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

arm64. If that's implemented and merged, then we can revert this patch later. Thanks, Jisheng > > Best regards, > Marcin > > > > 2016-12-01 12:26 GMT+01:00 Jisheng Zhang <jszh...@marvell.com>: > > Hi Gregory, Marcin, > > > > On Wed, 30 Nov 2016 22

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

arm64. If that's implemented and merged, then we can revert this patch later. Thanks, Jisheng > > Best regards, > Marcin > > > > 2016-12-01 12:26 GMT+01:00 Jisheng Zhang : > > Hi Gregory, Marcin, > > > > On Wed, 30 Nov 2016 22:42:49 +0100 Gregory CLEMEN

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

On Thu, 1 Dec 2016 19:26:04 +0800 Jisheng Zhang <jszh...@marvell.com> wrote: > Hi Gregory, Marcin, > > On Wed, 30 Nov 2016 22:42:49 +0100 Gregory CLEMENT wrote: > > > From: Marcin Wojtas <m...@semihalf.com> > > > > Prepare the mvneta driver in

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

On Thu, 1 Dec 2016 19:26:04 +0800 Jisheng Zhang wrote: > Hi Gregory, Marcin, > > On Wed, 30 Nov 2016 22:42:49 +0100 Gregory CLEMENT wrote: > > > From: Marcin Wojtas > > > > Prepare the mvneta driver in order to be usable on the 64 bits platfo

Re: [PATCH v5 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address

ie > field, this also means that currently the hwbm is not usable in 64-bits. > > Signed-off-by: Gregory CLEMENT <gregory.clem...@free-electrons.com> Reviewed-by: Jisheng Zhang <jszh...@marvell.com> Thanks, Jisheng > --- > drivers/net/ethernet/marvell/mvneta.c |

Re: [PATCH v5 net-next 3/7] net: mvneta: Use cacheable memory to store the rx buffer virtual address

ie > field, this also means that currently the hwbm is not usable in 64-bits. > > Signed-off-by: Gregory CLEMENT Reviewed-by: Jisheng Zhang Thanks, Jisheng > --- > drivers/net/ethernet/marvell/mvneta.c | 34 +++- > 1 file changed, 24 insertions(+),

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

Hi Gregory, Marcin, On Wed, 30 Nov 2016 22:42:49 +0100 Gregory CLEMENT wrote: > From: Marcin Wojtas > > Prepare the mvneta driver in order to be usable on the 64 bits platform > such as the Armada 3700. > > [gregory.clem...@free-electrons.com]: this patch was extract from a

Re: [PATCH v5 net-next 4/7] net: mvneta: Convert to be 64 bits compatible

Hi Gregory, Marcin, On Wed, 30 Nov 2016 22:42:49 +0100 Gregory CLEMENT wrote: > From: Marcin Wojtas > > Prepare the mvneta driver in order to be usable on the 64 bits platform > such as the Armada 3700. > > [gregory.clem...@free-electrons.com]: this patch was extract from a larger > one to

Re: [PATCH net-next 0/5] Support Armada 37xx SoC (ARMv8 64-bits) in mvneta driver

Hi Gregory, On Fri, 25 Nov 2016 16:30:13 +0100 Gregory CLEMENT wrote: > Hi, > > The Armada 37xx is a new ARMv8 SoC from Marvell using same network > controller as the older Armada 370/38x/XP SoCs. This series adapts the > driver in order to be able to use it on this new SoC. The main changes >

Re: [PATCH net-next 0/5] Support Armada 37xx SoC (ARMv8 64-bits) in mvneta driver

Hi Gregory, On Fri, 25 Nov 2016 16:30:13 +0100 Gregory CLEMENT wrote: > Hi, > > The Armada 37xx is a new ARMv8 SoC from Marvell using same network > controller as the older Armada 370/38x/XP SoCs. This series adapts the > driver in order to be able to use it on this new SoC. The main changes >

Re: [PATCH net-next 1/5] net: mvneta: Use cacheable memory to store the rx buffer virtual address

Hi Gregory, On Fri, 25 Nov 2016 16:30:14 +0100 Gregory CLEMENT wrote: > Until now the virtual address of the received buffer were stored in the > cookie field of the rx descriptor. However, this field is 32-bits only > which prevents to use the driver on a 64-bits architecture. > > With this

Re: [PATCH net-next 1/5] net: mvneta: Use cacheable memory to store the rx buffer virtual address

Hi Gregory, On Fri, 25 Nov 2016 16:30:14 +0100 Gregory CLEMENT wrote: > Until now the virtual address of the received buffer were stored in the > cookie field of the rx descriptor. However, this field is 32-bits only > which prevents to use the driver on a 64-bits architecture. > > With this

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

On Thu, 24 Nov 2016 10:00:36 +0100 Arnd Bergmann <a...@arndb.de> wrote: > On Thursday, November 24, 2016 4:37:36 PM CET Jisheng Zhang wrote: > > solB (a SW shadow cookie) perhaps gives a better performance: in hot path, > > such as mvneta_rx(), the driver accesses buf_coo

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

On Thu, 24 Nov 2016 10:00:36 +0100 Arnd Bergmann wrote: > On Thursday, November 24, 2016 4:37:36 PM CET Jisheng Zhang wrote: > > solB (a SW shadow cookie) perhaps gives a better performance: in hot path, > > such as mvneta_rx(), the driver accesses buf_cookie and buf_phys_addr

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

d Bergmann wrote: > > > >> On Wednesday, November 23, 2016 5:53:41 PM CET Jisheng Zhang wrote: > >>> On Tue, 22 Nov 2016 22:04:12 +0100 Arnd Bergmann wrote: > >>> > >>> > On Tuesday, November 22, 201

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

d Bergmann wrote: > > > >> On Wednesday, November 23, 2016 5:53:41 PM CET Jisheng Zhang wrote: > >>> On Tue, 22 Nov 2016 22:04:12 +0100 Arnd Bergmann wrote: > >>> > >>> > On Tuesday, November 22, 201

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

Hi Arnd, On Wed, 23 Nov 2016 11:15:32 +0100 Arnd Bergmann wrote: > On Wednesday, November 23, 2016 5:53:41 PM CET Jisheng Zhang wrote: > > On Tue, 22 Nov 2016 22:04:12 +0100 Arnd Bergmann wrote: > > > > > On Tuesday, November 22, 2016 5:48:41 PM CET Gregory CLEMENT

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

Hi Arnd, On Wed, 23 Nov 2016 11:15:32 +0100 Arnd Bergmann wrote: > On Wednesday, November 23, 2016 5:53:41 PM CET Jisheng Zhang wrote: > > On Tue, 22 Nov 2016 22:04:12 +0100 Arnd Bergmann wrote: > > > > > On Tuesday, November 22, 2016 5:48:41 PM CET Gregory CLEMENT

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

On Tue, 22 Nov 2016 22:04:12 +0100 Arnd Bergmann wrote: > On Tuesday, November 22, 2016 5:48:41 PM CET Gregory CLEMENT wrote: > > +#ifdef CONFIG_64BIT > > + void *data_tmp; > > + > > + /* In Neta HW only 32 bits data is supported, so in order to > > +* obtain whole 64 bits

Re: [PATCH net-next 1/4] net: mvneta: Convert to be 64 bits compatible

On Tue, 22 Nov 2016 22:04:12 +0100 Arnd Bergmann wrote: > On Tuesday, November 22, 2016 5:48:41 PM CET Gregory CLEMENT wrote: > > +#ifdef CONFIG_64BIT > > + void *data_tmp; > > + > > + /* In Neta HW only 32 bits data is supported, so in order to > > +* obtain whole 64 bits

Re: [PATCH 03/16] ARM: berlin: use generic API for enabling SCU

Hi Pankaj, On Mon, 14 Nov 2016 10:31:58 +0530 Pankaj Dubey wrote: > Now as we have of_scu_enable which takes care of mapping > scu base from DT, lets use it. > > CC: Jisheng Zhang <jszh...@marvell.com> > CC: Sebastian Hesselbarth <sebastian.hesselba...@gmail.com> &g

Re: [PATCH 03/16] ARM: berlin: use generic API for enabling SCU

Hi Pankaj, On Mon, 14 Nov 2016 10:31:58 +0530 Pankaj Dubey wrote: > Now as we have of_scu_enable which takes care of mapping > scu base from DT, lets use it. > > CC: Jisheng Zhang > CC: Sebastian Hesselbarth > Signed-off-by: Pankaj Dubey > --- > arch/arm/ma

Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU

Hi Pankaj, On Mon, 14 Nov 2016 14:54:59 +0800 Jisheng Zhang wrote: > On Mon, 14 Nov 2016 14:12:51 +0800 Jisheng Zhang wrote: > > > Hi Pankaj, > > > > On Mon, 14 Nov 2016 10:31:56 +0530 Pankaj Dubey wrote: > > > > > Many platforms are duplicating code

Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU

Hi Pankaj, On Mon, 14 Nov 2016 14:54:59 +0800 Jisheng Zhang wrote: > On Mon, 14 Nov 2016 14:12:51 +0800 Jisheng Zhang wrote: > > > Hi Pankaj, > > > > On Mon, 14 Nov 2016 10:31:56 +0530 Pankaj Dubey wrote: > > > > > Many platforms are duplicating code

Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU

On Mon, 14 Nov 2016 14:12:51 +0800 Jisheng Zhang wrote: > Hi Pankaj, > > On Mon, 14 Nov 2016 10:31:56 +0530 Pankaj Dubey wrote: > > > Many platforms are duplicating code for enabling SCU, lets add > > common code to enable SCU by parsing SCU device node so the duplicat

<    4   5   6   7   8   9   10   11   12   13   >