On Fri, 2020-08-28 at 09:21 +1000, Finn Thain wrote:
> > @@ -109,34 +111,28 @@ static void get_z2ram(void)
> ...
> > }
> > -
> > - return;
> > }
> >
>
> It would be good to have a semantic patch for that change.
>
> >
> > - if (z2ram_map[z2ram_size] == 0) {
> > +
On Fri, 2020-08-28 at 01:38 +0300, Denis Efremov wrote:
> > This will match it (the difference is in the ';'):
thanks.
On Thu, 2020-08-27 at 15:20 -0700, Kees Cook wrote:
> On Fri, Aug 28, 2020 at 12:01:34AM +0300, Denis Efremov wrote:
> > Just FYI, I've send an addition to the device_attr_show.cocci script[1] to
> > turn
> > simple cases of snprintf (e.g. "%i") to sprintf. Looks like many developers
> > would
>
On Thu, 2020-08-27 at 22:03 +, David Laight wrote:
> From: Joe Perches
> > Sent: 27 August 2020 21:30
> ...
> > Perhaps what's necessary is to find any
> > appropriate .show function and change
> > any use of strcpy/sprintf within those
> > function to so
On Thu, 2020-08-27 at 23:36 +0200, Julia Lawall wrote:
> On Fri, 28 Aug 2020, Denis Efremov wrote:
[]
> Regarding current device_attr_show.cocci implementation, it detects the
> functions
> > by declaration:
> > ssize_t any_name(struct device *dev, struct device_attribute *attr, char
> > *buf)
>
On Thu, 2020-08-27 at 13:29 -0700, Joe Perches wrote:
> On Thu, 2020-08-27 at 21:42 +0200, Julia Lawall wrote:
> > On Thu, 27 Aug 2020, Joe Perches wrote:
> >
> > > On Thu, 2020-08-27 at 15:48 +0100, Alex Dewar wrote:
> > > > On Thu, Aug 27, 2020 at 03:4
On Thu, 2020-08-27 at 21:42 +0200, Julia Lawall wrote:
>
> On Thu, 27 Aug 2020, Joe Perches wrote:
>
> > On Thu, 2020-08-27 at 15:48 +0100, Alex Dewar wrote:
> > > On Thu, Aug 27, 2020 at 03:41:06PM +0200, Rasmus Villemoes wrote:
> > > > On 27/08/2020 15.18
On Thu, 2020-08-27 at 11:30 -0700, Kees Cook wrote:
> Most of the uses of strcpy() in the kernel are just copying between two
> known-at-compile-time NUL-terminated character arrays. We had wanted to
> introduce stracpy() for this, but Linus objected to yet more string
> functions.
On Thu, 2020-08-27 at 15:48 +0100, Alex Dewar wrote:
> On Thu, Aug 27, 2020 at 03:41:06PM +0200, Rasmus Villemoes wrote:
> > On 27/08/2020 15.18, Alex Dewar wrote:
> > > On Thu, Aug 27, 2020 at 09:15:37AM +0200, Greg Kroah-Hartman wrote:
> > > > On Thu, Aug 27, 2020 at 08:42:06AM +0200, Rasmus
On Thu, 2020-08-27 at 16:01 +, Konstantin Komarov wrote:
> From: Randy Dunlap
> Sent: Friday, August 21, 2020 8:23 PM
[]
> > > +- Full journaling support (currently journal replaying is supported)
> > > over JBD.
> >
> > journalling
> > seems to be preferred.
> >
> Have to
On Thu, 2020-08-27 at 07:58 -0700, Kees Cook wrote:
> On Wed, Aug 26, 2020 at 08:12:01PM -0700, Joe Perches wrote:
> > It's now gone from the kernel so remove it from the deprecated API text.
> >
> > Signed-off-by: Joe Perches
>
> Oh! Right, thank you. I forgot to rew
On Thu, 2020-08-27 at 18:28 +0300, Denis Efremov wrote:
> > @@ -1013,10 +1013,7 @@ static struct udf_bitmap *udf_sb_alloc_bitmap(struct
> > super_block *sb, u32 index)
> > size = sizeof(struct udf_bitmap) +
> > (sizeof(struct buffer_head *) * nr_groups);
>
> I missed that this
On Thu, 2020-08-27 at 12:27 +0300, Kalle Valo wrote:
> Larry Finger writes:
> > On 7/27/20 9:52 AM, Joe Perches wrote:
> > > On Mon, 2020-07-27 at 09:04 +, Pkshih wrote:
> > > > So, I think you would like to have parenthesis intentionally.
> >
It's now gone from the kernel so remove it from the deprecated API text.
Signed-off-by: Joe Perches
---
Documentation/process/deprecated.rst | 18 --
1 file changed, 18 deletions(-)
diff --git a/Documentation/process/deprecated.rst
b/Documentation/process/deprecated.rst
index
On Wed, 2020-08-26 at 19:33 -0700, Kees Cook wrote:
> On Wed, Aug 26, 2020 at 04:57:41PM -0700, Joe Perches wrote:
> > On Wed, 2020-08-26 at 16:38 -0700, Kees Cook wrote:
> > > On Thu, Aug 27, 2020 at 07:59:45AM +0900, Masahiro Yamada wrote:
> > []
> > > > OK,
On Wed, 2020-08-26 at 16:38 -0700, Kees Cook wrote:
> On Thu, Aug 27, 2020 at 07:59:45AM +0900, Masahiro Yamada wrote:
[]
> > OK, then stpcpy(), strcpy() and sprintf()
> > have the same level of unsafety.
>
> Yes. And even snprintf() is dangerous because its return value is how
> much it WOULD
On Wed, 2020-08-26 at 15:32 -0400, Steven Rostedt wrote:
> On Tue, 25 Aug 2020 08:53:25 -0700
> Joe Perches wrote:
>
> > > The print buffer is statically allocated and managed using code borrowed
> > > from __ftrace_trace_stack() and is limited to 256 bytes (four of th
On Thu, 2020-08-27 at 01:49 +0900, Masahiro Yamada wrote:
> I do not have time to keep track of the discussion fully,
> but could you give me a little more context why
> the usage of stpcpy() is not recommended ?
>
> The implementation of strcpy() is almost the same.
> It is unclear to me what
On Wed, 2020-08-26 at 18:55 +0300, Andy Shevchenko wrote:
> On Wed, Aug 26, 2020 at 08:44:30AM -0700, Joe Perches wrote:
> > On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote:
>
> ...
>
> > > -int dev_err_probe(const struct device *dev, int err, const char *f
On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote:
> We have got already new users of this API which interpret it differently
> and miss the opportunity to optimize their code.
>
> In order to avoid similar cases in the future, annotate dev_err_probe()
> with __must_check.
>
> Fixes:
On Wed, 2020-08-26 at 11:49 +0200, John Paul Adrian Glaubitz wrote:
> > On Aug 26, 2020, at 11:21 AM, Joe Perches wrote:
> >
> > On Wed, 2020-08-26 at 08:24 +0200, Christoph Hellwig wrote:
> > > reindent the driver using Lident as the code style was far away f
On Wed, 2020-08-26 at 11:30 +0200, Thomas Renninger wrote:
> Hi,
>
> getting rid of lines with multiple instructions, separated by comma is
> certainly a good idea.
> One nit pick, though:
>
> Am Dienstag, 25. August 2020, 06:56:26 CEST schrieb Joe Perches:
> >
On Wed, 2020-08-26 at 08:24 +0200, Christoph Hellwig wrote:
> reindent the driver using Lident as the code style was far away from
> normal Linux code.
Why? Does anyone use this anymore?
** z2ram - Amiga pseudo-driver to access 16bit-RAM in ZorroII space
** as a block device, to be
On Tue, 2020-08-25 at 12:01 -0500, Gustavo A. R. Silva wrote:
> On 8/25/20 11:47, Joe Perches wrote
[]
> You would have noticed this should be two patches.
That's interpretational.
> > I think your desire for micropatches is unnecessary.
> >
> You might be generaliz
On Tue, 2020-08-25 at 11:49 -0500, Gustavo A. R. Silva wrote:
>
> On 8/25/20 11:26, Joe Perches wrote:
> > On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote:
> > > On 8/25/20 10:51, Alex Dewar wrote:
> > > > Commit 36a8f01cd24b (&quo
On Tue, 2020-08-25 at 11:19 -0500, Gustavo A. R. Silva wrote:
>
> On 8/25/20 10:51, Alex Dewar wrote:
> > Commit 36a8f01cd24b ("IB/qib: Add congestion control agent implementation")
> > erroneously marked a couple of switch cases as /* FALLTHROUGH */, which
> > were later converted to fallthrough
On Tue, 2020-08-25 at 17:41 +0200, Christian Brauner wrote:
> Namespace maintainership has never been formalized which has led to confusion
> when people need to determine where to send patches and who should take a look
> at them. Especially, since we have a dedicated list
>
On Tue, 2020-08-25 at 19:36 +0800, Nicolas Boichat wrote:
> trace_printk is meant as a debugging tool, and should not be
> compiled into production code without specific debug Kconfig
> options enabled, or source code changes, as indicated by the
> warning that shows up on boot if any trace_printk
On Tue, 2020-08-25 at 17:33 +0200, Vincent Whitchurch wrote:
> When debugging device drivers, I've found it very useful to be able to
> redirect existing pr_debug()/dev_dbg() prints to the trace buffer
> instead of dmesg. Among the many advantages of the trace buffer is that
> it can be
On Tue, 2020-08-25 at 15:09 +0800, Nicolas Boichat wrote:
> trace_printk is meant as a debugging tool, and should not be
> compiled into production code without specific debug Kconfig
> options enabled, or source code changes, as indicated by the
> warning that shows up on boot if any trace_printk
On Tue, 2020-08-25 at 00:01 -0700, Joe Perches wrote:
> On Tue, 2020-08-25 at 14:38 +0800, Jing Xiangfeng wrote:
> > The variable ret is being initialized with 'FAILED'. So we can remove
> > this assignement.
>
> If you are going to change the code at all,
> might as wel
On Tue, 2020-08-25 at 14:38 +0800, Jing Xiangfeng wrote:
> The variable ret is being initialized with 'FAILED'. So we can remove
> this assignement.
If you are going to change the code at all,
might as well try to improve it more by removing
the unnecessary out: label altogether.
Perhaps:
---
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/block/drbd/drbd_receiver.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/block/drbd/drbd_receiver.c
b/drivers/block/drbd/drbd_receiver.c
index 422363daa618..87f732fb5456 100644
--- a/drivers
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/md/bcache/bset.c | 12
drivers/md/bcache/sysfs.c | 6 --
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
index 67a2c47f4201..94d38e8a59b3
Use semicolons and braces.
Signed-off-by: Joe Perches
---
arch/sparc/kernel/smp_64.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/sparc/kernel/smp_64.c b/arch/sparc/kernel/smp_64.c
index e286e2badc8a..28c11f7871cd 100644
--- a/arch/sparc/kernel/smp_64.c
+++ b
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/gpu/drm/gma500/mdfld_intel_display.c | 44 +---
1 file changed, 28 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/gma500/mdfld_intel_display.c
b/drivers/gpu/drm/gma500/mdfld_intel_display.c
index
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/ata/pata_icside.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c
index 08543aeb0093..498383cb6e29 100644
--- a/drivers/ata
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/dma-buf/st-dma-fence.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/dma-buf/st-dma-fence.c b/drivers/dma-buf/st-dma-fence.c
index e593064341c8..c8a12d7ad71a 100644
--- a/drivers/dma-buf/st
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 8 +---
drivers/gpu/drm/i915/gt/intel_gt_requests.c| 6 --
drivers/gpu/drm/i915/gt/selftest_workarounds.c | 6 --
drivers/gpu/drm/i915/intel_runtime_pm.c| 6
Use semicolons and braces.
Signed-off-by: Joe Perches
---
net/sunrpc/sysctl.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c
index 999eee1ed61c..6c86e2a7d942 100644
--- a/net/sunrpc/sysctl.c
+++ b/net/sunrpc/sysctl.c
@@ -108,8
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/media/i2c/msp3400-kthreads.c | 12
drivers/media/pci/bt8xx/bttv-cards.c | 6 --
drivers/media/pci/saa7134/saa7134-video.c | 7 +--
3 files changed, 17 insertions(+), 8 deletions(-)
diff --git
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/8390/axnet_cs.c | 19 ---
drivers/net/ethernet/8390/lib8390.c | 14 +-
drivers/net/ethernet/8390/pcnet_cs.c | 6 --
3 files changed, 25 insertions(+), 14 deletions(-)
diff --git
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/s390/char/tty3270.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty3270.c
index aec996de44d9..6acce975df26 100644
--- a/drivers/s390/char/tty3270.c
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/staging/media/atomisp/pci/atomisp_subdev.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_subdev.c
b/drivers/staging/media/atomisp/pci/atomisp_subdev.c
index
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/mtd/devices/lart.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/devices/lart.c b/drivers/mtd/devices/lart.c
index 56f50d27b7fd..aecd441e4183 100644
--- a/drivers/mtd/devices/lart.c
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/net/wan/sbni.c | 101 +++--
1 file changed, 58 insertions(+), 43 deletions(-)
diff --git a/drivers/net/wan/sbni.c b/drivers/net/wan/sbni.c
index 40c04ea1200a..2fde439543fb 100644
--- a/drivers
Use semicolons and braces.
Signed-off-by: Joe Perches
---
lib/zlib_deflate/deftree.c | 49 +++---
1 file changed, 35 insertions(+), 14 deletions(-)
diff --git a/lib/zlib_deflate/deftree.c b/lib/zlib_deflate/deftree.c
index a4a34da512fe..e358053bdb15 100644
Use semicolons and braces.
Signed-off-by: Joe Perches
---
tools/lib/subcmd/help.c| 10 +-
tools/power/cpupower/utils/cpufreq-set.c | 14 +-
tools/testing/selftests/vm/gup_benchmark.c | 18 +-
tools/testing/selftests/vm/userfaultfd.c | 296 +
4
Use semicolons and braces.
Signed-off-by: Joe Perches
---
net/ipv6/ip6_fib.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index 25a90f3f705c..44d68ed70f24 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c
b/drivers/net/ethernet/freescale/fs_enet/fs_enet
Use semicolons and braces.
Signed-off-by: Joe Perches
---
arch/ia64/kernel/smpboot.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/ia64/kernel/smpboot.c b/arch/ia64/kernel/smpboot.c
index c29c600d7967..3311b9d21319 100644
--- a/arch/ia64/kernel/smpboot.c
+++ b
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/input/input-mt.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c
index f699538bdac4..44fe6f2f063c 100644
--- a/drivers/input/input-mt.c
+++ b
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/char/lp.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/lp.c b/drivers/char/lp.c
index 45932f05fd67..0ec73917d8dd 100644
--- a/drivers/char/lp.c
+++ b/drivers/char/lp.c
@@ -853,8 +853,10
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/video/fbdev/tgafb.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/tgafb.c b/drivers/video/fbdev/tgafb.c
index e9869135d833..666fbe2f671c 100644
--- a/drivers/video/fbdev
Use semicolons and braces.
Signed-off-by: Joe Perches
---
fs/fuse/dir.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index 26f028bc760b..ecb6eed832a0 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -1362,14
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/scsi/arm/cumana_2.c | 19 +++
drivers/scsi/arm/eesox.c| 9 +
drivers/scsi/arm/powertec.c | 9 +
3 files changed, 21 insertions(+), 16 deletions(-)
diff --git a/drivers/scsi/arm/cumana_2.c b
Use semicolons and braces.
Signed-off-by: Joe Perches
---
drivers/hwmon/scmi-hwmon.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/scmi-hwmon.c b/drivers/hwmon/scmi-hwmon.c
index d421e691318b..09ce30cba54b 100644
--- a/drivers/hwmon/scmi-hwmon.c
+++ b
Use semicolons and braces.
Signed-off-by: Joe Perches
---
fs/reiserfs/fix_node.c | 36
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/fs/reiserfs/fix_node.c b/fs/reiserfs/fix_node.c
index fefe87e1c099..aea63e67a42b 100644
--- a/fs/reiserfs
Use semicolons and braces.
Signed-off-by: Joe Perches
---
lib/zstd/compress.c | 120 ++--
lib/zstd/fse_compress.c | 24 +---
lib/zstd/huf_compress.c | 6 +-
3 files changed, 100 insertions(+), 50 deletions(-)
diff --git a/lib/zstd/compress.c b/lib
are changes for
another day.
Joe Perches (29):
coding-style.rst: Avoid comma statements
alpha: Avoid comma separated statements
ia64: Avoid comma separated statements
sparc: Avoid comma separated statements
ata: Avoid comma separated statements
drbd: Avoid comma separated statements
lp
Use semicolons and braces.
Signed-off-by: Joe Perches
---
arch/alpha/kernel/pci_iommu.c | 8 +---
arch/alpha/oprofile/op_model_ev4.c | 22 ++
arch/alpha/oprofile/op_model_ev5.c | 8 +---
3 files changed, 24 insertions(+), 14 deletions(-)
diff --git a/arch
Commas are not how statements are terminated.
Always use semicolons and braces if necessary.
Signed-off-by: Joe Perches
---
Documentation/process/coding-style.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/Documentation/process/coding-style.rst
b/Documentation
-by: Joe Perches
---
scripts/checkpatch.pl | 14 ++
1 file changed, 14 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 79fc357b18cd..cdee7cfadc11 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -976,6 +976,16 @@ sub seed_camelcase_includes
It's somewhat common for me to ask get_maintainer
to tell me who
maintains a patch file rather than
the files modified by the patch.
Emit a warning if using get_maintainer.pl -f
Signed-off-by: Joe Perches
---
scripts/get_maintainer.pl | 3 +++
1 file changed, 3 insertions(+)
diff --git
On Mon, 2020-08-24 at 21:01 +0100, Malcolm Priestley wrote:
> Good catch the interrupt URB is not running because usb_submit_urb is tangled
> with it.
>
> It only really affects signal strength.
>
> add
>
> Fixes: 15e1ce33182d ("[media] lmedm04: Fix usb_submit_urb BOGUS urb xfer,
> pipe 1 !=
On Mon, 2020-08-24 at 12:18 -0700, Andrew Morton wrote:
> On Mon, 24 Aug 2020 07:53:54 -0400 Miaohe Lin wrote:
>
> > Add else to split mutually exclusive case and avoid some unnecessary check.
> >
> > --- a/mm/mempool.c
> > +++ b/mm/mempool.c
> > @@ -60,9 +60,8 @@ static void
On Mon, 2020-08-24 at 12:54 -0600, Jim Cromie wrote:
> commit 59cf47e7df31 dyndbg: export ddebug_exec_queries
> left a few configs broken, fix them with ifdef-stubs.
>
> Rename the export to dynamic_debug_exec_queries(). This is a more
> canonical function name, instead of exposing the 'ddebug'
On Mon, 2020-08-24 at 11:46 -0700, Linus Torvalds wrote:
> I think I'd have preferred to get this as a couple of scripts that do
> the obvious 1:1 direct conversion of the simple cases that cover 90%
> of it all, so then the manual fixups separately.
I created a script and sent it directly to you
On Mon, 2020-08-24 at 00:00 +0200, Rikard Falkeborn wrote:
> This series constifies all static phy_ops structs in drivers/phy.
> Typically the only usage is to pass the address of it to devm_phy_create()
> which takes a const pointer. The lone exception is in
>
There's a comma used instead of a semicolon that causes multiple
statements to be executed after an if instead of just the intended
single statement.
Replace the comma with a semicolon.
Signed-off-by: Joe Perches
---
Untested, but really likely to be a defect given the indentation.
Found
On Sun, 2020-08-23 at 16:21 +0100, Matthew Wilcox wrote:
> On Wed, Aug 19, 2020 at 10:14:11AM +0200, Giuseppe Scrivano wrote:
> > > > - cft->file_offset = offsetof(struct hugetlb_cgroup,
> > > > events_file[idx]),
> > > > + cft->file_offset = offsetof(struct hugetlb_cgroup,
> > > >
On Sat, 2020-08-22 at 14:07 -0700, David Miller wrote:
> From: Joe Perches
> Date: Sat, 22 Aug 2020 14:03:31 -0700
>
> > The compiler didn't inline the code without it.
>
> Then the compiler had a good reason for doing so,
The "good" word choice there is sligh
On Sat, 2020-08-22 at 13:59 -0700, David Miller wrote:
> From: Joe Perches
> Date: Sat, 22 Aug 2020 13:39:28 -0700
>
> > It _might_ be slightly faster to use inlines
>
> We are not using the inline directive in foo.c files and are letting
> the compiler decide.
>
>
On Sat, 2020-08-22 at 12:33 -0700, David Miller wrote:
> From: Jianlin Lv
> Date: Sat, 22 Aug 2020 10:04:31 +0800
>
> > It is not necessary to use src/dst as an intermediate variable for
> > assignment operation; Delete src/dst intermediate variables to avoid
> > unnecessary variable
On Thu, 2020-08-20 at 17:02 -0500, Gustavo A. R. Silva wrote:
> This treewide patch doesn't address ALL fall-through markings in all
> subsystems at once because I have previously sent out patches for some of
> such subsystems separately, and I will follow up on them; however, this
> definitely
On Fri, 2020-08-21 at 23:35 -0400, Valdis Klētnieks wrote:
> On Fri, 21 Aug 2020 18:08:08 -0700, Joe Perches said:
> > (forwarding on to kernel-janitors/mentees and kernelnewbies)
> >
> > Just fyi for anyone that cares:
> >
> > A janitorial task for someone m
(forwarding on to kernel-janitors/mentees and kernelnewbies)
Just fyi for anyone that cares:
A janitorial task for someone might be to use Julia's coccinelle
script below to convert the existing instances of commas that
separate statements into semicolons.
On Fri, 2020-08-21 at 16:13 -0700, Randy Dunlap wrote:
> On 8/21/20 3:50 PM, Nathan Chancellor wrote:
> > Clang warns several times when building for 32-bit ARM along the lines
> > of:
The defines are quite horrible to read.
Maybe:
---
drivers/vdpa/mlx5/net/mlx5_vnet.c | 61
Rename the ntfs_warning and ntfs_error macros to the more common style of
ntfs_warn and ntfs_err. _inode_ variants too.
Miscellanea:
o Realign arguments
o Fix a typo
Signed-off-by: Joe Perches
---
fs/ntfs3/debug.h | 8 +++
fs/ntfs3/dir.c | 22 +--
fs/ntfs3/file.c
Use the normal name.
Miscellanea:
o Reorder the macro logging definitions in KERN_ order
Signed-off-by: Joe Perches
---
fs/ntfs3/debug.h | 4 ++--
fs/ntfs3/fsntfs.c | 16 +++-
fs/ntfs3/index.c | 4 ++--
fs/ntfs3/super.c | 13 ++---
4 files changed, 17 insertions
Convert the ntfs__trace function names to _printk.
Miscellanea:
o Change the macros that use these functions
o Use the more common ..., ##__VA_ARGS__ style
Signed-off-by: Joe Perches
---
fs/ntfs3/debug.h | 30 +-
fs/ntfs3/ntfs_fs.h | 4 ++--
fs/ntfs3/super.c
Use the more typical kernel logging styles.
These changes also trivially reduce overall object size.
btw: ntfs_fs_error/__ntfs_fs_error were and are left unused
Joe Perches (3):
ntfs3: Use more common logging function names and style
ntfs3: Rename logging macros and uses
ntfs3: Rename
On Wed, 2020-08-19 at 13:45 +0200, Mauro Carvalho Chehab wrote:
> From: Xiubin Zhang
>
> Add some debug prints on adv7535 and kirin_drm_drv.
bikeshed:
> diff --git a/drivers/staging/hikey9xx/gpu/hdmi/adv7535.c
> b/drivers/staging/hikey9xx/gpu/hdmi/adv7535.c
[]
> @@ -785,19 +786,25 @@
On Fri, 2020-08-21 at 16:25 +, Konstantin Komarov wrote:
> Initialization of super block for fs/ntfs3
[]
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
[]
> +
> +/**
> + * ntfs_trace() - print preformated ntfs specific messages.
> + */
> +void __ntfs_trace(const struct super_block *sb,
On Fri, 2020-08-21 at 16:24 +, Konstantin Komarov wrote:
> This patch adds NTFS Read-Write driver to fs/ntfs3.
Thanks.
Proper ntfs read/write support will be great addition.
Trivia:
If this patchset is submitted again with a new version,
please use something like "git format-patch
On Fri, 2020-08-21 at 12:17 -0600, Rob Herring wrote:
> I have another reason for wanting the split. I want to generate a
> MAINTAINERS file from the DT schema files. We have the data there and
> it's checked automatically. I don't care to either continually tell
> folks to add a MAINTAINERS entry
MAINTAINERS files generally have no specific maintainer but are updated
by individuals for subsystems all over the source tree.
Exclude MAINTAINERS file(s) from --git-fallback searches so the unlucky
individuals that update the files the most are not shown by default.
Signed-off-by: Joe Perches
MAINTAINERS files generally have no specific maintainer but are updated
by individuals for subsystems all over the source tree.
Exclude MAINTAINERS file(s) from --git-fallback and --git-blame searches
so the unlucky individuals that update the files the most are not shown.
Signed-off-by: Joe
On Fri, 2020-08-21 at 10:45 -0600, Rob Herring wrote:
> +Joe Perches
>
> On Fri, Aug 21, 2020 at 9:48 AM Steve Wahl wrote:
> >
> > Signed-off-by: Steve Wahl
>
> get_maintainers.pl doesn't work on MAINTAINERS. You need to send this
> to the maintainers of the f
On Wed, 2020-08-19 at 22:48 +0200, Sam Ravnborg wrote:
> And sometimes checkpatch is just wrong.
I'm interested in examples for when checkpatch is "just wrong".
On Thu, 2020-08-20 at 10:22 +0530, Mrinal Pandey wrote:
> On 20/07/30 12:31AM, Joe Perches wrote:
> > On Thu, 2020-07-30 at 07:58 +0200, Lukas Bulwahn wrote:
> > > Hi Joe,
> > >
> > > did you see this quick fix to checkpatch.pl? Can you comment on the
>
On Fri, 2020-08-21 at 10:42 +0800, Nicolas Boichat wrote:
> On Fri, Aug 21, 2020 at 10:36 AM Joe Perches wrote:
> > On Thu, 2020-08-20 at 21:57 -0400, Steven Rostedt wrote:
> > > On Fri, 21 Aug 2020 09:39:19 +0800
> > > Nicolas Boichat wrote:
> > []
&g
those with a semi-canned answer,
> > if I remember to check that filter regularly (not sustainable in the
> > long run...).
>
> Added Joe Perches to the thread.
>
> We can update checkpatch.pl to complain about a trace_printk() that it
> finds in the added code.
Why?
On Fri, 2020-08-21 at 00:17 +0206, John Ogness wrote:
> On 2020-08-20, Joe Perches wrote:
> > And here it seems like the 'for (j =...)' loop is superfluous.
>
> AFAICT it is skipping duplicate entries. In the case of a duplicate,
> only the first one is printed.
Ah, right. thanks.
On Thu, 2020-08-20 at 19:05 +0100, Alex Dewar wrote:
> In a number of places, the value returned from pci_alloc_consistent() is
> unnecessarily cast from void*. Remove these casts.
[]
> diff --git a/drivers/message/fusion/mptbase.c
> b/drivers/message/fusion/mptbase.c
[]
> @@ -4975,7 +4975,7 @@
On Wed, 2020-08-19 at 18:03 -0700, Linus Torvalds wrote:
> On Wed, Aug 19, 2020 at 4:26 PM John Ogness wrote:
> > Use the new pr_cont_t mechanism.
>
> This looks actively much worse than the old code.
Isn't this just a generic mechanism to simplify
the accumulation of
logging message chunks?
On Thu, 2020-08-20 at 19:03 +0200, Julia Lawall wrote:
> > > I have a bunch of variations of this that are more complicated than I
> > > would have expected. One shorter variant that I have is:
> > >
> > > @@
> > > expression e1,e2;
> > > statement S;
> > > @@
> > >
> > > S
> > > e1
> > > -,
On Thu, 2020-08-20 at 10:33 +0200, Julia Lawall wrote:
> On Wed, 19 Aug 2020, Joe Perches wrote:
> > On Wed, 2020-08-19 at 14:22 -0700, Joe Perches wrote:
> > > There are commas used as statement terminations that should typically
> > > have used semicolons instead. Onl
On Thu, 2020-08-20 at 07:44 +, David Laight wrote:
> From: Joe Perches
> > Sent: 20 August 2020 01:34
> >
> > On Thu, 2020-08-20 at 01:32 +0206, John Ogness wrote:
> > > Implement a new buffering mechanism for pr_cont messages.
> > >
> > &g
On Thu, 2020-08-20 at 07:44 +, David Laight wrote:
> I've no idea how you'd 'size' the number of buffers.
I believe they are static and assume no more than 10
simultaneous uses of
printk_begin
+#define CONT_LINE_MAX LOG_LINE_MAX
+#define CONT_BUF_COUNT 10
+static char
901 - 1000 of 18599 matches
Mail list logo
