Re: [PATCH] staging: rtl8192u/ieee80211: Fix sparse ieee80211_debug_init/_exit not declared warning

2014-08-11 Thread Joel Pelaez Jorge
ed. Should it be static? >> >> These functions are used outside of this file so using static will not >> work. Fix the warning by declaring the functions in the header file, >> ieee80211.h >> >> Signed-off-by: Jeremiah Mahler >> Cc: Greg Kroah-Hartman >&g

[PATCH] Staging: rtl8192u: Remove old WIRELESS_EXT support

2014-05-23 Thread Joel Pelaez Jorge
Remove support for building against ancient WIRELESS_EXT versions, only leaving support for the current version: 22 Signed-off-by: Joel Pelaez Jorge --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 14 - drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 5 + drivers

[PATCH] Staging: rtl8192u: Remove old WIRELESS_EXT support

2014-05-17 Thread Joel Pelaez Jorge
Remove support for building against ancient WIRELESS_EXT versions, only leaving support for the current version: 22 Signed-off-by: Joel Pelaez Jorge --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 14 - drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 5 +-- drivers/staging

[PATCH] Staging: rtl8192u: Remove old WIRELESS_EXT support

2014-05-14 Thread Joel Pelaez Jorge
Remove support for building against ancient WIRELESS_EXT versions, only leaving support for the current version: 22 --- drivers/staging/rtl8192u/ieee80211/ieee80211.h| 14 - drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 5 +-- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c |

[PATCH] Staging: rtl8192e: Fix declaration of symbols

2014-04-19 Thread Joel Pelaez Jorge
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: symbol 'r8192_wx_handlers_def' was not declared. Should it be static? Resolved incluing the fixed header to rtl_wx.c Also, isn't declared as constant variable, so it declared as such. And delete unnecessary cast in rtl_core.c

[PATCH v3] Staging: rtl8192e: Fix declaration of symbols

2014-04-06 Thread Joel Pelaez Jorge
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: symbol 'r8192_wx_handlers_def' was not declared. Should it be static? Resolved incluing the fixed header to rtl_wx.c Also, isn't declared as constant variable, so it declared as such. And delete unnecessary cast in rtl_core.c

[PATCH 2/2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
symbol 'r8192_wx_handlers_def' was not declared. Should it be static? Signed-off-by: Joel Pelaez Jorge --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_

[PATCH 1/2] Staging: rtl8192e: Remove bad 'extern' declaration

2014-04-06 Thread Joel Pelaez Jorge
Remove extern declaration to a static function: iw_statistics *r8192_get_wireless_stats(struct net_device *dev); Signed-off-by: Joel Pelaez Jorge --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.h b

[PATCH 0/3] Staging: rtl8192e: Fix code issues

2014-04-06 Thread Joel Pelaez Jorge
In the kernel driver: rtl8192e, exists some problems related to source check, using the tool sparse, but for fix it, is necessary remove a bad declaration that keep off the patch. Because it is resolved before apply the "main" patch. Joel Pelaez Jorge (2): Staging: rtl8192e: Remove b

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
El 06/04/14 15:26, Greg Kroah-Hartman escribió: > On Sun, Apr 06, 2014 at 02:12:44PM -0500, Joel Pelaez Jorge wrote: >> El 06/04/14 14:01, Greg Kroah-Hartman escribió: >>> On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote: >>>> Fix a sparse warning, no

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
El 06/04/14 14:01, Greg Kroah-Hartman escribió: On Sun, Apr 06, 2014 at 01:43:38PM -0500, Joel Pelaez Jorge wrote: Fix a sparse warning, non static symbol is no declared as such. And fix a conflict with static function declared extern to include rtl_wx.h header. drivers/staging/rtl8192e

Re: [PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
El 06/04/14 13:49, Joe Perches escribió: On Sun, 2014-04-06 at 13:43 -0500, Joel Pelaez Jorge wrote: Fix a sparse warning, non static symbol is no declared as such. And fix a conflict with static function declared extern to include rtl_wx.h header. drivers/staging/rtl8192e/rtl8192e/rtl_wx.c

[PATCH v2] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
ned-off-by: Joel Pelaez Jorge --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c index 498995d..f17584d 100644 --- a/drivers/staging/rtl8192

[PATCH] Staging: rtl8192e: Fix sparse warning

2014-04-06 Thread Joel Pelaez Jorge
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c:1323:24: warning: symbol 'r8192_wx_handlers_def' was not declared. Should it be static Signed-off-by: Joel Pelaez Jorge --- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/stagin

Re: [PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-18 Thread Joel Pelaez Jorge
El 17/03/14 23:49, Jingoo Han escribió: On Tuesday, March 18, 2014 2:04 PM, Joel Pelaez Jorge wrote: @@ -810,8 +810,8 @@ static int slic_mac_set_address(struct net_device *dev, void *ptr) if (!is_valid_ether_addr(addr->sa_data)) return -EINVAL; - memcpy(

[PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-17 Thread Joel Pelaez Jorge
This patch fixes the following checkpatch.pl issues caused by the new function: ether_addr_copy Signed-off-by: Joel Pelaez Jorge --- drivers/staging/slicoss/slicoss.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/slicoss/slicoss.c

[PATCH] staging: slicoss: Fix prefer ether_addr_copy over memcpy

2014-03-17 Thread Joel Pelaez Jorge
This patch fixes the following checkpatch.pl issues caused by the new function: ether_addr_copy Signed-off-by: Joel Pelaez Jorge --- diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index 12aafe3..4ff39aa 100644 --- a/drivers/staging/slicoss/slicoss.c +++ b