Re: [PATCH 4.14 v2 ] platform/x86: Corrects warning: missing braces around initializer

2020-10-30 Thread John Donnelly
> On Oct 30, 2020, at 11:52 AM, Andy Shevchenko > wrote: > > On Fri, Oct 30, 2020 at 08:55:01AM -0700, john.p.donne...@oracle.com wrote: >> From: John Donnelly >> >> The assignment statement of a local variable "struct tp_nvram_state s[2] = >>

Re: [PATCH 4.14 ] platform/x86: Corrects warning: missing braces around initializer

2020-10-30 Thread John Donnelly
> On Oct 30, 2020, at 10:52 AM, john.p.donne...@oracle.com wrote: > > From: John Donnelly > > The assignment statement of a local variable "struct tp_nvram_state s[2] = > {0}; " > is not valid for all versions of compilers (UEK6 on OL7). > &g

Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized

2020-10-02 Thread John Donnelly
> On Oct 2, 2020, at 1:01 PM, Mike Christie wrote: > > On 9/23/20 7:19 PM, john.p.donne...@oracle.com wrote: >> From: John Donnelly >> >> corrects: drivers/target/target_core_user.c:688:6: warning: 'page' may be >> used >> uninitialize

Re: [PATCH v12 0/9] support reserving crashkernel above 4G on arm64 kdump

2020-09-23 Thread John Donnelly
> On Sep 15, 2020, at 2:16 AM, chenzhou wrote: > > > > On 2020/9/7 21:47, Chen Zhou wrote: >> There are following issues in arm64 kdump: >> 1. We use crashkernel=X to reserve crashkernel below 4G, which >> will fail when there is no enough low memory. >> 2. If reserving crashkernel above 4G,

Re: [PATCH v12 0/9] support reserving crashkernel above 4G on arm64 kdump

2020-09-12 Thread John Donnelly
h_core.h| 4 + include/linux/kexec.h | 2 - kernel/crash_core.c | 192 ++ kernel/kexec_core.c | 17 -- 13 files changed, 328 insertions(+), 256 deletions(-) I did a brief unit-test on 5.9-rc4. Please add: Tested-by: John Donnelly This activity is over a year old. It needs accepted.

Re: [PATCH v4: {linux-4.14.y} ] dm cache: submit writethrough writes in parallel to origin and cache

2020-08-04 Thread John Donnelly
ked from commit 2df3bae9a6543e90042291707b8db0cbfbae9ee9) > > Fixes: 4ec34f2196d125ff781170ddc6c3058c08ec5e73 (dm bio record: > save/restore bi_end_io and bi_integrity ) > > 4ec34f21 introduced a mkfs.ext4 hang on a LVM device that has been > modified with lvconvert --cachemode=writethrough. >

[(resend) PATCH v3: {linux-4.14.y} ] dm cache: submit writethrough writes in parallel to origin and cache

2020-08-04 Thread John Donnelly
.ext4 hang on a LVM device that has been modified with lvconvert --cachemode=writethrough. CC:sta...@vger.kernel.org for 4.14.y Signed-off-by: John Donnelly Reviewed-by: Somasundaram Krishnasamy conflicts: drivers/md/dm-cache-target.c. - Corrected usage of writethrough_mode(&

[PATCH v3: {linux-4.14.y} ] dm cache: submit writethrough writes in parallel to origin and cache

2020-08-03 Thread John Donnelly
.ext4 hang on a LVM device that has been modified with lvconvert --cachemode=writethrough. CC:sta...@vger.kernel.org for 4.14.y Signed-off-by: John Donnelly Reviewed-by: Somasundaram Krishnasamy conflicts: drivers/md/dm-cache-target.c. - Corrected usage of writethrough_mode(&

Re: [PATCH v2: [linux-4.14.y] ] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-31 Thread John Donnelly
On 7/31/20 1:54 AM, Greg KH wrote: On Thu, Jul 30, 2020 at 03:33:42PM -0500, John Donnelly wrote: From: Mike Snitzer Discontinue issuing writethrough write IO in series to the origin and then cache. Use bio_clone_fast() to create a new origin clone bio that will be mapped to the origin

[PATCH v2: [linux-4.14.y] ] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-30 Thread John Donnelly
.ext4 hang on a LVM device that has been modified with lvconvert --cachemode=writethrough. CC:sta...@vger.kernel.org for 4.14.x . Signed-off-by: John Donnelly Reviewed-by: Somasundaram Krishnasamy conflicts: drivers/md/dm-cache-target.c. - Corrected usage of writethrough_mode(&

Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-30 Thread John Donnelly
> On Jul 30, 2020, at 12:21 AM, Greg KH wrote: > > On Wed, Jul 29, 2020 at 06:45:46PM -0500, John Donnelly wrote: >> >> >> On 7/29/20 9:16 AM, Mike Snitzer wrote: >>> On Wed, Jul 29 2020 at 7:55am -0400, >>> Greg KH wrote: >>> >&g

Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-29 Thread John Donnelly
eg et al: please backport 2df3bae9a6543e90042291707b8db0cbfbae9ee9 Now backported, thanks. Nope, it broke the build, I need something that actually works :) OK, I'll defer to John Donnelly to get back with you (and rest of stable@). He is more invested due to SUSE also having this issue.

Re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-27 Thread John Donnelly
> On Jul 27, 2020, at 3:17 PM, Sasha Levin wrote: > > On Mon, Jul 27, 2020 at 02:38:52PM -0500, John Donnelly wrote: >> >> >>> On Jul 27, 2020, at 2:18 PM, Sasha Levin wrote: >>> >>> On Mon, Jul 27, 2020 at 11:00:14AM -0400, Mike Snitze

re: (resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-27 Thread John Donnelly
> On Jul 27, 2020, at 2:18 PM, Sasha Levin wrote: > > On Mon, Jul 27, 2020 at 11:00:14AM -0400, Mike Snitzer wrote: >> This mail needs to be saent to sta...@vger.kernel.org (now cc'd). >> >> Greg et al: please backport 2df3bae9a6543e90042291707b8db0cbfbae9ee9 > > Hm, what's the issue that th

(resend) [PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-27 Thread John Donnelly
55970 introduced a mkfs.ext4 hang on a LVM device that has been modified with lvconvert --cachemode=writethrough. Signed-off-by: John Donnelly Tested-by: John Donnelly Reviewed-by: Somasundaram Krishnasamy conflict: drivers/md/dm-cache-target.c - Corrected syntax of writethrough_mode(&cache->f

Re: [PATCH v10 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-07-27 Thread John Donnelly
On 7/3/20 3:38 AM, chenzhou wrote: Hi Bhupesh, On 2020/7/3 15:26, Bhupesh Sharma wrote: Hi Chen, On Fri, Jul 3, 2020 at 9:24 AM Chen Zhou wrote: This patch series enable reserving crashkernel above 4G in arm64. There are following issues in arm64 kdump: 1. We use crashkernel=X to reserve

[PATCH [linux-4.14.y]] dm cache: submit writethrough writes in parallel to origin and cache

2020-07-15 Thread John Donnelly
55970 introduced a mkfs.ext4 hang on a LVM device that has been modified with lvconvert --cachemode=writethrough. Signed-off-by: John Donnelly Tested-by: John Donnelly Reviewed-by: Somasundaram Krishnasamy conflict: drivers/md/dm-cache-target.c - Corrected syntax of writethrough_mode(&cache->f

Re: [PATCH v9 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-29 Thread John Donnelly
Hi , > On Jun 28, 2020, at 3:34 AM, Chen Zhou wrote: > > This patch series enable reserving crashkernel above 4G in arm64. > > There are following issues in arm64 kdump: > 1. We use crashkernel=X to reserve crashkernel below 4G, which will fail > when there is no enough low memory. > 2. Curren

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-19 Thread John Donnelly
On 6/19/20 3:21 AM, chenzhou wrote: On 2020/6/19 10:32, John Donnelly wrote: On 6/4/20 12:01 PM, Nicolas Saenz Julienne wrote: On Thu, 2020-06-04 at 01:17 +0530, Bhupesh Sharma wrote: Hi All, On Wed, Jun 3, 2020 at 9:03 PM John Donnelly wrote: On Jun 3, 2020, at 8:20 AM, chenzhou wrote

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-18 Thread John Donnelly
On 6/4/20 12:01 PM, Nicolas Saenz Julienne wrote: On Thu, 2020-06-04 at 01:17 +0530, Bhupesh Sharma wrote: Hi All, On Wed, Jun 3, 2020 at 9:03 PM John Donnelly wrote: On Jun 3, 2020, at 8:20 AM, chenzhou wrote: Hi, On 2020/6/3 19:47, Prabhakar Kushwaha wrote: Hi Chen, On Tue, Jun 2

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-04 Thread John Donnelly
On 6/4/20 12:01 PM, Nicolas Saenz Julienne wrote: On Thu, 2020-06-04 at 01:17 +0530, Bhupesh Sharma wrote: Hi All, On Wed, Jun 3, 2020 at 9:03 PM John Donnelly wrote: On Jun 3, 2020, at 8:20 AM, chenzhou wrote: Hi, On 2020/6/3 19:47, Prabhakar Kushwaha wrote: Hi Chen, On Tue, Jun 2

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-03 Thread John Donnelly
> On Jun 3, 2020, at 8:20 AM, chenzhou wrote: > > Hi, > > > On 2020/6/3 19:47, Prabhakar Kushwaha wrote: >> Hi Chen, >> >> On Tue, Jun 2, 2020 at 8:12 PM John Donnelly >> wrote: >>> >>> >>>> On Jun 2, 2020, at 12:3

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-02 Thread John Donnelly
> On Jun 2, 2020, at 12:38 AM, Prabhakar Kushwaha > wrote: > > On Tue, Jun 2, 2020 at 3:29 AM John Donnelly > wrote: >> >> Hi . See below ! >> >>> On Jun 1, 2020, at 4:02 PM, Bhupesh Sharma wrote: >>> >>> Hi John, >&

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-01 Thread John Donnelly
Hi . See below ! > On Jun 1, 2020, at 4:02 PM, Bhupesh Sharma wrote: > > Hi John, > > On Tue, Jun 2, 2020 at 1:01 AM John Donnelly > wrote: >> >> Hi, >> >> >> On 6/1/20 7:02 AM, Prabhakar Kushwaha wrote: >>> Hi Chen, >>>

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-01 Thread John Donnelly
Hi, On 6/1/20 7:02 AM, Prabhakar Kushwaha wrote: Hi Chen, On Thu, May 21, 2020 at 3:05 PM Chen Zhou wrote: This patch series enable reserving crashkernel above 4G in arm64. There are following issues in arm64 kdump: 1. We use crashkernel=X to reserve crashkernel below 4G, which will fail wh

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-05-28 Thread John Donnelly
On 5/25/20 8:42 PM, Baoquan He wrote: On 05/21/20 at 05:38pm, Chen Zhou wrote: This patch series enable reserving crashkernel above 4G in arm64. There are following issues in arm64 kdump: 1. We use crashkernel=X to reserve crashkernel below 4G, which will fail when there is no enough low memo

Re: [PATCH v7 0/4] support reserving crashkernel above 4G on arm64 kdump

2020-05-19 Thread John Donnelly
> On May 19, 2020, at 5:21 AM, Arnd Bergmann wrote: > > On Thu, Mar 26, 2020 at 4:10 AM Chen Zhou wrote: >> >> Hi all, >> >> Friendly ping... > > I was asked about this patch series, and see that you last posted it in > December. I think you should rebase it to linux-5.7-rc6 and post the >

[PATCH v3 ] iommu/vt-d: Fix panic after kexec -p for kdump

2019-10-21 Thread John Donnelly
.@vger.kernel.org # v5.3+ Signed-off-by: John Donnelly Reviewed-by: Lu Baolu --- drivers/iommu/intel-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c index c4e0e4a9ee9e..f83a9a302f8e 100644 --- a/drivers/iommu/

[PATCH v2 ] iommu/vt-d: Fix panic after kexec -p for kdump

2019-10-21 Thread John Donnelly
.655720] ehci_pci_init+0x6a/0x6c [ 43.655720] do_one_initcall+0x4a/0x1fa [ 43.655720] ? do_early_param+0x95/0x95 [ 43.655720] kernel_init_freeable+0x1bd/0x262 [ 43.655720] ? rest_init+0xb0/0xb0 [ 43.655720] kernel_init+0xe/0x110 [ 43.655720] ret_from_fork+0x24/0x50 Signed-off-b

[PATCH] iommu/vt-d: Fix panic after kexec -p for kdump

2019-10-18 Thread John Donnelly
? do_early_param+0x95/0x95 [ 43.655720] kernel_init_freeable+0x1bd/0x262 [ 43.655720] ? rest_init+0xb0/0xb0 [ 43.655720] kernel_init+0xe/0x110 [ 43.655720] ret_from_fork+0x24/0x50 Signed-off-by: John Donnelly --- drivers/iommu/intel-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 de