On Fri, 9 Oct 2020 02:46:09 +0300
Vladimir Oltean wrote:
> On Thu, Oct 08, 2020 at 05:27:49PM +0100, John Keeping wrote:
> > With threadirqs, stmmac_interrupt() is called on a thread with hardirqs
> > enabled so we cannot call __napi_schedule_irqoff(). Under lockdep
() instead which will save & restore the interrupt
state.
Fixes: 4ccb45857c2c ("net: stmmac: Fix NAPI poll in TX path when in
multi-queue")
Signed-off-by: John Keeping
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
Hi,
On Fri, 17 Jul 2020 18:00:02 +0200
Thomas Gleixner wrote:
> Setting interrupt affinity on inactive interrupts is inconsistent when
> hierarchical irq domains are enabled. The core code should just store the
> affinity and not call into the irq chip driver for inactive interrupts
> because th
Enable i2c transactions in irq disabled contexts like poweroff where the
PMIC is connected via i2c.
Signed-off-by: John Keeping
---
drivers/i2c/busses/i2c-rk3x.c | 39 +++
1 file changed, 35 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c
: John Keeping
---
drivers/input/touchscreen/st1232.c | 55 +-
1 file changed, 46 insertions(+), 9 deletions(-)
diff --git a/drivers/input/touchscreen/st1232.c
b/drivers/input/touchscreen/st1232.c
index 63b29c7279e2..4e032d3a3737 100644
--- a/drivers/input/touchscreen
Commit-ID: e2736219e6ca3117e10651e215b96d66775220da
Gitweb: https://git.kernel.org/tip/e2736219e6ca3117e10651e215b96d66775220da
Author: John Keeping
AuthorDate: Thu, 15 Aug 2019 11:01:46 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 16 Aug 2019 12:30:14 -0300
perf unwind
Commit-ID: e8ba2906f6b9054102ad035ac9cafad9d4168589
Gitweb: https://git.kernel.org/tip/e8ba2906f6b9054102ad035ac9cafad9d4168589
Author: John Keeping
AuthorDate: Thu, 15 Aug 2019 11:01:45 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 16 Aug 2019 12:25:57 -0300
perf unwind
Commit-ID: ab6cd0e5276e24403751e0b3b8ed807738a8571f
Gitweb: https://git.kernel.org/tip/ab6cd0e5276e24403751e0b3b8ed807738a8571f
Author: John Keeping
AuthorDate: Thu, 15 Aug 2019 11:01:44 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 16 Aug 2019 12:25:23 -0300
perf map
only for thread group leader")
Cc: Konstantin Khlebnikov
Signed-off-by: John Keeping
---
v2:
- Remove unrelated change that has moved to the next patch
- Improve commit message to describe a scenario that shows the bug
---
tools/perf/util/map.c| 3 ++-
tools/pe
If dwarf_callchain_users is false, then unwind__prepare_access() will
not set unwind_libunwind_ops so the remaining test here is sufficient.
Signed-off-by: John Keeping
---
v2: new patch split out from patch 2
---
tools/perf/util/unwind-libunwind.c | 6 --
1 file changed, 6 deletions
In the next commit we will add new fields to map_groups and we need
these to be null if no value is assigned. The simplest way to achieve
this is to request zeroed memory from the allocator.
Signed-off-by: John Keeping
---
Unchanged in v2
---
tools/perf/util/map.c | 2 +-
1 file changed, 1
On Fri, 2 Aug 2019 15:30:39 +0200
Jiri Olsa wrote:
> On Mon, Jul 29, 2019 at 06:24:30PM +0100, John Keeping wrote:
> > Commit e5adfc3e7e77 ("perf map: Synthesize maps only for thread group
> > leader") changed the recording side so that we no longer get mmap events
>
In the next commit we will add new fields to map_groups and we need
these to be null if no value is assigned. The simplest way to achieve
this is to request zeroed memory from the allocator.
Signed-off-by: John Keeping
---
tools/perf/util/map.c | 2 +-
1 file changed, 1 insertion(+), 1
nikov
Signed-off-by: John Keeping
---
tools/perf/util/map.c| 3 +-
tools/perf/util/map_groups.h | 4 +++
tools/perf/util/thread.c | 7 ++---
tools/perf/util/thread.h | 4 ---
tools/perf/util/unwind-libunwind-local.c | 18 +---
Hi Minas,
On Wed, 19 Dec 2018 14:09:01 +
Minas Harutyunyan wrote:
> On 12/18/2018 6:35 PM, John Keeping wrote:
> > Hi Minas,
> >
> > On Fri, 14 Dec 2018 09:00:08 +
> > Minas Harutyunyan wrote:
> >> First of all, sorry for delayed answer.
> >
Hi Minas,
On Fri, 14 Dec 2018 09:00:08 +
Minas Harutyunyan wrote:
> First of all, sorry for delayed answer.
> Looks like similar issue seen by Andrzej Pietrasiewicz
> : "dwc2 isochronous transfers issues". Same
> feedback provided to Andrzej.
>
> I run tests on 4.20.0-rc4 in DDMA. By defau
Hi Minas,
On Fri, 9 Nov 2018 14:36:36 +
Minas Harutyunyan wrote:
> On 11/9/2018 12:43 PM, Minas Harutyunyan wrote:
> > Hi John,
> >
> > On 11/8/2018 9:37 PM, John Keeping wrote:
> >> Hi Minas,
> >>
> >> On Mon, 5 Nov 2018 08:28:07 +
&g
check req_running != -1
req_running = -1
_start channel
Signed-off-by: John Keeping
---
drivers/dma/pl330.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 370df2e74ddd..88750a34e859 100644
ed by
schedule_timeout() is the same as the original timeout (HCI_INIT_TIMEOUT
on a system with HZ=1000).
Use wait_event_interruptible_timeout() instead of open-coding similar
behaviour which is subject to the spurious failure described above.
Signed-off-by: John Keeping
---
I saw problems with the -rt patchs
If there are multiple functions associated with a configuration, then
the UAC2 interfaces may not start at zero. Set the correct first
interface number in the association descriptor so that the audio
interfaces are enumerated correctly in this case.
Signed-off-by: John Keeping
Reviewed-by
pace
programs continue to work correctly and, as a bonus, old programs are
now compliant with the specification without having to fix anything
themselves.
Fixes: 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of
OS_DESC_EXT_COMPAT")
Cc: sta...@vger.kernel.org
Signed-off-b
tinue to work correctly and, as a bonus, old programs are
now compliant with the specification without having to fix anything
themselves.
Fixes: 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of
OS_DESC_EXT_COMPAT")
Cc: sta...@vger.kernel.org
Signed-off-by: John Keep
On Fri, 10 Nov 2017 12:40:39 +0200, Felipe Balbi wrote:
> John Keeping writes:
> > This check has gone through several incompatible variations in commits
> > 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of
> > OS_DESC_EXT_COMPAT"), 354bc4
7;s just
drop the condition to avoid breaking userspace.
Fixes: 53642399aa71 ("usb: gadget: f_fs: Fix wrong check on reserved1 of
OS_DESC_EXT_COMPAT")
Cc: sta...@vger.kernel.org # v4.7+
Signed-off-by: John Keeping
---
drivers/usb/gadget/function/f_fs.c | 3 +--
1 file changed, 1 inser
On Wed, Sep 20, 2017 at 07:08:11PM +0800, hl wrote:
>
>
> On Wednesday, September 20, 2017 06:08 PM, John Keeping wrote:
> > On Tue, Sep 19, 2017 at 01:27:40PM -0700, Sean Paul wrote:
> >> On Tue, Sep 19, 2017 at 11:19:01AM -0700, Brian Norris wrote:
> >>>
On Tue, Sep 19, 2017 at 01:27:40PM -0700, Sean Paul wrote:
> On Tue, Sep 19, 2017 at 11:19:01AM -0700, Brian Norris wrote:
> > Hi Sean,
> >
> > On Tue, Sep 19, 2017 at 11:00:25AM -0700, Sean Paul wrote:
> > > On Mon, Sep 18, 2017 at 05:05:33PM +0800, Nickey Yang wrote:
> > > > This patch correct F
mclk is enabled and disabled only in i2s_runtime_{resume,suspend}() and
we ensure that the device is runtime suspended before reaching this
clk_disable_unprepare() call, so it is wrong to call it again here.
Signed-off-by: John Keeping
---
sound/soc/rockchip/rockchip_i2s.c | 1 -
1 file changed
complete.
Signed-off-by: John Keeping
---
I originally sent a version of this patch back in July [1] without any
response. Since then, I've improved the commit message and switched
from create_singlethread_workqueue() to alloc_ordered_workqueue(), so
I've marked this as v2.
Commit-ID: 596a7a1d0989c621c3ae49be73a1d1f9de22eb5a
Gitweb: http://git.kernel.org/tip/596a7a1d0989c621c3ae49be73a1d1f9de22eb5a
Author: John Keeping
AuthorDate: Wed, 6 Sep 2017 10:35:40 +0100
Committer: Thomas Gleixner
CommitDate: Wed, 6 Sep 2017 11:41:20 +0200
genirq/msi: Fix
b60 ("genirq/msi: Add msi_domain_populate_irqs")
Cc: sta...@vger.kernel.org #v4.5+
Signed-off-by: John Keeping
Reviewed-by: Marc Zyngier
---
On Wed, 6 Sep 2017 09:52:43 +0100, Marc Zyngier wrote:
> On 05/09/17 18:12, John Keeping wrote:
> > Use the correct variable to set up
Use the correct variable to set up each interrupt in turn rather than
configuring the first interrupt "nvec" times.
Signed-off-by: John Keeping
---
kernel/irq/msi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 48
On Fri, 25 Aug 2017 19:42:51 +0300, Andy Shevchenko wrote:
> On Fri, 2017-08-25 at 17:05 +0100, John Keeping wrote:
> > On Fri, 25 Aug 2017 10:24:26 -0400, Tom Rini wrote:
> > > On Fri, Aug 25, 2017 at 04:56:47PM +0300, Andy Shevchenko wrote:
>
> > > > Appa
On Fri, 25 Aug 2017 10:24:26 -0400, Tom Rini wrote:
> On Fri, Aug 25, 2017 at 04:56:47PM +0300, Andy Shevchenko wrote:
> > +John
> >
> > On Tue, 2017-08-22 at 21:51 -0400, Tom Rini wrote:
> > > Not all devices with ACPI and this combination of sound devices will
> > > have the required informat
completed
requests are passed to userspace in the order in which they complete.
Signed-off-by: John Keeping
---
drivers/usb/gadget/function/f_fs.c | 10 +-
drivers/usb/gadget/function/u_fs.h | 1 +
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function
Hi Sean,
On Sun, 12 Mar 2017 07:06:59 -0500, Rob Herring wrote:
> On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote:
> > This reset is required in order to fully reset the internal state of the
> > MIPI controller.
> >
> > Signed-off-by: John Keeping
>
On Thu, 23 Mar 2017 11:10:20 -0500, Julia Cartwright wrote:
> One quick question below. Apologies if this has been covered, but just
> want to be sure.
>
> On Thu, Mar 23, 2017 at 10:59:28AM +, John Keeping wrote:
> > regmap_update_bits does its own locking and everyt
With real-time preemption, regmap functions cannot be used in the
implementation of irq_chip since they use spinlocks which may sleep.
Move the setting of the mux for IRQs to an irq_bus_sync_unlock handler
where we are allowed to sleep.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
regmap_update_bits does its own locking and everything else accessed
here is a local variable so there is no need to lock around it.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v3: unchanged
v2.1:
- Remove RK2928 locking in rockchip_set_pull()
v2
The aim of the series is to make the Rockchip pinctrl irq_chip
implementation safe for use with RT_FULL which requires that raw
spinlocks are used to avoid sleeping in hardirq context.
v4 is v3 rebased onto pinctrl/devel as of b9c6dcab265e ("pinctrl: rockchip:
rename RK1108 to RV1108&quo
This lock is used from rockchip_irq_set_type() which is part of the
irq_chip implementation and thus must use raw_spinlock_t as documented
in Documentation/gpio/driver.txt.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v3: unchanged
v2: unchanged
s new rockchip_verify_mux() function from there.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v3: unchanged
v2: unchanged
---
drivers/pinctrl/pinctrl-rockchip.c | 46 +-
1 file changed, 30 insertions(+), 16 dele
This lock is used from rockchip_irq_set_type() which is part of the
irq_chip implementation and thus must use raw_spinlock_t as documented
in Documentation/gpio/driver.txt.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v3: unchanged
v2: unchanged
regmap_update_bits does its own locking and everything else accessed
here is a local variable so there is no need to lock around it.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v3: unchanged
v2.1:
- Remove RK2928 locking in rockchip_set_pull()
v2
s new rockchip_verify_mux() function from there.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v3: unchanged
v2: unchanged
---
drivers/pinctrl/pinctrl-rockchip.c | 46 +-
1 file changed, 30 insertions(+), 16 dele
a new version so it's simpler to
apply.
[1] https://www.spinics.net/lists/arm-kernel/msg568974.html
John Keeping (4):
pinctrl: rockchip: remove unnecessary locking
pinctrl: rockchip: convert to raw spinlock
pinctrl: rockchip: split out verification of mux settings
pinctrl: rockchip: avo
With real-time preemption, regmap functions cannot be used in the
implementation of irq_chip since they use spinlocks which may sleep.
Move the setting of the mux for IRQs to an irq_bus_sync_unlock handler
where we are allowed to sleep.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
On Thu, 16 Mar 2017 11:31:44 +0800, Chris Zhong wrote:
> For RK3399, the phy_cfg_clk is a required clock, if phy_cfg_clk is
> disabled, MIPI phy can not work. Let's return a error if there is no
> phy_cfg_clk in dts property, when the pdata match RK3399.
>
> Signed-off-by: Chris Zhong
> ---
>
>
regmap_update_bits does its own locking and everything else accessed
here is a local variable so there is no need to lock around it.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v2.1:
- Remove RK2928 locking in rockchip_set_pull()
v2:
- Also remove
On Wed, 15 Mar 2017 13:23:09 -0500, Julia Cartwright wrote:
> On Wed, Mar 15, 2017 at 07:16:53PM +0100, Heiko Stuebner wrote:
> > Am Mittwoch, 15. März 2017, 18:08:06 CET schrieb John Keeping:
> > > On Wed, 15 Mar 2017 13:01:37 -0500, Julia Cartwright wrote:
> > > &
spinlocks are used to avoid sleeping in hardirq context.
[1] https://www.spinics.net/lists/arm-kernel/msg568279.html
John Keeping (4):
pinctrl: rockchip: remove unnecessary locking
pinctrl: rockchip: convert to raw spinlock
pinctrl: rockchip: split out verification of mux settings
pinctrl
With real-time preemption, regmap functions cannot be used in the
implementation of irq_chip since they use spinlocks which may sleep.
Move the setting of the mux for IRQs to an irq_bus_sync_unlock handler
where we are allowed to sleep.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
regmap_update_bits does its own locking and everything else accessed
here is a local variable so there is no need to lock around it.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v2:
- Also remove locking in rockchip_set_schmitt()
---
drivers/pinctrl
This lock is used from rockchip_irq_set_type() which is part of the
irq_chip implementation and thus must use raw_spinlock_t as documented
in Documentation/gpio/driver.txt.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v2: unchanged
---
drivers/pinctrl
s new rockchip_verify_mux() function from there.
Signed-off-by: John Keeping
Reviewed-by: Heiko Stuebner
Tested-by: Heiko Stuebner
---
v2: unchanged
---
drivers/pinctrl/pinctrl-rockchip.c | 46 +-
1 file changed, 30 insertions(+), 16 deletions(-)
diff --
On Wed, 15 Mar 2017 13:01:37 -0500, Julia Cartwright wrote:
> On Wed, Mar 15, 2017 at 05:46:52PM +0000, John Keeping wrote:
> > This lock is used from rockchip_irq_set_type() which is part of the
> > irq_chip implementation and thus must use raw_spinlock_t as documented
> >
On Wed, 15 Mar 2017 17:41:21 +0100, Heiko Stuebner wrote:
> Am Mittwoch, 15. März 2017, 17:28:56 CET schrieb Heiko Stuebner:
> > Am Montag, 13. März 2017, 18:38:11 CET schrieb John Keeping:
> > > This lock is used from rockchip_irq_set_type() which is part of the
> > &
On Wed, 15 Mar 2017 09:47:29 -0700, Brian Norris wrote:
> On Wed, Mar 15, 2017 at 04:42:31PM +0800, Chris Zhong wrote:
> > For RK3399, the grf clk should be enabled before writing grf registers,
> > otherwise the register value can not be changed.
> >
> > Signed-off-by: Chris Zhong
> > ---
> >
The hci_bcm driver currently does not prepare/unprepare the clock and
goes directly to enable, but as the documentation for clk_enable says,
clk_prepare must be called before clk_enable.
Signed-off-by: John Keeping
---
drivers/bluetooth/hci_bcm.c | 4 ++--
1 file changed, 2 insertions(+), 2
The hci_bcm driver currently does not prepare/unprepare the clock and
goes directly to enable, but as the documentation for clk_enable says,
clk_prepare must be called before clk_enable.
Signed-off-by: John Keeping
---
drivers/bluetooth/hci_bcm.c | 4 ++--
1 file changed, 2 insertions(+), 2
verted to a raw
spinlock since with full RT preemption the regmap's spinlock may sleep.
John Keeping (4):
pinctrl: rockchip: remove unnecessary locking
pinctrl: rockchip: convert to raw spinlock
pinctrl: rockchip: split out verification of mux settings
pinctrl: rockchip: avoid hardirq
This lock is used from rockchip_irq_set_type() which is part of the
irq_chip implementation and thus must use raw_spinlock_t as documented
in Documentation/gpio/driver.txt.
Signed-off-by: John Keeping
---
drivers/pinctrl/pinctrl-rockchip.c | 30 +++---
1 file changed, 15
don't think it can be "slock" given that the following
patches will convert that to a raw spinlock and regmap uses a normal
spinlock internally.
Signed-off-by: John Keeping
---
drivers/pinctrl/pinctrl-rockchip.c | 20 +---
1 file changed, 1 insertion(+), 19 deleti
s new rockchip_verify_mux() function from there.
Signed-off-by: John Keeping
---
drivers/pinctrl/pinctrl-rockchip.c | 46 +-
1 file changed, 30 insertions(+), 16 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c
b/drivers/pinctrl/pinctrl-rockc
With real-time preemption, regmap functions cannot be used in the
implementation of irq_chip since they use spinlocks which may sleep.
Move the setting of the mux for IRQs to an irq_bus_sync_unlock handler
where we are allowed to sleep.
Signed-off-by: John Keeping
---
drivers/pinctrl/pinctrl
With Sphinx 1.5.3 I get the warning:
WARNING: primary_domain 'C' not found, ignored.
It seems that domain names in Sphinx are case-sensitive and for the C
domain the name must be lower case.
Signed-off-by: John Keeping
---
Documentation/conf.py | 2 +-
1 file changed, 1
This reset is required in order to fully reset the internal state of the
MIPI controller.
Signed-off-by: John Keeping
---
On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote:
> On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote:
> > + /*
> > +* Note that th
When binding a gadget to a device, "name" is stored in gi->udc_name, but
this does not happen when unregistering and the string is leaked.
Signed-off-by: John Keeping
---
drivers/usb/gadget/configfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/gadget/configf
call which seems to be a workaround for a specific panel and
thus belongs in the panel driver.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
v3:
- Add Chris' Reviewed-by
Unchanged in v2
---
drivers/gpu/drm/rockchip/dw-mipi-
In order to fully reset the state of the MIPI controller we must assert
this reset.
This is slightly more complicated than it could be in order to maintain
compatibility with device trees that do not specify the reset property.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
---
v4:
- Fix
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
v3:
- Add Chris' Reviewed-by
Unchanged in v2
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 21 +
1 file changed, 13 insertions(+), 8 deletions(-)
di
in order to
ensure that the PHY configuration is correct.
Signed-off-by: John Keeping
---
v4:
- Simplify ns2bc and ns2ui calculations as suggested by Sean Paul
v3:
- Wrap some long lines
Unchanged in v2
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 35 ++
1 file
By dereferencing the MIPI command buffer as a u32* we rely on it being
correctly aligned on ARM, but this may not be the case. Copy it into a
stack variable that will be correctly aligned.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
---
v3:
- Add Chris' Reviewed-by
Unchanged
at we have just read from the status register.
Signed-off-by: John Keeping
Tested-by: Chris Zhong
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
Unchanged in v3
Unchanged in v2
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 10 ++
1 file changed, 6 i
With atomic modesetting the hardware will be powered off when the
mode_set function is called. We should configure the hardware in the
enable function, which is the atomic version of "commit" so let's use
the enable hook rather than commit while we're at it.
Signed-off-by: Jo
Also don't power up the DSI host at this point since this is not
necessary in order to configure the PHY and we do so later when
selecting video or command mode.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
v3:
-
This ensures that the output resolution is known before fbcon loads.
mipi_dsi_host_register() is moved above dw_mipi_dsi_register() to
simplify error cleanup since the order of these operations does not
matter.
Signed-off-by: John Keeping
---
v4:
- Use "return 0" to separate normal
As a side-effect of this, encode the endianness explicitly rather than
casting a u16.
Signed-off-by: John Keeping
---
v4:
- Introduce "data" variable to avoid confusion around the masking in
GEN_HDATA()
v3:
- Add Chris' Reviewed-by
Unchanged in v2
---
drivers/gpu/drm/rockchi
We want to check that both the GEN_CMD_EMPTY and GEN_PLD_W_EMPTY bits
are set so we can't just check "val & mask" because that will be true if
either bit is set.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Rev
This is not needed since we can access the mode via the CRTC from the
enable hook. Also remove the "mode" field that is no longer used.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
v3:
- Add Chris' R
This matches other drivers.
Signed-off-by: John Keeping
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
Unchanged in v3
Unchanged in v2
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw
54, N = 4 as given by the databook.
While doing this, change the loop limits to encode the actual limits on
the divisor, which are:
40MHz >= (pllref / N) >= 5MHz
Signed-off-by: John Keeping
Reviewed-by: Sean Paul
---
v4:
- Add a comment explaining the limits so that it can be unde
Instead of always sending commands in LP mode, respect the
MIPI_DSI_MSG_USE_LPM flag to decide how to send each message. Also
request acks if MIPI_DSI_MSG_REQ_ACK is set.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
v3:
As the documentation for readx_poll_timeout says, we want to use the
specialized macro for readl rather than using the generic version
directly.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
v3:
- Add Chris' Reviewed-by
This shows that we only use the mode from the enable function and
prepares us to remove the "mode" field and the mode_set hook in the next
commit.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
v3:
- Add Chris' R
This clock rate is derived from the PHY PLL, so it should be calculated
dynamically. This calculation is the same as that used by the vendor
kernel and ensures that the escape clock runs at <20MHz as required by
the MIPI specification.
Signed-off-by: John Keeping
Reviewed-by: Chris Zh
Some panels need to be configured with commands sent over the MIPI link,
which they will do in the prepare hook. Call this after the PHY has
been initialized so that we are able to send commands to the panel.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4
As an aid to debugging.
Signed-off-by: John Keeping
Reviewed-by: Chris Zhong
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
v3:
- Add Chris' Reviewed-by
Unchanged in v2
---
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
di
The bias, bandgap and PLL should all be configured before we enable
them.
Signed-off-by: John Keeping
Reviewed-by: Sean Paul
---
v4:
- Add Sean's Reviewed-by
v3:
- Squash together two patches that both affect initialization order of
the PHY
Unchanged in v2
---
drivers/gpu/drm/rockch
on the list if anyone wants to pick it up in the future.
Version 3 was posted here:
http://www.spinics.net/lists/dri-devel/msg130977.html
Thanks to Sean Paul and Chris Zhong for their review and testing of this
series.
John Keeping (23):
drm/rockchip: dw-mipi-dsi: don't configure hard
Requesting the HS clock from the PHY before we initialize it causes an
invalid signal to be sent out since the input clock is not yet
configured. The PHY databook suggests only asserting this signal when
performing HS transfers, so let's do that.
Signed-off-by: John Keeping
Reviewed-by:
When connected to the MIPI DSI output, we need to use N{H,V}SYNC for the
internal connection but these flags are meaningless for DSI panels.
Switch the test so that we do not set the P{H,V}SYNC bits unless the
mode requires it.
Signed-off-by: John Keeping
Reviewed-by: Mark Yao
Reviewed-by: Sean
On Wed, 22 Feb 2017 10:57:05 -0500, Sean Paul wrote:
> On Wed, Feb 22, 2017 at 8:43 AM, John Keeping wrote:
> > On Tue, 21 Feb 2017 10:39:18 -0500, Sean Paul wrote:
> >
> >> On Mon, Feb 20, 2017 at 04:02:16PM +0800, Chris Zhong wrote:
> >> > Hi all
&
On Tue, 21 Feb 2017 10:39:18 -0500, Sean Paul wrote:
> On Mon, Feb 20, 2017 at 04:02:16PM +0800, Chris Zhong wrote:
> > Hi all
> >
> > [Resend this v7 version series, since there are 5 mails have gone missing,
> > last
> > week]
> >
> > This version does not change the existing v6 patches, just
+0x14/0x18
[] bus_probe_device+0x30/0x88
[] device_add+0x430/0x554
[] usb_set_configuration+0x660/0x6fc
Fixes: 2d984ad132a8 ("PM / QoS: Introcuce latency tolerance device PM QoS type")
Signed-off-by: John Keeping
---
drivers/base/power/qos.c | 2 +-
1 file changed, 1 inser
On Thu, 16 Feb 2017 11:01:46 +0800, Chris Zhong wrote:
> On 02/01/2017 03:22 AM, Sean Paul wrote:
> > On Sun, Jan 29, 2017 at 01:24:42PM +0000, John Keeping wrote:
> >
> > Reviewed-by: Sean Paul
> >
> >> Signed-off-by: John Keeping
> >> Reviewed-
On Thu, 16 Feb 2017 10:12:33 +0800, Chris Zhong wrote:
> On 02/15/2017 08:39 PM, John Keeping wrote:
> > On Wed, 15 Feb 2017 11:38:45 +0800, Chris Zhong wrote:
> >
> >> On 01/29/2017 09:24 PM, John Keeping wrote:
> >>> In order to fully reset the state o
On Wed, 15 Feb 2017 11:38:45 +0800, Chris Zhong wrote:
> On 01/29/2017 09:24 PM, John Keeping wrote:
> > In order to fully reset the state of the MIPI controller we must assert
> > this reset.
> >
> > This is slightly more complicated than it could be in order to main
On Tue, 31 Jan 2017 14:21:17 -0500, Sean Paul wrote:
> On Sun, Jan 29, 2017 at 01:24:41PM +0000, John Keeping wrote:
> > This ensures that the output resolution is known before fbcon loads.
> >
> > Signed-off-by: John Keeping
> > ---
> > Unchanged in v3
> >
On Mon, 30 Jan 2017 15:25:10 -0500, Sean Paul wrote:
> On Sun, Jan 29, 2017 at 01:24:33PM +0000, John Keeping wrote:
> > This clock rate is derived from the PHY PLL, so it should be calculated
> > dynamically. Use the same calculation as the vendor kernel to derive
> > t
On Mon, 30 Jan 2017 15:16:09 -0500, Sean Paul wrote:
> On Mon, Jan 30, 2017 at 06:14:27PM +0000, John Keeping wrote:
> > On Mon, 30 Jan 2017 10:26:11 -0500, Sean Paul wrote:
> >
> > > On Sun, Jan 29, 2017 at 01:24:44PM +, John Keeping wrote:
> > > > I
1 - 100 of 286 matches
Mail list logo
