[tip:timers/urgent] clocksource/exynos_mct: Clear interrupt when cpu is shut down

2017-01-17 Thread tip-bot for Joonyoung Shim
Commit-ID: bc7c36eedb0c7004aa06c2afc3c5385adada8fa3 Gitweb: http://git.kernel.org/tip/bc7c36eedb0c7004aa06c2afc3c5385adada8fa3 Author: Joonyoung Shim <jy0922.s...@samsung.com> AuthorDate: Tue, 17 Jan 2017 13:54:36 +0900 Committer: Thomas Gleixner <t...@linutronix.de> CommitD

[tip:timers/urgent] clocksource/exynos_mct: Clear interrupt when cpu is shut down

2017-01-17 Thread tip-bot for Joonyoung Shim
Commit-ID: bc7c36eedb0c7004aa06c2afc3c5385adada8fa3 Gitweb: http://git.kernel.org/tip/bc7c36eedb0c7004aa06c2afc3c5385adada8fa3 Author: Joonyoung Shim AuthorDate: Tue, 17 Jan 2017 13:54:36 +0900 Committer: Thomas Gleixner CommitDate: Tue, 17 Jan 2017 10:08:38 +0100 clocksource

[PATCH] clocksource: exynos_mct: clear irq at stop local mct to fix suspend

2017-01-16 Thread Joonyoung Shim
) [ 51.499057] ---[ end trace 995703fe1bede0b4 ]--- Fixes: 56a94f13919c ("clocksource: exynos_mct: Avoid blocking calls in the cpu hotplug notifier") Cc: sta...@vger.kernel.org #v4.2+ #v4.1.4+ #3.18.18+ #v3.16.18+ #v3.12.46+ Reported-by: Seung-Woo Kim <sw0312@samsung.com> Signed-o

[PATCH] clocksource: exynos_mct: clear irq at stop local mct to fix suspend

2017-01-16 Thread Joonyoung Shim
) [ 51.499057] ---[ end trace 995703fe1bede0b4 ]--- Fixes: 56a94f13919c ("clocksource: exynos_mct: Avoid blocking calls in the cpu hotplug notifier") Cc: sta...@vger.kernel.org #v4.2+ #v4.1.4+ #3.18.18+ #v3.16.18+ #v3.12.46+ Reported-by: Seung-Woo Kim Signed-off-by: Joonyoung Shim Signed-off

Re: [PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator()

2016-11-30 Thread Joonyoung Shim
On 11/30/2016 05:05 PM, Viresh Kumar wrote: > On 30-11-16, 15:19, Joonyoung Shim wrote: >> Hi Viresh, >> >> On 11/30/2016 12:59 PM, Viresh Kumar wrote: >>> From: Stephen Boyd <sb...@codeaurora.org> >>> >>> Joonyoung Shim reported an interesting

Re: [PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator()

2016-11-30 Thread Joonyoung Shim
On 11/30/2016 05:05 PM, Viresh Kumar wrote: > On 30-11-16, 15:19, Joonyoung Shim wrote: >> Hi Viresh, >> >> On 11/30/2016 12:59 PM, Viresh Kumar wrote: >>> From: Stephen Boyd >>> >>> Joonyoung Shim reported an interesting problem on his ARM o

Re: [PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator()

2016-11-29 Thread Joonyoung Shim
Hi Viresh, On 11/30/2016 12:59 PM, Viresh Kumar wrote: > From: Stephen Boyd <sb...@codeaurora.org> > > Joonyoung Shim reported an interesting problem on his ARM octa-core > Odoroid-XU3 platform. During system suspend, dev_pm_opp_put_regulator() > was failing for a st

Re: [PATCH V4] PM / OPP: Pass opp_table to dev_pm_opp_put_regulator()

2016-11-29 Thread Joonyoung Shim
Hi Viresh, On 11/30/2016 12:59 PM, Viresh Kumar wrote: > From: Stephen Boyd > > Joonyoung Shim reported an interesting problem on his ARM octa-core > Odoroid-XU3 platform. During system suspend, dev_pm_opp_put_regulator() > was failing for a struct device for which dev_pm_op

Re: [PATCH] PM / OPP: fix CPU device to be removed from OPP table in wrong order

2016-11-24 Thread Joonyoung Shim
Hi Viresh, On 11/25/2016 03:57 PM, Viresh Kumar wrote: > On 25-11-16, 10:54, Joonyoung Shim wrote: >> I found this problem during system suspend/resume of Odroid-XU3 board. >> >> # rtcwake -m mem -s 3 >> wakeup from "mem" at Wed Apr 4 05:54:44 2001 >

Re: [PATCH] PM / OPP: fix CPU device to be removed from OPP table in wrong order

2016-11-24 Thread Joonyoung Shim
Hi Viresh, On 11/25/2016 03:57 PM, Viresh Kumar wrote: > On 25-11-16, 10:54, Joonyoung Shim wrote: >> I found this problem during system suspend/resume of Odroid-XU3 board. >> >> # rtcwake -m mem -s 3 >> wakeup from "mem" at Wed Apr 4 05:54:44 2001 >

Re: [PATCH] PM / OPP: Allow inactive opp_device to be present in dev list

2016-11-24 Thread Joonyoung Shim
On 11/25/2016 03:53 PM, Viresh Kumar wrote: > Joonyoung Shim reported an interesting problem on his ARM octa-core > Odoroid-XU3 platform. During system suspend, dev_pm_opp_put_regulator() > was failing for a struct device for which dev_pm_opp_set_regulator() is > called earlier. >

Re: [PATCH] PM / OPP: Allow inactive opp_device to be present in dev list

2016-11-24 Thread Joonyoung Shim
On 11/25/2016 03:53 PM, Viresh Kumar wrote: > Joonyoung Shim reported an interesting problem on his ARM octa-core > Odoroid-XU3 platform. During system suspend, dev_pm_opp_put_regulator() > was failing for a struct device for which dev_pm_opp_set_regulator() is > called earlier. >

Re: [PATCH] PM / OPP: fix CPU device to be removed from OPP table in wrong order

2016-11-24 Thread Joonyoung Shim
Hi Viresh. On 11/24/2016 05:34 PM, Viresh Kumar wrote: > Ho Joonyoung, > > On 24-11-16, 16:49, Joonyoung Shim wrote: >> The device that creates OPP table first should be removed from dev_list >> of OPP table in last because it can be used by other resources >> (support

Re: [PATCH] PM / OPP: fix CPU device to be removed from OPP table in wrong order

2016-11-24 Thread Joonyoung Shim
Hi Viresh. On 11/24/2016 05:34 PM, Viresh Kumar wrote: > Ho Joonyoung, > > On 24-11-16, 16:49, Joonyoung Shim wrote: >> The device that creates OPP table first should be removed from dev_list >> of OPP table in last because it can be used by other resources >> (support

[PATCH] PM / OPP: fix CPU device to be removed from OPP table in wrong order

2016-11-23 Thread Joonyoung Shim
CPU devices. This patch makes that the CPU device that creates OPP table is removed last. Signed-off-by: Joonyoung Shim <jy0922.s...@samsung.com> --- drivers/base/power/opp/cpu.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/base/pow

[PATCH] PM / OPP: fix CPU device to be removed from OPP table in wrong order

2016-11-23 Thread Joonyoung Shim
CPU devices. This patch makes that the CPU device that creates OPP table is removed last. Signed-off-by: Joonyoung Shim --- drivers/base/power/opp/cpu.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/drivers/base/power/opp/cpu.c b/drivers/base/power

Re: [PATCH] pwm: samsung: fix to use lowest div for large enough modulation bits

2016-08-02 Thread Joonyoung Shim
t; + for (div = variant->div_base; div < 4; ++div) > + if ((rate >> (variant->bits + div)) < freq) > + break; > + } > Reviewed-by: Joonyoung Shim <jy0922.s...@samsung.com> Thanks.

Re: [PATCH] pwm: samsung: fix to use lowest div for large enough modulation bits

2016-08-02 Thread Joonyoung Shim
iant->div_base; div < 4; ++div) > + if ((rate >> (variant->bits + div)) < freq) > + break; > + } > Reviewed-by: Joonyoung Shim Thanks.

[PATCH v2] rtc: s5m: fix to update ctrl register

2015-08-21 Thread Joonyoung Shim
gned-off-by: Joonyoung Shim Cc: # v3.16 --- Changelog for v2: - update commit description and code to fix time keeping problem - update the stable tag with the kernel version drivers/rtc/rtc-s5m.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m

Re: [PATCH] rtc: s5m: fix to update ctrl register

2015-08-21 Thread Joonyoung Shim
On 08/21/2015 04:25 PM, Krzysztof Kozlowski wrote: > On 21.08.2015 15:58, Joonyoung Shim wrote: >> On 08/21/2015 10:21 AM, Krzysztof Kozlowski wrote: >>> On 21.08.2015 10:00, Joonyoung Shim wrote: >>>> On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: >>>&g

Re: [PATCH] rtc: s5m: fix to update ctrl register

2015-08-21 Thread Joonyoung Shim
On 08/21/2015 10:21 AM, Krzysztof Kozlowski wrote: > On 21.08.2015 10:00, Joonyoung Shim wrote: >> On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: >>> On 21.08.2015 08:15, Alexandre Belloni wrote: >>>> Hi, >>>> >>>> On 13/08/2015 at

Re: [PATCH] rtc: s5m: fix to update ctrl register

2015-08-21 Thread Joonyoung Shim
On 08/21/2015 10:21 AM, Krzysztof Kozlowski wrote: On 21.08.2015 10:00, Joonyoung Shim wrote: On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: On 21.08.2015 08:15, Alexandre Belloni wrote: Hi, On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : According to datasheet, the S2MPS13X

[PATCH v2] rtc: s5m: fix to update ctrl register

2015-08-21 Thread Joonyoung Shim
-by: Joonyoung Shim jy0922.s...@samsung.com Cc: sta...@vger.kernel.org # v3.16 --- Changelog for v2: - update commit description and code to fix time keeping problem - update the stable tag with the kernel version drivers/rtc/rtc-s5m.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers

Re: [PATCH] rtc: s5m: fix to update ctrl register

2015-08-21 Thread Joonyoung Shim
On 08/21/2015 04:25 PM, Krzysztof Kozlowski wrote: On 21.08.2015 15:58, Joonyoung Shim wrote: On 08/21/2015 10:21 AM, Krzysztof Kozlowski wrote: On 21.08.2015 10:00, Joonyoung Shim wrote: On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: On 21.08.2015 08:15, Alexandre Belloni wrote: Hi

Re: [PATCH] rtc: s5m: fix to update ctrl register

2015-08-20 Thread Joonyoung Shim
On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: > On 21.08.2015 08:15, Alexandre Belloni wrote: >> Hi, >> >> On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : >>> According to datasheet, the S2MPS13X and S2MPS14X should update write >>> buffer

Re: [PATCH] rtc: s5m: fix to update ctrl register

2015-08-20 Thread Joonyoung Shim
On 08/21/2015 09:44 AM, Krzysztof Kozlowski wrote: On 21.08.2015 08:15, Alexandre Belloni wrote: Hi, On 13/08/2015 at 17:49:24 +0900, Joonyoung Shim wrote : According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR bit to high after ctrl register

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Joonyoung Shim
On 08/17/2015 11:00 AM, Krzysztof Kozlowski wrote: > On 17.08.2015 10:47, Joonyoung Shim wrote: >> Hi, >> >> On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: >>> W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: >>>> According to datasheet, the

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Joonyoung Shim
Hi, On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: > W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: >> According to datasheet, the S2MPS13X and S2MPS14X should update write >> buffer via setting WUDR bit to high after ctrl register is updated. > > Hi, > > I c

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Joonyoung Shim
On 08/13/2015 07:42 PM, Krzysztof Kozlowski wrote: > W dniu 13.08.2015 o 19:02, Krzysztof Kozlowski pisze: >> W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: >>> According to datasheet, the S2MPS13X and S2MPS14X should update write >>> buffer via setting WUDR bit

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Joonyoung Shim
Hi, On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR bit to high after ctrl register is updated. Hi, I cannot find this information in S2MPS14

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Joonyoung Shim
On 08/13/2015 07:42 PM, Krzysztof Kozlowski wrote: W dniu 13.08.2015 o 19:02, Krzysztof Kozlowski pisze: W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR bit to high after ctrl register is updated

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Joonyoung Shim
On 08/17/2015 11:00 AM, Krzysztof Kozlowski wrote: On 17.08.2015 10:47, Joonyoung Shim wrote: Hi, On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: According to datasheet, the S2MPS13X and S2MPS14X should update write buffer via setting WUDR

[PATCH] rtc: s5m: fix to update ctrl register

2015-08-13 Thread Joonyoung Shim
hour mode in Odroid-XU3 board. Signed-off-by: Joonyoung Shim Cc: --- drivers/rtc/rtc-s5m.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 8c70d78..03828bb 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c @@ -635,6

[PATCH] rtc: s5m: fix to update ctrl register

2015-08-13 Thread Joonyoung Shim
hour mode in Odroid-XU3 board. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Cc: sta...@vger.kernel.org --- drivers/rtc/rtc-s5m.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 8c70d78..03828bb 100644 --- a/drivers/rtc/rtc

Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk

2015-08-12 Thread Joonyoung Shim
On 08/12/2015 09:10 AM, Krzysztof Kozlowski wrote: > On 11.08.2015 20:28, Joonyoung Shim wrote: >> The driver uses clk_prepare_enable()/clk_disable_unprepare() only in >> probe only, elsewhere, use the unified functions for enable/disable of >> clk, e.g. s3c_rtc_enable_clk()

[PATCH v2] rtc: s3c: fix disabled clocks for alarm

2015-08-12 Thread Joonyoung Shim
h 'enabled' argument having same value, so it needs to check whether clocks are enabled or not. Signed-off-by: Joonyoung Shim Cc: # v4.1 --- This is v2 of prior patch "[PATCH 4/4] rtc: s3c: enable/disable clocks for alarm". Changelog for v2: - commit messages is modified by Krzyszt

Re: [PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk

2015-08-12 Thread Joonyoung Shim
On 08/12/2015 09:10 AM, Krzysztof Kozlowski wrote: On 11.08.2015 20:28, Joonyoung Shim wrote: The driver uses clk_prepare_enable()/clk_disable_unprepare() only in probe only, elsewhere, use the unified functions for enable/disable of clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk(), so

[PATCH v2] rtc: s3c: fix disabled clocks for alarm

2015-08-12 Thread Joonyoung Shim
' argument having same value, so it needs to check whether clocks are enabled or not. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Cc: sta...@vger.kernel.org # v4.1 --- This is v2 of prior patch [PATCH 4/4] rtc: s3c: enable/disable clocks for alarm. Changelog for v2: - commit messages

Re: [PATCH 4/4] rtc: s3c: enable/disable clocks for alarm

2015-08-11 Thread Joonyoung Shim
On 08/12/2015 09:28 AM, Krzysztof Kozlowski wrote: > On 11.08.2015 20:28, Joonyoung Shim wrote: >> The clock enable/disable codes for alarm have removed from > > What do you mean in this paragraph? The clock code was removing something? > >> 'commit 24e1455493da ("

[PATCH 4/4] rtc: s3c: enable/disable clocks for alarm

2015-08-11 Thread Joonyoung Shim
at enabled argument has same value, so it needs to check whether clocks is enabled or not. Signed-off-by: Joonyoung Shim --- drivers/rtc/rtc-s3c.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c ind

[PATCH 1/4] rtc: s3c: add missing clk control

2015-08-11 Thread Joonyoung Shim
It's missed to call clk_unprepare() about info->rtc_src_clk in s3c_rtc_remove and to call clk_disable_unprepare about info->rtc_clk in error routine of s3c_rtc_probe. Signed-off-by: Joonyoung Shim --- drivers/rtc/rtc-s3c.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/r

[PATCH 2/4] rtc: s3c: remove unnecessary NULL assignment

2015-08-11 Thread Joonyoung Shim
It's unnecessary the code that assigns info->rtc_clk to NULL in s3c_rtc_remove. Signed-off-by: Joonyoung Shim --- drivers/rtc/rtc-s3c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index d1866a4..44b2921 100644 --- a/drivers/rtc/rtc-s3

[PATCH 0/4] modify clock codes of rtc-s3c driver

2015-08-11 Thread Joonyoung Shim
Hi, This patchset modifies clock codes of rtc-s3c driver. Main change is to fix the problem that alarm interrupt can't happen. Also there are some fixes incluing cleanup. Thanks. Joonyoung Shim (4): rtc: s3c: add missing clk

[PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk

2015-08-11 Thread Joonyoung Shim
The driver uses clk_prepare_enable()/clk_disable_unprepare() only in probe only, elsewhere, use the unified functions for enable/disable of clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk(), so it's better to use them for consistency of code. Signed-off-by: Joonyoung Shim --- drivers/rtc

[PATCH 1/4] rtc: s3c: add missing clk control

2015-08-11 Thread Joonyoung Shim
It's missed to call clk_unprepare() about info-rtc_src_clk in s3c_rtc_remove and to call clk_disable_unprepare about info-rtc_clk in error routine of s3c_rtc_probe. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/rtc/rtc-s3c.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 4/4] rtc: s3c: enable/disable clocks for alarm

2015-08-11 Thread Joonyoung Shim
argument has same value, so it needs to check whether clocks is enabled or not. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/rtc/rtc-s3c.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c

[PATCH 2/4] rtc: s3c: remove unnecessary NULL assignment

2015-08-11 Thread Joonyoung Shim
It's unnecessary the code that assigns info-rtc_clk to NULL in s3c_rtc_remove. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/rtc/rtc-s3c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index d1866a4..44b2921 100644

[PATCH 0/4] modify clock codes of rtc-s3c driver

2015-08-11 Thread Joonyoung Shim
Hi, This patchset modifies clock codes of rtc-s3c driver. Main change is to fix the problem that alarm interrupt can't happen. Also there are some fixes incluing cleanup. Thanks. Joonyoung Shim (4): rtc: s3c: add missing clk

[PATCH 3/4] rtc: s3c: use unified functions for enable/disable of clk

2015-08-11 Thread Joonyoung Shim
The driver uses clk_prepare_enable()/clk_disable_unprepare() only in probe only, elsewhere, use the unified functions for enable/disable of clk, e.g. s3c_rtc_enable_clk() / s3c_rtc_disable_clk(), so it's better to use them for consistency of code. Signed-off-by: Joonyoung Shim jy0922.s

Re: [PATCH 4/4] rtc: s3c: enable/disable clocks for alarm

2015-08-11 Thread Joonyoung Shim
On 08/12/2015 09:28 AM, Krzysztof Kozlowski wrote: On 11.08.2015 20:28, Joonyoung Shim wrote: The clock enable/disable codes for alarm have removed from What do you mean in this paragraph? The clock code was removing something? 'commit 24e1455493da (drivers/rtc/rtc-s3c.c: delete duplicate

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-22 Thread Joonyoung Shim
On 07/22/2015 05:22 PM, Inki Dae wrote: > On 2015년 07월 22일 17:12, Joonyoung Shim wrote: >> On 07/22/2015 01:55 PM, Inki Dae wrote: >>> On 2015년 07월 22일 11:02, Joonyoung Shim wrote: >>>> On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: >>>>> Hi,

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-22 Thread Joonyoung Shim
On 07/22/2015 01:55 PM, Inki Dae wrote: > On 2015년 07월 22일 11:02, Joonyoung Shim wrote: >> On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> Today's linux-next (next-20150721) encounters boot failures on Exynos >>> Octa (Exynos542

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

2015-07-22 Thread Joonyoung Shim
On 07/22/2015 01:55 PM, Inki Dae wrote: On 2015년 07월 22일 11:02, Joonyoung Shim wrote: On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: Hi, Today's linux-next (next-20150721) encounters boot failures on Exynos Octa (Exynos5422) based boards. The boards hangs. I bisected

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

2015-07-22 Thread Joonyoung Shim
On 07/22/2015 05:22 PM, Inki Dae wrote: On 2015년 07월 22일 17:12, Joonyoung Shim wrote: On 07/22/2015 01:55 PM, Inki Dae wrote: On 2015년 07월 22일 11:02, Joonyoung Shim wrote: On 07/21/2015 10:19 PM, Krzysztof Kozlowski wrote: Hi, Today's linux-next (next-20150721) encounters boot failures

Re: Linux-next, Exynos Octa boot fail, bisected to: "drm/exynos: remove drm_iommu_attach_device_if_possible"

2015-07-21 Thread Joonyoung Shim
ad commit > commit d80167b85024982c5f18d0481a5c248100360118 > Author: Joonyoung Shim > Date: Thu Jul 2 21:49:39 2015 +0900 > > drm/exynos: remove drm_iommu_attach_device_if_possible > > Already drm_iommu_attach_device checks whether support iommu internally. > It should clea

Re: Linux-next, Exynos Octa boot fail, bisected to: drm/exynos: remove drm_iommu_attach_device_if_possible

2015-07-21 Thread Joonyoung Shim
d80167b85024982c5f18d0481a5c248100360118 Author: Joonyoung Shim jy0922.s...@samsung.com Date: Thu Jul 2 21:49:39 2015 +0900 drm/exynos: remove drm_iommu_attach_device_if_possible Already drm_iommu_attach_device checks whether support iommu internally. It should clear channels always regardless iommu

Re: [PATCH RESEND v2 2/6] drm/exynos/mixer: fix interrupt clearing

2015-07-09 Thread Joonyoung Shim
* clear interrupts */ > - if (~val & MXR_INT_EN_VSYNC) { > - /* vsync interrupt use different bit for read and clear */ > - val &= ~MXR_INT_EN_VSYNC; > - val |= MXR_INT_CLEAR_VSYNC; > - } > mixer_reg_write(res, MXR_INT_STAT

Re: [PATCH RESEND 0/6] drm/exynos: HDMI related fixes

2015-07-09 Thread Joonyoung Shim
ertions(+), 51 deletions(-) > Looks good to me except one comment of "drm/exynos/mixer: fix interrupt clearing" patch. Also below my patch can be dropped by this patchset. http://www.spinics.net/lists/dri-devel/msg85322.html Reviewed-by: Joonyoung Shim -- To unsubscribe from this lis

Re: [PATCH RESEND 2/6] drm/exynos/mixer: fix interrupt clearing

2015-07-09 Thread Joonyoung Shim
On 07/09/2015 03:25 PM, Andrzej Hajda wrote: > The driver used incorrect flags to clear interrupt status. > The patch fixes it. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git

Re: [PATCH RESEND 0/6] drm/exynos: HDMI related fixes

2015-07-09 Thread Joonyoung Shim
comment of drm/exynos/mixer: fix interrupt clearing patch. Also below my patch can be dropped by this patchset. http://www.spinics.net/lists/dri-devel/msg85322.html Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH RESEND v2 2/6] drm/exynos/mixer: fix interrupt clearing

2015-07-09 Thread Joonyoung Shim
bit for read and clear */ - val = ~MXR_INT_EN_VSYNC; - val |= MXR_INT_CLEAR_VSYNC; - } mixer_reg_write(res, MXR_INT_STATUS, val); spin_unlock(res-reg_slock); Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. -- To unsubscribe from this list

Re: [PATCH RESEND 2/6] drm/exynos/mixer: fix interrupt clearing

2015-07-09 Thread Joonyoung Shim
On 07/09/2015 03:25 PM, Andrzej Hajda wrote: The driver used incorrect flags to clear interrupt status. The patch fixes it. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_mixer.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff

Re: [PATCH 2/2] clk: divider: fix to set parent rate from CLK_DIVIDER_READ_ONLY flag

2015-05-14 Thread Joonyoung Shim
Hi Michael, On 05/13/2015 08:57 AM, Stephen Boyd wrote: > On 05/12, Michael Turquette wrote: >> Quoting Joonyoung Shim (2015-04-07 00:46:46) >>> The round_rate callback function will returns alway same parent clk rate >>> of divider with CLK_DIVIDER

Re: [PATCH 1/2] clk: divider: don't set_rate with CLK_DIVIDER_READ_ONLY flag

2015-05-14 Thread Joonyoung Shim
Hi Stephen, On 05/13/2015 08:59 AM, Stephen Boyd wrote: > On 04/07, Joonyoung Shim wrote: >> Even if use CLK_DIVIDER_READ_ONLY flag, divider setting can be changed >> by set_rate callback. Don't change divider setting from set_rate >> callback of divider with CLK_D

Re: [PATCH 1/2] clk: divider: don't set_rate with CLK_DIVIDER_READ_ONLY flag

2015-05-14 Thread Joonyoung Shim
Hi Stephen, On 05/13/2015 08:59 AM, Stephen Boyd wrote: On 04/07, Joonyoung Shim wrote: Even if use CLK_DIVIDER_READ_ONLY flag, divider setting can be changed by set_rate callback. Don't change divider setting from set_rate callback of divider with CLK_DIVIDER_READ_ONLY flag. Signed-off

Re: [PATCH 2/2] clk: divider: fix to set parent rate from CLK_DIVIDER_READ_ONLY flag

2015-05-14 Thread Joonyoung Shim
Hi Michael, On 05/13/2015 08:57 AM, Stephen Boyd wrote: On 05/12, Michael Turquette wrote: Quoting Joonyoung Shim (2015-04-07 00:46:46) The round_rate callback function will returns alway same parent clk rate of divider with CLK_DIVIDER_READ_ONLY flag. If be used CLK_SET_RATE_PARENT flag

[PATCH 2/2] clk: divider: fix to set parent rate from CLK_DIVIDER_READ_ONLY flag

2015-04-07 Thread Joonyoung Shim
ate. Signed-off-by: Joonyoung Shim --- drivers/clk/clk-divider.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index ce34d29a..37e285e 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -352,6 +352,11 @@ static l

[PATCH 1/2] clk: divider: don't set_rate with CLK_DIVIDER_READ_ONLY flag

2015-04-07 Thread Joonyoung Shim
Even if use CLK_DIVIDER_READ_ONLY flag, divider setting can be changed by set_rate callback. Don't change divider setting from set_rate callback of divider with CLK_DIVIDER_READ_ONLY flag. Signed-off-by: Joonyoung Shim --- drivers/clk/clk-divider.c | 3 +++ 1 file changed, 3 insertions(+) diff

[PATCH 2/2] clk: divider: fix to set parent rate from CLK_DIVIDER_READ_ONLY flag

2015-04-07 Thread Joonyoung Shim
-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/clk/clk-divider.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index ce34d29a..37e285e 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c @@ -352,6

[PATCH 1/2] clk: divider: don't set_rate with CLK_DIVIDER_READ_ONLY flag

2015-04-07 Thread Joonyoung Shim
Even if use CLK_DIVIDER_READ_ONLY flag, divider setting can be changed by set_rate callback. Don't change divider setting from set_rate callback of divider with CLK_DIVIDER_READ_ONLY flag. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com --- drivers/clk/clk-divider.c | 3 +++ 1 file changed

Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x

2015-02-05 Thread Joonyoung Shim
Hi, On 02/05/2015 11:45 PM, Javier Martinez Canillas wrote: > Hello Andrzej, > > Thanks a lot for finally finding what was causing the HDMI issue. > > On 02/05/2015 01:35 PM, Andrzej Hajda wrote: >> Hi, >> >> Exynos chipsets since 542x have asynchronous bridges connecting different >> IPs. >>

Re: [PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-02-05 Thread Joonyoung Shim
s_gem_obj = exynos_fbd->exynos_gem_obj; > struct drm_framebuffer *fb; > > - if (is_drm_iommu_supported(dev) && exynos_gem_obj->buffer->kvaddr) > + if (is_drm_iommu_supported(dev)) > vunmap(exynos_gem_obj->buffer->kvaddr); > >

Re: [PATCH] GPU-DRM-Exynos: Delete unnecessary checks before two function calls

2015-02-05 Thread Joonyoung Shim
) + if (is_drm_iommu_supported(dev)) vunmap(exynos_gem_obj-buffer-kvaddr); /* release drm framebuffer and real buffer */ Acked-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x

2015-02-05 Thread Joonyoung Shim
Hi, On 02/05/2015 11:45 PM, Javier Martinez Canillas wrote: Hello Andrzej, Thanks a lot for finally finding what was causing the HDMI issue. On 02/05/2015 01:35 PM, Andrzej Hajda wrote: Hi, Exynos chipsets since 542x have asynchronous bridges connecting different IPs. These bridges

Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors

2015-01-20 Thread Joonyoung Shim
Hi Kevin, On 01/15/2015 10:08 AM, Kevin Hilman wrote: > From: Kevin Hilman > > The odroid-xu3 has 4 INA231 current sensors on board which can be > accessed from the Linux via the hwmon interface. > > There is one sensor for each of these power rails: > > - A15 cluster: VDD_ARM > - A7 cluster:

Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors

2015-01-20 Thread Joonyoung Shim
Hi Kevin, On 01/15/2015 10:08 AM, Kevin Hilman wrote: From: Kevin Hilman khil...@linaro.org The odroid-xu3 has 4 INA231 current sensors on board which can be accessed from the Linux via the hwmon interface. There is one sensor for each of these power rails: - A15 cluster: VDD_ARM - A7

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Joonyoung Shim
h? >From 6de01473746af225c688ee430123001d57d9af2a Mon Sep 17 00:00:00 2001 From: Joonyoung Shim Date: Thu, 2 Oct 2014 17:48:27 +0900 Subject: [PATCH] drm/exynos: use drm_vblank_on() We need to use drm_vblank_on() as a counterpart to drm_vblank_off() after the commit 7ffd7a68511c ("drm: Always reject drm_v

Re: [PATCH] drm/exynos: fix vblank handling during dpms off

2014-10-02 Thread Joonyoung Shim
6de01473746af225c688ee430123001d57d9af2a Mon Sep 17 00:00:00 2001 From: Joonyoung Shim jy0922.s...@samsung.com Date: Thu, 2 Oct 2014 17:48:27 +0900 Subject: [PATCH] drm/exynos: use drm_vblank_on() We need to use drm_vblank_on() as a counterpart to drm_vblank_off() after the commit 7ffd7a68511c (drm: Always reject

Re: [PATCH] drm/exynos: switch to universal plane API

2014-09-19 Thread Joonyoung Shim
Hi, On 09/19/2014 08:11 PM, Joonyoung Shim wrote: > Hi, > > On 09/19/2014 07:54 PM, Andrzej Hajda wrote: >> On 09/19/2014 03:02 AM, Joonyoung Shim wrote: >>> Hi Andrzej, >>> >>> On 09/18/2014 10:17 PM, Andrzej Hajda wrote: >>>> T

Re: [PATCH] drm/exynos: switch to universal plane API

2014-09-19 Thread Joonyoung Shim
Hi, On 09/19/2014 07:54 PM, Andrzej Hajda wrote: > On 09/19/2014 03:02 AM, Joonyoung Shim wrote: >> Hi Andrzej, >> >> On 09/18/2014 10:17 PM, Andrzej Hajda wrote: >>> The patch replaces legacy functions >>> drm_plane_init() / drm_crtc_i

Re: [PATCH] drm/exynos: switch to universal plane API

2014-09-19 Thread Joonyoung Shim
Hi, On 09/19/2014 07:54 PM, Andrzej Hajda wrote: On 09/19/2014 03:02 AM, Joonyoung Shim wrote: Hi Andrzej, On 09/18/2014 10:17 PM, Andrzej Hajda wrote: The patch replaces legacy functions drm_plane_init() / drm_crtc_init() with drm_universal_plane_init() and drm_crtc_init_with_planes

Re: [PATCH] drm/exynos: switch to universal plane API

2014-09-19 Thread Joonyoung Shim
Hi, On 09/19/2014 08:11 PM, Joonyoung Shim wrote: Hi, On 09/19/2014 07:54 PM, Andrzej Hajda wrote: On 09/19/2014 03:02 AM, Joonyoung Shim wrote: Hi Andrzej, On 09/18/2014 10:17 PM, Andrzej Hajda wrote: The patch replaces legacy functions drm_plane_init() / drm_crtc_init

Re: [PATCH] drm/exynos: switch to universal plane API

2014-09-18 Thread Joonyoung Shim
Hi Andrzej, On 09/18/2014 10:17 PM, Andrzej Hajda wrote: > The patch replaces legacy functions > drm_plane_init() / drm_crtc_init() with > drm_universal_plane_init() and drm_crtc_init_with_planes(). > It allows to replace fake primary plane with the real one. > > Signed-off-by: Andrzej Hajda >

Re: [PATCH] drm/exynos: switch to universal plane API

2014-09-18 Thread Joonyoung Shim
Hi Andrzej, On 09/18/2014 10:17 PM, Andrzej Hajda wrote: The patch replaces legacy functions drm_plane_init() / drm_crtc_init() with drm_universal_plane_init() and drm_crtc_init_with_planes(). It allows to replace fake primary plane with the real one. Signed-off-by: Andrzej Hajda

Re: [PATCH v3 16/17] drm/exynos/ipp: remove file argument from node related functions

2014-09-02 Thread Joonyoung Shim
xynos/exynos_drm_ipp.c | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > About both patch 16 and 17 Reviewed-by: Joonyoung Shim Thanks. > diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c > b/drivers/gpu/drm/exynos/exynos_drm_ipp.c > index 05f0f4e..9e9714a 100644 >

Re: [PATCH v3 16/17] drm/exynos/ipp: remove file argument from node related functions

2014-09-02 Thread Joonyoung Shim
+--- 1 file changed, 5 insertions(+), 7 deletions(-) About both patch 16 and 17 Reviewed-by: Joonyoung Shim jy0922.s...@samsung.com Thanks. diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c index 05f0f4e..9e9714a 100644 --- a/drivers/gpu

Re: [PATCH v2 17/17] drm/exynos/ipp: add file checks for ioctls

2014-08-29 Thread Joonyoung Shim
Hi Andrzej, On 08/28/2014 06:07 PM, Andrzej Hajda wrote: > Process should not have access to ipp nodes created by another > process. The patch adds necessary checks. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 ++- > 1 file changed, 10

Re: [PATCH v2 16/17] drm/exynos/ipp: remove file argument from node related functions

2014-08-29 Thread Joonyoung Shim
Hi Andrzej, On 08/28/2014 06:07 PM, Andrzej Hajda wrote: > Since file pointer is preserved in c_node passing it > as argument in node functions is redundant. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 14 ++ > 1 file changed, 6 insertions(+),

Re: [PATCH v2 16/17] drm/exynos/ipp: remove file argument from node related functions

2014-08-29 Thread Joonyoung Shim
Hi Andrzej, On 08/28/2014 06:07 PM, Andrzej Hajda wrote: Since file pointer is preserved in c_node passing it as argument in node functions is redundant. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 14 ++ 1 file changed, 6

Re: [PATCH v2 17/17] drm/exynos/ipp: add file checks for ioctls

2014-08-29 Thread Joonyoung Shim
Hi Andrzej, On 08/28/2014 06:07 PM, Andrzej Hajda wrote: Process should not have access to ipp nodes created by another process. The patch adds necessary checks. Signed-off-by: Andrzej Hajda a.ha...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 ++- 1 file

Re: [PATCH 06/15] drm/exynos/ipp: free partially allocated resources on error

2014-08-27 Thread Joonyoung Shim
Hi, On 08/27/2014 07:27 PM, Andrzej Hajda wrote: > On 08/26/2014 07:00 AM, Joonyoung Shim wrote: >> Hi Andrzej, >> >> On 08/22/2014 04:52 PM, Andrzej Hajda wrote: >>> In case of allocation errors some already allocated buffers >>> were not freed. The patch f

Re: [PATCH 06/15] drm/exynos/ipp: free partially allocated resources on error

2014-08-27 Thread Joonyoung Shim
Hi, On 08/27/2014 07:27 PM, Andrzej Hajda wrote: On 08/26/2014 07:00 AM, Joonyoung Shim wrote: Hi Andrzej, On 08/22/2014 04:52 PM, Andrzej Hajda wrote: In case of allocation errors some already allocated buffers were not freed. The patch fixes it. Signed-off-by: Andrzej Hajda a.ha

Re: [PATCH 00/15] drm/exynos/ipp: image post processing fixes and improvements, part four

2014-08-26 Thread Joonyoung Shim
> drm/exynos/fimc: fix source buffer registers With some minor comments, Reviewed-by: Joonyoung Shim Thanks. > > drivers/gpu/drm/exynos/exynos_drm_fimc.c| 90 ++- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 3 +- > drivers/gpu/drm/exynos/exynos_drm_ipp.c

Re: [PATCH 15/15] drm/exynos/fimc: fix source buffer registers

2014-08-26 Thread Joonyoung Shim
On 08/26/2014 03:35 PM, Andrzej Hajda wrote: > On 08/26/2014 07:57 AM, Joonyoung Shim wrote: >> Hi Andrzej, >> >> On 08/22/2014 04:52 PM, Andrzej Hajda wrote: >>> FIMC in default mode of operation uses only one input buffer, >>> but the driver us

Re: [PATCH 15/15] drm/exynos/fimc: fix source buffer registers

2014-08-26 Thread Joonyoung Shim
On 08/26/2014 03:35 PM, Andrzej Hajda wrote: On 08/26/2014 07:57 AM, Joonyoung Shim wrote: Hi Andrzej, On 08/22/2014 04:52 PM, Andrzej Hajda wrote: FIMC in default mode of operation uses only one input buffer, but the driver used also second buffer, as a result only the first frame

Re: [PATCH 00/15] drm/exynos/ipp: image post processing fixes and improvements, part four

2014-08-26 Thread Joonyoung Shim
memory drm/exynos/ipp: remove events during command cleaning drm/exynos/fimc: avoid clearing overflow bits drm/exynos/fimc: do not enable fimc twice drm/exynos/fimc: simplify buffer queuing drm/exynos/fimc: fix source buffer registers With some minor comments, Reviewed-by: Joonyoung Shim

Re: [PATCH 15/15] drm/exynos/fimc: fix source buffer registers

2014-08-25 Thread Joonyoung Shim
Hi Andrzej, On 08/22/2014 04:52 PM, Andrzej Hajda wrote: > FIMC in default mode of operation uses only one input buffer, > but the driver used also second buffer, as a result only the > first frame was processed correctly. The patch fixes it. I can't understand well, then we don't need to

Re: [PATCH 14/15] drm/exynos/fimc: simplify buffer queuing

2014-08-25 Thread Joonyoung Shim
Hi Andrzej, On 08/22/2014 04:52 PM, Andrzej Hajda wrote: > The patch removes redundant checks, redundant HW reads > and simplifies code. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_fimc.c | 64 > > 1 file changed, 15

Re: [PATCH 06/15] drm/exynos/ipp: free partially allocated resources on error

2014-08-25 Thread Joonyoung Shim
Hi Andrzej, On 08/22/2014 04:52 PM, Andrzej Hajda wrote: > In case of allocation errors some already allocated buffers > were not freed. The patch fixes it. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 68 > - > 1 file

Re: [PATCH 03/15] drm/exynos/ipp: move file reference from memory to command node

2014-08-25 Thread Joonyoung Shim
On 08/26/2014 11:55 AM, Joonyoung Shim wrote: > Hi Andrzej, > > On 08/22/2014 04:52 PM, Andrzej Hajda wrote: >> Command node should contain file reference to distinguish commands >> created by different processes. >> >> Signed-off-by: Andrzej Hajda

  1   2   >