Re: [PATCH] optee: simplify i2c access

2021-02-08 Thread Jorge Ramirez-Ortiz, Foundries
On 08/02/21, Jorge Ramirez-Ortiz, Foundries wrote: > On 08/02/21, Jens Wiklander wrote: > > Hi Jorge, > > > > On Wed, Jan 27, 2021 at 11:41 AM Jens Wiklander > > wrote: > > > > > > Hi Arnd, > > > > > > On Mon, Jan 25, 2021 at 12:

Re: [PATCH] optee: simplify i2c access

2021-02-07 Thread Jorge Ramirez-Ortiz, Foundries
On 08/02/21, Jens Wiklander wrote: > Hi Jorge, > > On Wed, Jan 27, 2021 at 11:41 AM Jens Wiklander > wrote: > > > > Hi Arnd, > > > > On Mon, Jan 25, 2021 at 12:38 PM Arnd Bergmann wrote: > > > > > > From: Arnd Bergmann > > > > > > Storing a bogus i2c_client structure on the stack adds overhead

Re: [PATCH] watchdog: qcom: Remove incorrect usage of QCOM_WDT_ENABLE_IRQ

2021-01-28 Thread Jorge Ramirez-Ortiz, Foundries
On 26/01/21, Sai Prakash Ranjan wrote: > As per register documentation, QCOM_WDT_ENABLE_IRQ which is BIT(1) > of watchdog control register is wakeup interrupt enable bit and > not related to bark interrupt at all, BIT(0) is used for that. > So remove incorrect usage of this bit when supporting

Re: [PATCH] optee: simplify i2c access

2021-01-26 Thread Jorge Ramirez-Ortiz, Foundries
On 25/01/21, Arnd Bergmann wrote: > From: Arnd Bergmann > > Storing a bogus i2c_client structure on the stack adds overhead and > causes a compile-time warning: > > drivers/tee/optee/rpc.c:493:6: error: stack frame size of 1056 bytes in > function 'optee_handle_rpc'

Re: [PATCH] optee: simplify i2c access

2021-01-26 Thread Jorge Ramirez-Ortiz, Foundries
On 26/01/21, Arnd Bergmann wrote: > On Tue, Jan 26, 2021 at 9:08 AM Jorge Ramirez-Ortiz, Foundries > wrote: > > > > On 25/01/21, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Storing a bogus i2c_client structure on the stack adds ove

Re: [PATCH] drivers: optee: i2c: add bus retry configuration

2020-09-23 Thread Jorge Ramirez-Ortiz, Foundries
On 23/09/20, Jens Wiklander wrote: > On Wed, Sep 23, 2020 at 01:26:31PM +0200, Jorge Ramirez-Ortiz, Foundries > wrote: > > On 23/09/20, Jorge Ramirez-Ortiz, Foundries wrote: > > > On 22/09/20, Jens Wiklander wrote: > > > > On Wed, Sep 16, 2020 at 05:27:32PM

Re: [PATCH] drivers: optee: i2c: add bus retry configuration

2020-09-23 Thread Jorge Ramirez-Ortiz, Foundries
On 23/09/20, Jorge Ramirez-Ortiz, Foundries wrote: > On 22/09/20, Jens Wiklander wrote: > > On Wed, Sep 16, 2020 at 05:27:32PM +0200, Jorge Ramirez-Ortiz wrote: > > > Allow OP-TEE to specify the number of retries in the adaptor. > > > > > >

Re: [PATCH] drivers: optee: i2c: add bus retry configuration

2020-09-23 Thread Jorge Ramirez-Ortiz, Foundries
On 22/09/20, Jens Wiklander wrote: > On Wed, Sep 16, 2020 at 05:27:32PM +0200, Jorge Ramirez-Ortiz wrote: > > Allow OP-TEE to specify the number of retries in the adaptor. > > > > Signed-off-by: Jorge Ramirez-Ortiz > > --- > > drivers/tee/optee/rpc.c | 7 +++ > > 1 file changed, 7

Re: [PATCH] drivers: optee: fix i2c build issue

2020-08-31 Thread Jorge Ramirez-Ortiz, Foundries
On 31/08/20, Randy Dunlap wrote: > On 8/31/20 8:23 AM, Jorge Ramirez-Ortiz wrote: > > When the optee driver is compiled into the kernel while the i2c core > > is configured as a module, the i2c symbols are not available. > > > > This commit addresses the situation by disabling the i2c support for

Re: [PATCHv9] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-21 Thread Jorge Ramirez-Ortiz, Foundries
On 21/08/20, Jens Wiklander wrote: > On Fri, Aug 14, 2020 at 01:12:21PM +0200, Jorge Ramirez-Ortiz wrote: > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > control this type of cryptographic devices it needs coordinated access > > to the bus, so collisions and

Re: [PATCHv8] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-13 Thread Jorge Ramirez-Ortiz, Foundries
On 13/08/20, Jens Wiklander wrote: > On Wed, Aug 12, 2020 at 02:06:52PM +0200, Jorge Ramirez-Ortiz wrote: > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > control this type of cryptographic devices it needs coordinated access > > to the bus, so collisions and

Re: [PATCHv7] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-12 Thread Jorge Ramirez-Ortiz, Foundries
On 12/08/20, Jens Wiklander wrote: > On Tue, Aug 11, 2020 at 07:55:31PM +0200, Jorge Ramirez-Ortiz wrote: > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > control this type of cryptographic devices it needs coordinated access > > to the bus, so collisions and

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-06 Thread Jorge Ramirez-Ortiz, Foundries
On 06/08/20, Sumit Garg wrote: > On Thu, 6 Aug 2020 at 12:00, Jorge Ramirez-Ortiz, Foundries > wrote: > > > > On 06/08/20, Sumit Garg wrote: > > > On Thu, 6 Aug 2020 at 02:08, Jorge Ramirez-Ortiz, Foundries > > > wrote: > > > > > > > &g

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-06 Thread Jorge Ramirez-Ortiz, Foundries
On 06/08/20, Sumit Garg wrote: > On Thu, 6 Aug 2020 at 02:08, Jorge Ramirez-Ortiz, Foundries > wrote: > > > > On 05/08/20, Sumit Garg wrote: > > > Apologies for my delayed response as I was busy with some other tasks > > > along with holidays. > >

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 05/08/20, Sumit Garg wrote: > Apologies for my delayed response as I was busy with some other tasks > along with holidays. no pb! was just making sure this wasnt falling through some cracks. > > On Fri, 24 Jul 2020 at 19:53, Jorge Ramirez-Ortiz, Foundries > wrote: > > &

Re: [PATCHv6] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 05/08/20, Jens Wiklander wrote: > On Wed, Aug 05, 2020 at 03:35:01PM +0200, Jorge Ramirez-Ortiz, Foundries > wrote: > > On 22/07/20, Jorge Ramirez-Ortiz wrote: > > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > > control this type of

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 23/07/20, Jorge Ramirez-Ortiz wrote: > The current code waits for data to be available before attempting a > second read. However the second read would not be executed as the > while loop exits. > > This fix does not wait if all data has been read and reads a second > time if only partial data

Re: [PATCHv6] drivers: optee: allow op-tee to access devices on the i2c bus

2020-08-05 Thread Jorge Ramirez-Ortiz, Foundries
On 22/07/20, Jorge Ramirez-Ortiz wrote: > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > control this type of cryptographic devices it needs coordinated access > to the bus, so collisions and RUNTIME_PM dont get in the way. > > This trampoline driver allow OP-TEE to

Re: [PATCHv6] drivers: optee: allow op-tee to access devices on the i2c bus

2020-07-28 Thread Jorge Ramirez-Ortiz, Foundries
On 22/07/20, Jorge Ramirez-Ortiz wrote: > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > control this type of cryptographic devices it needs coordinated access > to the bus, so collisions and RUNTIME_PM dont get in the way. > > This trampoline driver allow OP-TEE to

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-07-28 Thread Jorge Ramirez-Ortiz, Foundries
On 24/07/20, Jorge Ramirez-Ortiz, Foundries wrote: > On 24/07/20, Sumit Garg wrote: > > On Thu, 23 Jul 2020 at 14:16, Jorge Ramirez-Ortiz > > wrote: > > > > > > The current code waits for data to be available before attempting a > > > second read. How

Re: [PATCHv2 2/2] hwrng: optee: fix wait use case

2020-07-24 Thread Jorge Ramirez-Ortiz, Foundries
On 24/07/20, Sumit Garg wrote: > On Thu, 23 Jul 2020 at 14:16, Jorge Ramirez-Ortiz wrote: > > > > The current code waits for data to be available before attempting a > > second read. However the second read would not be executed as the > > while loop exits. > > > > This fix does not wait if all

Re: [Tee-dev] [PATCH v2] drivers: optee: allow op-tee to access devices on the i2c bus

2020-06-08 Thread Jorge Ramirez-Ortiz, Foundries
On 08/06/20, Jens Wiklander wrote: > On Mon, Jun 01, 2020 at 09:24:46AM +0200, Jorge Ramirez-Ortiz, Foundries > wrote: > > On 01/06/20, Sumit Garg wrote: > > > Hi Jorge, > > > > hey > > > > > > > > On Mon, 1 Jun 2020 at 04:41, Jorge

Re: [PATCH v2] drivers: optee: allow op-tee to access devices on the i2c bus

2020-06-07 Thread Jorge Ramirez-Ortiz, Foundries
On 01/06/20, Jorge Ramirez-Ortiz wrote: > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > control this type of cryptographic devices it needs coordinated access > to the bus, so collisions and RUNTIME_PM dont get in the way. > > This trampoline driver allow OP-TEE to

Re: [Tee-dev] [PATCH v2] drivers: optee: allow op-tee to access devices on the i2c bus

2020-06-01 Thread Jorge Ramirez-Ortiz, Foundries
On 01/06/20, Sumit Garg wrote: > Hi Jorge, hey > > On Mon, 1 Jun 2020 at 04:41, Jorge Ramirez-Ortiz wrote: > > > > Some secure elements like NXP's SE050 sit on I2C buses. For OP-TEE to > > control this type of cryptographic devices it needs coordinated access > > to the bus, so collisions and