cro generating two printk arguments. Doing so in v2;
hope that isn't too ugly...
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-inf
d things, just don't include them if
> not needed.
Fixed in v2.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.h
itional on CONFIG_BUG, and map them all to the passthrough WARN_ON
when !CONFIG_BUG.
This saves 4.4k on a minimized configuration (smaller than
allnoconfig), and 20.6k with defconfig plus CONFIG_BUG=n.
Signed-off-by: Josh Triplett
---
diff's presentation here is not the easiest for reviewing purpos
: Josh Triplett
---
arch/x86/Kconfig | 12 +++
arch/x86/boot/Makefile| 5 ++-
arch/x86/boot/cpu.c | 68 +++
arch/x86/include/asm/cpufeature.h | 13
arch/x86/kernel/cpu/Makefile | 5 ++-
arch/x86/kernel
593 --593
Signed-off-by: Josh Triplett
---
arch/x86/kernel/cpu/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
index 7fd54f0..64038d8 100644
--- a/arch/x86/kernel/cpu/Makefile
+++ b
-168
load_elf_library 426 --426
Signed-off-by: Josh Triplett
---
v2: Add "default y", unintentionally omitted from the first patch.
Andrew, can you please replace the patch in -mm with this one?
fs/binfmt_elf.c | 9 -
fs/exec.c | 2 +
On Fri, Feb 21, 2014 at 12:16:27PM -0800, Andrew Morton wrote:
> On Fri, 21 Feb 2014 10:11:06 -0800 Josh Triplett
> wrote:
> > uselib hasn't been used since libc5; glibc does not use it. Support
> > turning it off.
> >
> > When disabled, also omit the l
-168
load_elf_library 426 --426
Signed-off-by: Josh Triplett
---
fs/binfmt_elf.c | 9 -
fs/exec.c | 2 ++
init/Kconfig| 9 +
kernel/sys_ni.c | 1 +
4 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_
ozen GB in use
> by various processes, I have seen swapoff take several hours of
> CPU time.
And it's clear what the lower bound on swapoff should be: current amount
of swap in use, divided by maximum disk write speed. We're definitely
not to *that* point yet; this ought to get u
On Mon, Feb 17, 2014 at 05:43:57PM -0800, Paul E. McKenney wrote:
> On Mon, Feb 17, 2014 at 05:23:18PM -0800, Josh Triplett wrote:
> > On Mon, Feb 17, 2014 at 04:58:02PM -0800, Paul E. McKenney wrote:
> > > On Mon, Feb 17, 2014 at 04:26:06PM -0800, Josh Triplett wrote:
> >
On Mon, Feb 17, 2014 at 05:21:37PM -0800, Paul E. McKenney wrote:
> On Mon, Feb 17, 2014 at 04:45:11PM -0800, Josh Triplett wrote:
> > On Mon, Feb 17, 2014 at 04:17:40PM -0800, Paul E. McKenney wrote:
> > > On Mon, Feb 17, 2014 at 04:02:47PM -0800, Josh Triplett wrote:
> >
On Mon, Feb 17, 2014 at 04:58:02PM -0800, Paul E. McKenney wrote:
> On Mon, Feb 17, 2014 at 04:26:06PM -0800, Josh Triplett wrote:
> > On Mon, Feb 17, 2014 at 02:12:23PM -0800, Paul E. McKenney wrote:
> > > From: "Paul E. McKenney"
> > >
> > &g
On Mon, Feb 17, 2014 at 04:41:45PM -0800, Josh Triplett wrote:
> On Mon, Feb 17, 2014 at 02:12:31PM -0800, Paul E. McKenney wrote:
> > Hello!
> >
> > This series contains rcutorture changes, including adding a simple
> > locktorture. Creating this locktorture w
On Mon, Feb 17, 2014 at 04:17:40PM -0800, Paul E. McKenney wrote:
> On Mon, Feb 17, 2014 at 04:02:47PM -0800, Josh Triplett wrote:
> > On Mon, Feb 17, 2014 at 02:58:16PM -0800, Paul E. McKenney wrote:
> > > On Mon, Feb 17, 2014 at 01:46:06PM -0800, Josh Triplett wrote:
> >
19, 21, 35, and 37.
This series also appears to be missing patches numbered 12, 16, 18, 26,
38, 39, 43, and 53. (In some cases those patch numbers appear above but
the corresponding patches don't appear in subsequent mails; in other
cases those numbers appear missing above as well.)
For the re
lert("%s" TORTURE_FLAG "!!! %s\n", torture_type,
> s); } while (0)
This change is also unrelated, and should not occur in this commit.
- Josh Triplett
> /* Definitions for a non-string torture-test module parameter. */
> #define torture_parm(type, name, init, msg) \
On Mon, Feb 17, 2014 at 02:12:39PM -0800, Paul E. McKenney wrote:
> From: "Paul E. McKenney"
>
> Not all of the rcutorture kthreads waited for kthread_should_stop()
> before returning from their top-level functions, and none of them
> used torture_shutdown_absorb() properly. These problems can r
y
Assuming this doesn't go away (which I really hope it does), this needs
to occur *before* the introduction of the macros using these variables.
- Josh Triplett
> include/linux/torture.h | 4
> kernel/rcu/rcutorture.c | 8 ++--
> 2 files changed, 10 insertions(+), 2 de
On Mon, Feb 17, 2014 at 04:22:48PM -0800, Paul E. McKenney wrote:
> On Mon, Feb 17, 2014 at 04:11:37PM -0800, Josh Triplett wrote:
> > On Mon, Feb 17, 2014 at 02:12:19PM -0800, Paul E. McKenney wrote:
> > > From: "Paul E. McKenney"
> > >
> > > Be
e macros
that reference an out-of-macro variable). Ideally all of these could go
away in favor of pr_fmt, and then the individual calls to them would
become pr_alert, pr_debug, pr_error, or similar.
- Josh Triplett
> include/linux/torture.h | 8
> kernel/rcu/rcutorture.c | 8 --
MODULE_PARM_DESC" turns up numerous instances of the pattern. You
might consider adding this as a helper DECLARE_MODULE_PARAM_RO in
include/linux/moduleparam.h (possibly calling a generalized version that
takes the mode as another parameter).
- Josh Triplett
--
To unsubscribe from this list:
random generation
infrastructure, as something like "fast_insecure_nonblocking_random"?
That seems more generally useful.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
On Mon, Feb 17, 2014 at 03:05:11PM -0800, Paul E. McKenney wrote:
> On Mon, Feb 17, 2014 at 02:00:15PM -0800, Josh Triplett wrote:
> > On Mon, Feb 17, 2014 at 01:35:56PM -0800, Paul E. McKenney wrote:
> > > From: "Paul E. McKenney"
> > >
> > > (Trivi
On Mon, Feb 17, 2014 at 02:58:16PM -0800, Paul E. McKenney wrote:
> On Mon, Feb 17, 2014 at 01:46:06PM -0800, Josh Triplett wrote:
> > On Mon, Feb 17, 2014 at 01:26:52PM -0800, Paul E. McKenney wrote:
> > > From: "Paul E. McKenney"
> > >
> > > Curren
gt;
> 7.Disambiguate CONFIG_RCU_NOCB_CPUs, courtesy of Paul Bolle.
>
> 8.Move SRCU work to power-efficient workqueue, courtesy of
> Shaibal Dutta.
>
> 9-12. Downgrade rcu_dereference_raw() to rcu_access_pointer() in
> case
ning to wonder if this common pattern ought to have an
rcu_pointer_is_null(), which would not return the pointer, only the
boolean.
Regardless, for this patch:
Reviewed-by: Josh Triplett
> fs/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/file.c b/fs/file.c
&
quite accurate; they're
static, and in the header, and the compiler is likely to inline the
no-op versions, but they're not actually marked as inline. The commit
message should just say that it turns the implementations into no-ops.
> Signed-off-by: Paul E. McKenney
Reviewed-by: Josh
e creates a static inline
> implementation of rcu_needs_cpu() that unconditionally returns false
> when CONFIG_RCU_NOCB_CPU_ALL=y.
>
> Signed-off-by: Paul E. McKenney
Reviewed-by: Josh Triplett
> ---
> include/linux/rcupdate.h | 9 +
> include/linux/rcutiny
e creates a static inline
> implementation of rcu_is_nocb_cpu() that unconditionally returns
> true when CONFIG_RCU_NOCB_CPU_ALL=y.
>
> Signed-off-by: Paul E. McKenney
One suggestion below. With or without that change:
Reviewed-by: Josh Triplett
> include/linux/rcupdate.h | 4
On Mon, Feb 17, 2014 at 01:26:52PM -0800, Paul E. McKenney wrote:
> From: "Paul E. McKenney"
>
> Current compilers can "speculate" stores in the case where both legs
> of the "if" statement start with identical stores. Because the stores
> are identical, the compiler knows that the store will un
rs, most notably when the exact same store is
> at the beginning of both the then-clause and the else-clause.
> Document this.
>
> 6.Fixups to RTFP.txt
I've replied to 1, 2, and 5 with comments. For 3, 4, and 6:
Reviewed-by: Josh Triplett
--
To unsubscribe from th
Signed-off-by: Paul E. McKenney
Punctuation nit below; otherwise:
Reviewed-by: Josh Triplett
> Documentation/memory-barriers.txt | 17 +
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/memory-barriers.txt
> b/Documentation/memory-barriers.txt
>
s safety mechanism can be useful,
> it is no substitute for users of call_rcu() having rate-limit controls
> in place. This commit adds this nuance to the documentation.
>
> Reported-by: "Michael S. Tsirkin"
> Reported-by: Gleb Natapov
> Signed-off-by: Paul E. McKenney
erman
> Signed-off-by: Levente Kurusa
Reviewed-by: Josh Triplett
> drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c
> b/drivers/staging/media/davi
On Tue, Feb 11, 2014 at 03:34:49PM +0800, Dongsheng Yang wrote:
> Signed-off-by: Dongsheng Yang
> cc: Josh Triplett
> cc: "Paul E. McKenney"
> cc: Peter Zijlstra
> cc: Ingo Molnar
Reviewed-by: Josh Triplett
> kernel/rcu/torture.c | 8
> 1 f
vious prototype for ‘sys32_quotactl’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/linux/syscalls.h |5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
>
s prototype for
> ‘bio_integrity_tag_size’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> Some of the API functions like bio_integrity_tag_size appears to be
> entirely unused. Such occurences should be pruned because they haven't
>
callback_stop’
> [-Wmissing-prototypes]
> fs/dlm/ast.c:284:6: warning: no previous prototype for ‘dlm_callback_suspend’
> [-Wmissing-prototypes]
> fs/dlm/ast.c:292:6: warning: no previous prototype for ‘dlm_callback_resume’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika K
s prototype for
> ‘bio_integrity_tag’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> fs/bio-integrity.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> index 0bad24d..51
conflicting definitions when CONFIG_XEN_PVHVM is not defined.
>
> This eliminates the following warning in xen/events/events_base.c:
> drivers/xen/events/events_base.c:1640:6: warning: no previous prototype for
> ‘xen_callback_vector’ [-Wmissing-prototypes]
>
> Signed-off-by: Rash
s]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> net/sunrpc/svc_xprt.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index 80a6640..06c6ff0 100644
> --- a/net/sunrp
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> net/netfilter/nft_lookup.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/netfilter/nft_lookup.c b/net/netfilter/nft_lookup.c
> index 8a6116b..bb4ef4c 100644
> --- a/net/netfilter/nft_loo
On Sun, Feb 09, 2014 at 01:37:20AM +0530, Rashika Kheria wrote:
> Move prototype declaration of function to header file
> include/net/net_namespace.h from net/ipx/af_ipx.c because they are used
> by more than one file.
>
> This eliminates the following warning in net/ipx/sysctl_net_ipx.c:
> net/ip
et/ipx/pe2.c:20:24: warning: no previous prototype for ‘make_EII_client’
> [-Wmissing-prototypes]
> net/ipx/pe2.c:32:6: warning: no previous prototype for ‘destroy_EII_client’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include
us prototype for ‘ipxrtr_ioctl’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/net/ipx.h |8
> net/ipx/af_ipx.c |9 -
> 2 files changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/include/
> net/decnet/sysctl_net_decnet.c:354:6: warning: no previous prototype for
> ‘dn_register_sysctl’ [-Wmissing-prototypes]
> net/decnet/sysctl_net_decnet.c:359:6: warning: no previous prototype for
> ‘dn_unregister_sysctl’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheri
m’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/net/ipx.h |3 +++
> net/ipx/ipx_route.c |4
> 2 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/include/net/ipx.h b/include/net/ipx.h
> index 9e9
On Sun, Feb 09, 2014 at 01:25:05AM +0530, Rashika Kheria wrote:
> Mark function as static in core/filter.c because it is not used outside
> this file.
>
> This eliminates the following warning in core/filter.c:
> net/core/filter.c:48:7: warning: no previous prototype for
> ‘bpf_internal_load_poin
> net/decnet/dn_route.c:629:5: warning: no previous prototype for
> ‘dn_route_rcv’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> include/net/dn_route.h |2 ++
> net/decnet/af_decnet.c |2 --
> 2 files changed, 2 insertions(+
_dev_queue_xmit’
> [-Wmissing-prototypes]
> net/core/dev.c:4640:5: warning: no previous prototype for
> ‘netdev_adjacent_sysfs_add’ [-Wmissing-prototypes]
> net/core/dev.c:4650:6: warning: no previous prototype for
> ‘netdev_adjacent_sysfs_del’ [-Wmissing-prototypes]
>
> Signed-off-by
net/caif/cfsrvl.c:198:6: warning: no previous prototype for
> ‘caif_free_client’ [-Wmissing-prototypes]
> net/caif/cfsrvl.c:208:6: warning: no previous prototype for
> ‘caif_client_register_refcnt’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Tripl
v.c:
> net/caif/caif_dev.c:303:6: warning: no previous prototype for
> ‘caif_enroll_dev’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> net/caif/caif_dev.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/caif/caif_dev.
‘p9_fcall_alloc’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> net/9p/client.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/9p/client.c b/net/9p/client.c
> index a5e4d2d..9186550 100644
> ---
s prototype for
> ‘blk_throtl_dispatch_work_fn’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> block/blk-throttle.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 14
kdev_issue_zeroout’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> block/blk-lib.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-lib.c b/block/blk-lib.c
> index 2da76c9..332e7a9 100644
> ---
On Fri, Feb 07, 2014 at 05:02:02PM -0800, David Rientjes wrote:
> On Fri, 7 Feb 2014, Josh Triplett wrote:
>
> > > Why?? If CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID then, yes, we need it to be
> > > global. Otherwise it's perfectly fine just being static in file s
ine int __early_pfn_to_nid(unsigned long pfn)
> {
> return 0;
> }
> #else
> /* please see mm/page_alloc.c */
> extern int __meminit early_pfn_to_nid(unsigned long pfn);
> #ifdef CONFIG_HAVE_ARCH_EARLY_PFN_TO_NID
> /* th
ter to just declare the __early_pfn_to_nid() in
> mm/page_alloc.c to be static?
Won't that break the ability to override that function in
architecture-specific code (as arch/ia64/mm/numa.c does)?
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu
On Fri, Feb 07, 2014 at 05:22:58PM +, David Laight wrote:
> From: Josh Triplett
> > On Fri, Feb 07, 2014 at 01:33:46PM +, David Laight wrote:
> > > From: Rashika Kheria
> > > > Move prototype declarations of function to header file
> > > > hardware
s2_mixer.c:62:1: warning: no previous prototype for ‘mix_write’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> sound/oss/pas2.h |3 +++
> sound/oss/pas2_card.c |2 --
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
>
-by: Rashika Kheria
Reviewed-by: Josh Triplett
> sound/pci/lx6464es/lx_core.c | 84
> --
> 1 file changed, 84 deletions(-)
>
> diff --git a/sound/pci/lx6464es/lx_core.c b/sound/pci/lx6464es/lx_core.c
> index 626ecad..df4044d 100644
csp_input.c:110:5: warning: no previous prototype for
> ‘pcspkr_input_remove’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> sound/drivers/pcsp/pcsp_input.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/drivers/
Absolutely, but as far as I can tell Rashika is doing this
incrementally, organized more by header than by source file, so I'd
expect a few externs in a source file to disappear at a time rather than
all in one patch.
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, Jan 24, 2014 at 04:14:00AM +0530, Rashika Kheria wrote:
> Mark functions as static in bpctl_mod.c because they are not used
> outside this file. Remove unused function from bpctl_mod.c.
>
[...]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
--
To unsubs
ism) could
> still result in a warning.
That would actually *not* produce a warning, though it should. In
general, I *think* an implementation like Sparse's that ignores the
distinction between locks should produce false negatives but not false
positives.
- Josh Triplett
--
To unsubscribe
ented?
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59856
Also:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=59855
- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
t;active_timers == 0,
> courtesy of Oleg Nesterov.
For all five patches in v3:
Reviewed-by: Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
rn 1;
> + }
> +#endif /* #ifdef CONFIG_NO_HZ_FULL */
> + return 0;
> +}
In a function with return type "bool", please use true/false, not 1/0.
Please also document the semantic of the return value.
- Josh Triplett
--
To unsubscribe from this list: send the line
s a bit
> strange because we still update ->all_timers for no reason.
There's an easy way to improve this: instead of using an ifdef, put
"IS_ENABLED(CONFIG_NO_HZ_FULL) && " in the if condition.
- Josh Triplett
--
To unsubscribe from this list: send the line "
On Tue, Jan 14, 2014 at 09:56:53PM +0100, Michal Marek wrote:
> Dne 3.1.2014 22:00, Josh Triplett napsal(a):
> > On Fri, Jan 03, 2014 at 09:55:16PM +0100, Michal Marek wrote:
> >> On 3.1.2014 21:29, Josh Triplett wrote:
> >>> Please feel free to take the entire series
On Sun, Jan 12, 2014 at 11:14:56AM -0500, Patrick Palka wrote:
> On Mon, Jan 6, 2014 at 3:47 PM, Josh Triplett wrote:
> > Does anyone have any objection to the use of "#pragma once" instead of
> > the usual #ifndef-#define-...-#endif include guard? GCC, LLVM/clang,
>
evice.c:281:6: warning: no previous
> > prototype for ‘radeon_doorbell_fini’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
> > Reviewed-by: Josh Triplett
>
> I've pulled in a subset of these patches:
> http://cgit.freedesktop.org/~agd5f/linux/log/?h=drm-
_du_update_layout’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
> > Reviewed-by: Josh Triplett
> > ---
> > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 12 ++--
> > 1 file changed, 6 insertions(+), 6 deletions(-)
>
>
> This and pat
On Tue, Jan 07, 2014 at 10:48:53AM +0100, Geert Uytterhoeven wrote:
> On Tue, Jan 7, 2014 at 6:55 AM, Sam Ravnborg wrote:
> > On Mon, Jan 06, 2014 at 12:47:07PM -0800, Josh Triplett wrote:
> >> [CCing build-system folks and others likely to know about potential
> >> iss
Documentation/CodingStyle means
> that it will become hard to defend the few legitimate uses of ifndef
> guards against people who have a printed copy of checkpatch.pl under
> their pillow.
Any mention in CodingStyle or check in checkpatch would need to cover
the two exceptions: uapi, an
On Mon, Jan 06, 2014 at 01:00:03PM -0800, Andrew Morton wrote:
> On Mon, 6 Jan 2014 12:47:07 -0800 Josh Triplett wrote:
>
> > Does anyone have any objection to the use of "#pragma once" instead of
> > the usual #ifndef-#define-...-#endif include guard?
>
> S
[CCing build-system folks and others likely to know about potential
issues.]
Does anyone have any objection to the use of "#pragma once" instead of
the usual #ifndef-#define-...-#endif include guard? GCC, LLVM/clang,
and the latest Sparse all support either method just fine. (I added
support to
On Mon, Jan 06, 2014 at 04:48:39PM +0900, Alexandre Courbot wrote:
> On Sat, Jan 4, 2014 at 5:22 AM, Josh Triplett wrote:
> > On Fri, Jan 03, 2014 at 08:07:22PM +0900, Alexandre Courbot wrote:
> >> On Thu, Jan 2, 2014 at 10:07 PM, Linus Walleij
> >> wrote:
> >
minates the following warning in debugfs.c:
> > drivers/acpi/debugfs.c:16:13: warning: no previous prototype for
> > ‘acpi_debugfs_init’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria
> > Reviewed-by: Josh Triplett
> > ---
> > drivers/acpi
On Fri, Jan 03, 2014 at 09:55:16PM +0100, Michal Marek wrote:
> On 3.1.2014 21:29, Josh Triplett wrote:
> > Please feel free to take the entire series through your tree; I received
> > some maintainer acks, but no indications that the patches are going
> > through their trees.
On Fri, Jan 03, 2014 at 05:40:52PM +0100, Michal Marek wrote:
> On 2013-12-23 22:56, Josh Triplett wrote:
> > GCC 4.9 and newer have a new warning -Wdate-time, which warns on any use
> > of __DATE__, __TIME__, or __TIMESTAMP__, which would make the build
> > non-deterministic.
is also quite telling.
In any case, it's disappointing to have a pile of unused functions in
the kernel on the theory that they *might* be needed; it's not like it'd
be hard to retrieve them from git if they're ever needed.
However, if you're insistent on keeping them, it'
On Thu, Jan 02, 2014 at 11:57:27PM -0800, Paul E. McKenney wrote:
> On Thu, Jan 02, 2014 at 09:47:00PM -0800, Josh Triplett wrote:
> > On Thu, Jan 02, 2014 at 09:14:17PM -0800, Paul E. McKenney wrote:
> > > On Thu, Jan 02, 2014 at 07:39:07PM -0800, Josh Triplett wrote:
> >
On Thu, Jan 02, 2014 at 09:14:17PM -0800, Paul E. McKenney wrote:
> On Thu, Jan 02, 2014 at 07:39:07PM -0800, Josh Triplett wrote:
> > On Thu, Jan 02, 2014 at 12:33:20PM -0800, Paul E. McKenney wrote:
> > > Hello!
> > >
> > > From what I can see, the Linux-
en answer
> is "Inquiring programming-language memory-model designers want
> to know."
I find myself wondering about the original form of the question, since
I'd hope that programming-languge memory-model designers would
understand the need for synchronization ar
s in the process.
Thanks,
Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Thu, Dec 26, 2013 at 12:07:23PM -0800, Josh Triplett wrote:
> On Thu, Dec 26, 2013 at 11:20:28AM -0800, Joe Perches wrote:
> > Kernel style uses function pointers in this form:
> > "type (*funcptr)(args...)"
> >
> > Emit warnings when
if so.
>
> Signed-off-by: Joe Perches
Reviewed-by: Josh Triplett
> scripts/checkpatch.pl | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index db72b88..c12234e 100755
> --- a/scripts/checkpatch.
On Thu, Dec 26, 2013 at 11:20:29AM -0800, Joe Perches wrote:
> Add the ability to fix and overwrite existing files/patches instead
> of creating a new file ".EXPERIMENTAL-checkpatch-fixes".
>
> Suggested-by: Manfred Spraul
> Signed-off-by: Joe Perches
Reviewed-by: J
ry space after function pointer
> name\n" . $herecurr);
> + }
> +
> +# unnecessary space "type (*funcptr) (args...)"
> + if (defined $pre_args_space &&
> + $pre_args_space =~ /^\s/) {
> +
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.
Signed-off-by: Josh Triplett
---
drivers/net/wireless/brcm80211/brcmfmac/dhd_common.c | 7 ---
1
ned-off-by: Josh Triplett
---
arch/x86/math-emu/errors.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
index 59d353d..a544908 100644
--- a/arch/x86/math-emu/errors.c
+++ b/arch/x86/math-emu/errors.c
@@ -330,11 +330,6 @@ asmli
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.
Signed-off-by: Josh Triplett
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 -
1 file chang
(optionally) records this information at build time
in a single place; other kernel code should not duplicate that.
Signed-off-by: Josh Triplett
---
Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile b/Makefile
index 14d592c..188eea7 100644
--- a/Makefile
+++ b/Makefile
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __TIME__,
which makes the build non-deterministic. (And, without __DATE__,
__TIME__ provided little useful information to begin with.)
Signed-off-by: Josh Tri
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.
Signed-off-by: Josh Triplett
---
drivers/staging/wlags49_h2/wl_version.h | 4
1 file chang
The kernel already has this information, and individual drivers
shouldn't duplicate that. This also eliminates the use of __DATE__ and
__TIME__, which make the build non-deterministic.
Signed-off-by: Josh Triplett
---
drivers/mtd/nand/denali_pci.c | 1 -
1 file changed, 1 deletion(-)
rototype for
> ‘PropagateCalParamsFromEEPROMToMemory’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/bcm/nvm.c | 61
> -
> 1 file changed, 61 deletions(-)
>
> diff --git a/drivers/staging/bcm/nvm.c
s’
> [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by: Josh Triplett
> drivers/staging/bcm/Qos.c |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
> index 1609a2
p/dgap_parse.c:1252:7: warning: no previous prototype for
> ‘dgap_create_config_string’ [-Wmissing-prototypes]
> drivers/staging/dgap/dgap_parse.c:1311:7: warning: no previous prototype for
> ‘dgap_get_config_letters’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Reviewed-by:
701 - 800 of 1376 matches
Mail list logo
