diff --git a/Documentation/sysctl/vm.txt b/Documentation/sysctl/vm.txt
index 078701f..308fd77 100644
--- a/Documentation/sysctl/vm.txt
+++ b/Documentation/sysctl/vm.txt
@@ -640,6 +640,9 @@ swappiness
This control is used to define how aggressive the kernel will swap
memory pages. Higher
swapping even if there is a swap storage
+available. This might lead to memcg OOM killer if there are no file
+pages to reclaim.
Pretty good to me. Thank you!
Acked-by: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Mon, Oct 15, 2012 at 11:58 PM, David Rientjes rient...@google.com wrote:
On Mon, 15 Oct 2012, KOSAKI Motohiro wrote:
I don't think 80de7c3138ee9fd86a98696fd2cf7ad89b995d0a is right fix.
It's certainly not a complete fix, but I think it's a much better result
of the race, i.e. we don't
tjes
> CC: Andrew Morton
> Signed-off-by: Yasuaki Ishimatsu
Acked-by: KOSAKI Motohiro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info
Rientjes rient...@google.com
CC: Andrew Morton a...@linux-foundation.org
Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
Acked-by: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
st optimization and does not fix any problem.
>
> CC: David Rientjes
> CC: Jiang Liu
> CC: Len Brown
> CC: Christoph Lameter
> Cc: Minchan Kim
> CC: Andrew Morton
> CC: KOSAKI Motohiro
> CC: Wen Congyang
> Signed-off-by: Yasuaki Ishimatsu
> ---
> mm/memory_hot
>>> -static int acpi_memory_disable_device(struct acpi_memory_device
>>> *mem_device)
>>> +static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
>>> {
>>> int result;
>>> struct acpi_memory_info *info, *n;
>>>
>>> + list_for_each_entry_safe(info, n,
On Mon, Oct 8, 2012 at 2:47 AM, Wen Congyang wrote:
> At 10/06/2012 02:56 AM, KOSAKI Motohiro Wrote:
>> On Wed, Oct 3, 2012 at 6:11 AM, Yasuaki Ishimatsu
>> wrote:
>>> From: Wen Congyang
>>>
>>> The memory device has only one node id. Store the node id
On Mon, Oct 8, 2012 at 2:45 AM, Wen Congyang wrote:
> At 10/05/2012 05:31 AM, KOSAKI Motohiro Wrote:
>> On Wed, Oct 3, 2012 at 6:02 AM, Yasuaki Ishimatsu
>> wrote:
>>> From: Yasuaki Ishimatsu
>>>
>>> add_memory() hot adds a physical memory. But remov
k runs. So, add a bit more documentation
> about it, and add a little KERN_NOTICE. It should help developers
> who are chasing down reclaim-related bugs.
>
> [mho...@suse.cz: refreshed to current -mm tree]
> Signed-off-by: Dave Hansen
> Reviewed-by: KAMEZAWA Hiroyuki
> Ac
bugs.
[mho...@suse.cz: refreshed to current -mm tree]
Signed-off-by: Dave Hansen d...@linux.vnet.ibm.com
Reviewed-by: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com
Acked-by: Michal Hocko mho...@suse.cz
Looks fine.
Acked-by: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
--
To unsubscribe
On Mon, Oct 8, 2012 at 2:45 AM, Wen Congyang we...@cn.fujitsu.com wrote:
At 10/05/2012 05:31 AM, KOSAKI Motohiro Wrote:
On Wed, Oct 3, 2012 at 6:02 AM, Yasuaki Ishimatsu
isimatu.yasu...@jp.fujitsu.com wrote:
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
add_memory() hot adds
On Mon, Oct 8, 2012 at 2:47 AM, Wen Congyang we...@cn.fujitsu.com wrote:
At 10/06/2012 02:56 AM, KOSAKI Motohiro Wrote:
On Wed, Oct 3, 2012 at 6:11 AM, Yasuaki Ishimatsu
isimatu.yasu...@jp.fujitsu.com wrote:
From: Wen Congyang we...@cn.fujitsu.com
The memory device has only one node id
-static int acpi_memory_disable_device(struct acpi_memory_device
*mem_device)
+static int acpi_memory_remove_memory(struct acpi_memory_device *mem_device)
{
int result;
struct acpi_memory_info *info, *n;
+ list_for_each_entry_safe(info, n, mem_device-res_list, list)
is just optimization and does not fix any problem.
CC: David Rientjes rient...@google.com
CC: Jiang Liu liu...@gmail.com
CC: Len Brown len.br...@intel.com
CC: Christoph Lameter c...@linux.com
Cc: Minchan Kim minchan@gmail.com
CC: Andrew Morton a...@linux-foundation.org
CC: KOSAKI Motohiro
all in such a case.
>
> Signed-off-by: Michal Hocko
> Acked-by: David Rientjes
> Cc: stable [3.5+]
Acked-by: KOSAKI Motohiro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordom
de
> struct is part of node_devices[] array and it cannot be freed by
> node_device_release(). So if system reuses the node struct, it has a garbage.
>
> CC: David Rientjes
> CC: Jiang Liu
> Cc: Minchan Kim
> CC: Andrew Morton
> CC: KOSAKI Motohiro
> Signed-off-by: Yasuaki
ease function is prepared as a means
> to free a memory_block struct.
>
> CC: David Rientjes
> CC: Jiang Liu
> Cc: Minchan Kim
> CC: Andrew Morton
> CC: KOSAKI Motohiro
> CC: Wen Congyang
> Signed-off-by: Yasuaki Ishimatsu
Acked-by: KOSAKI Motohiro
--
To unsubsc
to free a memory_block struct.
CC: David Rientjes rient...@google.com
CC: Jiang Liu liu...@gmail.com
Cc: Minchan Kim minchan@gmail.com
CC: Andrew Morton a...@linux-foundation.org
CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
CC: Wen Congyang we...@cn.fujitsu.com
Signed-off
[] array and it cannot be freed by
node_device_release(). So if system reuses the node struct, it has a garbage.
CC: David Rientjes rient...@google.com
CC: Jiang Liu liu...@gmail.com
Cc: Minchan Kim minchan@gmail.com
CC: Andrew Morton a...@linux-foundation.org
CC: KOSAKI Motohiro
Acked-by: David Rientjes rient...@google.com
Cc: stable [3.5+]
Acked-by: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Jiang Liu
> CC: Len Brown
> CC: Christoph Lameter
> Cc: Minchan Kim
> CC: Andrew Morton
> CC: KOSAKI Motohiro
> Signed-off-by: Wen Congyang
> Signed-off-by: Yasuaki Ishimatsu
>
> ---
> drivers/firmware/memmap.c| 98
> +++
heck.
> CC: David Rientjes
> CC: Jiang Liu
> CC: Len Brown
> CC: Christoph Lameter
> Cc: Minchan Kim
> CC: Andrew Morton
> CC: KOSAKI Motohiro
> Signed-off-by: Wen Congyang
> Signed-off-by: Yasuaki Ishimatsu
>
> ---
> drivers/base/memory.c | 39 ++
> Known problems:
> 1. memory can't be offlined when CONFIG_MEMCG is selected.
>For example: there is a memory device on node 1. The address range
>is [1G, 1.5G). You will find 4 new directories memory8, memory9, memory10,
>and memory11 under the directory /sys/devices/system/memory/.
On Wed, Oct 3, 2012 at 6:11 AM, Yasuaki Ishimatsu
wrote:
> From: Wen Congyang
>
> The memory device has only one node id. Store the node id when
> enable the memory device, and we can reuse it when removing the
> memory device.
You don't explain why we need this. Then nobody can review nor ack.
On Wed, Oct 3, 2012 at 6:09 AM, Yasuaki Ishimatsu
wrote:
> From: Yasuaki Ishimatsu
>
> For hot removing physical memory, the patch adds remove_memory() into
> acpi_memory_remove_memory(). But we cannot support physical memory
> hot remove. So remove_memory() do nothinig.
I don't understand this
> I have the reason to have to fill the node struct with 0 by memset.
> The node is a part of node struct array (node_devices[]).
> If we add empty release function for suppressing warning,
> some data remains in the node struct after hot removing memory.
> So if we re-hot adds the memory, the
I have the reason to have to fill the node struct with 0 by memset.
The node is a part of node struct array (node_devices[]).
If we add empty release function for suppressing warning,
some data remains in the node struct after hot removing memory.
So if we re-hot adds the memory, the node
On Wed, Oct 3, 2012 at 6:09 AM, Yasuaki Ishimatsu
isimatu.yasu...@jp.fujitsu.com wrote:
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
For hot removing physical memory, the patch adds remove_memory() into
acpi_memory_remove_memory(). But we cannot support physical memory
hot remove.
On Wed, Oct 3, 2012 at 6:11 AM, Yasuaki Ishimatsu
isimatu.yasu...@jp.fujitsu.com wrote:
From: Wen Congyang we...@cn.fujitsu.com
The memory device has only one node id. Store the node id when
enable the memory device, and we can reuse it when removing the
memory device.
You don't explain why
Known problems:
1. memory can't be offlined when CONFIG_MEMCG is selected.
For example: there is a memory device on node 1. The address range
is [1G, 1.5G). You will find 4 new directories memory8, memory9, memory10,
and memory11 under the directory /sys/devices/system/memory/.
need the check.
CC: David Rientjes rient...@google.com
CC: Jiang Liu liu...@gmail.com
CC: Len Brown len.br...@intel.com
CC: Christoph Lameter c...@linux.com
Cc: Minchan Kim minchan@gmail.com
CC: Andrew Morton a...@linux-foundation.org
CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
...@google.com
CC: Jiang Liu liu...@gmail.com
CC: Len Brown len.br...@intel.com
CC: Christoph Lameter c...@linux.com
Cc: Minchan Kim minchan@gmail.com
CC: Andrew Morton a...@linux-foundation.org
CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
y() to offline_memory(). We will
> use rename_memory() for hot removing memory.
>
> CC: David Rientjes
> CC: Jiang Liu
> CC: Len Brown
> CC: Christoph Lameter
> Cc: Minchan Kim
> CC: Andrew Morton
> CC: KOSAKI Motohiro
> Signed-off-by: Yasuaki Ishimatsu
&
CC: Jiang Liu
> CC: Len Brown
> CC: Christoph Lameter
> Cc: Minchan Kim
> CC: Andrew Morton
> CC: KOSAKI Motohiro
> Signed-off-by: Yasuaki Ishimatsu
> Signed-off-by: Wen Congyang
> ---
> drivers/acpi/acpi_memhotplug.c | 44
> +++
: Len Brown len.br...@intel.com
CC: Christoph Lameter c...@linux.com
Cc: Minchan Kim minchan@gmail.com
CC: Andrew Morton a...@linux-foundation.org
CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
Signed-off-by: Wen Congyang
: Andrew Morton a...@linux-foundation.org
CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
Signed-off-by: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
---
drivers/acpi/acpi_memhotplug.c |2 +-
include/linux/memory_hotplug.h |2 +-
mm
v = p;
>
> - seq_printf(m, "0x%p-0x%p %7ld",
> + seq_printf(m, "0x%pK-0x%pK %7ld",
> v->addr, v->addr + v->size, v->size);
Looks good.
Acked-by: KOSAKI Motohiro
--
To unsubscribe from this list: send the line "unsubscribe
>> Then, you introduced bisect breakage. It is definitely unacceptable.
>
> What is "bisect breakage" meaning?
Think what's happen when only applying path [1/21].
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
On Mon, Oct 1, 2012 at 8:34 PM, Ni zhan Chen wrote:
> On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote:
>>
>> From: Wen Congyang
>>
>> The function acpi_bus_remove() can remove a acpi device from acpi device.
>
> IIUC, s/acpi device/acpi bus
IIUC, acpi_bus_remove() mean "remove the device
On Mon, Oct 1, 2012 at 8:34 PM, Ni zhan Chen nizhan.c...@gmail.com wrote:
On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote:
From: Wen Congyang we...@cn.fujitsu.com
The function acpi_bus_remove() can remove a acpi device from acpi device.
IIUC, s/acpi device/acpi bus
IIUC,
Then, you introduced bisect breakage. It is definitely unacceptable.
What is bisect breakage meaning?
Think what's happen when only applying path [1/21].
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
;
- seq_printf(m, 0x%p-0x%p %7ld,
+ seq_printf(m, 0x%pK-0x%pK %7ld,
v-addr, v-addr + v-size, v-size);
Looks good.
Acked-by: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
On Mon, Oct 1, 2012 at 2:54 AM, Yasuaki Ishimatsu
wrote:
> Hi Kosaki-san,
>
>
> 2012/09/29 7:19, KOSAKI Motohiro wrote:
>>>>>
>>>>> I don't understand it. How can we get rid of the warning?
>>>>
>>>>
>>>> See
On Mon, Oct 1, 2012 at 2:54 AM, Yasuaki Ishimatsu
isimatu.yasu...@jp.fujitsu.com wrote:
Hi Kosaki-san,
2012/09/29 7:19, KOSAKI Motohiro wrote:
I don't understand it. How can we get rid of the warning?
See cpu_device_release() for example.
If we implement a function like
> It is not correct. The kobject_put() is prepared against find_memory_block()
> in remove_memory_block() since kobject->kref is incremented in it.
> So release_memory_block() is called by device_unregister() correctly as
> follows:
Ok. Looks good then.
Please rewrite the description more kindly
On Fri, Sep 28, 2012 at 3:19 AM, Lai Jiangshan wrote:
> HI, Christoph, KOSAKI
>
> SLAB always allocates kmem_list3 for all nodes(N_HIGH_MEMORY), also node
> bug/bad things happens.
> SLUB always requires kmem_cache_node on the correct node, so these fix is
> needed.
>
> SLAB uses
On Thu, Sep 27, 2012 at 11:50 PM, Yasuaki Ishimatsu
wrote:
> Hi Chen,
>
>
> 2012/09/28 11:22, Ni zhan Chen wrote:
>>
>> On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote:
>>>
>>> From: Yasuaki Ishimatsu
>>>
>>> remove_memory() only try to offline pages. It is called in two cases:
>>> 1. hot
>>> I don't understand it. How can we get rid of the warning?
>>
>> See cpu_device_release() for example.
>
> If we implement a function like cpu_device_release(), the warning
> disappears. But the comment says in the function "Never copy this way...".
> So I think it is illegal way.
What does
I don't understand it. How can we get rid of the warning?
See cpu_device_release() for example.
If we implement a function like cpu_device_release(), the warning
disappears. But the comment says in the function Never copy this way
So I think it is illegal way.
What does illegal mean?
On Thu, Sep 27, 2012 at 11:50 PM, Yasuaki Ishimatsu
isimatu.yasu...@jp.fujitsu.com wrote:
Hi Chen,
2012/09/28 11:22, Ni zhan Chen wrote:
On 09/05/2012 05:25 PM, we...@cn.fujitsu.com wrote:
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
remove_memory() only try to offline pages.
On Fri, Sep 28, 2012 at 3:19 AM, Lai Jiangshan la...@cn.fujitsu.com wrote:
HI, Christoph, KOSAKI
SLAB always allocates kmem_list3 for all nodes(N_HIGH_MEMORY), also node
bug/bad things happens.
SLUB always requires kmem_cache_node on the correct node, so these fix is
needed.
SLAB uses
It is not correct. The kobject_put() is prepared against find_memory_block()
in remove_memory_block() since kobject-kref is incremented in it.
So release_memory_block() is called by device_unregister() correctly as
follows:
Ok. Looks good then.
Please rewrite the description more kindly at
>> Moreover, your explanation is still insufficient. Even if
>> node_device_release() is empty function, we can get rid of the
>> warning.
>
>
> I don't understand it. How can we get rid of the warning?
See cpu_device_release() for example.
>> Why do we need this node_device_release()
On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu
wrote:
> Hi Chen,
>
>
> 2012/09/27 19:20, Ni zhan Chen wrote:
>>
>> Hi Congyang,
>>
>> 2012/9/27
>>
>>> From: Yasuaki Ishimatsu
>>>
>>> When calling remove_memory_block(), the function shows following message
>>> at
>>> device_release().
>>>
On Thu, Sep 27, 2012 at 8:07 PM, Yasuaki Ishimatsu
wrote:
> Hi Kosaki-san,
>
>
> 2012/09/28 5:13, KOSAKI Motohiro wrote:
>>
>> On Thu, Sep 27, 2012 at 1:45 AM, wrote:
>>>
>>> From: Yasuaki Ishimatsu
>>>
>>> When cal
(9/27/12 2:47 AM), Lai Jiangshan wrote:
> The __add_zone() maybe call sleep-able init_currently_empty_zone()
> to init wait_table,
This doesn't explain why sleepable is critical important. I think sleepable
is jsut unrelated. The fact is only: to write zone->zone_start_pfn require
(9/27/12 2:47 AM), Lai Jiangshan wrote:
> SLUB only fucus on the nodes which has normal memory, so ignore the other
> node's hot-adding and hot-removing.
>
> Aka: if some memroy of a node(which has no onlined memory) is online,
> but this new memory onlined is not normal memory(HIGH memory
(9/27/12 2:47 AM), Lai Jiangshan wrote:
> Currently memory_hotplug only manages the node_states[N_HIGH_MEMORY],
> it forgets to manage node_states[N_NORMAL_MEMORY]. it causes
> node_states[N_NORMAL_MEMORY] becomes stale.
What's mean 'stale'? I guess
: Currently memory_hotplug doesn't turn on/off
> auto offline page_cgroup when onlining memory block failed.
>
> CC: David Rientjes
> CC: Jiang Liu
> CC: Len Brown
> CC: Benjamin Herrenschmidt
> CC: Paul Mackerras
> Cc: Minchan Kim
> CC: Andrew Morton
> CC: KOSAKI Motohiro
> CC: Yasuaki Ishimatsu
>
On Thu, Sep 27, 2012 at 1:45 AM, wrote:
> From: Wen Congyang
>
> hwpoisoned may set when we offline a page by the sysfs interface
> /sys/devices/system/memory/soft_offline_page or
> /sys/devices/system/memory/hard_offline_page. If we don't clear
> this flag when onlining pages, this page can't
On Thu, Sep 27, 2012 at 1:45 AM, wrote:
> From: Yasuaki Ishimatsu
>
> When calling unregister_node(), the function shows following message at
> device_release().
This description doesn't have the "following message".
> Device 'node2' does not have a release() function, it is broken and must
ng Liu
> CC: Len Brown
> CC: Benjamin Herrenschmidt
> CC: Paul Mackerras
> Cc: Minchan Kim
> CC: Andrew Morton
> CC: KOSAKI Motohiro
> CC: Wen Congyang
> Signed-off-by: Yasuaki Ishimatsu
> ---
> drivers/base/memory.c |9 -
> 1 files changed, 8 insert
CC: Jiang Liu liu...@gmail.com
CC: Len Brown len.br...@intel.com
CC: Benjamin Herrenschmidt b...@kernel.crashing.org
CC: Paul Mackerras pau...@samba.org
Cc: Minchan Kim minchan@gmail.com
CC: Andrew Morton a...@linux-foundation.org
CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
CC
On Thu, Sep 27, 2012 at 1:45 AM, we...@cn.fujitsu.com wrote:
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
When calling unregister_node(), the function shows following message at
device_release().
This description doesn't have the following message.
Device 'node2' does not have a
On Thu, Sep 27, 2012 at 1:45 AM, we...@cn.fujitsu.com wrote:
From: Wen Congyang we...@cn.fujitsu.com
hwpoisoned may set when we offline a page by the sysfs interface
/sys/devices/system/memory/soft_offline_page or
/sys/devices/system/memory/hard_offline_page. If we don't clear
this flag
CC: Andrew Morton a...@linux-foundation.org
CC: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
CC: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
---
mm/page_cgroup.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git
(9/27/12 2:47 AM), Lai Jiangshan wrote:
Currently memory_hotplug only manages the node_states[N_HIGH_MEMORY],
it forgets to manage node_states[N_NORMAL_MEMORY]. it causes
node_states[N_NORMAL_MEMORY] becomes stale.
What's mean 'stale'? I guess
: Currently memory_hotplug doesn't turn on/off
(9/27/12 2:47 AM), Lai Jiangshan wrote:
SLUB only fucus on the nodes which has normal memory, so ignore the other
node's hot-adding and hot-removing.
Aka: if some memroy of a node(which has no onlined memory) is online,
but this new memory onlined is not normal memory(HIGH memory example),
(9/27/12 2:47 AM), Lai Jiangshan wrote:
The __add_zone() maybe call sleep-able init_currently_empty_zone()
to init wait_table,
This doesn't explain why sleepable is critical important. I think sleepable
is jsut unrelated. The fact is only: to write zone-zone_start_pfn require
On Thu, Sep 27, 2012 at 8:07 PM, Yasuaki Ishimatsu
isimatu.yasu...@jp.fujitsu.com wrote:
Hi Kosaki-san,
2012/09/28 5:13, KOSAKI Motohiro wrote:
On Thu, Sep 27, 2012 at 1:45 AM, we...@cn.fujitsu.com wrote:
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
When calling
On Thu, Sep 27, 2012 at 8:24 PM, Yasuaki Ishimatsu
isimatu.yasu...@jp.fujitsu.com wrote:
Hi Chen,
2012/09/27 19:20, Ni zhan Chen wrote:
Hi Congyang,
2012/9/27 we...@cn.fujitsu.com
From: Yasuaki Ishimatsu isimatu.yasu...@jp.fujitsu.com
When calling remove_memory_block(), the function
Moreover, your explanation is still insufficient. Even if
node_device_release() is empty function, we can get rid of the
warning.
I don't understand it. How can we get rid of the warning?
See cpu_device_release() for example.
Why do we need this node_device_release() implementation?
I
On Tue, Sep 25, 2012 at 1:05 PM, Naoya Horiguchi
wrote:
> On Tue, Sep 25, 2012 at 11:59:51AM -0400, KOSAKI Motohiro wrote:
>> On Tue, Sep 25, 2012 at 9:56 AM, Naoya Horiguchi
>> wrote:
>> > KPF_THP can be set on non-huge compound pages like slab pages, because
>>
On Tue, Sep 25, 2012 at 9:56 AM, Naoya Horiguchi
wrote:
> KPF_THP can be set on non-huge compound pages like slab pages, because
> PageTransCompound only sees PG_head and PG_tail. Obviously this is a bug
> and breaks user space applications which look for thp via /proc/kpageflags.
> Currently thp
On Tue, Sep 25, 2012 at 9:56 AM, Naoya Horiguchi
n-horigu...@ah.jp.nec.com wrote:
KPF_THP can be set on non-huge compound pages like slab pages, because
PageTransCompound only sees PG_head and PG_tail. Obviously this is a bug
and breaks user space applications which look for thp via
On Tue, Sep 25, 2012 at 1:05 PM, Naoya Horiguchi
n-horigu...@ah.jp.nec.com wrote:
On Tue, Sep 25, 2012 at 11:59:51AM -0400, KOSAKI Motohiro wrote:
On Tue, Sep 25, 2012 at 9:56 AM, Naoya Horiguchi
n-horigu...@ah.jp.nec.com wrote:
KPF_THP can be set on non-huge compound pages like slab pages
On Wed, Sep 19, 2012 at 7:51 PM, Minchan Kim wrote:
> On Wed, Sep 19, 2012 at 02:28:10PM -0400, Johannes Weiner wrote:
>> On Wed, Sep 19, 2012 at 01:04:56PM -0400, KOSAKI Motohiro wrote:
>> > On Wed, Sep 19, 2012 at 3:45 AM, Minchan Kim wrote:
>> > > When I looked
On Wed, Sep 19, 2012 at 7:51 PM, Minchan Kim minc...@kernel.org wrote:
On Wed, Sep 19, 2012 at 02:28:10PM -0400, Johannes Weiner wrote:
On Wed, Sep 19, 2012 at 01:04:56PM -0400, KOSAKI Motohiro wrote:
On Wed, Sep 19, 2012 at 3:45 AM, Minchan Kim minc...@kernel.org wrote:
When I looked
On Wed, Sep 19, 2012 at 3:29 AM, Minchan Kim wrote:
> During memory-hotplug stress test, I found NR_ISOLATED_[ANON|FILE]
> are increasing so that kernel are hang out.
>
> The cause is that when we do memory-hotadd after memory-remove,
> __zone_pcp_update clear out zone's ZONE_STAT_ITEMS in
On Wed, Sep 19, 2012 at 3:45 AM, Minchan Kim wrote:
> When I looked at zone stat mismatch problem, I found
> migrate_to_node doesn't decrease NR_ISOLATED_[ANON|FILE]
> if check_range fails.
>
> It can make system hang out.
>
> Cc: KOSAKI Motohiro
> Cc: Mel Gorman
On Wed, Sep 19, 2012 at 3:45 AM, Minchan Kim minc...@kernel.org wrote:
When I looked at zone stat mismatch problem, I found
migrate_to_node doesn't decrease NR_ISOLATED_[ANON|FILE]
if check_range fails.
It can make system hang out.
Cc: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
Cc: Mel
On Wed, Sep 19, 2012 at 3:29 AM, Minchan Kim minc...@kernel.org wrote:
During memory-hotplug stress test, I found NR_ISOLATED_[ANON|FILE]
are increasing so that kernel are hang out.
The cause is that when we do memory-hotadd after memory-remove,
__zone_pcp_update clear out zone's
(9/17/12 1:55 PM), Tejun Heo wrote:
> (cc'ing Jens)
>
> On Mon, Sep 17, 2012 at 09:22:28AM -0400, Steven Rostedt wrote:
>> On Mon, 2012-09-17 at 19:33 +0800, Jianpeng Ma wrote:
>>> Hi all:
>>> I used blktrace to trace some io.But i can't find requests merge. I
>>> searched the code and did't
(9/17/12 1:55 PM), Tejun Heo wrote:
(cc'ing Jens)
On Mon, Sep 17, 2012 at 09:22:28AM -0400, Steven Rostedt wrote:
On Mon, 2012-09-17 at 19:33 +0800, Jianpeng Ma wrote:
Hi all:
I used blktrace to trace some io.But i can't find requests merge. I
searched the code and did't not find.
>> I've seen the exactly same patch from another fujitsu guys several
>> month ago. and as I pointed
>> out at that time, this line don't work when 32bit kernel + mmap2 syscall
>> case.
>>
>> Please don't think do_mmap_pgoff() is for mmap(2) specific and read a
>> past thread before resend
>> a
race occurs, alloc_pages_vma() falls in 'goto
> retry_cpuset' path, decrements the reference count and frees the policy
> prematurely.
>
> Signed-off-by: KOSAKI Motohiro
> Signed-off-by: Mel Gorman
> ---
> mm/mempolicy.c | 12 +++-
> 1 files changed, 11 insertion
en on this approach because it partially duplicates sp_alloc(). As
> the paths were sp->lock is taken are not that performance critical this
> patch converts sp->lock to sp->mutex so it can sleep when calling sp_alloc().
Looks make sense.
Acked-by: KOSAKI Motohiro
--
To unsubscribe from t
t;Test Pass: Error at mmap: %s\n", strerror(errno));
> return 0;
> }
>
> if (pa == MAP_FAILED)
> perror("Test FAIL: expect EOVERFLOW but get other error");
> else
> printf("Test FAIL : Expect EOVERFLOW bu
no error\n);
close(fd);
munmap(pa, len);
return 1;
Cc: Andrew Morton a...@linux-foundation.org
Cc: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
Cc: linux...@kvack.org (open list:MEMORY MANAGEMENT)
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
mm/mmap.c | 5
duplicates sp_alloc(). As
the paths were sp-lock is taken are not that performance critical this
patch converts sp-lock to sp-mutex so it can sleep when calling sp_alloc().
Looks make sense.
Acked-by: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
--
To unsubscribe from this list: send the line
, decrements the reference count and frees the policy
prematurely.
Signed-off-by: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
Signed-off-by: Mel Gorman mgor...@suse.de
---
mm/mempolicy.c | 12 +++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/mm/mempolicy.c b
I've seen the exactly same patch from another fujitsu guys several
month ago. and as I pointed
out at that time, this line don't work when 32bit kernel + mmap2 syscall
case.
Please don't think do_mmap_pgoff() is for mmap(2) specific and read a
past thread before resend
a patch.
So,
On 7/31/2012 8:33 AM, Josh Boyer wrote:
> On Mon, Jun 11, 2012 at 5:17 AM, wrote:
>> From: KOSAKI Motohiro
>>
>> Hi
>>
>> This is trivial fixes of mempolicy meory corruption issues. There
>> are independent patches each ather. and, they don't change userla
On 7/31/2012 8:33 AM, Josh Boyer wrote:
On Mon, Jun 11, 2012 at 5:17 AM, kosaki.motoh...@gmail.com wrote:
From: KOSAKI Motohiro kosaki.motoh...@jp.fujitsu.com
Hi
This is trivial fixes of mempolicy meory corruption issues. There
are independent patches each ather. and, they don't change
> Please, what's wrong with the patch below, to replace the current
> two or three? I don't have real NUMA myself: does it work?
> If it doesn't work, can you see why not?
It works. It doesn't match my preference. but I don't want block your way.
this area is maintained you. please go ahead.
at
Please, what's wrong with the patch below, to replace the current
two or three? I don't have real NUMA myself: does it work?
If it doesn't work, can you see why not?
It works. It doesn't match my preference. but I don't want block your way.
this area is maintained you. please go ahead.
at
Hi
Fujitsu machine can't boot too.
my bisect indicate git-sched.patch cause regression too.
Thanks.
> 25-rc2-mm1 is hanging early in boot on my HP ia64 numa platform. I saw
> the "Strange hang on ia64 with CONFIG_PRINTK_TIME=y" thread on lkml:
>
>
> > > > Can you change the spec?
> > >
> > > Not really. It will break all existing codes.
> >
> > I meant as in eg. submit changes to MPI-3
>
> MPI spec tries to be backward compatible. And MPI-2 spec is 10 years
> old, but MPI-1 is still in a wider use. HPC is moving fast in terms of HW
>
Can you change the spec?
Not really. It will break all existing codes.
I meant as in eg. submit changes to MPI-3
MPI spec tries to be backward compatible. And MPI-2 spec is 10 years
old, but MPI-1 is still in a wider use. HPC is moving fast in terms of HW
technology, but slow in
601 - 700 of 949 matches
Mail list logo