RE: [PATCH v1 1/1] i2c: drivers: Use generic definitions for bus frequencies (part 2)

Thanks. Acked-by: Khalil Blaiech > -Original Message- > From: Andy Shevchenko > Sent: Monday, March 22, 2021 12:54 PM > To: Wolfram Sang ; Khalil Blaiech ; > Loic Poulain ; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-arm-...@vger.kernel.org > C

RE: [PATCH] i2c: mlxbf: select CONFIG_I2C_SLAVE

mp; ARM64 > + select I2C_SLAVE > help >Enabling this option will add I2C SMBus support for Mellanox > BlueField >system. > -- > 2.27.0 Thank you! Acked-by: Khalil Blaiech

RE: [PATCH] i2c: mlxbf: Fix an error pointer vs NULL check

> In case of error, the function devm_ioremap() returns NULL pointer not > ERR_PTR(). The IS_ERR() test in the return value check should be > replaced with NULL test. > > Signed-off-by: Xu Wang Thank you very much for your patch. Please note that previous patch has been posted to address this

RE: [PATCH] i2c: mlxbf: Fix build error with CONFIG_ACPI disabled

Liu, thank you very much for the fix. Please note that I posted a patch series on October, 28th including this fix. Also note that I posted a v2 today. Khalil > Subject: [PATCH] i2c: mlxbf: Fix build error with CONFIG_ACPI disabled > > drivers/i2c/busses/i2c-mlxbf.c: In function ‘mlxbf_i2c_acp