Re: [PATCH 06/19] dt-bindings: power: rpmpd: Add QCS8300 power domains

2024-09-05 Thread Konrad Dybcio
On 5.09.2024 1:30 PM, Konrad Dybcio wrote: > On 4.09.2024 10:33 AM, Jingyi Wang wrote: >> From: Shazad Hussain >> >> Add compatible and constants for the power domains exposed by the RPMH >> in the Qualcomm QCS8300 platform. >> >> Signed-off-by: Shazad H

Re: [PATCH 06/19] dt-bindings: power: rpmpd: Add QCS8300 power domains

2024-09-05 Thread Konrad Dybcio
On 4.09.2024 10:33 AM, Jingyi Wang wrote: > From: Shazad Hussain > > Add compatible and constants for the power domains exposed by the RPMH > in the Qualcomm QCS8300 platform. > > Signed-off-by: Shazad Hussain > Signed-off-by: Tingguo Cheng > Signed-off-by: Jingyi Wang > --- > .../devicetree

Re: [PATCH v2 1/5] Revert "soc: qcom: smd-rpm: Match rpmsg channel instead of compatible"

2024-08-29 Thread Konrad Dybcio
t; Revert the commit bcabe1e09135 ("soc: qcom: smd-rpm: Match rpmsg channel > instead of compatible") > > Fixes: bcabe1e09135 ("soc: qcom: smd-rpm: Match rpmsg channel instead of > compatible") > Cc: sta...@vger.kernel.org > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 0/3] Add DisplayPort sound support for Fairphone 5 smartphone

2024-08-10 Thread Konrad Dybcio
On 9.08.2024 10:33 AM, Luca Weiss wrote: > Add the necessary sound card bits and some dts additions to enable sound > over DisplayPort-over-USB-C, e.g. to a connected TV or monitor. > > The UCM files can be found here: > https://gitlab.com/postmarketOS/pmaports/-/tree/master/device/testing/device-

Re: [PATCH v2 4/5] ARM: dts: qcom: add generic compat string to RPM glink channels

2024-07-30 Thread Konrad Dybcio
On 29.07.2024 9:52 PM, Dmitry Baryshkov wrote: > Add the generic qcom,smd-rpm compatible to RPM nodes to follow the > schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 5/5] arm64: dts: qcom: add generic compat string to RPM glink channels

2024-07-30 Thread Konrad Dybcio
On 29.07.2024 9:52 PM, Dmitry Baryshkov wrote: > Add the generic qcom,smd-rpm / qcom,glink-smd-rpm compatible to RPM > nodes to follow the schema. > > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 01/11] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button

2024-07-29 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > The Pro1X has a flip keyboard and a single-state camera button. > > Signed-off-by: Dang Huynh > --- [...] > > &tlmm { > gpio-reserved-ranges = <0 4>, <14 4>; > + > + hall_sensor_n: hall-sensor-n { These must end in -state to pass binding

Re: [PATCH v2 06/11] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > Fxtec Pro1x uses the same display (BOE BF060Y8M-AJ0) as Pro1. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 05/11] arm64: dts: qcom: sm6115-pro1x: Enable SD card slot

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > Fxtec Pro1X has two card slots and allow either 2xSIM cards or > 1xSIM, 1xSD Card configuration. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 04/11] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED

2024-07-25 Thread Konrad Dybcio
On 25.07.2024 3:42 AM, Dang Huynh wrote: > The Pro1X has a caps lock LED on the keyboard. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 11/11] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN

2024-07-25 Thread Konrad Dybcio
0 > fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HL.3.2.4-00982-QCAHLSWMTPLZ-1 > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Add touch keys

2024-07-24 Thread Konrad Dybcio
message and keep a link to the previous one & a changelog under the --- line in this instance, don't bother as it's a simple change and it looks good now Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:39 PM, Raymond Hackley wrote: >> Fixes? >> >> Konrad > > Hi Konrad, > > the issue is not reported or discussed on lkml, so there is no thread to fix? See the "In case your patch fixes a bug.." paragraph in: https://docs.kernel.org/process/submitting-patches.html > > Regards, >

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-rossa: Add touchscreen

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:15 PM, Raymond Hackley wrote: > Core Prime uses an Imagis IST3038 touchscreen that is connected to > blsp_i2c5. Add it to the device tree. > > Signed-off-by: Raymond Hackley > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-fortuna: Enable the touchkeys

2024-07-23 Thread Konrad Dybcio
On 23.07.2024 3:12 PM, Raymond Hackley wrote: > The phone needs the touchkeys to be enabled so the sense lines of the > touch controller are mapped properly. Otherwise the touchscreen is not > mapped to the display properly. > > Signed-off-by: Raymond Hackley > --- Fixes? Konrad

Re: [PATCH v3 7/9] dt-bindings: interconnect: qcom: msm8939: Fix example

2024-07-23 Thread Konrad Dybcio
On 9.07.2024 12:22 PM, Adam Skladowski wrote: > For now example list snoc_mm as children of bimc which is obviously > not valid, drop bimc and move snoc_mm into snoc. > > Signed-off-by: Adam Skladowski > --- loool, thanks Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 11/12] arm64: dts: qcom: sm6115-pro1x: Enable remoteprocs

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > Enable [A,C]DSP and MPSS remote processor on this device. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 09/12] arm64: dts: qcom: sm6115-pro1x: Add PMI632 Type-C property

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The USB-C port is used for powering external devices and transfer > data from/to them. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konradqmpphy_out { > + remote-endpoint = <&pmi632_ss_in>; > +}; &

Re: [PATCH 07/12] arm64: dts: qcom: sm6115-pro1x: Hook up USB3 SS

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The F(x)tec Pro1X supports USB 3.0 through it's USB-C port. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 06/12] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 11:17 AM, Dang Huynh wrote: >>> +&mdss_dsi0_phy { >>> + status = "okay"; >> >> No power supplies? >> >> Konrad > > Doesn't seem to be defined anywhere on downstream, may be hardware controlled. my downstream suggests L1b Konrad

Re: [PATCH 12/12] arm64: dts: qcom: sm6115-pro1x: Enable ATH10K WLAN

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > Enable onboard Wi-Fi on the F(x)tec Pro1X. > > For reference, HW/SW identifies as: > qmi chip_id 0x120 chip_family 0x4007 board_id 0xff soc_id 0x4067 > qmi fw_version 0x324103d6 fw_build_timestamp 2021-12-02 08:20 > fw_build_id QC_IMAGE_VERSION_STRING

Re: [PATCH 10/12] arm64: dts: qcom: sm6115-pro1x: Enable RGB LED

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > This device has an RGB LED. It is used for notifications. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 06/12] arm64: dts: qcom: sm6115-pro1x: Enable MDSS and GPU

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > Fxtec Pro1x uses the same display (BOE BF060Y8M-AJ0) as Pro1. > > Signed-off-by: Dang Huynh > --- [...] > + panel: panel@0 { > + compatible = "boe,bf060y8m-aj0"; > + reg = <0>; > + > + reset-gpios = <&tlmm 82 GP

Re: [PATCH 04/12] arm64: dts: qcom: sm6115-pro1x: Add Caps Lock LED

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The Pro1X has a caps lock LED on the keyboard. > > Signed-off-by: Dang Huynh > --- > arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts

Re: [PATCH 03/12] arm64: dts: qcom: sm6115-pro1x: Add Goodix Touchscreen

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The Fxtec Pro1X touchscreen uses Goodix GT9286 chip. > > Signed-off-by: Dang Huynh > --- > arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 49 > + > 1 file changed, 49 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/s

Re: [PATCH 02/12] arm64: dts: qcom: sm6115-pro1x: Add PCA9534 IO Expander

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > F(x)tec Pro1X comes with PCA9534 IO Expander, it is used for enabling > touch screen VDD/VDDIO and keyboard's caps lock LED. > > Signed-off-by: Dang Huynh > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 01/12] arm64: dts: qcom: sm6115-pro1x: Add Hall Switch and Camera Button

2024-07-22 Thread Konrad Dybcio
On 22.07.2024 9:10 AM, Dang Huynh wrote: > The Pro1X has a flip keyboard and a single-state camera button. > > Signed-off-by: Dang Huynh > --- > arch/arm64/boot/dts/qcom/sm6115-fxtec-pro1x.dts | 33 > +++-- > 1 file changed, 31 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH] arm64: dts: qcom: msm8916-samsung-grandmax: Add touchscreen

2024-07-15 Thread Konrad Dybcio
<1280>; > + > + vdd-supply = <®_vdd_tsp_a>; > + vddio-supply = <&pm8916_l6>; > + > + pinctrl-0 = <&ts_int_default>; > + pinctrl-names = "default"; > + > + linux,keycodes = ; > + }; > +}; > + > ®_motor_vdd { > gpio = <&tlmm 72 GPIO_ACTIVE_HIGH>; > }; > > ®_touch_key { > - status = "disabled"; > + status = "disabled"; /* Using Imagis touch key*/ key */ Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v4 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-07-09 Thread Konrad Dybcio
ither both the regions have to be used or only mpss_dsm_mem has > to be used. Also, reduce the size of mpssadsp_mem region. > > Signed-off-by: Naina Mehta > --- Thanks Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: sm7225-fairphone-fp4: Name the regulators

2024-06-29 Thread Konrad Dybcio
> Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/2] ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

2024-06-29 Thread Konrad Dybcio
= <330>; >> +}; > > This is the vibration motor? Use "vibrator" as node name then as per > https://github.com/devicetree-org/devicetree-specification/blob/main/source/chapter2-devicetree-basics.rst?plain=1#L299 With that: Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH V3 1/2] soc: qcom: smp2p: Use devname for interrupt descriptions

2024-06-29 Thread Konrad Dybcio
_set_irq_type(struct irq_data *irqd, > unsigned int type) > return 0; > } > > +static void smp2p_irq_print_chip(struct irq_data *irqd, struct seq_file *p) > +{ > + struct smp2p_entry *entry = irq_data_get_irq_chip_data(irqd); > + > + seq_printf(p, " %8s", dev_name(entry->smp2p->dev)); Not sure if the number is necessary but as you wish Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] soc: qcom: smsm: Add missing mailbox dependency to Kconfig

2024-06-29 Thread Konrad Dybcio
smsm: Support using mailbox interface") > Reported-by: kernel test robot > Closes: > https://lore.kernel.org/oe-kbuild-all/202406180006.z397c67h-...@intel.com/ > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 2/3] arm64: dts: qcom: msm8916-lg-m216: Add initial device tree

2024-06-26 Thread Konrad Dybcio
eter > - Touchscreen > - Sound and modem > - Haptic > > Signed-off-by: Cristian Cozzolino > [Nikita: Minor cleanup] > Signed-off-by: Nikita Travkin > --- That touchscreen binding could use some YAMLing Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/3] arm64: dts: qcom: msm8916-lg-c50: add initial dts for LG Leon LTE

2024-06-26 Thread Konrad Dybcio
f-by: Anton Bambura > Signed-off-by: Nikita Travkin > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-06-26 Thread Konrad Dybcio
On 24.06.2024 1:21 PM, Naina Mehta wrote: > > > On 6/18/2024 7:08 PM, Konrad Dybcio wrote: >> >> >> On 6/18/24 15:13, Naina Mehta wrote: >>> Rename qdss@8880 memory region as qlink_logging memory region >>> and add qdss_mem memory region at addr

Re: [PATCH 7/7] ARM: dts: qcom: msm8226: Convert APCS usages to mbox interface

2024-06-22 Thread Konrad Dybcio
On 19.06.2024 11:02 PM, Luca Weiss wrote: > Since we now have the apcs set up as a mailbox provider, let's use the > interface for all drivers where possible. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 6/7] ARM: dts: qcom: msm8226: Hook up CPU cooling

2024-06-22 Thread Konrad Dybcio
On 19.06.2024 11:02 PM, Luca Weiss wrote: > Add cooling-maps for the CPU thermal zones so the driver can actually do > something when the CPU temperature rises too much. > > Signed-off-by: Luca Weiss > --- Very cool, thanks Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 5/7] ARM: dts: qcom: msm8226: Add CPU frequency scaling support

2024-06-22 Thread Konrad Dybcio
On 19.06.2024 11:02 PM, Luca Weiss wrote: > Add a node for the a7pll with its frequencies. With this we can use the > apcs-kpss-global driver for the apcs node and use the apcs to scale the > CPU frequency according to the opp-table. > > At the same time unfortunately we need to provide the gcc no

Re: [PATCH v2 3/3] ARM: dts: qcom: msm8974-sony-shinano: increase load on l21 for sdhc2

2024-06-22 Thread Konrad Dybcio
igned-off-by: Valeriy Klimin > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/3] ARM: dts: qcom: Add Sony Xperia Z3 Compact smartphone

2024-06-22 Thread Konrad Dybcio
On 21.06.2024 4:26 PM, Valeriy Klimin wrote: > Add the dts for the Z3 Compact. This is currently almost the same > as the plain Z3 as they share almost the same hardware and > nothing device-specific is currently supported. > > Signed-off-by: Valeriy Klimin > --- Reviewed

Re: [PATCH 0/5] Use mboxes in smsm node for all dtsi where possible

2024-06-19 Thread Konrad Dybcio
Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 2/2] arm64: dts: qcom: qcm6490-shift-otter: Name the regulators

2024-06-18 Thread Konrad Dybcio
--- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 3/5] arm64: dts: qcom: sdx75: update reserved memory regions for mpss

2024-06-18 Thread Konrad Dybcio
On 6/18/24 15:13, Naina Mehta wrote: Rename qdss@8880 memory region as qlink_logging memory region and add qdss_mem memory region at address of 0x8850. Split mpss_dsmharq_mem region into 2 separate regions and reduce the size of mpssadsp_mem region. Signed-off-by: Naina Mehta --- A

Re: [PATCH 1/2] arm64: dts: qcom: qcm6490-fairphone-fp5: Name the regulators

2024-06-18 Thread Konrad Dybcio
--- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 3/3] ARM: dts: qcom: msm8926-motorola-peregrine: Add framebuffer supplies

2024-06-18 Thread Konrad Dybcio
On 6/17/24 23:22, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add regulators used by the framebuffer of Motorola Moto G 4G (2013). Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/3] ARM: dts: qcom: msm8926-motorola-peregrine: Update temperature sensor

2024-06-18 Thread Konrad Dybcio
On 6/17/24 23:22, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add alert interrupt for the temperature sensor of Motorola Moto G 4G (2013), although not used by the driver yet. Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 1/3] ARM: dts: qcom: msm8926-motorola-peregrine: Add accelerometer, magnetometer, regulator

2024-06-18 Thread Konrad Dybcio
On 6/17/24 23:22, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add the accelerometer, magnetometer and regulator that are present on the Motorola Moto G 4G (2013) device. Signed-off-by: André Apitzsch --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] ARM: dts: qcom: msm8926-motorola-peregrine: Add accelerometer, magnetometer, regulator

2024-06-17 Thread Konrad Dybcio
On 6/16/24 16:15, André Apitzsch via B4 Relay wrote: From: André Apitzsch Add the accelerometer, magnetometer and regulator that are present on the Motorola Moto G 4G (2013) device. While at it, update framebuffer supplies and temperature sensor. That's a bit too much for a "while at it"

Re: [PATCH v2 3/5] arm64: dts: qcom: sdx75: add missing qlink_logging reserved memory for mpss

2024-06-17 Thread Konrad Dybcio
On 6/17/24 11:34, Naina Mehta wrote: The qlink_logging memory region is also used by the modem firmware, add it to reserved memory regions. Also split MPSS DSM region into 2 separate regions. Signed-off-by: Naina Mehta --- The commit message is very misleading.. You're not adding qlink_log

Re: [PATCH] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer

2024-06-13 Thread Konrad Dybcio
On 6/13/24 19:18, Stanislav Jakubek wrote: On Thu, Jun 13, 2024 at 09:48:26AM +0200, Konrad Dybcio wrote: On 6/9/24 13:05, Stanislav Jakubek wrote: Add the accelerometer and magnetometer that are present on the Motorola Moto G (2013) device. Signed-off-by: Stanislav Jakubek

Re: [PATCH] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer

2024-06-13 Thread Konrad Dybcio
On 6/9/24 13:05, Stanislav Jakubek wrote: Add the accelerometer and magnetometer that are present on the Motorola Moto G (2013) device. Signed-off-by: Stanislav Jakubek --- [...] +&blsp1_i2c2 { Consider setting a clock-frequency = <> With that: Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: qcm6490-fairphone-fp5: Use .mbn firmware for IPA

2024-06-06 Thread Konrad Dybcio
On 6.06.2024 11:09 AM, Luca Weiss wrote: > Specify the file name for the squashed/non-split firmware with the .mbn > extension instead of the split .mdt. The kernel can load both but the > squashed version is preferred in dts nowadays. > > Signed-off-by: Luca Weiss > --- R

Re: [PATCH 2/2] ARM: dts: qcom: Add initial support for HTC One (M8)

2024-06-04 Thread Konrad Dybcio
--- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 1/3] arm64: dts: qcom: pm7250b: Add node for PMIC VBUS booster

2024-05-31 Thread Konrad Dybcio
On 30.05.2024 5:05 PM, Luca Weiss wrote: > Add the required DTS node for the USB VBUS output regulator, which is > available on PM7250B. This will provide the VBUS source to connected > peripherals. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Luca Weiss > ---

Re: [PATCH 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document the SA8775p ADSP, CDSP and GPDSP

2024-05-29 Thread Konrad Dybcio
On 22.05.2024 3:08 PM, Bartosz Golaszewski wrote: > On Wed, May 22, 2024 at 3:06 PM wrote: >> >> On 22/05/2024 15:04, Bartosz Golaszewski wrote: >>> On Wed, May 22, 2024 at 2:42 PM wrote: On 22/05/2024 14:08, Bartosz Golaszewski wrote: > From: Tengfei Fan > > Document the c

Re: [PATCH 6/7] arm64: dts: qcom: msm8976: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 7/7] arm64: dts: qcom: msm8994: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:24, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 5/7] arm64: dts: qcom: msm8953: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 4/7] arm64: dts: qcom: msm8939: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/7] arm64: dts: qcom: msm8916: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 2/7] ARM: dts: qcom: msm8974: Use mboxes properties for APCS

2024-04-24 Thread Konrad Dybcio
On 4/24/24 18:23, Luca Weiss wrote: Instead of passing the syscon to the various nodes, use the mbox interface using the mboxes property. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH RFC 2/2] soc: qcom: smsm: Support using mailbox interface

2024-04-24 Thread Konrad Dybcio
syscon. Signed-off-by: Luca Weiss --- Looks good! Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3 4/4] arm64: dts: qcom: msm8976: Add WCNSS node

2024-04-23 Thread Konrad Dybcio
On 4/13/24 19:03, Adam Skladowski wrote: Add node describing wireless connectivity subsystem. Signed-off-by: Adam Skladowski --- [...] + wcnss_wifi: wifi { + compatible = "qcom,wcnss-wlan"; + +

Re: [PATCH v3 3/4] arm64: dts: qcom: msm8976: Add Adreno GPU

2024-04-23 Thread Konrad Dybcio
On 4/13/24 19:03, Adam Skladowski wrote: Add Adreno GPU node. Signed-off-by: Adam Skladowski --- [...] + opp-2 { + opp-hz = /bits/ 64 <2>; + required-opps = <&rpmpd_o

Re: [PATCH v3 2/4] arm64: dts: qcom: msm8976: Add MDSS nodes

2024-04-23 Thread Konrad Dybcio
On 4/13/24 19:03, Adam Skladowski wrote: Add MDSS nodes to support displays on MSM8976 SoC. Signed-off-by: Adam Skladowski --- [...] + + mdp_opp_table: opp-table { + compatible = "operating-points-v2"; + +

Re: [PATCH v2 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Enable USB role switching

2024-04-23 Thread Konrad Dybcio
x27;t get messed with and we can charge the phone with at least some amount of power. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio nits: + usb-role-switch; this is a common property of the dwc3 host [...] vdda-phy-supply = <&vreg_l22a>;

Re: [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator

2024-04-22 Thread Konrad Dybcio
On 4/18/24 12:03, Luca Weiss wrote: On Thu Apr 18, 2024 at 12:01 PM CEST, Konrad Dybcio wrote: On 18.04.2024 8:36 AM, Luca Weiss wrote: Add a node for the vibrator module found inside the PMI632. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio On a side note, this is a

Re: [PATCH v2 3/3] arm64: dts: msm8996: add fastrpc nodes

2024-04-18 Thread Konrad Dybcio
On 18.04.2024 8:44 AM, Dmitry Baryshkov wrote: > From: Srinivas Kandagatla > > The ADSP provides fastrpc/compute capabilities. Enable support for the > fastrpc on this DSP. > > Signed-off-by: Srinivas Kandagatla > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] arm64: dts: qcom: pmi632: Add vibrator

2024-04-18 Thread Konrad Dybcio
On 18.04.2024 8:36 AM, Luca Weiss wrote: > Add a node for the vibrator module found inside the PMI632. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio On a side note, this is a totally configuration-free peripheral that doesn't do anything crazy until manuall

Re: [PATCH] rpmsg: qcom_glink_ssr: fix module autoloading

2024-04-10 Thread Konrad Dybcio
On 4/10/24 18:40, Krzysztof Kozlowski wrote: Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Krzysztof Kozlowski --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] dt-bindings: pinctrl: qcom,pmic-gpio: Allow gpio-hog nodes

2024-04-08 Thread Konrad Dybcio
On 4/8/24 18:39, Luca Weiss wrote: Allow specifying a GPIO hog, as already used on qcom-msm8974-lge-nexus5-hammerhead.dts. Signed-off-by: Luca Weiss --- .../devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml | 12 1 file changed, 12 insertions(+) diff --git a/Documenta

Re: [PATCH 1/1] clk: qcom: smd-rpm: Restore msm8976 num_clk

2024-04-02 Thread Konrad Dybcio
On 1.04.2024 7:16 PM, Adam Skladowski wrote: > During rework somehow msm8976 num_clk got removed, restore it. > > Fixes: d6edc31f3a68 ("clk: qcom: smd-rpm: Separate out interconnect bus > clocks") > Signed-off-by: Adam Skladowski > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/3] arm64: dts: msm8996: add fastrpc nodes

2024-04-02 Thread Konrad Dybcio
On 31.03.2024 11:10 PM, Dmitry Baryshkov wrote: > From: Srinivas Kandagatla > > The ADSP provides fastrpc/compute capabilities. Enable support for the > fastrpc on this DSP. > > Signed-off-by: Srinivas Kandagatla > Signed-off-by: Dmitry Baryshkov > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi

Re: [PATCH 2/3] arm64: dts: qcom: msm8996: add glink-edge nodes

2024-04-02 Thread Konrad Dybcio
0.remoteproc:glink-edge.glink_ssr.-1.-1 > 208.remoteproc:glink-edge.rpmsg_chrdev.0.0 > > adsp: > 930.remoteproc:glink-edge.LOOPBACK_CTL_LPASS.-1.-1 > 930.remoteproc:glink-edge.glink_ssr.-1.-1 > 930.remoteproc:glink-edge.rpmsg_chrdev.0.0 > > Signed-off-by: Dmitry Ba

Re: [PATCH RFT] arm64: dts: qcom: sm8350: Reenable crypto & cryptobam

2024-03-27 Thread Konrad Dybcio
On 16.02.2024 11:36 AM, Luca Weiss wrote: > On Mon Jan 8, 2024 at 11:45 PM CET, Dmitry Baryshkov wrote: >> On Mon, 8 Jan 2024 at 16:23, Luca Weiss wrote: >>> >>> On Mon Jan 8, 2024 at 3:18 PM CET, Konrad Dybcio wrote: >>>> On 8.01.2024 14:49, Luca Weiss wrot

Re: [PATCH v2 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013)

2024-03-27 Thread Konrad Dybcio
cumentation/devicetree/bindings/misc/hob_ram.txt > > Signed-off-by: Stanislav Jakubek > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013)

2024-03-26 Thread Konrad Dybcio
On 25.03.2024 9:25 PM, Stanislav Jakubek wrote: > On Mon, Mar 25, 2024 at 08:28:27PM +0100, Konrad Dybcio wrote: >> On 24.03.2024 3:04 PM, Stanislav Jakubek wrote: >>> Add a device tree for the Motorola Moto G (2013) smartphone based >>> on the Qualcomm MSM8226 SoC.

Re: [PATCH 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013)

2024-03-25 Thread Konrad Dybcio
On 24.03.2024 3:04 PM, Stanislav Jakubek wrote: > Add a device tree for the Motorola Moto G (2013) smartphone based > on the Qualcomm MSM8226 SoC. > > Initially supported features: > - Buttons (Volume Down/Up, Power) > - eMMC > - Hall Effect Sensor > - SimpleFB display > - TMP108 tempera

Re: [PATCH 4/5] arm64: dts: qcom: pm7250b: Add a TCPM description

2024-03-22 Thread Konrad Dybcio
ed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/5] arm64: dts: qcom: pm7250b: Add node for PMIC VBUS booster

2024-03-22 Thread Konrad Dybcio
On 22.03.2024 09:01, Luca Weiss wrote: > Add the required DTS node for the USB VBUS output regulator, which is > available on PM7250B. This will provide the VBUS source to connected > peripherals. > > Signed-off-by: Luca Weiss > --- > arch/arm64/boot/dts/qcom/pm7250b.dtsi | 6 ++ > 1 file ch

Re: [PATCH 2/2] ARM: dts: qcom: msm8974: Add empty chosen node

2024-03-18 Thread Konrad Dybcio
27;t add it automatically or complain about its absence at this point.. perhaps it could be taught about the latter Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] ARM: dts: qcom: msm8974: Add @0 to memory node name

2024-03-18 Thread Konrad Dybcio
gt; > Signed-off-by: Luca Weiss > --- Looks like it's indeed the start of RAM Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 3/3] ARM: dts: qcom: Add Sony Xperia Z3 smartphone

2024-03-15 Thread Konrad Dybcio
-voltage = <435>; > + qcom,auto-recharge-threshold-voltage = <428>; > + qcom,minimum-input-voltage = <420>; I took a quick look and without going deep into downstream code, these values look sane, so Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/2] ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3

2024-03-15 Thread Konrad Dybcio
On 14.03.2024 20:00, Luca Weiss wrote: > From: Adam Honse > > Add the devicetree for this "phablet" using the Snapdragon 800 SoC. > > Signed-off-by: Adam Honse > [l...@z3ntu.xyz: clean up, prepare for upstream] > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 2/2] ARM: dts: qcom: msm8974: Add Samsung Galaxy Note 3

2024-03-14 Thread Konrad Dybcio
On 3/10/24 15:13, Luca Weiss wrote: From: Adam Honse Add the devicetree for this "phablet" using the Snapdragon 800 SoC. Signed-off-by: Adam Honse [l...@z3ntu.xyz: clean up, prepare for upstream] Signed-off-by: Luca Weiss --- arch/arm/boot/dts/qcom/Makefile| 1 +

Re: [PATCH 1/3] ARM: dts: qcom: msm8974-sony-castor: Split into shinano-common

2024-03-12 Thread Konrad Dybcio
. under blsp2_i2c5) while at it ;) Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/3] ARM: dts: qcom: Add Sony Xperia Z3 smartphone

2024-03-12 Thread Konrad Dybcio
On 3/10/24 12:41, Luca Weiss wrote: Add the dts for the Xperia Z3 smartphone which is based on Sony's shinano platform, so at the moment there's little device-specific dts to add on top of the common parts. Signed-off-by: Luca Weiss --- modulo missing makfile, this looks good

Re: [PATCH v3 2/2] ARM: dts: qcom: Add support for Samsung Galaxy Tab 4 8.0 Wi-Fi

2024-03-08 Thread Konrad Dybcio
On 19.02.2024 22:43, Bryant Mairs wrote: > Add support for this tablet based on the MSM8226 SoC, codenamed > "milletwifi". > > Acked-by: Linus Walleij > Reviewed-by: Luca Weiss > Signed-off-by: Bryant Mairs > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/5] ARM: dts: qcom: msm8974pro-castor: Clean up formatting

2024-03-06 Thread Konrad Dybcio
On 3/6/24 00:18, Luca Weiss wrote: Clean up some easy things do prepare the dts for further changes. * Move pinctrl-names below pinctrl-* * Move status as last property * Remove default linux,input-type value Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/5] ARM: dts: qcom: msm8974pro-castor: Remove camera button definitions

2024-03-06 Thread Konrad Dybcio
a Weiss --- https://3dmodels.org/360-view/?id=82800 Doesn't look like! Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH] arm64: dts: qcom: sm6350: Add interconnect for MDSS

2024-02-16 Thread Konrad Dybcio
On 16.02.2024 14:11, Luca Weiss wrote: > Add the definition for the interconnect used in the display subsystem. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v3] ARM: dts: qcom: msm8974: correct qfprom node size

2024-02-12 Thread Konrad Dybcio
igned-off-by: Craig Tatlor > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/3] ARM: dts: qcom: msm8226: Sort and clean up nodes

2024-02-10 Thread Konrad Dybcio
Signed-off-by: Matti Lehtimäki [luca: add more text to commit message] Acked-by: Konrad Dybcio Signed-off-by: Luca Weiss --- Due to the nature of this change, it's hard to thoroughly review, but nothing screams nuclear breakage, so: Acked-by: Konrad Dybcio Konrad

Re: [PATCH v2 3/3] ARM: dts: qcom: msm8226: Add CPU and SAW/ACC nodes

2024-02-10 Thread Konrad Dybcio
On 2/10/24 17:28, Luca Weiss wrote: From: Ivaylo Ivanov Add CPU and SAW/ACC nodes to enable SMP on MSM8226. Signed-off-by: Ivaylo Ivanov [luca: update some nodes to fix dtbs_check errors, reorder, cleanup] Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 3/3] pmdomain: qcom: rpmpd: Add MSM8974PRO+PMA8084 power domains

2024-02-10 Thread Konrad Dybcio
On 2/10/24 17:38, Luca Weiss wrote: Add the power domains CX & GFX found on MSM8974 devices that use PMA8084 instead of the standard PM8841+PM8941 combo. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH v2 2/3] pmdomain: qcom: rpmpd: Add MSM8974+PM8841 power domains

2024-02-10 Thread Konrad Dybcio
On 2/10/24 17:38, Luca Weiss wrote: Add the power domains CX & GFX found on devices with MSM8974 and PM8841. Signed-off-by: Luca Weiss --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 3/3] pmdomain: qcom: rpmpd: Add MSM8974PRO+PMA8084 power domains

2024-02-10 Thread Konrad Dybcio
On 2/10/24 15:12, Luca Weiss wrote: Add the power domains CX & GFX found on MSM8974 devices that use PMA8084 instead of the standard PM8841+PM8941 combo. Signed-off-by: Luca Weiss --- Same comment as p2, gfx_ao may not make much sense on this platform Konrad

Re: [PATCH 2/3] pmdomain: qcom: rpmpd: Add MSM8974+PM8841 power domains

2024-02-10 Thread Konrad Dybcio
On 2/10/24 15:12, Luca Weiss wrote: Add the power domains CX & GFX found on devices with MSM8974 and PM8841. Signed-off-by: Luca Weiss --- [...] +static struct rpmpd gfx_s4b_corner_ao; +static struct rpmpd gfx_s4b_corner = { + .pd = { .name = "gfx", }, + .peer = &gfx_s4b_corn

Re: [PATCH RFC 2/2] arm64: dts: qcom: msm8953: Add GPU

2024-02-02 Thread Konrad Dybcio
On 27.01.2024 18:32, Luca Weiss wrote: > On Freitag, 26. Jänner 2024 00:50:43 CET Konrad Dybcio wrote: >> On 1/25/24 22:56, Luca Weiss wrote: >>> From: Vladimir Lypak >>> >>> Add the GPU node for the Adreno 506 found on this family of SoCs. The >>> clo

  1   2   3   4   5   6   7   8   >