Re: [PATCH] video: fbdev: xen-fbfront.c: Cleaning up useless assignment of function parameter

2014-07-08 Thread Konrad Rzeszutek Wilk
sis program called cppcheck > > > > Signed-off-by: Rickard Strandqvist > > Acked-by: Stefano Stabellini and Reviewed-by: Konrad Rzeszutek Wilk > > > > drivers/video/fbdev/xen-fbfront.c |1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a

Re: [PATCH] xen/setup: Remap Xen Identity Mapped RAM

2014-07-08 Thread Konrad Rzeszutek Wilk
On Mon, Jul 07, 2014 at 01:52:14AM -0700, Matthew Rushton wrote: > On 06/10/14 07:30, Konrad Rzeszutek Wilk wrote: > >On Thu, Jun 05, 2014 at 11:43:14AM -0700, Matt Rushton wrote: > >>Instead of ballooning up and down dom0 memory this remaps the existing mfns > >>that we

Re: [Xen-devel] [PATCH v1 1/2] genirq: Fix error path for resuming irqs

2014-07-07 Thread Konrad Rzeszutek Wilk
st for platform, a late wakeup irq, and other > instances. This change removes the function from syscore and calls it > explicitly > in suspend, hibernate, etc. > > This regression was introduced in 9bab0b7f "genirq: Add IRQF_RESUME_EARLY" > > Signed-off-by: Derek Bas

Re: [BUILD BUG][3.16-rc3] Error: too many copied sections (max = 13)

2014-07-03 Thread Konrad Rzeszutek Wilk
On Wed, Jul 02, 2014 at 02:28:36PM -0700, Andrew Morton wrote: > On Tue, 1 Jul 2014 00:09:13 -0400 Steven Rostedt wrote: > > > Testing the latest kernel (3.16-rc3) I hit this build bug: > > > > VDSO2C arch/x86/vdso/vdso-image-64.c > > Error: too many copied sections (max = 13) > > /arch/x86/v

Re: [Xen-devel] [PATCH net-next v2] xen-netback: Adding debugfs "io_ring_qX" files

2014-07-02 Thread Konrad Rzeszutek Wilk
On Wed, Jul 02, 2014 at 08:53:50PM +0100, Zoltan Kiss wrote: > This patch adds debugfs capabilities to netback. There used to be a similar > patch floating around for classic kernel, but it used procfs. It is based on a > very similar blkback patch. > It creates xen-netback/[vifname]/io_ring_q[queu

[GIT PULL] (swiotlb) stable/for-linus-3.16-rc1-tag

2014-06-27 Thread Konrad Rzeszutek Wilk
Hey Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git stable/for-linus-3.16-rc1-tag which has one bug-fix that had been in tree for quite some time. We had assumed that the physical address zero was invalid and would fail it. But that is

Re: [Patch V3 00/16] Enable support of IOAPIC hotplug on x86 platforms

2014-06-27 Thread Konrad Rzeszutek Wilk
On Wed, Jun 25, 2014 at 04:40:31PM +0800, Jiang Liu wrote: > This patch set enhances IOAPIC core and ACPI drivers to support IOAPIC > hotplug on x86 platforms. It's based on tip/x86/apic. > > You may pull it from > https://github.com/jiangliu/linux.git ioapic/hotplug_v3 fatal: Couldn't find remo

Re: [PATCH 01/11] qspinlock: A simple generic 4-byte queue spinlock

2014-06-27 Thread Konrad Rzeszutek Wilk
On Mon, Jun 23, 2014 at 06:26:22PM +0200, Peter Zijlstra wrote: > On Tue, Jun 17, 2014 at 04:05:31PM -0400, Konrad Rzeszutek Wilk wrote: > > > + * The basic principle of a queue-based spinlock can best be understood > > > + * by studying a classic queue-based spinlock impl

Re: [PATCH 01/11] qspinlock: A simple generic 4-byte queue spinlock

2014-06-27 Thread Konrad Rzeszutek Wilk
On Mon, Jun 23, 2014 at 06:12:00PM +0200, Peter Zijlstra wrote: > On Tue, Jun 17, 2014 at 04:03:29PM -0400, Konrad Rzeszutek Wilk wrote: > > > > + new = tail | (val & _Q_LOCKED_MASK); > > > > + > > > > +

Re: [PATCH 01/11] qspinlock: A simple generic 4-byte queue spinlock

2014-06-27 Thread Konrad Rzeszutek Wilk
On Mon, Jun 23, 2014 at 05:56:50PM +0200, Peter Zijlstra wrote: > On Mon, Jun 16, 2014 at 04:49:18PM -0400, Konrad Rzeszutek Wilk wrote: > > > Index: linux-2.6/kernel/locking/mcs_spinlock.h > > > === > >

Re: [GIT PULL] 2 RAS fixes for 3.17, refreshed

2014-06-27 Thread Konrad Rzeszutek Wilk
On Tue, Jun 24, 2014 at 03:24:39PM +0200, Borislav Petkov wrote: > On Sun, Jun 22, 2014 at 06:46:03PM +0200, Borislav Petkov wrote: > > Hi guys, > > > > please queue this for 3.17. We had it ready earlier but decided to delay > > it for an extra testing period. > > Actually, ignore that one. Here

Re: [Xen-devel] [PATCHv1] x86: don't schedule when handling #NM exception

2014-06-23 Thread Konrad Rzeszutek Wilk
On Wed, Mar 19, 2014 at 08:02:22AM -0700, H. Peter Anvin wrote: > On 03/19/2014 06:21 AM, Konrad Rzeszutek Wilk wrote: > >> > >> The following patch does the always eager allocation. It's a fixup of > >> Suresh's original patch. > >> > > &

Re: [PATCH] swiotlb: Correct kernel command line handler

2014-06-20 Thread Konrad Rzeszutek Wilk
On Wed, Apr 02, 2014 at 01:36:29PM +0900, Jungseok Lee wrote: > On Tuesday, April 01, 2014 9:46 PM, Konrad Rzeszutek Wilk wrote: > > On Tue, Apr 01, 2014 at 10:51:58AM +0900, Jungseok Lee wrote: > > > This patch corrects kernel command line handler when io_tlb_nslabs

Re: [PATCH v3 1/2] xen: vnuma for pv guests

2014-06-20 Thread Konrad Rzeszutek Wilk
On Tue, Jun 03, 2014 at 12:54:39AM -0400, Elena Ufimtseva wrote: > Issues Xen hypercall subop XENMEM_get_vnumainfo and sets the > NUMA topology, otherwise sets dummy NUMA node and prevents > numa_init from calling other numa initializators as they dont > work with pv guests. We should also have a

Re: [PATCH 10/11] qspinlock: Paravirt support

2014-06-20 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 02:47:07PM +0200, Peter Zijlstra wrote: > Add minimal paravirt support. > > The code aims for minimal impact on the native case. Woot! > > On the lock side we add one jump label (asm_goto) and 4 paravirt > callee saved calls that default to NOPs. The only effects are the

Re: [PATCH 05/11] qspinlock: Optimize for smaller NR_CPUS

2014-06-18 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 02:47:02PM +0200, Peter Zijlstra wrote: > From: Peter Zijlstra > > When we allow for a max NR_CPUS < 2^14 we can optimize the pending > wait-acquire and the xchg_tail() operations. > > By growing the pending bit to a byte, we reduce the tail to 16bit. > This means we can

Re: [PATCH 07/11] qspinlock: Use a simple write to grab the lock, if applicable

2014-06-18 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 02:47:04PM +0200, Peter Zijlstra wrote: > From: Waiman Long > > Currently, atomic_cmpxchg() is used to get the lock. However, this is > not really necessary if there is more than one task in the queue and > the queue head don't need to reset the queue code word. For that c

Re: [PATCH 08/11] qspinlock: Revert to test-and-set on hypervisors

2014-06-18 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 02:47:05PM +0200, Peter Zijlstra wrote: > When we detect a hypervisor (!paravirt, see later patches), revert to Please spell out the name of the patches. > a simple test-and-set lock to avoid the horrors of queue preemption. Heheh. > > Signed-off-by: Peter Zijlstra > --

Re: [PATCH 09/11] pvqspinlock, x86: Rename paravirt_ticketlocks_enabled

2014-06-18 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 02:47:06PM +0200, Peter Zijlstra wrote: > From: Waiman Long > > This patch renames the paravirt_ticketlocks_enabled static key to a > more generic paravirt_spinlocks_enabled name. > > Signed-off-by: Waiman Long > Signed-off-by: Peter Zijlst

Re: [PATCH 04/11] qspinlock: Extract out the exchange of tail code word

2014-06-18 Thread Konrad Rzeszutek Wilk
> >>However, I *do* agree with you that it's simpler to just squash this patch > >>into 01/11. > >Uh, did I say that? Oh I said why don't make it right the first time! > > > >I meant in terms of seperating the slowpath (aka the bytelock on the pending > >bit) from the queue (MCS code). Or renaming

Re: [PATCH v5 0/7] xen: Add EFI support

2014-06-18 Thread Konrad Rzeszutek Wilk
On Wed, Jun 18, 2014 at 03:15:41PM +0100, Matt Fleming wrote: > On Fri, 13 Jun, at 07:00:16PM, Daniel Kiper wrote: > > Hey, > > > > This patch series adds EFI support for Xen dom0 guests. > > It is based on Jan Beulich and Tang Liang work. I was > > trying to take into account all previous comment

Re: [PATCH v5 6/7] arch/x86: Remove redundant set_bit() call

2014-06-18 Thread Konrad Rzeszutek Wilk
On Wed, Jun 18, 2014 at 02:56:37PM +0100, Matt Fleming wrote: > On Fri, 13 Jun, at 07:00:22PM, Daniel Kiper wrote: > > Remove redundant set_bit(EFI_SYSTEM_TABLES, &efi.flags) call. > > It is executed earlier in efi_systab_init(). > > > > Signed-off-by: Daniel Kiper > > --- > > arch/x86/platform/

Re: [PATCH 04/11] qspinlock: Extract out the exchange of tail code word

2014-06-18 Thread Konrad Rzeszutek Wilk
On Wed, Jun 18, 2014 at 01:37:45PM +0200, Paolo Bonzini wrote: > Il 17/06/2014 22:55, Konrad Rzeszutek Wilk ha scritto: > >On Sun, Jun 15, 2014 at 02:47:01PM +0200, Peter Zijlstra wrote: > >>From: Waiman Long > >> > >>This patch extracts the logic for t

Re: [PATCH 03/11] qspinlock: Add pending bit

2014-06-18 Thread Konrad Rzeszutek Wilk
On Wed, Jun 18, 2014 at 01:29:48PM +0200, Paolo Bonzini wrote: > Il 17/06/2014 22:36, Konrad Rzeszutek Wilk ha scritto: > >+/* One more attempt - but if we fail mark it as pending. */ > >+if (val == _Q_LOCKED_VAL) { > >+new = Q_LOCKE

Re: [PATCH 03/11] qspinlock: Add pending bit

2014-06-17 Thread Konrad Rzeszutek Wilk
On Jun 17, 2014 6:25 PM, Waiman Long wrote: > > On 06/17/2014 05:10 PM, Konrad Rzeszutek Wilk wrote: > > On Tue, Jun 17, 2014 at 05:07:29PM -0400, Konrad Rzeszutek Wilk wrote: > >> On Tue, Jun 17, 2014 at 04:51:57PM -0400, Waiman Long wrote: > >>> On 06/17/201

Re: [PATCH v11 14/16] pvqspinlock: Add qspinlock para-virtualization support

2014-06-17 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 03:16:54PM +0200, Peter Zijlstra wrote: > On Thu, Jun 12, 2014 at 04:48:41PM -0400, Waiman Long wrote: > > I don't have a good understanding of the kernel alternatives mechanism. > > I didn't either; I do now, cost me a whole day reading up on > alternative/paravirt code pa

Re: [PATCH 04/11] qspinlock: Extract out the exchange of tail code word

2014-06-17 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 02:47:01PM +0200, Peter Zijlstra wrote: > From: Waiman Long > > This patch extracts the logic for the exchange of new and previous tail > code words into a new xchg_tail() function which can be optimized in a > later patch. And also adds a third try on acquiring the lock.

Re: [PATCH 03/11] qspinlock: Add pending bit

2014-06-17 Thread Konrad Rzeszutek Wilk
On Tue, Jun 17, 2014 at 05:07:29PM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Jun 17, 2014 at 04:51:57PM -0400, Waiman Long wrote: > > On 06/17/2014 04:36 PM, Konrad Rzeszutek Wilk wrote: > > >On Sun, Jun 15, 2014 at 02:47:00PM +0200, Peter Zijlstra wrote: > > >>

Re: [PATCH 03/11] qspinlock: Add pending bit

2014-06-17 Thread Konrad Rzeszutek Wilk
On Tue, Jun 17, 2014 at 04:51:57PM -0400, Waiman Long wrote: > On 06/17/2014 04:36 PM, Konrad Rzeszutek Wilk wrote: > >On Sun, Jun 15, 2014 at 02:47:00PM +0200, Peter Zijlstra wrote: > >>Because the qspinlock needs to touch a second cacheline; add a pending > >>bit

Re: [PATCH 03/11] qspinlock: Add pending bit

2014-06-17 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 02:47:00PM +0200, Peter Zijlstra wrote: > Because the qspinlock needs to touch a second cacheline; add a pending > bit and allow a single in-word spinner before we punt to the second > cacheline. Could you add this in the description please: And by second cacheline we mean

Re: [PATCH 01/11] qspinlock: A simple generic 4-byte queue spinlock

2014-06-17 Thread Konrad Rzeszutek Wilk
> + * The basic principle of a queue-based spinlock can best be understood > + * by studying a classic queue-based spinlock implementation called the > + * MCS lock. The paper below provides a good description for this kind > + * of lock. > + * > + * http://www.cise.ufl.edu/tr/DOC/REP-1992-71.pdf >

Re: [PATCH 01/11] qspinlock: A simple generic 4-byte queue spinlock

2014-06-17 Thread Konrad Rzeszutek Wilk
> > + new = tail | (val & _Q_LOCKED_MASK); > > + > > + old = atomic_cmpxchg(&lock->val, val, new); > > + if (old == val) > > + break; > > + > > + val = old; > > + } > > + > > + /* > > +* we won the trylock; forget about queue

Re: [PATCH 00/11] qspinlock with paravirt support

2014-06-16 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 02:46:57PM +0200, Peter Zijlstra wrote: > Since Waiman seems incapable of doing simple things; here's my take on the > paravirt crap. > > The first few patches are taken from Waiman's latest series, but the virt > support is completely new. Its primary aim is to not mess up

Re: [PATCH 01/11] qspinlock: A simple generic 4-byte queue spinlock

2014-06-16 Thread Konrad Rzeszutek Wilk
On Sun, Jun 15, 2014 at 02:46:58PM +0200, Peter Zijlstra wrote: > From: Waiman Long > > This patch introduces a new generic queue spinlock implementation that > can serve as an alternative to the default ticket spinlock. Compared > with the ticket spinlock, this queue spinlock should be almost as

Re: [PATCH v2] xenpv: don't BUG when failing to setup NMI callback

2014-06-16 Thread Konrad Rzeszutek Wilk
gs: ss: e02b cs: e033 > ... > > However it is possible to proceed without NMI callback registered. > > Changes in v2: > - skip nmi in cvt_gate_to_trap() for Xen < 3.2 > - do not call xen_enable_nmi() when running under Xen < 3.2 > - never BUG() in xen_enable_n

Re: [PATCH] xenpv: don't BUG when failing to setup NMI callback

2014-06-13 Thread Konrad Rzeszutek Wilk
On Fri, Jun 13, 2014 at 01:26:28PM +0200, Vitaly Kuznetsov wrote: > some old Xen hypervisors (prior to 3.2) forbid DomUs to register > NMI callbacks. E.g. we have the following code in xen-3.1: > > if ( (d->domain_id != 0) || (v->vcpu_id != 0) ) > return -EINVAL; > > Commit 6efa20e49b

Re: [PATCH 3/5] gpu/drm/ttm: Use mutex_trylock() to avoid deadlock inside shrinker functions.

2014-06-10 Thread Konrad Rzeszutek Wilk
On Sat, May 31, 2014 at 12:00:45PM +0900, Tetsuo Handa wrote: > >From 4e8d1a83629c5966bfd401c5f2187355624194f2 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Sat, 31 May 2014 09:59:44 +0900 > Subject: [PATCH 3/5] gpu/drm/ttm: Use mutex_trylock() to avoid deadlock > inside shrinker function

Re: [PATCH] xen/setup: Remap Xen Identity Mapped RAM

2014-06-10 Thread Konrad Rzeszutek Wilk
On Thu, Jun 05, 2014 at 11:43:14AM -0700, Matt Rushton wrote: > Instead of ballooning up and down dom0 memory this remaps the existing mfns > that were replaced by the identity map. The reason for this is that the > existing implementation ballooned memory up and and down which caused dom0 > to hav

Re: [PATCH v2 3/3] x86, platform, xen, kconfig: add xen defconfig helper

2014-06-09 Thread Konrad Rzeszutek Wilk
a guest > kernel configuration but upon review with the xen team > since we don't have many dom0 options its best to just > combine these two into one. Both patches look good to me. If you want to add Acked-by: Konrad Rzeszutek Wilk please go ahead. > > Cc: Borislav

Re: Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-06-06 Thread Konrad Rzeszutek Wilk
On Fri, Jun 06, 2014 at 06:56:57AM -0700, Greg KH wrote: > On Fri, Jun 06, 2014 at 12:47:07PM +0200, Jiri Slaby wrote: > > On 06/04/2014 07:48 AM, Greg KH wrote: > > > On Wed, May 14, 2014 at 03:11:22PM -0400, Konrad Rzeszutek Wilk wrote: > > >> Hey Greg > > &

Re: [PATCH] gpu/drm/ttm: Use mutex_lock_killable() for shrinker functions.

2014-05-30 Thread Konrad Rzeszutek Wilk
On Thu, May 29, 2014 at 11:34:59PM +0900, Tetsuo Handa wrote: > Tetsuo Handa wrote: > > Konrad Rzeszutek Wilk wrote: > > > On Sat, May 24, 2014 at 11:22:09PM +0900, Tetsuo Handa wrote: > > > > Hello. > > > > > > > > I tried to test

Re: [PATCH] gpu/drm/ttm: Use mutex_lock_killable() for shrinker functions.

2014-05-30 Thread Konrad Rzeszutek Wilk
On Thu, May 29, 2014 at 06:47:49AM +0900, Tetsuo Handa wrote: > Konrad Rzeszutek Wilk wrote: > > On Sat, May 24, 2014 at 11:22:09PM +0900, Tetsuo Handa wrote: > > > Hello. > > > > > > I tried to test whether it is OK (from point of view of ree

Re: [PATCH] gpu/drm/ttm: Use mutex_lock_killable() for shrinker functions.

2014-05-28 Thread Konrad Rzeszutek Wilk
On Sat, May 24, 2014 at 11:22:09PM +0900, Tetsuo Handa wrote: > Hello. > > I tried to test whether it is OK (from point of view of reentrant) to use > mutex_lock() or mutex_lock_killable() inside shrinker functions when shrinker > functions do memory allocation, for drivers/gpu/drm/ttm/ttm_page_al

[GIT PULL] (xen) stable/for-jens-3.16

2014-05-28 Thread Konrad Rzeszutek Wilk
Dear Jens, Please git pull the following branch: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git stable/for-jens-3.16 which has a bunch of fixes to the Xen block frontend and backend driver and a new parameter for Xen backend driver - an override (set by the toolstack) whether to expo

Re: [PATCH RESEND 0/3] xen-block: changes for discard support

2014-05-23 Thread Konrad Rzeszutek Wilk
On Wed, May 21, 2014 at 04:32:39PM +0200, Olaf Hering wrote: > Fix blkfront to handle all sorts of backends. > > Also let blkback recognize a xenstore property to disable discard for a > given device. This part requires libxl changes ("discard-enable"): > http://lists.xenproject.org/archives/html/

Re: [PATCH] xen-blkfront: check feature-persitent on resume

2014-05-23 Thread Konrad Rzeszutek Wilk
On Thu, May 22, 2014 at 04:40:07PM +0200, Roger Pau Monne wrote: > We are missing a check to see if the backend supports persistent > grants on resume, meaning we will always run with the value fetched > from the firsts host on which we run on. > > Signed-off-by: Roger Pau Monn

Re: [PATCH] gpu/drm/ttm: Pass GFP flags in order to avoid deadlock.

2014-05-20 Thread Konrad Rzeszutek Wilk
On Tue, May 20, 2014 at 01:40:40AM +0100, Dave Airlie wrote: > > cc'ing dri-devel. It looks pretty simple and correct . I can test it tomorrow and make sure it works right. > > > >From d0d57745ba23faf605b0f249b57d283fe1a8ee60 Mon Sep 17 00:00:00 2001 > > From: Tetsuo Handa > > Date: Mon, 19 Ma

Re: [PATCH v2] PCI: Introduce new device binding path using pci_dev.driver_override

2014-05-16 Thread Konrad Rzeszutek Wilk
On Fri, May 16, 2014 at 10:48:00AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, May 9, 2014 at 12:50 PM, Alex Williamson > wrote: > > > The driver_override field allows us to specify the driver for a device > > ... > > > ... > > > Signed-off-by: Alex

Backport request to stable of two performance related fixes for xen-blkfront (3.13 fixes to earlier trees)

2014-05-14 Thread Konrad Rzeszutek Wilk
Hey Greg This email is in regards to backporting two patches to stable that fall under the 'performance' rule: bfe11d6de1c416cea4f3f0f35f864162063ce3fa fbe363c476afe8ec992d3baf682670a4bd1b6ce6 I've copied Jerry - the maintainer of the Oracle's kernel. I don't have the emails of the other distr

[GIT PULL] (ibft) stable/for-linus-3.15-rc5-tag

2014-05-13 Thread Konrad Rzeszutek Wilk
Hey Linus, Please git pull the following tag at your leisure: git pull git://git.kernel.org/pub/scm/linux/kernel/git/konrad/ibft.git stable/for-linus-3.15-rc5-tag which has an regression introduced way back in v3.2. The Broadcom NICs offer an iBFT feature - but they use a non-standard identi

Re: [PATCH 0/2] dma,x86,xen: fix dma_get_required_mask() when dma != phys address

2014-05-12 Thread Konrad Rzeszutek Wilk
1 is a straight forward refactoring of a common function. > > Patch #2 addes the required arch-specific implementation of > dma_get_required_mask() to x86. David, Thank you for taking a look at that. If you would like, you can tack on Reviewed-by: Konrad Rzeszutek Wilk And with the *SWIOTLB

Re: [PATCH v10 18/19] pvqspinlock, x86: Enable PV qspinlock PV for KVM

2014-05-07 Thread Konrad Rzeszutek Wilk
> Raghavendra KT had done some performance testing on this patch with > the following results: > > Overall we are seeing good improvement for pv-unfair version. > > System: 32 cpu sandybridge with HT on (4 node with 32 GB each) > Guest : 8GB with 16 vcpu/VM. > Average was taken over 8-10 data poi

Re: [PATCH v10 00/19] qspinlock: a 4-byte queue spinlock with PV support

2014-05-07 Thread Konrad Rzeszutek Wilk
On Wed, May 07, 2014 at 11:01:28AM -0400, Waiman Long wrote: > v9->v10: > - Make some minor changes to qspinlock.c to accommodate review feedback. > - Change author to PeterZ for 2 of the patches. > - Include Raghavendra KT's test results in patch 18. Any chance you can post these on a git t

[PATCH v1 2/6] xen-pciback: First reset, then free.

2014-04-30 Thread Konrad Rzeszutek Wilk
We were doing the operations of freeing and reset in the wrong order. Granted nothing broke because the reset functions just set bar->which = 0. But nonethless this was incorrect. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Jan Beulich --- drivers/xen/xen-pciback/pci_stub.c | 2 +-

[PATCH v1 3/6] xen-pciback: Document when we FLR an PCI device.

2014-04-30 Thread Konrad Rzeszutek Wilk
next guest. Signed-off-by: Konrad Rzeszutek Wilk --- drivers/xen/xen-pciback/pci_stub.c | 2 ++ drivers/xen/xen-pciback/xenbus.c | 4 2 files changed, 6 insertions(+) diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c index 36dd4f3..b84426a 100644

[PATCH v1 4/6] xen/pciback: Document when the 'unbind' and 'bind' functions are called.

2014-04-30 Thread Konrad Rzeszutek Wilk
And also mention that you cannot do any pci_reset_function, pci_reset_slot, or such calls. This is because they take the same lock as SysFS does - and we would end up with a dead-lock if we call those functions. Signed-off-by: Konrad Rzeszutek Wilk --- drivers/xen/xen-pciback/pci_stub.c | 4

[PATCH v1 6/6] xen/pciback: Don't call xen_pcibk_config_init_dev when device de-assigned.

2014-04-30 Thread Konrad Rzeszutek Wilk
calling pcistub_device_release which does this. Signed-off-by: Konrad Rzeszutek Wilk --- drivers/xen/xen-pciback/pci_stub.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c index d57a173..158d53df 100644 --- a/drivers/xen

[PATCH v1 5/6] xen/pciback: Document the entry points for 'pcistub_put_pci_dev'

2014-04-30 Thread Konrad Rzeszutek Wilk
which are quite a few. It should be evident that dealing with that many options is a bit complex. Signed-off-by: Konrad Rzeszutek Wilk --- drivers/xen/xen-pciback/pci_stub.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen

[PATCH v1] Documentation and two bug-fixes for Xen pciback.

2014-04-30 Thread Konrad Rzeszutek Wilk
ay is the documentation day! drivers/xen/xen-pciback/pci_stub.c | 25 +++-- drivers/xen/xen-pciback/xenbus.c | 4 2 files changed, 23 insertions(+), 6 deletions(-) Konrad Rzeszutek Wilk (6): xen-pciback: Cleanup up pcistub_put_pci_dev xen-pciback: First

[PATCH v1 1/6] xen-pciback: Cleanup up pcistub_put_pci_dev

2014-04-30 Thread Konrad Rzeszutek Wilk
We are using 'psdev->dev','found_psdev->dev', and 'dev' at the same time - and they all point to the same structure. To keep it straight lets just use one - 'dev'. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Jan Beulich --- drivers/xen/

Re: [PATCH 3/7] x86: Add C intrinsics for new rd/wr fs/gs base instructions

2014-04-29 Thread Konrad Rzeszutek Wilk
On Mon, Apr 28, 2014 at 03:12:37PM -0700, Andi Kleen wrote: > From: Andi Kleen > > Plus for swapgs. > > Very straight forward. Used in followon patch. follow on > > Signed-off-by: Andi Kleen > --- > arch/x86/include/asm/fsgs.h | 43 +++ > 1 file change

Re: [PATCH] x86-64: espfix for 64-bit mode *PROTOTYPE*

2014-04-28 Thread Konrad Rzeszutek Wilk
On Wed, Apr 23, 2014 at 09:56:00AM -0700, H. Peter Anvin wrote: > On 04/23/2014 07:24 AM, Boris Ostrovsky wrote: > >> > >> Konrad - I really could use some help figuring out what needs to be done > >> for this not to break Xen. > > > > This does break Xen PV: > > > > I know it does. This is why

Re: [PATCH] x86-64: espfix for 64-bit mode *PROTOTYPE*

2014-04-25 Thread Konrad Rzeszutek Wilk
On Tue, Apr 22, 2014 at 06:17:21PM -0700, H. Peter Anvin wrote: > Another spin of the prototype. This one avoids the espfix for anything > but #GP, and avoids save/restore/saving registers... one can wonder, > though, how much that actually matters in practice. > > It still does redundant SWAPGS

Re: [PATCH v9 05/19] qspinlock: Optimize for smaller NR_CPUS

2014-04-23 Thread Konrad Rzeszutek Wilk
On Wed, Apr 23, 2014 at 01:43:58PM -0400, Waiman Long wrote: > On 04/23/2014 10:56 AM, Konrad Rzeszutek Wilk wrote: > >On Wed, Apr 23, 2014 at 10:23:43AM -0400, Waiman Long wrote: > >>On 04/18/2014 05:40 PM, Waiman Long wrote: > >>>On 04/18/2014 03:05 PM, Peter Zijlst

Re: [PATCH v9 05/19] qspinlock: Optimize for smaller NR_CPUS

2014-04-23 Thread Konrad Rzeszutek Wilk
On Wed, Apr 23, 2014 at 10:23:43AM -0400, Waiman Long wrote: > On 04/18/2014 05:40 PM, Waiman Long wrote: > >On 04/18/2014 03:05 PM, Peter Zijlstra wrote: > >>On Fri, Apr 18, 2014 at 01:52:50PM -0400, Waiman Long wrote: > >>>I am confused by your notation. > >>Nah, I think I was confused :-) Make t

Re: [XEN PATCH 1/2] hvm: Support more than 32 VCPUS when migrating.

2014-04-22 Thread Konrad Rzeszutek Wilk
On Wed, Apr 09, 2014 at 04:36:53PM +0100, Jan Beulich wrote: > >>> On 09.04.14 at 17:27, wrote: > > On Wed, Apr 09, 2014 at 10:06:12AM +0100, Jan Beulich wrote: > >> >>> On 08.04.14 at 19:25, wrote: > >> > --- a/xen/arch/x86/hvm/hvm.c > >> > +++ b/xen/arch/x86/hvm/hvm.c > >> > @@ -3470,6 +3470,9

Re: [PATCH v9 03/19] qspinlock: Add pending bit

2014-04-18 Thread Konrad Rzeszutek Wilk
On Fri, Apr 18, 2014 at 12:23:29PM -0400, Waiman Long wrote: > On 04/18/2014 03:42 AM, Ingo Molnar wrote: > >* Waiman Long wrote: > > > >>Because the qspinlock needs to touch a second cacheline; add a pending > >>bit and allow a single in-word spinner before we punt to the second > >>cacheline. >

Re: [PATCH v9 00/19] qspinlock: a 4-byte queue spinlock with PV support

2014-04-18 Thread Konrad Rzeszutek Wilk
On Thu, Apr 17, 2014 at 09:48:36PM -0400, Waiman Long wrote: > On 04/17/2014 01:23 PM, Konrad Rzeszutek Wilk wrote: > >On Thu, Apr 17, 2014 at 11:03:52AM -0400, Waiman Long wrote: > >>v8->v9: > >> - Integrate PeterZ's version of the queue spinlock pa

Re: [PATCH v9 00/19] qspinlock: a 4-byte queue spinlock with PV support

2014-04-17 Thread Konrad Rzeszutek Wilk
On Thu, Apr 17, 2014 at 11:03:52AM -0400, Waiman Long wrote: > v8->v9: > - Integrate PeterZ's version of the queue spinlock patch with some > modification: > http://lkml.kernel.org/r/20140310154236.038181...@infradead.org > - Break the more complex patches into smaller ones to ease revi

Re: [PATCH] xen/pci: Remove unused dev_err() string

2014-04-15 Thread Konrad Rzeszutek Wilk
On Tue, Apr 15, 2014 at 02:29:16PM +0100, David Vrabel wrote: > On 15/04/14 14:03, Konrad Rzeszutek Wilk wrote: > > On Mon, Apr 14, 2014 at 04:25:23PM -0600, Bjorn Helgaas wrote: > >> We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or > >>

Re: [PATCH] xen/pci: Remove unused dev_err() string

2014-04-15 Thread Konrad Rzeszutek Wilk
On Mon, Apr 14, 2014 at 04:25:23PM -0600, Bjorn Helgaas wrote: > We previously verified that "action" is either BUS_NOTIFY_ADD_DEVICE or > BUS_NOTIFY_DEL_DEVICE, so there's no need for the default "?" case. > > Found by Coverity (CID 146520). Reviewed-by: K

Re: [Xen-devel] [XEN PATCH 1/2] hvm: Support more than 32 VCPUS when migrating.

2014-04-09 Thread Konrad Rzeszutek Wilk
On Wed, Apr 09, 2014 at 04:38:37PM +0100, David Vrabel wrote: > On 09/04/14 16:34, Konrad Rzeszutek Wilk wrote: > > On Wed, Apr 09, 2014 at 09:37:01AM +0200, Roger Pau Monné wrote: > >> On 08/04/14 20:53, Konrad Rzeszutek Wilk wrote: > >>> On Tue, Apr 08, 2014 at 08:

Re: [Xen-devel] [XEN PATCH 1/2] hvm: Support more than 32 VCPUS when migrating.

2014-04-09 Thread Konrad Rzeszutek Wilk
On Wed, Apr 09, 2014 at 09:37:01AM +0200, Roger Pau Monné wrote: > On 08/04/14 20:53, Konrad Rzeszutek Wilk wrote: > > On Tue, Apr 08, 2014 at 08:18:48PM +0200, Roger Pau Monné wrote: > >> On 08/04/14 19:25, kon...@kernel.org wrote: > >>> From: Konrad Rzeszutek Wilk

Re: [XEN PATCH 1/2] hvm: Support more than 32 VCPUS when migrating.

2014-04-09 Thread Konrad Rzeszutek Wilk
On Wed, Apr 09, 2014 at 10:06:12AM +0100, Jan Beulich wrote: > >>> On 08.04.14 at 19:25, wrote: > > --- a/xen/arch/x86/hvm/hvm.c > > +++ b/xen/arch/x86/hvm/hvm.c > > @@ -3470,6 +3470,9 @@ static long hvm_vcpu_op( > > case VCPUOP_stop_singleshot_timer: > > case VCPUOP_register_vcpu_info:

Re: [PATCH 2/3] x86: Define _PAGE_NUMA with unused physical address bits PMD and PTE levels

2014-04-09 Thread Konrad Rzeszutek Wilk
On Tue, Apr 08, 2014 at 05:51:23PM +0100, Mel Gorman wrote: > On Tue, Apr 08, 2014 at 12:02:50PM -0400, Konrad Rzeszutek Wilk wrote: > > .snip.. > > > >>> David Vrabel has a patchset which I presumed would be pulled through > > > >t

Re: [PATCH 2/3] x86: Define _PAGE_NUMA with unused physical address bits PMD and PTE levels

2014-04-09 Thread Konrad Rzeszutek Wilk
On Tue, Apr 08, 2014 at 01:59:09PM -0700, H. Peter Anvin wrote: > On 04/08/2014 01:51 PM, Steven Noonan wrote: > > On Tue, Apr 8, 2014 at 8:16 AM, H. Peter Anvin wrote: > >> > >> > >> Of course, it would also be preferable if Amazon (or anything else) didn't > >> need Xen PV :( > > > > Well Ama

Re: [LINUX PATCH 2/2] xen/pvhvm: Support more than 32 VCPUs when migrating.

2014-04-09 Thread Konrad Rzeszutek Wilk
On Apr 9, 2014 4:03 AM, Jan Beulich wrote: > > >>> On 08.04.14 at 19:25, wrote: > > + /* Only Xen 4.5 and higher supports this. */ > > + if (HYPERVISOR_vcpu_op(VCPUOP_is_up, smp_processor_id(), NULL) == > > -ENOSYS) > > + vcpuops = false; > > Did you mean to say "for HVM guests" in the comm

Re: [Xen-devel] [XEN PATCH 1/2] hvm: Support more than 32 VCPUS when migrating.

2014-04-08 Thread Konrad Rzeszutek Wilk
On Tue, Apr 08, 2014 at 08:18:48PM +0200, Roger Pau Monné wrote: > On 08/04/14 19:25, kon...@kernel.org wrote: > > From: Konrad Rzeszutek Wilk > > > > When we migrate an HVM guest, by default our shared_info can > > only hold up to 32 CPUs. As such the hypercall > &

Re: [PATCH 2/3] x86: Define _PAGE_NUMA with unused physical address bits PMD and PTE levels

2014-04-08 Thread Konrad Rzeszutek Wilk
.snip.. > >>> David Vrabel has a patchset which I presumed would be pulled through > >the > >>> Xen tree this merge window: > >>> > >>> [PATCHv5 0/8] x86/xen: fixes for mapping high MMIO regions (and > >remove > >>> _PAGE_IOMAP) > >>> > >>> That frees up this bit. > >>> > >> > >> Thanks, I was not

Re: [PATCH 2/2] xen/manage: Poweroff forcefully if user-space is not yet up.

2014-04-07 Thread Konrad Rzeszutek Wilk
On Mon, Apr 07, 2014 at 06:19:32PM +0100, David Vrabel wrote: > On 04/04/14 19:53, Konrad Rzeszutek Wilk wrote: > > The user can launch the guest in this sequence: > > > > xl create -p /vm.cfg[launch, but pause it] > > xl shutdown latest [sets control/shutdo

Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation

2014-04-07 Thread Konrad Rzeszutek Wilk
On Mon, Apr 07, 2014 at 04:12:58PM +0200, Peter Zijlstra wrote: > On Fri, Apr 04, 2014 at 12:57:27PM -0400, Konrad Rzeszutek Wilk wrote: > > On Fri, Apr 04, 2014 at 03:00:12PM +0200, Peter Zijlstra wrote: > > > > > > So I'm just not ever going to pick up this patch

Re: [PATCH 1/2] xen/xenbus: Avoid synchronous wait on XenBus stalling shutdown/restart.

2014-04-04 Thread Konrad Rzeszutek Wilk
On Fri, Apr 04, 2014 at 04:35:27PM -0400, Boris Ostrovsky wrote: > On 04/04/2014 02:53 PM, Konrad Rzeszutek Wilk wrote: > >The 'read_reply' works with 'process_msg' to read of a reply in XenBus. > >'process_msg' is running from within the 'xenbus

[PATCH 2/2] xen/manage: Poweroff forcefully if user-space is not yet up.

2014-04-04 Thread Konrad Rzeszutek Wilk
27; and we will try to act on them instead of ignoring them. Fixes-Bug: http://bugs.xenproject.org/xen/bug/6 Reported-by: Alex Bligh Signed-off-by: Konrad Rzeszutek Wilk [v2: Add switch statement] [v3: Add a reboot notifier] --- drivers/xen/manage.c | 32 ++--

[PATCH] Bug-fixes for 3.15 related to 'xl shutdown' and hanging the initial domain reboot.

2014-04-04 Thread Konrad Rzeszutek Wilk
++--- 2 files changed, 71 insertions(+), 5 deletions(-) Konrad Rzeszutek Wilk (2): xen/xenbus: Avoid synchronous wait on XenBus stalling shutdown/restart. xen/manage: Poweroff forcefully if user-space is not yet up. -- To unsubscribe from this list: send the line "unsub

[PATCH 1/2] xen/xenbus: Avoid synchronous wait on XenBus stalling shutdown/restart.

2014-04-04 Thread Konrad Rzeszutek Wilk
he right domain. If it is an initial domain and hurtling towards death - there is no point of continuing the wait. All other type of guests continue with their behavior. mechanism a bit more asynchronous. Fixes-Bug: http://bugs.xenproject.org/xen/bug/8 Signed-off-by: Konrad Rzeszutek Wil

Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support

2014-04-04 Thread Konrad Rzeszutek Wilk
On Fri, Apr 04, 2014 at 01:58:15PM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Apr 04, 2014 at 01:13:17PM -0400, Waiman Long wrote: > > On 04/04/2014 12:55 PM, Konrad Rzeszutek Wilk wrote: > > >On Thu, Apr 03, 2014 at 10:57:18PM -0400, Waiman Long wrote: > > >>

Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support

2014-04-04 Thread Konrad Rzeszutek Wilk
On Fri, Apr 04, 2014 at 01:13:17PM -0400, Waiman Long wrote: > On 04/04/2014 12:55 PM, Konrad Rzeszutek Wilk wrote: > >On Thu, Apr 03, 2014 at 10:57:18PM -0400, Waiman Long wrote: > >>On 04/03/2014 01:23 PM, Konrad Rzeszutek Wilk wrote: > >>>On Wed, Apr 02, 2014 at

Re: [PATCH] xen-blkback: only attach blkback if the required features are met

2014-04-04 Thread Konrad Rzeszutek Wilk
d you point to the git commit that introduces it in the patch please? > > Signed-off-by: Roger Pau Monné > Cc: Konrad Rzeszutek Wilk > Cc: David Vrabel > Cc: Boris Ostrovsky > --- > drivers/block/xen-blkback/blkback.c | 12 > include/xen/interface/features

Re: [PATCH v8 01/10] qspinlock: A generic 4-byte queue spinlock implementation

2014-04-04 Thread Konrad Rzeszutek Wilk
On Fri, Apr 04, 2014 at 03:00:12PM +0200, Peter Zijlstra wrote: > > So I'm just not ever going to pick up this patch; I spend a week trying > to reverse engineer this; I posted a 7 patch series creating the > equivalent, but in a gradual and readable fashion: > > http://lkml.kernel.org/r/201403

Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support

2014-04-04 Thread Konrad Rzeszutek Wilk
On Thu, Apr 03, 2014 at 10:57:18PM -0400, Waiman Long wrote: > On 04/03/2014 01:23 PM, Konrad Rzeszutek Wilk wrote: > >On Wed, Apr 02, 2014 at 10:10:17PM -0400, Waiman Long wrote: > >>On 04/02/2014 04:35 PM, Waiman Long wrote: > >>>On 04/02/2014 10:32 AM, Konrad Rzes

Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support

2014-04-04 Thread Konrad Rzeszutek Wilk
On Wed, Apr 02, 2014 at 10:32:01AM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Apr 02, 2014 at 09:27:29AM -0400, Waiman Long wrote: > > N.B. Sorry for the duplicate. This patch series were resent as the > > original one was rejected by the vger.kernel.org list server >

Re: [PATCH] Fixes to Linux v3.13 - bugs.xenproject.org ones. (v1).

2014-04-03 Thread Konrad Rzeszutek Wilk
On Thu, Apr 03, 2014 at 12:59:00PM +0100, David Vrabel wrote: > On 08/11/13 17:38, Konrad Rzeszutek Wilk wrote: > > Hey, > > > > Two of these: > > [PATCH 2/4] xen/manage: Poweroff forcefully if user-space is not yet > > [PATCH 4/4] xen/xenbus: Avoid sy

Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support

2014-04-03 Thread Konrad Rzeszutek Wilk
On Wed, Apr 02, 2014 at 10:10:17PM -0400, Waiman Long wrote: > On 04/02/2014 04:35 PM, Waiman Long wrote: > >On 04/02/2014 10:32 AM, Konrad Rzeszutek Wilk wrote: > >>On Wed, Apr 02, 2014 at 09:27:29AM -0400, Waiman Long wrote: > >>>N.B. Sorry for the duplicate. This p

Re: [PATCH v8 10/10] pvqspinlock, x86: Enable qspinlock PV support for XEN

2014-04-02 Thread Konrad Rzeszutek Wilk
> diff --git a/kernel/Kconfig.locks b/kernel/Kconfig.locks > index a70fdeb..451e392 100644 > --- a/kernel/Kconfig.locks > +++ b/kernel/Kconfig.locks > @@ -229,4 +229,4 @@ config ARCH_USE_QUEUE_SPINLOCK > > config QUEUE_SPINLOCK > def_bool y if ARCH_USE_QUEUE_SPINLOCK > - depends on SMP

Re: [PATCH v8 00/10] qspinlock: a 4-byte queue spinlock with PV support

2014-04-02 Thread Konrad Rzeszutek Wilk
On Wed, Apr 02, 2014 at 09:27:29AM -0400, Waiman Long wrote: > N.B. Sorry for the duplicate. This patch series were resent as the > original one was rejected by the vger.kernel.org list server > due to long header. There is no change in content. > > v7->v8: > - Remove one unneeded atom

Re: [PATCH 2/4] xen/manage: Poweroff forcefully if user-space is not yet up.

2014-04-01 Thread Konrad Rzeszutek Wilk
On Thu, Nov 21, 2013 at 11:33:49AM +, David Vrabel wrote: > On 08/11/13 17:38, Konrad Rzeszutek Wilk wrote: > > The user can launch the guest in this sequence: > > > > xl create -p /vm.cfg[launch, but pause it] > > xl shutdown latest [sets control/shutdo

Re: [PATCH 3/4] xen/manage: Guard against user-space initiated poweroff and XenBus.

2014-04-01 Thread Konrad Rzeszutek Wilk
On Tue, Apr 01, 2014 at 02:18:02PM +0100, David Vrabel wrote: > On 08/11/13 17:38, Konrad Rzeszutek Wilk wrote: > > There is a race case where the user does 'poweroff' > > and at the same time the system admin does 'xl shutdown'. > > > >

Re: [PATCH] swiotlb: Correct kernel command line handler

2014-04-01 Thread Konrad Rzeszutek Wilk
On Tue, Apr 01, 2014 at 10:51:58AM +0900, Jungseok Lee wrote: > This patch corrects kernel command line handler when io_tlb_nslabs > is set to 0. > > A current implementation allocates default size memory (64MB) when > 0 is given to io_tlb_nslabs ("swiotlb=0") by kernel command line. > In other wo

Re: [Xen-devel] [PATCH 4/4] xen/xenbus: Avoid synchronous wait on XenBus stalling shutdown/restart.

2014-03-31 Thread Konrad Rzeszutek Wilk
On Mon, Dec 02, 2013 at 11:41:57AM +, David Vrabel wrote: > On 26/11/13 16:50, Konrad Rzeszutek Wilk wrote: > > On Thu, Nov 21, 2013 at 05:52:28PM +, David Vrabel wrote: > >> On 08/11/13 17:38, Konrad Rzeszutek Wilk wrote: > >>> The 'read_reply' wor

Re: [PATCH 3/4] xen/manage: Guard against user-space initiated poweroff and XenBus.

2014-03-31 Thread Konrad Rzeszutek Wilk
On Mon, Dec 02, 2013 at 11:27:40AM +, David Vrabel wrote: > On 26/11/13 16:45, Konrad Rzeszutek Wilk wrote: > > On Thu, Nov 21, 2013 at 11:09:52AM +, David Vrabel wrote: > >> On 08/11/13 17:38, Konrad Rzeszutek Wilk wrote: > >>> There is a race case where the

<    5   6   7   8   9   10   11   12   13   14   >